22bba5f377
Change-Id: I938deef90c8d6ceb0e72ab3f6ee2cbddc6f72b8d Reviewed-on: https://gerrit.libreoffice.org/47730 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
116 lines
4.1 KiB
C++
116 lines
4.1 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*/
|
|
|
|
#include <array>
|
|
#include <unordered_map>
|
|
|
|
struct XXX {
|
|
~XXX() {}
|
|
};
|
|
|
|
class Foo1 {
|
|
XXX* m_pbar; // expected-note {{member is here [loplugin:useuniqueptr]}}
|
|
~Foo1()
|
|
{
|
|
delete m_pbar; // expected-error {{unconditional call to delete on a member, should be using std::unique_ptr [loplugin:useuniqueptr]}}
|
|
m_pbar = nullptr;
|
|
}
|
|
};
|
|
|
|
|
|
class Foo2 {
|
|
char* m_pbar1; // expected-note {{member is here [loplugin:useuniqueptr]}}
|
|
char* m_pbar2; // expected-note {{member is here [loplugin:useuniqueptr]}}
|
|
~Foo2()
|
|
{
|
|
delete[] m_pbar1; // expected-error {{unconditional call to delete on a member, should be using std::unique_ptr [loplugin:useuniqueptr]}}
|
|
delete[] m_pbar2; // expected-error {{unconditional call to delete on a member, should be using std::unique_ptr [loplugin:useuniqueptr]}}
|
|
}
|
|
};
|
|
|
|
class Foo3 {
|
|
char* m_pbar;
|
|
bool bMine;
|
|
~Foo3()
|
|
{
|
|
if (bMine)
|
|
delete[] m_pbar;
|
|
}
|
|
};
|
|
|
|
class Class4 {
|
|
int* m_pbar[10]; // expected-note {{member is here [loplugin:useuniqueptr]}}
|
|
~Class4()
|
|
{
|
|
for (int i = 0; i < 10; ++i)
|
|
delete m_pbar[i]; // expected-error {{rather manage with std::some_container<std::unique_ptr<T>> [loplugin:useuniqueptr]}}
|
|
}
|
|
};
|
|
class Class5 {
|
|
int* m_pbar[10]; // expected-note {{member is here [loplugin:useuniqueptr]}}
|
|
~Class5()
|
|
{
|
|
for (auto p : m_pbar)
|
|
delete p; // expected-error {{rather manage with std::some_container<std::unique_ptr<T>> [loplugin:useuniqueptr]}}
|
|
}
|
|
};
|
|
class Class6 {
|
|
std::array<int*,10> m_pbar; // expected-note {{member is here [loplugin:useuniqueptr]}}
|
|
~Class6()
|
|
{
|
|
for (auto p : m_pbar)
|
|
delete p; // expected-error {{rather manage with std::some_container<std::unique_ptr<T>> [loplugin:useuniqueptr]}}
|
|
}
|
|
};
|
|
class Class7 {
|
|
std::array<int*,10> m_pbar; // expected-note {{member is here [loplugin:useuniqueptr]}}
|
|
~Class7()
|
|
{
|
|
for (int i = 0; i < 10; ++i)
|
|
delete m_pbar[i]; // expected-error {{rather manage with std::some_container<std::unique_ptr<T>> [loplugin:useuniqueptr]}}
|
|
}
|
|
};
|
|
// don't warn for maps, MSVC 2015 has problems with mixing std::map/std::unordered_map and std::unique_ptr
|
|
class Class8 {
|
|
std::unordered_map<int, int*> m_pbar;
|
|
~Class8()
|
|
{
|
|
for (auto i : m_pbar)
|
|
delete i.second;
|
|
}
|
|
};
|
|
class Foo8 {
|
|
XXX* m_pbar1; // expected-note {{member is here [loplugin:useuniqueptr]}}
|
|
XXX* m_pbar2; // expected-note {{member is here [loplugin:useuniqueptr]}}
|
|
~Foo8()
|
|
{
|
|
delete m_pbar1; // expected-error {{unconditional call to delete on a member, should be using std::unique_ptr [loplugin:useuniqueptr]}}
|
|
delete m_pbar2; // expected-error {{unconditional call to delete on a member, should be using std::unique_ptr [loplugin:useuniqueptr]}}
|
|
}
|
|
};
|
|
class Foo9 {
|
|
XXX* m_pbar1; // expected-note {{member is here [loplugin:useuniqueptr]}}
|
|
XXX* m_pbar2; // expected-note {{member is here [loplugin:useuniqueptr]}}
|
|
XXX* m_pbar3; // expected-note {{member is here [loplugin:useuniqueptr]}}
|
|
~Foo9()
|
|
{
|
|
if (m_pbar1)
|
|
{
|
|
delete m_pbar1; // expected-error {{unconditional call to delete on a member, should be using std::unique_ptr [loplugin:useuniqueptr]}}
|
|
}
|
|
if (m_pbar2 != nullptr)
|
|
{
|
|
delete m_pbar2; // expected-error {{unconditional call to delete on a member, should be using std::unique_ptr [loplugin:useuniqueptr]}}
|
|
}
|
|
if (m_pbar3 != nullptr)
|
|
delete m_pbar3; // expected-error {{unconditional call to delete on a member, should be using std::unique_ptr [loplugin:useuniqueptr]}}
|
|
}
|
|
};
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
|