7e403195e5
...with a boost::optional fallback for Xcode < 10 (as std::optional is only
available starting with Xcode 10 according to
<https://en.cppreference.com/w/cpp/compiler_support>, and our baseline for iOS
and macOS is still Xcode 9.3 according to README.md). And mechanically rewrite
all code to use o3tl::optional instead of boost::optional.
One immediate benefit is that disabling -Wmaybe-uninitialized for GCC as per
fed7c3deb3 "Slience bogus
-Werror=maybe-uninitialized" should no longer be necessary (and whose check
happened to no longer trigger for GCC 10 trunk, even though that compiler would
still emit bogus -Wmaybe-uninitialized for uses of boost::optional under
--enable-optimized, which made me ponder whether this switch from
boost::optional to std::optional would be a useful thing to do; I keep that
configure.ac check for now, though, and will only remove it in a follow up
commit).
Another longer-term benefit is that the code is now already in good shape for an
eventual switch to std::optional (a switch we would have done anyway once we no
longer need to support Xcode < 10).
Only desktop/qa/desktop_lib/test_desktop_lib.cxx heavily uses
boost::property_tree::ptree::get_child_optional returning boost::optional, so
let it keep using boost::optional for now.
After a number of preceding commits have paved the way for this change, this
commit is completely mechanical, done with
> git ls-files -z | grep -vz -e '^bin/find-unneeded-includes$' -e '^configure.ac$' -e '^desktop/qa/desktop_lib/test_desktop_lib.cxx$' -e '^dictionaries$' -e '^external/' -e '^helpcontent2$' -e '^include/IwyuFilter_include.yaml$' -e '^sc/IwyuFilter_sc.yaml$' -e '^solenv/gdb/boost/optional.py$' -e '^solenv/vs/LibreOffice.natvis$' -e '^translations$' -e '\.svg$' | xargs -0 sed -i -E -e 's|\<boost(/optional)?/optional\.hpp\>|o3tl/optional.hxx|g' -e 's/\<boost(\s*)::(\s*)(make_)?optional\>/o3tl\1::\2\3optional/g' -e 's/\<boost(\s*)::(\s*)none\>/o3tl\1::\2nullopt/g'
(before committing include/o3tl/optional.hxx, and relying on some GNU features).
It excludes some files where mention of boost::optional et al should apparently
not be changed (and the sub-repo directory stubs). It turned out that all uses
of boost::none across the code base were in combination with boost::optional, so
had all to be rewritten as o3tl::nullopt.
Change-Id: Ibfd9f4b3d5a8aee6e6eed310b988c4e5ffd8b11b
Reviewed-on: https://gerrit.libreoffice.org/84128
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
90 lines
3.7 KiB
C++
90 lines
3.7 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*
|
|
* This file incorporates work covered by the following license notice:
|
|
*
|
|
* Licensed to the Apache Software Foundation (ASF) under one or more
|
|
* contributor license agreements. See the NOTICE file distributed
|
|
* with this work for additional information regarding copyright
|
|
* ownership. The ASF licenses this file to you under the Apache
|
|
* License, Version 2.0 (the "License"); you may not use this file
|
|
* except in compliance with the License. You may obtain a copy of
|
|
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
|
|
*/
|
|
|
|
#ifndef INCLUDED_DBACCESS_SOURCE_CORE_API_RESULTCOLUMN_HXX
|
|
#define INCLUDED_DBACCESS_SOURCE_CORE_API_RESULTCOLUMN_HXX
|
|
|
|
#include <com/sun/star/sdbc/XResultSetMetaData.hpp>
|
|
#include <com/sun/star/sdbc/XDatabaseMetaData.hpp>
|
|
#include <column.hxx>
|
|
#include <o3tl/optional.hxx>
|
|
#include <comphelper/proparrhlp.hxx>
|
|
namespace dbaccess
|
|
{
|
|
|
|
// OResultColumn
|
|
|
|
class OResultColumn : public OColumn,
|
|
public ::comphelper::OPropertyArrayUsageHelper < OResultColumn >
|
|
{
|
|
protected:
|
|
css::uno::Reference < css::sdbc::XResultSetMetaData > m_xMetaData;
|
|
css::uno::Reference< css::sdbc::XDatabaseMetaData > m_xDBMetaData;
|
|
sal_Int32 m_nPos;
|
|
css::uno::Any m_aIsRowVersion;
|
|
mutable ::o3tl::optional< sal_Bool > m_isSigned;
|
|
mutable ::o3tl::optional< sal_Bool > m_isCurrency;
|
|
mutable ::o3tl::optional< sal_Bool > m_bSearchable;
|
|
mutable ::o3tl::optional< sal_Bool > m_isCaseSensitive;
|
|
mutable ::o3tl::optional< sal_Bool > m_isReadOnly;
|
|
mutable ::o3tl::optional< sal_Bool > m_isWritable;
|
|
mutable ::o3tl::optional< sal_Bool > m_isDefinitelyWritable;
|
|
mutable ::o3tl::optional< sal_Bool > m_isAutoIncrement;
|
|
mutable ::o3tl::optional< sal_Int32 > m_isNullable;
|
|
mutable ::o3tl::optional< OUString > m_sColumnLabel;
|
|
mutable ::o3tl::optional< sal_Int32 > m_nColumnDisplaySize;
|
|
mutable ::o3tl::optional< sal_Int32 > m_nColumnType;
|
|
mutable ::o3tl::optional< sal_Int32 > m_nPrecision;
|
|
mutable ::o3tl::optional< sal_Int32 > m_nScale;
|
|
|
|
virtual ~OResultColumn() override;
|
|
public:
|
|
OResultColumn(
|
|
const css::uno::Reference < css::sdbc::XResultSetMetaData >& _xMetaData,
|
|
sal_Int32 _nPos,
|
|
const css::uno::Reference< css::sdbc::XDatabaseMetaData >& _rxDBMeta );
|
|
|
|
// css::lang::XTypeProvider
|
|
virtual css::uno::Sequence< sal_Int8 > SAL_CALL getImplementationId() override;
|
|
|
|
// css::lang::XServiceInfo
|
|
virtual OUString SAL_CALL getImplementationName( ) override;
|
|
virtual css::uno::Sequence< OUString > SAL_CALL getSupportedServiceNames( ) override;
|
|
|
|
// cppu::OComponentHelper
|
|
virtual void SAL_CALL disposing() override;
|
|
|
|
// comphelper::OPropertyArrayUsageHelper
|
|
virtual ::cppu::IPropertyArrayHelper* createArrayHelper( ) const override;
|
|
|
|
// cppu::OPropertySetHelper
|
|
virtual ::cppu::IPropertyArrayHelper& SAL_CALL getInfoHelper() override;
|
|
virtual void SAL_CALL getFastPropertyValue( css::uno::Any& rValue, sal_Int32 nHandle ) const override;
|
|
|
|
private:
|
|
void impl_determineIsRowVersion_nothrow();
|
|
|
|
protected:
|
|
using ::cppu::OPropertySetHelper::getFastPropertyValue;
|
|
};
|
|
}
|
|
#endif // INCLUDED_DBACCESS_SOURCE_CORE_API_RESULTCOLUMN_HXX
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|