...following up on 314f15bff0
"Extend
loplugin:external to warn about enums".
Cases where free functions were moved into an unnamed namespace along with a
class, to not break ADL, are in:
filter/source/svg/svgexport.cxx
sc/source/filter/excel/xelink.cxx
sc/source/filter/excel/xilink.cxx
svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx
All other free functions mentioning moved classes appear to be harmless and not
give rise to (silent, even) ADL breakage. (One remaining TODO in
compilerplugins/clang/external.cxx is that derived classes are not covered by
computeAffectedTypes, even though they could also be affected by ADL-breakage---
but don't seem to be in any acutal case across the code base.)
For friend declarations using elaborate type specifiers, like
class C1 {};
class C2 { friend class C1; };
* If C2 (but not C1) is moved into an unnamed namespace, the friend declaration
must be changed to not use an elaborate type specifier (i.e., "friend C1;"; see
C++17 [namespace.memdef]/3: "If the name in a friend declaration is neither
qualified nor a template-id and the declaration is a function or an
elaborated-type-specifier, the lookup to determine whether the entity has been
previously declared shall not consider any scopes outside the innermost
enclosing namespace.")
* If C1 (but not C2) is moved into an unnamed namespace, the friend declaration
must be changed too, see <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71882>
"elaborated-type-specifier friend not looked up in unnamed namespace".
Apart from that, to keep changes simple and mostly mechanical (which should help
avoid regressions), out-of-line definitions of class members have been left in
the enclosing (named) namespace. But explicit specializations of class
templates had to be moved into the unnamed namespace to appease
<https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92598> "explicit specialization of
template from unnamed namespace using unqualified-id in enclosing namespace".
Also, accompanying declarations (of e.g. typedefs or static variables) that
could arguably be moved into the unnamed namespace too have been left alone.
And in some cases, mention of affected types in blacklists in other loplugins
needed to be adapted.
And sc/qa/unit/mark_test.cxx uses a hack of including other .cxx, one of which
is sc/source/core/data/segmenttree.cxx where e.g. ScFlatUInt16SegmentsImpl is
not moved into an unnamed namespace (because it is declared in
sc/inc/segmenttree.hxx), but its base ScFlatSegmentsImpl is. GCC warns about
such combinations with enabled-by-default -Wsubobject-linkage, but "The compiler
doesn’t give this warning for types defined in the main .C file, as those are
unlikely to have multiple definitions."
(<https://gcc.gnu.org/onlinedocs/gcc-9.2.0/gcc/Warning-Options.html>) The
warned-about classes also don't have multiple definitions in the given test, so
disable the warning when including the .cxx.
Change-Id: Ib694094c0d8168be68f8fe90dfd0acbb66a3f1e4
Reviewed-on: https://gerrit.libreoffice.org/83239
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
193 lines
5.9 KiB
C++
193 lines
5.9 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*
|
|
*/
|
|
|
|
#include <memory>
|
|
#include <sal/config.h>
|
|
#include <vcl/opengl/OpenGLContext.hxx>
|
|
#include <vcl/opengl/OpenGLHelper.hxx>
|
|
|
|
#include <opengl/framebuffer.hxx>
|
|
#include <opengl/texture.hxx>
|
|
|
|
#include <opengl/PackedTextureAtlas.hxx>
|
|
|
|
namespace {
|
|
|
|
struct Node
|
|
{
|
|
tools::Rectangle const mRectangle;
|
|
std::unique_ptr<Node> mLeftNode;
|
|
std::unique_ptr<Node> mRightNode;
|
|
bool mOccupied;
|
|
|
|
explicit Node(int nWidth, int nHeight);
|
|
explicit Node(tools::Rectangle const & aRectangle);
|
|
|
|
bool isLeaf() const;
|
|
Node* insert(int nWidth, int nHeight, int nPadding);
|
|
};
|
|
|
|
}
|
|
|
|
Node::Node(int nWidth, int nHeight)
|
|
: mRectangle(tools::Rectangle(Point(), Size(nWidth, nHeight)))
|
|
, mLeftNode()
|
|
, mRightNode()
|
|
, mOccupied(false)
|
|
{}
|
|
|
|
Node::Node(tools::Rectangle const & aRectangle)
|
|
: mRectangle(aRectangle)
|
|
, mLeftNode()
|
|
, mRightNode()
|
|
, mOccupied(false)
|
|
{}
|
|
|
|
bool Node::isLeaf() const { return mLeftNode == nullptr && mRightNode == nullptr; }
|
|
|
|
Node* Node::insert(int nWidth, int nHeight, int nPadding)
|
|
{
|
|
if (!isLeaf())
|
|
{
|
|
Node* pNewNode = mLeftNode->insert(nWidth, nHeight, nPadding);
|
|
|
|
if (pNewNode != nullptr)
|
|
return pNewNode;
|
|
|
|
return mRightNode->insert(nWidth, nHeight, nPadding);
|
|
}
|
|
else
|
|
{
|
|
if (mOccupied)
|
|
{
|
|
return nullptr;
|
|
}
|
|
|
|
if (nWidth > mRectangle.GetWidth() || nHeight > mRectangle.GetHeight())
|
|
{ // does not fit
|
|
return nullptr;
|
|
}
|
|
|
|
if (nWidth == mRectangle.GetWidth() && nHeight == mRectangle.GetHeight())
|
|
{ // perfect fit
|
|
mOccupied = true;
|
|
return this;
|
|
}
|
|
|
|
int dw = mRectangle.GetWidth() - nWidth;
|
|
int dh = mRectangle.GetHeight() - nHeight;
|
|
|
|
tools::Rectangle aLeftRect;
|
|
tools::Rectangle aRightRect;
|
|
if (dw > dh)
|
|
{
|
|
aLeftRect = tools::Rectangle(Point(mRectangle.Left(), mRectangle.Top()),
|
|
Size(nWidth, mRectangle.GetHeight()));
|
|
aRightRect = tools::Rectangle(Point(nPadding + mRectangle.Left() + nWidth, mRectangle.Top()),
|
|
Size(mRectangle.GetWidth() - nWidth - nPadding, mRectangle.GetHeight()));
|
|
}
|
|
else
|
|
{
|
|
aLeftRect = tools::Rectangle(Point(mRectangle.Left(), mRectangle.Top()),
|
|
Size(mRectangle.GetWidth(), nHeight));
|
|
aRightRect = tools::Rectangle(Point(mRectangle.Left(), nPadding + mRectangle.Top() + nHeight),
|
|
Size(mRectangle.GetWidth(), mRectangle.GetHeight() - nHeight - nPadding));
|
|
}
|
|
|
|
mLeftNode.reset(new Node(aLeftRect));
|
|
mRightNode.reset(new Node(aRightRect));
|
|
|
|
return mLeftNode->insert(nWidth, nHeight, nPadding);
|
|
}
|
|
}
|
|
|
|
struct PackedTexture
|
|
{
|
|
std::shared_ptr<ImplOpenGLTexture> mpTexture;
|
|
std::unique_ptr<Node> mpRootNode;
|
|
|
|
PackedTexture(int nWidth, int nHeight)
|
|
: mpTexture(new ImplOpenGLTexture(nWidth, nHeight, true))
|
|
, mpRootNode(new Node(nWidth, nHeight))
|
|
{}
|
|
};
|
|
|
|
PackedTextureAtlasManager::PackedTextureAtlasManager(int nTextureWidth, int nTextureHeight)
|
|
: mnTextureWidth(nTextureWidth)
|
|
, mnTextureHeight(nTextureHeight)
|
|
{
|
|
}
|
|
|
|
PackedTextureAtlasManager::~PackedTextureAtlasManager()
|
|
{
|
|
for (std::unique_ptr<PackedTexture>& pPackedTexture : maPackedTextures)
|
|
{
|
|
// Free texture early in VCL shutdown while we have a context.
|
|
pPackedTexture->mpTexture.reset();
|
|
}
|
|
}
|
|
|
|
void PackedTextureAtlasManager::CreateNewTexture()
|
|
{
|
|
std::unique_ptr<PackedTexture> pPackedTexture(new PackedTexture(mnTextureWidth, mnTextureHeight));
|
|
GLuint nTextureID = pPackedTexture->mpTexture->mnTexture;
|
|
maPackedTextures.push_back(std::move(pPackedTexture));
|
|
VCL_GL_INFO("PackedTextureAtlas::CreateNewTexture adding texture: " << nTextureID <<
|
|
" atlases: " << maPackedTextures.size());
|
|
}
|
|
|
|
OpenGLTexture PackedTextureAtlasManager::Reserve(int nWidth, int nHeight)
|
|
{
|
|
for (std::unique_ptr<PackedTexture>& pPackedTexture : maPackedTextures)
|
|
{
|
|
Node* pNode = pPackedTexture->mpRootNode->insert(nWidth, nHeight, 1);
|
|
if (pNode != nullptr)
|
|
{
|
|
return OpenGLTexture(pPackedTexture->mpTexture, pNode->mRectangle, -1);
|
|
}
|
|
}
|
|
CreateNewTexture();
|
|
std::unique_ptr<PackedTexture>& pPackedTexture = maPackedTextures.back();
|
|
Node* pNode = pPackedTexture->mpRootNode->insert(nWidth, nHeight, 1);
|
|
if (pNode != nullptr)
|
|
{
|
|
return OpenGLTexture(pPackedTexture->mpTexture, pNode->mRectangle, -1);
|
|
}
|
|
return OpenGLTexture();
|
|
}
|
|
|
|
OpenGLTexture PackedTextureAtlasManager::InsertBuffer(int nWidth, int nHeight, int nFormat, int nType, sal_uInt8 const * pData)
|
|
{
|
|
OpenGLTexture aTexture = Reserve(nWidth, nHeight);
|
|
if (aTexture && pData == nullptr)
|
|
return aTexture;
|
|
|
|
aTexture.CopyData(nWidth, nHeight, nFormat, nType, pData);
|
|
|
|
return aTexture;
|
|
}
|
|
|
|
std::vector<GLuint> PackedTextureAtlasManager::ReduceTextureNumber(int nMaxNumberOfTextures)
|
|
{
|
|
std::vector<GLuint> aTextureIDs;
|
|
while (int(maPackedTextures.size()) > nMaxNumberOfTextures)
|
|
{
|
|
// Remove oldest created texture
|
|
GLuint nTextureID = maPackedTextures[0]->mpTexture->mnTexture;
|
|
aTextureIDs.push_back(nTextureID);
|
|
maPackedTextures.erase(maPackedTextures.begin());
|
|
VCL_GL_INFO("PackedTextureAtlas::ReduceTextureNumber removing texture: " << nTextureID <<
|
|
" atlases: " << maPackedTextures.size());
|
|
}
|
|
return aTextureIDs;
|
|
}
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|