1fd27a7931
I seem to have missed quite a few in
commit 9f4d23c151
filter out some of the AST in the plugins
This nets me another 14% improvement
Change-Id: I39b980b49ced560f768045dbedd3ddfef29306c1
Reviewed-on: https://gerrit.libreoffice.org/59501
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
61 lines
2.0 KiB
C++
61 lines
2.0 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*/
|
|
|
|
#include "plugin.hxx"
|
|
|
|
// Find occurrences of 'new T()' where the instance is zero-initialized upfront
|
|
// since C++11. For one, in many cases this may be unnecessary and unintended,
|
|
// as the code was written before C++11. For another, the zero-initialization
|
|
// would go away when T gets a user-provided default constructor, for example,
|
|
// so better make any necessary initialization more explicit in the code.
|
|
|
|
namespace {
|
|
|
|
class SubtleZeroInit final:
|
|
public loplugin::FilteringPlugin<SubtleZeroInit>
|
|
{
|
|
public:
|
|
explicit SubtleZeroInit(loplugin::InstantiationData const & data):
|
|
FilteringPlugin(data) {}
|
|
|
|
bool VisitCXXNewExpr(CXXNewExpr const * expr) {
|
|
if (ignoreLocation(expr)) {
|
|
return true;
|
|
}
|
|
auto ce = expr->getConstructExpr();
|
|
if (ce == nullptr) {
|
|
return true;
|
|
}
|
|
if (!ce->requiresZeroInitialization()) {
|
|
return true;
|
|
}
|
|
report(
|
|
DiagnosticsEngine::Warning,
|
|
("if zero-initialization of %0 is intentional here, better make"
|
|
" that more explicit (e.g., assigning to members, default"
|
|
" constructor, default member initializers, std::memset)"),
|
|
expr->getExprLoc())
|
|
<< ce->getType() << expr->getSourceRange();
|
|
return true;
|
|
}
|
|
|
|
private:
|
|
void run() override {
|
|
if (compiler.getLangOpts().CPlusPlus) {
|
|
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
|
|
}
|
|
}
|
|
};
|
|
|
|
static loplugin::Plugin::Registration<SubtleZeroInit> reg("subtlezeroinit");
|
|
|
|
}
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
|