c0f1c0da77
Currently when a text edit is started, then in the LOK case if there is an other view that shows the same page, then both draw views will have an outliner view showing the text edit. This means that in case a view shell is created after starting the text edit, that won't have an outliner view for the text edit. Before fixing this, calls to SfxViewShell::Current() has to be avoided when we're in the process of setting up a new LOK view. In case of Impress, this is a double initialization, and by the time SdrObjEditView::ImpMakeOutlinerView() is called, we're already in the process of setting up the second SfxViewShell (as part of SdXImpressDocument::initializeForTiledRendering()), but SfxViewShell::Current() still points to the old view shell. Which means that the outliner view would refer to a view shell that's deleted soon, and we crash as soon as it tries to invoke a LOK callback. Fix this by adding a virtual member function to SdrObjEditView, and override it in sd, so in case applications want to provide a more precise way of giving the view shell owning a draw view, then they can. Change-Id: Ie0005f73237d4ff9cf576bf16fa5b46280f13759 Reviewed-on: https://gerrit.libreoffice.org/27561 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
283 lines
11 KiB
C++
283 lines
11 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*
|
|
* This file incorporates work covered by the following license notice:
|
|
*
|
|
* Licensed to the Apache Software Foundation (ASF) under one or more
|
|
* contributor license agreements. See the NOTICE file distributed
|
|
* with this work for additional information regarding copyright
|
|
* ownership. The ASF licenses this file to you under the Apache
|
|
* License, Version 2.0 (the "License"); you may not use this file
|
|
* except in compliance with the License. You may obtain a copy of
|
|
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
|
|
*/
|
|
|
|
#ifndef INCLUDED_SD_SOURCE_UI_INC_VIEW_HXX
|
|
#define INCLUDED_SD_SOURCE_UI_INC_VIEW_HXX
|
|
|
|
#include "pres.hxx"
|
|
#include <tools/gen.hxx>
|
|
#include <svtools/transfer.hxx>
|
|
#include <svx/fmview.hxx>
|
|
#include <svx/svdmark.hxx>
|
|
#include <svx/svdpage.hxx>
|
|
#include <vcl/idle.hxx>
|
|
#include "fupoor.hxx"
|
|
|
|
#include "smarttag.hxx"
|
|
#include <editeng/numitem.hxx>
|
|
|
|
class SdDrawDocument;
|
|
class SdPage;
|
|
class SdrOle2Obj;
|
|
class SdrGrafObj;
|
|
class SdrMediaObj;
|
|
class OutputDevice;
|
|
class ImageMap;
|
|
class Point;
|
|
class Graphic;
|
|
class SdrOutliner;
|
|
class TransferableDataHelper;
|
|
struct StyleRequestData;
|
|
class Outliner;
|
|
|
|
namespace sd {
|
|
|
|
class DrawDocShell;
|
|
struct SdNavigatorDropEvent;
|
|
class ViewShell;
|
|
class Window;
|
|
class ViewClipboard;
|
|
|
|
//For master view we want to force that master
|
|
//textboxes have readonly text, because the
|
|
//text is the auto-generated click-here-to-edit
|
|
//and it doesn't help to change it
|
|
class OutlinerMasterViewFilter
|
|
{
|
|
private:
|
|
SdrOutliner *m_pOutl;
|
|
bool m_bReadOnly;
|
|
public:
|
|
OutlinerMasterViewFilter()
|
|
: m_pOutl(nullptr)
|
|
, m_bReadOnly(false)
|
|
{
|
|
}
|
|
void Start(SdrOutliner *pOutl);
|
|
void End();
|
|
};
|
|
|
|
class View : public FmFormView
|
|
{
|
|
public:
|
|
|
|
View (
|
|
SdDrawDocument& rDrawDoc,
|
|
OutputDevice* pOutDev,
|
|
ViewShell* pViewSh=nullptr);
|
|
virtual ~View();
|
|
|
|
void CompleteRedraw( OutputDevice* pOutDev, const vcl::Region& rReg, sdr::contact::ViewObjectContactRedirector* pRedirector = nullptr) override;
|
|
|
|
virtual void GetAttributes( SfxItemSet& rTargetSet, bool bOnlyHardAttr = false ) const;
|
|
virtual bool SetAttributes(const SfxItemSet& rSet, bool bReplaceAll = false);
|
|
virtual void MarkListHasChanged() override;
|
|
virtual void ModelHasChanged() override;
|
|
void SelectAll();
|
|
void DoCut(vcl::Window* pWindow=nullptr);
|
|
void DoCopy(vcl::Window* pWindow=nullptr);
|
|
void DoPaste(vcl::Window* pWindow=nullptr);
|
|
virtual void DoConnect(SdrOle2Obj* pOleObj) override;
|
|
virtual bool SetStyleSheet(SfxStyleSheet* pStyleSheet, bool bDontRemoveHardAttr = false);
|
|
void StartDrag( const Point& rStartPos, vcl::Window* pWindow );
|
|
virtual void DragFinished( sal_Int8 nDropAction );
|
|
virtual sal_Int8 AcceptDrop (
|
|
const AcceptDropEvent& rEvt,
|
|
DropTargetHelper& rTargetHelper,
|
|
::sd::Window* pTargetWindow = nullptr,
|
|
sal_uInt16 nPage = SDRPAGE_NOTFOUND,
|
|
sal_uInt16 nLayer = SDRPAGE_NOTFOUND);
|
|
virtual sal_Int8 ExecuteDrop (
|
|
const ExecuteDropEvent& rEvt,
|
|
::sd::Window* pTargetWindow = nullptr,
|
|
sal_uInt16 nPage = SDRPAGE_NOTFOUND,
|
|
sal_uInt16 nLayer = SDRPAGE_NOTFOUND);
|
|
|
|
css::uno::Reference<css::datatransfer::XTransferable>
|
|
CreateClipboardDataObject (::sd::View*, vcl::Window& rWindow);
|
|
css::uno::Reference<css::datatransfer::XTransferable>
|
|
CreateDragDataObject (::sd::View*, vcl::Window& rWindow,
|
|
const Point& rDragPos);
|
|
css::uno::Reference<css::datatransfer::XTransferable>
|
|
CreateSelectionDataObject (::sd::View*, vcl::Window& rWindow);
|
|
|
|
void UpdateSelectionClipboard( bool bForceDeselect );
|
|
|
|
inline DrawDocShell* GetDocSh() const { return mpDocSh; }
|
|
inline SdDrawDocument& GetDoc() const;
|
|
inline ViewShell* GetViewShell() const { return mpViewSh; }
|
|
SfxViewShell* GetSfxViewShell() const override;
|
|
|
|
virtual bool SdrBeginTextEdit(SdrObject* pObj, SdrPageView* pPV = nullptr, vcl::Window* pWin = nullptr, bool bIsNewObj = false,
|
|
SdrOutliner* pGivenOutliner = nullptr, OutlinerView* pGivenOutlinerView = nullptr,
|
|
bool bDontDeleteOutliner = false, bool bOnlyOneView = false, bool bGrabFocus = true) override;
|
|
|
|
virtual SdrEndTextEditKind SdrEndTextEdit(bool bDontDeleteReally = false) override;
|
|
|
|
bool RestoreDefaultText( SdrTextObj* pTextObj );
|
|
|
|
bool InsertData( const TransferableDataHelper& rDataHelper,
|
|
const Point& rPos, sal_Int8& rDnDAction, bool bDrag,
|
|
SotClipboardFormatId nFormat = SotClipboardFormatId::NONE,
|
|
sal_uInt16 nPage = SDRPAGE_NOTFOUND, sal_uInt16 nLayer = SDRLAYER_NOTFOUND );
|
|
/** gets the metafile from the given transferable helper and insert it as a graphic shape.
|
|
@param bOptimize if set to true, the metafile is analyzed and if only one bitmap action is
|
|
present, then is inserted as a single graphic.
|
|
*/
|
|
bool InsertMetaFile( TransferableDataHelper& rDataHelper,
|
|
const Point& rInsertPos,
|
|
ImageMap* pImageMap, bool bOptimize );
|
|
SdrGrafObj* InsertGraphic( const Graphic& rGraphic,
|
|
sal_Int8& rAction, const Point& rPos,
|
|
SdrObject* pSelectedObj, ImageMap* pImageMap );
|
|
void InsertMediaURL( const OUString& rMediaURL, sal_Int8& rAction,
|
|
const Point& rPos, const Size& rSize,
|
|
bool const bLink );
|
|
void Insert3DModelURL( const OUString& rModelURL, sal_Int8& rAction,
|
|
const Point& rPos, const Size& rSize );
|
|
SdrMediaObj* InsertMediaObj( const OUString& rURL, const OUString& rMimeType, sal_Int8& rAction,
|
|
const Point& rPos, const Size& rSize );
|
|
|
|
bool PasteRTFTable( const ::tools::SvRef<SotStorageStream>& xStm, SdrPage* pPage, SdrInsertFlags nPasteOptions );
|
|
|
|
bool IsPresObjSelected(bool bOnPage = true, bool bOnMasterPage = true, bool bCheckPresObjListOnly = false, bool bCheckLayoutOnly = false) const;
|
|
|
|
void SetMarkedOriginalSize();
|
|
|
|
bool IsMorphingAllowed() const;
|
|
bool IsVectorizeAllowed() const;
|
|
|
|
virtual SfxStyleSheet* GetStyleSheet() const;
|
|
|
|
/** return parameter:
|
|
pExchangeList == NULL -> all names are unique
|
|
bNameOK == false -> cancel by user
|
|
nType == 0 -> pages
|
|
nType == 1 -> objects
|
|
nType == 2 -> pages and objects */
|
|
|
|
bool GetExchangeList( std::vector<OUString> &rExchangeList,
|
|
std::vector<OUString> &rBookmarkList,
|
|
const sal_uInt16 nType );
|
|
|
|
virtual void onAccessibilityOptionsChanged() override;
|
|
|
|
virtual SdrModel* GetMarkedObjModel() const override;
|
|
virtual bool Paste(
|
|
const SdrModel& rMod, const Point& rPos, SdrObjList* pLst, SdrInsertFlags nOptions) override;
|
|
|
|
using SdrExchangeView::Paste;
|
|
|
|
/** returns true if we have an undo manager and there is an open list undo action */
|
|
bool isRecordingUndo() const;
|
|
|
|
virtual void AddCustomHdl() override;
|
|
|
|
SmartTagSet& getSmartTags() { return maSmartTags; }
|
|
void updateHandles();
|
|
|
|
virtual SdrViewContext GetContext() const override;
|
|
virtual bool HasMarkablePoints() const override;
|
|
virtual sal_uLong GetMarkablePointCount() const override;
|
|
virtual bool HasMarkedPoints() const override;
|
|
virtual sal_uLong GetMarkedPointCount() const override;
|
|
virtual bool IsPointMarkable(const SdrHdl& rHdl) const override;
|
|
virtual bool MarkPoint(SdrHdl& rHdl, bool bUnmark=false) override;
|
|
virtual void CheckPossibilities() override;
|
|
virtual bool MarkPoints(const ::Rectangle* pRect, bool bUnmark) override;
|
|
using SdrMarkView::MarkPoints;
|
|
|
|
bool ShouldToggleOn(
|
|
const bool bBulletOnOffMode,
|
|
const bool bNormalBullet);
|
|
|
|
/** change the bullets/numbering of the marked objects
|
|
|
|
@param bToggle
|
|
true: just toggle the current bullets/numbering on --> off resp. off --> on
|
|
|
|
@param bHandleBullets
|
|
true: handle bullets
|
|
false: handle numbering
|
|
|
|
@param pNumRule
|
|
numbering rule which needs to be applied. can be 0.
|
|
*/
|
|
void ChangeMarkedObjectsBulletsNumbering(
|
|
const bool bToggle,
|
|
const bool bHandleBullets,
|
|
const SvxNumRule* pNumRule);
|
|
|
|
void SetPossibilitiesDirty() { bPossibilitiesDirty = true; }
|
|
void SetMoveAllowed( bool bSet ) { bMoveAllowed = bSet; }
|
|
void SetMoveProtected( bool bSet ) { bMoveProtect = bSet; }
|
|
void SetResizeFreeAllowed( bool bSet ) { bResizeFreeAllowed = bSet; }
|
|
void SetResizePropAllowed( bool bSet ) { bResizePropAllowed = bSet; }
|
|
void SetResizeProtected( bool bSet ) { bResizeProtect = bSet; }
|
|
|
|
SdrObject* GetEmptyPresentationObject( PresObjKind eKind );
|
|
SdPage* GetPage();
|
|
SdrObject* GetSelectedSingleObject(SdPage* pPage);
|
|
|
|
protected:
|
|
DECL_LINK_TYPED( OnParagraphInsertedHdl, ::Outliner *, void );
|
|
DECL_LINK_TYPED( OnParagraphRemovingHdl, ::Outliner *, void );
|
|
|
|
virtual void OnBeginPasteOrDrop( PasteOrDropInfos* pInfo ) override;
|
|
virtual void OnEndPasteOrDrop( PasteOrDropInfos* pInfo ) override;
|
|
|
|
SdDrawDocument& mrDoc;
|
|
DrawDocShell* mpDocSh;
|
|
ViewShell* mpViewSh;
|
|
SdrMarkList* mpDragSrcMarkList;
|
|
SdrObject* mpDropMarkerObj;
|
|
SdrDropMarkerOverlay* mpDropMarker;
|
|
sal_uInt16 mnDragSrcPgNum;
|
|
Point maDropPos;
|
|
::std::vector<OUString> maDropFileVector;
|
|
sal_Int8 mnAction;
|
|
Idle maDropErrorIdle;
|
|
Idle maDropInsertFileIdle;
|
|
sal_uInt16 mnLockRedrawSmph;
|
|
bool mbIsDropAllowed;
|
|
|
|
DECL_LINK_TYPED( DropErrorHdl, Idle*, void );
|
|
DECL_LINK_TYPED( DropInsertFileHdl, Idle*, void );
|
|
DECL_LINK_TYPED( ExecuteNavigatorDrop, void*, void );
|
|
|
|
void ImplClearDrawDropMarker();
|
|
|
|
SmartTagSet maSmartTags;
|
|
|
|
private:
|
|
::std::unique_ptr<ViewClipboard> mpClipboard;
|
|
OutlinerMasterViewFilter maMasterViewFilter;
|
|
};
|
|
|
|
SdDrawDocument& View::GetDoc() const
|
|
{
|
|
return mrDoc;
|
|
}
|
|
|
|
} // end of namespace sd
|
|
|
|
#endif
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|