mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
c7a608a6691c790783c63f504010bc796c36af25
libreoffice/sw/inc/swatrset.hxx
Armin Le Grand (allotropia) 23d1395a78 ITEM: improve SfxItemSet notification callback 
When browsing cachegrind data I stumbled over the notification
callback used by Writer in SfxItemSet::Changed. That is a
virtual method that gets called in quite some places to forward
item changes, SW uses it to record these.
For that purpose always (quite some) data gets prepared without
checking if this is necessary, this uses calls to ::Get and
::GetDefaultItem to have either the old or new Item from the
parent or default (pool).
This is not needed - except for Writer. Even there this
mechanism is not always active. Thus I:

- removed SfxItemSet::Changed, replaced with a settable callback
member of type std::function<...>. Thus one less virtual function
and depenence in SfxItemSet
- added a callback functor to SwAttrSet that can be set at the
SfxItemSet it is derived from
- setting/releasing this only in used cases. It is not even used
all the time in SW.
- moved the creation/processing of needed data to a member
function in SW (SwAttrSet::changeCallback). All processing and
evtl. needed data is now created there - on demand.
- adapted all places in SfxItemSet where that mechanism is used
to only call it if set & without pre-calculating anything
- since all former calls/usages were pretty similar I could put
all of this to SwAttrSet::changeCallback

This leads to use that only when needed now. Naturally, SW will
potentially profit less than the other apps.

Here are callgrind numbers with this change using OfficeStart,
DocLoad, DocClose, OfficeShutdown. This change also has potential
avantages @runtime/UI which also did all preparations to call
SfxItemSet::Changed all the time:

Writer doc: 0,9907 ~1%
old: 93842 mio
new: 92971 mio

Draw/Impress doc: 0,9971 ~2,8%
old: 170023 mio
new: 169544 mio
::Get reduces from 1416103 to 293874 calls
::GetDefaultItem reduces from 2252336 to 1927209 calls (nearly half)

Calc doc: 0.9868 ~1,3%
old: 194708 mio
new: 192130 mio
::Get reduces from 882298 to 880087 calls
::GetDefaultItem reduces from 4611901 to 2633555 calls (nearly half)

Of course this highly depends on the used test documents, so it can
only be a excerpt result.

Also adapted SfxItemSet::MergeRange a little bit: Do nothing not only
when a single new slot is already contaioned, but check if all slots
are already present. This works well and fast using the formally added
caching mechanism.

Change-Id: I4d369d2e5b21aa7a21687177518150515e3de954
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155559
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-08-10 20:43:21 +02:00

347 lines
15 KiB
C++
Raw Blame History

/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*
* This file incorporates work covered by the following license notice:
*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed
* with this work for additional information regarding copyright
* ownership. The ASF licenses this file to you under the Apache
* License, Version 2.0 (the "License"); you may not use this file
* except in compliance with the License. You may obtain a copy of
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
#ifndef INCLUDED_SW_INC_SWATRSET_HXX
#define INCLUDED_SW_INC_SWATRSET_HXX
#include <svl/itemset.hxx>
#include <svl/itempool.hxx>
#include "swdllapi.h"
#include "calbck.hxx"
class SwDoc;
class OutputDevice;
class IDocumentSettingAccess;
class SvxPostureItem;
class SvxWeightItem;
class SvxShadowedItem;
class SvxAutoKernItem;
class SvxWordLineModeItem;
class SvxContourItem;
class SvxKerningItem;
class SvxUnderlineItem;
class SvxOverlineItem;
class SvxCrossedOutItem;
class SvxFontHeightItem;
class SvxFontItem;
class SvxColorItem;
class SvxLanguageItem;
class SvxEscapementItem;
class SvxCaseMapItem;
class SvxNoHyphenItem;
class SvxBlinkItem;
class SvxEmphasisMarkItem;
class SvxTwoLinesItem;
class SvxCharScaleWidthItem;
class SvxCharRotateItem;
class SvxCharReliefItem;
class SvxCharHiddenItem;
// Frame attributes
class SwFormatFillOrder;
class SwFormatFrameSize;
class SvxPaperBinItem;
class SvxLeftMarginItem;
class SvxTextLeftMarginItem;
class SvxFirstLineIndentItem;
class SvxRightMarginItem;
class SvxGutterLeftMarginItem;
class SvxGutterRightMarginItem;
class SvxLRSpaceItem;
class SvxULSpaceItem;
class SwFormatContent;
class SwFormatHeader;
class SwFormatFooter;
class SvxPrintItem;
class SvxOpaqueItem;
class SvxProtectItem;
class SwFormatSurround;
class SwFormatVertOrient;
class SwFormatHoriOrient;
class SwFormatAnchor;
class SvxBoxItem;
class SvxBrushItem;
class SvxShadowItem;
class SwFormatPageDesc;
class SvxFormatBreakItem;
class SwFormatCol;
class SvxMacroItem;
class SvxFormatKeepItem;
class SwFormatURL;
class SwFormatLineNumber;
class SwFormatEditInReadonly;
class SwFormatLayoutSplit;
class SwFormatRowSplit;
class SwFormatFlySplit;
class SwFormatChain;
class SwFormatFootnoteAtTextEnd;
class SwFormatEndAtTextEnd;
class SwFormatNoBalancedColumns;
class SvxFrameDirectionItem;
class SwHeaderAndFooterEatSpacingItem;
class SwFormatFollowTextFlow;
class SwFormatWrapInfluenceOnObjPos;
class SdrTextVertAdjustItem;
// Graphic attributes
class SwMirrorGrf;
class SwCropGrf;
class SwRotationGrf;
class SwLuminanceGrf;
class SwContrastGrf;
class SwChannelRGrf;
class SwChannelGGrf;
class SwChannelBGrf;
class SwGammaGrf;
class SwInvertGrf;
class SwTransparencyGrf;
class SwDrawModeGrf;
// Paragraph attributes
class SvxLineSpacingItem;
class SvxAdjustItem;
class SvxFormatSplitItem;
class SwRegisterItem;
class SwNumRuleItem;
class SvxWidowsItem;
class SvxOrphansItem;
class SvxTabStopItem;
class SvxHyphenZoneItem;
class SwFormatDrop;
class SvxScriptSpaceItem;
class SvxHangingPunctuationItem;
class SvxForbiddenRuleItem;
class SvxParaVertAlignItem;
class SvxParaGridItem;
class SwParaConnectBorderItem;
// TableBox attributes
class SwTableBoxNumFormat;
class SwTableBoxFormula;
class SwTableBoxValue;
namespace vcl {
typedef OutputDevice RenderContext;
};
class SAL_DLLPUBLIC_RTTI SwAttrPool final : public SfxItemPool
{
private:
friend void InitCore(); // For creating/deleting of version maps.
friend void FinitCore();
SwDoc* m_pDoc;
public:
SwAttrPool( SwDoc* pDoc );
private:
virtual ~SwAttrPool() override;
public:
SwDoc* GetDoc() { return m_pDoc; }
const SwDoc* GetDoc() const { return m_pDoc; }
};
class SW_DLLPUBLIC SwAttrSet final : public SfxItemSet
{
// Pointer for Modify-System
SwAttrSet *m_pOldSet;
SwAttrSet *m_pNewSet;
// helper class for change callback & local instance
// needed to forward the processing call to the correct instance
class callbackHolder final
{
private:
SwAttrSet* m_Set;
public:
callbackHolder(SwAttrSet* pSet) : m_Set(pSet) {}
void operator () (const SfxPoolItem* pOld, const SfxPoolItem* pNew) { m_Set->changeCallback(pOld, pNew); }
} m_aCallbackHolder;
// processor for change callback
void changeCallback(const SfxPoolItem* pOld, const SfxPoolItem* pNew) const;
void PutChgd( const SfxPoolItem& rI ) { SfxItemSet::PutDirect( rI ); }
public:
SwAttrSet( SwAttrPool&, sal_uInt16 nWhich1, sal_uInt16 nWhich2 );
SwAttrSet( SwAttrPool&, const WhichRangesContainer& nWhichPairTable );
SwAttrSet( const SwAttrSet& );
virtual std::unique_ptr<SfxItemSet> Clone(bool bItems = true, SfxItemPool *pToPool = nullptr) const override;
bool Put_BC( const SfxPoolItem& rAttr, SwAttrSet* pOld, SwAttrSet* pNew );
bool Put_BC( const SfxItemSet& rSet, SwAttrSet* pOld, SwAttrSet* pNew );
// Delete an item or a range.
sal_uInt16 ClearItem_BC( sal_uInt16 nWhich, SwAttrSet* pOld, SwAttrSet* pNew );
sal_uInt16 ClearItem_BC( sal_uInt16 nWhich1, sal_uInt16 nWhich2,
SwAttrSet* pOld = nullptr, SwAttrSet* pNew = nullptr );
int Intersect_BC( const SfxItemSet& rSet, SwAttrSet* pOld, SwAttrSet* pNew );
void GetPresentation( SfxItemPresentation ePres,
MapUnit eCoreMetric, MapUnit ePresMetric, OUString &rText ) const;
SwAttrPool* GetPool() const { return static_cast<SwAttrPool*>(SfxItemSet::GetPool()); }
// Copy attributes, if necessary across documents.
void CopyToModify( sw::BroadcastingModify& rMod ) const;
// Special treatment for some attributes.
// Set Modify-pointer (the old pDefinedIn) at the following attributes:
// - SwFormatDropCaps
// - SwFormatPageDesc
// (Is called at insert in formats/nodes.)
// Second version is for the SwAttrSet handles of SwContentNode.
bool SetModifyAtAttr( const sw::BroadcastingModify* pModify );
// Document is set at SwAttrPool. Therefore it is always accessible.
const SwDoc *GetDoc() const { return GetPool()->GetDoc(); }
SwDoc *GetDoc() { return GetPool()->GetDoc(); }
// Get methods: bool indicates whether to search only in Set (when false)
// or also in parents. If nothing is found then default attribute is returned.
// Character attributes. Implementation in charatr.hxx.
inline const SvxPostureItem &GetPosture( bool = true ) const;
inline const SvxWeightItem &GetWeight( bool = true ) const;
inline const SvxShadowedItem &GetShadowed( bool = true ) const;
inline const SvxAutoKernItem &GetAutoKern( bool = true ) const;
inline const SvxWordLineModeItem &GetWordLineMode( bool = true ) const;
inline const SvxContourItem &GetContour( bool = true ) const;
inline const SvxKerningItem &GetKerning( bool = true ) const;
inline const SvxUnderlineItem &GetUnderline( bool = true ) const;
inline const SvxOverlineItem &GetOverline( bool = true ) const;
inline const SvxCrossedOutItem &GetCrossedOut( bool = true ) const;
inline const SvxFontHeightItem &GetSize( bool = true ) const;
inline const SvxFontItem &GetFont( bool = true ) const;
inline const SvxColorItem &GetColor( bool = true ) const;
inline const SvxLanguageItem &GetLanguage( bool = true ) const;
inline const SvxEscapementItem &GetEscapement( bool = true ) const;
inline const SvxCaseMapItem &GetCaseMap( bool = true ) const;
inline const SvxNoHyphenItem &GetNoHyphenHere( bool = true ) const;
inline const SvxFontItem &GetCJKFont( bool = true ) const;
inline const SvxFontHeightItem &GetCJKSize( bool = true ) const;
inline const SvxLanguageItem &GetCJKLanguage( bool = true ) const;
inline const SvxPostureItem &GetCJKPosture( bool = true ) const;
inline const SvxWeightItem &GetCJKWeight( bool = true ) const;
inline const SvxFontItem &GetCTLFont( bool = true ) const;
inline const SvxFontHeightItem &GetCTLSize( bool = true ) const;
inline const SvxLanguageItem &GetCTLLanguage( bool = true ) const;
inline const SvxPostureItem &GetCTLPosture( bool = true ) const;
inline const SvxWeightItem &GetCTLWeight( bool = true ) const;
inline const SvxEmphasisMarkItem &GetEmphasisMark( bool = true ) const;
inline const SvxTwoLinesItem &Get2Lines( bool = true ) const;
inline const SvxCharScaleWidthItem &GetCharScaleW( bool = true ) const;
inline const SvxCharRotateItem &GetCharRotate( bool = true ) const;
inline const SvxCharReliefItem &GetCharRelief( bool = true ) const;
inline const SvxCharHiddenItem &GetCharHidden( bool = true ) const;
// Frame attributes. Implementation in frmatr.hxx.
inline const SwFormatFillOrder &GetFillOrder( bool = true ) const;
inline const SwFormatFrameSize &GetFrameSize( bool = true ) const;
inline const SvxPaperBinItem &GetPaperBin( bool = true ) const;
inline const SvxLeftMarginItem & GetLeftMargin(bool = true) const;
inline const SvxTextLeftMarginItem &GetTextLeftMargin(bool = true) const;
inline const SvxFirstLineIndentItem &GetFirstLineIndent(bool = true) const;
inline const SvxRightMarginItem & GetRightMargin(bool = true) const;
inline const SvxGutterLeftMarginItem &GetGutterLeftMargin(bool = true) const;
inline const SvxGutterRightMarginItem &GetGutterRightMargin(bool = true) const;
inline const SvxLRSpaceItem &GetLRSpace( bool = true ) const;
inline const SvxULSpaceItem &GetULSpace( bool = true ) const;
inline const SwFormatContent &GetContent( bool = true ) const;
inline const SwFormatHeader &GetHeader( bool = true ) const;
inline const SwFormatFooter &GetFooter( bool = true ) const;
inline const SvxPrintItem &GetPrint( bool = true ) const;
inline const SvxOpaqueItem &GetOpaque( bool = true ) const;
inline const SvxProtectItem &GetProtect( bool = true ) const;
inline const SwFormatSurround &GetSurround( bool = true ) const;
inline const SwFormatVertOrient &GetVertOrient( bool = true ) const;
inline const SwFormatHoriOrient &GetHoriOrient( bool = true ) const;
inline const SwFormatAnchor &GetAnchor( bool = true ) const;
inline const SvxBoxItem &GetBox( bool = true ) const;
inline const SvxFormatKeepItem &GetKeep( bool = true ) const;
inline const SvxBrushItem &GetBackground( bool = true ) const;
inline const SvxShadowItem &GetShadow( bool = true ) const;
inline const SwFormatPageDesc &GetPageDesc( bool = true ) const;
inline const SvxFormatBreakItem &GetBreak( bool = true ) const;
inline const SwFormatCol &GetCol( bool = true ) const;
inline const SvxMacroItem &GetMacro( bool = true ) const;
inline const SwFormatURL &GetURL( bool = true ) const;
inline const SwFormatEditInReadonly &GetEditInReadonly( bool = true ) const;
inline const SwFormatLayoutSplit &GetLayoutSplit( bool = true ) const;
inline const SwFormatRowSplit &GetRowSplit( bool = true ) const;
inline const SwFormatFlySplit &GetFlySplit( bool = true ) const;
inline const SwFormatChain &GetChain( bool = true ) const;
inline const SwFormatLineNumber &GetLineNumber( bool = true ) const;
inline const SwFormatFootnoteAtTextEnd &GetFootnoteAtTextEnd( bool = true ) const;
inline const SwFormatEndAtTextEnd &GetEndAtTextEnd( bool = true ) const;
inline const SwFormatNoBalancedColumns &GetBalancedColumns( bool = true ) const;
inline const SvxFrameDirectionItem &GetFrameDir( bool = true ) const;
inline const SwHeaderAndFooterEatSpacingItem &GetHeaderAndFooterEatSpacing( bool = true ) const;
inline const SwFormatFollowTextFlow &GetFollowTextFlow(bool = true) const;
inline const SwFormatWrapInfluenceOnObjPos& GetWrapInfluenceOnObjPos(bool = true) const;
inline const SdrTextVertAdjustItem& GetTextVertAdjust(bool = true) const;
// Graphic attributes - implementation in grfatr.hxx
inline const SwMirrorGrf &GetMirrorGrf( bool = true ) const;
inline const SwCropGrf &GetCropGrf( bool = true ) const;
inline const SwRotationGrf &GetRotationGrf(bool = true ) const;
inline const SwLuminanceGrf &GetLuminanceGrf(bool = true ) const;
inline const SwContrastGrf &GetContrastGrf(bool = true ) const;
inline const SwChannelRGrf &GetChannelRGrf(bool = true ) const;
inline const SwChannelGGrf &GetChannelGGrf(bool = true ) const;
inline const SwChannelBGrf &GetChannelBGrf(bool = true ) const;
inline const SwGammaGrf &GetGammaGrf(bool = true ) const;
inline const SwInvertGrf &GetInvertGrf(bool = true ) const;
inline const SwTransparencyGrf &GetTransparencyGrf(bool = true ) const;
inline const SwDrawModeGrf &GetDrawModeGrf(bool = true ) const;
// Paragraph attributes - implementation in paratr.hxx
inline const SvxLineSpacingItem &GetLineSpacing( bool = true ) const;
inline const SvxAdjustItem &GetAdjust( bool = true ) const;
inline const SvxFormatSplitItem &GetSplit( bool = true ) const;
inline const SwRegisterItem &GetRegister( bool = true ) const;
inline const SwNumRuleItem &GetNumRule( bool = true ) const;
inline const SvxWidowsItem &GetWidows( bool = true ) const;
inline const SvxOrphansItem &GetOrphans( bool = true ) const;
inline const SvxTabStopItem &GetTabStops( bool = true ) const;
inline const SvxHyphenZoneItem &GetHyphenZone( bool = true ) const;
inline const SwFormatDrop &GetDrop( bool = true ) const;
inline const SvxScriptSpaceItem &GetScriptSpace(bool = true) const;
inline const SvxHangingPunctuationItem &GetHangingPunctuation(bool = true) const;
inline const SvxForbiddenRuleItem &GetForbiddenRule(bool = true) const;
inline const SvxParaVertAlignItem &GetParaVertAlign(bool = true) const;
inline const SvxParaGridItem &GetParaGrid(bool = true) const;
inline const SwParaConnectBorderItem &GetParaConnectBorder(bool = true ) const;
// Tablebox attributes - implementation in cellatr.hxx
inline const SwTableBoxNumFormat &GetTableBoxNumFormat( bool = true ) const;
inline const SwTableBoxFormula &GetTableBoxFormula( bool = true ) const;
inline const SwTableBoxValue &GetTableBoxValue( bool = true ) const;
};
//Helper for filters to find true lineheight of a font
SW_DLLPUBLIC tools::Long AttrSetToLineHeight( const IDocumentSettingAccess& rIDocumentSettingAccess,
const SwAttrSet &rSet,
const vcl::RenderContext &rOut, sal_Int16 nScript);
#endif
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
Reference in New Issue View Git Blame Copy Permalink