5d546de67b
<https://github.com/llvm/llvm-project/commit/ 5689b38c6a4220cc5f6ba68a56486229b10071bf> "Removed a RecursiveASTVisitor feature to visit operator kinds with different methods". That change is incompatible in that before the change individual TraverseUnary* and TraverseBin* functions were called, while now TraverseUnaryOperator and TraverseBinaryOperator/TraverseCompoundAssignOperator are called for all the different operators. Fixed that with a few #if for the non-shared plugins, but that doesn't work for the shared plugin. So made the two affected plugins non- shared for now and left a better fix as a TODO. Change-Id: I5b87d329ae2c4c93bf605bb1ecc9641039f014a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99000 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
53 lines
1.4 KiB
C++
53 lines
1.4 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*/
|
|
|
|
#ifndef LO_CLANG_SHARED_PLUGINS
|
|
|
|
#include "plugin.hxx"
|
|
|
|
namespace {
|
|
|
|
class DerefNullPtr:
|
|
public loplugin::FilteringPlugin<DerefNullPtr>
|
|
{
|
|
public:
|
|
explicit DerefNullPtr(loplugin::InstantiationData const & data):
|
|
FilteringPlugin(data) {}
|
|
|
|
void run() override
|
|
{ TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); }
|
|
|
|
bool VisitUnaryOperator(UnaryOperator const * op);
|
|
};
|
|
|
|
bool DerefNullPtr::VisitUnaryOperator(UnaryOperator const * op) {
|
|
if (op->getOpcode() != UO_Deref) {
|
|
return true;
|
|
}
|
|
if (!ignoreLocation(op)
|
|
&& (op->getSubExpr()->IgnoreParenCasts()->isNullPointerConstant(
|
|
compiler.getASTContext(), Expr::NPC_ValueDependentIsNotNull/*TODO*/)
|
|
!= Expr::NPCK_NotNull))
|
|
{
|
|
report(
|
|
DiagnosticsEngine::Warning, "null pointer dereference",
|
|
compat::getBeginLoc(op))
|
|
<< op->getSourceRange();
|
|
}
|
|
return true;
|
|
}
|
|
|
|
loplugin::Plugin::Registration<DerefNullPtr> derefnullptr("derefnullptr");
|
|
|
|
}
|
|
|
|
#endif // LO_CLANG_SHARED_PLUGINS
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|