9f4d23c151
by checking if the current namespace decl is in our code, so we have to scan less stuff, which results in a 10% perf improvement for me Change-Id: Idf0e30d57b6d0dcd13daa9ed679c28b9d233d387 Reviewed-on: https://gerrit.libreoffice.org/58942 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
833 lines
31 KiB
C++
833 lines
31 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*/
|
|
|
|
#include <algorithm>
|
|
#include <cassert>
|
|
#include <limits>
|
|
#include <set>
|
|
#include <string>
|
|
|
|
#include "clang/AST/Attr.h"
|
|
|
|
#include "check.hxx"
|
|
#include "compat.hxx"
|
|
#include "plugin.hxx"
|
|
|
|
namespace {
|
|
|
|
bool isSalBool(QualType type) {
|
|
TypedefType const * t = type->getAs<TypedefType>();
|
|
return t != nullptr && t->getDecl()->getNameAsString() == "sal_Bool";
|
|
}
|
|
|
|
bool isSalBoolArray(QualType type) {
|
|
auto t = type->getAsArrayTypeUnsafe();
|
|
return t != nullptr
|
|
&& (isSalBool(t->getElementType())
|
|
|| isSalBoolArray(t->getElementType()));
|
|
}
|
|
|
|
// It appears that, given a function declaration, there is no way to determine
|
|
// the language linkage of the function's type, only of the function's name
|
|
// (via FunctionDecl::isExternC); however, in a case like
|
|
//
|
|
// extern "C" { static void f(); }
|
|
//
|
|
// the function's name does not have C language linkage while the function's
|
|
// type does (as clarified in C++11 [decl.link]); cf. <http://clang-developers.
|
|
// 42468.n3.nabble.com/Language-linkage-of-function-type-tt4037248.html>
|
|
// "Language linkage of function type":
|
|
bool hasCLanguageLinkageType(FunctionDecl const * decl) {
|
|
assert(decl != nullptr);
|
|
if (decl->isExternC()) {
|
|
return true;
|
|
}
|
|
if (decl->isInExternCContext()) {
|
|
return true;
|
|
}
|
|
return false;
|
|
}
|
|
|
|
enum class OverrideKind { NO, YES, MAYBE };
|
|
|
|
OverrideKind getOverrideKind(FunctionDecl const * decl) {
|
|
CXXMethodDecl const * m = dyn_cast<CXXMethodDecl>(decl);
|
|
if (m == nullptr) {
|
|
return OverrideKind::NO;
|
|
}
|
|
if (m->size_overridden_methods() != 0 || m->hasAttr<OverrideAttr>()) {
|
|
return OverrideKind::YES;
|
|
}
|
|
if (!dyn_cast<CXXRecordDecl>(m->getDeclContext())->hasAnyDependentBases()) {
|
|
return OverrideKind::NO;
|
|
}
|
|
return OverrideKind::MAYBE;
|
|
}
|
|
|
|
enum class BoolOverloadKind { No, Yes, CheckNext };
|
|
|
|
BoolOverloadKind isBoolOverloadOf(
|
|
FunctionDecl const * f, FunctionDecl const * decl, bool mustBeDeleted)
|
|
{
|
|
if (!mustBeDeleted || f->isDeleted()) {
|
|
unsigned n = decl->getNumParams();
|
|
if (f->getNumParams() == n) {
|
|
bool hasSB = false;
|
|
for (unsigned i = 0; i != n; ++i) {
|
|
QualType t1 { decl->getParamDecl(i)->getType() };
|
|
bool isSB = isSalBool(t1);
|
|
bool isSBRef = !isSB && t1->isReferenceType()
|
|
&& isSalBool(t1.getNonReferenceType());
|
|
QualType t2 { f->getParamDecl(i)->getType() };
|
|
if (!(isSB
|
|
? t2->isBooleanType()
|
|
: isSBRef
|
|
? (t2->isReferenceType()
|
|
&& t2.getNonReferenceType()->isBooleanType())
|
|
: t2.getCanonicalType() == t1.getCanonicalType()))
|
|
{
|
|
return BoolOverloadKind::CheckNext;
|
|
}
|
|
hasSB |= isSB || isSBRef;
|
|
}
|
|
return hasSB ? BoolOverloadKind::Yes : BoolOverloadKind::No;
|
|
// cheaply protect against the case where decl would have no
|
|
// sal_Bool parameters at all and would match itself
|
|
}
|
|
}
|
|
return BoolOverloadKind::CheckNext;
|
|
}
|
|
|
|
//TODO: current implementation is not at all general, just tests what we
|
|
// encounter in practice:
|
|
bool hasBoolOverload(FunctionDecl const * decl, bool mustBeDeleted) {
|
|
auto ctx = decl->getDeclContext();
|
|
if (!ctx->isLookupContext()) {
|
|
return false;
|
|
}
|
|
auto res = ctx->lookup(decl->getDeclName());
|
|
for (auto d = res.begin(); d != res.end(); ++d) {
|
|
if (auto f = dyn_cast<FunctionDecl>(*d)) {
|
|
switch (isBoolOverloadOf(f, decl, mustBeDeleted)) {
|
|
case BoolOverloadKind::No:
|
|
return false;
|
|
case BoolOverloadKind::Yes:
|
|
return true;
|
|
case BoolOverloadKind::CheckNext:
|
|
break;
|
|
}
|
|
} else if (auto ftd = dyn_cast<FunctionTemplateDecl>(*d)) {
|
|
for (auto f: ftd->specializations()) {
|
|
if (f->getTemplateSpecializationKind()
|
|
== TSK_ExplicitSpecialization)
|
|
{
|
|
switch (isBoolOverloadOf(f, decl, mustBeDeleted)) {
|
|
case BoolOverloadKind::No:
|
|
return false;
|
|
case BoolOverloadKind::Yes:
|
|
return true;
|
|
case BoolOverloadKind::CheckNext:
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
return false;
|
|
}
|
|
|
|
class SalBool:
|
|
public loplugin::FilteringRewritePlugin<SalBool>
|
|
{
|
|
public:
|
|
explicit SalBool(loplugin::InstantiationData const & data):
|
|
FilteringRewritePlugin(data) {}
|
|
|
|
virtual void run() override;
|
|
|
|
bool VisitUnaryAddrOf(UnaryOperator const * op);
|
|
|
|
bool VisitCallExpr(CallExpr * expr);
|
|
|
|
bool VisitCStyleCastExpr(CStyleCastExpr * expr);
|
|
|
|
bool VisitCXXStaticCastExpr(CXXStaticCastExpr * expr);
|
|
|
|
bool VisitCXXFunctionalCastExpr(CXXFunctionalCastExpr * expr);
|
|
|
|
bool VisitImplicitCastExpr(ImplicitCastExpr * expr);
|
|
|
|
bool VisitReturnStmt(ReturnStmt const * stmt);
|
|
|
|
bool WalkUpFromParmVarDecl(ParmVarDecl const * decl);
|
|
bool VisitParmVarDecl(ParmVarDecl const * decl);
|
|
|
|
bool WalkUpFromVarDecl(VarDecl const * decl);
|
|
bool VisitVarDecl(VarDecl const * decl);
|
|
|
|
bool WalkUpFromFieldDecl(FieldDecl const * decl);
|
|
bool VisitFieldDecl(FieldDecl const * decl);
|
|
|
|
bool WalkUpFromFunctionDecl(FunctionDecl const * decl);
|
|
bool VisitFunctionDecl(FunctionDecl const * decl);
|
|
|
|
bool VisitValueDecl(ValueDecl const * decl);
|
|
|
|
bool TraverseStaticAssertDecl(StaticAssertDecl * decl);
|
|
|
|
bool TraverseLinkageSpecDecl(LinkageSpecDecl * decl);
|
|
|
|
private:
|
|
bool isFromCIncludeFile(SourceLocation spellingLocation) const;
|
|
|
|
bool isSharedCAndCppCode(SourceLocation location) const;
|
|
|
|
bool isInSpecialMainFile(SourceLocation spellingLocation) const;
|
|
|
|
bool rewrite(SourceLocation location);
|
|
|
|
std::set<VarDecl const *> varDecls_;
|
|
unsigned int externCContexts_ = 0;
|
|
};
|
|
|
|
void SalBool::run() {
|
|
if (compiler.getLangOpts().CPlusPlus) {
|
|
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
|
|
for (auto decl: varDecls_) {
|
|
SourceLocation loc { compat::getBeginLoc(decl) };
|
|
TypeSourceInfo * tsi = decl->getTypeSourceInfo();
|
|
if (tsi != nullptr) {
|
|
SourceLocation l {
|
|
compiler.getSourceManager().getExpansionLoc(
|
|
tsi->getTypeLoc().getBeginLoc()) };
|
|
SourceLocation end {
|
|
compiler.getSourceManager().getExpansionLoc(
|
|
tsi->getTypeLoc().getEndLoc()) };
|
|
assert(l.isFileID() && end.isFileID());
|
|
if (l == end
|
|
|| compiler.getSourceManager().isBeforeInTranslationUnit(
|
|
l, end))
|
|
{
|
|
for (;;) {
|
|
unsigned n = Lexer::MeasureTokenLength(
|
|
l, compiler.getSourceManager(),
|
|
compiler.getLangOpts());
|
|
std::string s {
|
|
compiler.getSourceManager().getCharacterData(l),
|
|
n };
|
|
if (s == "sal_Bool") {
|
|
loc = l;
|
|
break;
|
|
}
|
|
if (l == end) {
|
|
break;
|
|
}
|
|
l = l.getLocWithOffset(std::max<unsigned>(n, 1));
|
|
}
|
|
}
|
|
}
|
|
if (!rewrite(loc)) {
|
|
report(
|
|
DiagnosticsEngine::Warning,
|
|
"VarDecl, use \"bool\" instead of \"sal_Bool\"", loc)
|
|
<< decl->getSourceRange();
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
bool SalBool::VisitUnaryAddrOf(UnaryOperator const * op) {
|
|
Expr const * e1 = op->getSubExpr()->IgnoreParenCasts();
|
|
if (isSalBool(e1->getType())) {
|
|
DeclRefExpr const * e2 = dyn_cast<DeclRefExpr>(e1);
|
|
if (e2 != nullptr) {
|
|
VarDecl const * d = dyn_cast<VarDecl>(e2->getDecl());
|
|
if (d != nullptr) {
|
|
varDecls_.erase(d);
|
|
}
|
|
}
|
|
}
|
|
return true;
|
|
}
|
|
|
|
bool SalBool::VisitCallExpr(CallExpr * expr) {
|
|
Decl const * d = expr->getCalleeDecl();
|
|
FunctionProtoType const * ft = nullptr;
|
|
if (d != nullptr) {
|
|
FunctionDecl const * fd = dyn_cast<FunctionDecl>(d);
|
|
if (fd != nullptr) {
|
|
if (!hasBoolOverload(fd, false)) {
|
|
clang::PointerType const * pt = fd->getType()
|
|
->getAs<clang::PointerType>();
|
|
QualType t2(
|
|
pt == nullptr ? fd->getType() : pt->getPointeeType());
|
|
ft = t2->getAs<FunctionProtoType>();
|
|
assert(
|
|
ft != nullptr || !compiler.getLangOpts().CPlusPlus
|
|
|| (fd->getBuiltinID() != Builtin::NotBuiltin
|
|
&& isa<FunctionNoProtoType>(t2)));
|
|
// __builtin_*s have no proto type?
|
|
}
|
|
} else {
|
|
VarDecl const * vd = dyn_cast<VarDecl>(d);
|
|
if (vd != nullptr) {
|
|
clang::PointerType const * pt = vd->getType()
|
|
->getAs<clang::PointerType>();
|
|
ft = (pt == nullptr ? vd->getType() : pt->getPointeeType())
|
|
->getAs<FunctionProtoType>();
|
|
}
|
|
}
|
|
}
|
|
if (ft != nullptr) {
|
|
for (unsigned i = 0; i != ft->getNumParams(); ++i) {
|
|
QualType t(ft->getParamType(i));
|
|
bool b = false;
|
|
if (t->isLValueReferenceType()) {
|
|
t = t.getNonReferenceType();
|
|
b = !t.isConstQualified() && isSalBool(t);
|
|
} else if (t->isPointerType()) {
|
|
for (;;) {
|
|
auto t2 = t->getAs<clang::PointerType>();
|
|
if (t2 == nullptr) {
|
|
break;
|
|
}
|
|
t = t2->getPointeeType();
|
|
}
|
|
b = isSalBool(t);
|
|
}
|
|
if (b && i < expr->getNumArgs()) {
|
|
DeclRefExpr * ref = dyn_cast<DeclRefExpr>(
|
|
expr->getArg(i)->IgnoreParenImpCasts());
|
|
if (ref != nullptr) {
|
|
VarDecl const * d = dyn_cast<VarDecl>(ref->getDecl());
|
|
if (d != nullptr) {
|
|
varDecls_.erase(d);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
return true;
|
|
}
|
|
|
|
bool SalBool::VisitCStyleCastExpr(CStyleCastExpr * expr) {
|
|
if (ignoreLocation(expr)) {
|
|
return true;
|
|
}
|
|
if (isSalBool(expr->getType())) {
|
|
SourceLocation loc { compat::getBeginLoc(expr) };
|
|
while (compiler.getSourceManager().isMacroArgExpansion(loc)) {
|
|
loc = compiler.getSourceManager().getImmediateMacroCallerLoc(loc);
|
|
}
|
|
if (compiler.getSourceManager().isMacroBodyExpansion(loc)) {
|
|
StringRef name { Lexer::getImmediateMacroName(
|
|
loc, compiler.getSourceManager(), compiler.getLangOpts()) };
|
|
if (name == "sal_False" || name == "sal_True") {
|
|
auto callLoc = compiler.getSourceManager()
|
|
.getImmediateMacroCallerLoc(loc);
|
|
if (!isSharedCAndCppCode(callLoc)) {
|
|
SourceLocation argLoc;
|
|
if (compat::isMacroArgExpansion(
|
|
compiler, compat::getBeginLoc(expr), &argLoc)
|
|
//TODO: check it's the complete (first) arg to the macro
|
|
&& (Lexer::getImmediateMacroName(
|
|
argLoc, compiler.getSourceManager(),
|
|
compiler.getLangOpts())
|
|
== "CPPUNIT_ASSERT_EQUAL"))
|
|
{
|
|
// Ignore sal_False/True that are directly used as
|
|
// arguments to CPPUNIT_ASSERT_EQUAL:
|
|
return true;
|
|
}
|
|
bool b = name == "sal_True";
|
|
if (rewriter != nullptr) {
|
|
auto callSpellLoc = compiler.getSourceManager()
|
|
.getSpellingLoc(callLoc);
|
|
unsigned n = Lexer::MeasureTokenLength(
|
|
callSpellLoc, compiler.getSourceManager(),
|
|
compiler.getLangOpts());
|
|
if (StringRef(
|
|
compiler.getSourceManager().getCharacterData(
|
|
callSpellLoc),
|
|
n)
|
|
== name)
|
|
{
|
|
return replaceText(
|
|
callSpellLoc, n, b ? "true" : "false");
|
|
}
|
|
}
|
|
report(
|
|
DiagnosticsEngine::Warning,
|
|
"use '%select{false|true}0' instead of '%1'", callLoc)
|
|
<< b << name << expr->getSourceRange();
|
|
}
|
|
return true;
|
|
}
|
|
}
|
|
report(
|
|
DiagnosticsEngine::Warning,
|
|
"CStyleCastExpr, suspicious cast from %0 to %1",
|
|
compat::getBeginLoc(expr))
|
|
<< expr->getSubExpr()->IgnoreParenImpCasts()->getType()
|
|
<< expr->getType() << expr->getSourceRange();
|
|
}
|
|
return true;
|
|
}
|
|
|
|
bool SalBool::VisitCXXStaticCastExpr(CXXStaticCastExpr * expr) {
|
|
if (ignoreLocation(expr)) {
|
|
return true;
|
|
}
|
|
if (isSalBool(expr->getType())
|
|
&& !isInSpecialMainFile(
|
|
compiler.getSourceManager().getSpellingLoc(compat::getBeginLoc(expr))))
|
|
{
|
|
report(
|
|
DiagnosticsEngine::Warning,
|
|
"CXXStaticCastExpr, suspicious cast from %0 to %1",
|
|
compat::getBeginLoc(expr))
|
|
<< expr->getSubExpr()->IgnoreParenImpCasts()->getType()
|
|
<< expr->getType() << expr->getSourceRange();
|
|
}
|
|
return true;
|
|
}
|
|
|
|
bool SalBool::VisitCXXFunctionalCastExpr(CXXFunctionalCastExpr * expr) {
|
|
if (ignoreLocation(expr)) {
|
|
return true;
|
|
}
|
|
if (isSalBool(expr->getType())) {
|
|
report(
|
|
DiagnosticsEngine::Warning,
|
|
"CXXFunctionalCastExpr, suspicious cast from %0 to %1",
|
|
compat::getBeginLoc(expr))
|
|
<< expr->getSubExpr()->IgnoreParenImpCasts()->getType()
|
|
<< expr->getType() << expr->getSourceRange();
|
|
}
|
|
return true;
|
|
}
|
|
|
|
bool SalBool::VisitImplicitCastExpr(ImplicitCastExpr * expr) {
|
|
if (ignoreLocation(expr)) {
|
|
return true;
|
|
}
|
|
if (!isSalBool(expr->getType())) {
|
|
return true;
|
|
}
|
|
auto l = compat::getBeginLoc(expr);
|
|
while (compiler.getSourceManager().isMacroArgExpansion(l)) {
|
|
l = compiler.getSourceManager().getImmediateMacroCallerLoc(l);
|
|
}
|
|
if (compiler.getSourceManager().isMacroBodyExpansion(l)) {
|
|
auto n = Lexer::getImmediateMacroName(
|
|
l, compiler.getSourceManager(), compiler.getLangOpts());
|
|
if (n == "sal_False" || n == "sal_True") {
|
|
return true;
|
|
}
|
|
}
|
|
auto e1 = expr->getSubExprAsWritten();
|
|
auto t = e1->getType();
|
|
if (!t->isFundamentalType() || loplugin::TypeCheck(t).AnyBoolean()) {
|
|
return true;
|
|
}
|
|
auto e2 = dyn_cast<ConditionalOperator>(e1);
|
|
if (e2 != nullptr) {
|
|
auto ic1 = dyn_cast<ImplicitCastExpr>(
|
|
e2->getTrueExpr()->IgnoreParens());
|
|
auto ic2 = dyn_cast<ImplicitCastExpr>(
|
|
e2->getFalseExpr()->IgnoreParens());
|
|
if (ic1 != nullptr && ic2 != nullptr
|
|
&& ic1->getType()->isSpecificBuiltinType(BuiltinType::Int)
|
|
&& (loplugin::TypeCheck(ic1->getSubExprAsWritten()->getType())
|
|
.AnyBoolean())
|
|
&& ic2->getType()->isSpecificBuiltinType(BuiltinType::Int)
|
|
&& (loplugin::TypeCheck(ic2->getSubExprAsWritten()->getType())
|
|
.AnyBoolean()))
|
|
{
|
|
return true;
|
|
}
|
|
}
|
|
report(
|
|
DiagnosticsEngine::Warning, "conversion from %0 to sal_Bool",
|
|
compat::getBeginLoc(expr))
|
|
<< t << expr->getSourceRange();
|
|
return true;
|
|
}
|
|
|
|
bool SalBool::VisitReturnStmt(ReturnStmt const * stmt) {
|
|
// Just enough to avoid warnings in rtl_getUriCharClass (sal/rtl/uri.cxx),
|
|
// which has
|
|
//
|
|
// static sal_Bool const aCharClass[][nCharClassSize] = ...;
|
|
//
|
|
// and
|
|
//
|
|
// return aCharClass[eCharClass];
|
|
//
|
|
if (ignoreLocation(stmt)) {
|
|
return true;
|
|
}
|
|
auto e = stmt->getRetValue();
|
|
if (e == nullptr) {
|
|
return true;
|
|
}
|
|
auto t = e->getType();
|
|
if (!t->isPointerType()) {
|
|
return true;
|
|
}
|
|
for (;;) {
|
|
auto t2 = t->getAs<clang::PointerType>();
|
|
if (t2 == nullptr) {
|
|
break;
|
|
}
|
|
t = t2->getPointeeType();
|
|
}
|
|
if (!isSalBool(t)) {
|
|
return true;
|
|
}
|
|
auto e2 = dyn_cast<ArraySubscriptExpr>(e->IgnoreParenImpCasts());
|
|
if (e2 == nullptr) {
|
|
return true;
|
|
}
|
|
auto e3 = dyn_cast<DeclRefExpr>(e2->getBase()->IgnoreParenImpCasts());
|
|
if (e3 == nullptr) {
|
|
return true;
|
|
}
|
|
auto d = dyn_cast<VarDecl>(e3->getDecl());
|
|
if (d == nullptr) {
|
|
return true;
|
|
}
|
|
varDecls_.erase(d);
|
|
return true;
|
|
}
|
|
|
|
bool SalBool::WalkUpFromParmVarDecl(ParmVarDecl const * decl) {
|
|
return VisitParmVarDecl(decl);
|
|
}
|
|
|
|
bool SalBool::VisitParmVarDecl(ParmVarDecl const * decl) {
|
|
if (ignoreLocation(decl)) {
|
|
return true;
|
|
}
|
|
if (isSalBool(decl->getType().getNonReferenceType())) {
|
|
FunctionDecl const * f = dyn_cast<FunctionDecl>(decl->getDeclContext());
|
|
if (f != nullptr) { // e.g.: typedef sal_Bool (* FuncPtr )( sal_Bool );
|
|
f = f->getCanonicalDecl();
|
|
if (!(hasCLanguageLinkageType(f)
|
|
|| (isInUnoIncludeFile(f)
|
|
&& (!f->isInlined() || f->hasAttr<DeprecatedAttr>()
|
|
|| decl->getType()->isReferenceType()
|
|
|| hasBoolOverload(f, false)))
|
|
|| f->isDeleted() || hasBoolOverload(f, true)))
|
|
{
|
|
OverrideKind k = getOverrideKind(f);
|
|
if (k != OverrideKind::YES) {
|
|
SourceLocation loc { compat::getBeginLoc(decl) };
|
|
TypeSourceInfo * tsi = decl->getTypeSourceInfo();
|
|
if (tsi != nullptr) {
|
|
SourceLocation l {
|
|
compiler.getSourceManager().getExpansionLoc(
|
|
tsi->getTypeLoc().getBeginLoc()) };
|
|
SourceLocation end {
|
|
compiler.getSourceManager().getExpansionLoc(
|
|
tsi->getTypeLoc().getEndLoc()) };
|
|
assert(l.isFileID() && end.isFileID());
|
|
if (l == end
|
|
|| (compiler.getSourceManager()
|
|
.isBeforeInTranslationUnit(l, end)))
|
|
{
|
|
for (;;) {
|
|
unsigned n = Lexer::MeasureTokenLength(
|
|
l, compiler.getSourceManager(),
|
|
compiler.getLangOpts());
|
|
std::string s {
|
|
compiler.getSourceManager().getCharacterData(l),
|
|
n };
|
|
if (s == "sal_Bool") {
|
|
loc = l;
|
|
break;
|
|
}
|
|
if (l == end) {
|
|
break;
|
|
}
|
|
l = l.getLocWithOffset(std::max<unsigned>(n, 1));
|
|
}
|
|
}
|
|
}
|
|
// Only rewrite declarations in include files if a
|
|
// definition is also seen, to avoid compilation of a
|
|
// definition (in a main file only processed later) to fail
|
|
// with a "mismatch" error before the rewriter had a chance
|
|
// to act upon the definition (but use the heuristic of
|
|
// assuming pure virtual functions do not have definitions);
|
|
// also, do not automatically rewrite functions that could
|
|
// implicitly override depend base functions (and thus stop
|
|
// doing so after the rewrite; note that this is less
|
|
// dangerous for return types than for parameter types,
|
|
// where the function would still implicitly override and
|
|
// cause a compilation error due to the incompatible return
|
|
// type):
|
|
if (!((compiler.getSourceManager().isInMainFile(
|
|
compiler.getSourceManager().getSpellingLoc(
|
|
dyn_cast<FunctionDecl>(
|
|
decl->getDeclContext())
|
|
->getNameInfo().getLoc()))
|
|
|| f->isDefined() || f->isPure())
|
|
&& k != OverrideKind::MAYBE && rewrite(loc)))
|
|
{
|
|
report(
|
|
DiagnosticsEngine::Warning,
|
|
("ParmVarDecl, use \"bool\" instead of"
|
|
" \"sal_Bool\"%0"),
|
|
loc)
|
|
<< (k == OverrideKind::MAYBE
|
|
? (" (unless this member function overrides a"
|
|
" dependent base member function, even"
|
|
" though it is not marked 'override')")
|
|
: "")
|
|
<< decl->getSourceRange();
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
return true;
|
|
}
|
|
|
|
bool SalBool::WalkUpFromVarDecl(VarDecl const * decl) {
|
|
return VisitVarDecl(decl);
|
|
}
|
|
|
|
bool SalBool::VisitVarDecl(VarDecl const * decl) {
|
|
if (ignoreLocation(decl)) {
|
|
return true;
|
|
}
|
|
if (!decl->isExternC()
|
|
&& (isSalBool(decl->getType()) || isSalBoolArray(decl->getType()))
|
|
&& !isInSpecialMainFile(
|
|
compiler.getSourceManager().getSpellingLoc(compat::getBeginLoc(decl))))
|
|
{
|
|
varDecls_.insert(decl);
|
|
}
|
|
return true;
|
|
}
|
|
|
|
bool SalBool::WalkUpFromFieldDecl(FieldDecl const * decl) {
|
|
return VisitFieldDecl(decl);
|
|
}
|
|
|
|
bool SalBool::VisitFieldDecl(FieldDecl const * decl) {
|
|
if (ignoreLocation(decl)) {
|
|
return true;
|
|
}
|
|
if ((isSalBool(decl->getType()) || isSalBoolArray(decl->getType()))
|
|
&& !isInSpecialMainFile(
|
|
compiler.getSourceManager().getSpellingLoc(compat::getBeginLoc(decl))))
|
|
{
|
|
TagDecl const * td = dyn_cast<TagDecl>(decl->getDeclContext());
|
|
assert(td != nullptr);
|
|
if (!(((td->isStruct() || td->isUnion()) && td->isExternCContext())
|
|
|| isInUnoIncludeFile(
|
|
compiler.getSourceManager().getSpellingLoc(
|
|
decl->getLocation()))))
|
|
{
|
|
SourceLocation loc { compat::getBeginLoc(decl) };
|
|
TypeSourceInfo * tsi = decl->getTypeSourceInfo();
|
|
if (tsi != nullptr) {
|
|
SourceLocation l {
|
|
compiler.getSourceManager().getExpansionLoc(
|
|
tsi->getTypeLoc().getBeginLoc()) };
|
|
SourceLocation end {
|
|
compiler.getSourceManager().getExpansionLoc(
|
|
tsi->getTypeLoc().getEndLoc()) };
|
|
assert(l.isFileID() && end.isFileID());
|
|
if (l == end
|
|
|| compiler.getSourceManager().isBeforeInTranslationUnit(
|
|
l, end))
|
|
{
|
|
for (;;) {
|
|
unsigned n = Lexer::MeasureTokenLength(
|
|
l, compiler.getSourceManager(),
|
|
compiler.getLangOpts());
|
|
std::string s {
|
|
compiler.getSourceManager().getCharacterData(l),
|
|
n };
|
|
if (s == "sal_Bool") {
|
|
loc = l;
|
|
break;
|
|
}
|
|
if (l == end) {
|
|
break;
|
|
}
|
|
l = l.getLocWithOffset(std::max<unsigned>(n, 1));
|
|
}
|
|
}
|
|
}
|
|
if (!rewrite(loc)) {
|
|
report(
|
|
DiagnosticsEngine::Warning,
|
|
"FieldDecl, use \"bool\" instead of \"sal_Bool\"", loc)
|
|
<< decl->getSourceRange();
|
|
}
|
|
}
|
|
}
|
|
return true;
|
|
}
|
|
|
|
bool SalBool::WalkUpFromFunctionDecl(FunctionDecl const * decl) {
|
|
return VisitFunctionDecl(decl);
|
|
}
|
|
|
|
bool SalBool::VisitFunctionDecl(FunctionDecl const * decl) {
|
|
if (ignoreLocation(decl)) {
|
|
return true;
|
|
}
|
|
if (isSalBool(decl->getReturnType().getNonReferenceType())
|
|
&& !(decl->isDeletedAsWritten() && isa<CXXConversionDecl>(decl)))
|
|
{
|
|
FunctionDecl const * f = decl->getCanonicalDecl();
|
|
OverrideKind k = getOverrideKind(f);
|
|
if (k != OverrideKind::YES
|
|
&& !(hasCLanguageLinkageType(f)
|
|
|| (isInUnoIncludeFile(f)
|
|
&& (!f->isInlined() || f->hasAttr<DeprecatedAttr>()))))
|
|
{
|
|
SourceLocation loc { compat::getBeginLoc(decl) };
|
|
SourceLocation l { compiler.getSourceManager().getExpansionLoc(
|
|
loc) };
|
|
SourceLocation end { compiler.getSourceManager().getExpansionLoc(
|
|
decl->getNameInfo().getLoc()) };
|
|
assert(l.isFileID() && end.isFileID());
|
|
if (compiler.getSourceManager().isBeforeInTranslationUnit(l, end)) {
|
|
while (l != end) {
|
|
unsigned n = Lexer::MeasureTokenLength(
|
|
l, compiler.getSourceManager(), compiler.getLangOpts());
|
|
std::string s {
|
|
compiler.getSourceManager().getCharacterData(l), n };
|
|
if (s == "sal_Bool") {
|
|
loc = l;
|
|
break;
|
|
}
|
|
l = l.getLocWithOffset(std::max<unsigned>(n, 1));
|
|
}
|
|
}
|
|
// Only rewrite declarations in include files if a definition is
|
|
// also seen, to avoid compilation of a definition (in a main file
|
|
// only processed later) to fail with a "mismatch" error before the
|
|
// rewriter had a chance to act upon the definition (but use the
|
|
// heuristic of assuming pure virtual functions do not have
|
|
// definitions):
|
|
if (!((compiler.getSourceManager().isInMainFile(
|
|
compiler.getSourceManager().getSpellingLoc(
|
|
decl->getNameInfo().getLoc()))
|
|
|| f->isDefined() || f->isPure())
|
|
&& rewrite(loc)))
|
|
{
|
|
report(
|
|
DiagnosticsEngine::Warning,
|
|
"use \"bool\" instead of \"sal_Bool\" as return type%0",
|
|
loc)
|
|
<< (k == OverrideKind::MAYBE
|
|
? (" (unless this member function overrides a dependent"
|
|
" base member function, even though it is not marked"
|
|
" 'override')")
|
|
: "")
|
|
<< decl->getSourceRange();
|
|
}
|
|
}
|
|
}
|
|
return true;
|
|
}
|
|
|
|
bool SalBool::VisitValueDecl(ValueDecl const * decl) {
|
|
if (ignoreLocation(decl)) {
|
|
return true;
|
|
}
|
|
if (isSalBool(decl->getType()) && !rewrite(compat::getBeginLoc(decl))) {
|
|
report(
|
|
DiagnosticsEngine::Warning,
|
|
"ValueDecl, use \"bool\" instead of \"sal_Bool\"",
|
|
compat::getBeginLoc(decl))
|
|
<< decl->getSourceRange();
|
|
}
|
|
return true;
|
|
}
|
|
|
|
bool SalBool::TraverseStaticAssertDecl(StaticAssertDecl * decl) {
|
|
// Ignore special code like
|
|
//
|
|
// static_cast<sal_Bool>(true) == sal_True
|
|
//
|
|
// inside static_assert in cppu/source/uno/check.cxx:
|
|
return
|
|
loplugin::isSamePathname(
|
|
getFileNameOfSpellingLoc(decl->getLocation()),
|
|
SRCDIR "/cppu/source/uno/check.cxx")
|
|
|| RecursiveASTVisitor::TraverseStaticAssertDecl(decl);
|
|
}
|
|
|
|
bool SalBool::TraverseLinkageSpecDecl(LinkageSpecDecl * decl) {
|
|
assert(externCContexts_ != std::numeric_limits<unsigned int>::max()); //TODO
|
|
++externCContexts_;
|
|
bool ret = RecursiveASTVisitor::TraverseLinkageSpecDecl(decl);
|
|
assert(externCContexts_ != 0);
|
|
--externCContexts_;
|
|
return ret;
|
|
}
|
|
|
|
bool SalBool::isFromCIncludeFile(SourceLocation spellingLocation) const {
|
|
return !compiler.getSourceManager().isInMainFile(spellingLocation)
|
|
&& (StringRef(
|
|
compiler.getSourceManager().getPresumedLoc(spellingLocation)
|
|
.getFilename())
|
|
.endswith(".h"));
|
|
}
|
|
|
|
bool SalBool::isSharedCAndCppCode(SourceLocation location) const {
|
|
// Assume that code is intended to be shared between C and C++ if it comes
|
|
// from an include file ending in .h, and is either in an extern "C" context
|
|
// or the body of a macro definition:
|
|
return
|
|
isFromCIncludeFile(compiler.getSourceManager().getSpellingLoc(location))
|
|
&& (externCContexts_ != 0
|
|
|| compiler.getSourceManager().isMacroBodyExpansion(location));
|
|
}
|
|
|
|
bool SalBool::isInSpecialMainFile(SourceLocation spellingLocation) const {
|
|
if (!compiler.getSourceManager().isInMainFile(spellingLocation)) {
|
|
return false;
|
|
}
|
|
auto f = getFileNameOfSpellingLoc(spellingLocation);
|
|
return loplugin::isSamePathname(f, SRCDIR "/cppu/qa/test_any.cxx")
|
|
|| loplugin::isSamePathname(f, SRCDIR "/cppu/source/uno/check.cxx");
|
|
// TODO: the offset checks
|
|
}
|
|
|
|
bool SalBool::rewrite(SourceLocation location) {
|
|
if (rewriter != nullptr) {
|
|
//TODO: "::sal_Bool" -> "bool", not "::bool"
|
|
SourceLocation loc { compiler.getSourceManager().getExpansionLoc(
|
|
location) };
|
|
unsigned n = Lexer::MeasureTokenLength(
|
|
loc, compiler.getSourceManager(), compiler.getLangOpts());
|
|
if (std::string(compiler.getSourceManager().getCharacterData(loc), n)
|
|
== "sal_Bool")
|
|
{
|
|
return replaceText(loc, n, "bool");
|
|
}
|
|
}
|
|
return false;
|
|
}
|
|
|
|
loplugin::Plugin::Registration<SalBool> X("salbool", true);
|
|
|
|
}
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|