0e493cae40
enforce that DBG_UNHANDLED_EXCEPTION is called first in a catch block, otherwise it cannot do it's job properly Change-Id: I906436c6861212c44f8f21552ccbceb54f15c6e1 Reviewed-on: https://gerrit.libreoffice.org/52303 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
108 lines
2.9 KiB
C++
108 lines
2.9 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* Based on LLVM/Clang.
|
|
*
|
|
* This file is distributed under the University of Illinois Open Source
|
|
* License. See LICENSE.TXT for details.
|
|
*
|
|
*/
|
|
|
|
#include "check.hxx"
|
|
#include "plugin.hxx"
|
|
#include <clang/Lex/Lexer.h>
|
|
#include <fstream>
|
|
#include <set>
|
|
|
|
namespace loplugin
|
|
{
|
|
/*
|
|
This is a compile check.
|
|
|
|
Check that DBG_UNHANDLED_EXCEPTION is always the first statement in a catch block, otherwise
|
|
it does not work properly.
|
|
*/
|
|
|
|
class DbgUnhandledException : public RecursiveASTVisitor<DbgUnhandledException>, public Plugin
|
|
{
|
|
public:
|
|
explicit DbgUnhandledException(InstantiationData const& data);
|
|
virtual void run() override;
|
|
bool VisitCallExpr(CallExpr const* call);
|
|
bool TraverseCXXCatchStmt(CXXCatchStmt*);
|
|
|
|
private:
|
|
CXXCatchStmt const* currCatchStmt = nullptr;
|
|
};
|
|
|
|
DbgUnhandledException::DbgUnhandledException(const InstantiationData& data)
|
|
: Plugin(data)
|
|
{
|
|
}
|
|
|
|
void DbgUnhandledException::run()
|
|
{
|
|
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
|
|
}
|
|
|
|
bool DbgUnhandledException::TraverseCXXCatchStmt(CXXCatchStmt* catchStmt)
|
|
{
|
|
auto prevCatchStmt = currCatchStmt;
|
|
currCatchStmt = catchStmt;
|
|
auto rv = RecursiveASTVisitor::TraverseCXXCatchStmt(catchStmt);
|
|
currCatchStmt = prevCatchStmt;
|
|
return rv;
|
|
}
|
|
|
|
bool DbgUnhandledException::VisitCallExpr(const CallExpr* call)
|
|
{
|
|
if (ignoreLocation(call))
|
|
return true;
|
|
const FunctionDecl* func = call->getDirectCallee();
|
|
if (!func)
|
|
return true;
|
|
|
|
if (!func->getIdentifier() || func->getName() != "DbgUnhandledException")
|
|
return true;
|
|
|
|
if (!currCatchStmt)
|
|
{
|
|
report(DiagnosticsEngine::Warning, "DBG_UNHANDLED_EXCEPTION outside catch block",
|
|
call->getLocStart());
|
|
return true;
|
|
}
|
|
auto catchBlock = dyn_cast<CompoundStmt>(currCatchStmt->getHandlerBlock());
|
|
if (!catchBlock)
|
|
{
|
|
report(DiagnosticsEngine::Warning,
|
|
"something wrong with DBG_UNHANDLED_EXCEPTION, no CompoundStmt?",
|
|
call->getLocStart());
|
|
return true;
|
|
}
|
|
if (catchBlock->size() < 1)
|
|
{
|
|
report(DiagnosticsEngine::Warning,
|
|
"something wrong with DBG_UNHANDLED_EXCEPTION, CompoundStmt size == 0?",
|
|
call->getLocStart());
|
|
return true;
|
|
}
|
|
|
|
Stmt const* firstStmt = *catchBlock->body_begin();
|
|
if (auto exprWithCleanups = dyn_cast<ExprWithCleanups>(firstStmt))
|
|
firstStmt = exprWithCleanups->getSubExpr();
|
|
if (firstStmt != call)
|
|
{
|
|
report(DiagnosticsEngine::Warning,
|
|
"DBG_UNHANDLED_EXCEPTION must be first statement in catch block",
|
|
call->getLocStart());
|
|
}
|
|
return true;
|
|
}
|
|
|
|
static Plugin::Registration<DbgUnhandledException> X("dbgunhandledexception");
|
|
|
|
} // namespace
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|