adb08e892b
Each plugin currently uses its own recursive AST run, which adds up. This patch adds another shared plugin which internally contains all (suitable) plugins and dispatches to them from the same one recursive run. This patch converts ~25 plugins and for starmath's accessibility.cxx reduces clang build time from 5.43s to 5.14s (and it's 4.39s without any plugins). As there are almost 50 more plugins to go, this can theoretically result in 4.56s final time, although probably not all plugins can be that easily converted, if at all. This mostly requires very little change in many plugins (see e.g. BadStatics), some even work without any functionality change (e.g. CharRightShift). Traverse* calls require some changes but are often not that difficult. WalkUp* probably can't be supported, although some plugins can(?) possibly be adjusted to not rely on them. And of course some plugins can be left as they are, using their own recursive run. See description at the top of generator.cxx for description of how to convert a plugin. The sharedvisitor.cxx source is generated based on scanning relevant plugin sources using a clang-based scanner/generator. The generated source is intentionally included instead of getting always generated, as the generating currently takes some time, so it should get updated in git whenever a change in a plugin triggers a source change in it. Change-Id: Ia0d2e3a5a464659503dbb4ed6c20b6cc89b4de01 Reviewed-on: https://gerrit.libreoffice.org/68026 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
100 lines
2.9 KiB
C++
100 lines
2.9 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* Based on LLVM/Clang.
|
|
*
|
|
* This file is distributed under the University of Illinois Open Source
|
|
* License. See LICENSE.TXT for details.
|
|
*
|
|
*/
|
|
|
|
#ifndef PLUGINHANDLER_H
|
|
#define PLUGINHANDLER_H
|
|
|
|
#include <cstddef>
|
|
#include <functional>
|
|
#include <memory>
|
|
#include <set>
|
|
#include <unordered_map>
|
|
|
|
#include <clang/AST/ASTConsumer.h>
|
|
#include <clang/Frontend/CompilerInstance.h>
|
|
#include <clang/Frontend/FrontendAction.h>
|
|
#include <clang/Rewrite/Core/Rewriter.h>
|
|
|
|
using namespace clang;
|
|
|
|
namespace std {
|
|
|
|
template<> struct hash<::clang::SourceLocation> {
|
|
size_t operator ()(::clang::SourceLocation loc) const
|
|
{ return loc.getRawEncoding(); }
|
|
};
|
|
|
|
}
|
|
|
|
namespace loplugin
|
|
{
|
|
|
|
class Plugin;
|
|
struct InstantiationData;
|
|
|
|
/**
|
|
Class that manages all LO modules.
|
|
*/
|
|
class PluginHandler
|
|
: public ASTConsumer
|
|
{
|
|
public:
|
|
PluginHandler( CompilerInstance& compiler, const std::vector< std::string >& args );
|
|
virtual ~PluginHandler();
|
|
virtual void HandleTranslationUnit( ASTContext& context ) override;
|
|
static void registerPlugin( Plugin* (*create)( const InstantiationData& ), const char* optionName,
|
|
bool isPPCallback, bool isSharedPlugin, bool byDefault );
|
|
DiagnosticBuilder report( DiagnosticsEngine::Level level, const char * plugin, StringRef message,
|
|
CompilerInstance& compiler, SourceLocation loc = SourceLocation());
|
|
bool ignoreLocation(SourceLocation loc);
|
|
bool isDebugMode() const { return debugMode; }
|
|
static bool isUnitTestMode();
|
|
// If we overlap with a previous area we modified, we cannot perform this change
|
|
// without corrupting the source
|
|
bool checkOverlap(SourceRange range);
|
|
void addSourceModification(SourceRange range);
|
|
StringRef const& getMainFileName() const { return mainFileName; }
|
|
private:
|
|
void handleOption( const std::string& option );
|
|
void createPlugins( std::set< std::string > rewriters );
|
|
DiagnosticBuilder report( DiagnosticsEngine::Level level, StringRef message, SourceLocation loc = SourceLocation());
|
|
bool checkIgnoreLocation(SourceLocation loc);
|
|
CompilerInstance& compiler;
|
|
StringRef const mainFileName;
|
|
std::unordered_map<SourceLocation, bool> ignored_;
|
|
Rewriter rewriter;
|
|
std::string scope;
|
|
std::string warningsOnly;
|
|
bool warningsAsErrors;
|
|
bool debugMode = false;
|
|
std::vector<std::pair<char const*, char const*>> mvModifiedRanges;
|
|
};
|
|
|
|
/**
|
|
The Clang plugin class, just forwards to PluginHandler.
|
|
*/
|
|
class LibreOfficeAction
|
|
: public PluginASTAction
|
|
{
|
|
public:
|
|
virtual std::unique_ptr<ASTConsumer> CreateASTConsumer( CompilerInstance& Compiler, StringRef InFile );
|
|
|
|
virtual bool ParseArgs( const CompilerInstance& CI, const std::vector< std::string >& args );
|
|
private:
|
|
std::vector< std::string > _args;
|
|
};
|
|
|
|
}
|
|
|
|
#endif // COMPILEPLUGIN_H
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|