adb08e892b
Each plugin currently uses its own recursive AST run, which adds up. This patch adds another shared plugin which internally contains all (suitable) plugins and dispatches to them from the same one recursive run. This patch converts ~25 plugins and for starmath's accessibility.cxx reduces clang build time from 5.43s to 5.14s (and it's 4.39s without any plugins). As there are almost 50 more plugins to go, this can theoretically result in 4.56s final time, although probably not all plugins can be that easily converted, if at all. This mostly requires very little change in many plugins (see e.g. BadStatics), some even work without any functionality change (e.g. CharRightShift). Traverse* calls require some changes but are often not that difficult. WalkUp* probably can't be supported, although some plugins can(?) possibly be adjusted to not rely on them. And of course some plugins can be left as they are, using their own recursive run. See description at the top of generator.cxx for description of how to convert a plugin. The sharedvisitor.cxx source is generated based on scanning relevant plugin sources using a clang-based scanner/generator. The generated source is intentionally included instead of getting always generated, as the generating currently takes some time, so it should get updated in git whenever a change in a plugin triggers a source change in it. Change-Id: Ia0d2e3a5a464659503dbb4ed6c20b6cc89b4de01 Reviewed-on: https://gerrit.libreoffice.org/68026 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
84 lines
2.7 KiB
C++
84 lines
2.7 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* Based on LLVM/Clang.
|
|
*
|
|
* This file is distributed under the University of Illinois Open Source
|
|
* License. See LICENSE.TXT for details.
|
|
*
|
|
*/
|
|
|
|
#ifndef LO_CLANG_SHARED_PLUGINS
|
|
|
|
#include <config_global.h>
|
|
|
|
#include "compat.hxx"
|
|
#include "check.hxx"
|
|
#include "unusedvariablecheck.hxx"
|
|
|
|
namespace loplugin
|
|
{
|
|
|
|
/*
|
|
This is a compile check.
|
|
|
|
Check for unused classes where the compiler cannot decide (e.g. because of
|
|
non-trivial or extern ctors) if a variable is unused if only its ctor/dtor
|
|
are called and nothing else. For example std::vector is a class where
|
|
the ctor may call further functions, but an unused std::string variable
|
|
does nothing. On the other hand, std::lock_guard instances are used
|
|
for their dtors and so are not unused even if not otherwise accessed.
|
|
|
|
Classes which are safe to be warned about need to be marked using
|
|
SAL_WARN_UNUSED (see e.g. OUString). For external classes such as std::vector
|
|
that cannot be edited there is a manual list below.
|
|
*/
|
|
|
|
UnusedVariableCheck::UnusedVariableCheck( const InstantiationData& data )
|
|
: FilteringPlugin( data )
|
|
{
|
|
}
|
|
|
|
void UnusedVariableCheck::run()
|
|
{
|
|
TraverseDecl( compiler.getASTContext().getTranslationUnitDecl());
|
|
}
|
|
|
|
bool UnusedVariableCheck::VisitVarDecl( const VarDecl* var )
|
|
{
|
|
if( ignoreLocation( var ))
|
|
return true;
|
|
if( var->isReferenced() || var->isUsed())
|
|
return true;
|
|
if( var->isDefinedOutsideFunctionOrMethod())
|
|
return true;
|
|
if( loplugin::isExtraWarnUnusedType(var->getType()))
|
|
{
|
|
if( const ParmVarDecl* param = dyn_cast< ParmVarDecl >( var ))
|
|
{
|
|
if( !param->getDeclName())
|
|
return true; // unnamed parameter -> unused
|
|
// If this declaration does not have a body, then the parameter is indeed not used,
|
|
// so ignore.
|
|
if( const FunctionDecl* func = dyn_cast_or_null< FunctionDecl >( param->getParentFunctionOrMethod()))
|
|
if( !func->doesThisDeclarationHaveABody())
|
|
return true;
|
|
report( DiagnosticsEngine::Warning, "unused parameter %0",
|
|
var->getLocation()) << var->getDeclName();
|
|
}
|
|
else
|
|
report( DiagnosticsEngine::Warning, "unused variable %0",
|
|
var->getLocation()) << var->getDeclName();
|
|
}
|
|
return true;
|
|
}
|
|
|
|
static Plugin::Registration< UnusedVariableCheck > unusedvariablecheck( "unusedvariablecheck" );
|
|
|
|
} // namespace
|
|
|
|
#endif // LO_CLANG_SHARED_PLUGINS
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|