Files
libreoffice/compilerplugins/clang/check.hxx
Stephan Bergmann 50696615fa loplugin:typedefparam: Work around different size_t typedefs on macOS
...which for me caused

> [CXX] registry/tools/options.cxx
> /Users/stephan/Software/lo/core/registry/tools/options.cxx:39:89: error: function param 3 at definition site does not match function param at declaration site, 'size_t' (aka 'unsigned long') vs 'size_t' (aka 'unsigned long') [loplugin:typedefparam]
> bool Options::checkArgument(std::vector< std::string> & rArgs, char const * arg, size_t len)
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
> /Users/stephan/Software/lo/core/registry/tools/options.hxx:41:93: note: declaration site here [loplugin:typedefparam]
>     static bool checkArgument (std::vector< std::string > & rArgs, char const * arg, size_t len);
>     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~

because one is

  TypedefType 0x115a4d700 'size_t' sugar
  |-Typedef 0x115a4d460 'size_t'
  `-BuiltinType 0x7fde8e0393c0 'unsigned long'

while the other is

  TypedefType 0x7fde8e94a3a0 'size_t' sugar
  |-Typedef 0x7fde8e94a138 'size_t'
  `-TypedefType 0x7fde8e94a100 '__darwin_size_t' sugar
    |-Typedef 0x7fde8e88cc28 '__darwin_size_t'
    `-BuiltinType 0x7fde8e0393c0 'unsigned long'

and

> [CXX] store/source/storcach.cxx
> /Users/stephan/Software/lo/core/store/source/storcach.cxx:218:43: error: function param 1 at definition site does not match function param at declaration site, 'std::size_t' (aka 'unsigned long') vs 'std::size_t' (aka 'unsigned long') [loplugin:typedefparam]
> void PageCache::rescale_Impl (std::size_t new_size)
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
> /Users/stephan/Software/lo/core/store/source/storcach.hxx:67:36: note: declaration site here [loplugin:typedefparam]
>     void rescale_Impl (std::size_t new_size);
>     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~

because one is

  ElaboratedType 0x116f5cba0 'std::size_t' sugar
  `-TypedefType 0x7fd58673e090 'size_t' sugar
    |-Typedef 0x7fd58673dde8 'size_t'
    `-BuiltinType 0x7fd58603cfc0 'unsigned long'

while the other is

  ElaboratedType 0x7fd586742200 'std::size_t' sugar
  `-TypedefType 0x7fd58621cdc0 'size_t' sugar
    |-Typedef 0x7fd5861ce4a0 'size_t'
    `-TypedefType 0x7fd5861cdc70 '__darwin_size_t' sugar
      |-Typedef 0x7fd586889ec8 '__darwin_size_t'
      `-BuiltinType 0x7fd58603cfc0 'unsigned long'

Change-Id: I3622716376198cc046b0489db59c5cbf613ea1f4
Reviewed-on: https://gerrit.libreoffice.org/73585
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-06 13:06:32 +02:00

284 lines
7.1 KiB
C++

/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/*
* This file is part of the LibreOffice project.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
#ifndef INCLUDED_COMPILERPLUGINS_CLANG_CHECK_HXX
#define INCLUDED_COMPILERPLUGINS_CLANG_CHECK_HXX
#include <cstddef>
#include <clang/AST/DeclBase.h>
#include <clang/AST/Decl.h>
#include <clang/AST/Type.h>
#include <clang/Basic/OperatorKinds.h>
namespace loplugin {
class ContextCheck;
class TerminalCheck;
namespace detail {
inline ContextCheck checkRecordDecl(
clang::Decl const * decl, clang::TagTypeKind tag, llvm::StringRef id);
}
class TypeCheck {
public:
explicit TypeCheck(clang::QualType type): type_(type) {}
explicit TypeCheck(clang::Type const * type): type_(type, 0) {}
explicit TypeCheck(clang::TypeDecl const * decl): type_(decl->getTypeForDecl(), 0) {}
explicit operator bool() const { return !type_.isNull(); }
TypeCheck NonConst() const;
TypeCheck NonConstVolatile() const;
TypeCheck Const() const;
TypeCheck Volatile() const;
TypeCheck ConstVolatile() const;
TerminalCheck Void() const;
TerminalCheck Char() const;
TerminalCheck AnyBoolean() const;
TypeCheck Pointer() const;
TerminalCheck Enum() const;
TypeCheck LvalueReference() const;
inline ContextCheck Class(llvm::StringRef id) const;
inline ContextCheck Struct(llvm::StringRef id) const;
TypeCheck Typedef() const;
inline ContextCheck Typedef(llvm::StringRef id) const;
TypeCheck NotSubstTemplateTypeParmType() const;
private:
TypeCheck() = default;
clang::QualType const type_{};
};
class DeclCheck {
public:
explicit DeclCheck(clang::Decl const * decl): decl_(decl) {}
explicit operator bool() const { return decl_ != nullptr; }
inline ContextCheck Class(llvm::StringRef id) const;
inline ContextCheck Struct(llvm::StringRef id) const;
inline ContextCheck Union(llvm::StringRef id) const;
inline ContextCheck Function(llvm::StringRef id) const;
ContextCheck Operator(clang::OverloadedOperatorKind op) const;
inline ContextCheck Var(llvm::StringRef id) const;
ContextCheck MemberFunction() const;
private:
clang::Decl const * const decl_;
};
class ContextCheck {
public:
explicit operator bool() const { return context_ != nullptr; }
TerminalCheck GlobalNamespace() const;
inline ContextCheck Namespace(llvm::StringRef id) const;
TerminalCheck StdNamespace() const;
ContextCheck AnonymousNamespace() const;
inline ContextCheck Class(llvm::StringRef id) const;
inline ContextCheck Struct(llvm::StringRef id) const;
explicit ContextCheck(const clang::NamespaceDecl * decl ) : context_( decl ) {}
private:
friend DeclCheck;
friend TypeCheck;
friend ContextCheck detail::checkRecordDecl(
clang::Decl const * decl, clang::TagTypeKind tag, llvm::StringRef id);
explicit ContextCheck(clang::DeclContext const * context = nullptr):
context_(context) {}
clang::DeclContext const * const context_;
};
class TerminalCheck {
public:
explicit operator bool() const { return satisfied_; }
private:
friend ContextCheck;
friend TypeCheck;
explicit TerminalCheck(bool satisfied): satisfied_(satisfied) {}
bool const satisfied_;
};
typedef std::function<bool(clang::Decl const *)> DeclChecker;
// Returns true if the class has a base matching the checker, or if the class itself matches.
bool isDerivedFrom(const clang::CXXRecordDecl *decl, DeclChecker base);
namespace detail {
ContextCheck checkRecordDecl(
clang::Decl const * decl, clang::TagTypeKind tag, llvm::StringRef id)
{
auto r = llvm::dyn_cast_or_null<clang::RecordDecl>(decl);
if (r != nullptr && r->getTagKind() == tag) {
auto const i = r->getIdentifier();
if (i != nullptr && i->getName() == id) {
return ContextCheck(r->getDeclContext());
}
}
return ContextCheck();
}
}
ContextCheck TypeCheck::Class(llvm::StringRef id)
const
{
if (!type_.isNull()) {
auto const t = type_->getAs<clang::RecordType>();
if (t != nullptr) {
return detail::checkRecordDecl(t->getDecl(), clang::TTK_Class, id);
}
}
return ContextCheck();
}
ContextCheck TypeCheck::Struct(llvm::StringRef id) const
{
if (!type_.isNull()) {
auto const t = type_->getAs<clang::RecordType>();
if (t != nullptr) {
return detail::checkRecordDecl(t->getDecl(), clang::TTK_Struct, id);
}
}
return ContextCheck();
}
ContextCheck TypeCheck::Typedef(llvm::StringRef id) const
{
if (!type_.isNull()) {
if (auto const t = type_->getAs<clang::TypedefType>()) {
auto const d = t->getDecl();
auto const i = d->getIdentifier();
assert(i != nullptr);
if (i->getName() == id) {
return ContextCheck(d->getDeclContext());
}
}
}
return ContextCheck();
}
ContextCheck DeclCheck::Class(llvm::StringRef id) const
{
return detail::checkRecordDecl(decl_, clang::TTK_Class, id);
}
ContextCheck DeclCheck::Struct(llvm::StringRef id) const
{
return detail::checkRecordDecl(decl_, clang::TTK_Struct, id);
}
ContextCheck DeclCheck::Union(llvm::StringRef id) const
{
return detail::checkRecordDecl(decl_, clang::TTK_Union, id);
}
ContextCheck DeclCheck::Function(llvm::StringRef id) const
{
auto f = llvm::dyn_cast_or_null<clang::FunctionDecl>(decl_);
if (f != nullptr) {
auto const i = f->getIdentifier();
if (i != nullptr && i->getName() == id) {
return ContextCheck(f->getDeclContext());
}
}
return ContextCheck();
}
ContextCheck DeclCheck::Var(llvm::StringRef id) const
{
auto f = llvm::dyn_cast_or_null<clang::VarDecl>(decl_);
if (f != nullptr) {
auto const i = f->getIdentifier();
if (i != nullptr && i->getName() == id) {
return ContextCheck(f->getDeclContext());
}
}
return ContextCheck();
}
ContextCheck ContextCheck::Namespace(llvm::StringRef id) const
{
if (context_) {
auto n = llvm::dyn_cast<clang::NamespaceDecl>(context_);
if (n != nullptr) {
auto const i = n->getIdentifier();
if (i != nullptr && i->getName() == id) {
return ContextCheck(n->getParent());
}
}
}
return ContextCheck();
}
ContextCheck ContextCheck::Class(llvm::StringRef id) const
{
return detail::checkRecordDecl(
llvm::dyn_cast_or_null<clang::Decl>(context_), clang::TTK_Class, id);
}
ContextCheck ContextCheck::Struct(llvm::StringRef id) const
{
return detail::checkRecordDecl(
llvm::dyn_cast_or_null<clang::Decl>(context_), clang::TTK_Struct, id);
}
bool isExtraWarnUnusedType(clang::QualType type);
bool isOkToRemoveArithmeticCast(
clang::ASTContext & context, clang::QualType t1, clang::QualType t2,
const clang::Expr* subExpr);
}
#endif
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */