7d8196ea2f
There were over 150 places in *::Notify() functions that did some dynamic_cast<SfxSimpleHint*> of which ~98% were unnecessary because the base class SfxHint passed was an SfxSimpleHint anyway. dynamic_cast operations come with quite some cost, so avoid if possible. Specifically for ScFormulaCell::Notify() that created a bottleneck in scenarios where cells were notified that already handled a previous notification. In mass operations doing the dynamic_cast before it could be decided whether having to act on it or not this made 2/3 of all time spent in the Notify() call. To get rid of that rename/move SfxSimpleHint to SfxHint and let classes derive from SfxHint instead of SfxSimpleHint. This comes only with a slight cost that an additional sal_uInt32 is transported in such hints, initialized to 0, but this is neglectable compared to the huge gain. For the rare cases where a Notify() actually expects both, an SfxHint (formerly SfxSimpleHint) and a derived hint, this changed order of the dynamic_cast involved so the simple SfxHint::GetId() is handled last. Modules using such combinations can further optimize by treating the simple SfxHint::GetId() first once verified that none of the other derived hints use an ID not equal to zero respectively none of the ID values the simple hint uses. Change-Id: I9fcf723e3a4487ceb92336189d23a62c344cf0ce Reviewed-on: https://gerrit.libreoffice.org/29205 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
101 lines
2.4 KiB
C++
101 lines
2.4 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*/
|
|
|
|
#include <refhint.hxx>
|
|
|
|
namespace sc {
|
|
|
|
RefHint::RefHint( Type eType ) : SfxHint(SC_HINT_REFERENCE), meType(eType) {}
|
|
RefHint::~RefHint() {}
|
|
|
|
RefHint::Type RefHint::getType() const
|
|
{
|
|
return meType;
|
|
}
|
|
|
|
RefMovedHint::RefMovedHint( const ScRange& rRange, const ScAddress& rMove, const sc::RefUpdateContext& rCxt ) :
|
|
RefHint(Moved), maRange(rRange), maMoveDelta(rMove), mrCxt(rCxt) {}
|
|
|
|
RefMovedHint::~RefMovedHint() {}
|
|
|
|
const ScRange& RefMovedHint::getRange() const
|
|
{
|
|
return maRange;
|
|
}
|
|
|
|
const ScAddress& RefMovedHint::getDelta() const
|
|
{
|
|
return maMoveDelta;
|
|
}
|
|
|
|
const sc::RefUpdateContext& RefMovedHint::getContext() const
|
|
{
|
|
return mrCxt;
|
|
}
|
|
|
|
RefColReorderHint::RefColReorderHint( const sc::ColRowReorderMapType& rColMap, SCTAB nTab, SCROW nRow1, SCROW nRow2 ) :
|
|
RefHint(ColumnReordered), mrColMap(rColMap), mnTab(nTab), mnRow1(nRow1), mnRow2(nRow2) {}
|
|
|
|
RefColReorderHint::~RefColReorderHint() {}
|
|
|
|
const sc::ColRowReorderMapType& RefColReorderHint::getColMap() const
|
|
{
|
|
return mrColMap;
|
|
}
|
|
|
|
SCTAB RefColReorderHint::getTab() const
|
|
{
|
|
return mnTab;
|
|
}
|
|
|
|
SCROW RefColReorderHint::getStartRow() const
|
|
{
|
|
return mnRow1;
|
|
}
|
|
|
|
SCROW RefColReorderHint::getEndRow() const
|
|
{
|
|
return mnRow2;
|
|
}
|
|
|
|
RefRowReorderHint::RefRowReorderHint( const sc::ColRowReorderMapType& rRowMap, SCTAB nTab, SCCOL nCol1, SCCOL nCol2 ) :
|
|
RefHint(RowReordered), mrRowMap(rRowMap), mnTab(nTab), mnCol1(nCol1), mnCol2(nCol2) {}
|
|
|
|
RefRowReorderHint::~RefRowReorderHint() {}
|
|
|
|
const sc::ColRowReorderMapType& RefRowReorderHint::getRowMap() const
|
|
{
|
|
return mrRowMap;
|
|
}
|
|
|
|
SCTAB RefRowReorderHint::getTab() const
|
|
{
|
|
return mnTab;
|
|
}
|
|
|
|
SCCOL RefRowReorderHint::getStartColumn() const
|
|
{
|
|
return mnCol1;
|
|
}
|
|
|
|
SCCOL RefRowReorderHint::getEndColumn() const
|
|
{
|
|
return mnCol2;
|
|
}
|
|
|
|
RefStartListeningHint::RefStartListeningHint() : RefHint(StartListening) {}
|
|
RefStartListeningHint::~RefStartListeningHint() {}
|
|
|
|
RefStopListeningHint::RefStopListeningHint() : RefHint(StopListening) {}
|
|
RefStopListeningHint::~RefStopListeningHint() {}
|
|
|
|
}
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|