92 lines
2.5 KiB
C++
92 lines
2.5 KiB
C++
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This file is part of the LibreOffice project.
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
*/
|
|
|
|
#include <cassert>
|
|
#include <string>
|
|
#include <iostream>
|
|
#include <fstream>
|
|
#include <set>
|
|
#include "plugin.hxx"
|
|
|
|
/**
|
|
the comma operator is best used sparingly
|
|
*/
|
|
|
|
namespace {
|
|
|
|
class CommaOperator:
|
|
public RecursiveASTVisitor<CommaOperator>, public loplugin::Plugin
|
|
{
|
|
public:
|
|
explicit CommaOperator(InstantiationData const & data): Plugin(data) {}
|
|
|
|
virtual void run() override
|
|
{
|
|
TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
|
|
}
|
|
|
|
bool VisitBinaryOperator(const BinaryOperator* );
|
|
};
|
|
|
|
bool CommaOperator::VisitBinaryOperator(const BinaryOperator* binaryOp)
|
|
{
|
|
if (ignoreLocation(binaryOp)) {
|
|
return true;
|
|
}
|
|
// Ignore FD_SET expanding to "...} while(0, 0)" in some Microsoft
|
|
// winsock2.h (TODO: improve heuristic of determining that the whole
|
|
// binaryOp is part of a single macro body expansion):
|
|
if (compiler.getSourceManager().isMacroBodyExpansion(
|
|
binaryOp->getLocStart())
|
|
&& compiler.getSourceManager().isMacroBodyExpansion(
|
|
binaryOp->getOperatorLoc())
|
|
&& compiler.getSourceManager().isMacroBodyExpansion(
|
|
binaryOp->getLocEnd())
|
|
&& ignoreLocation(
|
|
compiler.getSourceManager().getSpellingLoc(
|
|
binaryOp->getOperatorLoc())))
|
|
{
|
|
return true;
|
|
}
|
|
if (binaryOp->getOpcode() != BO_Comma) {
|
|
return true;
|
|
}
|
|
const Stmt* parent = parentStmt(binaryOp);
|
|
if (parent != nullptr) {
|
|
if (isa<ParenExpr>(parent)) {
|
|
return true;
|
|
}
|
|
if (isa<BinaryOperator>(parent)) {
|
|
return true;
|
|
}
|
|
if (isa<ForStmt>(parent)) {
|
|
return true;
|
|
}
|
|
if (isa<ExprWithCleanups>(parent)) {
|
|
const Stmt* parent2 = parentStmt(parent);
|
|
if (isa<ForStmt>(parent2)) {
|
|
return true;
|
|
}
|
|
}
|
|
}
|
|
// parent->dump();
|
|
report(
|
|
DiagnosticsEngine::Warning, "comma operator hides code",
|
|
binaryOp->getOperatorLoc())
|
|
<< binaryOp->getSourceRange();
|
|
return true;
|
|
}
|
|
|
|
|
|
loplugin::Plugin::Registration< CommaOperator > X("commaoperator", true);
|
|
|
|
}
|
|
|
|
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
|