Update with sad todo

.rubocop_todo.yml

@@ -1,5 +1,6 @@
-# This configuration was generated by `rubocop --auto-gen-config`
-# on 2014-11-08 22:49:55 +0900 using RuboCop version 0.27.1.
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2016-05-24 01:50:42 +0900 using RuboCop version 0.40.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -7,67 +8,115 @@
 
 # Offense count: 1
 Lint/AmbiguousOperator:
-  Enabled: false
+  Exclude:
+    - 'app/models/post/image_store_methods.rb'
 
 # Offense count: 22
 Lint/AmbiguousRegexpLiteral:
-  Enabled: false
+  Exclude:
+    - 'lib/download.rb'
+    - 'lib/dtext.rb'
+    - 'test/mailers/user_mailer_test.rb'
+    - 'test/models/dtext_test.rb'
 
 # Offense count: 1
+# Cop supports --auto-correct.
 Lint/Debugger:
-  Enabled: false
+  Exclude:
+    - 'db/migrate/20081015004938_convert_favorites_to_votes.rb'
 
 # Offense count: 1
 Lint/ElseLayout:
-  Enabled: false
+  Exclude:
+    - 'app/models/tag/parse_methods.rb'
 
 # Offense count: 1
-# Configuration parameters: AlignWith, SupportedStyles.
+# Cop supports --auto-correct.
+# Configuration parameters: AlignWith, SupportedStyles, AutoCorrect.
+# SupportedStyles: keyword, variable, start_of_line
 Lint/EndAlignment:
   Enabled: false
 
 # Offense count: 8
 Lint/HandleExceptions:
-  Enabled: false
+  Exclude:
+    - 'app/controllers/pool_controller.rb'
+    - 'app/mailers/user_mailer.rb'
+    - 'app/models/artist.rb'
+    - 'app/models/post/tag_methods.rb'
+    - 'config/initializers/newrelic_gc.rb'
+    - 'db/migrate/046_posts_tags_add_foreign_keys.rb'
+
+# Offense count: 18
+Lint/ImplicitStringConcatenation:
+  Exclude:
+    - 'app/models/tag/api_methods.rb'
+    - 'db/migrate/09142010220946_add_fts_to_pools.rb'
+    - 'db/migrate/20100906054326_add_fts_to_history.rb'
+    - 'db/migrate/20100907210915_include_note_body_in_history_fts.rb'
+    - 'db/migrate/20101027013550_fix_fts_underscores.rb'
+
+# Offense count: 3
+Lint/IneffectiveAccessModifier:
+  Exclude:
+    - 'app/models/history.rb'
+
+# Offense count: 5
+Lint/NestedMethodDefinition:
+  Exclude:
+    - 'app/controllers/post_controller.rb'
+    - 'app/models/inline.rb'
+    - 'app/models/user.rb'
+    - 'lib/tasks/i18n.rake'
 
 # Offense count: 1
 Lint/ShadowingOuterLocalVariable:
-  Enabled: false
+  Exclude:
+    - 'lib/versioning.rb'
 
 # Offense count: 1
 Lint/UselessAccessModifier:
-  Enabled: false
+  Exclude:
+    - 'app/models/history.rb'
 
 # Offense count: 2
 Lint/Void:
-  Enabled: false
+  Exclude:
+    - 'app/models/tag/parse_methods.rb'
+    - 'lib/moebooru/resizer.rb'
 
-# Offense count: 286
+# Offense count: 281
 Metrics/AbcSize:
-  Max: 296
+  Max: 286
 
 # Offense count: 13
 Metrics/BlockNesting:
   Max: 5
 
-# Offense count: 24
+# Offense count: 25
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 656
+  Max: 659
 
-# Offense count: 70
+# Offense count: 72
 Metrics/CyclomaticComplexity:
   Max: 86
 
-# Offense count: 1866
-# Configuration parameters: AllowURI, URISchemes.
+# Offense count: 1764
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes.
+# URISchemes: http, https
 Metrics/LineLength:
   Max: 431
 
-# Offense count: 292
+# Offense count: 287
 # Configuration parameters: CountComments.
 Metrics/MethodLength:
-  Max: 260
+  Max: 258
+
+# Offense count: 12
+# Configuration parameters: CountComments.
+Metrics/ModuleLength:
+  Max: 423
 
 # Offense count: 1
 # Configuration parameters: CountKeywordArgs.
@@ -78,109 +127,428 @@ Metrics/ParameterLists:
 Metrics/PerceivedComplexity:
   Max: 86
 
+# Offense count: 4
+# Cop supports --auto-correct.
+Performance/Casecmp:
+  Exclude:
+    - 'app/models/post/file_methods.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+Performance/RedundantMatch:
+  Exclude:
+    - 'lib/diff.rb'
+    - 'lib/download.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Performance/StartWith:
+  Exclude:
+    - 'app/controllers/wiki_controller.rb'
+
+# Offense count: 9
+# Cop supports --auto-correct.
+Performance/StringReplacement:
+  Exclude:
+    - 'app/controllers/application_controller.rb'
+    - 'app/models/anonymous_user.rb'
+    - 'app/models/artist.rb'
+    - 'app/models/pool.rb'
+    - 'app/models/tag.rb'
+    - 'app/models/tag_alias.rb'
+    - 'app/models/user.rb'
+    - 'lib/core_ext/ext-string.rb'
+
 # Offense count: 23
 Style/AccessorMethodName:
-  Enabled: false
+  Exclude:
+    - 'app/controllers/application_controller.rb'
+    - 'app/helpers/history_helper.rb'
+    - 'app/models/comment.rb'
+    - 'app/models/history.rb'
+    - 'app/models/history_change.rb'
+    - 'app/models/pool.rb'
+    - 'app/models/post/parent_methods.rb'
+    - 'app/models/tag/api_methods.rb'
+    - 'app/models/user.rb'
+    - 'lib/versioning.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: prefer_alias, prefer_alias_method
+Style/Alias:
+  Exclude:
+    - 'app/models/anonymous_user.rb'
+    - 'lib/core_extensions.rb'
+    - 'lib/legacy/prototype_legacy_helper.rb'
+
+# Offense count: 18
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: with_first_parameter, with_fixed_indentation
+Style/AlignParameters:
+  Exclude:
+    - 'app/controllers/admin_controller.rb'
+    - 'app/controllers/post_controller.rb'
+    - 'app/controllers/user_controller.rb'
+    - 'app/helpers/avatar_helper.rb'
+    - 'app/models/post/parent_methods.rb'
+    - 'app/models/post_frames.rb'
+    - 'config/environments/production.rb'
+    - 'lib/core_ext/ext-string.rb'
+    - 'lib/mirror.rb'
 
 # Offense count: 3
 Style/AsciiComments:
-  Enabled: false
+  Exclude:
+    - 'app/models/post_tag_history.rb'
+    - 'lib/core_ext/patch-remove_utf8_enforcer_tag_in_form.rb'
+    - 'lib/translate.rb'
 
 # Offense count: 11
-# Configuration parameters: IndentWhenRelativeTo, SupportedStyles, IndentOneStep.
+# Cop supports --auto-correct.
+# Configuration parameters: IndentWhenRelativeTo, SupportedStyles, IndentOneStep, IndentationWidth.
+# SupportedStyles: case, end
 Style/CaseIndentation:
   Enabled: false
 
 # Offense count: 30
 # Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: nested, compact
 Style/ClassAndModuleChildren:
   Enabled: false
 
-# Offense count: 418
+# Offense count: 40
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, SingleLineConditionsOnly.
+# SupportedStyles: assign_to_condition, assign_inside_condition
+Style/ConditionalAssignment:
+  Enabled: false
+
+# Offense count: 374
 Style/Documentation:
   Enabled: false
 
 # Offense count: 1
 Style/DoubleNegation:
-  Enabled: false
+  Exclude:
+    - 'app/models/post/parent_methods.rb'
 
 # Offense count: 2
 Style/EachWithObject:
-  Enabled: false
+  Exclude:
+    - 'app/controllers/tag_controller.rb'
 
-# Offense count: 7
-# Configuration parameters: Exclude.
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AllowAdjacentOneLineDefs.
+Style/EmptyLineBetweenDefs:
+  Exclude:
+    - 'db/migrate/082_add_post_votes.rb'
+
+# Offense count: 13
+# Cop supports --auto-correct.
+# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
+Style/ExtraSpacing:
+  Exclude:
+    - 'app/helpers/favorite_helper.rb'
+    - 'bin/rails'
+    - 'config.ru'
+    - 'config/environments/job_task.rb'
+    - 'config/environments/test.rb'
+    - 'db/migrate/20101027013550_fix_fts_underscores.rb'
+    - 'lib/legacy/prototype_helper.rb'
+    - 'lib/legacy/prototype_legacy_helper.rb'
+    - 'lib/mirror.rb'
+    - 'test/models/dtext/helper.rb'
+
+# Offense count: 5
+# Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts.
 Style/FileName:
-  Enabled: false
+  Exclude:
+    - 'lib/core_ext/ext-string.rb'
+    - 'lib/core_ext/fix-rack_params_key_unescape.rb'
+    - 'lib/core_ext/patch-login_check_on_links_and_buttons.rb'
+    - 'lib/core_ext/patch-remove_commit_search_from_form.rb'
+    - 'lib/core_ext/patch-remove_utf8_enforcer_tag_in_form.rb'
 
 # Offense count: 4
 # Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: for, each
 Style/For:
   Enabled: false
 
 # Offense count: 69
 # Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: format, sprintf, percent
 Style/FormatString:
   Enabled: false
 
-# Offense count: 63
+# Offense count: 31
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
   Enabled: false
 
-# Offense count: 122
+# Offense count: 7
+Style/IfInsideElse:
+  Exclude:
+    - 'app/controllers/post_controller.rb'
+    - 'app/controllers/user_controller.rb'
+    - 'app/controllers/wiki_controller.rb'
+    - 'app/helpers/post_helper.rb'
+    - 'app/models/post/image_store/remote_hierarchy.rb'
+    - 'app/models/post/sql_methods.rb'
+
+# Offense count: 103
+# Cop supports --auto-correct.
 # Configuration parameters: MaxLineLength.
 Style/IfUnlessModifier:
   Enabled: false
 
 # Offense count: 22
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: line_count_dependent, lambda, literal
 Style/Lambda:
-  Enabled: false
+  Exclude:
+    - 'app/controllers/report_controller.rb'
+    - 'app/models/forum_post.rb'
+    - 'app/models/pool.rb'
+    - 'app/models/pool_post.rb'
+    - 'app/models/post.rb'
+    - 'app/models/post/comment_methods.rb'
+    - 'app/models/post/parent_methods.rb'
+    - 'app/models/post/tag_methods.rb'
+    - 'app/models/tag_subscription.rb'
+    - 'app/models/user.rb'
+    - 'lib/diff.rb'
 
 # Offense count: 1
 # Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: snake_case, camelCase
 Style/MethodName:
   Enabled: false
 
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: symmetrical, new_line, same_line
+Style/MultilineArrayBraceLayout:
+  Exclude:
+    - 'app/helpers/pool_helper.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: symmetrical, new_line, same_line
+Style/MultilineMethodCallBraceLayout:
+  Exclude:
+    - 'app/controllers/post_controller.rb'
+    - 'app/models/flagged_post_detail.rb'
+    - 'app/models/user.rb'
+
+# Offense count: 8
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
+# SupportedStyles: aligned, indented
+Style/MultilineOperationIndentation:
+  Enabled: false
+
 # Offense count: 3
 Style/MultilineTernaryOperator:
-  Enabled: false
+  Exclude:
+    - 'lib/legacy/prototype_helper.rb'
+    - 'lib/moebooru/resizer.rb'
+
+# Offense count: 13
+# Cop supports --auto-correct.
+Style/MutableConstant:
+  Exclude:
+    - 'app/models/job_task.rb'
+    - 'app/models/post.rb'
+    - 'app/models/tag.rb'
+    - 'config/init_config.rb'
+    - 'lib/diff.rb'
+    - 'lib/legacy/prototype_helper.rb'
+    - 'lib/similar_images.rb'
 
 # Offense count: 7
+# Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
+# SupportedStyles: skip_modifier_ifs, always
 Style/Next:
-  Enabled: false
+  Exclude:
+    - 'app/controllers/user_controller.rb'
+    - 'app/models/post/sql_methods.rb'
+    - 'app/models/post_tag_history.rb'
+    - 'db/migrate/076_create_user_blacklisted_tags.rb'
+    - 'lib/similar_images.rb'
+    - 'lib/versioning.rb'
 
-# Offense count: 17
+# Offense count: 1
+# Cop supports --auto-correct.
 Style/OneLineConditional:
-  Enabled: false
+  Exclude:
+    - 'app/helpers/post_helper.rb'
 
-# Offense count: 21
-# Configuration parameters: NamePrefix, NamePrefixBlacklist.
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: AllowSafeAssignment.
+Style/ParenthesesAroundCondition:
+  Exclude:
+    - 'app/models/post/file_methods.rb'
+
+# Offense count: 20
+# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
+# NamePrefix: is_, has_, have_
+# NamePrefixBlacklist: is_, has_, have_
+# NameWhitelist: is_a?
 Style/PredicateName:
-  Enabled: false
+  Exclude:
+    - 'spec/**/*'
+    - 'app/models/anonymous_user.rb'
+    - 'app/models/forum_post.rb'
+    - 'app/models/history_change.rb'
+    - 'app/models/inline_image.rb'
+    - 'app/models/note.rb'
+    - 'app/models/pool.rb'
+    - 'app/models/post/file_methods.rb'
+    - 'app/models/post/status_methods.rb'
+    - 'app/models/post/tag_methods.rb'
+    - 'app/models/user.rb'
+    - 'lib/external_post.rb'
 
-# Offense count: 3
+# Offense count: 1
+# Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: compact, exploded
 Style/RaiseArgs:
   Enabled: false
 
-# Offense count: 11
-# Configuration parameters: MaxSlashes.
-Style/RegexpLiteral:
-  Enabled: false
+# Offense count: 5
+# Cop supports --auto-correct.
+Style/RedundantParentheses:
+  Exclude:
+    - 'app/helpers/post_helper.rb'
+    - 'app/models/inline_image.rb'
+    - 'app/models/post/tag_methods.rb'
+    - 'app/models/user.rb'
 
-# Offense count: 12
+# Offense count: 15
+# Cop supports --auto-correct.
+Style/RedundantSelf:
+  Exclude:
+    - 'app/models/batch_upload.rb'
+    - 'app/models/history_change.rb'
+    - 'app/models/inline_image.rb'
+    - 'app/models/post.rb'
+    - 'app/models/post/image_store/remote_hierarchy.rb'
+    - 'app/models/post/mirror_methods.rb'
+    - 'app/models/post/parent_methods.rb'
+    - 'app/models/post/status_methods.rb'
+    - 'app/models/post/tag_methods.rb'
+    - 'app/models/user.rb'
+
+# Offense count: 28
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
+# SupportedStyles: slashes, percent_r, mixed
+Style/RegexpLiteral:
+  Exclude:
+    - 'app/models/artist_url.rb'
+    - 'app/models/inline_image.rb'
+    - 'app/models/note.rb'
+    - 'app/models/post.rb'
+    - 'app/models/post/file_methods.rb'
+    - 'db/migrate/20090903232732_update_post_text.rb'
+    - 'lib/download.rb'
+    - 'lib/dtext.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/RescueEnsureAlignment:
+  Exclude:
+    - 'app/models/forum_post.rb'
+
+# Offense count: 13
+# Cop supports --auto-correct.
 Style/RescueModifier:
+  Exclude:
+    - 'app/controllers/wiki_controller.rb'
+    - 'app/helpers/post_helper.rb'
+    - 'app/models/artist.rb'
+    - 'app/models/post/file_methods.rb'
+    - 'app/models/post/tag_methods.rb'
+    - 'app/models/post_tag_history.rb'
+    - 'app/models/tag/parse_methods.rb'
+    - 'db/migrate/20081130190723_add_file_size_to_posts.rb'
+    - 'lib/similar_images.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/SpaceAroundKeyword:
+  Exclude:
+    - 'app/helpers/history_helper.rb'
+
+# Offense count: 9
+# Cop supports --auto-correct.
+# Configuration parameters: AllowForAlignment.
+Style/SpaceAroundOperators:
+  Exclude:
+    - 'app/models/post.rb'
+    - 'config/environments/job_task.rb'
+    - 'config/environments/test.rb'
+    - 'lib/legacy/prototype_helper.rb'
+    - 'lib/legacy/prototype_legacy_helper.rb'
+    - 'lib/mirror.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, ConsistentQuotesInMultiline.
+# SupportedStyles: single_quotes, double_quotes
+Style/StringLiterals:
   Enabled: false
 
 # Offense count: 3
 # Cop supports --auto-correct.
-# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, Whitelist.
+# Configuration parameters: IgnoredMethods.
+# IgnoredMethods: respond_to, define_method
+Style/SymbolProc:
+  Exclude:
+    - 'lib/mirror.rb'
+    - 'lib/similar_images.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
+# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
 Style/TrivialAccessors:
-  Enabled: false
+  Exclude:
+    - 'lib/nagato.rb'
 
 # Offense count: 5
+# Cop supports --auto-correct.
+Style/UnneededInterpolation:
+  Exclude:
+    - 'app/controllers/post_controller.rb'
+    - 'app/helpers/tag_helper.rb'
+    - 'lib/diff.rb'
+    - 'lib/legacy/prototype_helper.rb'
+    - 'lib/similar_images.rb'
+
+# Offense count: 5
+# Cop supports --auto-correct.
 # Configuration parameters: MaxLineLength.
 Style/WhileUntilModifier:
-  Enabled: false
+  Exclude:
+    - 'app/models/history.rb'
+    - 'app/models/inline_image.rb'
+    - 'app/models/post/file_methods.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/ZeroLengthPredicate:
+  Exclude:
+    - 'app/models/inline_image.rb'
+    - 'app/models/post/file_methods.rb'