[webhook] Allow passing options to HTTPS server

Feature:

  We shall allow passing more options to the HTTP server,
  in `https.createServer()`.

  We are using a new property, `https`, to avoid any namespace
  collisions with our own options.

  `options.key`, `options.cert` and `options.pfx` are convenient
  options, in that they allow the user to provide paths to the
  corresponding files, which are read automatically,
  though synchronously!

Implementation:

  * completely backwards-compatible
  * all changes are being tested, except `options.pfx`

References:

  * Pass `ca` prop to https.createServer(): https://github.com/yagop/node-telegram-bot-api/pull/17

test/telegram.js

@@ -1,4 +1,4 @@
-const Telegram = require('../lib/telegram');
+const TelegramBot = require('../lib/telegram');
 const Promise = require('bluebird');
 const request = require('request-promise');
 const assert = require('assert');
@@ -8,7 +8,9 @@ const path = require('path');
 const is = require('is');
 const utils = require('./utils');
 
+// Allows self-signed certificates to be used in our tests
 process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
+
 const TOKEN = process.env.TEST_TELEGRAM_TOKEN;
 if (!TOKEN) {
   throw new Error('Bot token not provided');
@@ -19,12 +21,15 @@ const USERID = process.env.TEST_USER_ID || 777000;
 const GROUPID = process.env.TEST_GROUP_ID || -1001075450562;
 const GAME_SHORT_NAME = process.env.TEST_GAME_SHORT_NAME || 'medusalab_test';
 const timeout = 60 * 1000;
-const staticPort = 8091;
-const pollingPort = 8092;
-const webHookPort = 8093;
-const pollingPort2 = 8094;
-const webHookPort2 = 8095;
+let portindex = 8091;
+const staticPort = portindex++;
+const pollingPort = portindex++;
+const webHookPort = portindex++;
+const pollingPort2 = portindex++;
+const webHookPort2 = portindex++;
 const staticUrl = `http://127.0.0.1:${staticPort}`;
+const key = `${__dirname}/../examples/key.pem`;
+const cert = `${__dirname}/../examples/crt.pem`;
 let FILE_ID;
 let GAME_CHAT_ID;
 let GAME_MSG_ID;
@@ -37,7 +42,7 @@ before(function beforeAll() {
     });
 });
 
-describe('Telegram', function telegramSuite() {
+describe('TelegramBot', function telegramSuite() {
   let bot;
   let testbot;
   let botPolling;
@@ -45,8 +50,8 @@ describe('Telegram', function telegramSuite() {
 
   before(function beforeAll() {
     this.timeout(timeout);
-    bot = new Telegram(TOKEN);
-    testbot = new Telegram(TOKEN, {
+    bot = new TelegramBot(TOKEN);
+    testbot = new TelegramBot(TOKEN, {
       baseApiUrl: `http://127.0.0.1:${pollingPort}`,
       polling: {
         autoStart: false,
@@ -56,11 +61,11 @@ describe('Telegram', function telegramSuite() {
         port: webHookPort,
       },
     });
-    botPolling = new Telegram(TOKEN, {
+    botPolling = new TelegramBot(TOKEN, {
       baseApiUrl: `http://127.0.0.1:${pollingPort2}`,
       polling: true,
     });
-    botWebHook = new Telegram(TOKEN, {
+    botWebHook = new TelegramBot(TOKEN, {
       webHook: {
         port: webHookPort2,
       },
@@ -136,6 +141,31 @@ describe('Telegram', function telegramSuite() {
     });
   });
 
+  describe('WebHook HTTPS', function webHookHTTPSSuite() {
+    const port = portindex++;
+    let httpsbot;
+    afterEach(function afterEach() {
+      return httpsbot.closeWebHook();
+    });
+    it('is enabled, through options.key and options.cert', function test() {
+      httpsbot = new TelegramBot(TOKEN, { webHook: { port, key, cert } });
+      return utils.sendWebHookMessage(port, TOKEN, { https: true });
+    });
+    it('is enabled, through options.pfx');
+    it('is enabled, through options.https', function test() {
+      httpsbot = new TelegramBot(TOKEN, {
+        webHook: {
+          port,
+          https: {
+            key: fs.readFileSync(key),
+            cert: fs.readFileSync(cert),
+          },
+        },
+      });
+      return utils.sendWebHookMessage(port, TOKEN, { https: true });
+    });
+  });
+
   describe('#initPolling', function initPollingSuite() {
     it('initiates polling', function test() {
       testbot.initPolling();
@@ -215,7 +245,6 @@ describe('Telegram', function telegramSuite() {
 
   describe('#setWebHook', function setWebHookSuite() {
     const ip = '216.58.210.174';
-    const cert = `${__dirname}/../examples/crt.pem`;
     before(function before() {
       utils.handleRatelimit(bot, 'setWebHook', this);
     });

test/utils.js

@@ -37,6 +37,7 @@ exports = module.exports = {
    * @param  {Object} [options]
    * @param  {String} [options.method=POST] Method to use
    * @param  {Object} [options.message] Message to send. Default to a generic text message
+   * @param  {Boolean} [options.https=false] Use https
    * @return {Promise}
    */
   sendWebHookMessage,
@@ -136,7 +137,8 @@ function hasOpenWebHook(port, reverse) {
 function sendWebHookMessage(port, token, options = {}) {
   assert.ok(port);
   assert.ok(token);
-  const url = `http://127.0.0.1:${port}/bot${token}`;
+  const protocol = options.https ? 'https' : 'http';
+  const url = `${protocol}://127.0.0.1:${port}/bot${token}`;
   return request({
     url,
     method: options.method || 'POST',