mir/node-telegram-bot-api
2
0
Fork 0
mirror of https://github.com/yagop/node-telegram-bot-api synced 2025-08-30 22:05:28 +00:00
Code Issues Releases Wiki Activity

WebHook request bot token can be anywhere on the URL request. Tests

Browse Source
This commit is contained in:
yago
2015-07-12 16:50:07 +02:00
parent 01a1b67bb4
commit 5e1d13749d
2 changed files with 44 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/telegram.js
View File

@@ -74,24 +74,35 @@ TelegramBot.prototype._configureWebHook = function (port, host, key, cert) {
TelegramBot.prototype._requestListener = function (req, res) { TelegramBot.prototype._requestListener = function (req, res) {
var self = this; var self = this;
var url = '/bot'+this.token; var regex = new RegExp(this.token);
if (req.url === url && req.method === 'POST') {
debug('WebHook request URL:', req.url);
debug('WebHook request headers: %j', req.headers);
// If there isn't token on URL
if (!regex.test(req.url)) {
debug('WebHook request unauthorized');
res.statusCode = 401;
res.end();
} else if (req.method === 'POST') {
var fullBody = ''; var fullBody = '';
req.on('data', function (chunk) { req.on('data', function (chunk) {
fullBody += chunk.toString(); fullBody += chunk.toString();
}); });
req.on('end', function () { req.on('end', function () {
try { try {
debug('WebHook request fullBody', fullBody);
var data = JSON.parse(fullBody); var data = JSON.parse(fullBody);
self.offset = data.update_id; self.offset = data.update_id;
self.emit('message', data.message); self.emit('message', data.message);
} catch (error) { } catch (error) {
console.error(error); debug(error);
} }
res.end('OK :P\n'); res.end('OK');
}); });
} else { } else { // Authorized but not a POST
res.end('OK\n'); debug('WebHook request isn\'t a POST');
res.statusCode = 418; // I'm a teabot!
res.end();
} }
}; };

28
test/index.js
View File

@@ -31,7 +31,7 @@ describe('Telegram', function () {
}); });
}); });
describe('#emit', function () { describe('#Polling', function () {
it('should emit a `message` on polling', function (done) { it('should emit a `message` on polling', function (done) {
var bot = new Telegram(TOKEN); var bot = new Telegram(TOKEN);
bot.on('message', function (msg) { bot.on('message', function (msg) {
@@ -50,6 +50,32 @@ describe('Telegram', function () {
}; };
bot._polling(); bot._polling();
}); });
});
describe('#WebHook', function () {
it('should reject request if same token not provided', function (done) {
var bot = new Telegram(TOKEN, {webHook: true});
request({
url: 'http://localhost:8443/NOT_REAL_TOKEN',
method: 'POST'
}, function (error, response, body) {
response.statusCode.should.not.be.equal(200);
bot._webServer.close();
done();
});
});
it('should reject request if authorized but not a POST', function (done) {
var bot = new Telegram(TOKEN, {webHook: true});
request({
url: 'http://localhost:8443/bot'+TOKEN,
method: 'GET'
}, function (error, response, body) {
response.statusCode.should.not.be.equal(200);
bot._webServer.close();
done();
});
});
it('should emit a `message` on HTTP WebHook', function (done) { it('should emit a `message` on HTTP WebHook', function (done) {
var bot = new Telegram(TOKEN, {webHook: true}); var bot = new Telegram(TOKEN, {webHook: true});