datapath: Change listing ports to use an iterator concept.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to add new
features to the kernel vport layer without changing userspace software. In
turn, that means that the odp_port structure must become variable-length.
This does not, however, fit in well with the ODP_PORT_LIST ioctl in its
current form, because that would require userspace to know how much space
to allocate for each port in advance, or to allocate as much space as
could possibly be needed. Neither choice is very attractive.
This commit prepares for a different solution, by replacing ODP_PORT_LIST
by a new ioctl ODP_VPORT_DUMP that retrieves information about a single
vport from the datapath on each call. It is much cleaner to allocate the
maximum amount of space for a single vport than to do so for possibly a
large number of vports.
It would be faster to retrieve a number of vports in batch instead of just
one at a time, but that will naturally happen later when the kernel
datapath interface is changed to use Netlink, so this patch does not bother
with it.
The Netlink version won't need to take the starting port number from
userspace, since Netlink sockets can keep track of that state as part
of their "dump" feature.
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2011-01-10 13:12:12 -08:00
|
|
|
|
/* Copyright (c) 2008, 2009, 2010, 2011 Nicira Networks
|
2009-06-10 15:24:03 -07:00
|
|
|
|
*
|
2009-06-15 15:11:30 -07:00
|
|
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
|
* you may not use this file except in compliance with the License.
|
|
|
|
|
* You may obtain a copy of the License at:
|
2009-07-08 13:19:16 -07:00
|
|
|
|
*
|
2009-06-15 15:11:30 -07:00
|
|
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
2009-07-08 13:19:16 -07:00
|
|
|
|
*
|
2009-06-15 15:11:30 -07:00
|
|
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
|
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
|
* See the License for the specific language governing permissions and
|
|
|
|
|
* limitations under the License.
|
2009-07-08 13:19:16 -07:00
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#include <config.h>
|
|
|
|
|
#include "bridge.h"
|
|
|
|
|
#include <assert.h>
|
|
|
|
|
#include <errno.h>
|
|
|
|
|
#include <inttypes.h>
|
|
|
|
|
#include <stdlib.h>
|
|
|
|
|
#include "bitmap.h"
|
2011-03-30 11:03:16 -07:00
|
|
|
|
#include "bond.h"
|
2010-11-15 16:20:01 -08:00
|
|
|
|
#include "cfm.h"
|
2009-07-08 13:19:16 -07:00
|
|
|
|
#include "coverage.h"
|
2011-01-28 12:44:00 -08:00
|
|
|
|
#include "daemon.h"
|
2009-07-08 13:19:16 -07:00
|
|
|
|
#include "dirs.h"
|
|
|
|
|
#include "dynamic-string.h"
|
|
|
|
|
#include "hash.h"
|
2010-07-19 11:23:05 -07:00
|
|
|
|
#include "hmap.h"
|
2011-11-30 12:09:35 -08:00
|
|
|
|
#include "hmapx.h"
|
2010-04-26 10:48:31 -07:00
|
|
|
|
#include "jsonrpc.h"
|
2011-02-28 14:48:06 -08:00
|
|
|
|
#include "lacp.h"
|
2009-07-08 13:19:16 -07:00
|
|
|
|
#include "list.h"
|
|
|
|
|
#include "netdev.h"
|
|
|
|
|
#include "ofp-print.h"
|
|
|
|
|
#include "ofpbuf.h"
|
2009-07-08 10:30:42 -07:00
|
|
|
|
#include "ofproto/ofproto.h"
|
2009-07-08 13:19:16 -07:00
|
|
|
|
#include "poll-loop.h"
|
2009-12-03 11:28:40 -08:00
|
|
|
|
#include "sha1.h"
|
2009-12-01 01:14:33 -08:00
|
|
|
|
#include "shash.h"
|
2009-07-08 13:19:16 -07:00
|
|
|
|
#include "socket-util.h"
|
2010-01-06 14:35:20 -08:00
|
|
|
|
#include "stream-ssl.h"
|
2011-03-25 15:26:30 -07:00
|
|
|
|
#include "sset.h"
|
2010-09-22 16:45:30 -07:00
|
|
|
|
#include "system-stats.h"
|
2009-07-08 13:19:16 -07:00
|
|
|
|
#include "timeval.h"
|
|
|
|
|
#include "util.h"
|
2009-06-10 15:13:21 -07:00
|
|
|
|
#include "unixctl.h"
|
2011-11-23 17:03:31 -08:00
|
|
|
|
#include "vlandev.h"
|
2009-12-02 11:18:40 -08:00
|
|
|
|
#include "vswitchd/vswitch-idl.h"
|
2009-07-08 13:19:16 -07:00
|
|
|
|
#include "xenserver.h"
|
2010-07-16 11:02:49 -07:00
|
|
|
|
#include "vlog.h"
|
2010-01-04 13:08:37 -08:00
|
|
|
|
#include "sflow_api.h"
|
2011-04-08 13:19:33 -07:00
|
|
|
|
#include "vlan-bitmap.h"
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2010-10-19 14:47:01 -07:00
|
|
|
|
VLOG_DEFINE_THIS_MODULE(bridge);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
coverage: Make the coverage counters catalog program-specific.
Until now, the collection of coverage counters supported by a given OVS
program was not specific to that program. That means that, for example,
even though ovs-dpctl does not have anything to do with mac_learning, it
still has a coverage counter for it. This is confusing, at best.
This commit fixes the problem on some systems, in particular on ones that
use GCC and the GNU linker. It uses the feature of the GNU linker
described in its manual as:
If an orphaned section's name is representable as a C identifier then
the linker will automatically see PROVIDE two symbols: __start_SECNAME
and __end_SECNAME, where SECNAME is the name of the section. These
indicate the start address and end address of the orphaned section
respectively.
Systems that don't support these features retain the earlier behavior.
This commit also fixes the annoyance that files that include coverage
counters must be listed on COVERAGE_FILES in lib/automake.mk.
This commit also fixes the annoyance that modifying any source file that
includes a coverage counter caused all programs that link against
libopenvswitch.a to relink, even programs that the source file was not
linked into. For example, modifying ofproto/ofproto.c (which includes
coverage counters) caused tests/test-aes128 to relink, even though
test-aes128 does not link again ofproto.o.
2010-11-01 14:14:27 -07:00
|
|
|
|
COVERAGE_DEFINE(bridge_reconfigure);
|
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
struct iface {
|
2009-07-30 16:00:41 -07:00
|
|
|
|
/* These members are always valid. */
|
2011-03-21 10:24:32 -07:00
|
|
|
|
struct list port_elem; /* Element in struct port's "ifaces" list. */
|
2011-04-01 11:42:25 -07:00
|
|
|
|
struct hmap_node name_node; /* In struct bridge's "iface_by_name" hmap. */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
struct port *port; /* Containing port. */
|
|
|
|
|
char *name; /* Host network device name. */
|
|
|
|
|
tag_type tag; /* Tag associated with this interface. */
|
|
|
|
|
|
2009-07-30 16:00:41 -07:00
|
|
|
|
/* These members are valid only after bridge_reconfigure() causes them to
|
2010-06-10 14:32:32 -07:00
|
|
|
|
* be initialized. */
|
2011-05-09 09:24:39 -07:00
|
|
|
|
struct hmap_node ofp_port_node; /* In struct bridge's "ifaces" hmap. */
|
|
|
|
|
int ofp_port; /* OpenFlow port number, -1 if unknown. */
|
2009-07-30 16:00:41 -07:00
|
|
|
|
struct netdev *netdev; /* Network device. */
|
2010-10-11 10:13:33 -07:00
|
|
|
|
const char *type; /* Usually same as cfg->type. */
|
2009-12-03 11:28:40 -08:00
|
|
|
|
const struct ovsrec_interface *cfg;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
struct mirror {
|
2011-05-11 12:26:06 -07:00
|
|
|
|
struct uuid uuid; /* UUID of this "mirror" record in database. */
|
|
|
|
|
struct hmap_node hmap_node; /* In struct bridge's "mirrors" hmap. */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
struct bridge *bridge;
|
|
|
|
|
char *name;
|
2011-11-20 15:12:36 -08:00
|
|
|
|
const struct ovsrec_mirror *cfg;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
struct port {
|
|
|
|
|
struct bridge *bridge;
|
2011-03-21 10:07:39 -07:00
|
|
|
|
struct hmap_node hmap_node; /* Element in struct bridge's "ports" hmap. */
|
|
|
|
|
char *name;
|
|
|
|
|
|
2010-06-10 14:32:32 -07:00
|
|
|
|
const struct ovsrec_port *cfg;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
|
|
|
|
/* An ordinary bridge port has 1 interface.
|
|
|
|
|
* A bridge port for bonding has at least 2 interfaces. */
|
2011-03-21 10:24:32 -07:00
|
|
|
|
struct list ifaces; /* List of "struct iface"s. */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
struct bridge {
|
2011-04-04 14:11:16 -07:00
|
|
|
|
struct hmap_node node; /* In 'all_bridges'. */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
char *name; /* User-specified arbitrary name. */
|
2011-04-08 13:50:21 -07:00
|
|
|
|
char *type; /* Datapath type. */
|
2011-01-26 13:14:42 -08:00
|
|
|
|
uint8_t ea[ETH_ADDR_LEN]; /* Bridge Ethernet Address. */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
uint8_t default_ea[ETH_ADDR_LEN]; /* Default MAC. */
|
2010-06-10 14:32:32 -07:00
|
|
|
|
const struct ovsrec_bridge *cfg;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
|
|
|
|
/* OpenFlow switch processing. */
|
|
|
|
|
struct ofproto *ofproto; /* OpenFlow switch. */
|
|
|
|
|
|
|
|
|
|
/* Bridge ports. */
|
2011-03-21 10:07:39 -07:00
|
|
|
|
struct hmap ports; /* "struct port"s indexed by name. */
|
2011-05-09 09:24:39 -07:00
|
|
|
|
struct hmap ifaces; /* "struct iface"s indexed by ofp_port. */
|
2011-04-01 11:42:25 -07:00
|
|
|
|
struct hmap iface_by_name; /* "struct iface"s indexed by name. */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
|
|
|
|
/* Port mirroring. */
|
2011-05-11 12:26:06 -07:00
|
|
|
|
struct hmap mirrors; /* "struct mirror" indexed by UUID. */
|
2011-04-13 11:10:44 -07:00
|
|
|
|
|
|
|
|
|
/* Synthetic local port if necessary. */
|
|
|
|
|
struct ovsrec_port synth_local_port;
|
|
|
|
|
struct ovsrec_interface synth_local_iface;
|
|
|
|
|
struct ovsrec_interface *synth_local_ifacep;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
};
|
|
|
|
|
|
2011-04-04 14:11:16 -07:00
|
|
|
|
/* All bridges, indexed by name. */
|
|
|
|
|
static struct hmap all_bridges = HMAP_INITIALIZER(&all_bridges);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2010-06-10 14:17:41 -07:00
|
|
|
|
/* OVSDB IDL used to obtain configuration. */
|
|
|
|
|
static struct ovsdb_idl *idl;
|
|
|
|
|
|
2010-09-23 10:21:40 -07:00
|
|
|
|
/* Each time this timer expires, the bridge fetches systems and interface
|
|
|
|
|
* statistics and pushes them into the database. */
|
|
|
|
|
#define STATS_INTERVAL (5 * 1000) /* In milliseconds. */
|
|
|
|
|
static long long int stats_timer = LLONG_MIN;
|
2010-06-23 11:02:46 -07:00
|
|
|
|
|
2011-04-15 12:57:30 -07:00
|
|
|
|
/* Stores the time after which rate limited statistics may be written to the
|
|
|
|
|
* database. Only updated when changes to the database require rate limiting.
|
|
|
|
|
*/
|
|
|
|
|
#define DB_LIMIT_INTERVAL (1 * 1000) /* In milliseconds. */
|
|
|
|
|
static long long int db_limiter = LLONG_MIN;
|
2011-03-25 13:36:43 -07:00
|
|
|
|
|
2011-04-08 13:50:21 -07:00
|
|
|
|
static void add_del_bridges(const struct ovsrec_open_vswitch *);
|
2011-05-09 09:33:02 -07:00
|
|
|
|
static void bridge_del_ofprotos(void);
|
|
|
|
|
static bool bridge_add_ofprotos(struct bridge *);
|
2011-04-08 13:50:21 -07:00
|
|
|
|
static void bridge_create(const struct ovsrec_bridge *);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static void bridge_destroy(struct bridge *);
|
|
|
|
|
static struct bridge *bridge_lookup(const char *name);
|
2009-10-29 15:20:21 -07:00
|
|
|
|
static unixctl_cb_func bridge_unixctl_dump_flows;
|
2010-06-18 13:58:42 -07:00
|
|
|
|
static unixctl_cb_func bridge_unixctl_reconnect;
|
2010-07-15 14:53:36 -07:00
|
|
|
|
static size_t bridge_get_controllers(const struct bridge *br,
|
2010-04-20 10:43:42 -07:00
|
|
|
|
struct ovsrec_controller ***controllersp);
|
2011-11-23 17:03:31 -08:00
|
|
|
|
static void bridge_add_del_ports(struct bridge *,
|
|
|
|
|
const unsigned long int *splinter_vlans);
|
2011-04-08 13:50:21 -07:00
|
|
|
|
static void bridge_add_ofproto_ports(struct bridge *);
|
|
|
|
|
static void bridge_del_ofproto_ports(struct bridge *);
|
2011-05-09 09:24:39 -07:00
|
|
|
|
static void bridge_refresh_ofp_port(struct bridge *);
|
2011-05-04 10:20:04 -07:00
|
|
|
|
static void bridge_configure_datapath_id(struct bridge *);
|
2011-07-28 16:38:50 -07:00
|
|
|
|
static void bridge_configure_flow_eviction_threshold(struct bridge *);
|
2011-05-04 10:20:04 -07:00
|
|
|
|
static void bridge_configure_netflow(struct bridge *);
|
Option to forward BPDU (Ethernet control class) frames
Currently, a NORMAL action bridge drops reserved-multicast-mac addresses;
01-80-c2-00-00-[f0:ff]. A node that does not implement STP should have an
option to forward such frames.
This commit proposes to have a configuration option to allow forwarding of
BPDU class frames. To ensure backward compatibility, this option is
disabled by default.
This config can be set using bridge's other-config column, for e.g
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
Changing this option can revalidate all flows in a software-OVS
implementation (ofproto-dpif)
--------
unit tests:
------------
make config changes, test runtime behavior
-- test runtime behavior --
continuously send packets to br0 with dest-mac=01:80:c2:00:00:00
ovs-dpctl dump-flows br0
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
ovs-dpctl dump-flows br0
ovs-vsctl set bridge br0 other-config:forward-bpdu=false
ovs-dpctl dump-flows br0
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
ovs-dpctl dump-flows br0
ovs-vsctl remove bridge br0 other-config forward-bpdu=true
ovs-dpctl dump-flows br0
--result--
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:29550, bytes:1773000, used:0.004s, actions:drop
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:8209, bytes:492540, used:0.000s, actions:2,0
ovs-vsctl set bridge br0 other-config:forward-bpdu=false
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:19, bytes:1140, used:0.000s, actions:drop
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:29, bytes:1740, used:0.000s, actions:2,0
ovs-vsctl remove bridge br0 other-config forward-bpdu=true
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:0, bytes:0, used:never, actions:drop
Bug #6624
Reported-by: Niklas Andersson <nandersson@nicira.com>
2011-08-09 11:08:27 -07:00
|
|
|
|
static void bridge_configure_forward_bpdu(struct bridge *);
|
2011-05-04 10:20:04 -07:00
|
|
|
|
static void bridge_configure_sflow(struct bridge *, int *sflow_bridge_number);
|
2011-10-14 09:48:17 -07:00
|
|
|
|
static void bridge_configure_stp(struct bridge *);
|
2011-05-11 12:26:06 -07:00
|
|
|
|
static void bridge_configure_remotes(struct bridge *,
|
|
|
|
|
const struct sockaddr_in *managers,
|
|
|
|
|
size_t n_managers);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static void bridge_pick_local_hw_addr(struct bridge *,
|
|
|
|
|
uint8_t ea[ETH_ADDR_LEN],
|
2009-07-23 14:50:55 -07:00
|
|
|
|
struct iface **hw_addr_iface);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static uint64_t bridge_pick_datapath_id(struct bridge *,
|
|
|
|
|
const uint8_t bridge_ea[ETH_ADDR_LEN],
|
2009-07-23 14:50:55 -07:00
|
|
|
|
struct iface *hw_addr_iface);
|
2011-10-14 09:48:17 -07:00
|
|
|
|
static const char *bridge_get_other_config(const struct ovsrec_bridge *,
|
|
|
|
|
const char *key);
|
|
|
|
|
static const char *get_port_other_config(const struct ovsrec_port *,
|
|
|
|
|
const char *key,
|
|
|
|
|
const char *default_value);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static uint64_t dpid_from_hash(const void *, size_t nbytes);
|
2011-05-04 10:18:23 -07:00
|
|
|
|
static bool bridge_has_bond_fake_iface(const struct bridge *,
|
|
|
|
|
const char *name);
|
|
|
|
|
static bool port_is_bond_fake_iface(const struct port *);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-03-11 13:44:16 -08:00
|
|
|
|
static unixctl_cb_func qos_unixctl_show;
|
2009-07-15 11:05:37 -07:00
|
|
|
|
|
2011-04-08 13:50:21 -07:00
|
|
|
|
static struct port *port_create(struct bridge *, const struct ovsrec_port *);
|
|
|
|
|
static void port_add_ifaces(struct port *);
|
|
|
|
|
static void port_del_ifaces(struct port *);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static void port_destroy(struct port *);
|
|
|
|
|
static struct port *port_lookup(const struct bridge *, const char *name);
|
2011-05-11 12:26:06 -07:00
|
|
|
|
static void port_configure(struct port *);
|
|
|
|
|
static struct lacp_settings *port_configure_lacp(struct port *,
|
|
|
|
|
struct lacp_settings *);
|
2011-05-13 16:47:01 -07:00
|
|
|
|
static void port_configure_bond(struct port *, struct bond_settings *,
|
|
|
|
|
uint32_t *bond_stable_ids);
|
2011-10-26 11:39:46 -07:00
|
|
|
|
static bool port_is_synthetic(const struct port *);
|
2011-05-11 12:26:06 -07:00
|
|
|
|
|
|
|
|
|
static void bridge_configure_mirrors(struct bridge *);
|
|
|
|
|
static struct mirror *mirror_create(struct bridge *,
|
|
|
|
|
const struct ovsrec_mirror *);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static void mirror_destroy(struct mirror *);
|
2011-11-20 15:12:36 -08:00
|
|
|
|
static bool mirror_configure(struct mirror *);
|
|
|
|
|
static void mirror_refresh_stats(struct mirror *);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
static void iface_configure_lacp(struct iface *, struct lacp_slave_settings *);
|
2010-08-30 00:24:53 -07:00
|
|
|
|
static struct iface *iface_create(struct port *port,
|
2009-12-05 16:01:06 -08:00
|
|
|
|
const struct ovsrec_interface *if_cfg);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static void iface_destroy(struct iface *);
|
|
|
|
|
static struct iface *iface_lookup(const struct bridge *, const char *name);
|
2011-03-11 13:44:16 -08:00
|
|
|
|
static struct iface *iface_find(const char *name);
|
2011-05-09 09:24:39 -07:00
|
|
|
|
static struct iface *iface_from_ofp_port(const struct bridge *,
|
|
|
|
|
uint16_t ofp_port);
|
2009-10-02 13:29:01 -07:00
|
|
|
|
static void iface_set_mac(struct iface *);
|
2010-10-22 13:42:40 -07:00
|
|
|
|
static void iface_set_ofport(const struct ovsrec_interface *, int64_t ofport);
|
2011-09-28 09:36:13 -07:00
|
|
|
|
static void iface_clear_db_record(const struct ovsrec_interface *if_cfg);
|
2011-04-08 13:50:21 -07:00
|
|
|
|
static void iface_configure_qos(struct iface *, const struct ovsrec_qos *);
|
|
|
|
|
static void iface_configure_cfm(struct iface *);
|
2011-09-08 16:15:36 -07:00
|
|
|
|
static void iface_refresh_cfm_stats(struct iface *);
|
2011-06-28 13:17:54 -07:00
|
|
|
|
static void iface_refresh_stats(struct iface *);
|
|
|
|
|
static void iface_refresh_status(struct iface *);
|
2011-04-13 11:10:44 -07:00
|
|
|
|
static bool iface_is_synthetic(const struct iface *);
|
2011-11-23 17:03:31 -08:00
|
|
|
|
static const char *get_interface_other_config(const struct ovsrec_interface *,
|
|
|
|
|
const char *key,
|
|
|
|
|
const char *default_value);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2010-09-27 13:15:19 -07:00
|
|
|
|
static void shash_from_ovs_idl_map(char **keys, char **values, size_t n,
|
|
|
|
|
struct shash *);
|
2011-01-05 11:51:15 -08:00
|
|
|
|
static void shash_to_ovs_idl_map(struct shash *,
|
|
|
|
|
char ***keys, char ***values, size_t *n);
|
2011-11-23 17:03:31 -08:00
|
|
|
|
|
|
|
|
|
/* Linux VLAN device support (e.g. "eth0.10" for VLAN 10.)
|
|
|
|
|
*
|
|
|
|
|
* This is deprecated. It is only for compatibility with broken device drivers
|
|
|
|
|
* in old versions of Linux that do not properly support VLANs when VLAN
|
|
|
|
|
* devices are not used. When broken device drivers are no longer in
|
|
|
|
|
* widespread use, we will delete these interfaces. */
|
|
|
|
|
|
|
|
|
|
/* True if VLAN splinters are enabled on any interface, false otherwise.*/
|
|
|
|
|
static bool vlan_splinters_enabled_anywhere;
|
|
|
|
|
|
|
|
|
|
static bool vlan_splinters_is_enabled(const struct ovsrec_interface *);
|
|
|
|
|
static unsigned long int *collect_splinter_vlans(
|
|
|
|
|
const struct ovsrec_open_vswitch *);
|
|
|
|
|
static void configure_splinter_port(struct port *);
|
|
|
|
|
static void add_vlan_splinter_ports(struct bridge *,
|
|
|
|
|
const unsigned long int *splinter_vlans,
|
|
|
|
|
struct shash *ports);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
|
|
|
|
/* Public functions. */
|
|
|
|
|
|
2010-06-10 14:17:41 -07:00
|
|
|
|
/* Initializes the bridge module, configuring it to obtain its configuration
|
|
|
|
|
* from an OVSDB server accessed over 'remote', which should be a string in a
|
|
|
|
|
* form acceptable to ovsdb_idl_create(). */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
void
|
2010-06-10 14:17:41 -07:00
|
|
|
|
bridge_init(const char *remote)
|
|
|
|
|
{
|
|
|
|
|
/* Create connection to database. */
|
2010-11-16 09:14:52 -08:00
|
|
|
|
idl = ovsdb_idl_create(remote, &ovsrec_idl_class, true);
|
2011-07-26 16:49:03 -07:00
|
|
|
|
ovsdb_idl_set_lock(idl, "ovs_vswitchd");
|
2010-06-10 14:17:41 -07:00
|
|
|
|
|
2010-11-16 09:14:52 -08:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_open_vswitch_col_cur_cfg);
|
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_open_vswitch_col_statistics);
|
2010-08-11 15:29:36 -07:00
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_external_ids);
|
2011-03-29 17:05:52 -07:00
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_ovs_version);
|
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_db_version);
|
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_system_type);
|
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_system_version);
|
2010-08-11 15:29:36 -07:00
|
|
|
|
|
2011-03-29 17:05:52 -07:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_bridge_col_datapath_id);
|
2011-10-14 09:48:17 -07:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_bridge_col_status);
|
2010-08-11 15:29:36 -07:00
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_bridge_col_external_ids);
|
|
|
|
|
|
2011-10-14 09:48:17 -07:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_port_col_status);
|
2011-11-14 15:04:14 -08:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_port_col_statistics);
|
2010-08-11 15:29:36 -07:00
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_port_col_external_ids);
|
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_port_col_fake_bridge);
|
|
|
|
|
|
2011-03-29 17:05:52 -07:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_admin_state);
|
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_duplex);
|
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_link_speed);
|
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_link_state);
|
2011-10-14 12:49:57 -07:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_link_resets);
|
2011-03-29 17:05:52 -07:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_mtu);
|
2010-11-16 09:14:52 -08:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_ofport);
|
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_statistics);
|
2011-03-29 17:05:52 -07:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_status);
|
2011-09-08 16:19:10 -07:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_cfm_fault);
|
2011-08-26 14:54:34 -07:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_cfm_remote_mpids);
|
2011-09-08 16:19:10 -07:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_lacp_current);
|
2010-08-11 15:29:36 -07:00
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_interface_col_external_ids);
|
|
|
|
|
|
2011-03-29 17:05:52 -07:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_controller_col_is_connected);
|
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_controller_col_role);
|
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_controller_col_status);
|
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_controller_col_external_ids);
|
|
|
|
|
|
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_qos_col_external_ids);
|
|
|
|
|
|
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_queue_col_external_ids);
|
|
|
|
|
|
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_mirror_col_external_ids);
|
2011-11-20 15:12:36 -08:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_mirror_col_statistics);
|
2011-03-29 17:05:52 -07:00
|
|
|
|
|
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_netflow_col_external_ids);
|
|
|
|
|
|
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_sflow_col_external_ids);
|
|
|
|
|
|
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_manager_col_external_ids);
|
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_manager_col_inactivity_probe);
|
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_manager_col_is_connected);
|
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_manager_col_max_backoff);
|
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_manager_col_status);
|
|
|
|
|
|
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_ssl_col_external_ids);
|
|
|
|
|
|
2010-06-10 14:17:41 -07:00
|
|
|
|
/* Register unixctl commands. */
|
2011-12-02 15:29:19 -08:00
|
|
|
|
unixctl_command_register("qos/show", "interface", 1, 1,
|
|
|
|
|
qos_unixctl_show, NULL);
|
|
|
|
|
unixctl_command_register("bridge/dump-flows", "bridge", 1, 1,
|
2011-09-26 14:59:35 -07:00
|
|
|
|
bridge_unixctl_dump_flows, NULL);
|
2011-12-02 15:29:19 -08:00
|
|
|
|
unixctl_command_register("bridge/reconnect", "[bridge]", 0, 1,
|
2011-09-26 14:59:35 -07:00
|
|
|
|
bridge_unixctl_reconnect, NULL);
|
2011-04-13 17:58:26 -07:00
|
|
|
|
lacp_init();
|
2010-06-10 14:17:41 -07:00
|
|
|
|
bond_init();
|
2011-05-13 16:53:24 -07:00
|
|
|
|
cfm_init();
|
2010-06-10 14:17:41 -07:00
|
|
|
|
}
|
|
|
|
|
|
2010-12-13 13:08:31 -08:00
|
|
|
|
void
|
|
|
|
|
bridge_exit(void)
|
|
|
|
|
{
|
|
|
|
|
struct bridge *br, *next_br;
|
|
|
|
|
|
2011-04-04 14:11:16 -07:00
|
|
|
|
HMAP_FOR_EACH_SAFE (br, next_br, node, &all_bridges) {
|
2010-12-13 13:08:31 -08:00
|
|
|
|
bridge_destroy(br);
|
|
|
|
|
}
|
|
|
|
|
ovsdb_idl_destroy(idl);
|
|
|
|
|
}
|
|
|
|
|
|
2010-04-26 10:48:31 -07:00
|
|
|
|
/* Looks at the list of managers in 'ovs_cfg' and extracts their remote IP
|
|
|
|
|
* addresses and ports into '*managersp' and '*n_managersp'. The caller is
|
|
|
|
|
* responsible for freeing '*managersp' (with free()).
|
|
|
|
|
*
|
|
|
|
|
* You may be asking yourself "why does ovs-vswitchd care?", because
|
|
|
|
|
* ovsdb-server is responsible for connecting to the managers, and ovs-vswitchd
|
|
|
|
|
* should not be and in fact is not directly involved in that. But
|
|
|
|
|
* ovs-vswitchd needs to make sure that ovsdb-server can reach the managers, so
|
|
|
|
|
* it has to tell in-band control where the managers are to enable that.
|
2010-11-05 10:22:18 -07:00
|
|
|
|
* (Thus, only managers connected in-band are collected.)
|
2010-04-26 10:48:31 -07:00
|
|
|
|
*/
|
|
|
|
|
static void
|
2010-11-05 10:22:18 -07:00
|
|
|
|
collect_in_band_managers(const struct ovsrec_open_vswitch *ovs_cfg,
|
|
|
|
|
struct sockaddr_in **managersp, size_t *n_managersp)
|
2010-04-26 10:48:31 -07:00
|
|
|
|
{
|
|
|
|
|
struct sockaddr_in *managers = NULL;
|
|
|
|
|
size_t n_managers = 0;
|
2011-03-25 15:26:30 -07:00
|
|
|
|
struct sset targets;
|
2010-11-05 10:22:18 -07:00
|
|
|
|
size_t i;
|
|
|
|
|
|
2011-02-18 09:50:12 -08:00
|
|
|
|
/* Collect all of the potential targets from the "targets" columns of the
|
|
|
|
|
* rows pointed to by "manager_options", excluding any that are
|
|
|
|
|
* out-of-band. */
|
2011-03-25 15:26:30 -07:00
|
|
|
|
sset_init(&targets);
|
2010-11-05 10:22:18 -07:00
|
|
|
|
for (i = 0; i < ovs_cfg->n_manager_options; i++) {
|
|
|
|
|
struct ovsrec_manager *m = ovs_cfg->manager_options[i];
|
|
|
|
|
|
|
|
|
|
if (m->connection_mode && !strcmp(m->connection_mode, "out-of-band")) {
|
2011-03-25 15:26:30 -07:00
|
|
|
|
sset_find_and_delete(&targets, m->target);
|
2010-11-05 10:22:18 -07:00
|
|
|
|
} else {
|
2011-03-25 15:26:30 -07:00
|
|
|
|
sset_add(&targets, m->target);
|
2010-11-05 10:22:18 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
2010-04-26 10:48:31 -07:00
|
|
|
|
|
2010-11-05 10:22:18 -07:00
|
|
|
|
/* Now extract the targets' IP addresses. */
|
2011-03-25 15:26:30 -07:00
|
|
|
|
if (!sset_is_empty(&targets)) {
|
|
|
|
|
const char *target;
|
2010-04-26 10:48:31 -07:00
|
|
|
|
|
2011-03-25 15:26:30 -07:00
|
|
|
|
managers = xmalloc(sset_count(&targets) * sizeof *managers);
|
|
|
|
|
SSET_FOR_EACH (target, &targets) {
|
2010-11-05 10:22:18 -07:00
|
|
|
|
struct sockaddr_in *sin = &managers[n_managers];
|
2010-04-26 10:48:31 -07:00
|
|
|
|
|
2010-11-05 10:22:18 -07:00
|
|
|
|
if ((!strncmp(target, "tcp:", 4)
|
|
|
|
|
&& inet_parse_active(target + 4, JSONRPC_TCP_PORT, sin)) ||
|
|
|
|
|
(!strncmp(target, "ssl:", 4)
|
|
|
|
|
&& inet_parse_active(target + 4, JSONRPC_SSL_PORT, sin))) {
|
2010-04-26 10:48:31 -07:00
|
|
|
|
n_managers++;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
2011-03-25 15:26:30 -07:00
|
|
|
|
sset_destroy(&targets);
|
2010-04-26 10:48:31 -07:00
|
|
|
|
|
|
|
|
|
*managersp = managers;
|
|
|
|
|
*n_managersp = n_managers;
|
|
|
|
|
}
|
|
|
|
|
|
2010-06-10 14:17:41 -07:00
|
|
|
|
static void
|
2009-12-03 11:28:40 -08:00
|
|
|
|
bridge_reconfigure(const struct ovsrec_open_vswitch *ovs_cfg)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2011-11-23 17:03:31 -08:00
|
|
|
|
unsigned long int *splinter_vlans;
|
2010-04-26 10:48:31 -07:00
|
|
|
|
struct sockaddr_in *managers;
|
2011-04-08 13:50:21 -07:00
|
|
|
|
struct bridge *br, *next;
|
2010-01-04 13:08:37 -08:00
|
|
|
|
int sflow_bridge_number;
|
2011-04-08 13:50:21 -07:00
|
|
|
|
size_t n_managers;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
|
|
|
|
COVERAGE_INC(bridge_reconfigure);
|
|
|
|
|
|
2011-04-08 13:50:21 -07:00
|
|
|
|
/* Create and destroy "struct bridge"s, "struct port"s, and "struct
|
|
|
|
|
* iface"s according to 'ovs_cfg', with only very minimal configuration
|
|
|
|
|
* otherwise.
|
|
|
|
|
*
|
2011-11-14 10:28:31 -08:00
|
|
|
|
* This is mostly an update to bridge data structures. Very little is
|
|
|
|
|
* pushed down to ofproto or lower layers. */
|
2011-04-08 13:50:21 -07:00
|
|
|
|
add_del_bridges(ovs_cfg);
|
2011-11-23 17:03:31 -08:00
|
|
|
|
splinter_vlans = collect_splinter_vlans(ovs_cfg);
|
2011-04-04 14:11:16 -07:00
|
|
|
|
HMAP_FOR_EACH (br, node, &all_bridges) {
|
2011-11-23 17:03:31 -08:00
|
|
|
|
bridge_add_del_ports(br, splinter_vlans);
|
2009-12-03 11:28:40 -08:00
|
|
|
|
}
|
2011-11-23 17:03:31 -08:00
|
|
|
|
free(splinter_vlans);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-04-08 13:50:21 -07:00
|
|
|
|
/* Delete all datapaths and datapath ports that are no longer configured.
|
2009-07-08 13:19:16 -07:00
|
|
|
|
*
|
|
|
|
|
* The kernel will reject any attempt to add a given port to a datapath if
|
|
|
|
|
* that port already belongs to a different datapath, so we must do all
|
2011-04-08 13:50:21 -07:00
|
|
|
|
* port deletions before any port additions. A datapath always has a
|
|
|
|
|
* "local port" so we must delete not-configured datapaths too. */
|
2011-05-09 09:33:02 -07:00
|
|
|
|
bridge_del_ofprotos();
|
2011-04-04 14:11:16 -07:00
|
|
|
|
HMAP_FOR_EACH (br, node, &all_bridges) {
|
2011-04-08 13:50:21 -07:00
|
|
|
|
if (br->ofproto) {
|
|
|
|
|
bridge_del_ofproto_ports(br);
|
2009-12-03 11:28:40 -08:00
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-04-08 13:50:21 -07:00
|
|
|
|
/* Create datapaths and datapath ports that are missing.
|
|
|
|
|
*
|
|
|
|
|
* After this is done, we have our final set of bridges, ports, and
|
|
|
|
|
* interfaces. Every "struct bridge" has an ofproto, every "struct port"
|
2011-05-09 09:24:39 -07:00
|
|
|
|
* has at least one iface, every "struct iface" has a valid ofp_port and
|
2011-04-08 13:50:21 -07:00
|
|
|
|
* netdev. */
|
|
|
|
|
HMAP_FOR_EACH_SAFE (br, next, node, &all_bridges) {
|
2011-05-09 09:33:02 -07:00
|
|
|
|
if (!br->ofproto && !bridge_add_ofprotos(br)) {
|
2009-07-08 13:19:16 -07:00
|
|
|
|
bridge_destroy(br);
|
|
|
|
|
}
|
|
|
|
|
}
|
2011-05-04 10:18:23 -07:00
|
|
|
|
HMAP_FOR_EACH (br, node, &all_bridges) {
|
2011-05-09 09:24:39 -07:00
|
|
|
|
bridge_refresh_ofp_port(br);
|
2011-04-08 13:50:21 -07:00
|
|
|
|
bridge_add_ofproto_ports(br);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-04-08 13:50:21 -07:00
|
|
|
|
/* Complete the configuration. */
|
|
|
|
|
sflow_bridge_number = 0;
|
|
|
|
|
collect_in_band_managers(ovs_cfg, &managers, &n_managers);
|
2011-04-04 14:11:16 -07:00
|
|
|
|
HMAP_FOR_EACH (br, node, &all_bridges) {
|
2011-03-21 10:07:39 -07:00
|
|
|
|
struct port *port;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-11-30 12:09:35 -08:00
|
|
|
|
/* We need the datapath ID early to allow LACP ports to use it as the
|
|
|
|
|
* default system ID. */
|
|
|
|
|
bridge_configure_datapath_id(br);
|
|
|
|
|
|
2011-03-21 10:07:39 -07:00
|
|
|
|
HMAP_FOR_EACH (port, hmap_node, &br->ports) {
|
2011-03-21 10:24:32 -07:00
|
|
|
|
struct iface *iface;
|
2009-10-02 13:29:01 -07:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
port_configure(port);
|
2010-06-17 15:04:12 -07:00
|
|
|
|
|
2011-05-25 13:23:49 -07:00
|
|
|
|
LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
|
2011-04-08 13:50:21 -07:00
|
|
|
|
iface_configure_cfm(iface);
|
|
|
|
|
iface_configure_qos(iface, port->cfg->qos);
|
2011-05-04 10:12:03 -07:00
|
|
|
|
iface_set_mac(iface);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
2011-05-11 12:26:06 -07:00
|
|
|
|
bridge_configure_mirrors(br);
|
2011-07-28 16:38:50 -07:00
|
|
|
|
bridge_configure_flow_eviction_threshold(br);
|
Option to forward BPDU (Ethernet control class) frames
Currently, a NORMAL action bridge drops reserved-multicast-mac addresses;
01-80-c2-00-00-[f0:ff]. A node that does not implement STP should have an
option to forward such frames.
This commit proposes to have a configuration option to allow forwarding of
BPDU class frames. To ensure backward compatibility, this option is
disabled by default.
This config can be set using bridge's other-config column, for e.g
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
Changing this option can revalidate all flows in a software-OVS
implementation (ofproto-dpif)
--------
unit tests:
------------
make config changes, test runtime behavior
-- test runtime behavior --
continuously send packets to br0 with dest-mac=01:80:c2:00:00:00
ovs-dpctl dump-flows br0
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
ovs-dpctl dump-flows br0
ovs-vsctl set bridge br0 other-config:forward-bpdu=false
ovs-dpctl dump-flows br0
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
ovs-dpctl dump-flows br0
ovs-vsctl remove bridge br0 other-config forward-bpdu=true
ovs-dpctl dump-flows br0
--result--
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:29550, bytes:1773000, used:0.004s, actions:drop
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:8209, bytes:492540, used:0.000s, actions:2,0
ovs-vsctl set bridge br0 other-config:forward-bpdu=false
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:19, bytes:1140, used:0.000s, actions:drop
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:29, bytes:1740, used:0.000s, actions:2,0
ovs-vsctl remove bridge br0 other-config forward-bpdu=true
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:0, bytes:0, used:never, actions:drop
Bug #6624
Reported-by: Niklas Andersson <nandersson@nicira.com>
2011-08-09 11:08:27 -07:00
|
|
|
|
bridge_configure_forward_bpdu(br);
|
2011-05-11 12:26:06 -07:00
|
|
|
|
bridge_configure_remotes(br, managers, n_managers);
|
2011-04-08 13:50:21 -07:00
|
|
|
|
bridge_configure_netflow(br);
|
|
|
|
|
bridge_configure_sflow(br, &sflow_bridge_number);
|
2011-10-14 09:48:17 -07:00
|
|
|
|
bridge_configure_stp(br);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2011-04-08 13:50:21 -07:00
|
|
|
|
free(managers);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-04-08 13:50:21 -07:00
|
|
|
|
/* ovs-vswitchd has completed initialization, so allow the process that
|
|
|
|
|
* forked us to exit successfully. */
|
|
|
|
|
daemonize_complete();
|
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-05-09 09:33:02 -07:00
|
|
|
|
/* Iterate over all ofprotos and delete any of them that do not have a
|
2011-04-08 13:50:21 -07:00
|
|
|
|
* configured bridge or that are the wrong type. */
|
|
|
|
|
static void
|
2011-05-09 09:33:02 -07:00
|
|
|
|
bridge_del_ofprotos(void)
|
2011-04-08 13:50:21 -07:00
|
|
|
|
{
|
2011-05-09 09:33:02 -07:00
|
|
|
|
struct sset names;
|
|
|
|
|
struct sset types;
|
2011-04-08 13:50:21 -07:00
|
|
|
|
const char *type;
|
2009-12-01 01:14:33 -08:00
|
|
|
|
|
2011-05-09 09:33:02 -07:00
|
|
|
|
sset_init(&names);
|
|
|
|
|
sset_init(&types);
|
|
|
|
|
ofproto_enumerate_types(&types);
|
|
|
|
|
SSET_FOR_EACH (type, &types) {
|
2011-04-08 13:50:21 -07:00
|
|
|
|
const char *name;
|
2010-10-11 10:28:28 -07:00
|
|
|
|
|
2011-05-09 09:33:02 -07:00
|
|
|
|
ofproto_enumerate_names(type, &names);
|
|
|
|
|
SSET_FOR_EACH (name, &names) {
|
2011-04-08 13:50:21 -07:00
|
|
|
|
struct bridge *br = bridge_lookup(name);
|
|
|
|
|
if (!br || strcmp(type, br->type)) {
|
2011-05-09 09:33:02 -07:00
|
|
|
|
ofproto_delete(name, type);
|
2010-10-11 10:28:28 -07:00
|
|
|
|
}
|
2010-11-15 16:20:01 -08:00
|
|
|
|
}
|
|
|
|
|
}
|
2011-05-09 09:33:02 -07:00
|
|
|
|
sset_destroy(&names);
|
|
|
|
|
sset_destroy(&types);
|
2011-04-08 13:50:21 -07:00
|
|
|
|
}
|
2009-12-03 11:28:40 -08:00
|
|
|
|
|
2011-04-08 13:50:21 -07:00
|
|
|
|
static bool
|
2011-05-09 09:33:02 -07:00
|
|
|
|
bridge_add_ofprotos(struct bridge *br)
|
2011-04-08 13:50:21 -07:00
|
|
|
|
{
|
2011-05-11 12:26:06 -07:00
|
|
|
|
int error = ofproto_create(br->name, br->type, &br->ofproto);
|
2011-04-08 13:50:21 -07:00
|
|
|
|
if (error) {
|
2011-05-11 12:26:06 -07:00
|
|
|
|
VLOG_ERR("failed to create bridge %s: %s", br->name, strerror(error));
|
2011-04-08 13:50:21 -07:00
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
return true;
|
2009-12-11 17:03:35 -08:00
|
|
|
|
}
|
2010-12-03 14:41:38 -08:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
static void
|
|
|
|
|
port_configure(struct port *port)
|
|
|
|
|
{
|
|
|
|
|
const struct ovsrec_port *cfg = port->cfg;
|
|
|
|
|
struct bond_settings bond_settings;
|
|
|
|
|
struct lacp_settings lacp_settings;
|
|
|
|
|
struct ofproto_bundle_settings s;
|
|
|
|
|
struct iface *iface;
|
2010-09-27 11:39:41 -07:00
|
|
|
|
|
2011-11-23 17:03:31 -08:00
|
|
|
|
if (cfg->vlan_mode && !strcmp(cfg->vlan_mode, "splinter")) {
|
|
|
|
|
configure_splinter_port(port);
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
/* Get name. */
|
|
|
|
|
s.name = port->name;
|
2010-10-11 10:28:28 -07:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
/* Get slaves. */
|
|
|
|
|
s.n_slaves = 0;
|
|
|
|
|
s.slaves = xmalloc(list_size(&port->ifaces) * sizeof *s.slaves);
|
|
|
|
|
LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
|
2011-05-09 09:24:39 -07:00
|
|
|
|
s.slaves[s.n_slaves++] = iface->ofp_port;
|
2011-05-11 12:26:06 -07:00
|
|
|
|
}
|
2010-12-03 14:41:38 -08:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
/* Get VLAN tag. */
|
|
|
|
|
s.vlan = -1;
|
2011-12-12 14:44:23 -08:00
|
|
|
|
if (cfg->tag && *cfg->tag >= 0 && *cfg->tag <= 4095) {
|
|
|
|
|
s.vlan = *cfg->tag;
|
2011-05-11 12:26:06 -07:00
|
|
|
|
}
|
datapath: Change listing ports to use an iterator concept.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to add new
features to the kernel vport layer without changing userspace software. In
turn, that means that the odp_port structure must become variable-length.
This does not, however, fit in well with the ODP_PORT_LIST ioctl in its
current form, because that would require userspace to know how much space
to allocate for each port in advance, or to allocate as much space as
could possibly be needed. Neither choice is very attractive.
This commit prepares for a different solution, by replacing ODP_PORT_LIST
by a new ioctl ODP_VPORT_DUMP that retrieves information about a single
vport from the datapath on each call. It is much cleaner to allocate the
maximum amount of space for a single vport than to do so for possibly a
large number of vports.
It would be faster to retrieve a number of vports in batch instead of just
one at a time, but that will naturally happen later when the kernel
datapath interface is changed to use Netlink, so this patch does not bother
with it.
The Netlink version won't need to take the starting port number from
userspace, since Netlink sockets can keep track of that state as part
of their "dump" feature.
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2011-01-10 13:12:12 -08:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
/* Get VLAN trunks. */
|
|
|
|
|
s.trunks = NULL;
|
2011-09-23 17:03:03 -07:00
|
|
|
|
if (cfg->n_trunks) {
|
2011-05-11 12:26:06 -07:00
|
|
|
|
s.trunks = vlan_bitmap_from_array(cfg->trunks, cfg->n_trunks);
|
2011-09-23 17:03:03 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Get VLAN mode. */
|
|
|
|
|
if (cfg->vlan_mode) {
|
|
|
|
|
if (!strcmp(cfg->vlan_mode, "access")) {
|
|
|
|
|
s.vlan_mode = PORT_VLAN_ACCESS;
|
|
|
|
|
} else if (!strcmp(cfg->vlan_mode, "trunk")) {
|
|
|
|
|
s.vlan_mode = PORT_VLAN_TRUNK;
|
|
|
|
|
} else if (!strcmp(cfg->vlan_mode, "native-tagged")) {
|
|
|
|
|
s.vlan_mode = PORT_VLAN_NATIVE_TAGGED;
|
|
|
|
|
} else if (!strcmp(cfg->vlan_mode, "native-untagged")) {
|
|
|
|
|
s.vlan_mode = PORT_VLAN_NATIVE_UNTAGGED;
|
|
|
|
|
} else {
|
|
|
|
|
/* This "can't happen" because ovsdb-server should prevent it. */
|
|
|
|
|
VLOG_ERR("unknown VLAN mode %s", cfg->vlan_mode);
|
|
|
|
|
s.vlan_mode = PORT_VLAN_TRUNK;
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
if (s.vlan >= 0) {
|
|
|
|
|
s.vlan_mode = PORT_VLAN_ACCESS;
|
|
|
|
|
if (cfg->n_trunks) {
|
|
|
|
|
VLOG_ERR("port %s: ignoring trunks in favor of implicit vlan",
|
|
|
|
|
port->name);
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
s.vlan_mode = PORT_VLAN_TRUNK;
|
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2011-11-17 17:11:53 -08:00
|
|
|
|
s.use_priority_tags = !strcmp("true", get_port_other_config(
|
|
|
|
|
cfg, "priority-tags", ""));
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
/* Get LACP settings. */
|
|
|
|
|
s.lacp = port_configure_lacp(port, &lacp_settings);
|
|
|
|
|
if (s.lacp) {
|
|
|
|
|
size_t i = 0;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
s.lacp_slaves = xmalloc(s.n_slaves * sizeof *s.lacp_slaves);
|
|
|
|
|
LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
|
|
|
|
|
iface_configure_lacp(iface, &s.lacp_slaves[i++]);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2011-05-11 12:26:06 -07:00
|
|
|
|
} else {
|
|
|
|
|
s.lacp_slaves = NULL;
|
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
/* Get bond settings. */
|
|
|
|
|
if (s.n_slaves > 1) {
|
|
|
|
|
s.bond = &bond_settings;
|
2011-05-13 16:47:01 -07:00
|
|
|
|
s.bond_stable_ids = xmalloc(s.n_slaves * sizeof *s.bond_stable_ids);
|
|
|
|
|
port_configure_bond(port, &bond_settings, s.bond_stable_ids);
|
2011-05-11 12:26:06 -07:00
|
|
|
|
} else {
|
|
|
|
|
s.bond = NULL;
|
2011-05-13 16:47:01 -07:00
|
|
|
|
s.bond_stable_ids = NULL;
|
2011-05-16 14:40:03 -07:00
|
|
|
|
|
|
|
|
|
LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
|
|
|
|
|
netdev_set_miimon_interval(iface->netdev, 0);
|
|
|
|
|
}
|
2011-05-11 12:26:06 -07:00
|
|
|
|
}
|
2009-12-11 17:03:35 -08:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
/* Register. */
|
|
|
|
|
ofproto_bundle_register(port->bridge->ofproto, port, &s);
|
2009-12-03 11:28:40 -08:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
/* Clean up. */
|
2011-06-07 13:19:41 -07:00
|
|
|
|
free(s.slaves);
|
2011-05-11 12:26:06 -07:00
|
|
|
|
free(s.trunks);
|
|
|
|
|
free(s.lacp_slaves);
|
2011-05-13 16:47:01 -07:00
|
|
|
|
free(s.bond_stable_ids);
|
2011-05-11 12:26:06 -07:00
|
|
|
|
}
|
2009-12-03 11:28:40 -08:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
/* Pick local port hardware address and datapath ID for 'br'. */
|
|
|
|
|
static void
|
|
|
|
|
bridge_configure_datapath_id(struct bridge *br)
|
|
|
|
|
{
|
|
|
|
|
uint8_t ea[ETH_ADDR_LEN];
|
|
|
|
|
uint64_t dpid;
|
|
|
|
|
struct iface *local_iface;
|
|
|
|
|
struct iface *hw_addr_iface;
|
|
|
|
|
char *dpid_string;
|
2009-12-03 11:28:40 -08:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
bridge_pick_local_hw_addr(br, ea, &hw_addr_iface);
|
2011-05-09 09:24:39 -07:00
|
|
|
|
local_iface = iface_from_ofp_port(br, OFPP_LOCAL);
|
2011-05-04 10:20:04 -07:00
|
|
|
|
if (local_iface) {
|
|
|
|
|
int error = netdev_set_etheraddr(local_iface->netdev, ea);
|
|
|
|
|
if (error) {
|
|
|
|
|
static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
|
|
|
|
|
VLOG_ERR_RL(&rl, "bridge %s: failed to set bridge "
|
|
|
|
|
"Ethernet address: %s",
|
|
|
|
|
br->name, strerror(error));
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
memcpy(br->ea, ea, ETH_ADDR_LEN);
|
2009-12-03 11:28:40 -08:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
dpid = bridge_pick_datapath_id(br, ea, hw_addr_iface);
|
|
|
|
|
ofproto_set_datapath_id(br->ofproto, dpid);
|
2009-12-03 11:28:40 -08:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
dpid_string = xasprintf("%016"PRIx64, dpid);
|
|
|
|
|
ovsrec_bridge_set_datapath_id(br->cfg, dpid_string);
|
|
|
|
|
free(dpid_string);
|
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
/* Set NetFlow configuration on 'br'. */
|
|
|
|
|
static void
|
|
|
|
|
bridge_configure_netflow(struct bridge *br)
|
|
|
|
|
{
|
|
|
|
|
struct ovsrec_netflow *cfg = br->cfg->netflow;
|
|
|
|
|
struct netflow_options opts;
|
2010-01-04 13:08:37 -08:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
if (!cfg) {
|
|
|
|
|
ofproto_set_netflow(br->ofproto, NULL);
|
|
|
|
|
return;
|
|
|
|
|
}
|
2010-02-05 15:58:27 -08:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
memset(&opts, 0, sizeof opts);
|
2010-01-04 13:08:37 -08:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
/* Get default NetFlow configuration from datapath.
|
|
|
|
|
* Apply overrides from 'cfg'. */
|
|
|
|
|
ofproto_get_netflow_ids(br->ofproto, &opts.engine_type, &opts.engine_id);
|
|
|
|
|
if (cfg->engine_type) {
|
|
|
|
|
opts.engine_type = *cfg->engine_type;
|
|
|
|
|
}
|
|
|
|
|
if (cfg->engine_id) {
|
|
|
|
|
opts.engine_id = *cfg->engine_id;
|
|
|
|
|
}
|
2010-01-04 13:08:37 -08:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
/* Configure active timeout interval. */
|
|
|
|
|
opts.active_timeout = cfg->active_timeout;
|
|
|
|
|
if (!opts.active_timeout) {
|
|
|
|
|
opts.active_timeout = -1;
|
|
|
|
|
} else if (opts.active_timeout < 0) {
|
|
|
|
|
VLOG_WARN("bridge %s: active timeout interval set to negative "
|
|
|
|
|
"value, using default instead (%d seconds)", br->name,
|
|
|
|
|
NF_ACTIVE_TIMEOUT_DEFAULT);
|
|
|
|
|
opts.active_timeout = -1;
|
|
|
|
|
}
|
2010-01-04 13:08:37 -08:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
/* Add engine ID to interface number to disambiguate bridgs? */
|
|
|
|
|
opts.add_id_to_iface = cfg->add_id_to_interface;
|
|
|
|
|
if (opts.add_id_to_iface) {
|
|
|
|
|
if (opts.engine_id > 0x7f) {
|
|
|
|
|
VLOG_WARN("bridge %s: NetFlow port mangling may conflict with "
|
|
|
|
|
"another vswitch, choose an engine id less than 128",
|
|
|
|
|
br->name);
|
|
|
|
|
}
|
|
|
|
|
if (hmap_count(&br->ports) > 508) {
|
|
|
|
|
VLOG_WARN("bridge %s: NetFlow port mangling will conflict with "
|
|
|
|
|
"another port when more than 508 ports are used",
|
|
|
|
|
br->name);
|
|
|
|
|
}
|
|
|
|
|
}
|
2010-01-04 13:08:37 -08:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
/* Collectors. */
|
|
|
|
|
sset_init(&opts.collectors);
|
|
|
|
|
sset_add_array(&opts.collectors, cfg->targets, cfg->n_targets);
|
2010-02-05 15:58:27 -08:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
/* Configure. */
|
|
|
|
|
if (ofproto_set_netflow(br->ofproto, &opts)) {
|
|
|
|
|
VLOG_ERR("bridge %s: problem setting netflow collectors", br->name);
|
|
|
|
|
}
|
|
|
|
|
sset_destroy(&opts.collectors);
|
|
|
|
|
}
|
2010-01-04 13:08:37 -08:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
/* Set sFlow configuration on 'br'. */
|
|
|
|
|
static void
|
|
|
|
|
bridge_configure_sflow(struct bridge *br, int *sflow_bridge_number)
|
|
|
|
|
{
|
|
|
|
|
const struct ovsrec_sflow *cfg = br->cfg->sflow;
|
|
|
|
|
struct ovsrec_controller **controllers;
|
|
|
|
|
struct ofproto_sflow_options oso;
|
|
|
|
|
size_t n_controllers;
|
|
|
|
|
size_t i;
|
2010-01-04 13:08:37 -08:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
if (!cfg) {
|
|
|
|
|
ofproto_set_sflow(br->ofproto, NULL);
|
|
|
|
|
return;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2011-03-21 10:07:39 -07:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
memset(&oso, 0, sizeof oso);
|
2009-10-02 13:29:01 -07:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
sset_init(&oso.targets);
|
|
|
|
|
sset_add_array(&oso.targets, cfg->targets, cfg->n_targets);
|
2010-06-17 15:04:12 -07:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
oso.sampling_rate = SFL_DEFAULT_SAMPLING_RATE;
|
|
|
|
|
if (cfg->sampling) {
|
|
|
|
|
oso.sampling_rate = *cfg->sampling;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2011-05-04 10:20:04 -07:00
|
|
|
|
|
|
|
|
|
oso.polling_interval = SFL_DEFAULT_POLLING_INTERVAL;
|
|
|
|
|
if (cfg->polling) {
|
|
|
|
|
oso.polling_interval = *cfg->polling;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2009-12-11 17:03:35 -08:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
oso.header_len = SFL_DEFAULT_HEADER_SIZE;
|
|
|
|
|
if (cfg->header) {
|
|
|
|
|
oso.header_len = *cfg->header;
|
|
|
|
|
}
|
2011-04-06 16:59:22 -07:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
oso.sub_id = (*sflow_bridge_number)++;
|
|
|
|
|
oso.agent_device = cfg->agent;
|
2011-04-06 16:59:22 -07:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
oso.control_ip = NULL;
|
|
|
|
|
n_controllers = bridge_get_controllers(br, &controllers);
|
|
|
|
|
for (i = 0; i < n_controllers; i++) {
|
|
|
|
|
if (controllers[i]->local_ip) {
|
|
|
|
|
oso.control_ip = controllers[i]->local_ip;
|
|
|
|
|
break;
|
2010-11-15 16:20:01 -08:00
|
|
|
|
}
|
|
|
|
|
}
|
2011-05-04 10:20:04 -07:00
|
|
|
|
ofproto_set_sflow(br->ofproto, &oso);
|
2010-11-15 16:20:01 -08:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
sset_destroy(&oso.targets);
|
|
|
|
|
}
|
2011-01-28 12:44:00 -08:00
|
|
|
|
|
2011-10-14 09:48:17 -07:00
|
|
|
|
static void
|
|
|
|
|
port_configure_stp(const struct ofproto *ofproto, struct port *port,
|
|
|
|
|
struct ofproto_port_stp_settings *port_s,
|
|
|
|
|
int *port_num_counter, unsigned long *port_num_bitmap)
|
|
|
|
|
{
|
|
|
|
|
const char *config_str;
|
|
|
|
|
struct iface *iface;
|
|
|
|
|
|
|
|
|
|
config_str = get_port_other_config(port->cfg, "stp-enable", NULL);
|
|
|
|
|
if (config_str && !strcmp(config_str, "false")) {
|
|
|
|
|
port_s->enable = false;
|
|
|
|
|
return;
|
|
|
|
|
} else {
|
|
|
|
|
port_s->enable = true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* STP over bonds is not supported. */
|
|
|
|
|
if (!list_is_singleton(&port->ifaces)) {
|
|
|
|
|
VLOG_ERR("port %s: cannot enable STP on bonds, disabling",
|
|
|
|
|
port->name);
|
|
|
|
|
port_s->enable = false;
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
iface = CONTAINER_OF(list_front(&port->ifaces), struct iface, port_elem);
|
|
|
|
|
|
|
|
|
|
/* Internal ports shouldn't participate in spanning tree, so
|
|
|
|
|
* skip them. */
|
|
|
|
|
if (!strcmp(iface->type, "internal")) {
|
|
|
|
|
VLOG_DBG("port %s: disable STP on internal ports", port->name);
|
|
|
|
|
port_s->enable = false;
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* STP on mirror output ports is not supported. */
|
|
|
|
|
if (ofproto_is_mirror_output_bundle(ofproto, port)) {
|
|
|
|
|
VLOG_DBG("port %s: disable STP on mirror ports", port->name);
|
|
|
|
|
port_s->enable = false;
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
config_str = get_port_other_config(port->cfg, "stp-port-num", NULL);
|
|
|
|
|
if (config_str) {
|
|
|
|
|
unsigned long int port_num = strtoul(config_str, NULL, 0);
|
|
|
|
|
int port_idx = port_num - 1;
|
|
|
|
|
|
|
|
|
|
if (port_num < 1 || port_num > STP_MAX_PORTS) {
|
|
|
|
|
VLOG_ERR("port %s: invalid stp-port-num", port->name);
|
|
|
|
|
port_s->enable = false;
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (bitmap_is_set(port_num_bitmap, port_idx)) {
|
|
|
|
|
VLOG_ERR("port %s: duplicate stp-port-num %lu, disabling",
|
|
|
|
|
port->name, port_num);
|
|
|
|
|
port_s->enable = false;
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
bitmap_set1(port_num_bitmap, port_idx);
|
|
|
|
|
port_s->port_num = port_idx;
|
|
|
|
|
} else {
|
|
|
|
|
if (*port_num_counter > STP_MAX_PORTS) {
|
|
|
|
|
VLOG_ERR("port %s: too many STP ports, disabling", port->name);
|
|
|
|
|
port_s->enable = false;
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
port_s->port_num = (*port_num_counter)++;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
config_str = get_port_other_config(port->cfg, "stp-path-cost", NULL);
|
|
|
|
|
if (config_str) {
|
|
|
|
|
port_s->path_cost = strtoul(config_str, NULL, 10);
|
|
|
|
|
} else {
|
|
|
|
|
uint32_t current;
|
|
|
|
|
|
|
|
|
|
if (netdev_get_features(iface->netdev, ¤t, NULL, NULL, NULL)) {
|
|
|
|
|
/* Couldn't get speed, so assume 100Mb/s. */
|
|
|
|
|
port_s->path_cost = 19;
|
|
|
|
|
} else {
|
|
|
|
|
unsigned int mbps;
|
|
|
|
|
|
|
|
|
|
mbps = netdev_features_to_bps(current) / 1000000;
|
|
|
|
|
port_s->path_cost = stp_convert_speed_to_cost(mbps);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
config_str = get_port_other_config(port->cfg, "stp-port-priority", NULL);
|
|
|
|
|
if (config_str) {
|
|
|
|
|
port_s->priority = strtoul(config_str, NULL, 0);
|
|
|
|
|
} else {
|
|
|
|
|
port_s->priority = STP_DEFAULT_PORT_PRIORITY;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Set spanning tree configuration on 'br'. */
|
|
|
|
|
static void
|
|
|
|
|
bridge_configure_stp(struct bridge *br)
|
|
|
|
|
{
|
|
|
|
|
if (!br->cfg->stp_enable) {
|
|
|
|
|
ofproto_set_stp(br->ofproto, NULL);
|
|
|
|
|
} else {
|
|
|
|
|
struct ofproto_stp_settings br_s;
|
|
|
|
|
const char *config_str;
|
|
|
|
|
struct port *port;
|
|
|
|
|
int port_num_counter;
|
|
|
|
|
unsigned long *port_num_bitmap;
|
|
|
|
|
|
|
|
|
|
config_str = bridge_get_other_config(br->cfg, "stp-system-id");
|
|
|
|
|
if (config_str) {
|
|
|
|
|
uint8_t ea[ETH_ADDR_LEN];
|
|
|
|
|
|
|
|
|
|
if (eth_addr_from_string(config_str, ea)) {
|
|
|
|
|
br_s.system_id = eth_addr_to_uint64(ea);
|
|
|
|
|
} else {
|
|
|
|
|
br_s.system_id = eth_addr_to_uint64(br->ea);
|
|
|
|
|
VLOG_ERR("bridge %s: invalid stp-system-id, defaulting "
|
|
|
|
|
"to "ETH_ADDR_FMT, br->name, ETH_ADDR_ARGS(br->ea));
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
br_s.system_id = eth_addr_to_uint64(br->ea);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
config_str = bridge_get_other_config(br->cfg, "stp-priority");
|
|
|
|
|
if (config_str) {
|
|
|
|
|
br_s.priority = strtoul(config_str, NULL, 0);
|
|
|
|
|
} else {
|
|
|
|
|
br_s.priority = STP_DEFAULT_BRIDGE_PRIORITY;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
config_str = bridge_get_other_config(br->cfg, "stp-hello-time");
|
|
|
|
|
if (config_str) {
|
|
|
|
|
br_s.hello_time = strtoul(config_str, NULL, 10) * 1000;
|
|
|
|
|
} else {
|
|
|
|
|
br_s.hello_time = STP_DEFAULT_HELLO_TIME;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
config_str = bridge_get_other_config(br->cfg, "stp-max-age");
|
|
|
|
|
if (config_str) {
|
|
|
|
|
br_s.max_age = strtoul(config_str, NULL, 10) * 1000;
|
|
|
|
|
} else {
|
|
|
|
|
br_s.max_age = STP_DEFAULT_MAX_AGE;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
config_str = bridge_get_other_config(br->cfg, "stp-forward-delay");
|
|
|
|
|
if (config_str) {
|
|
|
|
|
br_s.fwd_delay = strtoul(config_str, NULL, 10) * 1000;
|
|
|
|
|
} else {
|
|
|
|
|
br_s.fwd_delay = STP_DEFAULT_FWD_DELAY;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Configure STP on the bridge. */
|
|
|
|
|
if (ofproto_set_stp(br->ofproto, &br_s)) {
|
|
|
|
|
VLOG_ERR("bridge %s: could not enable STP", br->name);
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Users must either set the port number with the "stp-port-num"
|
|
|
|
|
* configuration on all ports or none. If manual configuration
|
|
|
|
|
* is not done, then we allocate them sequentially. */
|
|
|
|
|
port_num_counter = 0;
|
|
|
|
|
port_num_bitmap = bitmap_allocate(STP_MAX_PORTS);
|
|
|
|
|
HMAP_FOR_EACH (port, hmap_node, &br->ports) {
|
|
|
|
|
struct ofproto_port_stp_settings port_s;
|
|
|
|
|
struct iface *iface;
|
|
|
|
|
|
|
|
|
|
port_configure_stp(br->ofproto, port, &port_s,
|
|
|
|
|
&port_num_counter, port_num_bitmap);
|
|
|
|
|
|
|
|
|
|
/* As bonds are not supported, just apply configuration to
|
|
|
|
|
* all interfaces. */
|
|
|
|
|
LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
|
|
|
|
|
if (ofproto_port_set_stp(br->ofproto, iface->ofp_port,
|
|
|
|
|
&port_s)) {
|
|
|
|
|
VLOG_ERR("port %s: could not enable STP", port->name);
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (bitmap_scan(port_num_bitmap, 0, STP_MAX_PORTS) != STP_MAX_PORTS
|
|
|
|
|
&& port_num_counter) {
|
|
|
|
|
VLOG_ERR("bridge %s: must manually configure all STP port "
|
|
|
|
|
"IDs or none, disabling", br->name);
|
|
|
|
|
ofproto_set_stp(br->ofproto, NULL);
|
|
|
|
|
}
|
|
|
|
|
bitmap_free(port_num_bitmap);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2011-05-04 10:18:23 -07:00
|
|
|
|
static bool
|
|
|
|
|
bridge_has_bond_fake_iface(const struct bridge *br, const char *name)
|
|
|
|
|
{
|
|
|
|
|
const struct port *port = port_lookup(br, name);
|
|
|
|
|
return port && port_is_bond_fake_iface(port);
|
2009-12-11 17:03:35 -08:00
|
|
|
|
}
|
|
|
|
|
|
2011-05-04 10:18:23 -07:00
|
|
|
|
static bool
|
|
|
|
|
port_is_bond_fake_iface(const struct port *port)
|
2009-12-11 17:03:35 -08:00
|
|
|
|
{
|
2011-05-04 10:18:23 -07:00
|
|
|
|
return port->cfg->bond_fake_iface && !list_is_short(&port->ifaces);
|
|
|
|
|
}
|
2009-12-11 17:03:35 -08:00
|
|
|
|
|
2011-04-08 13:50:21 -07:00
|
|
|
|
static void
|
|
|
|
|
add_del_bridges(const struct ovsrec_open_vswitch *cfg)
|
|
|
|
|
{
|
|
|
|
|
struct bridge *br, *next;
|
|
|
|
|
struct shash new_br;
|
|
|
|
|
size_t i;
|
|
|
|
|
|
|
|
|
|
/* Collect new bridges' names and types. */
|
|
|
|
|
shash_init(&new_br);
|
|
|
|
|
for (i = 0; i < cfg->n_bridges; i++) {
|
2011-10-14 10:17:41 -07:00
|
|
|
|
static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
|
2011-04-08 13:50:21 -07:00
|
|
|
|
const struct ovsrec_bridge *br_cfg = cfg->bridges[i];
|
2011-10-14 10:17:41 -07:00
|
|
|
|
|
|
|
|
|
if (strchr(br_cfg->name, '/')) {
|
|
|
|
|
/* Prevent remote ovsdb-server users from accessing arbitrary
|
|
|
|
|
* directories, e.g. consider a bridge named "../../../etc/". */
|
|
|
|
|
VLOG_WARN_RL(&rl, "ignoring bridge with invalid name \"%s\"",
|
|
|
|
|
br_cfg->name);
|
|
|
|
|
} else if (!shash_add_once(&new_br, br_cfg->name, br_cfg)) {
|
|
|
|
|
VLOG_WARN_RL(&rl, "bridge %s specified twice", br_cfg->name);
|
2011-04-08 13:50:21 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Get rid of deleted bridges or those whose types have changed.
|
|
|
|
|
* Update 'cfg' of bridges that still exist. */
|
|
|
|
|
HMAP_FOR_EACH_SAFE (br, next, node, &all_bridges) {
|
|
|
|
|
br->cfg = shash_find_data(&new_br, br->name);
|
2011-05-09 09:33:02 -07:00
|
|
|
|
if (!br->cfg || strcmp(br->type, ofproto_normalize_type(
|
|
|
|
|
br->cfg->datapath_type))) {
|
2011-04-08 13:50:21 -07:00
|
|
|
|
bridge_destroy(br);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Add new bridges. */
|
|
|
|
|
for (i = 0; i < cfg->n_bridges; i++) {
|
|
|
|
|
const struct ovsrec_bridge *br_cfg = cfg->bridges[i];
|
|
|
|
|
struct bridge *br = bridge_lookup(br_cfg->name);
|
|
|
|
|
if (!br) {
|
|
|
|
|
bridge_create(br_cfg);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
shash_destroy(&new_br);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Delete each ofproto port on 'br' that doesn't have a corresponding "struct
|
|
|
|
|
* iface".
|
|
|
|
|
*
|
|
|
|
|
* The kernel will reject any attempt to add a given port to a datapath if that
|
|
|
|
|
* port already belongs to a different datapath, so we must do all port
|
|
|
|
|
* deletions before any port additions. */
|
|
|
|
|
static void
|
|
|
|
|
bridge_del_ofproto_ports(struct bridge *br)
|
|
|
|
|
{
|
|
|
|
|
struct ofproto_port_dump dump;
|
|
|
|
|
struct ofproto_port ofproto_port;
|
|
|
|
|
|
|
|
|
|
OFPROTO_PORT_FOR_EACH (&ofproto_port, &dump, br->ofproto) {
|
|
|
|
|
const char *name = ofproto_port.name;
|
|
|
|
|
struct iface *iface;
|
|
|
|
|
const char *type;
|
|
|
|
|
int error;
|
|
|
|
|
|
|
|
|
|
/* Ignore the local port. We can't change it anyhow. */
|
|
|
|
|
if (!strcmp(name, br->name)) {
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Get the type that 'ofproto_port' should have (ordinarily the
|
|
|
|
|
* type of its corresponding iface) or NULL if it should be
|
|
|
|
|
* deleted. */
|
|
|
|
|
iface = iface_lookup(br, name);
|
|
|
|
|
type = (iface ? iface->type
|
|
|
|
|
: bridge_has_bond_fake_iface(br, name) ? "internal"
|
|
|
|
|
: NULL);
|
|
|
|
|
|
|
|
|
|
/* If it's the wrong type then delete the ofproto port. */
|
|
|
|
|
if (type
|
|
|
|
|
&& !strcmp(ofproto_port.type, type)
|
|
|
|
|
&& (!iface || !iface->netdev
|
|
|
|
|
|| !strcmp(netdev_get_type(iface->netdev), type))) {
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
error = ofproto_port_del(br->ofproto, ofproto_port.ofp_port);
|
|
|
|
|
if (error) {
|
|
|
|
|
VLOG_WARN("bridge %s: failed to remove %s interface (%s)",
|
|
|
|
|
br->name, name, strerror(error));
|
|
|
|
|
}
|
|
|
|
|
if (iface) {
|
|
|
|
|
netdev_close(iface->netdev);
|
|
|
|
|
iface->netdev = NULL;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
2011-05-09 09:24:39 -07:00
|
|
|
|
iface_set_ofp_port(struct iface *iface, int ofp_port)
|
2011-04-08 13:50:21 -07:00
|
|
|
|
{
|
|
|
|
|
struct bridge *br = iface->port->bridge;
|
|
|
|
|
|
2011-05-09 09:24:39 -07:00
|
|
|
|
assert(iface->ofp_port < 0 && ofp_port >= 0);
|
|
|
|
|
iface->ofp_port = ofp_port;
|
|
|
|
|
hmap_insert(&br->ifaces, &iface->ofp_port_node, hash_int(ofp_port, 0));
|
2011-05-18 09:16:00 -07:00
|
|
|
|
iface_set_ofport(iface->cfg, ofp_port);
|
2011-04-08 13:50:21 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
2011-05-09 09:24:39 -07:00
|
|
|
|
bridge_refresh_ofp_port(struct bridge *br)
|
2011-04-08 13:50:21 -07:00
|
|
|
|
{
|
|
|
|
|
struct ofproto_port_dump dump;
|
|
|
|
|
struct ofproto_port ofproto_port;
|
|
|
|
|
struct port *port;
|
|
|
|
|
|
2011-05-09 09:24:39 -07:00
|
|
|
|
/* Clear all the "ofp_port"es. */
|
2011-04-08 13:50:21 -07:00
|
|
|
|
hmap_clear(&br->ifaces);
|
|
|
|
|
HMAP_FOR_EACH (port, hmap_node, &br->ports) {
|
|
|
|
|
struct iface *iface;
|
|
|
|
|
|
|
|
|
|
LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
|
2011-05-09 09:24:39 -07:00
|
|
|
|
iface->ofp_port = -1;
|
2011-04-08 13:50:21 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2011-05-09 09:24:39 -07:00
|
|
|
|
/* Obtain the correct "ofp_port"s from ofproto. */
|
2011-04-08 13:50:21 -07:00
|
|
|
|
OFPROTO_PORT_FOR_EACH (&ofproto_port, &dump, br->ofproto) {
|
|
|
|
|
struct iface *iface = iface_lookup(br, ofproto_port.name);
|
|
|
|
|
if (iface) {
|
2011-05-09 09:24:39 -07:00
|
|
|
|
if (iface->ofp_port >= 0) {
|
2011-04-08 13:50:21 -07:00
|
|
|
|
VLOG_WARN("bridge %s: interface %s reported twice",
|
|
|
|
|
br->name, ofproto_port.name);
|
2011-05-09 09:24:39 -07:00
|
|
|
|
} else if (iface_from_ofp_port(br, ofproto_port.ofp_port)) {
|
2011-04-08 13:50:21 -07:00
|
|
|
|
VLOG_WARN("bridge %s: interface %"PRIu16" reported twice",
|
2011-05-09 09:24:39 -07:00
|
|
|
|
br->name, ofproto_port.ofp_port);
|
2011-04-08 13:50:21 -07:00
|
|
|
|
} else {
|
2011-05-09 09:24:39 -07:00
|
|
|
|
iface_set_ofp_port(iface, ofproto_port.ofp_port);
|
2011-04-08 13:50:21 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2011-05-09 09:33:02 -07:00
|
|
|
|
/* Add an ofproto port for any "struct iface" that doesn't have one.
|
2011-04-08 13:50:21 -07:00
|
|
|
|
* Delete any "struct iface" for which this fails.
|
|
|
|
|
* Delete any "struct port" that thereby ends up with no ifaces. */
|
|
|
|
|
static void
|
|
|
|
|
bridge_add_ofproto_ports(struct bridge *br)
|
|
|
|
|
{
|
|
|
|
|
struct port *port, *next_port;
|
|
|
|
|
|
|
|
|
|
HMAP_FOR_EACH_SAFE (port, next_port, hmap_node, &br->ports) {
|
|
|
|
|
struct iface *iface, *next_iface;
|
2011-05-09 09:24:39 -07:00
|
|
|
|
struct ofproto_port ofproto_port;
|
2011-04-08 13:50:21 -07:00
|
|
|
|
|
|
|
|
|
LIST_FOR_EACH_SAFE (iface, next_iface, port_elem, &port->ifaces) {
|
|
|
|
|
int error;
|
|
|
|
|
|
netdev: Decouple creating and configuring network devices.
Until now, each call to netdev_open() for a particular network device
had to either specify a set of network device arguments that was either
empty or (for devices that already existed) equal to the existing device's
configuration. Unfortunately, the definition of "equality" in the latter
case was mostly done in terms of strict equality of string-to-string maps,
which caused problems in cases where, for example, one set of arguments
specified the default value of an optional argument explicitly and the
other omitted it.
The netdev interface does have provisions for defining equality other ways,
but this had only been done in one case that was especially problematic in
practice. One way to solve this particular problem would be to carefully
define equality in all the problematic cases.
This commit takes another approach based on the realization that there is
really no need to do any comparisons. Instead, it removes configuration
at netdev_open() time entirely, because almost all of netdev_open()'s
callers are not interested in creating and configuring a netdev. Most of
them just want to open a configured device and use it. Therefore, this
commit stops providing any configuration arguments to netdev_open() and the
provider functions that it calls. Instead, a caller that does want to
configure a device does so after it opens it, by calling
netdev_set_config().
This change allows us to simplify the netdev interface a bit. There is no
longer any need to implement argument comparisons. As a result, there is
also no need for "struct netdev_dev" to keep track of configuration at all.
Instead, the network devices that have configuration keep track of it in
their own internal form.
This new interface does mean that it becomes possible to accidentally
create and try to use an unconfigured netdev that requires configuration.
Bug #6677.
Reported-by: Paul Ingram <paul@nicira.com>
2011-08-08 12:49:17 -07:00
|
|
|
|
/* Open the netdev. */
|
2011-04-08 13:50:21 -07:00
|
|
|
|
if (!iface->netdev) {
|
2011-08-05 14:18:06 -07:00
|
|
|
|
error = netdev_open(iface->name, iface->type, &iface->netdev);
|
netdev: Decouple creating and configuring network devices.
Until now, each call to netdev_open() for a particular network device
had to either specify a set of network device arguments that was either
empty or (for devices that already existed) equal to the existing device's
configuration. Unfortunately, the definition of "equality" in the latter
case was mostly done in terms of strict equality of string-to-string maps,
which caused problems in cases where, for example, one set of arguments
specified the default value of an optional argument explicitly and the
other omitted it.
The netdev interface does have provisions for defining equality other ways,
but this had only been done in one case that was especially problematic in
practice. One way to solve this particular problem would be to carefully
define equality in all the problematic cases.
This commit takes another approach based on the realization that there is
really no need to do any comparisons. Instead, it removes configuration
at netdev_open() time entirely, because almost all of netdev_open()'s
callers are not interested in creating and configuring a netdev. Most of
them just want to open a configured device and use it. Therefore, this
commit stops providing any configuration arguments to netdev_open() and the
provider functions that it calls. Instead, a caller that does want to
configure a device does so after it opens it, by calling
netdev_set_config().
This change allows us to simplify the netdev interface a bit. There is no
longer any need to implement argument comparisons. As a result, there is
also no need for "struct netdev_dev" to keep track of configuration at all.
Instead, the network devices that have configuration keep track of it in
their own internal form.
This new interface does mean that it becomes possible to accidentally
create and try to use an unconfigured netdev that requires configuration.
Bug #6677.
Reported-by: Paul Ingram <paul@nicira.com>
2011-08-08 12:49:17 -07:00
|
|
|
|
if (error) {
|
|
|
|
|
VLOG_WARN("could not open network device %s (%s)",
|
|
|
|
|
iface->name, strerror(error));
|
|
|
|
|
}
|
2011-11-23 17:03:31 -08:00
|
|
|
|
|
|
|
|
|
if (iface->netdev
|
|
|
|
|
&& port->cfg->vlan_mode
|
|
|
|
|
&& !strcmp(port->cfg->vlan_mode, "splinter")) {
|
|
|
|
|
netdev_turn_flags_on(iface->netdev, NETDEV_UP, true);
|
|
|
|
|
}
|
2011-04-08 13:50:21 -07:00
|
|
|
|
} else {
|
netdev: Decouple creating and configuring network devices.
Until now, each call to netdev_open() for a particular network device
had to either specify a set of network device arguments that was either
empty or (for devices that already existed) equal to the existing device's
configuration. Unfortunately, the definition of "equality" in the latter
case was mostly done in terms of strict equality of string-to-string maps,
which caused problems in cases where, for example, one set of arguments
specified the default value of an optional argument explicitly and the
other omitted it.
The netdev interface does have provisions for defining equality other ways,
but this had only been done in one case that was especially problematic in
practice. One way to solve this particular problem would be to carefully
define equality in all the problematic cases.
This commit takes another approach based on the realization that there is
really no need to do any comparisons. Instead, it removes configuration
at netdev_open() time entirely, because almost all of netdev_open()'s
callers are not interested in creating and configuring a netdev. Most of
them just want to open a configured device and use it. Therefore, this
commit stops providing any configuration arguments to netdev_open() and the
provider functions that it calls. Instead, a caller that does want to
configure a device does so after it opens it, by calling
netdev_set_config().
This change allows us to simplify the netdev interface a bit. There is no
longer any need to implement argument comparisons. As a result, there is
also no need for "struct netdev_dev" to keep track of configuration at all.
Instead, the network devices that have configuration keep track of it in
their own internal form.
This new interface does mean that it becomes possible to accidentally
create and try to use an unconfigured netdev that requires configuration.
Bug #6677.
Reported-by: Paul Ingram <paul@nicira.com>
2011-08-08 12:49:17 -07:00
|
|
|
|
error = 0;
|
2011-04-08 13:50:21 -07:00
|
|
|
|
}
|
netdev: Decouple creating and configuring network devices.
Until now, each call to netdev_open() for a particular network device
had to either specify a set of network device arguments that was either
empty or (for devices that already existed) equal to the existing device's
configuration. Unfortunately, the definition of "equality" in the latter
case was mostly done in terms of strict equality of string-to-string maps,
which caused problems in cases where, for example, one set of arguments
specified the default value of an optional argument explicitly and the
other omitted it.
The netdev interface does have provisions for defining equality other ways,
but this had only been done in one case that was especially problematic in
practice. One way to solve this particular problem would be to carefully
define equality in all the problematic cases.
This commit takes another approach based on the realization that there is
really no need to do any comparisons. Instead, it removes configuration
at netdev_open() time entirely, because almost all of netdev_open()'s
callers are not interested in creating and configuring a netdev. Most of
them just want to open a configured device and use it. Therefore, this
commit stops providing any configuration arguments to netdev_open() and the
provider functions that it calls. Instead, a caller that does want to
configure a device does so after it opens it, by calling
netdev_set_config().
This change allows us to simplify the netdev interface a bit. There is no
longer any need to implement argument comparisons. As a result, there is
also no need for "struct netdev_dev" to keep track of configuration at all.
Instead, the network devices that have configuration keep track of it in
their own internal form.
This new interface does mean that it becomes possible to accidentally
create and try to use an unconfigured netdev that requires configuration.
Bug #6677.
Reported-by: Paul Ingram <paul@nicira.com>
2011-08-08 12:49:17 -07:00
|
|
|
|
|
|
|
|
|
/* Configure the netdev. */
|
|
|
|
|
if (iface->netdev) {
|
|
|
|
|
struct shash args;
|
|
|
|
|
|
|
|
|
|
shash_init(&args);
|
|
|
|
|
shash_from_ovs_idl_map(iface->cfg->key_options,
|
|
|
|
|
iface->cfg->value_options,
|
|
|
|
|
iface->cfg->n_options, &args);
|
|
|
|
|
error = netdev_set_config(iface->netdev, &args);
|
|
|
|
|
shash_destroy(&args);
|
|
|
|
|
|
|
|
|
|
if (error) {
|
|
|
|
|
VLOG_WARN("could not configure network device %s (%s)",
|
|
|
|
|
iface->name, strerror(error));
|
|
|
|
|
netdev_close(iface->netdev);
|
|
|
|
|
iface->netdev = NULL;
|
|
|
|
|
}
|
2011-04-08 13:50:21 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Add the port, if necessary. */
|
2011-05-09 09:24:39 -07:00
|
|
|
|
if (iface->netdev && iface->ofp_port < 0) {
|
2011-04-08 13:50:21 -07:00
|
|
|
|
uint16_t ofp_port;
|
|
|
|
|
int error;
|
|
|
|
|
|
|
|
|
|
error = ofproto_port_add(br->ofproto, iface->netdev,
|
|
|
|
|
&ofp_port);
|
|
|
|
|
if (!error) {
|
2011-05-09 09:24:39 -07:00
|
|
|
|
iface_set_ofp_port(iface, ofp_port);
|
2011-04-08 13:50:21 -07:00
|
|
|
|
} else {
|
|
|
|
|
netdev_close(iface->netdev);
|
|
|
|
|
iface->netdev = NULL;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2011-08-05 14:14:18 -07:00
|
|
|
|
/* Populate stats columns in new Interface rows. */
|
|
|
|
|
if (iface->netdev && !iface->cfg->mtu) {
|
|
|
|
|
iface_refresh_stats(iface);
|
|
|
|
|
iface_refresh_status(iface);
|
|
|
|
|
}
|
|
|
|
|
|
netdev: Decouple creating and configuring network devices.
Until now, each call to netdev_open() for a particular network device
had to either specify a set of network device arguments that was either
empty or (for devices that already existed) equal to the existing device's
configuration. Unfortunately, the definition of "equality" in the latter
case was mostly done in terms of strict equality of string-to-string maps,
which caused problems in cases where, for example, one set of arguments
specified the default value of an optional argument explicitly and the
other omitted it.
The netdev interface does have provisions for defining equality other ways,
but this had only been done in one case that was especially problematic in
practice. One way to solve this particular problem would be to carefully
define equality in all the problematic cases.
This commit takes another approach based on the realization that there is
really no need to do any comparisons. Instead, it removes configuration
at netdev_open() time entirely, because almost all of netdev_open()'s
callers are not interested in creating and configuring a netdev. Most of
them just want to open a configured device and use it. Therefore, this
commit stops providing any configuration arguments to netdev_open() and the
provider functions that it calls. Instead, a caller that does want to
configure a device does so after it opens it, by calling
netdev_set_config().
This change allows us to simplify the netdev interface a bit. There is no
longer any need to implement argument comparisons. As a result, there is
also no need for "struct netdev_dev" to keep track of configuration at all.
Instead, the network devices that have configuration keep track of it in
their own internal form.
This new interface does mean that it becomes possible to accidentally
create and try to use an unconfigured netdev that requires configuration.
Bug #6677.
Reported-by: Paul Ingram <paul@nicira.com>
2011-08-08 12:49:17 -07:00
|
|
|
|
/* Delete the iface if we failed. */
|
2011-05-09 09:24:39 -07:00
|
|
|
|
if (iface->netdev && iface->ofp_port >= 0) {
|
2011-04-08 13:50:21 -07:00
|
|
|
|
VLOG_DBG("bridge %s: interface %s is on port %d",
|
2011-05-09 09:24:39 -07:00
|
|
|
|
br->name, iface->name, iface->ofp_port);
|
2011-04-08 13:50:21 -07:00
|
|
|
|
} else {
|
|
|
|
|
if (iface->netdev) {
|
|
|
|
|
VLOG_ERR("bridge %s: missing %s interface, dropping",
|
|
|
|
|
br->name, iface->name);
|
|
|
|
|
} else {
|
|
|
|
|
/* We already reported a related error, don't bother
|
|
|
|
|
* duplicating it. */
|
|
|
|
|
}
|
2011-09-28 09:36:13 -07:00
|
|
|
|
iface_clear_db_record(iface->cfg);
|
2011-04-08 13:50:21 -07:00
|
|
|
|
iface_destroy(iface);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
if (list_is_empty(&port->ifaces)) {
|
|
|
|
|
VLOG_WARN("%s port has no interfaces, dropping", port->name);
|
|
|
|
|
port_destroy(port);
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Add bond fake iface if necessary. */
|
|
|
|
|
if (port_is_bond_fake_iface(port)) {
|
|
|
|
|
if (ofproto_port_query_by_name(br->ofproto, port->name,
|
|
|
|
|
&ofproto_port)) {
|
|
|
|
|
struct netdev *netdev;
|
|
|
|
|
int error;
|
|
|
|
|
|
2011-08-05 14:18:06 -07:00
|
|
|
|
error = netdev_open(port->name, "internal", &netdev);
|
2011-04-08 13:50:21 -07:00
|
|
|
|
if (!error) {
|
|
|
|
|
ofproto_port_add(br->ofproto, netdev, NULL);
|
|
|
|
|
netdev_close(netdev);
|
|
|
|
|
} else {
|
|
|
|
|
VLOG_WARN("could not open network device %s (%s)",
|
|
|
|
|
port->name, strerror(error));
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
/* Already exists, nothing to do. */
|
|
|
|
|
ofproto_port_destroy(&ofproto_port);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2009-12-11 17:03:35 -08:00
|
|
|
|
static const char *
|
2011-11-23 13:17:38 -08:00
|
|
|
|
get_ovsrec_key_value(char **keys, char **values, size_t n, const char *key)
|
2009-12-11 17:03:35 -08:00
|
|
|
|
{
|
2011-11-23 13:17:38 -08:00
|
|
|
|
size_t i;
|
|
|
|
|
|
|
|
|
|
for (i = 0; i < n; i++) {
|
|
|
|
|
if (!strcmp(keys[i], key)) {
|
|
|
|
|
return values[i];
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
return NULL;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2010-04-05 14:21:38 -07:00
|
|
|
|
static const char *
|
|
|
|
|
bridge_get_other_config(const struct ovsrec_bridge *br_cfg, const char *key)
|
|
|
|
|
{
|
2011-11-23 13:17:38 -08:00
|
|
|
|
return get_ovsrec_key_value(br_cfg->key_other_config,
|
|
|
|
|
br_cfg->value_other_config,
|
|
|
|
|
br_cfg->n_other_config, key);
|
2010-04-05 14:21:38 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-07-28 16:38:50 -07:00
|
|
|
|
/* Set Flow eviction threshold */
|
|
|
|
|
static void
|
|
|
|
|
bridge_configure_flow_eviction_threshold(struct bridge *br)
|
|
|
|
|
{
|
|
|
|
|
const char *threshold_str;
|
|
|
|
|
unsigned threshold;
|
|
|
|
|
|
|
|
|
|
threshold_str = bridge_get_other_config(br->cfg, "flow-eviction-threshold");
|
|
|
|
|
if (threshold_str) {
|
|
|
|
|
threshold = strtoul(threshold_str, NULL, 10);
|
|
|
|
|
} else {
|
|
|
|
|
threshold = OFPROTO_FLOW_EVICTON_THRESHOLD_DEFAULT;
|
|
|
|
|
}
|
|
|
|
|
ofproto_set_flow_eviction_threshold(br->ofproto, threshold);
|
|
|
|
|
}
|
|
|
|
|
|
Option to forward BPDU (Ethernet control class) frames
Currently, a NORMAL action bridge drops reserved-multicast-mac addresses;
01-80-c2-00-00-[f0:ff]. A node that does not implement STP should have an
option to forward such frames.
This commit proposes to have a configuration option to allow forwarding of
BPDU class frames. To ensure backward compatibility, this option is
disabled by default.
This config can be set using bridge's other-config column, for e.g
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
Changing this option can revalidate all flows in a software-OVS
implementation (ofproto-dpif)
--------
unit tests:
------------
make config changes, test runtime behavior
-- test runtime behavior --
continuously send packets to br0 with dest-mac=01:80:c2:00:00:00
ovs-dpctl dump-flows br0
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
ovs-dpctl dump-flows br0
ovs-vsctl set bridge br0 other-config:forward-bpdu=false
ovs-dpctl dump-flows br0
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
ovs-dpctl dump-flows br0
ovs-vsctl remove bridge br0 other-config forward-bpdu=true
ovs-dpctl dump-flows br0
--result--
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:29550, bytes:1773000, used:0.004s, actions:drop
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:8209, bytes:492540, used:0.000s, actions:2,0
ovs-vsctl set bridge br0 other-config:forward-bpdu=false
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:19, bytes:1140, used:0.000s, actions:drop
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:29, bytes:1740, used:0.000s, actions:2,0
ovs-vsctl remove bridge br0 other-config forward-bpdu=true
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:0, bytes:0, used:never, actions:drop
Bug #6624
Reported-by: Niklas Andersson <nandersson@nicira.com>
2011-08-09 11:08:27 -07:00
|
|
|
|
/* Set forward BPDU option. */
|
|
|
|
|
static void
|
|
|
|
|
bridge_configure_forward_bpdu(struct bridge *br)
|
|
|
|
|
{
|
|
|
|
|
const char *forward_bpdu_str;
|
|
|
|
|
bool forward_bpdu = false;
|
|
|
|
|
|
|
|
|
|
forward_bpdu_str = bridge_get_other_config(br->cfg, "forward-bpdu");
|
|
|
|
|
if (forward_bpdu_str && !strcmp(forward_bpdu_str, "true")) {
|
|
|
|
|
forward_bpdu = true;
|
|
|
|
|
}
|
|
|
|
|
ofproto_set_forward_bpdu(br->ofproto, forward_bpdu);
|
|
|
|
|
}
|
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static void
|
|
|
|
|
bridge_pick_local_hw_addr(struct bridge *br, uint8_t ea[ETH_ADDR_LEN],
|
2009-07-23 14:50:55 -07:00
|
|
|
|
struct iface **hw_addr_iface)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2011-11-30 12:09:35 -08:00
|
|
|
|
struct hmapx mirror_output_ports;
|
2009-12-11 17:03:35 -08:00
|
|
|
|
const char *hwaddr;
|
2011-03-21 10:07:39 -07:00
|
|
|
|
struct port *port;
|
2011-08-26 15:05:53 -07:00
|
|
|
|
bool found_addr = false;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
int error;
|
2011-11-30 12:09:35 -08:00
|
|
|
|
int i;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2009-07-23 14:50:55 -07:00
|
|
|
|
*hw_addr_iface = NULL;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
|
|
|
|
/* Did the user request a particular MAC? */
|
2009-12-11 17:03:35 -08:00
|
|
|
|
hwaddr = bridge_get_other_config(br->cfg, "hwaddr");
|
|
|
|
|
if (hwaddr && eth_addr_from_string(hwaddr, ea)) {
|
2009-07-08 13:19:16 -07:00
|
|
|
|
if (eth_addr_is_multicast(ea)) {
|
|
|
|
|
VLOG_ERR("bridge %s: cannot set MAC address to multicast "
|
|
|
|
|
"address "ETH_ADDR_FMT, br->name, ETH_ADDR_ARGS(ea));
|
|
|
|
|
} else if (eth_addr_is_zero(ea)) {
|
|
|
|
|
VLOG_ERR("bridge %s: cannot set MAC address to zero", br->name);
|
|
|
|
|
} else {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2011-11-30 12:09:35 -08:00
|
|
|
|
/* Mirror output ports don't participate in picking the local hardware
|
|
|
|
|
* address. ofproto can't help us find out whether a given port is a
|
|
|
|
|
* mirror output because we haven't configured mirrors yet, so we need to
|
|
|
|
|
* accumulate them ourselves. */
|
|
|
|
|
hmapx_init(&mirror_output_ports);
|
|
|
|
|
for (i = 0; i < br->cfg->n_mirrors; i++) {
|
|
|
|
|
struct ovsrec_mirror *m = br->cfg->mirrors[i];
|
|
|
|
|
if (m->output_port) {
|
|
|
|
|
hmapx_add(&mirror_output_ports, m->output_port);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2009-12-14 13:09:47 -08:00
|
|
|
|
/* Otherwise choose the minimum non-local MAC address among all of the
|
|
|
|
|
* interfaces. */
|
2011-03-21 10:07:39 -07:00
|
|
|
|
HMAP_FOR_EACH (port, hmap_node, &br->ports) {
|
2009-07-22 12:21:25 -07:00
|
|
|
|
uint8_t iface_ea[ETH_ADDR_LEN];
|
2011-03-21 10:24:32 -07:00
|
|
|
|
struct iface *candidate;
|
2009-07-22 12:21:25 -07:00
|
|
|
|
struct iface *iface;
|
|
|
|
|
|
|
|
|
|
/* Mirror output ports don't participate. */
|
2011-11-30 12:09:35 -08:00
|
|
|
|
if (hmapx_contains(&mirror_output_ports, port->cfg)) {
|
2009-07-08 13:19:16 -07:00
|
|
|
|
continue;
|
|
|
|
|
}
|
2009-07-22 12:21:25 -07:00
|
|
|
|
|
|
|
|
|
/* Choose the MAC address to represent the port. */
|
2011-03-21 10:24:32 -07:00
|
|
|
|
iface = NULL;
|
2009-12-03 11:28:40 -08:00
|
|
|
|
if (port->cfg->mac && eth_addr_from_string(port->cfg->mac, iface_ea)) {
|
2009-08-05 14:50:54 -07:00
|
|
|
|
/* Find the interface with this Ethernet address (if any) so that
|
|
|
|
|
* we can provide the correct devname to the caller. */
|
2011-03-21 10:24:32 -07:00
|
|
|
|
LIST_FOR_EACH (candidate, port_elem, &port->ifaces) {
|
2009-08-05 14:50:54 -07:00
|
|
|
|
uint8_t candidate_ea[ETH_ADDR_LEN];
|
2009-08-19 13:03:46 -07:00
|
|
|
|
if (!netdev_get_etheraddr(candidate->netdev, candidate_ea)
|
2009-08-05 14:50:54 -07:00
|
|
|
|
&& eth_addr_equals(iface_ea, candidate_ea)) {
|
|
|
|
|
iface = candidate;
|
|
|
|
|
}
|
|
|
|
|
}
|
2009-07-22 12:21:25 -07:00
|
|
|
|
} else {
|
|
|
|
|
/* Choose the interface whose MAC address will represent the port.
|
|
|
|
|
* The Linux kernel bonding code always chooses the MAC address of
|
|
|
|
|
* the first slave added to a bond, and the Fedora networking
|
|
|
|
|
* scripts always add slaves to a bond in alphabetical order, so
|
|
|
|
|
* for compatibility we choose the interface with the name that is
|
|
|
|
|
* first in alphabetical order. */
|
2011-03-21 10:24:32 -07:00
|
|
|
|
LIST_FOR_EACH (candidate, port_elem, &port->ifaces) {
|
|
|
|
|
if (!iface || strcmp(candidate->name, iface->name) < 0) {
|
2009-07-22 12:21:25 -07:00
|
|
|
|
iface = candidate;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* The local port doesn't count (since we're trying to choose its
|
2009-12-14 13:09:47 -08:00
|
|
|
|
* MAC address anyway). */
|
2011-05-09 09:24:39 -07:00
|
|
|
|
if (iface->ofp_port == OFPP_LOCAL) {
|
2009-07-08 13:19:16 -07:00
|
|
|
|
continue;
|
|
|
|
|
}
|
2009-07-22 12:21:25 -07:00
|
|
|
|
|
|
|
|
|
/* Grab MAC. */
|
2009-07-23 14:50:55 -07:00
|
|
|
|
error = netdev_get_etheraddr(iface->netdev, iface_ea);
|
2009-07-22 12:21:25 -07:00
|
|
|
|
if (error) {
|
|
|
|
|
continue;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
2009-07-22 12:21:25 -07:00
|
|
|
|
|
|
|
|
|
/* Compare against our current choice. */
|
|
|
|
|
if (!eth_addr_is_multicast(iface_ea) &&
|
2009-12-14 13:09:47 -08:00
|
|
|
|
!eth_addr_is_local(iface_ea) &&
|
2009-07-22 12:21:25 -07:00
|
|
|
|
!eth_addr_is_reserved(iface_ea) &&
|
|
|
|
|
!eth_addr_is_zero(iface_ea) &&
|
2011-09-09 10:12:32 -07:00
|
|
|
|
(!found_addr || eth_addr_compare_3way(iface_ea, ea) < 0))
|
2009-07-22 12:21:25 -07:00
|
|
|
|
{
|
2009-08-26 12:51:39 -07:00
|
|
|
|
memcpy(ea, iface_ea, ETH_ADDR_LEN);
|
2009-08-19 13:03:46 -07:00
|
|
|
|
*hw_addr_iface = iface;
|
2011-08-26 15:05:53 -07:00
|
|
|
|
found_addr = true;
|
2009-07-22 12:21:25 -07:00
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2011-08-26 15:05:53 -07:00
|
|
|
|
if (found_addr) {
|
|
|
|
|
VLOG_DBG("bridge %s: using bridge Ethernet address "ETH_ADDR_FMT,
|
|
|
|
|
br->name, ETH_ADDR_ARGS(ea));
|
|
|
|
|
} else {
|
2009-07-08 13:19:16 -07:00
|
|
|
|
memcpy(ea, br->default_ea, ETH_ADDR_LEN);
|
2009-07-23 14:50:55 -07:00
|
|
|
|
*hw_addr_iface = NULL;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
VLOG_WARN("bridge %s: using default bridge Ethernet "
|
|
|
|
|
"address "ETH_ADDR_FMT, br->name, ETH_ADDR_ARGS(ea));
|
|
|
|
|
}
|
2011-11-30 12:09:35 -08:00
|
|
|
|
|
|
|
|
|
hmapx_destroy(&mirror_output_ports);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Choose and returns the datapath ID for bridge 'br' given that the bridge
|
|
|
|
|
* Ethernet address is 'bridge_ea'. If 'bridge_ea' is the Ethernet address of
|
2009-07-23 14:50:55 -07:00
|
|
|
|
* an interface on 'br', then that interface must be passed in as
|
|
|
|
|
* 'hw_addr_iface'; if 'bridge_ea' was derived some other way, then
|
|
|
|
|
* 'hw_addr_iface' must be passed in as a null pointer. */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static uint64_t
|
|
|
|
|
bridge_pick_datapath_id(struct bridge *br,
|
|
|
|
|
const uint8_t bridge_ea[ETH_ADDR_LEN],
|
2009-07-23 14:50:55 -07:00
|
|
|
|
struct iface *hw_addr_iface)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
|
|
|
|
/*
|
|
|
|
|
* The procedure for choosing a bridge MAC address will, in the most
|
|
|
|
|
* ordinary case, also choose a unique MAC that we can use as a datapath
|
|
|
|
|
* ID. In some special cases, though, multiple bridges will end up with
|
|
|
|
|
* the same MAC address. This is OK for the bridges, but it will confuse
|
|
|
|
|
* the OpenFlow controller, because each datapath needs a unique datapath
|
|
|
|
|
* ID.
|
|
|
|
|
*
|
|
|
|
|
* Datapath IDs must be unique. It is also very desirable that they be
|
|
|
|
|
* stable from one run to the next, so that policy set on a datapath
|
|
|
|
|
* "sticks".
|
|
|
|
|
*/
|
2009-12-11 17:03:35 -08:00
|
|
|
|
const char *datapath_id;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
uint64_t dpid;
|
|
|
|
|
|
2009-12-11 17:03:35 -08:00
|
|
|
|
datapath_id = bridge_get_other_config(br->cfg, "datapath-id");
|
|
|
|
|
if (datapath_id && dpid_from_string(datapath_id, &dpid)) {
|
2009-07-08 13:19:16 -07:00
|
|
|
|
return dpid;
|
|
|
|
|
}
|
|
|
|
|
|
2011-11-08 13:53:38 -08:00
|
|
|
|
if (!hw_addr_iface) {
|
2009-07-08 13:19:16 -07:00
|
|
|
|
/*
|
|
|
|
|
* A purely internal bridge, that is, one that has no non-virtual
|
2011-11-08 13:53:38 -08:00
|
|
|
|
* network devices on it at all, is difficult because it has no
|
2009-07-08 13:19:16 -07:00
|
|
|
|
* natural unique identifier at all.
|
|
|
|
|
*
|
|
|
|
|
* When the host is a XenServer, we handle this case by hashing the
|
|
|
|
|
* host's UUID with the name of the bridge. Names of bridges are
|
|
|
|
|
* persistent across XenServer reboots, although they can be reused if
|
|
|
|
|
* an internal network is destroyed and then a new one is later
|
|
|
|
|
* created, so this is fairly effective.
|
|
|
|
|
*
|
|
|
|
|
* When the host is not a XenServer, we punt by using a random MAC
|
|
|
|
|
* address on each run.
|
|
|
|
|
*/
|
|
|
|
|
const char *host_uuid = xenserver_get_host_uuid();
|
|
|
|
|
if (host_uuid) {
|
|
|
|
|
char *combined = xasprintf("%s,%s", host_uuid, br->name);
|
|
|
|
|
dpid = dpid_from_hash(combined, strlen(combined));
|
|
|
|
|
free(combined);
|
|
|
|
|
return dpid;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return eth_addr_to_uint64(bridge_ea);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static uint64_t
|
|
|
|
|
dpid_from_hash(const void *data, size_t n)
|
|
|
|
|
{
|
2009-06-15 16:03:28 -07:00
|
|
|
|
uint8_t hash[SHA1_DIGEST_SIZE];
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
|
|
|
|
BUILD_ASSERT_DECL(sizeof hash >= ETH_ADDR_LEN);
|
2009-06-15 16:03:28 -07:00
|
|
|
|
sha1_bytes(data, n, hash);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
eth_addr_mark_random(hash);
|
|
|
|
|
return eth_addr_to_uint64(hash);
|
|
|
|
|
}
|
|
|
|
|
|
2010-12-21 16:26:21 -08:00
|
|
|
|
static void
|
2011-01-05 11:51:15 -08:00
|
|
|
|
iface_refresh_status(struct iface *iface)
|
2010-12-21 16:26:21 -08:00
|
|
|
|
{
|
2011-01-05 11:51:15 -08:00
|
|
|
|
struct shash sh;
|
|
|
|
|
|
2011-01-17 15:37:13 -08:00
|
|
|
|
enum netdev_flags flags;
|
|
|
|
|
uint32_t current;
|
|
|
|
|
int64_t bps;
|
|
|
|
|
int mtu;
|
|
|
|
|
int64_t mtu_64;
|
|
|
|
|
int error;
|
|
|
|
|
|
2011-04-13 11:10:44 -07:00
|
|
|
|
if (iface_is_synthetic(iface)) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2011-01-05 11:51:15 -08:00
|
|
|
|
shash_init(&sh);
|
|
|
|
|
|
|
|
|
|
if (!netdev_get_status(iface->netdev, &sh)) {
|
|
|
|
|
size_t n;
|
|
|
|
|
char **keys, **values;
|
2010-12-21 16:26:21 -08:00
|
|
|
|
|
2011-01-05 11:51:15 -08:00
|
|
|
|
shash_to_ovs_idl_map(&sh, &keys, &values, &n);
|
|
|
|
|
ovsrec_interface_set_status(iface->cfg, keys, values, n);
|
|
|
|
|
|
|
|
|
|
free(keys);
|
|
|
|
|
free(values);
|
|
|
|
|
} else {
|
|
|
|
|
ovsrec_interface_set_status(iface->cfg, NULL, NULL, 0);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
shash_destroy_free_data(&sh);
|
2011-01-17 15:37:13 -08:00
|
|
|
|
|
|
|
|
|
error = netdev_get_flags(iface->netdev, &flags);
|
|
|
|
|
if (!error) {
|
|
|
|
|
ovsrec_interface_set_admin_state(iface->cfg, flags & NETDEV_UP ? "up" : "down");
|
|
|
|
|
}
|
|
|
|
|
else {
|
|
|
|
|
ovsrec_interface_set_admin_state(iface->cfg, NULL);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
error = netdev_get_features(iface->netdev, ¤t, NULL, NULL, NULL);
|
|
|
|
|
if (!error) {
|
|
|
|
|
ovsrec_interface_set_duplex(iface->cfg,
|
|
|
|
|
netdev_features_is_full_duplex(current)
|
|
|
|
|
? "full" : "half");
|
|
|
|
|
/* warning: uint64_t -> int64_t conversion */
|
|
|
|
|
bps = netdev_features_to_bps(current);
|
|
|
|
|
ovsrec_interface_set_link_speed(iface->cfg, &bps, 1);
|
|
|
|
|
}
|
|
|
|
|
else {
|
|
|
|
|
ovsrec_interface_set_duplex(iface->cfg, NULL);
|
|
|
|
|
ovsrec_interface_set_link_speed(iface->cfg, NULL, 0);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
error = netdev_get_mtu(iface->netdev, &mtu);
|
2011-09-12 17:12:52 -07:00
|
|
|
|
if (!error) {
|
2011-01-17 15:37:13 -08:00
|
|
|
|
mtu_64 = mtu;
|
|
|
|
|
ovsrec_interface_set_mtu(iface->cfg, &mtu_64, 1);
|
|
|
|
|
}
|
|
|
|
|
else {
|
|
|
|
|
ovsrec_interface_set_mtu(iface->cfg, NULL, 0);
|
|
|
|
|
}
|
2010-12-21 16:26:21 -08:00
|
|
|
|
}
|
|
|
|
|
|
2011-10-04 18:20:34 -07:00
|
|
|
|
/* Writes 'iface''s CFM statistics to the database. */
|
2011-09-08 16:15:36 -07:00
|
|
|
|
static void
|
2010-11-15 16:20:01 -08:00
|
|
|
|
iface_refresh_cfm_stats(struct iface *iface)
|
|
|
|
|
{
|
2011-05-12 15:28:43 -07:00
|
|
|
|
const struct ovsrec_interface *cfg = iface->cfg;
|
2011-08-26 14:54:34 -07:00
|
|
|
|
int fault, error;
|
|
|
|
|
const uint64_t *rmps;
|
|
|
|
|
size_t n_rmps;
|
2010-11-15 16:20:01 -08:00
|
|
|
|
|
2011-09-12 22:39:01 -07:00
|
|
|
|
if (iface_is_synthetic(iface)) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2011-05-13 15:37:23 -07:00
|
|
|
|
fault = ofproto_port_get_cfm_fault(iface->port->bridge->ofproto,
|
|
|
|
|
iface->ofp_port);
|
2011-09-08 16:15:36 -07:00
|
|
|
|
if (fault >= 0) {
|
2011-05-13 15:37:23 -07:00
|
|
|
|
bool fault_bool = fault;
|
|
|
|
|
ovsrec_interface_set_cfm_fault(cfg, &fault_bool, 1);
|
2011-09-06 17:13:24 -07:00
|
|
|
|
} else {
|
|
|
|
|
ovsrec_interface_set_cfm_fault(cfg, NULL, 0);
|
2011-03-25 13:36:43 -07:00
|
|
|
|
}
|
2011-08-26 14:54:34 -07:00
|
|
|
|
|
|
|
|
|
error = ofproto_port_get_cfm_remote_mpids(iface->port->bridge->ofproto,
|
|
|
|
|
iface->ofp_port, &rmps, &n_rmps);
|
|
|
|
|
if (error >= 0) {
|
|
|
|
|
ovsrec_interface_set_cfm_remote_mpids(cfg, (const int64_t *)rmps,
|
|
|
|
|
n_rmps);
|
|
|
|
|
} else {
|
|
|
|
|
ovsrec_interface_set_cfm_remote_mpids(cfg, NULL, 0);
|
|
|
|
|
}
|
2010-11-15 16:20:01 -08:00
|
|
|
|
}
|
|
|
|
|
|
2010-06-23 11:02:46 -07:00
|
|
|
|
static void
|
|
|
|
|
iface_refresh_stats(struct iface *iface)
|
|
|
|
|
{
|
2011-05-24 11:02:31 -07:00
|
|
|
|
#define IFACE_STATS \
|
|
|
|
|
IFACE_STAT(rx_packets, "rx_packets") \
|
|
|
|
|
IFACE_STAT(tx_packets, "tx_packets") \
|
|
|
|
|
IFACE_STAT(rx_bytes, "rx_bytes") \
|
|
|
|
|
IFACE_STAT(tx_bytes, "tx_bytes") \
|
|
|
|
|
IFACE_STAT(rx_dropped, "rx_dropped") \
|
|
|
|
|
IFACE_STAT(tx_dropped, "tx_dropped") \
|
|
|
|
|
IFACE_STAT(rx_errors, "rx_errors") \
|
|
|
|
|
IFACE_STAT(tx_errors, "tx_errors") \
|
|
|
|
|
IFACE_STAT(rx_frame_errors, "rx_frame_err") \
|
|
|
|
|
IFACE_STAT(rx_over_errors, "rx_over_err") \
|
|
|
|
|
IFACE_STAT(rx_crc_errors, "rx_crc_err") \
|
|
|
|
|
IFACE_STAT(collisions, "collisions")
|
|
|
|
|
|
|
|
|
|
#define IFACE_STAT(MEMBER, NAME) NAME,
|
|
|
|
|
static char *keys[] = { IFACE_STATS };
|
|
|
|
|
#undef IFACE_STAT
|
|
|
|
|
int64_t values[ARRAY_SIZE(keys)];
|
|
|
|
|
int i;
|
2010-06-23 11:02:46 -07:00
|
|
|
|
|
|
|
|
|
struct netdev_stats stats;
|
|
|
|
|
|
2011-04-13 11:10:44 -07:00
|
|
|
|
if (iface_is_synthetic(iface)) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2010-06-23 11:02:46 -07:00
|
|
|
|
/* Intentionally ignore return value, since errors will set 'stats' to
|
|
|
|
|
* all-1s, and we will deal with that correctly below. */
|
|
|
|
|
netdev_get_stats(iface->netdev, &stats);
|
|
|
|
|
|
2011-05-24 11:02:31 -07:00
|
|
|
|
/* Copy statistics into values[] array. */
|
|
|
|
|
i = 0;
|
|
|
|
|
#define IFACE_STAT(MEMBER, NAME) values[i++] = stats.MEMBER;
|
|
|
|
|
IFACE_STATS;
|
|
|
|
|
#undef IFACE_STAT
|
|
|
|
|
assert(i == ARRAY_SIZE(keys));
|
2010-06-23 11:02:46 -07:00
|
|
|
|
|
2011-05-24 11:02:31 -07:00
|
|
|
|
ovsrec_interface_set_statistics(iface->cfg, keys, values, ARRAY_SIZE(keys));
|
|
|
|
|
#undef IFACE_STATS
|
2010-06-23 11:02:46 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-10-14 09:48:17 -07:00
|
|
|
|
static void
|
|
|
|
|
br_refresh_stp_status(struct bridge *br)
|
|
|
|
|
{
|
|
|
|
|
struct ofproto *ofproto = br->ofproto;
|
|
|
|
|
struct ofproto_stp_status status;
|
|
|
|
|
char *keys[3], *values[3];
|
|
|
|
|
size_t i;
|
|
|
|
|
|
|
|
|
|
if (ofproto_get_stp_status(ofproto, &status)) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (!status.enabled) {
|
|
|
|
|
ovsrec_bridge_set_status(br->cfg, NULL, NULL, 0);
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
keys[0] = "stp_bridge_id",
|
|
|
|
|
values[0] = xasprintf(STP_ID_FMT, STP_ID_ARGS(status.bridge_id));
|
|
|
|
|
keys[1] = "stp_designated_root",
|
|
|
|
|
values[1] = xasprintf(STP_ID_FMT, STP_ID_ARGS(status.designated_root));
|
|
|
|
|
keys[2] = "stp_root_path_cost",
|
|
|
|
|
values[2] = xasprintf("%d", status.root_path_cost);
|
|
|
|
|
|
|
|
|
|
ovsrec_bridge_set_status(br->cfg, keys, values, ARRAY_SIZE(values));
|
|
|
|
|
|
|
|
|
|
for (i = 0; i < ARRAY_SIZE(values); i++) {
|
|
|
|
|
free(values[i]);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
port_refresh_stp_status(struct port *port)
|
|
|
|
|
{
|
|
|
|
|
struct ofproto *ofproto = port->bridge->ofproto;
|
|
|
|
|
struct iface *iface;
|
|
|
|
|
struct ofproto_port_stp_status status;
|
2011-11-14 15:04:14 -08:00
|
|
|
|
char *keys[4];
|
|
|
|
|
char *str_values[4];
|
|
|
|
|
int64_t int_values[3];
|
2011-10-14 09:48:17 -07:00
|
|
|
|
size_t i;
|
|
|
|
|
|
2011-10-26 11:39:46 -07:00
|
|
|
|
if (port_is_synthetic(port)) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2011-10-14 09:48:17 -07:00
|
|
|
|
/* STP doesn't currently support bonds. */
|
|
|
|
|
if (!list_is_singleton(&port->ifaces)) {
|
|
|
|
|
ovsrec_port_set_status(port->cfg, NULL, NULL, 0);
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
iface = CONTAINER_OF(list_front(&port->ifaces), struct iface, port_elem);
|
|
|
|
|
|
|
|
|
|
if (ofproto_port_get_stp_status(ofproto, iface->ofp_port, &status)) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (!status.enabled) {
|
|
|
|
|
ovsrec_port_set_status(port->cfg, NULL, NULL, 0);
|
2011-11-14 15:04:14 -08:00
|
|
|
|
ovsrec_port_set_statistics(port->cfg, NULL, NULL, 0);
|
2011-10-14 09:48:17 -07:00
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2011-11-14 15:04:14 -08:00
|
|
|
|
/* Set Status column. */
|
|
|
|
|
keys[0] = "stp_port_id";
|
|
|
|
|
str_values[0] = xasprintf(STP_PORT_ID_FMT, status.port_id);
|
2011-10-14 09:48:17 -07:00
|
|
|
|
keys[1] = "stp_state";
|
2011-11-14 15:04:14 -08:00
|
|
|
|
str_values[1] = xstrdup(stp_state_name(status.state));
|
2011-10-14 09:48:17 -07:00
|
|
|
|
keys[2] = "stp_sec_in_state";
|
2011-11-14 15:04:14 -08:00
|
|
|
|
str_values[2] = xasprintf("%u", status.sec_in_state);
|
2011-10-14 09:48:17 -07:00
|
|
|
|
keys[3] = "stp_role";
|
2011-11-14 15:04:14 -08:00
|
|
|
|
str_values[3] = xstrdup(stp_role_name(status.role));
|
2011-10-14 09:48:17 -07:00
|
|
|
|
|
2011-11-14 15:04:14 -08:00
|
|
|
|
ovsrec_port_set_status(port->cfg, keys, str_values,
|
|
|
|
|
ARRAY_SIZE(str_values));
|
2011-10-14 09:48:17 -07:00
|
|
|
|
|
2011-11-14 15:04:14 -08:00
|
|
|
|
for (i = 0; i < ARRAY_SIZE(str_values); i++) {
|
|
|
|
|
free(str_values[i]);
|
2011-10-14 09:48:17 -07:00
|
|
|
|
}
|
2011-11-14 15:04:14 -08:00
|
|
|
|
|
|
|
|
|
/* Set Statistics column. */
|
|
|
|
|
keys[0] = "stp_tx_count";
|
|
|
|
|
int_values[0] = status.tx_count;
|
|
|
|
|
keys[1] = "stp_rx_count";
|
|
|
|
|
int_values[1] = status.rx_count;
|
|
|
|
|
keys[2] = "stp_error_count";
|
|
|
|
|
int_values[2] = status.error_count;
|
|
|
|
|
|
|
|
|
|
ovsrec_port_set_statistics(port->cfg, keys, int_values,
|
|
|
|
|
ARRAY_SIZE(int_values));
|
2011-10-14 09:48:17 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-06-20 14:21:06 -07:00
|
|
|
|
static bool
|
|
|
|
|
enable_system_stats(const struct ovsrec_open_vswitch *cfg)
|
|
|
|
|
{
|
|
|
|
|
const char *enable;
|
|
|
|
|
|
|
|
|
|
/* Use other-config:enable-system-stats by preference. */
|
2011-11-23 13:17:38 -08:00
|
|
|
|
enable = get_ovsrec_key_value(cfg->key_other_config,
|
|
|
|
|
cfg->value_other_config,
|
|
|
|
|
cfg->n_other_config,
|
2011-06-20 14:21:06 -07:00
|
|
|
|
"enable-statistics");
|
|
|
|
|
if (enable) {
|
|
|
|
|
return !strcmp(enable, "true");
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Disable by default. */
|
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
|
2010-09-22 16:45:30 -07:00
|
|
|
|
static void
|
|
|
|
|
refresh_system_stats(const struct ovsrec_open_vswitch *cfg)
|
|
|
|
|
{
|
|
|
|
|
struct ovsdb_datum datum;
|
|
|
|
|
struct shash stats;
|
|
|
|
|
|
|
|
|
|
shash_init(&stats);
|
2011-06-20 14:21:06 -07:00
|
|
|
|
if (enable_system_stats(cfg)) {
|
|
|
|
|
get_system_stats(&stats);
|
|
|
|
|
}
|
2010-09-22 16:45:30 -07:00
|
|
|
|
|
|
|
|
|
ovsdb_datum_from_shash(&datum, &stats);
|
|
|
|
|
ovsdb_idl_txn_write(&cfg->header_, &ovsrec_open_vswitch_col_statistics,
|
|
|
|
|
&datum);
|
|
|
|
|
}
|
|
|
|
|
|
2011-01-21 11:01:45 -08:00
|
|
|
|
static inline const char *
|
|
|
|
|
nx_role_to_str(enum nx_role role)
|
|
|
|
|
{
|
|
|
|
|
switch (role) {
|
|
|
|
|
case NX_ROLE_OTHER:
|
|
|
|
|
return "other";
|
|
|
|
|
case NX_ROLE_MASTER:
|
|
|
|
|
return "master";
|
|
|
|
|
case NX_ROLE_SLAVE:
|
|
|
|
|
return "slave";
|
|
|
|
|
default:
|
|
|
|
|
return "*** INVALID ROLE ***";
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
2011-06-30 15:15:46 -07:00
|
|
|
|
refresh_controller_status(void)
|
2011-01-21 11:01:45 -08:00
|
|
|
|
{
|
2011-06-30 15:15:46 -07:00
|
|
|
|
struct bridge *br;
|
2011-01-21 11:01:45 -08:00
|
|
|
|
struct shash info;
|
|
|
|
|
const struct ovsrec_controller *cfg;
|
|
|
|
|
|
2011-06-30 15:15:46 -07:00
|
|
|
|
shash_init(&info);
|
|
|
|
|
|
|
|
|
|
/* Accumulate status for controllers on all bridges. */
|
|
|
|
|
HMAP_FOR_EACH (br, node, &all_bridges) {
|
|
|
|
|
ofproto_get_ofproto_controller_info(br->ofproto, &info);
|
|
|
|
|
}
|
2011-01-21 11:01:45 -08:00
|
|
|
|
|
2011-06-30 15:15:46 -07:00
|
|
|
|
/* Update each controller in the database with current status. */
|
2011-01-21 11:01:45 -08:00
|
|
|
|
OVSREC_CONTROLLER_FOR_EACH(cfg, idl) {
|
2011-01-24 17:01:53 -08:00
|
|
|
|
struct ofproto_controller_info *cinfo =
|
|
|
|
|
shash_find_data(&info, cfg->target);
|
|
|
|
|
|
|
|
|
|
if (cinfo) {
|
|
|
|
|
ovsrec_controller_set_is_connected(cfg, cinfo->is_connected);
|
|
|
|
|
ovsrec_controller_set_role(cfg, nx_role_to_str(cinfo->role));
|
|
|
|
|
ovsrec_controller_set_status(cfg, (char **) cinfo->pairs.keys,
|
|
|
|
|
(char **) cinfo->pairs.values,
|
|
|
|
|
cinfo->pairs.n);
|
|
|
|
|
} else {
|
|
|
|
|
ovsrec_controller_set_is_connected(cfg, false);
|
|
|
|
|
ovsrec_controller_set_role(cfg, NULL);
|
|
|
|
|
ovsrec_controller_set_status(cfg, NULL, NULL, 0);
|
|
|
|
|
}
|
2011-01-21 11:01:45 -08:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
ofproto_free_ofproto_controller_info(&info);
|
|
|
|
|
}
|
|
|
|
|
|
2011-09-08 16:15:36 -07:00
|
|
|
|
static void
|
|
|
|
|
refresh_cfm_stats(void)
|
|
|
|
|
{
|
|
|
|
|
static struct ovsdb_idl_txn *txn = NULL;
|
|
|
|
|
|
|
|
|
|
if (!txn) {
|
|
|
|
|
struct bridge *br;
|
|
|
|
|
|
|
|
|
|
txn = ovsdb_idl_txn_create(idl);
|
|
|
|
|
|
|
|
|
|
HMAP_FOR_EACH (br, node, &all_bridges) {
|
|
|
|
|
struct iface *iface;
|
|
|
|
|
|
|
|
|
|
HMAP_FOR_EACH (iface, name_node, &br->iface_by_name) {
|
|
|
|
|
iface_refresh_cfm_stats(iface);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (ovsdb_idl_txn_commit(txn) != TXN_INCOMPLETE) {
|
|
|
|
|
ovsdb_idl_txn_destroy(txn);
|
|
|
|
|
txn = NULL;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2011-11-28 10:35:15 -08:00
|
|
|
|
/* Performs periodic activity required by bridges that needs to be done with
|
|
|
|
|
* the least possible latency.
|
|
|
|
|
*
|
|
|
|
|
* It makes sense to call this function a couple of times per poll loop, to
|
|
|
|
|
* provide a significant performance boost on some benchmarks with ofprotos
|
|
|
|
|
* that use the ofproto-dpif implementation. */
|
|
|
|
|
void
|
|
|
|
|
bridge_run_fast(void)
|
|
|
|
|
{
|
|
|
|
|
struct bridge *br;
|
|
|
|
|
|
|
|
|
|
HMAP_FOR_EACH (br, node, &all_bridges) {
|
|
|
|
|
ofproto_run_fast(br->ofproto);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2010-06-10 14:17:41 -07:00
|
|
|
|
void
|
2009-07-08 13:19:16 -07:00
|
|
|
|
bridge_run(void)
|
|
|
|
|
{
|
2010-08-05 09:58:58 -07:00
|
|
|
|
const struct ovsrec_open_vswitch *cfg;
|
|
|
|
|
|
2011-11-23 17:03:31 -08:00
|
|
|
|
bool vlan_splinters_changed;
|
2010-08-05 09:58:58 -07:00
|
|
|
|
bool database_changed;
|
2010-06-10 14:17:41 -07:00
|
|
|
|
struct bridge *br;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-07-26 16:49:03 -07:00
|
|
|
|
/* (Re)configure if necessary. */
|
|
|
|
|
database_changed = ovsdb_idl_run(idl);
|
|
|
|
|
if (ovsdb_idl_is_lock_contended(idl)) {
|
|
|
|
|
static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 1);
|
|
|
|
|
struct bridge *br, *next_br;
|
|
|
|
|
|
|
|
|
|
VLOG_ERR_RL(&rl, "another ovs-vswitchd process is running, "
|
|
|
|
|
"disabling this process until it goes away");
|
|
|
|
|
|
|
|
|
|
HMAP_FOR_EACH_SAFE (br, next_br, node, &all_bridges) {
|
|
|
|
|
bridge_destroy(br);
|
|
|
|
|
}
|
|
|
|
|
return;
|
|
|
|
|
} else if (!ovsdb_idl_has_lock(idl)) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
cfg = ovsrec_open_vswitch_first(idl);
|
|
|
|
|
|
2010-06-10 14:17:41 -07:00
|
|
|
|
/* Let each bridge do the work that it needs to do. */
|
2011-04-04 14:11:16 -07:00
|
|
|
|
HMAP_FOR_EACH (br, node, &all_bridges) {
|
2011-11-28 10:35:15 -08:00
|
|
|
|
ofproto_run(br->ofproto);
|
2010-06-10 14:17:41 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-01-25 15:27:54 -08:00
|
|
|
|
/* Re-configure SSL. We do this on every trip through the main loop,
|
|
|
|
|
* instead of just when the database changes, because the contents of the
|
|
|
|
|
* key and certificate files can change without the database changing.
|
|
|
|
|
*
|
|
|
|
|
* We do this before bridge_reconfigure() because that function might
|
|
|
|
|
* initiate SSL connections and thus requires SSL to be configured. */
|
|
|
|
|
if (cfg && cfg->ssl) {
|
|
|
|
|
const struct ovsrec_ssl *ssl = cfg->ssl;
|
|
|
|
|
|
|
|
|
|
stream_ssl_set_key_and_cert(ssl->private_key, ssl->certificate);
|
|
|
|
|
stream_ssl_set_ca_cert_file(ssl->ca_cert, ssl->bootstrap_ca_cert);
|
|
|
|
|
}
|
2011-05-10 09:17:37 -07:00
|
|
|
|
|
2011-11-23 17:03:31 -08:00
|
|
|
|
/* If VLAN splinters are in use, then we need to reconfigure if VLAN usage
|
|
|
|
|
* has changed. */
|
|
|
|
|
vlan_splinters_changed = false;
|
|
|
|
|
if (vlan_splinters_enabled_anywhere) {
|
|
|
|
|
HMAP_FOR_EACH (br, node, &all_bridges) {
|
|
|
|
|
if (ofproto_has_vlan_usage_changed(br->ofproto)) {
|
|
|
|
|
vlan_splinters_changed = true;
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2011-11-28 10:35:15 -08:00
|
|
|
|
if (database_changed || vlan_splinters_changed) {
|
2010-06-10 14:17:41 -07:00
|
|
|
|
if (cfg) {
|
|
|
|
|
struct ovsdb_idl_txn *txn = ovsdb_idl_txn_create(idl);
|
|
|
|
|
|
|
|
|
|
bridge_reconfigure(cfg);
|
|
|
|
|
|
|
|
|
|
ovsrec_open_vswitch_set_cur_cfg(cfg, cfg->next_cfg);
|
|
|
|
|
ovsdb_idl_txn_commit(txn);
|
|
|
|
|
ovsdb_idl_txn_destroy(txn); /* XXX */
|
2010-06-10 14:32:32 -07:00
|
|
|
|
} else {
|
|
|
|
|
/* We still need to reconfigure to avoid dangling pointers to
|
|
|
|
|
* now-destroyed ovsrec structures inside bridge data. */
|
|
|
|
|
static const struct ovsrec_open_vswitch null_cfg;
|
|
|
|
|
|
|
|
|
|
bridge_reconfigure(&null_cfg);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
2010-06-23 11:02:46 -07:00
|
|
|
|
|
2010-09-23 10:21:40 -07:00
|
|
|
|
/* Refresh system and interface stats if necessary. */
|
|
|
|
|
if (time_msec() >= stats_timer) {
|
2010-09-22 16:45:30 -07:00
|
|
|
|
if (cfg) {
|
|
|
|
|
struct ovsdb_idl_txn *txn;
|
2010-06-23 11:02:46 -07:00
|
|
|
|
|
2010-09-22 16:45:30 -07:00
|
|
|
|
txn = ovsdb_idl_txn_create(idl);
|
2011-04-04 14:11:16 -07:00
|
|
|
|
HMAP_FOR_EACH (br, node, &all_bridges) {
|
2011-03-21 10:07:39 -07:00
|
|
|
|
struct port *port;
|
2011-11-20 15:12:36 -08:00
|
|
|
|
struct mirror *m;
|
2010-06-23 11:02:46 -07:00
|
|
|
|
|
2011-03-21 10:07:39 -07:00
|
|
|
|
HMAP_FOR_EACH (port, hmap_node, &br->ports) {
|
2011-03-21 10:24:32 -07:00
|
|
|
|
struct iface *iface;
|
2010-06-23 11:02:46 -07:00
|
|
|
|
|
2011-03-21 10:24:32 -07:00
|
|
|
|
LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
|
2010-09-22 16:45:30 -07:00
|
|
|
|
iface_refresh_stats(iface);
|
2011-01-05 11:51:15 -08:00
|
|
|
|
iface_refresh_status(iface);
|
2010-09-22 16:45:30 -07:00
|
|
|
|
}
|
2010-06-23 11:02:46 -07:00
|
|
|
|
}
|
2011-11-20 15:12:36 -08:00
|
|
|
|
|
|
|
|
|
HMAP_FOR_EACH (m, hmap_node, &br->mirrors) {
|
|
|
|
|
mirror_refresh_stats(m);
|
|
|
|
|
}
|
|
|
|
|
|
2010-06-23 11:02:46 -07:00
|
|
|
|
}
|
2010-09-22 16:45:30 -07:00
|
|
|
|
refresh_system_stats(cfg);
|
2011-06-30 15:15:46 -07:00
|
|
|
|
refresh_controller_status();
|
2010-09-22 16:45:30 -07:00
|
|
|
|
ovsdb_idl_txn_commit(txn);
|
|
|
|
|
ovsdb_idl_txn_destroy(txn); /* XXX */
|
2010-06-23 11:02:46 -07:00
|
|
|
|
}
|
|
|
|
|
|
2010-09-23 10:21:40 -07:00
|
|
|
|
stats_timer = time_msec() + STATS_INTERVAL;
|
2010-06-23 11:02:46 -07:00
|
|
|
|
}
|
2011-03-25 13:36:43 -07:00
|
|
|
|
|
2011-04-15 12:57:30 -07:00
|
|
|
|
if (time_msec() >= db_limiter) {
|
2011-03-25 13:36:43 -07:00
|
|
|
|
struct ovsdb_idl_txn *txn;
|
|
|
|
|
|
|
|
|
|
txn = ovsdb_idl_txn_create(idl);
|
2011-04-04 14:11:16 -07:00
|
|
|
|
HMAP_FOR_EACH (br, node, &all_bridges) {
|
2011-10-14 17:20:25 -07:00
|
|
|
|
struct iface *iface;
|
2011-10-14 09:48:17 -07:00
|
|
|
|
struct port *port;
|
|
|
|
|
|
|
|
|
|
br_refresh_stp_status(br);
|
|
|
|
|
|
|
|
|
|
HMAP_FOR_EACH (port, hmap_node, &br->ports) {
|
|
|
|
|
port_refresh_stp_status(port);
|
|
|
|
|
}
|
2011-10-14 17:20:25 -07:00
|
|
|
|
|
|
|
|
|
HMAP_FOR_EACH (iface, name_node, &br->iface_by_name) {
|
2011-10-14 17:29:35 -07:00
|
|
|
|
const char *link_state;
|
2011-10-14 12:49:57 -07:00
|
|
|
|
int64_t link_resets;
|
2011-10-14 17:20:25 -07:00
|
|
|
|
int current;
|
2011-03-25 13:36:43 -07:00
|
|
|
|
|
2011-10-14 17:20:25 -07:00
|
|
|
|
if (iface_is_synthetic(iface)) {
|
|
|
|
|
continue;
|
|
|
|
|
}
|
2011-03-25 13:36:43 -07:00
|
|
|
|
|
2011-10-14 17:20:25 -07:00
|
|
|
|
current = ofproto_port_is_lacp_current(br->ofproto,
|
|
|
|
|
iface->ofp_port);
|
|
|
|
|
if (current >= 0) {
|
|
|
|
|
bool bl = current;
|
|
|
|
|
ovsrec_interface_set_lacp_current(iface->cfg, &bl, 1);
|
|
|
|
|
} else {
|
|
|
|
|
ovsrec_interface_set_lacp_current(iface->cfg, NULL, 0);
|
2011-03-25 13:36:43 -07:00
|
|
|
|
}
|
2011-10-14 17:29:35 -07:00
|
|
|
|
|
|
|
|
|
link_state = netdev_get_carrier(iface->netdev) ? "up" : "down";
|
|
|
|
|
ovsrec_interface_set_link_state(iface->cfg, link_state);
|
2011-10-14 12:49:57 -07:00
|
|
|
|
|
|
|
|
|
link_resets = netdev_get_carrier_resets(iface->netdev);
|
|
|
|
|
ovsrec_interface_set_link_resets(iface->cfg, &link_resets, 1);
|
2011-03-25 13:36:43 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2011-10-14 17:20:25 -07:00
|
|
|
|
if (ovsdb_idl_txn_commit(txn) != TXN_UNCHANGED) {
|
2011-04-15 12:57:30 -07:00
|
|
|
|
db_limiter = time_msec() + DB_LIMIT_INTERVAL;
|
2011-03-25 13:36:43 -07:00
|
|
|
|
}
|
|
|
|
|
ovsdb_idl_txn_destroy(txn);
|
|
|
|
|
}
|
2011-09-08 16:15:36 -07:00
|
|
|
|
|
|
|
|
|
refresh_cfm_stats();
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void
|
|
|
|
|
bridge_wait(void)
|
|
|
|
|
{
|
2010-06-10 14:17:41 -07:00
|
|
|
|
ovsdb_idl_wait(idl);
|
2011-07-26 16:49:03 -07:00
|
|
|
|
if (!hmap_is_empty(&all_bridges)) {
|
|
|
|
|
struct bridge *br;
|
2011-03-25 13:36:43 -07:00
|
|
|
|
|
2011-07-26 16:49:03 -07:00
|
|
|
|
HMAP_FOR_EACH (br, node, &all_bridges) {
|
|
|
|
|
ofproto_wait(br->ofproto);
|
|
|
|
|
}
|
|
|
|
|
poll_timer_wait_until(stats_timer);
|
|
|
|
|
|
|
|
|
|
if (db_limiter > time_msec()) {
|
|
|
|
|
poll_timer_wait_until(db_limiter);
|
|
|
|
|
}
|
2011-03-25 13:36:43 -07:00
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2009-07-15 11:05:37 -07:00
|
|
|
|
|
2011-03-11 13:44:16 -08:00
|
|
|
|
/* QoS unixctl user interface functions. */
|
|
|
|
|
|
|
|
|
|
struct qos_unixctl_show_cbdata {
|
|
|
|
|
struct ds *ds;
|
|
|
|
|
struct iface *iface;
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
qos_unixctl_show_cb(unsigned int queue_id,
|
|
|
|
|
const struct shash *details,
|
|
|
|
|
void *aux)
|
|
|
|
|
{
|
|
|
|
|
struct qos_unixctl_show_cbdata *data = aux;
|
|
|
|
|
struct ds *ds = data->ds;
|
|
|
|
|
struct iface *iface = data->iface;
|
|
|
|
|
struct netdev_queue_stats stats;
|
|
|
|
|
struct shash_node *node;
|
|
|
|
|
int error;
|
|
|
|
|
|
|
|
|
|
ds_put_cstr(ds, "\n");
|
|
|
|
|
if (queue_id) {
|
|
|
|
|
ds_put_format(ds, "Queue %u:\n", queue_id);
|
|
|
|
|
} else {
|
|
|
|
|
ds_put_cstr(ds, "Default:\n");
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
SHASH_FOR_EACH (node, details) {
|
|
|
|
|
ds_put_format(ds, "\t%s: %s\n", node->name, (char *)node->data);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
error = netdev_get_queue_stats(iface->netdev, queue_id, &stats);
|
|
|
|
|
if (!error) {
|
|
|
|
|
if (stats.tx_packets != UINT64_MAX) {
|
|
|
|
|
ds_put_format(ds, "\ttx_packets: %"PRIu64"\n", stats.tx_packets);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (stats.tx_bytes != UINT64_MAX) {
|
|
|
|
|
ds_put_format(ds, "\ttx_bytes: %"PRIu64"\n", stats.tx_bytes);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (stats.tx_errors != UINT64_MAX) {
|
|
|
|
|
ds_put_format(ds, "\ttx_errors: %"PRIu64"\n", stats.tx_errors);
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
ds_put_format(ds, "\tFailed to get statistics for queue %u: %s",
|
|
|
|
|
queue_id, strerror(error));
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
2011-12-02 15:29:19 -08:00
|
|
|
|
qos_unixctl_show(struct unixctl_conn *conn, int argc OVS_UNUSED,
|
|
|
|
|
const char *argv[], void *aux OVS_UNUSED)
|
2011-03-11 13:44:16 -08:00
|
|
|
|
{
|
|
|
|
|
struct ds ds = DS_EMPTY_INITIALIZER;
|
|
|
|
|
struct shash sh = SHASH_INITIALIZER(&sh);
|
|
|
|
|
struct iface *iface;
|
|
|
|
|
const char *type;
|
|
|
|
|
struct shash_node *node;
|
|
|
|
|
struct qos_unixctl_show_cbdata data;
|
|
|
|
|
int error;
|
|
|
|
|
|
2011-12-02 15:29:19 -08:00
|
|
|
|
iface = iface_find(argv[1]);
|
2011-03-11 13:44:16 -08:00
|
|
|
|
if (!iface) {
|
|
|
|
|
unixctl_command_reply(conn, 501, "no such interface");
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
netdev_get_qos(iface->netdev, &type, &sh);
|
|
|
|
|
|
|
|
|
|
if (*type != '\0') {
|
|
|
|
|
ds_put_format(&ds, "QoS: %s %s\n", iface->name, type);
|
|
|
|
|
|
|
|
|
|
SHASH_FOR_EACH (node, &sh) {
|
|
|
|
|
ds_put_format(&ds, "%s: %s\n", node->name, (char *)node->data);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
data.ds = &ds;
|
|
|
|
|
data.iface = iface;
|
|
|
|
|
error = netdev_dump_queues(iface->netdev, qos_unixctl_show_cb, &data);
|
|
|
|
|
|
|
|
|
|
if (error) {
|
|
|
|
|
ds_put_format(&ds, "failed to dump queues: %s", strerror(error));
|
|
|
|
|
}
|
|
|
|
|
unixctl_command_reply(conn, 200, ds_cstr(&ds));
|
|
|
|
|
} else {
|
|
|
|
|
ds_put_format(&ds, "QoS not configured on %s\n", iface->name);
|
|
|
|
|
unixctl_command_reply(conn, 501, ds_cstr(&ds));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
shash_destroy_free_data(&sh);
|
|
|
|
|
ds_destroy(&ds);
|
|
|
|
|
}
|
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
/* Bridge reconfiguration functions. */
|
2011-04-08 13:50:21 -07:00
|
|
|
|
static void
|
2010-01-22 14:37:10 -05:00
|
|
|
|
bridge_create(const struct ovsrec_bridge *br_cfg)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
|
|
|
|
struct bridge *br;
|
|
|
|
|
|
2010-01-22 14:37:10 -05:00
|
|
|
|
assert(!bridge_lookup(br_cfg->name));
|
2009-09-28 13:56:42 -07:00
|
|
|
|
br = xzalloc(sizeof *br);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2010-01-22 14:37:10 -05:00
|
|
|
|
br->name = xstrdup(br_cfg->name);
|
2011-05-09 09:33:02 -07:00
|
|
|
|
br->type = xstrdup(ofproto_normalize_type(br_cfg->datapath_type));
|
2010-01-22 14:37:10 -05:00
|
|
|
|
br->cfg = br_cfg;
|
2011-05-10 11:38:24 -07:00
|
|
|
|
|
|
|
|
|
/* Derive the default Ethernet address from the bridge's UUID. This should
|
|
|
|
|
* be unique and it will be stable between ovs-vswitchd runs. */
|
|
|
|
|
memcpy(br->default_ea, &br_cfg->header_.uuid, ETH_ADDR_LEN);
|
|
|
|
|
eth_addr_mark_random(br->default_ea);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-03-21 10:07:39 -07:00
|
|
|
|
hmap_init(&br->ports);
|
2010-07-19 11:23:05 -07:00
|
|
|
|
hmap_init(&br->ifaces);
|
2011-04-01 11:42:25 -07:00
|
|
|
|
hmap_init(&br->iface_by_name);
|
2011-05-11 12:26:06 -07:00
|
|
|
|
hmap_init(&br->mirrors);
|
2010-05-05 14:00:47 -07:00
|
|
|
|
|
2011-04-04 14:11:16 -07:00
|
|
|
|
hmap_insert(&all_bridges, &br->node, hash_string(br->name, 0));
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
bridge_destroy(struct bridge *br)
|
|
|
|
|
{
|
|
|
|
|
if (br) {
|
2011-05-11 12:26:06 -07:00
|
|
|
|
struct mirror *mirror, *next_mirror;
|
|
|
|
|
struct port *port, *next_port;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
HMAP_FOR_EACH_SAFE (port, next_port, hmap_node, &br->ports) {
|
2011-03-21 10:07:39 -07:00
|
|
|
|
port_destroy(port);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2011-05-11 12:26:06 -07:00
|
|
|
|
HMAP_FOR_EACH_SAFE (mirror, next_mirror, hmap_node, &br->mirrors) {
|
|
|
|
|
mirror_destroy(mirror);
|
2011-04-11 11:22:39 -07:00
|
|
|
|
}
|
2011-04-04 14:11:16 -07:00
|
|
|
|
hmap_remove(&all_bridges, &br->node);
|
2011-03-31 14:12:57 -07:00
|
|
|
|
ofproto_destroy(br->ofproto);
|
2010-07-19 11:23:05 -07:00
|
|
|
|
hmap_destroy(&br->ifaces);
|
2011-03-21 10:07:39 -07:00
|
|
|
|
hmap_destroy(&br->ports);
|
2011-04-01 11:42:25 -07:00
|
|
|
|
hmap_destroy(&br->iface_by_name);
|
2011-05-11 12:26:06 -07:00
|
|
|
|
hmap_destroy(&br->mirrors);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
free(br->name);
|
2011-04-08 13:50:21 -07:00
|
|
|
|
free(br->type);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
free(br);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static struct bridge *
|
|
|
|
|
bridge_lookup(const char *name)
|
|
|
|
|
{
|
|
|
|
|
struct bridge *br;
|
|
|
|
|
|
2011-04-04 14:11:16 -07:00
|
|
|
|
HMAP_FOR_EACH_WITH_HASH (br, node, hash_string(name, 0), &all_bridges) {
|
2009-07-08 13:19:16 -07:00
|
|
|
|
if (!strcmp(br->name, name)) {
|
|
|
|
|
return br;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
return NULL;
|
|
|
|
|
}
|
|
|
|
|
|
2009-07-14 13:03:57 -07:00
|
|
|
|
/* Handle requests for a listing of all flows known by the OpenFlow
|
|
|
|
|
* stack, including those normally hidden. */
|
|
|
|
|
static void
|
2011-12-02 15:29:19 -08:00
|
|
|
|
bridge_unixctl_dump_flows(struct unixctl_conn *conn, int argc OVS_UNUSED,
|
|
|
|
|
const char *argv[], void *aux OVS_UNUSED)
|
2009-07-14 13:03:57 -07:00
|
|
|
|
{
|
|
|
|
|
struct bridge *br;
|
|
|
|
|
struct ds results;
|
2010-08-30 00:24:53 -07:00
|
|
|
|
|
2011-12-02 15:29:19 -08:00
|
|
|
|
br = bridge_lookup(argv[1]);
|
2009-07-14 13:03:57 -07:00
|
|
|
|
if (!br) {
|
|
|
|
|
unixctl_command_reply(conn, 501, "Unknown bridge");
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
ds_init(&results);
|
|
|
|
|
ofproto_get_all_flows(br->ofproto, &results);
|
|
|
|
|
|
|
|
|
|
unixctl_command_reply(conn, 200, ds_cstr(&results));
|
|
|
|
|
ds_destroy(&results);
|
|
|
|
|
}
|
|
|
|
|
|
2010-06-18 13:58:42 -07:00
|
|
|
|
/* "bridge/reconnect [BRIDGE]": makes BRIDGE drop all of its controller
|
|
|
|
|
* connections and reconnect. If BRIDGE is not specified, then all bridges
|
|
|
|
|
* drop their controller connections and reconnect. */
|
|
|
|
|
static void
|
2011-12-02 15:29:19 -08:00
|
|
|
|
bridge_unixctl_reconnect(struct unixctl_conn *conn, int argc,
|
|
|
|
|
const char *argv[], void *aux OVS_UNUSED)
|
2010-06-18 13:58:42 -07:00
|
|
|
|
{
|
|
|
|
|
struct bridge *br;
|
2011-12-02 15:29:19 -08:00
|
|
|
|
if (argc > 1) {
|
|
|
|
|
br = bridge_lookup(argv[1]);
|
2010-06-18 13:58:42 -07:00
|
|
|
|
if (!br) {
|
|
|
|
|
unixctl_command_reply(conn, 501, "Unknown bridge");
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
ofproto_reconnect_controllers(br->ofproto);
|
|
|
|
|
} else {
|
2011-04-04 14:11:16 -07:00
|
|
|
|
HMAP_FOR_EACH (br, node, &all_bridges) {
|
2010-06-18 13:58:42 -07:00
|
|
|
|
ofproto_reconnect_controllers(br->ofproto);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
unixctl_command_reply(conn, 200, NULL);
|
|
|
|
|
}
|
|
|
|
|
|
2010-04-20 10:43:42 -07:00
|
|
|
|
static size_t
|
2010-07-15 14:53:36 -07:00
|
|
|
|
bridge_get_controllers(const struct bridge *br,
|
2010-04-20 10:43:42 -07:00
|
|
|
|
struct ovsrec_controller ***controllersp)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2010-04-20 10:43:42 -07:00
|
|
|
|
struct ovsrec_controller **controllers;
|
|
|
|
|
size_t n_controllers;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2010-07-15 14:53:36 -07:00
|
|
|
|
controllers = br->cfg->controller;
|
|
|
|
|
n_controllers = br->cfg->n_controller;
|
2009-12-03 11:28:40 -08:00
|
|
|
|
|
2010-04-20 10:43:42 -07:00
|
|
|
|
if (n_controllers == 1 && !strcmp(controllers[0]->target, "none")) {
|
|
|
|
|
controllers = NULL;
|
|
|
|
|
n_controllers = 0;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2009-12-03 11:28:40 -08:00
|
|
|
|
|
2010-04-20 10:43:42 -07:00
|
|
|
|
if (controllersp) {
|
|
|
|
|
*controllersp = controllers;
|
|
|
|
|
}
|
|
|
|
|
return n_controllers;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-04-08 13:50:21 -07:00
|
|
|
|
/* Adds and deletes "struct port"s and "struct iface"s under 'br' to match
|
|
|
|
|
* those configured in 'br->cfg'. */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static void
|
2011-11-23 17:03:31 -08:00
|
|
|
|
bridge_add_del_ports(struct bridge *br,
|
|
|
|
|
const unsigned long int *splinter_vlans)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2011-03-21 10:07:39 -07:00
|
|
|
|
struct port *port, *next;
|
2009-12-03 11:28:40 -08:00
|
|
|
|
struct shash_node *node;
|
2011-03-21 10:07:39 -07:00
|
|
|
|
struct shash new_ports;
|
2009-07-30 15:56:17 -07:00
|
|
|
|
size_t i;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
|
|
|
|
/* Collect new ports. */
|
2009-12-03 11:28:40 -08:00
|
|
|
|
shash_init(&new_ports);
|
|
|
|
|
for (i = 0; i < br->cfg->n_ports; i++) {
|
|
|
|
|
const char *name = br->cfg->ports[i]->name;
|
|
|
|
|
if (!shash_add_once(&new_ports, name, br->cfg->ports[i])) {
|
|
|
|
|
VLOG_WARN("bridge %s: %s specified twice as bridge port",
|
|
|
|
|
br->name, name);
|
|
|
|
|
}
|
|
|
|
|
}
|
2011-05-04 10:15:31 -07:00
|
|
|
|
if (bridge_get_controllers(br, NULL)
|
|
|
|
|
&& !shash_find(&new_ports, br->name)) {
|
2011-04-13 11:10:44 -07:00
|
|
|
|
VLOG_WARN("bridge %s: no port named %s, synthesizing one",
|
|
|
|
|
br->name, br->name);
|
2009-06-19 14:09:39 -07:00
|
|
|
|
|
2011-04-13 11:10:44 -07:00
|
|
|
|
br->synth_local_port.interfaces = &br->synth_local_ifacep;
|
|
|
|
|
br->synth_local_port.n_interfaces = 1;
|
|
|
|
|
br->synth_local_port.name = br->name;
|
|
|
|
|
|
|
|
|
|
br->synth_local_iface.name = br->name;
|
2011-04-08 13:50:21 -07:00
|
|
|
|
br->synth_local_iface.type = "internal";
|
2011-04-13 11:10:44 -07:00
|
|
|
|
|
|
|
|
|
br->synth_local_ifacep = &br->synth_local_iface;
|
|
|
|
|
|
|
|
|
|
shash_add(&new_ports, br->name, &br->synth_local_port);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-11-23 17:03:31 -08:00
|
|
|
|
if (splinter_vlans) {
|
|
|
|
|
add_vlan_splinter_ports(br, splinter_vlans, &new_ports);
|
|
|
|
|
}
|
|
|
|
|
|
2010-05-05 14:00:47 -07:00
|
|
|
|
/* Get rid of deleted ports.
|
2011-11-14 10:28:31 -08:00
|
|
|
|
* Get rid of deleted interfaces on ports that still exist. */
|
2011-03-21 10:07:39 -07:00
|
|
|
|
HMAP_FOR_EACH_SAFE (port, next, hmap_node, &br->ports) {
|
2011-04-08 13:50:21 -07:00
|
|
|
|
port->cfg = shash_find_data(&new_ports, port->name);
|
|
|
|
|
if (!port->cfg) {
|
2010-05-05 14:00:47 -07:00
|
|
|
|
port_destroy(port);
|
|
|
|
|
} else {
|
2011-04-08 13:50:21 -07:00
|
|
|
|
port_del_ifaces(port);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
2010-05-05 14:00:47 -07:00
|
|
|
|
|
|
|
|
|
/* Create new ports.
|
2011-04-08 13:50:21 -07:00
|
|
|
|
* Add new interfaces to existing ports. */
|
2009-12-03 11:28:40 -08:00
|
|
|
|
SHASH_FOR_EACH (node, &new_ports) {
|
2011-03-21 10:07:39 -07:00
|
|
|
|
struct port *port = port_lookup(br, node->name);
|
2009-12-03 11:28:40 -08:00
|
|
|
|
if (!port) {
|
2011-04-08 13:50:21 -07:00
|
|
|
|
struct ovsrec_port *cfg = node->data;
|
|
|
|
|
port = port_create(br, cfg);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2011-04-08 13:50:21 -07:00
|
|
|
|
port_add_ifaces(port);
|
2011-03-24 10:29:36 -07:00
|
|
|
|
if (list_is_empty(&port->ifaces)) {
|
2010-04-29 14:54:10 -07:00
|
|
|
|
VLOG_WARN("bridge %s: port %s has no interfaces, dropping",
|
|
|
|
|
br->name, port->name);
|
|
|
|
|
port_destroy(port);
|
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2009-12-03 11:28:40 -08:00
|
|
|
|
shash_destroy(&new_ports);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2010-08-06 16:49:20 -07:00
|
|
|
|
/* Initializes 'oc' appropriately as a management service controller for
|
|
|
|
|
* 'br'.
|
|
|
|
|
*
|
|
|
|
|
* The caller must free oc->target when it is no longer needed. */
|
|
|
|
|
static void
|
|
|
|
|
bridge_ofproto_controller_for_mgmt(const struct bridge *br,
|
|
|
|
|
struct ofproto_controller *oc)
|
|
|
|
|
{
|
2010-11-29 12:28:26 -08:00
|
|
|
|
oc->target = xasprintf("punix:%s/%s.mgmt", ovs_rundir(), br->name);
|
2010-08-06 16:49:20 -07:00
|
|
|
|
oc->max_backoff = 0;
|
|
|
|
|
oc->probe_interval = 60;
|
|
|
|
|
oc->band = OFPROTO_OUT_OF_BAND;
|
|
|
|
|
oc->rate_limit = 0;
|
|
|
|
|
oc->burst_limit = 0;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Converts ovsrec_controller 'c' into an ofproto_controller in 'oc'. */
|
|
|
|
|
static void
|
|
|
|
|
bridge_ofproto_controller_from_ovsrec(const struct ovsrec_controller *c,
|
|
|
|
|
struct ofproto_controller *oc)
|
|
|
|
|
{
|
|
|
|
|
oc->target = c->target;
|
|
|
|
|
oc->max_backoff = c->max_backoff ? *c->max_backoff / 1000 : 8;
|
|
|
|
|
oc->probe_interval = c->inactivity_probe ? *c->inactivity_probe / 1000 : 5;
|
|
|
|
|
oc->band = (!c->connection_mode || !strcmp(c->connection_mode, "in-band")
|
|
|
|
|
? OFPROTO_IN_BAND : OFPROTO_OUT_OF_BAND);
|
|
|
|
|
oc->rate_limit = c->controller_rate_limit ? *c->controller_rate_limit : 0;
|
|
|
|
|
oc->burst_limit = (c->controller_burst_limit
|
|
|
|
|
? *c->controller_burst_limit : 0);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Configures the IP stack for 'br''s local interface properly according to the
|
|
|
|
|
* configuration in 'c'. */
|
|
|
|
|
static void
|
|
|
|
|
bridge_configure_local_iface_netdev(struct bridge *br,
|
|
|
|
|
struct ovsrec_controller *c)
|
|
|
|
|
{
|
|
|
|
|
struct netdev *netdev;
|
|
|
|
|
struct in_addr mask, gateway;
|
|
|
|
|
|
|
|
|
|
struct iface *local_iface;
|
|
|
|
|
struct in_addr ip;
|
|
|
|
|
|
|
|
|
|
/* If there's no local interface or no IP address, give up. */
|
2011-05-09 09:24:39 -07:00
|
|
|
|
local_iface = iface_from_ofp_port(br, OFPP_LOCAL);
|
2010-08-06 16:49:20 -07:00
|
|
|
|
if (!local_iface || !c->local_ip || !inet_aton(c->local_ip, &ip)) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Bring up the local interface. */
|
|
|
|
|
netdev = local_iface->netdev;
|
|
|
|
|
netdev_turn_flags_on(netdev, NETDEV_UP, true);
|
|
|
|
|
|
|
|
|
|
/* Configure the IP address and netmask. */
|
|
|
|
|
if (!c->local_netmask
|
|
|
|
|
|| !inet_aton(c->local_netmask, &mask)
|
|
|
|
|
|| !mask.s_addr) {
|
|
|
|
|
mask.s_addr = guess_netmask(ip.s_addr);
|
|
|
|
|
}
|
|
|
|
|
if (!netdev_set_in4(netdev, ip, mask)) {
|
|
|
|
|
VLOG_INFO("bridge %s: configured IP address "IP_FMT", netmask "IP_FMT,
|
|
|
|
|
br->name, IP_ARGS(&ip.s_addr), IP_ARGS(&mask.s_addr));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Configure the default gateway. */
|
|
|
|
|
if (c->local_gateway
|
|
|
|
|
&& inet_aton(c->local_gateway, &gateway)
|
|
|
|
|
&& gateway.s_addr) {
|
|
|
|
|
if (!netdev_add_router(netdev, gateway)) {
|
|
|
|
|
VLOG_INFO("bridge %s: configured gateway "IP_FMT,
|
|
|
|
|
br->name, IP_ARGS(&gateway.s_addr));
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2011-10-18 08:57:37 -07:00
|
|
|
|
/* Returns true if 'a' and 'b' are the same except that any number of slashes
|
|
|
|
|
* in either string are treated as equal to any number of slashes in the other,
|
|
|
|
|
* e.g. "x///y" is equal to "x/y". */
|
|
|
|
|
static bool
|
|
|
|
|
equal_pathnames(const char *a, const char *b)
|
|
|
|
|
{
|
|
|
|
|
while (*a == *b) {
|
|
|
|
|
if (*a == '/') {
|
|
|
|
|
a += strspn(a, "/");
|
|
|
|
|
b += strspn(b, "/");
|
|
|
|
|
} else if (*a == '\0') {
|
|
|
|
|
return true;
|
|
|
|
|
} else {
|
|
|
|
|
a++;
|
|
|
|
|
b++;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static void
|
2011-05-11 12:26:06 -07:00
|
|
|
|
bridge_configure_remotes(struct bridge *br,
|
|
|
|
|
const struct sockaddr_in *managers, size_t n_managers)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2010-11-02 10:45:33 -07:00
|
|
|
|
const char *disable_ib_str, *queue_id_str;
|
|
|
|
|
bool disable_in_band = false;
|
|
|
|
|
int queue_id;
|
|
|
|
|
|
2010-04-20 10:43:42 -07:00
|
|
|
|
struct ovsrec_controller **controllers;
|
|
|
|
|
size_t n_controllers;
|
2010-08-06 16:49:20 -07:00
|
|
|
|
|
2011-04-08 13:50:21 -07:00
|
|
|
|
enum ofproto_fail_mode fail_mode;
|
2010-08-06 16:49:20 -07:00
|
|
|
|
|
|
|
|
|
struct ofproto_controller *ocs;
|
|
|
|
|
size_t n_ocs;
|
|
|
|
|
size_t i;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2010-10-19 15:58:35 -07:00
|
|
|
|
/* Check if we should disable in-band control on this bridge. */
|
|
|
|
|
disable_ib_str = bridge_get_other_config(br->cfg, "disable-in-band");
|
|
|
|
|
if (disable_ib_str && !strcmp(disable_ib_str, "true")) {
|
|
|
|
|
disable_in_band = true;
|
|
|
|
|
}
|
|
|
|
|
|
2010-11-02 10:45:33 -07:00
|
|
|
|
/* Set OpenFlow queue ID for in-band control. */
|
|
|
|
|
queue_id_str = bridge_get_other_config(br->cfg, "in-band-queue");
|
|
|
|
|
queue_id = queue_id_str ? strtol(queue_id_str, NULL, 10) : -1;
|
|
|
|
|
ofproto_set_in_band_queue(br->ofproto, queue_id);
|
|
|
|
|
|
2010-10-19 15:58:35 -07:00
|
|
|
|
if (disable_in_band) {
|
|
|
|
|
ofproto_set_extra_in_band_remotes(br->ofproto, NULL, 0);
|
|
|
|
|
} else {
|
|
|
|
|
ofproto_set_extra_in_band_remotes(br->ofproto, managers, n_managers);
|
|
|
|
|
}
|
2010-04-26 10:48:31 -07:00
|
|
|
|
|
2010-07-15 14:53:36 -07:00
|
|
|
|
n_controllers = bridge_get_controllers(br, &controllers);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2010-08-06 16:49:20 -07:00
|
|
|
|
ocs = xmalloc((n_controllers + 1) * sizeof *ocs);
|
|
|
|
|
n_ocs = 0;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2010-08-06 16:49:20 -07:00
|
|
|
|
bridge_ofproto_controller_for_mgmt(br, &ocs[n_ocs++]);
|
|
|
|
|
for (i = 0; i < n_controllers; i++) {
|
|
|
|
|
struct ovsrec_controller *c = controllers[i];
|
2010-04-20 10:43:42 -07:00
|
|
|
|
|
2010-08-06 16:49:20 -07:00
|
|
|
|
if (!strncmp(c->target, "punix:", 6)
|
|
|
|
|
|| !strncmp(c->target, "unix:", 5)) {
|
|
|
|
|
static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
|
2011-10-18 08:57:37 -07:00
|
|
|
|
char *whitelist;
|
|
|
|
|
|
|
|
|
|
whitelist = xasprintf("unix:%s/%s.controller",
|
|
|
|
|
ovs_rundir(), br->name);
|
|
|
|
|
if (!equal_pathnames(c->target, whitelist)) {
|
|
|
|
|
/* Prevent remote ovsdb-server users from accessing arbitrary
|
|
|
|
|
* Unix domain sockets and overwriting arbitrary local
|
|
|
|
|
* files. */
|
|
|
|
|
VLOG_ERR_RL(&rl, "bridge %s: Not adding Unix domain socket "
|
|
|
|
|
"controller \"%s\" due to possibility for remote "
|
|
|
|
|
"exploit. Instead, specify whitelisted \"%s\" or "
|
|
|
|
|
"connect to \"unix:%s/%s.mgmt\" (which is always "
|
|
|
|
|
"available without special configuration).",
|
|
|
|
|
br->name, c->target, whitelist,
|
|
|
|
|
ovs_rundir(), br->name);
|
|
|
|
|
free(whitelist);
|
|
|
|
|
continue;
|
|
|
|
|
}
|
2011-04-14 16:50:26 -07:00
|
|
|
|
|
2011-10-18 08:57:37 -07:00
|
|
|
|
free(whitelist);
|
2011-04-14 16:50:26 -07:00
|
|
|
|
}
|
|
|
|
|
|
2010-08-06 16:49:20 -07:00
|
|
|
|
bridge_configure_local_iface_netdev(br, c);
|
2010-10-19 15:58:35 -07:00
|
|
|
|
bridge_ofproto_controller_from_ovsrec(c, &ocs[n_ocs]);
|
|
|
|
|
if (disable_in_band) {
|
|
|
|
|
ocs[n_ocs].band = OFPROTO_OUT_OF_BAND;
|
2011-03-30 11:03:16 -07:00
|
|
|
|
}
|
2010-10-19 15:58:35 -07:00
|
|
|
|
n_ocs++;
|
2011-01-06 12:14:23 -08:00
|
|
|
|
}
|
|
|
|
|
|
2010-08-06 16:49:20 -07:00
|
|
|
|
ofproto_set_controllers(br->ofproto, ocs, n_ocs);
|
|
|
|
|
free(ocs[0].target); /* From bridge_ofproto_controller_for_mgmt(). */
|
|
|
|
|
free(ocs);
|
2011-04-08 13:50:21 -07:00
|
|
|
|
|
|
|
|
|
/* Set the fail-mode. */
|
|
|
|
|
fail_mode = !br->cfg->fail_mode
|
|
|
|
|
|| !strcmp(br->cfg->fail_mode, "standalone")
|
|
|
|
|
? OFPROTO_FAIL_STANDALONE
|
|
|
|
|
: OFPROTO_FAIL_SECURE;
|
|
|
|
|
ofproto_set_fail_mode(br->ofproto, fail_mode);
|
|
|
|
|
|
|
|
|
|
/* Configure OpenFlow controller connection snooping. */
|
|
|
|
|
if (!ofproto_has_snoops(br->ofproto)) {
|
|
|
|
|
struct sset snoops;
|
2011-04-13 17:58:26 -07:00
|
|
|
|
|
2011-04-08 13:50:21 -07:00
|
|
|
|
sset_init(&snoops);
|
|
|
|
|
sset_add_and_free(&snoops, xasprintf("punix:%s/%s.snoop",
|
|
|
|
|
ovs_rundir(), br->name));
|
|
|
|
|
ofproto_set_snoops(br->ofproto, &snoops);
|
|
|
|
|
sset_destroy(&snoops);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
/* Port functions. */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-03-30 11:03:16 -07:00
|
|
|
|
static struct port *
|
2011-05-11 12:26:06 -07:00
|
|
|
|
port_create(struct bridge *br, const struct ovsrec_port *cfg)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2011-03-30 11:03:16 -07:00
|
|
|
|
struct port *port;
|
|
|
|
|
|
|
|
|
|
port = xzalloc(sizeof *port);
|
|
|
|
|
port->bridge = br;
|
2011-05-11 12:26:06 -07:00
|
|
|
|
port->name = xstrdup(cfg->name);
|
|
|
|
|
port->cfg = cfg;
|
2011-03-30 11:03:16 -07:00
|
|
|
|
list_init(&port->ifaces);
|
|
|
|
|
|
|
|
|
|
hmap_insert(&br->ports, &port->hmap_node, hash_string(port->name, 0));
|
|
|
|
|
|
|
|
|
|
VLOG_INFO("created port %s on bridge %s", port->name, br->name);
|
|
|
|
|
|
|
|
|
|
return port;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-03-30 11:03:16 -07:00
|
|
|
|
static const char *
|
|
|
|
|
get_port_other_config(const struct ovsrec_port *port, const char *key,
|
|
|
|
|
const char *default_value)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2011-03-30 11:03:16 -07:00
|
|
|
|
const char *value;
|
|
|
|
|
|
2011-11-23 13:17:38 -08:00
|
|
|
|
value = get_ovsrec_key_value(port->key_other_config,
|
|
|
|
|
port->value_other_config,
|
|
|
|
|
port->n_other_config, key);
|
2011-03-30 11:03:16 -07:00
|
|
|
|
return value ? value : default_value;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-03-30 11:03:16 -07:00
|
|
|
|
static const char *
|
|
|
|
|
get_interface_other_config(const struct ovsrec_interface *iface,
|
|
|
|
|
const char *key, const char *default_value)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2011-03-30 11:03:16 -07:00
|
|
|
|
const char *value;
|
|
|
|
|
|
2011-11-23 13:17:38 -08:00
|
|
|
|
value = get_ovsrec_key_value(iface->key_other_config,
|
|
|
|
|
iface->value_other_config,
|
|
|
|
|
iface->n_other_config, key);
|
2011-03-30 11:03:16 -07:00
|
|
|
|
return value ? value : default_value;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
/* Deletes interfaces from 'port' that are no longer configured for it. */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static void
|
2011-05-11 12:26:06 -07:00
|
|
|
|
port_del_ifaces(struct port *port)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2011-03-30 11:03:16 -07:00
|
|
|
|
struct iface *iface, *next;
|
|
|
|
|
struct sset new_ifaces;
|
|
|
|
|
size_t i;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-03-30 11:03:16 -07:00
|
|
|
|
/* Collect list of new interfaces. */
|
|
|
|
|
sset_init(&new_ifaces);
|
2011-05-11 12:26:06 -07:00
|
|
|
|
for (i = 0; i < port->cfg->n_interfaces; i++) {
|
|
|
|
|
const char *name = port->cfg->interfaces[i]->name;
|
2011-05-12 12:05:42 -07:00
|
|
|
|
const char *type = port->cfg->interfaces[i]->name;
|
|
|
|
|
if (strcmp(type, "null")) {
|
|
|
|
|
sset_add(&new_ifaces, name);
|
|
|
|
|
}
|
2011-03-30 11:03:16 -07:00
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-03-30 11:03:16 -07:00
|
|
|
|
/* Get rid of deleted interfaces. */
|
|
|
|
|
LIST_FOR_EACH_SAFE (iface, next, port_elem, &port->ifaces) {
|
|
|
|
|
if (!sset_contains(&new_ifaces, iface->name)) {
|
|
|
|
|
iface_destroy(iface);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
2011-03-30 11:03:16 -07:00
|
|
|
|
|
|
|
|
|
sset_destroy(&new_ifaces);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
/* Adds new interfaces to 'port' and updates 'type' and 'cfg' members of
|
|
|
|
|
* existing ones. */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static void
|
2011-05-11 12:26:06 -07:00
|
|
|
|
port_add_ifaces(struct port *port)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2011-05-11 12:26:06 -07:00
|
|
|
|
struct shash new_ifaces;
|
|
|
|
|
struct shash_node *node;
|
|
|
|
|
size_t i;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
/* Collect new ifaces. */
|
|
|
|
|
shash_init(&new_ifaces);
|
|
|
|
|
for (i = 0; i < port->cfg->n_interfaces; i++) {
|
|
|
|
|
const struct ovsrec_interface *cfg = port->cfg->interfaces[i];
|
2011-05-12 12:05:42 -07:00
|
|
|
|
if (strcmp(cfg->type, "null")
|
|
|
|
|
&& !shash_add_once(&new_ifaces, cfg->name, cfg)) {
|
2011-05-11 12:26:06 -07:00
|
|
|
|
VLOG_WARN("port %s: %s specified twice as port interface",
|
|
|
|
|
port->name, cfg->name);
|
2011-09-28 09:36:13 -07:00
|
|
|
|
iface_clear_db_record(cfg);
|
2011-03-30 11:03:16 -07:00
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2011-01-06 12:14:23 -08:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
/* Create new interfaces.
|
|
|
|
|
* Update interface types and 'cfg' members. */
|
|
|
|
|
SHASH_FOR_EACH (node, &new_ifaces) {
|
|
|
|
|
const struct ovsrec_interface *cfg = node->data;
|
|
|
|
|
const char *iface_name = node->name;
|
2009-12-03 11:28:40 -08:00
|
|
|
|
struct iface *iface;
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
iface = iface_lookup(port->bridge, iface_name);
|
|
|
|
|
if (!iface) {
|
|
|
|
|
iface = iface_create(port, cfg);
|
|
|
|
|
} else {
|
|
|
|
|
iface->cfg = cfg;
|
2010-05-05 14:00:47 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-04-25 16:06:54 -07:00
|
|
|
|
/* Determine interface type. The local port always has type
|
|
|
|
|
* "internal". Other ports take their type from the database and
|
|
|
|
|
* default to "system" if none is specified. */
|
2011-05-11 12:26:06 -07:00
|
|
|
|
iface->type = (!strcmp(iface_name, port->bridge->name) ? "internal"
|
|
|
|
|
: cfg->type[0] ? cfg->type
|
|
|
|
|
: "system");
|
bridge: Avoid flushing entire MAC learning table for common operations.
Adding and removing ports is fairly common in a virtual environment,
because it happens whenever a VM boots or shuts down. It is best to
avoid flushing the whole MAC learning table when that happens, because
that means that, briefly, every packet will get flooded, wasting CPU cycles
and network bandwidth.
This commit breaks flushing the MAC table out of bridge_flush(). Instead,
each caller is now responsible for flushing the MAC table if it is
necessary. In a few cases, no flushing was necessary, so those callers
were not modified. In the case of removing a port or modifying its VLAN
assignments, it is necessary to expire all of the MAC learning entries
associated with that port, so this commit does that. Finally, some
operations do require a MAC learning flush but they are rare enough that
in my opinion it's not worth taking care to avoid a MAC table flush.
Bug #891.
2011-03-18 15:42:29 -07:00
|
|
|
|
}
|
2011-05-11 12:26:06 -07:00
|
|
|
|
shash_destroy(&new_ifaces);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
port_destroy(struct port *port)
|
|
|
|
|
{
|
|
|
|
|
if (port) {
|
|
|
|
|
struct bridge *br = port->bridge;
|
2011-03-21 10:24:32 -07:00
|
|
|
|
struct iface *iface, *next;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
if (br->ofproto) {
|
|
|
|
|
ofproto_bundle_unregister(br->ofproto, port);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-03-21 10:24:32 -07:00
|
|
|
|
LIST_FOR_EACH_SAFE (iface, next, port_elem, &port->ifaces) {
|
|
|
|
|
iface_destroy(iface);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-03-21 10:07:39 -07:00
|
|
|
|
hmap_remove(&br->ports, &port->hmap_node);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2010-10-21 15:37:57 -07:00
|
|
|
|
VLOG_INFO("destroyed port %s on bridge %s", port->name, br->name);
|
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
free(port->name);
|
|
|
|
|
free(port);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static struct port *
|
|
|
|
|
port_lookup(const struct bridge *br, const char *name)
|
|
|
|
|
{
|
2011-03-21 10:07:39 -07:00
|
|
|
|
struct port *port;
|
|
|
|
|
|
|
|
|
|
HMAP_FOR_EACH_WITH_HASH (port, hmap_node, hash_string(name, 0),
|
|
|
|
|
&br->ports) {
|
|
|
|
|
if (!strcmp(port->name, name)) {
|
|
|
|
|
return port;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
return NULL;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-03-21 12:49:44 -07:00
|
|
|
|
static bool
|
|
|
|
|
enable_lacp(struct port *port, bool *activep)
|
|
|
|
|
{
|
|
|
|
|
if (!port->cfg->lacp) {
|
|
|
|
|
/* XXX when LACP implementation has been sufficiently tested, enable by
|
|
|
|
|
* default and make active on bonded ports. */
|
|
|
|
|
return false;
|
|
|
|
|
} else if (!strcmp(port->cfg->lacp, "off")) {
|
|
|
|
|
return false;
|
|
|
|
|
} else if (!strcmp(port->cfg->lacp, "active")) {
|
|
|
|
|
*activep = true;
|
|
|
|
|
return true;
|
|
|
|
|
} else if (!strcmp(port->cfg->lacp, "passive")) {
|
|
|
|
|
*activep = false;
|
|
|
|
|
return true;
|
|
|
|
|
} else {
|
|
|
|
|
VLOG_WARN("port %s: unknown LACP mode %s",
|
|
|
|
|
port->name, port->cfg->lacp);
|
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
static struct lacp_settings *
|
|
|
|
|
port_configure_lacp(struct port *port, struct lacp_settings *s)
|
2011-04-13 17:58:26 -07:00
|
|
|
|
{
|
2011-11-29 19:03:52 -08:00
|
|
|
|
const char *lacp_time, *system_id;
|
2011-04-18 12:22:12 -07:00
|
|
|
|
long long int custom_time;
|
2011-04-15 09:40:50 -07:00
|
|
|
|
int priority;
|
2011-04-13 17:58:26 -07:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
if (!enable_lacp(port, &s->active)) {
|
|
|
|
|
return NULL;
|
2011-04-15 17:03:37 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
s->name = port->name;
|
2011-11-29 19:03:52 -08:00
|
|
|
|
|
|
|
|
|
system_id = get_port_other_config(port->cfg, "lacp-system-id", NULL);
|
|
|
|
|
if (!system_id
|
|
|
|
|
|| sscanf(system_id, ETH_ADDR_SCAN_FMT,
|
|
|
|
|
ETH_ADDR_SCAN_ARGS(s->id)) != ETH_ADDR_SCAN_COUNT) {
|
|
|
|
|
memcpy(s->id, port->bridge->ea, ETH_ADDR_LEN);
|
|
|
|
|
}
|
2011-04-15 09:40:50 -07:00
|
|
|
|
|
2011-11-29 13:22:18 -08:00
|
|
|
|
if (eth_addr_is_zero(s->id)) {
|
|
|
|
|
VLOG_WARN("port %s: Invalid zero LACP system ID.", port->name);
|
|
|
|
|
return NULL;
|
|
|
|
|
}
|
|
|
|
|
|
2011-04-15 09:40:50 -07:00
|
|
|
|
/* Prefer bondable links if unspecified. */
|
|
|
|
|
priority = atoi(get_port_other_config(port->cfg, "lacp-system-priority",
|
|
|
|
|
"0"));
|
2011-05-11 12:26:06 -07:00
|
|
|
|
s->priority = (priority > 0 && priority <= UINT16_MAX
|
|
|
|
|
? priority
|
|
|
|
|
: UINT16_MAX - !list_is_short(&port->ifaces));
|
2011-04-15 09:40:50 -07:00
|
|
|
|
|
2011-05-12 12:05:42 -07:00
|
|
|
|
s->heartbeat = !strcmp(get_port_other_config(port->cfg,
|
|
|
|
|
"lacp-heartbeat",
|
|
|
|
|
"false"), "true");
|
2011-04-15 09:40:50 -07:00
|
|
|
|
|
2011-04-18 12:22:12 -07:00
|
|
|
|
lacp_time = get_port_other_config(port->cfg, "lacp-time", "slow");
|
|
|
|
|
custom_time = atoi(lacp_time);
|
|
|
|
|
if (!strcmp(lacp_time, "fast")) {
|
2011-05-11 12:26:06 -07:00
|
|
|
|
s->lacp_time = LACP_TIME_FAST;
|
2011-04-18 12:22:12 -07:00
|
|
|
|
} else if (!strcmp(lacp_time, "slow")) {
|
2011-05-11 12:26:06 -07:00
|
|
|
|
s->lacp_time = LACP_TIME_SLOW;
|
2011-04-18 12:22:12 -07:00
|
|
|
|
} else if (custom_time > 0) {
|
2011-05-11 12:26:06 -07:00
|
|
|
|
s->lacp_time = LACP_TIME_CUSTOM;
|
|
|
|
|
s->custom_time = custom_time;
|
2011-04-18 12:22:12 -07:00
|
|
|
|
} else {
|
2011-05-11 12:26:06 -07:00
|
|
|
|
s->lacp_time = LACP_TIME_SLOW;
|
2011-04-18 12:22:12 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
return s;
|
|
|
|
|
}
|
2011-04-13 17:58:26 -07:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
static void
|
|
|
|
|
iface_configure_lacp(struct iface *iface, struct lacp_slave_settings *s)
|
|
|
|
|
{
|
2011-05-12 12:05:42 -07:00
|
|
|
|
int priority, portid, key;
|
2011-04-13 17:58:26 -07:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
portid = atoi(get_interface_other_config(iface->cfg, "lacp-port-id", "0"));
|
|
|
|
|
priority = atoi(get_interface_other_config(iface->cfg,
|
|
|
|
|
"lacp-port-priority", "0"));
|
2011-05-12 12:05:42 -07:00
|
|
|
|
key = atoi(get_interface_other_config(iface->cfg, "lacp-aggregation-key",
|
|
|
|
|
"0"));
|
2011-05-11 12:26:06 -07:00
|
|
|
|
|
|
|
|
|
if (portid <= 0 || portid > UINT16_MAX) {
|
2011-05-09 09:24:39 -07:00
|
|
|
|
portid = iface->ofp_port;
|
2011-04-13 17:58:26 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
if (priority <= 0 || priority > UINT16_MAX) {
|
|
|
|
|
priority = UINT16_MAX;
|
|
|
|
|
}
|
2011-04-13 17:58:26 -07:00
|
|
|
|
|
2011-05-12 12:05:42 -07:00
|
|
|
|
if (key < 0 || key > UINT16_MAX) {
|
|
|
|
|
key = 0;
|
2011-04-13 17:58:26 -07:00
|
|
|
|
}
|
2011-05-12 12:05:42 -07:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
s->name = iface->name;
|
|
|
|
|
s->id = portid;
|
|
|
|
|
s->priority = priority;
|
2011-05-12 12:05:42 -07:00
|
|
|
|
s->key = key;
|
2011-03-21 14:30:33 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-01-18 18:46:58 -08:00
|
|
|
|
static void
|
2011-05-13 16:47:01 -07:00
|
|
|
|
port_configure_bond(struct port *port, struct bond_settings *s,
|
|
|
|
|
uint32_t *bond_stable_ids)
|
2011-01-18 18:46:58 -08:00
|
|
|
|
{
|
2011-03-30 11:03:16 -07:00
|
|
|
|
const char *detect_s;
|
2011-03-21 12:49:44 -07:00
|
|
|
|
struct iface *iface;
|
2011-05-16 14:40:03 -07:00
|
|
|
|
int miimon_interval;
|
2011-05-13 16:47:01 -07:00
|
|
|
|
size_t i;
|
2011-01-18 18:46:58 -08:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
s->name = port->name;
|
|
|
|
|
s->balance = BM_SLB;
|
2011-12-15 13:39:38 -08:00
|
|
|
|
if (port->cfg->bond_mode) {
|
|
|
|
|
if (!bond_mode_from_string(&s->balance, port->cfg->bond_mode)) {
|
|
|
|
|
VLOG_WARN("port %s: unknown bond_mode %s, defaulting to %s",
|
|
|
|
|
port->name, port->cfg->bond_mode,
|
|
|
|
|
bond_mode_to_string(s->balance));
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 1);
|
|
|
|
|
|
|
|
|
|
/* XXX: Post version 1.4.*, change the default bond_mode to
|
|
|
|
|
* active-backup. Until then, warn that the change is imminent. */
|
|
|
|
|
VLOG_WARN_RL(&rl, "port %s: Using the default bond_mode %s. Note that"
|
|
|
|
|
" in future versions, the default bond_mode is expected"
|
|
|
|
|
" to change to active-backup", port->name,
|
|
|
|
|
bond_mode_to_string(s->balance));
|
2011-03-30 11:03:16 -07:00
|
|
|
|
}
|
2011-08-05 16:58:02 -07:00
|
|
|
|
if (s->balance == BM_SLB && port->bridge->cfg->n_flood_vlans) {
|
|
|
|
|
VLOG_WARN("port %s: SLB bonds are incompatible with flood_vlans, "
|
|
|
|
|
"please use another bond type or disable flood_vlans",
|
|
|
|
|
port->name);
|
|
|
|
|
}
|
2011-03-21 14:30:33 -07:00
|
|
|
|
|
2011-05-16 14:40:03 -07:00
|
|
|
|
miimon_interval = atoi(get_port_other_config(port->cfg,
|
|
|
|
|
"bond-miimon-interval", "0"));
|
|
|
|
|
if (miimon_interval <= 0) {
|
|
|
|
|
miimon_interval = 200;
|
2011-03-30 11:03:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-05-16 14:40:03 -07:00
|
|
|
|
detect_s = get_port_other_config(port->cfg, "bond-detect-mode", "carrier");
|
|
|
|
|
if (!strcmp(detect_s, "carrier")) {
|
|
|
|
|
miimon_interval = 0;
|
|
|
|
|
} else if (strcmp(detect_s, "miimon")) {
|
|
|
|
|
VLOG_WARN("port %s: unsupported bond-detect-mode %s, "
|
|
|
|
|
"defaulting to carrier", port->name, detect_s);
|
|
|
|
|
miimon_interval = 0;
|
2011-03-30 11:03:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
s->up_delay = MAX(0, port->cfg->bond_updelay);
|
|
|
|
|
s->down_delay = MAX(0, port->cfg->bond_downdelay);
|
2011-05-12 12:05:42 -07:00
|
|
|
|
s->basis = atoi(get_port_other_config(port->cfg, "bond-hash-basis", "0"));
|
2011-05-11 12:26:06 -07:00
|
|
|
|
s->rebalance_interval = atoi(
|
2011-03-30 11:03:16 -07:00
|
|
|
|
get_port_other_config(port->cfg, "bond-rebalance-interval", "10000"));
|
2011-05-11 12:26:06 -07:00
|
|
|
|
if (s->rebalance_interval < 1000) {
|
|
|
|
|
s->rebalance_interval = 1000;
|
2011-03-30 11:03:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
s->fake_iface = port->cfg->bond_fake_iface;
|
2011-03-21 12:49:44 -07:00
|
|
|
|
|
2011-05-13 16:47:01 -07:00
|
|
|
|
i = 0;
|
2011-03-21 12:49:44 -07:00
|
|
|
|
LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
|
2011-05-05 16:01:11 -07:00
|
|
|
|
long long stable_id;
|
|
|
|
|
|
|
|
|
|
stable_id = atoll(get_interface_other_config(iface->cfg,
|
|
|
|
|
"bond-stable-id", "0"));
|
|
|
|
|
if (stable_id <= 0 || stable_id >= UINT32_MAX) {
|
2011-05-13 16:47:01 -07:00
|
|
|
|
stable_id = iface->ofp_port;
|
2011-05-05 16:01:11 -07:00
|
|
|
|
}
|
2011-05-13 16:47:01 -07:00
|
|
|
|
bond_stable_ids[i++] = stable_id;
|
2011-05-16 14:40:03 -07:00
|
|
|
|
|
|
|
|
|
netdev_set_miimon_interval(iface->netdev, miimon_interval);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
2011-10-26 11:39:46 -07:00
|
|
|
|
|
|
|
|
|
/* Returns true if 'port' is synthetic, that is, if we constructed it locally
|
|
|
|
|
* instead of obtaining it from the database. */
|
|
|
|
|
static bool
|
|
|
|
|
port_is_synthetic(const struct port *port)
|
|
|
|
|
{
|
|
|
|
|
return ovsdb_idl_row_is_synthetic(&port->cfg->header_);
|
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
|
|
|
|
/* Interface functions. */
|
|
|
|
|
|
2009-12-03 11:28:40 -08:00
|
|
|
|
static struct iface *
|
2009-12-05 16:01:06 -08:00
|
|
|
|
iface_create(struct port *port, const struct ovsrec_interface *if_cfg)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2010-05-05 14:00:47 -07:00
|
|
|
|
struct bridge *br = port->bridge;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
struct iface *iface;
|
2009-12-05 16:01:06 -08:00
|
|
|
|
char *name = if_cfg->name;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2009-09-28 13:56:42 -07:00
|
|
|
|
iface = xzalloc(sizeof *iface);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
iface->port = port;
|
|
|
|
|
iface->name = xstrdup(name);
|
2011-05-09 09:24:39 -07:00
|
|
|
|
iface->ofp_port = -1;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
iface->tag = tag_create_random();
|
2009-07-30 16:00:41 -07:00
|
|
|
|
iface->netdev = NULL;
|
2010-01-12 16:01:43 -05:00
|
|
|
|
iface->cfg = if_cfg;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-04-01 11:42:25 -07:00
|
|
|
|
hmap_insert(&br->iface_by_name, &iface->name_node, hash_string(name, 0));
|
2010-05-10 13:34:41 -07:00
|
|
|
|
|
2011-03-21 10:24:32 -07:00
|
|
|
|
list_push_back(&port->ifaces, &iface->port_elem);
|
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
VLOG_DBG("attached network device %s to port %s", iface->name, port->name);
|
|
|
|
|
|
2009-12-03 11:28:40 -08:00
|
|
|
|
return iface;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
iface_destroy(struct iface *iface)
|
|
|
|
|
{
|
|
|
|
|
if (iface) {
|
|
|
|
|
struct port *port = iface->port;
|
|
|
|
|
struct bridge *br = port->bridge;
|
2011-03-21 13:25:02 -07:00
|
|
|
|
|
2011-05-09 09:24:39 -07:00
|
|
|
|
if (br->ofproto && iface->ofp_port >= 0) {
|
|
|
|
|
ofproto_port_unregister(br->ofproto, iface->ofp_port);
|
2011-04-13 17:58:26 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-05-09 09:24:39 -07:00
|
|
|
|
if (iface->ofp_port >= 0) {
|
|
|
|
|
hmap_remove(&br->ifaces, &iface->ofp_port_node);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-03-21 10:24:32 -07:00
|
|
|
|
list_remove(&iface->port_elem);
|
2011-04-01 11:42:25 -07:00
|
|
|
|
hmap_remove(&br->iface_by_name, &iface->name_node);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2009-07-30 16:00:41 -07:00
|
|
|
|
netdev_close(iface->netdev);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2009-12-05 16:01:06 -08:00
|
|
|
|
free(iface->name);
|
|
|
|
|
free(iface);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static struct iface *
|
|
|
|
|
iface_lookup(const struct bridge *br, const char *name)
|
|
|
|
|
{
|
2011-04-01 11:42:25 -07:00
|
|
|
|
struct iface *iface;
|
|
|
|
|
|
|
|
|
|
HMAP_FOR_EACH_WITH_HASH (iface, name_node, hash_string(name, 0),
|
|
|
|
|
&br->iface_by_name) {
|
|
|
|
|
if (!strcmp(iface->name, name)) {
|
|
|
|
|
return iface;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return NULL;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-03-11 13:44:16 -08:00
|
|
|
|
static struct iface *
|
|
|
|
|
iface_find(const char *name)
|
|
|
|
|
{
|
|
|
|
|
const struct bridge *br;
|
|
|
|
|
|
2011-04-04 14:11:16 -07:00
|
|
|
|
HMAP_FOR_EACH (br, node, &all_bridges) {
|
2011-03-11 13:44:16 -08:00
|
|
|
|
struct iface *iface = iface_lookup(br, name);
|
|
|
|
|
|
|
|
|
|
if (iface) {
|
|
|
|
|
return iface;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
return NULL;
|
|
|
|
|
}
|
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static struct iface *
|
2011-05-09 09:24:39 -07:00
|
|
|
|
iface_from_ofp_port(const struct bridge *br, uint16_t ofp_port)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2010-07-19 11:23:05 -07:00
|
|
|
|
struct iface *iface;
|
|
|
|
|
|
2011-05-09 09:24:39 -07:00
|
|
|
|
HMAP_FOR_EACH_IN_BUCKET (iface, ofp_port_node,
|
|
|
|
|
hash_int(ofp_port, 0), &br->ifaces) {
|
|
|
|
|
if (iface->ofp_port == ofp_port) {
|
2010-07-19 11:23:05 -07:00
|
|
|
|
return iface;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
return NULL;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2009-10-02 10:41:05 -07:00
|
|
|
|
|
2009-10-02 13:29:01 -07:00
|
|
|
|
/* Set Ethernet address of 'iface', if one is specified in the configuration
|
|
|
|
|
* file. */
|
|
|
|
|
static void
|
|
|
|
|
iface_set_mac(struct iface *iface)
|
|
|
|
|
{
|
2009-12-03 11:28:40 -08:00
|
|
|
|
uint8_t ea[ETH_ADDR_LEN];
|
2009-10-02 13:29:01 -07:00
|
|
|
|
|
2011-03-29 11:16:31 -07:00
|
|
|
|
if (!strcmp(iface->type, "internal")
|
|
|
|
|
&& iface->cfg->mac && eth_addr_from_string(iface->cfg->mac, ea)) {
|
2011-05-09 09:24:39 -07:00
|
|
|
|
if (iface->ofp_port == OFPP_LOCAL) {
|
2011-03-29 11:16:31 -07:00
|
|
|
|
VLOG_ERR("interface %s: ignoring mac in Interface record "
|
|
|
|
|
"(use Bridge record to set local port's mac)",
|
|
|
|
|
iface->name);
|
|
|
|
|
} else if (eth_addr_is_multicast(ea)) {
|
2009-10-02 13:29:01 -07:00
|
|
|
|
VLOG_ERR("interface %s: cannot set MAC to multicast address",
|
|
|
|
|
iface->name);
|
|
|
|
|
} else {
|
2009-10-05 10:29:07 -07:00
|
|
|
|
int error = netdev_set_etheraddr(iface->netdev, ea);
|
2009-10-02 13:29:01 -07:00
|
|
|
|
if (error) {
|
|
|
|
|
VLOG_ERR("interface %s: setting MAC failed (%s)",
|
|
|
|
|
iface->name, strerror(error));
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
2010-06-17 15:04:12 -07:00
|
|
|
|
|
2010-10-22 13:42:40 -07:00
|
|
|
|
/* Sets the ofport column of 'if_cfg' to 'ofport'. */
|
|
|
|
|
static void
|
|
|
|
|
iface_set_ofport(const struct ovsrec_interface *if_cfg, int64_t ofport)
|
|
|
|
|
{
|
2011-04-13 11:10:44 -07:00
|
|
|
|
if (if_cfg && !ovsdb_idl_row_is_synthetic(&if_cfg->header_)) {
|
2010-10-22 13:42:40 -07:00
|
|
|
|
ovsrec_interface_set_ofport(if_cfg, &ofport, 1);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2011-09-28 09:36:13 -07:00
|
|
|
|
/* Clears all of the fields in 'if_cfg' that indicate interface status, and
|
|
|
|
|
* sets the "ofport" field to -1.
|
|
|
|
|
*
|
|
|
|
|
* This is appropriate when 'if_cfg''s interface cannot be created or is
|
|
|
|
|
* otherwise invalid. */
|
|
|
|
|
static void
|
|
|
|
|
iface_clear_db_record(const struct ovsrec_interface *if_cfg)
|
|
|
|
|
{
|
|
|
|
|
if (!ovsdb_idl_row_is_synthetic(&if_cfg->header_)) {
|
|
|
|
|
iface_set_ofport(if_cfg, -1);
|
|
|
|
|
ovsrec_interface_set_status(if_cfg, NULL, NULL, 0);
|
|
|
|
|
ovsrec_interface_set_admin_state(if_cfg, NULL);
|
|
|
|
|
ovsrec_interface_set_duplex(if_cfg, NULL);
|
|
|
|
|
ovsrec_interface_set_link_speed(if_cfg, NULL, 0);
|
|
|
|
|
ovsrec_interface_set_link_state(if_cfg, NULL);
|
|
|
|
|
ovsrec_interface_set_mtu(if_cfg, NULL, 0);
|
|
|
|
|
ovsrec_interface_set_cfm_fault(if_cfg, NULL, 0);
|
|
|
|
|
ovsrec_interface_set_cfm_remote_mpids(if_cfg, NULL, 0);
|
|
|
|
|
ovsrec_interface_set_lacp_current(if_cfg, NULL, 0);
|
|
|
|
|
ovsrec_interface_set_statistics(if_cfg, NULL, NULL, 0);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2010-09-27 13:15:19 -07:00
|
|
|
|
/* Adds the 'n' key-value pairs in 'keys' in 'values' to 'shash'.
|
|
|
|
|
*
|
|
|
|
|
* The value strings in '*shash' are taken directly from values[], not copied,
|
|
|
|
|
* so the caller should not modify or free them. */
|
2010-06-17 15:04:12 -07:00
|
|
|
|
static void
|
|
|
|
|
shash_from_ovs_idl_map(char **keys, char **values, size_t n,
|
|
|
|
|
struct shash *shash)
|
|
|
|
|
{
|
|
|
|
|
size_t i;
|
|
|
|
|
|
|
|
|
|
shash_init(shash);
|
|
|
|
|
for (i = 0; i < n; i++) {
|
|
|
|
|
shash_add(shash, keys[i], values[i]);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2011-01-05 11:51:15 -08:00
|
|
|
|
/* Creates 'keys' and 'values' arrays from 'shash'.
|
|
|
|
|
*
|
|
|
|
|
* Sets 'keys' and 'values' to heap allocated arrays representing the key-value
|
|
|
|
|
* pairs in 'shash'. The caller takes ownership of 'keys' and 'values'. They
|
|
|
|
|
* are populated with with strings taken directly from 'shash' and thus have
|
|
|
|
|
* the same ownership of the key-value pairs in shash.
|
|
|
|
|
*/
|
|
|
|
|
static void
|
|
|
|
|
shash_to_ovs_idl_map(struct shash *shash,
|
|
|
|
|
char ***keys, char ***values, size_t *n)
|
|
|
|
|
{
|
|
|
|
|
size_t i, count;
|
|
|
|
|
char **k, **v;
|
|
|
|
|
struct shash_node *sn;
|
|
|
|
|
|
|
|
|
|
count = shash_count(shash);
|
|
|
|
|
|
|
|
|
|
k = xmalloc(count * sizeof *k);
|
|
|
|
|
v = xmalloc(count * sizeof *v);
|
|
|
|
|
|
|
|
|
|
i = 0;
|
|
|
|
|
SHASH_FOR_EACH(sn, shash) {
|
|
|
|
|
k[i] = sn->name;
|
|
|
|
|
v[i] = sn->data;
|
|
|
|
|
i++;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
*n = count;
|
|
|
|
|
*keys = k;
|
|
|
|
|
*values = v;
|
|
|
|
|
}
|
|
|
|
|
|
2010-06-17 15:04:12 -07:00
|
|
|
|
struct iface_delete_queues_cbdata {
|
|
|
|
|
struct netdev *netdev;
|
2010-06-17 15:43:27 -07:00
|
|
|
|
const struct ovsdb_datum *queues;
|
2010-06-17 15:04:12 -07:00
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
static bool
|
2010-06-17 15:43:27 -07:00
|
|
|
|
queue_ids_include(const struct ovsdb_datum *queues, int64_t target)
|
2010-06-17 15:04:12 -07:00
|
|
|
|
{
|
2010-06-17 15:43:27 -07:00
|
|
|
|
union ovsdb_atom atom;
|
2010-06-17 15:04:12 -07:00
|
|
|
|
|
2010-06-17 15:43:27 -07:00
|
|
|
|
atom.integer = target;
|
|
|
|
|
return ovsdb_datum_find_key(queues, &atom, OVSDB_TYPE_INTEGER) != UINT_MAX;
|
2010-06-17 15:04:12 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
iface_delete_queues(unsigned int queue_id,
|
|
|
|
|
const struct shash *details OVS_UNUSED, void *cbdata_)
|
|
|
|
|
{
|
|
|
|
|
struct iface_delete_queues_cbdata *cbdata = cbdata_;
|
|
|
|
|
|
2010-06-17 15:43:27 -07:00
|
|
|
|
if (!queue_ids_include(cbdata->queues, queue_id)) {
|
2010-06-17 15:04:12 -07:00
|
|
|
|
netdev_delete_queue(cbdata->netdev, queue_id);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
2011-04-08 13:50:21 -07:00
|
|
|
|
iface_configure_qos(struct iface *iface, const struct ovsrec_qos *qos)
|
2010-06-17 15:04:12 -07:00
|
|
|
|
{
|
2011-11-16 16:31:05 -08:00
|
|
|
|
struct ofpbuf queues_buf;
|
|
|
|
|
|
|
|
|
|
ofpbuf_init(&queues_buf, 0);
|
|
|
|
|
|
2011-05-06 17:02:02 -07:00
|
|
|
|
if (!qos || qos->type[0] == '\0' || qos->n_queues < 1) {
|
2010-06-17 15:04:12 -07:00
|
|
|
|
netdev_set_qos(iface->netdev, NULL, NULL);
|
|
|
|
|
} else {
|
|
|
|
|
struct iface_delete_queues_cbdata cbdata;
|
|
|
|
|
struct shash details;
|
2011-07-20 10:41:16 -07:00
|
|
|
|
bool queue_zero;
|
2010-06-17 15:04:12 -07:00
|
|
|
|
size_t i;
|
|
|
|
|
|
|
|
|
|
/* Configure top-level Qos for 'iface'. */
|
|
|
|
|
shash_from_ovs_idl_map(qos->key_other_config, qos->value_other_config,
|
|
|
|
|
qos->n_other_config, &details);
|
|
|
|
|
netdev_set_qos(iface->netdev, qos->type, &details);
|
|
|
|
|
shash_destroy(&details);
|
|
|
|
|
|
|
|
|
|
/* Deconfigure queues that were deleted. */
|
|
|
|
|
cbdata.netdev = iface->netdev;
|
2010-06-17 15:43:27 -07:00
|
|
|
|
cbdata.queues = ovsrec_qos_get_queues(qos, OVSDB_TYPE_INTEGER,
|
|
|
|
|
OVSDB_TYPE_UUID);
|
2010-06-17 15:04:12 -07:00
|
|
|
|
netdev_dump_queues(iface->netdev, iface_delete_queues, &cbdata);
|
|
|
|
|
|
|
|
|
|
/* Configure queues for 'iface'. */
|
2011-07-20 10:41:16 -07:00
|
|
|
|
queue_zero = false;
|
2010-06-17 15:04:12 -07:00
|
|
|
|
for (i = 0; i < qos->n_queues; i++) {
|
|
|
|
|
const struct ovsrec_queue *queue = qos->value_queues[i];
|
|
|
|
|
unsigned int queue_id = qos->key_queues[i];
|
|
|
|
|
|
2011-07-20 10:41:16 -07:00
|
|
|
|
if (queue_id == 0) {
|
|
|
|
|
queue_zero = true;
|
|
|
|
|
}
|
|
|
|
|
|
2011-11-16 16:31:05 -08:00
|
|
|
|
if (queue->n_dscp == 1) {
|
|
|
|
|
struct ofproto_port_queue *port_queue;
|
|
|
|
|
|
|
|
|
|
port_queue = ofpbuf_put_uninit(&queues_buf,
|
|
|
|
|
sizeof *port_queue);
|
|
|
|
|
port_queue->queue = queue_id;
|
|
|
|
|
port_queue->dscp = queue->dscp[0];
|
|
|
|
|
}
|
|
|
|
|
|
2010-06-17 15:04:12 -07:00
|
|
|
|
shash_from_ovs_idl_map(queue->key_other_config,
|
|
|
|
|
queue->value_other_config,
|
|
|
|
|
queue->n_other_config, &details);
|
|
|
|
|
netdev_set_queue(iface->netdev, queue_id, &details);
|
|
|
|
|
shash_destroy(&details);
|
|
|
|
|
}
|
2011-07-20 10:41:16 -07:00
|
|
|
|
if (!queue_zero) {
|
|
|
|
|
static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 1);
|
|
|
|
|
VLOG_WARN_RL(&rl, "interface %s: QoS configured without a default "
|
|
|
|
|
"queue (queue 0). Packets not directed to a "
|
|
|
|
|
"correctly configured queue may be dropped.",
|
|
|
|
|
iface->name);
|
|
|
|
|
}
|
2010-06-17 15:04:12 -07:00
|
|
|
|
}
|
2011-05-11 12:26:06 -07:00
|
|
|
|
|
2011-11-16 16:31:05 -08:00
|
|
|
|
if (iface->ofp_port >= 0) {
|
|
|
|
|
const struct ofproto_port_queue *port_queues = queues_buf.data;
|
|
|
|
|
size_t n_queues = queues_buf.size / sizeof *port_queues;
|
|
|
|
|
|
|
|
|
|
ofproto_port_set_queues(iface->port->bridge->ofproto, iface->ofp_port,
|
|
|
|
|
port_queues, n_queues);
|
|
|
|
|
}
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
netdev_set_policing(iface->netdev,
|
|
|
|
|
iface->cfg->ingress_policing_rate,
|
|
|
|
|
iface->cfg->ingress_policing_burst);
|
2011-11-16 16:31:05 -08:00
|
|
|
|
|
|
|
|
|
ofpbuf_uninit(&queues_buf);
|
2010-06-17 15:04:12 -07:00
|
|
|
|
}
|
2010-11-15 16:20:01 -08:00
|
|
|
|
|
|
|
|
|
static void
|
2011-04-08 13:50:21 -07:00
|
|
|
|
iface_configure_cfm(struct iface *iface)
|
2010-11-15 16:20:01 -08:00
|
|
|
|
{
|
2011-05-12 15:28:43 -07:00
|
|
|
|
const struct ovsrec_interface *cfg = iface->cfg;
|
2011-10-06 22:43:05 -07:00
|
|
|
|
const char *extended_str, *opstate_str;
|
2011-05-13 15:37:23 -07:00
|
|
|
|
struct cfm_settings s;
|
2010-11-15 16:20:01 -08:00
|
|
|
|
|
2011-08-19 13:58:56 -07:00
|
|
|
|
if (!cfg->n_cfm_mpid) {
|
2011-05-09 09:24:39 -07:00
|
|
|
|
ofproto_port_clear_cfm(iface->port->bridge->ofproto, iface->ofp_port);
|
2010-11-15 16:20:01 -08:00
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2011-05-13 15:37:23 -07:00
|
|
|
|
s.mpid = *cfg->cfm_mpid;
|
|
|
|
|
s.interval = atoi(get_interface_other_config(iface->cfg, "cfm_interval",
|
|
|
|
|
"0"));
|
2011-11-03 13:03:16 -07:00
|
|
|
|
s.ccm_vlan = atoi(get_interface_other_config(iface->cfg, "cfm_ccm_vlan",
|
|
|
|
|
"0"));
|
2011-05-13 15:37:23 -07:00
|
|
|
|
if (s.interval <= 0) {
|
|
|
|
|
s.interval = 1000;
|
2010-11-15 16:20:01 -08:00
|
|
|
|
}
|
|
|
|
|
|
2011-08-30 17:37:06 -07:00
|
|
|
|
extended_str = get_interface_other_config(iface->cfg, "cfm_extended",
|
|
|
|
|
"false");
|
|
|
|
|
s.extended = !strcasecmp("true", extended_str);
|
|
|
|
|
|
2011-10-06 22:43:05 -07:00
|
|
|
|
opstate_str = get_interface_other_config(iface->cfg, "cfm_opstate", "up");
|
|
|
|
|
s.opup = !strcasecmp("up", opstate_str);
|
|
|
|
|
|
2011-05-13 15:37:23 -07:00
|
|
|
|
ofproto_port_set_cfm(iface->port->bridge->ofproto, iface->ofp_port, &s);
|
2010-11-15 16:20:01 -08:00
|
|
|
|
}
|
2011-03-17 10:48:05 -07:00
|
|
|
|
|
2011-04-13 11:10:44 -07:00
|
|
|
|
/* Returns true if 'iface' is synthetic, that is, if we constructed it locally
|
|
|
|
|
* instead of obtaining it from the database. */
|
|
|
|
|
static bool
|
|
|
|
|
iface_is_synthetic(const struct iface *iface)
|
|
|
|
|
{
|
|
|
|
|
return ovsdb_idl_row_is_synthetic(&iface->cfg->header_);
|
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
|
|
|
|
/* Port mirroring. */
|
|
|
|
|
|
2010-06-17 15:31:56 -07:00
|
|
|
|
static struct mirror *
|
|
|
|
|
mirror_find_by_uuid(struct bridge *br, const struct uuid *uuid)
|
|
|
|
|
{
|
2011-05-11 12:26:06 -07:00
|
|
|
|
struct mirror *m;
|
2010-06-17 15:31:56 -07:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
HMAP_FOR_EACH_IN_BUCKET (m, hmap_node, uuid_hash(uuid), &br->mirrors) {
|
|
|
|
|
if (uuid_equals(uuid, &m->uuid)) {
|
2010-06-17 15:31:56 -07:00
|
|
|
|
return m;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
return NULL;
|
|
|
|
|
}
|
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static void
|
2011-05-11 12:26:06 -07:00
|
|
|
|
bridge_configure_mirrors(struct bridge *br)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2011-05-11 12:26:06 -07:00
|
|
|
|
const struct ovsdb_datum *mc;
|
|
|
|
|
unsigned long *flood_vlans;
|
|
|
|
|
struct mirror *m, *next;
|
|
|
|
|
size_t i;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2010-06-17 15:31:56 -07:00
|
|
|
|
/* Get rid of deleted mirrors. */
|
2011-05-11 12:26:06 -07:00
|
|
|
|
mc = ovsrec_bridge_get_mirrors(br->cfg, OVSDB_TYPE_UUID);
|
|
|
|
|
HMAP_FOR_EACH_SAFE (m, next, hmap_node, &br->mirrors) {
|
|
|
|
|
union ovsdb_atom atom;
|
|
|
|
|
|
|
|
|
|
atom.uuid = m->uuid;
|
|
|
|
|
if (ovsdb_datum_find_key(mc, &atom, OVSDB_TYPE_UUID) == UINT_MAX) {
|
|
|
|
|
mirror_destroy(m);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2010-06-17 15:31:56 -07:00
|
|
|
|
/* Add new mirrors and reconfigure existing ones. */
|
2010-01-19 10:40:36 -08:00
|
|
|
|
for (i = 0; i < br->cfg->n_mirrors; i++) {
|
2011-05-11 12:26:06 -07:00
|
|
|
|
const struct ovsrec_mirror *cfg = br->cfg->mirrors[i];
|
2010-06-17 15:31:56 -07:00
|
|
|
|
struct mirror *m = mirror_find_by_uuid(br, &cfg->header_.uuid);
|
2011-05-11 12:26:06 -07:00
|
|
|
|
if (!m) {
|
|
|
|
|
m = mirror_create(br, cfg);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2011-11-20 15:12:36 -08:00
|
|
|
|
m->cfg = cfg;
|
|
|
|
|
if (!mirror_configure(m)) {
|
2011-05-11 12:26:06 -07:00
|
|
|
|
mirror_destroy(m);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
2009-11-06 17:13:51 -08:00
|
|
|
|
|
2010-01-19 10:41:46 -08:00
|
|
|
|
/* Update flooded vlans (for RSPAN). */
|
2011-05-11 12:26:06 -07:00
|
|
|
|
flood_vlans = vlan_bitmap_from_array(br->cfg->flood_vlans,
|
|
|
|
|
br->cfg->n_flood_vlans);
|
|
|
|
|
ofproto_set_flood_vlans(br->ofproto, flood_vlans);
|
|
|
|
|
bitmap_free(flood_vlans);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
static struct mirror *
|
|
|
|
|
mirror_create(struct bridge *br, const struct ovsrec_mirror *cfg)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
|
|
|
|
struct mirror *m;
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
m = xzalloc(sizeof *m);
|
2011-04-05 14:17:55 -07:00
|
|
|
|
m->uuid = cfg->header_.uuid;
|
2011-05-11 12:26:06 -07:00
|
|
|
|
hmap_insert(&br->mirrors, &m->hmap_node, uuid_hash(&m->uuid));
|
2009-07-08 13:19:16 -07:00
|
|
|
|
m->bridge = br;
|
2010-06-17 15:31:56 -07:00
|
|
|
|
m->name = xstrdup(cfg->name);
|
2010-01-19 10:40:36 -08:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
return m;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
mirror_destroy(struct mirror *m)
|
|
|
|
|
{
|
|
|
|
|
if (m) {
|
|
|
|
|
struct bridge *br = m->bridge;
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
if (br->ofproto) {
|
|
|
|
|
ofproto_mirror_unregister(br->ofproto, m);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
hmap_remove(&br->mirrors, &m->hmap_node);
|
2010-06-17 15:32:09 -07:00
|
|
|
|
free(m->name);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
free(m);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
2011-05-11 12:26:06 -07:00
|
|
|
|
mirror_collect_ports(struct mirror *m,
|
|
|
|
|
struct ovsrec_port **in_ports, int n_in_ports,
|
|
|
|
|
void ***out_portsp, size_t *n_out_portsp)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2011-05-11 12:26:06 -07:00
|
|
|
|
void **out_ports = xmalloc(n_in_ports * sizeof *out_ports);
|
|
|
|
|
size_t n_out_ports = 0;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
size_t i;
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
for (i = 0; i < n_in_ports; i++) {
|
|
|
|
|
const char *name = in_ports[i]->name;
|
|
|
|
|
struct port *port = port_lookup(m->bridge, name);
|
|
|
|
|
if (port) {
|
|
|
|
|
out_ports[n_out_ports++] = port;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
} else {
|
2010-01-19 10:40:36 -08:00
|
|
|
|
VLOG_WARN("bridge %s: mirror %s cannot match on nonexistent "
|
|
|
|
|
"port %s", m->bridge->name, m->name, name);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
2011-05-11 12:26:06 -07:00
|
|
|
|
*out_portsp = out_ports;
|
|
|
|
|
*n_out_portsp = n_out_ports;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static bool
|
2011-11-20 15:12:36 -08:00
|
|
|
|
mirror_configure(struct mirror *m)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2011-11-20 15:12:36 -08:00
|
|
|
|
const struct ovsrec_mirror *cfg = m->cfg;
|
2011-05-11 12:26:06 -07:00
|
|
|
|
struct ofproto_mirror_settings s;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2010-06-17 15:31:56 -07:00
|
|
|
|
/* Set name. */
|
|
|
|
|
if (strcmp(cfg->name, m->name)) {
|
|
|
|
|
free(m->name);
|
|
|
|
|
m->name = xstrdup(cfg->name);
|
|
|
|
|
}
|
2011-05-11 12:26:06 -07:00
|
|
|
|
s.name = m->name;
|
2010-06-17 15:31:56 -07:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
/* Get output port or VLAN. */
|
2010-01-19 10:40:36 -08:00
|
|
|
|
if (cfg->output_port) {
|
2011-05-11 12:26:06 -07:00
|
|
|
|
s.out_bundle = port_lookup(m->bridge, cfg->output_port->name);
|
2011-05-11 12:13:10 -07:00
|
|
|
|
if (!s.out_bundle) {
|
2010-01-19 10:40:36 -08:00
|
|
|
|
VLOG_ERR("bridge %s: mirror %s outputs to port not on bridge",
|
|
|
|
|
m->bridge->name, m->name);
|
2011-05-11 12:26:06 -07:00
|
|
|
|
return false;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2011-05-11 12:26:06 -07:00
|
|
|
|
s.out_vlan = UINT16_MAX;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2010-01-19 10:40:36 -08:00
|
|
|
|
if (cfg->output_vlan) {
|
|
|
|
|
VLOG_ERR("bridge %s: mirror %s specifies both output port and "
|
|
|
|
|
"output vlan; ignoring output vlan",
|
|
|
|
|
m->bridge->name, m->name);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2010-01-19 10:40:36 -08:00
|
|
|
|
} else if (cfg->output_vlan) {
|
2011-05-11 12:26:06 -07:00
|
|
|
|
/* The database should prevent invalid VLAN values. */
|
|
|
|
|
s.out_bundle = NULL;
|
|
|
|
|
s.out_vlan = *cfg->output_vlan;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
} else {
|
2010-01-19 10:40:36 -08:00
|
|
|
|
VLOG_ERR("bridge %s: mirror %s does not specify output; ignoring",
|
|
|
|
|
m->bridge->name, m->name);
|
2011-05-11 12:26:06 -07:00
|
|
|
|
return false;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
/* Get port selection. */
|
2010-03-15 15:23:22 -07:00
|
|
|
|
if (cfg->select_all) {
|
2011-05-11 12:26:06 -07:00
|
|
|
|
size_t n_ports = hmap_count(&m->bridge->ports);
|
|
|
|
|
void **ports = xmalloc(n_ports * sizeof *ports);
|
2011-05-11 12:13:10 -07:00
|
|
|
|
struct port *port;
|
2011-05-11 12:26:06 -07:00
|
|
|
|
size_t i;
|
|
|
|
|
|
|
|
|
|
i = 0;
|
2011-03-21 10:07:39 -07:00
|
|
|
|
HMAP_FOR_EACH (port, hmap_node, &m->bridge->ports) {
|
2011-05-11 12:26:06 -07:00
|
|
|
|
ports[i++] = port;
|
2010-03-15 15:23:22 -07:00
|
|
|
|
}
|
2011-05-11 12:26:06 -07:00
|
|
|
|
|
|
|
|
|
s.srcs = ports;
|
|
|
|
|
s.n_srcs = n_ports;
|
|
|
|
|
|
|
|
|
|
s.dsts = ports;
|
|
|
|
|
s.n_dsts = n_ports;
|
2010-03-15 15:23:22 -07:00
|
|
|
|
} else {
|
2011-05-11 12:26:06 -07:00
|
|
|
|
/* Get ports, dropping ports that don't exist.
|
|
|
|
|
* The IDL ensures that there are no duplicates. */
|
2010-03-15 15:23:22 -07:00
|
|
|
|
mirror_collect_ports(m, cfg->select_src_port, cfg->n_select_src_port,
|
2011-05-11 12:26:06 -07:00
|
|
|
|
&s.srcs, &s.n_srcs);
|
2010-03-15 15:23:22 -07:00
|
|
|
|
mirror_collect_ports(m, cfg->select_dst_port, cfg->n_select_dst_port,
|
2011-05-11 12:26:06 -07:00
|
|
|
|
&s.dsts, &s.n_dsts);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
/* Get VLAN selection. */
|
|
|
|
|
s.src_vlans = vlan_bitmap_from_array(cfg->select_vlan, cfg->n_select_vlan);
|
|
|
|
|
|
|
|
|
|
/* Configure. */
|
|
|
|
|
ofproto_mirror_register(m->bridge->ofproto, m, &s);
|
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
/* Clean up. */
|
2011-05-11 12:26:06 -07:00
|
|
|
|
if (s.srcs != s.dsts) {
|
|
|
|
|
free(s.dsts);
|
|
|
|
|
}
|
|
|
|
|
free(s.srcs);
|
|
|
|
|
free(s.src_vlans);
|
|
|
|
|
|
|
|
|
|
return true;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2011-11-23 17:03:31 -08:00
|
|
|
|
|
|
|
|
|
/* Linux VLAN device support (e.g. "eth0.10" for VLAN 10.)
|
|
|
|
|
*
|
|
|
|
|
* This is deprecated. It is only for compatibility with broken device drivers
|
|
|
|
|
* in old versions of Linux that do not properly support VLANs when VLAN
|
|
|
|
|
* devices are not used. When broken device drivers are no longer in
|
|
|
|
|
* widespread use, we will delete these interfaces. */
|
|
|
|
|
|
|
|
|
|
static void **blocks;
|
|
|
|
|
static size_t n_blocks, allocated_blocks;
|
|
|
|
|
|
|
|
|
|
/* Adds 'block' to a list of blocks that have to be freed with free() when the
|
|
|
|
|
* VLAN splinters are reconfigured. */
|
|
|
|
|
static void
|
|
|
|
|
register_block(void *block)
|
|
|
|
|
{
|
|
|
|
|
if (n_blocks >= allocated_blocks) {
|
|
|
|
|
blocks = x2nrealloc(blocks, &allocated_blocks, sizeof *blocks);
|
|
|
|
|
}
|
|
|
|
|
blocks[n_blocks++] = block;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Frees all of the blocks registered with register_block(). */
|
|
|
|
|
static void
|
|
|
|
|
free_registered_blocks(void)
|
|
|
|
|
{
|
|
|
|
|
size_t i;
|
|
|
|
|
|
|
|
|
|
for (i = 0; i < n_blocks; i++) {
|
|
|
|
|
free(blocks[i]);
|
|
|
|
|
}
|
|
|
|
|
n_blocks = 0;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Returns true if VLAN splinters are enabled on 'iface_cfg', false
|
|
|
|
|
* otherwise. */
|
|
|
|
|
static bool
|
|
|
|
|
vlan_splinters_is_enabled(const struct ovsrec_interface *iface_cfg)
|
|
|
|
|
{
|
|
|
|
|
const char *value;
|
|
|
|
|
|
|
|
|
|
value = get_interface_other_config(iface_cfg, "enable-vlan-splinters", "");
|
|
|
|
|
return !strcmp(value, "true");
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Figures out the set of VLANs that are in use for the purpose of VLAN
|
|
|
|
|
* splinters.
|
|
|
|
|
*
|
|
|
|
|
* If VLAN splinters are enabled on at least one interface and any VLANs are in
|
|
|
|
|
* use, returns a 4096-bit bitmap with a 1-bit for each in-use VLAN (bits 0 and
|
|
|
|
|
* 4095 will not be set). The caller is responsible for freeing the bitmap,
|
|
|
|
|
* with free().
|
|
|
|
|
*
|
|
|
|
|
* If VLANs splinters are not enabled on any interface or if no VLANs are in
|
|
|
|
|
* use, returns NULL.
|
|
|
|
|
*
|
|
|
|
|
* Updates 'vlan_splinters_enabled_anywhere'. */
|
|
|
|
|
static unsigned long int *
|
|
|
|
|
collect_splinter_vlans(const struct ovsrec_open_vswitch *ovs_cfg)
|
|
|
|
|
{
|
|
|
|
|
unsigned long int *splinter_vlans;
|
|
|
|
|
struct sset splinter_ifaces;
|
|
|
|
|
const char *real_dev_name;
|
|
|
|
|
struct shash *real_devs;
|
|
|
|
|
struct shash_node *node;
|
|
|
|
|
struct bridge *br;
|
|
|
|
|
size_t i;
|
|
|
|
|
|
2011-12-09 15:57:55 -08:00
|
|
|
|
/* Free space allocated for synthesized ports and interfaces, since we're
|
|
|
|
|
* in the process of reconstructing all of them. */
|
|
|
|
|
free_registered_blocks();
|
|
|
|
|
|
2011-11-23 17:03:31 -08:00
|
|
|
|
splinter_vlans = NULL;
|
|
|
|
|
sset_init(&splinter_ifaces);
|
|
|
|
|
for (i = 0; i < ovs_cfg->n_bridges; i++) {
|
|
|
|
|
struct ovsrec_bridge *br_cfg = ovs_cfg->bridges[i];
|
|
|
|
|
size_t j;
|
|
|
|
|
|
|
|
|
|
for (j = 0; j < br_cfg->n_ports; j++) {
|
|
|
|
|
struct ovsrec_port *port_cfg = br_cfg->ports[j];
|
|
|
|
|
int k;
|
|
|
|
|
|
|
|
|
|
for (k = 0; k < port_cfg->n_interfaces; k++) {
|
|
|
|
|
struct ovsrec_interface *iface_cfg = port_cfg->interfaces[k];
|
|
|
|
|
|
|
|
|
|
if (vlan_splinters_is_enabled(iface_cfg)) {
|
|
|
|
|
sset_add(&splinter_ifaces, iface_cfg->name);
|
|
|
|
|
|
|
|
|
|
if (!splinter_vlans) {
|
|
|
|
|
splinter_vlans = bitmap_allocate(4096);
|
|
|
|
|
}
|
|
|
|
|
vlan_bitmap_from_array__(port_cfg->trunks,
|
|
|
|
|
port_cfg->n_trunks,
|
|
|
|
|
splinter_vlans);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
vlan_splinters_enabled_anywhere = splinter_vlans != NULL;
|
|
|
|
|
if (!splinter_vlans) {
|
|
|
|
|
sset_destroy(&splinter_ifaces);
|
|
|
|
|
return NULL;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
HMAP_FOR_EACH (br, node, &all_bridges) {
|
|
|
|
|
if (br->ofproto) {
|
|
|
|
|
ofproto_get_vlan_usage(br->ofproto, splinter_vlans);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Don't allow VLANs 0 or 4095 to be splintered. VLAN 0 should appear on
|
|
|
|
|
* the real device. VLAN 4095 is reserved and Linux doesn't allow a VLAN
|
|
|
|
|
* device to be created for it. */
|
|
|
|
|
bitmap_set0(splinter_vlans, 0);
|
|
|
|
|
bitmap_set0(splinter_vlans, 4095);
|
|
|
|
|
|
|
|
|
|
/* Delete all VLAN devices that we don't need. */
|
|
|
|
|
vlandev_refresh();
|
|
|
|
|
real_devs = vlandev_get_real_devs();
|
|
|
|
|
SHASH_FOR_EACH (node, real_devs) {
|
|
|
|
|
const struct vlan_real_dev *real_dev = node->data;
|
|
|
|
|
const struct vlan_dev *vlan_dev;
|
|
|
|
|
bool real_dev_has_splinters;
|
|
|
|
|
|
|
|
|
|
real_dev_has_splinters = sset_contains(&splinter_ifaces,
|
|
|
|
|
real_dev->name);
|
|
|
|
|
HMAP_FOR_EACH (vlan_dev, hmap_node, &real_dev->vlan_devs) {
|
|
|
|
|
if (!real_dev_has_splinters
|
|
|
|
|
|| !bitmap_is_set(splinter_vlans, vlan_dev->vid)) {
|
|
|
|
|
struct netdev *netdev;
|
|
|
|
|
|
|
|
|
|
if (!netdev_open(vlan_dev->name, "system", &netdev)) {
|
|
|
|
|
if (!netdev_get_in4(netdev, NULL, NULL) ||
|
|
|
|
|
!netdev_get_in6(netdev, NULL)) {
|
|
|
|
|
vlandev_del(vlan_dev->name);
|
|
|
|
|
} else {
|
|
|
|
|
/* It has an IP address configured, so we don't own
|
|
|
|
|
* it. Don't delete it. */
|
|
|
|
|
}
|
|
|
|
|
netdev_close(netdev);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Add all VLAN devices that we need. */
|
|
|
|
|
SSET_FOR_EACH (real_dev_name, &splinter_ifaces) {
|
|
|
|
|
int vid;
|
|
|
|
|
|
|
|
|
|
BITMAP_FOR_EACH_1 (vid, 4096, splinter_vlans) {
|
|
|
|
|
if (!vlandev_get_name(real_dev_name, vid)) {
|
|
|
|
|
vlandev_add(real_dev_name, vid);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
vlandev_refresh();
|
|
|
|
|
|
|
|
|
|
sset_destroy(&splinter_ifaces);
|
|
|
|
|
|
|
|
|
|
if (bitmap_scan(splinter_vlans, 0, 4096) >= 4096) {
|
|
|
|
|
free(splinter_vlans);
|
|
|
|
|
return NULL;
|
|
|
|
|
}
|
|
|
|
|
return splinter_vlans;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Pushes the configure of VLAN splinter port 'port' (e.g. eth0.9) down to
|
|
|
|
|
* ofproto. */
|
|
|
|
|
static void
|
|
|
|
|
configure_splinter_port(struct port *port)
|
|
|
|
|
{
|
|
|
|
|
struct ofproto *ofproto = port->bridge->ofproto;
|
|
|
|
|
uint16_t realdev_ofp_port;
|
|
|
|
|
const char *realdev_name;
|
|
|
|
|
struct iface *vlandev, *realdev;
|
|
|
|
|
|
|
|
|
|
ofproto_bundle_unregister(port->bridge->ofproto, port);
|
|
|
|
|
|
|
|
|
|
vlandev = CONTAINER_OF(list_front(&port->ifaces), struct iface,
|
|
|
|
|
port_elem);
|
|
|
|
|
|
|
|
|
|
realdev_name = get_port_other_config(port->cfg, "realdev", NULL);
|
|
|
|
|
realdev = iface_lookup(port->bridge, realdev_name);
|
|
|
|
|
realdev_ofp_port = realdev ? realdev->ofp_port : 0;
|
|
|
|
|
|
|
|
|
|
ofproto_port_set_realdev(ofproto, vlandev->ofp_port, realdev_ofp_port,
|
|
|
|
|
*port->cfg->tag);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static struct ovsrec_port *
|
|
|
|
|
synthesize_splinter_port(const char *real_dev_name,
|
|
|
|
|
const char *vlan_dev_name, int vid)
|
|
|
|
|
{
|
|
|
|
|
struct ovsrec_interface *iface;
|
|
|
|
|
struct ovsrec_port *port;
|
|
|
|
|
|
|
|
|
|
iface = xzalloc(sizeof *iface);
|
|
|
|
|
iface->name = xstrdup(vlan_dev_name);
|
|
|
|
|
iface->type = "system";
|
|
|
|
|
|
|
|
|
|
port = xzalloc(sizeof *port);
|
|
|
|
|
port->interfaces = xmemdup(&iface, sizeof iface);
|
|
|
|
|
port->n_interfaces = 1;
|
|
|
|
|
port->name = xstrdup(vlan_dev_name);
|
|
|
|
|
port->vlan_mode = "splinter";
|
|
|
|
|
port->tag = xmalloc(sizeof *port->tag);
|
|
|
|
|
*port->tag = vid;
|
|
|
|
|
port->key_other_config = xmalloc(sizeof *port->key_other_config);
|
|
|
|
|
port->key_other_config[0] = "realdev";
|
|
|
|
|
port->value_other_config = xmalloc(sizeof *port->value_other_config);
|
|
|
|
|
port->value_other_config[0] = xstrdup(real_dev_name);
|
|
|
|
|
port->n_other_config = 1;
|
|
|
|
|
|
|
|
|
|
register_block(iface);
|
|
|
|
|
register_block(iface->name);
|
|
|
|
|
register_block(port);
|
|
|
|
|
register_block(port->interfaces);
|
|
|
|
|
register_block(port->name);
|
|
|
|
|
register_block(port->tag);
|
|
|
|
|
register_block(port->key_other_config);
|
|
|
|
|
register_block(port->value_other_config);
|
|
|
|
|
register_block(port->value_other_config[0]);
|
|
|
|
|
|
|
|
|
|
return port;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* For each interface with 'br' that has VLAN splinters enabled, adds a
|
|
|
|
|
* corresponding ovsrec_port to 'ports' for each splinter VLAN marked with a
|
|
|
|
|
* 1-bit in the 'splinter_vlans' bitmap. */
|
|
|
|
|
static void
|
|
|
|
|
add_vlan_splinter_ports(struct bridge *br,
|
|
|
|
|
const unsigned long int *splinter_vlans,
|
|
|
|
|
struct shash *ports)
|
|
|
|
|
{
|
|
|
|
|
size_t i;
|
|
|
|
|
|
|
|
|
|
/* We iterate through 'br->cfg->ports' instead of 'ports' here because
|
|
|
|
|
* we're modifying 'ports'. */
|
|
|
|
|
for (i = 0; i < br->cfg->n_ports; i++) {
|
|
|
|
|
const char *name = br->cfg->ports[i]->name;
|
|
|
|
|
struct ovsrec_port *port_cfg = shash_find_data(ports, name);
|
|
|
|
|
size_t j;
|
|
|
|
|
|
|
|
|
|
for (j = 0; j < port_cfg->n_interfaces; j++) {
|
|
|
|
|
struct ovsrec_interface *iface_cfg = port_cfg->interfaces[j];
|
|
|
|
|
|
|
|
|
|
if (vlan_splinters_is_enabled(iface_cfg)) {
|
|
|
|
|
const char *real_dev_name;
|
|
|
|
|
uint16_t vid;
|
|
|
|
|
|
|
|
|
|
real_dev_name = iface_cfg->name;
|
|
|
|
|
BITMAP_FOR_EACH_1 (vid, 4096, splinter_vlans) {
|
|
|
|
|
const char *vlan_dev_name;
|
|
|
|
|
|
|
|
|
|
vlan_dev_name = vlandev_get_name(real_dev_name, vid);
|
|
|
|
|
if (vlan_dev_name
|
|
|
|
|
&& !shash_find(ports, vlan_dev_name)) {
|
|
|
|
|
shash_add(ports, vlan_dev_name,
|
|
|
|
|
synthesize_splinter_port(
|
|
|
|
|
real_dev_name, vlan_dev_name, vid));
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
2011-11-20 15:12:36 -08:00
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
mirror_refresh_stats(struct mirror *m)
|
|
|
|
|
{
|
|
|
|
|
struct ofproto *ofproto = m->bridge->ofproto;
|
|
|
|
|
uint64_t tx_packets, tx_bytes;
|
|
|
|
|
char *keys[2];
|
|
|
|
|
int64_t values[2];
|
|
|
|
|
size_t stat_cnt = 0;
|
|
|
|
|
|
|
|
|
|
if (ofproto_mirror_get_stats(ofproto, m, &tx_packets, &tx_bytes)) {
|
|
|
|
|
ovsrec_mirror_set_statistics(m->cfg, NULL, NULL, 0);
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (tx_packets != UINT64_MAX) {
|
|
|
|
|
keys[stat_cnt] = "tx_packets";
|
|
|
|
|
values[stat_cnt] = tx_packets;
|
|
|
|
|
stat_cnt++;
|
|
|
|
|
}
|
|
|
|
|
if (tx_bytes != UINT64_MAX) {
|
|
|
|
|
keys[stat_cnt] = "tx_bytes";
|
|
|
|
|
values[stat_cnt] = tx_bytes;
|
|
|
|
|
stat_cnt++;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
ovsrec_mirror_set_statistics(m->cfg, keys, values, stat_cnt);
|
|
|
|
|
}
|