2009-07-08 13:19:16 -07:00
|
|
|
/*
|
|
|
|
|
* Distributed under the terms of the GNU GPL version 2.
|
2011-01-26 13:41:54 -08:00
|
|
|
* Copyright (c) 2007, 2008, 2009, 2010, 2011 Nicira Networks.
|
2009-06-15 15:11:30 -07:00
|
|
|
*
|
|
|
|
|
* Significant portions of this file may be copied from parts of the Linux
|
|
|
|
|
* kernel, by Linus Torvalds and others.
|
2009-07-08 13:19:16 -07:00
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
/* Functions for executing flow actions. */
|
|
|
|
|
|
|
|
|
|
#include <linux/skbuff.h>
|
|
|
|
|
#include <linux/in.h>
|
|
|
|
|
#include <linux/ip.h>
|
|
|
|
|
#include <linux/tcp.h>
|
|
|
|
|
#include <linux/udp.h>
|
|
|
|
|
#include <linux/in6.h>
|
2010-08-24 16:00:27 -07:00
|
|
|
#include <linux/if_arp.h>
|
2009-07-08 13:19:16 -07:00
|
|
|
#include <linux/if_vlan.h>
|
2010-02-11 15:19:26 -08:00
|
|
|
#include <net/inet_ecn.h>
|
2009-07-08 13:19:16 -07:00
|
|
|
#include <net/ip.h>
|
|
|
|
|
#include <net/checksum.h>
|
2010-04-12 15:53:39 -04:00
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
#include "actions.h"
|
2010-11-22 14:17:24 -08:00
|
|
|
#include "checksum.h"
|
2010-04-12 15:53:39 -04:00
|
|
|
#include "datapath.h"
|
2011-04-29 10:49:06 -07:00
|
|
|
#include "loop_counter.h"
|
2009-07-08 13:19:16 -07:00
|
|
|
#include "openvswitch/datapath-protocol.h"
|
2010-12-29 22:13:15 -08:00
|
|
|
#include "vlan.h"
|
2010-04-12 15:53:39 -04:00
|
|
|
#include "vport.h"
|
2009-07-08 13:19:16 -07:00
|
|
|
|
2010-12-23 09:35:15 -08:00
|
|
|
static int do_execute_actions(struct datapath *, struct sk_buff *,
|
2011-04-29 10:49:06 -07:00
|
|
|
struct sw_flow_actions *acts);
|
2010-12-23 09:35:15 -08:00
|
|
|
|
2010-09-10 11:16:31 -07:00
|
|
|
static struct sk_buff *make_writable(struct sk_buff *skb, unsigned min_headroom)
|
2009-07-08 13:19:16 -07:00
|
|
|
{
|
2010-07-29 19:01:02 -07:00
|
|
|
if (skb_cloned(skb)) {
|
2009-11-17 19:03:27 -08:00
|
|
|
struct sk_buff *nskb;
|
|
|
|
|
unsigned headroom = max(min_headroom, skb_headroom(skb));
|
|
|
|
|
|
2010-09-10 11:16:31 -07:00
|
|
|
nskb = skb_copy_expand(skb, headroom, skb_tailroom(skb), GFP_ATOMIC);
|
2009-07-08 13:19:16 -07:00
|
|
|
if (nskb) {
|
2010-04-07 13:55:28 -04:00
|
|
|
set_skb_csum_bits(skb, nskb);
|
2009-07-08 13:19:16 -07:00
|
|
|
kfree_skb(skb);
|
|
|
|
|
return nskb;
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
unsigned int hdr_len = (skb_transport_offset(skb)
|
|
|
|
|
+ sizeof(struct tcphdr));
|
|
|
|
|
if (pskb_may_pull(skb, min(hdr_len, skb->len)))
|
|
|
|
|
return skb;
|
|
|
|
|
}
|
|
|
|
|
kfree_skb(skb);
|
|
|
|
|
return NULL;
|
|
|
|
|
}
|
|
|
|
|
|
2010-12-29 22:13:15 -08:00
|
|
|
static struct sk_buff *strip_vlan(struct sk_buff *skb)
|
2009-07-08 13:19:16 -07:00
|
|
|
{
|
|
|
|
|
struct ethhdr *eh;
|
|
|
|
|
|
2010-12-29 22:13:15 -08:00
|
|
|
if (vlan_tx_tag_present(skb)) {
|
|
|
|
|
vlan_set_tci(skb, 0);
|
|
|
|
|
return skb;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (unlikely(vlan_eth_hdr(skb)->h_vlan_proto != htons(ETH_P_8021Q) ||
|
|
|
|
|
skb->len < VLAN_ETH_HLEN))
|
2009-07-08 13:19:16 -07:00
|
|
|
return skb;
|
|
|
|
|
|
2010-12-29 22:13:15 -08:00
|
|
|
skb = make_writable(skb, 0);
|
|
|
|
|
if (unlikely(!skb))
|
|
|
|
|
return NULL;
|
|
|
|
|
|
2010-11-22 14:17:24 -08:00
|
|
|
if (get_ip_summed(skb) == OVS_CSUM_COMPLETE)
|
2010-03-04 16:39:57 -05:00
|
|
|
skb->csum = csum_sub(skb->csum, csum_partial(skb->data
|
|
|
|
|
+ ETH_HLEN, VLAN_HLEN, 0));
|
|
|
|
|
|
2010-12-29 22:13:15 -08:00
|
|
|
memmove(skb->data + VLAN_HLEN, skb->data, 2 * ETH_ALEN);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
|
|
|
eh = (struct ethhdr *)skb_pull(skb, VLAN_HLEN);
|
|
|
|
|
|
|
|
|
|
skb->protocol = eh->h_proto;
|
|
|
|
|
skb->mac_header += VLAN_HLEN;
|
|
|
|
|
|
|
|
|
|
return skb;
|
|
|
|
|
}
|
|
|
|
|
|
2011-03-02 10:38:14 -08:00
|
|
|
static struct sk_buff *modify_vlan_tci(struct sk_buff *skb, __be16 tci)
|
2009-07-08 13:19:16 -07:00
|
|
|
{
|
2010-12-29 22:13:15 -08:00
|
|
|
struct vlan_ethhdr *vh;
|
|
|
|
|
__be16 old_tci;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
2010-12-29 22:13:15 -08:00
|
|
|
if (vlan_tx_tag_present(skb) || skb->protocol != htons(ETH_P_8021Q))
|
|
|
|
|
return __vlan_hwaccel_put_tag(skb, ntohs(tci));
|
2010-08-13 10:46:12 -07:00
|
|
|
|
2010-12-29 22:13:15 -08:00
|
|
|
skb = make_writable(skb, 0);
|
|
|
|
|
if (unlikely(!skb))
|
|
|
|
|
return NULL;
|
2010-06-17 15:17:53 -07:00
|
|
|
|
2010-12-29 22:13:15 -08:00
|
|
|
if (unlikely(skb->len < VLAN_ETH_HLEN))
|
|
|
|
|
return skb;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
2010-12-29 22:13:15 -08:00
|
|
|
vh = vlan_eth_hdr(skb);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
2010-12-29 22:13:15 -08:00
|
|
|
old_tci = vh->h_vlan_TCI;
|
|
|
|
|
vh->h_vlan_TCI = tci;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
2010-12-29 22:13:15 -08:00
|
|
|
if (get_ip_summed(skb) == OVS_CSUM_COMPLETE) {
|
|
|
|
|
__be16 diff[] = { ~old_tci, vh->h_vlan_TCI };
|
|
|
|
|
skb->csum = ~csum_partial((char *)diff, sizeof(diff), ~skb->csum);
|
2009-07-08 13:19:16 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return skb;
|
|
|
|
|
}
|
|
|
|
|
|
2011-04-29 10:49:06 -07:00
|
|
|
static bool is_ip(struct sk_buff *skb)
|
2010-08-13 10:46:12 -07:00
|
|
|
{
|
2011-05-18 11:30:07 -07:00
|
|
|
return (OVS_CB(skb)->flow->key.eth.type == htons(ETH_P_IP) &&
|
2010-08-13 10:46:12 -07:00
|
|
|
skb->transport_header > skb->network_header);
|
|
|
|
|
}
|
|
|
|
|
|
2011-04-29 10:49:06 -07:00
|
|
|
static __sum16 *get_l4_checksum(struct sk_buff *skb)
|
2010-08-13 10:46:12 -07:00
|
|
|
{
|
2011-06-08 12:28:57 -07:00
|
|
|
u8 nw_proto = OVS_CB(skb)->flow->key.ip.proto;
|
2010-08-13 10:46:12 -07:00
|
|
|
int transport_len = skb->len - skb_transport_offset(skb);
|
2011-04-29 10:49:06 -07:00
|
|
|
if (nw_proto == IPPROTO_TCP) {
|
2010-08-13 10:46:12 -07:00
|
|
|
if (likely(transport_len >= sizeof(struct tcphdr)))
|
|
|
|
|
return &tcp_hdr(skb)->check;
|
2011-04-29 10:49:06 -07:00
|
|
|
} else if (nw_proto == IPPROTO_UDP) {
|
2010-08-13 10:46:12 -07:00
|
|
|
if (likely(transport_len >= sizeof(struct udphdr)))
|
|
|
|
|
return &udp_hdr(skb)->check;
|
|
|
|
|
}
|
|
|
|
|
return NULL;
|
|
|
|
|
}
|
|
|
|
|
|
2011-04-29 10:49:06 -07:00
|
|
|
static struct sk_buff *set_nw_addr(struct sk_buff *skb, const struct nlattr *a)
|
2009-07-08 13:19:16 -07:00
|
|
|
{
|
2010-12-10 10:40:58 -08:00
|
|
|
__be32 new_nwaddr = nla_get_be32(a);
|
2010-08-13 10:46:12 -07:00
|
|
|
struct iphdr *nh;
|
|
|
|
|
__sum16 *check;
|
|
|
|
|
__be32 *nwaddr;
|
|
|
|
|
|
2011-04-29 10:49:06 -07:00
|
|
|
if (unlikely(!is_ip(skb)))
|
2009-07-08 13:19:16 -07:00
|
|
|
return skb;
|
|
|
|
|
|
2010-09-10 11:16:31 -07:00
|
|
|
skb = make_writable(skb, 0);
|
2010-08-13 10:46:12 -07:00
|
|
|
if (unlikely(!skb))
|
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
|
|
nh = ip_hdr(skb);
|
2011-01-23 21:56:00 -08:00
|
|
|
nwaddr = nla_type(a) == ODP_ACTION_ATTR_SET_NW_SRC ? &nh->saddr : &nh->daddr;
|
2010-08-13 10:46:12 -07:00
|
|
|
|
2011-04-29 10:49:06 -07:00
|
|
|
check = get_l4_checksum(skb);
|
2010-08-13 10:46:12 -07:00
|
|
|
if (likely(check))
|
2010-12-10 10:40:58 -08:00
|
|
|
inet_proto_csum_replace4(check, skb, *nwaddr, new_nwaddr, 1);
|
|
|
|
|
csum_replace4(&nh->check, *nwaddr, new_nwaddr);
|
2010-08-13 10:46:12 -07:00
|
|
|
|
2011-02-07 11:07:14 +09:00
|
|
|
skb_clear_rxhash(skb);
|
|
|
|
|
|
2010-12-10 10:40:58 -08:00
|
|
|
*nwaddr = new_nwaddr;
|
2010-08-13 10:46:12 -07:00
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
return skb;
|
|
|
|
|
}
|
|
|
|
|
|
2011-04-29 10:49:06 -07:00
|
|
|
static struct sk_buff *set_nw_tos(struct sk_buff *skb, u8 nw_tos)
|
2009-11-11 14:59:49 -08:00
|
|
|
{
|
2011-04-29 10:49:06 -07:00
|
|
|
if (unlikely(!is_ip(skb)))
|
2009-11-11 14:59:49 -08:00
|
|
|
return skb;
|
|
|
|
|
|
2010-09-10 11:16:31 -07:00
|
|
|
skb = make_writable(skb, 0);
|
2009-11-11 14:59:49 -08:00
|
|
|
if (skb) {
|
|
|
|
|
struct iphdr *nh = ip_hdr(skb);
|
|
|
|
|
u8 *f = &nh->tos;
|
|
|
|
|
u8 old = *f;
|
2010-02-11 15:19:26 -08:00
|
|
|
u8 new;
|
2009-11-11 14:59:49 -08:00
|
|
|
|
2010-02-11 15:19:26 -08:00
|
|
|
/* Set the DSCP bits and preserve the ECN bits. */
|
2010-12-10 10:40:58 -08:00
|
|
|
new = nw_tos | (nh->tos & INET_ECN_MASK);
|
2010-12-06 17:51:33 -08:00
|
|
|
csum_replace4(&nh->check, (__force __be32)old,
|
|
|
|
|
(__force __be32)new);
|
2009-11-11 14:59:49 -08:00
|
|
|
*f = new;
|
|
|
|
|
}
|
|
|
|
|
return skb;
|
|
|
|
|
}
|
|
|
|
|
|
2011-04-29 10:49:06 -07:00
|
|
|
static struct sk_buff *set_tp_port(struct sk_buff *skb, const struct nlattr *a)
|
2009-07-08 13:19:16 -07:00
|
|
|
{
|
2010-08-13 10:46:12 -07:00
|
|
|
struct udphdr *th;
|
|
|
|
|
__sum16 *check;
|
|
|
|
|
__be16 *port;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
2011-04-29 10:49:06 -07:00
|
|
|
if (unlikely(!is_ip(skb)))
|
2009-07-08 13:19:16 -07:00
|
|
|
return skb;
|
|
|
|
|
|
2010-09-10 11:16:31 -07:00
|
|
|
skb = make_writable(skb, 0);
|
2010-08-13 10:46:12 -07:00
|
|
|
if (unlikely(!skb))
|
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
|
|
/* Must follow make_writable() since that can move the skb data. */
|
2011-04-29 10:49:06 -07:00
|
|
|
check = get_l4_checksum(skb);
|
2010-08-13 10:46:12 -07:00
|
|
|
if (unlikely(!check))
|
2009-07-08 13:19:16 -07:00
|
|
|
return skb;
|
|
|
|
|
|
2010-08-13 10:46:12 -07:00
|
|
|
/*
|
|
|
|
|
* Update port and checksum.
|
|
|
|
|
*
|
|
|
|
|
* This is OK because source and destination port numbers are at the
|
|
|
|
|
* same offsets in both UDP and TCP headers, and get_l4_checksum() only
|
|
|
|
|
* supports those protocols.
|
|
|
|
|
*/
|
|
|
|
|
th = udp_hdr(skb);
|
2011-01-23 21:56:00 -08:00
|
|
|
port = nla_type(a) == ODP_ACTION_ATTR_SET_TP_SRC ? &th->source : &th->dest;
|
2010-12-10 10:40:58 -08:00
|
|
|
inet_proto_csum_replace2(check, skb, *port, nla_get_be16(a), 0);
|
|
|
|
|
*port = nla_get_be16(a);
|
2011-02-07 11:07:14 +09:00
|
|
|
skb_clear_rxhash(skb);
|
2010-08-13 10:46:12 -07:00
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
return skb;
|
|
|
|
|
}
|
|
|
|
|
|
2010-08-24 16:00:27 -07:00
|
|
|
/**
|
|
|
|
|
* is_spoofed_arp - check for invalid ARP packet
|
|
|
|
|
*
|
|
|
|
|
* @skb: skbuff containing an Ethernet packet, with network header pointing
|
|
|
|
|
* just past the Ethernet and optional 802.1Q header.
|
|
|
|
|
*
|
|
|
|
|
* Returns true if @skb is an invalid Ethernet+IPv4 ARP packet: one with screwy
|
|
|
|
|
* or truncated header fields or one whose inner and outer Ethernet address
|
|
|
|
|
* differ.
|
|
|
|
|
*/
|
2011-04-29 10:49:06 -07:00
|
|
|
static bool is_spoofed_arp(struct sk_buff *skb)
|
2010-08-24 16:00:27 -07:00
|
|
|
{
|
|
|
|
|
struct arp_eth_header *arp;
|
|
|
|
|
|
2011-05-18 11:30:07 -07:00
|
|
|
if (OVS_CB(skb)->flow->key.eth.type != htons(ETH_P_ARP))
|
2010-08-24 16:00:27 -07:00
|
|
|
return false;
|
|
|
|
|
|
|
|
|
|
if (skb_network_offset(skb) + sizeof(struct arp_eth_header) > skb->len)
|
|
|
|
|
return true;
|
|
|
|
|
|
|
|
|
|
arp = (struct arp_eth_header *)skb_network_header(skb);
|
|
|
|
|
return (arp->ar_hrd != htons(ARPHRD_ETHER) ||
|
|
|
|
|
arp->ar_pro != htons(ETH_P_IP) ||
|
|
|
|
|
arp->ar_hln != ETH_ALEN ||
|
|
|
|
|
arp->ar_pln != 4 ||
|
|
|
|
|
compare_ether_addr(arp->ar_sha, eth_hdr(skb)->h_source));
|
|
|
|
|
}
|
|
|
|
|
|
2010-07-14 19:27:18 -07:00
|
|
|
static void do_output(struct datapath *dp, struct sk_buff *skb, int out_port)
|
2009-07-08 13:19:16 -07:00
|
|
|
{
|
2010-12-03 13:09:26 -08:00
|
|
|
struct vport *p;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
|
|
|
if (!skb)
|
|
|
|
|
goto error;
|
|
|
|
|
|
2010-04-12 15:53:39 -04:00
|
|
|
p = rcu_dereference(dp->ports[out_port]);
|
2009-07-08 13:19:16 -07:00
|
|
|
if (!p)
|
|
|
|
|
goto error;
|
|
|
|
|
|
2010-12-03 13:09:26 -08:00
|
|
|
vport_send(p, skb);
|
2009-07-08 13:19:16 -07:00
|
|
|
return;
|
|
|
|
|
|
|
|
|
|
error:
|
|
|
|
|
kfree_skb(skb);
|
|
|
|
|
}
|
|
|
|
|
|
2011-04-29 10:49:06 -07:00
|
|
|
static int output_control(struct datapath *dp, struct sk_buff *skb, u64 arg)
|
2009-07-08 13:19:16 -07:00
|
|
|
{
|
datapath: Report kernel's flow key when passing packets up to userspace.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to change
the kernel's idea of the flow key separately from the userspace version.
This commit takes one step in that direction by making the kernel report
its idea of the flow that a packet belongs to whenever it passes a packet
up to userspace. This means that userspace can intelligently figure out
what to do:
- If userspace's notion of the flow for the packet matches the kernel's,
then nothing special is necessary.
- If the kernel has a more specific notion for the flow than userspace,
for example if the kernel decoded IPv6 headers but userspace stopped
at the Ethernet type (because it does not understand IPv6), then again
nothing special is necessary: userspace can still set up the flow in
the usual way.
- If userspace has a more specific notion for the flow than the kernel,
for example if userspace decoded an IPv6 header but the kernel
stopped at the Ethernet type, then userspace can forward the packet
manually, without setting up a flow in the kernel. (This case is
bad from a performance point of view, but at least it is correct.)
This commit does not actually make userspace flexible enough to handle
changes in the kernel flow key structure, although userspace does now
have enough information to do that intelligently. This will have to wait
for later commits.
This commit is bigger than it would otherwise be because it is rolled
together with changing "struct odp_msg" to a sequence of Netlink
attributes. The alternative, to do each of those changes in a separate
patch, seemed like overkill because it meant that either we would have to
introduce and then kill off Netlink attributes for in_port and tun_id, if
Netlink conversion went first, or shove yet another variable-length header
into the stuff already after odp_msg, if adding the flow key to odp_msg
went first.
This commit will slow down performance of checksumming packets sent up to
userspace. I'm not entirely pleased with how I did it. I considered a
couple of alternatives, but none of them seemed that much better.
Suggestions welcome. Not changing anything wasn't an option,
unfortunately. At any rate some slowdown will become unavoidable when OVS
actually starts using Netlink instead of just Netlink framing.
(Actually, I thought of one option where we could avoid that: make
userspace do the checksum instead, by passing csum_start and csum_offset as
part of what goes to userspace. But that's not perfect either.)
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2011-01-24 14:59:57 -08:00
|
|
|
struct dp_upcall_info upcall;
|
|
|
|
|
|
2010-09-10 11:16:31 -07:00
|
|
|
skb = skb_clone(skb, GFP_ATOMIC);
|
2009-07-08 13:19:16 -07:00
|
|
|
if (!skb)
|
|
|
|
|
return -ENOMEM;
|
datapath: Report kernel's flow key when passing packets up to userspace.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to change
the kernel's idea of the flow key separately from the userspace version.
This commit takes one step in that direction by making the kernel report
its idea of the flow that a packet belongs to whenever it passes a packet
up to userspace. This means that userspace can intelligently figure out
what to do:
- If userspace's notion of the flow for the packet matches the kernel's,
then nothing special is necessary.
- If the kernel has a more specific notion for the flow than userspace,
for example if the kernel decoded IPv6 headers but userspace stopped
at the Ethernet type (because it does not understand IPv6), then again
nothing special is necessary: userspace can still set up the flow in
the usual way.
- If userspace has a more specific notion for the flow than the kernel,
for example if userspace decoded an IPv6 header but the kernel
stopped at the Ethernet type, then userspace can forward the packet
manually, without setting up a flow in the kernel. (This case is
bad from a performance point of view, but at least it is correct.)
This commit does not actually make userspace flexible enough to handle
changes in the kernel flow key structure, although userspace does now
have enough information to do that intelligently. This will have to wait
for later commits.
This commit is bigger than it would otherwise be because it is rolled
together with changing "struct odp_msg" to a sequence of Netlink
attributes. The alternative, to do each of those changes in a separate
patch, seemed like overkill because it meant that either we would have to
introduce and then kill off Netlink attributes for in_port and tun_id, if
Netlink conversion went first, or shove yet another variable-length header
into the stuff already after odp_msg, if adding the flow key to odp_msg
went first.
This commit will slow down performance of checksumming packets sent up to
userspace. I'm not entirely pleased with how I did it. I considered a
couple of alternatives, but none of them seemed that much better.
Suggestions welcome. Not changing anything wasn't an option,
unfortunately. At any rate some slowdown will become unavoidable when OVS
actually starts using Netlink instead of just Netlink framing.
(Actually, I thought of one option where we could avoid that: make
userspace do the checksum instead, by passing csum_start and csum_offset as
part of what goes to userspace. But that's not perfect either.)
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2011-01-24 14:59:57 -08:00
|
|
|
|
2011-01-26 13:41:54 -08:00
|
|
|
upcall.cmd = ODP_PACKET_CMD_ACTION;
|
2011-04-29 10:49:06 -07:00
|
|
|
upcall.key = &OVS_CB(skb)->flow->key;
|
datapath: Report kernel's flow key when passing packets up to userspace.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to change
the kernel's idea of the flow key separately from the userspace version.
This commit takes one step in that direction by making the kernel report
its idea of the flow that a packet belongs to whenever it passes a packet
up to userspace. This means that userspace can intelligently figure out
what to do:
- If userspace's notion of the flow for the packet matches the kernel's,
then nothing special is necessary.
- If the kernel has a more specific notion for the flow than userspace,
for example if the kernel decoded IPv6 headers but userspace stopped
at the Ethernet type (because it does not understand IPv6), then again
nothing special is necessary: userspace can still set up the flow in
the usual way.
- If userspace has a more specific notion for the flow than the kernel,
for example if userspace decoded an IPv6 header but the kernel
stopped at the Ethernet type, then userspace can forward the packet
manually, without setting up a flow in the kernel. (This case is
bad from a performance point of view, but at least it is correct.)
This commit does not actually make userspace flexible enough to handle
changes in the kernel flow key structure, although userspace does now
have enough information to do that intelligently. This will have to wait
for later commits.
This commit is bigger than it would otherwise be because it is rolled
together with changing "struct odp_msg" to a sequence of Netlink
attributes. The alternative, to do each of those changes in a separate
patch, seemed like overkill because it meant that either we would have to
introduce and then kill off Netlink attributes for in_port and tun_id, if
Netlink conversion went first, or shove yet another variable-length header
into the stuff already after odp_msg, if adding the flow key to odp_msg
went first.
This commit will slow down performance of checksumming packets sent up to
userspace. I'm not entirely pleased with how I did it. I considered a
couple of alternatives, but none of them seemed that much better.
Suggestions welcome. Not changing anything wasn't an option,
unfortunately. At any rate some slowdown will become unavoidable when OVS
actually starts using Netlink instead of just Netlink framing.
(Actually, I thought of one option where we could avoid that: make
userspace do the checksum instead, by passing csum_start and csum_offset as
part of what goes to userspace. But that's not perfect either.)
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2011-01-24 14:59:57 -08:00
|
|
|
upcall.userdata = arg;
|
|
|
|
|
upcall.sample_pool = 0;
|
|
|
|
|
upcall.actions = NULL;
|
|
|
|
|
upcall.actions_len = 0;
|
|
|
|
|
return dp_upcall(dp, skb, &upcall);
|
2009-07-08 13:19:16 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Execute a list of actions against 'skb'. */
|
2010-12-23 09:35:15 -08:00
|
|
|
static int do_execute_actions(struct datapath *dp, struct sk_buff *skb,
|
2011-04-29 10:49:06 -07:00
|
|
|
struct sw_flow_actions *acts)
|
2009-07-08 13:19:16 -07:00
|
|
|
{
|
|
|
|
|
/* Every output action needs a separate clone of 'skb', but the common
|
|
|
|
|
* case is just a single output action, so that doing a clone and
|
|
|
|
|
* then freeing the original skbuff is wasteful. So the following code
|
|
|
|
|
* is slightly obscure just to avoid that. */
|
|
|
|
|
int prev_port = -1;
|
2010-06-17 15:04:12 -07:00
|
|
|
u32 priority = skb->priority;
|
2010-12-10 10:40:58 -08:00
|
|
|
const struct nlattr *a;
|
|
|
|
|
int rem, err;
|
2010-01-04 13:08:37 -08:00
|
|
|
|
2011-04-29 10:49:06 -07:00
|
|
|
for (a = acts->actions, rem = acts->actions_len; rem > 0;
|
|
|
|
|
a = nla_next(a, &rem)) {
|
2009-07-08 13:19:16 -07:00
|
|
|
if (prev_port != -1) {
|
2010-09-10 11:16:31 -07:00
|
|
|
do_output(dp, skb_clone(skb, GFP_ATOMIC), prev_port);
|
2009-07-08 13:19:16 -07:00
|
|
|
prev_port = -1;
|
|
|
|
|
}
|
|
|
|
|
|
2010-12-10 10:40:58 -08:00
|
|
|
switch (nla_type(a)) {
|
2011-01-23 21:56:00 -08:00
|
|
|
case ODP_ACTION_ATTR_OUTPUT:
|
2010-12-10 10:40:58 -08:00
|
|
|
prev_port = nla_get_u32(a);
|
2009-07-08 13:19:16 -07:00
|
|
|
break;
|
|
|
|
|
|
2011-01-23 21:56:00 -08:00
|
|
|
case ODP_ACTION_ATTR_CONTROLLER:
|
2011-04-29 10:49:06 -07:00
|
|
|
err = output_control(dp, skb, nla_get_u64(a));
|
2009-07-08 13:19:16 -07:00
|
|
|
if (err) {
|
|
|
|
|
kfree_skb(skb);
|
|
|
|
|
return err;
|
|
|
|
|
}
|
|
|
|
|
break;
|
|
|
|
|
|
2011-01-23 21:56:00 -08:00
|
|
|
case ODP_ACTION_ATTR_SET_TUNNEL:
|
2010-12-10 10:42:42 -08:00
|
|
|
OVS_CB(skb)->tun_id = nla_get_be64(a);
|
2010-04-12 11:49:16 -04:00
|
|
|
break;
|
|
|
|
|
|
2011-01-23 21:56:00 -08:00
|
|
|
case ODP_ACTION_ATTR_SET_DL_TCI:
|
2011-03-02 10:38:14 -08:00
|
|
|
skb = modify_vlan_tci(skb, nla_get_be16(a));
|
2009-07-08 13:19:16 -07:00
|
|
|
break;
|
|
|
|
|
|
2011-01-23 21:56:00 -08:00
|
|
|
case ODP_ACTION_ATTR_STRIP_VLAN:
|
2010-09-10 11:16:31 -07:00
|
|
|
skb = strip_vlan(skb);
|
2009-07-08 13:19:16 -07:00
|
|
|
break;
|
|
|
|
|
|
2011-01-23 21:56:00 -08:00
|
|
|
case ODP_ACTION_ATTR_SET_DL_SRC:
|
2010-12-10 10:40:58 -08:00
|
|
|
skb = make_writable(skb, 0);
|
|
|
|
|
if (!skb)
|
|
|
|
|
return -ENOMEM;
|
|
|
|
|
memcpy(eth_hdr(skb)->h_source, nla_data(a), ETH_ALEN);
|
|
|
|
|
break;
|
|
|
|
|
|
2011-01-23 21:56:00 -08:00
|
|
|
case ODP_ACTION_ATTR_SET_DL_DST:
|
2010-12-10 10:40:58 -08:00
|
|
|
skb = make_writable(skb, 0);
|
|
|
|
|
if (!skb)
|
|
|
|
|
return -ENOMEM;
|
|
|
|
|
memcpy(eth_hdr(skb)->h_dest, nla_data(a), ETH_ALEN);
|
2009-07-08 13:19:16 -07:00
|
|
|
break;
|
|
|
|
|
|
2011-01-23 21:56:00 -08:00
|
|
|
case ODP_ACTION_ATTR_SET_NW_SRC:
|
|
|
|
|
case ODP_ACTION_ATTR_SET_NW_DST:
|
2011-04-29 10:49:06 -07:00
|
|
|
skb = set_nw_addr(skb, a);
|
2009-07-08 13:19:16 -07:00
|
|
|
break;
|
|
|
|
|
|
2011-01-23 21:56:00 -08:00
|
|
|
case ODP_ACTION_ATTR_SET_NW_TOS:
|
2011-04-29 10:49:06 -07:00
|
|
|
skb = set_nw_tos(skb, nla_get_u8(a));
|
2009-11-11 14:59:49 -08:00
|
|
|
break;
|
|
|
|
|
|
2011-01-23 21:56:00 -08:00
|
|
|
case ODP_ACTION_ATTR_SET_TP_SRC:
|
|
|
|
|
case ODP_ACTION_ATTR_SET_TP_DST:
|
2011-04-29 10:49:06 -07:00
|
|
|
skb = set_tp_port(skb, a);
|
2009-07-08 13:19:16 -07:00
|
|
|
break;
|
2010-06-17 15:04:12 -07:00
|
|
|
|
2011-01-23 21:56:00 -08:00
|
|
|
case ODP_ACTION_ATTR_SET_PRIORITY:
|
2010-12-10 10:40:58 -08:00
|
|
|
skb->priority = nla_get_u32(a);
|
2010-06-17 15:04:12 -07:00
|
|
|
break;
|
|
|
|
|
|
2011-01-23 21:56:00 -08:00
|
|
|
case ODP_ACTION_ATTR_POP_PRIORITY:
|
2010-06-17 15:04:12 -07:00
|
|
|
skb->priority = priority;
|
|
|
|
|
break;
|
2010-08-24 16:00:27 -07:00
|
|
|
|
2011-01-23 21:56:00 -08:00
|
|
|
case ODP_ACTION_ATTR_DROP_SPOOFED_ARP:
|
2011-04-29 10:49:06 -07:00
|
|
|
if (unlikely(is_spoofed_arp(skb)))
|
2010-08-24 16:00:27 -07:00
|
|
|
goto exit;
|
|
|
|
|
break;
|
2009-07-08 13:19:16 -07:00
|
|
|
}
|
|
|
|
|
if (!skb)
|
|
|
|
|
return -ENOMEM;
|
|
|
|
|
}
|
2010-08-24 16:00:27 -07:00
|
|
|
exit:
|
2009-07-08 13:19:16 -07:00
|
|
|
if (prev_port != -1)
|
|
|
|
|
do_output(dp, skb, prev_port);
|
|
|
|
|
else
|
|
|
|
|
kfree_skb(skb);
|
2009-06-19 14:03:12 -07:00
|
|
|
return 0;
|
2009-07-08 13:19:16 -07:00
|
|
|
}
|
2010-12-23 09:35:15 -08:00
|
|
|
|
|
|
|
|
static void sflow_sample(struct datapath *dp, struct sk_buff *skb,
|
2011-04-29 10:49:06 -07:00
|
|
|
struct sw_flow_actions *acts)
|
2010-12-23 09:35:15 -08:00
|
|
|
{
|
|
|
|
|
struct sk_buff *nskb;
|
datapath: Report kernel's flow key when passing packets up to userspace.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to change
the kernel's idea of the flow key separately from the userspace version.
This commit takes one step in that direction by making the kernel report
its idea of the flow that a packet belongs to whenever it passes a packet
up to userspace. This means that userspace can intelligently figure out
what to do:
- If userspace's notion of the flow for the packet matches the kernel's,
then nothing special is necessary.
- If the kernel has a more specific notion for the flow than userspace,
for example if the kernel decoded IPv6 headers but userspace stopped
at the Ethernet type (because it does not understand IPv6), then again
nothing special is necessary: userspace can still set up the flow in
the usual way.
- If userspace has a more specific notion for the flow than the kernel,
for example if userspace decoded an IPv6 header but the kernel
stopped at the Ethernet type, then userspace can forward the packet
manually, without setting up a flow in the kernel. (This case is
bad from a performance point of view, but at least it is correct.)
This commit does not actually make userspace flexible enough to handle
changes in the kernel flow key structure, although userspace does now
have enough information to do that intelligently. This will have to wait
for later commits.
This commit is bigger than it would otherwise be because it is rolled
together with changing "struct odp_msg" to a sequence of Netlink
attributes. The alternative, to do each of those changes in a separate
patch, seemed like overkill because it meant that either we would have to
introduce and then kill off Netlink attributes for in_port and tun_id, if
Netlink conversion went first, or shove yet another variable-length header
into the stuff already after odp_msg, if adding the flow key to odp_msg
went first.
This commit will slow down performance of checksumming packets sent up to
userspace. I'm not entirely pleased with how I did it. I considered a
couple of alternatives, but none of them seemed that much better.
Suggestions welcome. Not changing anything wasn't an option,
unfortunately. At any rate some slowdown will become unavoidable when OVS
actually starts using Netlink instead of just Netlink framing.
(Actually, I thought of one option where we could avoid that: make
userspace do the checksum instead, by passing csum_start and csum_offset as
part of what goes to userspace. But that's not perfect either.)
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2011-01-24 14:59:57 -08:00
|
|
|
struct vport *p = OVS_CB(skb)->vport;
|
|
|
|
|
struct dp_upcall_info upcall;
|
|
|
|
|
|
|
|
|
|
if (unlikely(!p))
|
|
|
|
|
return;
|
2010-12-23 09:35:15 -08:00
|
|
|
|
datapath: Report kernel's flow key when passing packets up to userspace.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to change
the kernel's idea of the flow key separately from the userspace version.
This commit takes one step in that direction by making the kernel report
its idea of the flow that a packet belongs to whenever it passes a packet
up to userspace. This means that userspace can intelligently figure out
what to do:
- If userspace's notion of the flow for the packet matches the kernel's,
then nothing special is necessary.
- If the kernel has a more specific notion for the flow than userspace,
for example if the kernel decoded IPv6 headers but userspace stopped
at the Ethernet type (because it does not understand IPv6), then again
nothing special is necessary: userspace can still set up the flow in
the usual way.
- If userspace has a more specific notion for the flow than the kernel,
for example if userspace decoded an IPv6 header but the kernel
stopped at the Ethernet type, then userspace can forward the packet
manually, without setting up a flow in the kernel. (This case is
bad from a performance point of view, but at least it is correct.)
This commit does not actually make userspace flexible enough to handle
changes in the kernel flow key structure, although userspace does now
have enough information to do that intelligently. This will have to wait
for later commits.
This commit is bigger than it would otherwise be because it is rolled
together with changing "struct odp_msg" to a sequence of Netlink
attributes. The alternative, to do each of those changes in a separate
patch, seemed like overkill because it meant that either we would have to
introduce and then kill off Netlink attributes for in_port and tun_id, if
Netlink conversion went first, or shove yet another variable-length header
into the stuff already after odp_msg, if adding the flow key to odp_msg
went first.
This commit will slow down performance of checksumming packets sent up to
userspace. I'm not entirely pleased with how I did it. I considered a
couple of alternatives, but none of them seemed that much better.
Suggestions welcome. Not changing anything wasn't an option,
unfortunately. At any rate some slowdown will become unavoidable when OVS
actually starts using Netlink instead of just Netlink framing.
(Actually, I thought of one option where we could avoid that: make
userspace do the checksum instead, by passing csum_start and csum_offset as
part of what goes to userspace. But that's not perfect either.)
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2011-01-24 14:59:57 -08:00
|
|
|
atomic_inc(&p->sflow_pool);
|
|
|
|
|
if (net_random() >= dp->sflow_probability)
|
2010-12-23 09:35:15 -08:00
|
|
|
return;
|
|
|
|
|
|
datapath: Report kernel's flow key when passing packets up to userspace.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to change
the kernel's idea of the flow key separately from the userspace version.
This commit takes one step in that direction by making the kernel report
its idea of the flow that a packet belongs to whenever it passes a packet
up to userspace. This means that userspace can intelligently figure out
what to do:
- If userspace's notion of the flow for the packet matches the kernel's,
then nothing special is necessary.
- If the kernel has a more specific notion for the flow than userspace,
for example if the kernel decoded IPv6 headers but userspace stopped
at the Ethernet type (because it does not understand IPv6), then again
nothing special is necessary: userspace can still set up the flow in
the usual way.
- If userspace has a more specific notion for the flow than the kernel,
for example if userspace decoded an IPv6 header but the kernel
stopped at the Ethernet type, then userspace can forward the packet
manually, without setting up a flow in the kernel. (This case is
bad from a performance point of view, but at least it is correct.)
This commit does not actually make userspace flexible enough to handle
changes in the kernel flow key structure, although userspace does now
have enough information to do that intelligently. This will have to wait
for later commits.
This commit is bigger than it would otherwise be because it is rolled
together with changing "struct odp_msg" to a sequence of Netlink
attributes. The alternative, to do each of those changes in a separate
patch, seemed like overkill because it meant that either we would have to
introduce and then kill off Netlink attributes for in_port and tun_id, if
Netlink conversion went first, or shove yet another variable-length header
into the stuff already after odp_msg, if adding the flow key to odp_msg
went first.
This commit will slow down performance of checksumming packets sent up to
userspace. I'm not entirely pleased with how I did it. I considered a
couple of alternatives, but none of them seemed that much better.
Suggestions welcome. Not changing anything wasn't an option,
unfortunately. At any rate some slowdown will become unavoidable when OVS
actually starts using Netlink instead of just Netlink framing.
(Actually, I thought of one option where we could avoid that: make
userspace do the checksum instead, by passing csum_start and csum_offset as
part of what goes to userspace. But that's not perfect either.)
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2011-01-24 14:59:57 -08:00
|
|
|
nskb = skb_clone(skb, GFP_ATOMIC);
|
|
|
|
|
if (unlikely(!nskb))
|
|
|
|
|
return;
|
|
|
|
|
|
2011-01-26 13:41:54 -08:00
|
|
|
upcall.cmd = ODP_PACKET_CMD_SAMPLE;
|
2011-04-29 10:49:06 -07:00
|
|
|
upcall.key = &OVS_CB(skb)->flow->key;
|
datapath: Report kernel's flow key when passing packets up to userspace.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to change
the kernel's idea of the flow key separately from the userspace version.
This commit takes one step in that direction by making the kernel report
its idea of the flow that a packet belongs to whenever it passes a packet
up to userspace. This means that userspace can intelligently figure out
what to do:
- If userspace's notion of the flow for the packet matches the kernel's,
then nothing special is necessary.
- If the kernel has a more specific notion for the flow than userspace,
for example if the kernel decoded IPv6 headers but userspace stopped
at the Ethernet type (because it does not understand IPv6), then again
nothing special is necessary: userspace can still set up the flow in
the usual way.
- If userspace has a more specific notion for the flow than the kernel,
for example if userspace decoded an IPv6 header but the kernel
stopped at the Ethernet type, then userspace can forward the packet
manually, without setting up a flow in the kernel. (This case is
bad from a performance point of view, but at least it is correct.)
This commit does not actually make userspace flexible enough to handle
changes in the kernel flow key structure, although userspace does now
have enough information to do that intelligently. This will have to wait
for later commits.
This commit is bigger than it would otherwise be because it is rolled
together with changing "struct odp_msg" to a sequence of Netlink
attributes. The alternative, to do each of those changes in a separate
patch, seemed like overkill because it meant that either we would have to
introduce and then kill off Netlink attributes for in_port and tun_id, if
Netlink conversion went first, or shove yet another variable-length header
into the stuff already after odp_msg, if adding the flow key to odp_msg
went first.
This commit will slow down performance of checksumming packets sent up to
userspace. I'm not entirely pleased with how I did it. I considered a
couple of alternatives, but none of them seemed that much better.
Suggestions welcome. Not changing anything wasn't an option,
unfortunately. At any rate some slowdown will become unavoidable when OVS
actually starts using Netlink instead of just Netlink framing.
(Actually, I thought of one option where we could avoid that: make
userspace do the checksum instead, by passing csum_start and csum_offset as
part of what goes to userspace. But that's not perfect either.)
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2011-01-24 14:59:57 -08:00
|
|
|
upcall.userdata = 0;
|
|
|
|
|
upcall.sample_pool = atomic_read(&p->sflow_pool);
|
2011-04-29 10:49:06 -07:00
|
|
|
upcall.actions = acts->actions;
|
|
|
|
|
upcall.actions_len = acts->actions_len;
|
datapath: Report kernel's flow key when passing packets up to userspace.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to change
the kernel's idea of the flow key separately from the userspace version.
This commit takes one step in that direction by making the kernel report
its idea of the flow that a packet belongs to whenever it passes a packet
up to userspace. This means that userspace can intelligently figure out
what to do:
- If userspace's notion of the flow for the packet matches the kernel's,
then nothing special is necessary.
- If the kernel has a more specific notion for the flow than userspace,
for example if the kernel decoded IPv6 headers but userspace stopped
at the Ethernet type (because it does not understand IPv6), then again
nothing special is necessary: userspace can still set up the flow in
the usual way.
- If userspace has a more specific notion for the flow than the kernel,
for example if userspace decoded an IPv6 header but the kernel
stopped at the Ethernet type, then userspace can forward the packet
manually, without setting up a flow in the kernel. (This case is
bad from a performance point of view, but at least it is correct.)
This commit does not actually make userspace flexible enough to handle
changes in the kernel flow key structure, although userspace does now
have enough information to do that intelligently. This will have to wait
for later commits.
This commit is bigger than it would otherwise be because it is rolled
together with changing "struct odp_msg" to a sequence of Netlink
attributes. The alternative, to do each of those changes in a separate
patch, seemed like overkill because it meant that either we would have to
introduce and then kill off Netlink attributes for in_port and tun_id, if
Netlink conversion went first, or shove yet another variable-length header
into the stuff already after odp_msg, if adding the flow key to odp_msg
went first.
This commit will slow down performance of checksumming packets sent up to
userspace. I'm not entirely pleased with how I did it. I considered a
couple of alternatives, but none of them seemed that much better.
Suggestions welcome. Not changing anything wasn't an option,
unfortunately. At any rate some slowdown will become unavoidable when OVS
actually starts using Netlink instead of just Netlink framing.
(Actually, I thought of one option where we could avoid that: make
userspace do the checksum instead, by passing csum_start and csum_offset as
part of what goes to userspace. But that's not perfect either.)
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2011-01-24 14:59:57 -08:00
|
|
|
dp_upcall(dp, nskb, &upcall);
|
2010-12-23 09:35:15 -08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Execute a list of actions against 'skb'. */
|
2011-04-29 10:49:06 -07:00
|
|
|
int execute_actions(struct datapath *dp, struct sk_buff *skb)
|
2010-12-23 09:35:15 -08:00
|
|
|
{
|
2011-04-29 10:49:06 -07:00
|
|
|
struct sw_flow_actions *acts = rcu_dereference(OVS_CB(skb)->flow->sf_acts);
|
|
|
|
|
struct loop_counter *loop;
|
|
|
|
|
int error;
|
|
|
|
|
|
|
|
|
|
/* Check whether we've looped too much. */
|
|
|
|
|
loop = loop_get_counter();
|
|
|
|
|
if (unlikely(++loop->count > MAX_LOOPS))
|
|
|
|
|
loop->looping = true;
|
|
|
|
|
if (unlikely(loop->looping)) {
|
|
|
|
|
error = loop_suppress(dp, acts);
|
|
|
|
|
kfree_skb(skb);
|
|
|
|
|
goto out_loop;
|
|
|
|
|
}
|
2010-12-23 09:35:15 -08:00
|
|
|
|
2011-04-29 10:49:06 -07:00
|
|
|
/* Really execute actions. */
|
|
|
|
|
if (dp->sflow_probability)
|
|
|
|
|
sflow_sample(dp, skb, acts);
|
2010-12-23 09:35:15 -08:00
|
|
|
OVS_CB(skb)->tun_id = 0;
|
2011-04-29 10:49:06 -07:00
|
|
|
error = do_execute_actions(dp, skb, acts);
|
|
|
|
|
|
|
|
|
|
/* Check whether sub-actions looped too much. */
|
|
|
|
|
if (unlikely(loop->looping))
|
|
|
|
|
error = loop_suppress(dp, acts);
|
|
|
|
|
|
|
|
|
|
out_loop:
|
|
|
|
|
/* Decrement loop counter. */
|
|
|
|
|
if (!--loop->count)
|
|
|
|
|
loop->looping = false;
|
|
|
|
|
loop_put_counter();
|
2010-12-23 09:35:15 -08:00
|
|
|
|
2011-04-29 10:49:06 -07:00
|
|
|
return error;
|
2010-12-23 09:35:15 -08:00
|
|
|
}
|