2017-03-01 17:48:00 -05:00
|
|
|
|
/* Copyright (c) 2008, 2009, 2010, 2011, 2012, 2013, 2014, 2015, 2016, 2017 Nicira, Inc.
|
2009-06-10 15:24:03 -07:00
|
|
|
|
*
|
2009-06-15 15:11:30 -07:00
|
|
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
|
* you may not use this file except in compliance with the License.
|
|
|
|
|
* You may obtain a copy of the License at:
|
2009-07-08 13:19:16 -07:00
|
|
|
|
*
|
2009-06-15 15:11:30 -07:00
|
|
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
2009-07-08 13:19:16 -07:00
|
|
|
|
*
|
2009-06-15 15:11:30 -07:00
|
|
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
|
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
|
* See the License for the specific language governing permissions and
|
|
|
|
|
* limitations under the License.
|
2009-07-08 13:19:16 -07:00
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#include <config.h>
|
|
|
|
|
#include "bridge.h"
|
|
|
|
|
#include <errno.h>
|
|
|
|
|
#include <inttypes.h>
|
|
|
|
|
#include <stdlib.h>
|
2015-03-24 10:39:11 +00:00
|
|
|
|
|
2013-07-10 11:43:46 -07:00
|
|
|
|
#include "async-append.h"
|
bfd: Implement Bidirectional Forwarding Detection.
Traditionally, Open vSwitch has used a variant of 802.1ag "CFM" for
interface liveness detection. This has served us well until now,
but has several serious drawbacks which have steadily become more
inconvenient. First, the 802.1ag standard does not implement
several useful features forcing us to (optionally) break
compatibility. Second, 802.1.ag is not particularly popular
outside of carrier grade networking equipment. Third, 802.1ag is
simply quite awkward.
In an effort to solve the aforementioned problems, this patch
implements BFD which is ubiquitous, well designed, straight
forward, and implements required features in a standard way. The
initial cut of the protocol focuses on getting the basics of the
specification correct, leaving performance optimizations, and
advanced features as future work. The protocol should be
considered experimental pending future testing.
Signed-off-by: Ethan Jackson <ethan@nicira.com>
2012-06-08 12:42:42 -07:00
|
|
|
|
#include "bfd.h"
|
2009-07-08 13:19:16 -07:00
|
|
|
|
#include "bitmap.h"
|
2010-11-15 16:20:01 -08:00
|
|
|
|
#include "cfm.h"
|
2013-12-13 03:33:49 +00:00
|
|
|
|
#include "connectivity.h"
|
2009-07-08 13:19:16 -07:00
|
|
|
|
#include "coverage.h"
|
2011-01-28 12:44:00 -08:00
|
|
|
|
#include "daemon.h"
|
2009-07-08 13:19:16 -07:00
|
|
|
|
#include "dirs.h"
|
2015-03-24 10:39:11 +00:00
|
|
|
|
#include "dpif.h"
|
2016-10-04 17:58:05 -07:00
|
|
|
|
#include "dpdk.h"
|
2009-07-08 13:19:16 -07:00
|
|
|
|
#include "hash.h"
|
2016-07-12 16:37:34 -05:00
|
|
|
|
#include "openvswitch/hmap.h"
|
2011-11-30 12:09:35 -08:00
|
|
|
|
#include "hmapx.h"
|
2016-04-14 15:20:21 -07:00
|
|
|
|
#include "if-notifier.h"
|
2010-04-26 10:48:31 -07:00
|
|
|
|
#include "jsonrpc.h"
|
2011-02-28 14:48:06 -08:00
|
|
|
|
#include "lacp.h"
|
2012-02-01 15:04:51 -08:00
|
|
|
|
#include "mac-learning.h"
|
2014-06-18 22:14:35 -03:00
|
|
|
|
#include "mcast-snooping.h"
|
2009-07-08 13:19:16 -07:00
|
|
|
|
#include "netdev.h"
|
2019-05-07 12:24:08 +03:00
|
|
|
|
#include "netdev-offload.h"
|
2014-09-16 22:13:44 -07:00
|
|
|
|
#include "nx-match.h"
|
2013-12-06 13:27:26 -08:00
|
|
|
|
#include "ofproto/bond.h"
|
2009-07-08 10:30:42 -07:00
|
|
|
|
#include "ofproto/ofproto.h"
|
2016-04-14 15:20:21 -07:00
|
|
|
|
#include "openvswitch/dynamic-string.h"
|
|
|
|
|
#include "openvswitch/list.h"
|
|
|
|
|
#include "openvswitch/meta-flow.h"
|
|
|
|
|
#include "openvswitch/ofp-print.h"
|
|
|
|
|
#include "openvswitch/ofpbuf.h"
|
2018-10-26 15:53:55 -07:00
|
|
|
|
#include "openvswitch/vconn.h"
|
2016-04-14 15:20:21 -07:00
|
|
|
|
#include "openvswitch/vlog.h"
|
|
|
|
|
#include "ovs-lldp.h"
|
2014-06-16 10:48:01 -07:00
|
|
|
|
#include "ovs-numa.h"
|
2016-04-14 15:20:21 -07:00
|
|
|
|
#include "packets.h"
|
2017-11-03 13:53:53 +08:00
|
|
|
|
#include "openvswitch/poll-loop.h"
|
2013-12-13 03:33:49 +00:00
|
|
|
|
#include "seq.h"
|
2016-04-14 15:20:21 -07:00
|
|
|
|
#include "sflow_api.h"
|
2009-12-03 11:28:40 -08:00
|
|
|
|
#include "sha1.h"
|
2016-07-12 16:37:34 -05:00
|
|
|
|
#include "openvswitch/shash.h"
|
2012-05-22 03:47:36 -07:00
|
|
|
|
#include "smap.h"
|
2009-07-08 13:19:16 -07:00
|
|
|
|
#include "socket-util.h"
|
2011-12-21 09:59:16 -08:00
|
|
|
|
#include "stream.h"
|
2010-01-06 14:35:20 -08:00
|
|
|
|
#include "stream-ssl.h"
|
2011-03-25 15:26:30 -07:00
|
|
|
|
#include "sset.h"
|
2010-09-22 16:45:30 -07:00
|
|
|
|
#include "system-stats.h"
|
2009-07-08 13:19:16 -07:00
|
|
|
|
#include "timeval.h"
|
bridge: Clean leaking netdevs when route is added.
When adding a route to a bridge, by executing "$appctl ovs/route/add
$IP/$MASK $BR", a reference to the existing netdev is taken and stored
in an instantiated ip_dev struct which is then stored in an addr_list
list in tnl-ports.c. When OvS is signaled to exit, as a result of a
"$appctl $OVS_PID exit --cleanup", for example, the bridge takes care of
destroying its allocated port and iface structs. While destroying and
freeing an iface, the netdev associated with it is also destroyed.
However, for this to happen its ref_cnt must be 0. Otherwise the
destructor of the netdev (specific to each datapath) won't be called. On
the userspace datapath this means a system interface, such as "br0",
wouldn't get deleted upon exit of OvS (when a route happens to be
assocaited).
This was first observed in the "ptap - triangle bridge setup with L2 and
L3 GRE tunnels" test, which runs as part of the system userspace
testsuite and uses the netdev datapath (as opoosed to several tests
which use the dummy datapath, where this issue isn't seen). The test
would pass every other time and fail the rest of the times because the
needed system interfaces (br-p1, br-p2 and br-p3) were already present
(from the previous successfull run which didn't clean up properly),
leading to a failure.
To fix the leak and clean up the interfaces upon exit, on its final
stage before destroying a netdev, in iface_destroy__(), the bridge calls
tnl_port_map_delete_ipdev() which takes care of freeing the instatiated
ip_dev structs that refer to a specific netdev.
An extra test is also introduced which verifies that the resources used
by OvS netdev datapath have been correctly cleaned up between
OVS_TRAFFIC_VSWITCHD_STOP and AT_CLEANUP.
Signed-off-by: Tiago Lam <tiago.lam@intel.com>
Signed-off-by: Ben Pfaff <blp@ovn.org>
2018-06-21 18:39:16 +01:00
|
|
|
|
#include "tnl-ports.h"
|
2020-01-17 18:47:55 -03:00
|
|
|
|
#include "userspace-tso.h"
|
2009-07-08 13:19:16 -07:00
|
|
|
|
#include "util.h"
|
2009-06-10 15:13:21 -07:00
|
|
|
|
#include "unixctl.h"
|
2012-03-27 15:57:52 -07:00
|
|
|
|
#include "lib/vswitch-idl.h"
|
2009-07-08 13:19:16 -07:00
|
|
|
|
#include "xenserver.h"
|
2011-04-08 13:19:33 -07:00
|
|
|
|
#include "vlan-bitmap.h"
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2010-10-19 14:47:01 -07:00
|
|
|
|
VLOG_DEFINE_THIS_MODULE(bridge);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
coverage: Make the coverage counters catalog program-specific.
Until now, the collection of coverage counters supported by a given OVS
program was not specific to that program. That means that, for example,
even though ovs-dpctl does not have anything to do with mac_learning, it
still has a coverage counter for it. This is confusing, at best.
This commit fixes the problem on some systems, in particular on ones that
use GCC and the GNU linker. It uses the feature of the GNU linker
described in its manual as:
If an orphaned section's name is representable as a C identifier then
the linker will automatically see PROVIDE two symbols: __start_SECNAME
and __end_SECNAME, where SECNAME is the name of the section. These
indicate the start address and end address of the orphaned section
respectively.
Systems that don't support these features retain the earlier behavior.
This commit also fixes the annoyance that files that include coverage
counters must be listed on COVERAGE_FILES in lib/automake.mk.
This commit also fixes the annoyance that modifying any source file that
includes a coverage counter caused all programs that link against
libopenvswitch.a to relink, even programs that the source file was not
linked into. For example, modifying ofproto/ofproto.c (which includes
coverage counters) caused tests/test-aes128 to relink, even though
test-aes128 does not link again ofproto.o.
2010-11-01 14:14:27 -07:00
|
|
|
|
COVERAGE_DEFINE(bridge_reconfigure);
|
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
struct iface {
|
2013-12-11 17:55:26 -08:00
|
|
|
|
/* These members are always valid.
|
|
|
|
|
*
|
|
|
|
|
* They are immutable: they never change between iface_create() and
|
|
|
|
|
* iface_destroy(). */
|
2014-12-15 14:10:38 +01:00
|
|
|
|
struct ovs_list port_elem; /* Element in struct port's "ifaces" list. */
|
2011-04-01 11:42:25 -07:00
|
|
|
|
struct hmap_node name_node; /* In struct bridge's "iface_by_name" hmap. */
|
2013-12-11 17:55:26 -08:00
|
|
|
|
struct hmap_node ofp_port_node; /* In struct bridge's "ifaces" hmap. */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
struct port *port; /* Containing port. */
|
|
|
|
|
char *name; /* Host network device name. */
|
2009-07-30 16:00:41 -07:00
|
|
|
|
struct netdev *netdev; /* Network device. */
|
2013-12-11 17:55:26 -08:00
|
|
|
|
ofp_port_t ofp_port; /* OpenFlow port number. */
|
2014-04-03 13:12:35 -07:00
|
|
|
|
uint64_t change_seq;
|
2013-12-11 17:55:26 -08:00
|
|
|
|
|
|
|
|
|
/* These members are valid only within bridge_reconfigure(). */
|
2010-10-11 10:13:33 -07:00
|
|
|
|
const char *type; /* Usually same as cfg->type. */
|
2009-12-03 11:28:40 -08:00
|
|
|
|
const struct ovsrec_interface *cfg;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
struct mirror {
|
2011-05-11 12:26:06 -07:00
|
|
|
|
struct uuid uuid; /* UUID of this "mirror" record in database. */
|
|
|
|
|
struct hmap_node hmap_node; /* In struct bridge's "mirrors" hmap. */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
struct bridge *bridge;
|
|
|
|
|
char *name;
|
2011-11-20 15:12:36 -08:00
|
|
|
|
const struct ovsrec_mirror *cfg;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
struct port {
|
2011-03-21 10:07:39 -07:00
|
|
|
|
struct hmap_node hmap_node; /* Element in struct bridge's "ports" hmap. */
|
2012-03-28 14:13:02 -07:00
|
|
|
|
struct bridge *bridge;
|
2011-03-21 10:07:39 -07:00
|
|
|
|
char *name;
|
|
|
|
|
|
2010-06-10 14:32:32 -07:00
|
|
|
|
const struct ovsrec_port *cfg;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
|
|
|
|
/* An ordinary bridge port has 1 interface.
|
|
|
|
|
* A bridge port for bonding has at least 2 interfaces. */
|
2014-12-15 14:10:38 +01:00
|
|
|
|
struct ovs_list ifaces; /* List of "struct iface"s. */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
struct bridge {
|
2011-04-04 14:11:16 -07:00
|
|
|
|
struct hmap_node node; /* In 'all_bridges'. */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
char *name; /* User-specified arbitrary name. */
|
2011-04-08 13:50:21 -07:00
|
|
|
|
char *type; /* Datapath type. */
|
2015-08-28 14:55:11 -07:00
|
|
|
|
struct eth_addr ea; /* Bridge Ethernet Address. */
|
|
|
|
|
struct eth_addr default_ea; /* Default MAC. */
|
2010-06-10 14:32:32 -07:00
|
|
|
|
const struct ovsrec_bridge *cfg;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
|
|
|
|
/* OpenFlow switch processing. */
|
|
|
|
|
struct ofproto *ofproto; /* OpenFlow switch. */
|
|
|
|
|
|
|
|
|
|
/* Bridge ports. */
|
2011-03-21 10:07:39 -07:00
|
|
|
|
struct hmap ports; /* "struct port"s indexed by name. */
|
2011-05-09 09:24:39 -07:00
|
|
|
|
struct hmap ifaces; /* "struct iface"s indexed by ofp_port. */
|
2011-04-01 11:42:25 -07:00
|
|
|
|
struct hmap iface_by_name; /* "struct iface"s indexed by name. */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
|
|
|
|
/* Port mirroring. */
|
2011-05-11 12:26:06 -07:00
|
|
|
|
struct hmap mirrors; /* "struct mirror" indexed by UUID. */
|
2011-04-13 11:10:44 -07:00
|
|
|
|
|
2015-02-20 14:17:11 -05:00
|
|
|
|
/* Auto Attach */
|
|
|
|
|
struct hmap mappings; /* "struct" indexed by UUID */
|
|
|
|
|
|
2013-12-11 17:55:26 -08:00
|
|
|
|
/* Used during reconfiguration. */
|
|
|
|
|
struct shash wanted_ports;
|
|
|
|
|
|
2011-04-13 11:10:44 -07:00
|
|
|
|
/* Synthetic local port if necessary. */
|
|
|
|
|
struct ovsrec_port synth_local_port;
|
|
|
|
|
struct ovsrec_interface synth_local_iface;
|
|
|
|
|
struct ovsrec_interface *synth_local_ifacep;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
};
|
|
|
|
|
|
2015-02-20 14:17:11 -05:00
|
|
|
|
struct aa_mapping {
|
|
|
|
|
struct hmap_node hmap_node; /* In struct bridge's "mappings" hmap. */
|
|
|
|
|
struct bridge *bridge;
|
2015-03-03 15:36:28 -08:00
|
|
|
|
uint32_t isid;
|
|
|
|
|
uint16_t vlan;
|
2015-02-20 14:17:11 -05:00
|
|
|
|
char *br_name;
|
|
|
|
|
};
|
|
|
|
|
|
ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables
This patch consumes the CT_Zone and CT_Timeout_Policy tables, maintains
the zone-based configuration in the vswitchd. Whenever there is a
database change, vswitchd will read the datapath, CT_Zone, and
CT_Timeout_Policy tables from ovsdb, builds an internal snapshot of the
database configuration in bridge.c, and pushes down the change into
ofproto and dpif layer.
If a new zone-based timeout policy is added, it updates the zone to
timeout policy mapping in the per datapath type datapath structure in
dpif-backer, and pushes down the timeout policy into the datapath via
dpif interface.
If a timeout policy is no longer used, for kernel datapath, vswitchd
may not be able to remove it from datapath immediately since
datapath flows can still reference the to-be-deleted timeout policies.
Thus, we keep an timeout policy kill list, that vswitchd will go
back to the list periodically and try to kill the unused timeout policies.
Signed-off-by: Yi-Hung Wei <yihung.wei@gmail.com>
Signed-off-by: Justin Pettit <jpettit@ovn.org>
2019-08-28 15:14:26 -07:00
|
|
|
|
/* Internal representation of conntrack zone configuration table in OVSDB. */
|
|
|
|
|
struct ct_zone {
|
|
|
|
|
uint16_t zone_id;
|
|
|
|
|
struct simap tp; /* A map from timeout policy attribute to
|
|
|
|
|
* timeout value. */
|
|
|
|
|
struct hmap_node node; /* Node in 'struct datapath' 'ct_zones'
|
|
|
|
|
* hmap. */
|
|
|
|
|
unsigned int last_used; /* The last idl_seqno that this 'ct_zone' used
|
|
|
|
|
* in OVSDB. This number is used for garbage
|
|
|
|
|
* collection. */
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
/* Internal representation of datapath configuration table in OVSDB. */
|
|
|
|
|
struct datapath {
|
|
|
|
|
char *type; /* Datapath type. */
|
|
|
|
|
struct hmap ct_zones; /* Map of 'struct ct_zone' elements, indexed
|
|
|
|
|
* by 'zone'. */
|
|
|
|
|
struct hmap_node node; /* Node in 'all_datapaths' hmap. */
|
2019-10-04 13:48:58 -07:00
|
|
|
|
struct smap caps; /* Capabilities. */
|
ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables
This patch consumes the CT_Zone and CT_Timeout_Policy tables, maintains
the zone-based configuration in the vswitchd. Whenever there is a
database change, vswitchd will read the datapath, CT_Zone, and
CT_Timeout_Policy tables from ovsdb, builds an internal snapshot of the
database configuration in bridge.c, and pushes down the change into
ofproto and dpif layer.
If a new zone-based timeout policy is added, it updates the zone to
timeout policy mapping in the per datapath type datapath structure in
dpif-backer, and pushes down the timeout policy into the datapath via
dpif interface.
If a timeout policy is no longer used, for kernel datapath, vswitchd
may not be able to remove it from datapath immediately since
datapath flows can still reference the to-be-deleted timeout policies.
Thus, we keep an timeout policy kill list, that vswitchd will go
back to the list periodically and try to kill the unused timeout policies.
Signed-off-by: Yi-Hung Wei <yihung.wei@gmail.com>
Signed-off-by: Justin Pettit <jpettit@ovn.org>
2019-08-28 15:14:26 -07:00
|
|
|
|
unsigned int last_used; /* The last idl_seqno that this 'datapath'
|
|
|
|
|
* used in OVSDB. This number is used for
|
|
|
|
|
* garbage collection. */
|
|
|
|
|
};
|
|
|
|
|
|
2011-04-04 14:11:16 -07:00
|
|
|
|
/* All bridges, indexed by name. */
|
|
|
|
|
static struct hmap all_bridges = HMAP_INITIALIZER(&all_bridges);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables
This patch consumes the CT_Zone and CT_Timeout_Policy tables, maintains
the zone-based configuration in the vswitchd. Whenever there is a
database change, vswitchd will read the datapath, CT_Zone, and
CT_Timeout_Policy tables from ovsdb, builds an internal snapshot of the
database configuration in bridge.c, and pushes down the change into
ofproto and dpif layer.
If a new zone-based timeout policy is added, it updates the zone to
timeout policy mapping in the per datapath type datapath structure in
dpif-backer, and pushes down the timeout policy into the datapath via
dpif interface.
If a timeout policy is no longer used, for kernel datapath, vswitchd
may not be able to remove it from datapath immediately since
datapath flows can still reference the to-be-deleted timeout policies.
Thus, we keep an timeout policy kill list, that vswitchd will go
back to the list periodically and try to kill the unused timeout policies.
Signed-off-by: Yi-Hung Wei <yihung.wei@gmail.com>
Signed-off-by: Justin Pettit <jpettit@ovn.org>
2019-08-28 15:14:26 -07:00
|
|
|
|
/* All datapath configuartions, indexed by type. */
|
|
|
|
|
static struct hmap all_datapaths = HMAP_INITIALIZER(&all_datapaths);
|
|
|
|
|
|
2010-06-10 14:17:41 -07:00
|
|
|
|
/* OVSDB IDL used to obtain configuration. */
|
|
|
|
|
static struct ovsdb_idl *idl;
|
|
|
|
|
|
2013-04-10 10:33:39 -07:00
|
|
|
|
/* We want to complete daemonization, fully detaching from our parent process,
|
|
|
|
|
* only after we have completed our initial configuration, committed our state
|
|
|
|
|
* to the database, and received confirmation back from the database server
|
|
|
|
|
* that it applied the commit. This allows our parent process to know that,
|
|
|
|
|
* post-detach, ephemeral fields such as datapath-id and ofport are very likely
|
|
|
|
|
* to have already been filled in. (It is only "very likely" rather than
|
|
|
|
|
* certain because there is always a slim possibility that the transaction will
|
|
|
|
|
* fail or that some other client has added new bridges, ports, etc. while
|
|
|
|
|
* ovs-vswitchd was configuring using an old configuration.)
|
|
|
|
|
*
|
|
|
|
|
* We only need to do this once for our initial configuration at startup, so
|
|
|
|
|
* 'initial_config_done' tracks whether we've already done it. While we are
|
|
|
|
|
* waiting for a response to our commit, 'daemonize_txn' tracks the transaction
|
|
|
|
|
* itself and is otherwise NULL. */
|
|
|
|
|
static bool initial_config_done;
|
|
|
|
|
static struct ovsdb_idl_txn *daemonize_txn;
|
|
|
|
|
|
2012-03-27 10:16:52 -07:00
|
|
|
|
/* Most recently processed IDL sequence number. */
|
|
|
|
|
static unsigned int idl_seqno;
|
|
|
|
|
|
2013-12-13 03:33:49 +00:00
|
|
|
|
/* Track changes to port connectivity. */
|
|
|
|
|
static uint64_t connectivity_seqno = LLONG_MIN;
|
|
|
|
|
|
2014-04-03 13:12:35 -07:00
|
|
|
|
/* Status update to database.
|
|
|
|
|
*
|
|
|
|
|
* Some information in the database must be kept as up-to-date as possible to
|
|
|
|
|
* allow controllers to respond rapidly to network outages. Those status are
|
|
|
|
|
* updated via the 'status_txn'.
|
|
|
|
|
*
|
|
|
|
|
* We use the global connectivity sequence number to detect the status change.
|
|
|
|
|
* Also, to prevent the status update from sending too much to the database,
|
|
|
|
|
* we check the return status of each update transaction and do not start new
|
|
|
|
|
* update if the previous transaction status is 'TXN_INCOMPLETE'.
|
|
|
|
|
*
|
|
|
|
|
* 'statux_txn' is NULL if there is no ongoing status update.
|
2014-05-30 10:19:26 -07:00
|
|
|
|
*
|
|
|
|
|
* If the previous database transaction was failed (is not 'TXN_SUCCESS',
|
|
|
|
|
* 'TXN_UNCHANGED' or 'TXN_INCOMPLETE'), 'status_txn_try_again' is set to true,
|
|
|
|
|
* which will cause the main thread wake up soon and retry the status update.
|
2014-04-03 13:12:35 -07:00
|
|
|
|
*/
|
|
|
|
|
static struct ovsdb_idl_txn *status_txn;
|
2014-05-30 10:19:26 -07:00
|
|
|
|
static bool status_txn_try_again;
|
2014-04-03 13:12:35 -07:00
|
|
|
|
|
|
|
|
|
/* When the status update transaction returns 'TXN_INCOMPLETE', should register a
|
|
|
|
|
* timeout in 'STATUS_CHECK_AGAIN_MSEC' to check again. */
|
|
|
|
|
#define STATUS_CHECK_AGAIN_MSEC 100
|
|
|
|
|
|
2015-03-31 17:07:03 -07:00
|
|
|
|
/* Statistics update to database. */
|
|
|
|
|
static struct ovsdb_idl_txn *stats_txn;
|
|
|
|
|
|
2012-07-18 10:59:52 -07:00
|
|
|
|
/* Each time this timer expires, the bridge fetches interface and mirror
|
2010-09-23 10:21:40 -07:00
|
|
|
|
* statistics and pushes them into the database. */
|
2014-04-03 13:27:22 -07:00
|
|
|
|
static int stats_timer_interval;
|
|
|
|
|
static long long int stats_timer = LLONG_MIN;
|
2010-06-23 11:02:46 -07:00
|
|
|
|
|
2015-02-20 14:17:11 -05:00
|
|
|
|
/* Each time this timer expires, the bridge fetches the list of port/VLAN
|
|
|
|
|
* membership that has been modified by the AA.
|
|
|
|
|
*/
|
|
|
|
|
#define AA_REFRESH_INTERVAL (1000) /* In milliseconds. */
|
|
|
|
|
static long long int aa_refresh_timer = LLONG_MIN;
|
|
|
|
|
|
2015-07-31 14:35:02 -03:00
|
|
|
|
/* Whenever system interfaces are added, removed or change state, the bridge
|
|
|
|
|
* will be reconfigured.
|
|
|
|
|
*/
|
|
|
|
|
static struct if_notifier *ifnotifier;
|
2016-10-25 15:44:43 -02:00
|
|
|
|
static struct seq *ifaces_changed;
|
|
|
|
|
static uint64_t last_ifaces_changed;
|
2015-07-31 14:35:02 -03:00
|
|
|
|
|
2019-08-02 10:29:52 +02:00
|
|
|
|
/* Default/min/max packet-in queue sizes towards the controllers. */
|
|
|
|
|
#define BRIDGE_CONTROLLER_PACKET_QUEUE_DEFAULT_SIZE 100
|
|
|
|
|
#define BRIDGE_CONTROLLER_PACKET_QUEUE_MIN_SIZE 1
|
|
|
|
|
#define BRIDGE_CONTROLLER_PACKET_QUEUE_MAX_SIZE 512
|
|
|
|
|
|
2011-04-08 13:50:21 -07:00
|
|
|
|
static void add_del_bridges(const struct ovsrec_open_vswitch *);
|
2013-09-30 13:07:35 -07:00
|
|
|
|
static void bridge_run__(void);
|
2011-04-08 13:50:21 -07:00
|
|
|
|
static void bridge_create(const struct ovsrec_bridge *);
|
2016-02-04 09:48:54 -08:00
|
|
|
|
static void bridge_destroy(struct bridge *, bool del);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static struct bridge *bridge_lookup(const char *name);
|
2009-10-29 15:20:21 -07:00
|
|
|
|
static unixctl_cb_func bridge_unixctl_dump_flows;
|
2010-06-18 13:58:42 -07:00
|
|
|
|
static unixctl_cb_func bridge_unixctl_reconnect;
|
2010-07-15 14:53:36 -07:00
|
|
|
|
static size_t bridge_get_controllers(const struct bridge *br,
|
2010-04-20 10:43:42 -07:00
|
|
|
|
struct ovsrec_controller ***controllersp);
|
2013-12-11 17:55:26 -08:00
|
|
|
|
static void bridge_collect_wanted_ports(struct bridge *,
|
|
|
|
|
struct shash *wanted_ports);
|
|
|
|
|
static void bridge_delete_ofprotos(void);
|
|
|
|
|
static void bridge_delete_or_reconfigure_ports(struct bridge *);
|
|
|
|
|
static void bridge_del_ports(struct bridge *,
|
|
|
|
|
const struct shash *wanted_ports);
|
|
|
|
|
static void bridge_add_ports(struct bridge *,
|
|
|
|
|
const struct shash *wanted_ports);
|
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
static void bridge_configure_datapath_id(struct bridge *);
|
|
|
|
|
static void bridge_configure_netflow(struct bridge *);
|
Option to forward BPDU (Ethernet control class) frames
Currently, a NORMAL action bridge drops reserved-multicast-mac addresses;
01-80-c2-00-00-[f0:ff]. A node that does not implement STP should have an
option to forward such frames.
This commit proposes to have a configuration option to allow forwarding of
BPDU class frames. To ensure backward compatibility, this option is
disabled by default.
This config can be set using bridge's other-config column, for e.g
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
Changing this option can revalidate all flows in a software-OVS
implementation (ofproto-dpif)
--------
unit tests:
------------
make config changes, test runtime behavior
-- test runtime behavior --
continuously send packets to br0 with dest-mac=01:80:c2:00:00:00
ovs-dpctl dump-flows br0
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
ovs-dpctl dump-flows br0
ovs-vsctl set bridge br0 other-config:forward-bpdu=false
ovs-dpctl dump-flows br0
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
ovs-dpctl dump-flows br0
ovs-vsctl remove bridge br0 other-config forward-bpdu=true
ovs-dpctl dump-flows br0
--result--
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:29550, bytes:1773000, used:0.004s, actions:drop
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:8209, bytes:492540, used:0.000s, actions:2,0
ovs-vsctl set bridge br0 other-config:forward-bpdu=false
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:19, bytes:1140, used:0.000s, actions:drop
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:29, bytes:1740, used:0.000s, actions:2,0
ovs-vsctl remove bridge br0 other-config forward-bpdu=true
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:0, bytes:0, used:never, actions:drop
Bug #6624
Reported-by: Niklas Andersson <nandersson@nicira.com>
2011-08-09 11:08:27 -07:00
|
|
|
|
static void bridge_configure_forward_bpdu(struct bridge *);
|
2012-12-08 12:32:33 -08:00
|
|
|
|
static void bridge_configure_mac_table(struct bridge *);
|
2014-06-18 22:14:35 -03:00
|
|
|
|
static void bridge_configure_mcast_snooping(struct bridge *);
|
2011-05-04 10:20:04 -07:00
|
|
|
|
static void bridge_configure_sflow(struct bridge *, int *sflow_bridge_number);
|
2013-04-22 10:01:14 -07:00
|
|
|
|
static void bridge_configure_ipfix(struct bridge *);
|
2015-03-05 11:12:21 -08:00
|
|
|
|
static void bridge_configure_spanning_tree(struct bridge *);
|
2012-02-01 10:27:30 -08:00
|
|
|
|
static void bridge_configure_tables(struct bridge *);
|
2012-12-26 15:00:06 -08:00
|
|
|
|
static void bridge_configure_dp_desc(struct bridge *);
|
2020-01-13 12:29:10 +03:00
|
|
|
|
static void bridge_configure_serial_desc(struct bridge *);
|
2015-02-20 14:17:11 -05:00
|
|
|
|
static void bridge_configure_aa(struct bridge *);
|
|
|
|
|
static void bridge_aa_refresh_queued(struct bridge *);
|
|
|
|
|
static bool bridge_aa_need_refresh(struct bridge *);
|
2011-05-11 12:26:06 -07:00
|
|
|
|
static void bridge_configure_remotes(struct bridge *,
|
|
|
|
|
const struct sockaddr_in *managers,
|
|
|
|
|
size_t n_managers);
|
2015-08-28 14:55:11 -07:00
|
|
|
|
static void bridge_pick_local_hw_addr(struct bridge *, struct eth_addr *ea,
|
2009-07-23 14:50:55 -07:00
|
|
|
|
struct iface **hw_addr_iface);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static uint64_t bridge_pick_datapath_id(struct bridge *,
|
2015-08-28 14:55:11 -07:00
|
|
|
|
const struct eth_addr bridge_ea,
|
2009-07-23 14:50:55 -07:00
|
|
|
|
struct iface *hw_addr_iface);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static uint64_t dpid_from_hash(const void *, size_t nbytes);
|
2011-05-04 10:18:23 -07:00
|
|
|
|
static bool bridge_has_bond_fake_iface(const struct bridge *,
|
|
|
|
|
const char *name);
|
|
|
|
|
static bool port_is_bond_fake_iface(const struct port *);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables
This patch consumes the CT_Zone and CT_Timeout_Policy tables, maintains
the zone-based configuration in the vswitchd. Whenever there is a
database change, vswitchd will read the datapath, CT_Zone, and
CT_Timeout_Policy tables from ovsdb, builds an internal snapshot of the
database configuration in bridge.c, and pushes down the change into
ofproto and dpif layer.
If a new zone-based timeout policy is added, it updates the zone to
timeout policy mapping in the per datapath type datapath structure in
dpif-backer, and pushes down the timeout policy into the datapath via
dpif interface.
If a timeout policy is no longer used, for kernel datapath, vswitchd
may not be able to remove it from datapath immediately since
datapath flows can still reference the to-be-deleted timeout policies.
Thus, we keep an timeout policy kill list, that vswitchd will go
back to the list periodically and try to kill the unused timeout policies.
Signed-off-by: Yi-Hung Wei <yihung.wei@gmail.com>
Signed-off-by: Justin Pettit <jpettit@ovn.org>
2019-08-28 15:14:26 -07:00
|
|
|
|
static void datapath_destroy(struct datapath *dp);
|
|
|
|
|
|
2016-03-18 17:14:16 +00:00
|
|
|
|
static unixctl_cb_func qos_unixctl_show_types;
|
2011-03-11 13:44:16 -08:00
|
|
|
|
static unixctl_cb_func qos_unixctl_show;
|
2009-07-15 11:05:37 -07:00
|
|
|
|
|
2011-04-08 13:50:21 -07:00
|
|
|
|
static struct port *port_create(struct bridge *, const struct ovsrec_port *);
|
|
|
|
|
static void port_del_ifaces(struct port *);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static void port_destroy(struct port *);
|
|
|
|
|
static struct port *port_lookup(const struct bridge *, const char *name);
|
2011-05-11 12:26:06 -07:00
|
|
|
|
static void port_configure(struct port *);
|
|
|
|
|
static struct lacp_settings *port_configure_lacp(struct port *,
|
|
|
|
|
struct lacp_settings *);
|
2013-02-04 18:28:57 -08:00
|
|
|
|
static void port_configure_bond(struct port *, struct bond_settings *);
|
2011-10-26 11:39:46 -07:00
|
|
|
|
static bool port_is_synthetic(const struct port *);
|
2011-05-11 12:26:06 -07:00
|
|
|
|
|
2012-07-18 10:59:52 -07:00
|
|
|
|
static void reconfigure_system_stats(const struct ovsrec_open_vswitch *);
|
|
|
|
|
static void run_system_stats(void);
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
static void bridge_configure_mirrors(struct bridge *);
|
|
|
|
|
static struct mirror *mirror_create(struct bridge *,
|
|
|
|
|
const struct ovsrec_mirror *);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static void mirror_destroy(struct mirror *);
|
2011-11-20 15:12:36 -08:00
|
|
|
|
static bool mirror_configure(struct mirror *);
|
|
|
|
|
static void mirror_refresh_stats(struct mirror *);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
static void iface_configure_lacp(struct iface *, struct lacp_slave_settings *);
|
2013-12-11 17:55:26 -08:00
|
|
|
|
static bool iface_create(struct bridge *, const struct ovsrec_interface *,
|
|
|
|
|
const struct ovsrec_port *);
|
2012-11-15 13:53:16 -08:00
|
|
|
|
static bool iface_is_internal(const struct ovsrec_interface *iface,
|
|
|
|
|
const struct ovsrec_bridge *br);
|
2012-04-24 15:59:42 -07:00
|
|
|
|
static const char *iface_get_type(const struct ovsrec_interface *,
|
|
|
|
|
const struct ovsrec_bridge *);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static void iface_destroy(struct iface *);
|
bridge: When ports disappear from a datapath, add them back.
Before commit 2a73b1d73d4bdb (bridge: Reconfigure in single pass.), if a
port disappeared, for one reason or another, from a datapath, the next
bridge reconfiguration pass would notice and, if the port was still
configured in the database, add the port back to the datapath. That
commit, however, removed the logic from bridge_refresh_ofp_port() that
did that and failed to add the same logic to the replacement function
bridge_delete_or_reconfigure_ports(). This commit fixes the problem.
To see this problem on a Linux kernel system:
ovs-vsctl add-br br0 # 1
tunctl -t tap # 2
ovs-vsctl add-port br0 tap # 3
ovs-dpctl show # 4
tunctl -d tap # 5
ovs-dpctl show # 6
tunctl -t tap # 7
ovs-vsctl del-port tap -- add-port br0 tap # 8
ovs-dpctl show # 9
Steps 1-4 create a bridge and a tap and add it to the bridge and
demonstrate that the tap is part of the datapath. Step 5 and 6 delete
the tap and demonstrate that it has therefore disappeared from the
datapath. Step 7 recreates a tap with the same name, and step 8
forces ovs-vswitchd to reconfigure. Step 9 shows the effect of the
fix: without the fix, the new tap is not added back to the datapath;
with this fix, it is.
Special thanks to Gurucharan Shetty <gshetty@nicira.com> for finding a
simple reproduction case and then bisecting to find the commit that
introduced the problem.
Bug #1238467.
Reported-by: Ronald Lee <ronaldlee@vmware.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Ethan Jackson <ethan@nicira.com>
2014-04-23 18:33:36 -07:00
|
|
|
|
static void iface_destroy__(struct iface *);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static struct iface *iface_lookup(const struct bridge *, const char *name);
|
2011-03-11 13:44:16 -08:00
|
|
|
|
static struct iface *iface_find(const char *name);
|
2011-05-09 09:24:39 -07:00
|
|
|
|
static struct iface *iface_from_ofp_port(const struct bridge *,
|
2013-06-19 16:58:44 -07:00
|
|
|
|
ofp_port_t ofp_port);
|
2014-02-19 11:59:33 +01:00
|
|
|
|
static void iface_set_mac(const struct bridge *, const struct port *, struct iface *);
|
2013-06-19 16:58:44 -07:00
|
|
|
|
static void iface_set_ofport(const struct ovsrec_interface *, ofp_port_t ofport);
|
2014-04-10 12:50:10 +02:00
|
|
|
|
static void iface_clear_db_record(const struct ovsrec_interface *if_cfg, char *errp);
|
2011-04-08 13:50:21 -07:00
|
|
|
|
static void iface_configure_qos(struct iface *, const struct ovsrec_qos *);
|
|
|
|
|
static void iface_configure_cfm(struct iface *);
|
2011-09-08 16:15:36 -07:00
|
|
|
|
static void iface_refresh_cfm_stats(struct iface *);
|
2011-06-28 13:17:54 -07:00
|
|
|
|
static void iface_refresh_stats(struct iface *);
|
2014-04-03 13:12:35 -07:00
|
|
|
|
static void iface_refresh_netdev_status(struct iface *);
|
|
|
|
|
static void iface_refresh_ofproto_status(struct iface *);
|
2011-04-13 11:10:44 -07:00
|
|
|
|
static bool iface_is_synthetic(const struct iface *);
|
2013-12-11 15:40:52 -08:00
|
|
|
|
static ofp_port_t iface_get_requested_ofp_port(
|
|
|
|
|
const struct ovsrec_interface *);
|
2013-06-19 16:58:44 -07:00
|
|
|
|
static ofp_port_t iface_pick_ofport(const struct ovsrec_interface *);
|
2011-11-23 17:03:31 -08:00
|
|
|
|
|
2015-03-24 10:39:11 +00:00
|
|
|
|
|
|
|
|
|
static void discover_types(const struct ovsrec_open_vswitch *cfg);
|
|
|
|
|
|
2012-10-08 17:57:22 -07:00
|
|
|
|
static void
|
|
|
|
|
bridge_init_ofproto(const struct ovsrec_open_vswitch *cfg)
|
|
|
|
|
{
|
|
|
|
|
struct shash iface_hints;
|
|
|
|
|
static bool initialized = false;
|
|
|
|
|
int i;
|
|
|
|
|
|
|
|
|
|
if (initialized) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
shash_init(&iface_hints);
|
|
|
|
|
|
2012-11-05 19:00:07 -08:00
|
|
|
|
if (cfg) {
|
|
|
|
|
for (i = 0; i < cfg->n_bridges; i++) {
|
|
|
|
|
const struct ovsrec_bridge *br_cfg = cfg->bridges[i];
|
|
|
|
|
int j;
|
|
|
|
|
|
|
|
|
|
for (j = 0; j < br_cfg->n_ports; j++) {
|
|
|
|
|
struct ovsrec_port *port_cfg = br_cfg->ports[j];
|
|
|
|
|
int k;
|
|
|
|
|
|
|
|
|
|
for (k = 0; k < port_cfg->n_interfaces; k++) {
|
|
|
|
|
struct ovsrec_interface *if_cfg = port_cfg->interfaces[k];
|
|
|
|
|
struct iface_hint *iface_hint;
|
|
|
|
|
|
|
|
|
|
iface_hint = xmalloc(sizeof *iface_hint);
|
|
|
|
|
iface_hint->br_name = br_cfg->name;
|
|
|
|
|
iface_hint->br_type = br_cfg->datapath_type;
|
2012-11-20 03:34:03 -08:00
|
|
|
|
iface_hint->ofp_port = iface_pick_ofport(if_cfg);
|
2012-11-05 19:00:07 -08:00
|
|
|
|
|
|
|
|
|
shash_add(&iface_hints, if_cfg->name, iface_hint);
|
|
|
|
|
}
|
2012-10-08 17:57:22 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
ofproto_init(&iface_hints);
|
|
|
|
|
|
|
|
|
|
shash_destroy_free_data(&iface_hints);
|
|
|
|
|
initialized = true;
|
|
|
|
|
}
|
2015-07-31 14:35:02 -03:00
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
if_change_cb(void *aux OVS_UNUSED)
|
|
|
|
|
{
|
2016-10-25 15:44:43 -02:00
|
|
|
|
seq_change(ifaces_changed);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static bool
|
|
|
|
|
if_notifier_changed(struct if_notifier *notifier OVS_UNUSED)
|
|
|
|
|
{
|
|
|
|
|
uint64_t new_seq;
|
|
|
|
|
bool changed = false;
|
|
|
|
|
new_seq = seq_read(ifaces_changed);
|
|
|
|
|
if (new_seq != last_ifaces_changed) {
|
|
|
|
|
changed = true;
|
|
|
|
|
last_ifaces_changed = new_seq;
|
|
|
|
|
}
|
|
|
|
|
seq_wait(ifaces_changed, last_ifaces_changed);
|
|
|
|
|
return changed;
|
2015-07-31 14:35:02 -03:00
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
|
|
|
|
/* Public functions. */
|
|
|
|
|
|
2010-06-10 14:17:41 -07:00
|
|
|
|
/* Initializes the bridge module, configuring it to obtain its configuration
|
|
|
|
|
* from an OVSDB server accessed over 'remote', which should be a string in a
|
|
|
|
|
* form acceptable to ovsdb_idl_create(). */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
void
|
2010-06-10 14:17:41 -07:00
|
|
|
|
bridge_init(const char *remote)
|
|
|
|
|
{
|
|
|
|
|
/* Create connection to database. */
|
2013-03-15 16:14:28 -07:00
|
|
|
|
idl = ovsdb_idl_create(remote, &ovsrec_idl_class, true, true);
|
2012-03-27 10:16:52 -07:00
|
|
|
|
idl_seqno = ovsdb_idl_get_seqno(idl);
|
2011-07-26 16:49:03 -07:00
|
|
|
|
ovsdb_idl_set_lock(idl, "ovs_vswitchd");
|
2012-09-20 11:13:15 -07:00
|
|
|
|
ovsdb_idl_verify_write_only(idl);
|
2010-06-10 14:17:41 -07:00
|
|
|
|
|
2010-11-16 09:14:52 -08:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_open_vswitch_col_cur_cfg);
|
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_open_vswitch_col_statistics);
|
2015-03-24 10:39:11 +00:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_open_vswitch_col_datapath_types);
|
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_open_vswitch_col_iface_types);
|
2010-08-11 15:29:36 -07:00
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_external_ids);
|
2011-03-29 17:05:52 -07:00
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_ovs_version);
|
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_db_version);
|
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_system_type);
|
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_open_vswitch_col_system_version);
|
2018-05-03 15:08:01 -04:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_open_vswitch_col_dpdk_version);
|
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_open_vswitch_col_dpdk_initialized);
|
2010-08-11 15:29:36 -07:00
|
|
|
|
|
2011-03-29 17:05:52 -07:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_bridge_col_datapath_id);
|
2014-10-16 15:23:11 -07:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_bridge_col_datapath_version);
|
2011-10-14 09:48:17 -07:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_bridge_col_status);
|
2014-08-22 09:01:34 -07:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_bridge_col_rstp_status);
|
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_bridge_col_stp_enable);
|
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_bridge_col_rstp_enable);
|
2010-08-11 15:29:36 -07:00
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_bridge_col_external_ids);
|
|
|
|
|
|
2011-10-14 09:48:17 -07:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_port_col_status);
|
2014-08-22 09:01:34 -07:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_port_col_rstp_status);
|
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_port_col_rstp_statistics);
|
2011-11-14 15:04:14 -08:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_port_col_statistics);
|
2014-10-04 23:35:30 -07:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_port_col_bond_active_slave);
|
2010-08-11 15:29:36 -07:00
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_port_col_external_ids);
|
2015-02-20 14:17:11 -05:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_port_col_trunks);
|
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_port_col_vlan_mode);
|
2011-03-29 17:05:52 -07:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_admin_state);
|
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_duplex);
|
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_link_speed);
|
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_link_state);
|
2011-10-14 12:49:57 -07:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_link_resets);
|
2013-03-12 14:47:22 -07:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_mac_in_use);
|
2013-07-08 13:36:06 -07:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_ifindex);
|
2011-03-29 17:05:52 -07:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_mtu);
|
2010-11-16 09:14:52 -08:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_ofport);
|
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_statistics);
|
2011-03-29 17:05:52 -07:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_status);
|
2011-09-08 16:19:10 -07:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_cfm_fault);
|
2012-02-07 14:35:09 -08:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_cfm_fault_status);
|
2011-08-26 14:54:34 -07:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_cfm_remote_mpids);
|
2013-10-22 05:16:23 +00:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_cfm_flap_count);
|
2012-04-05 14:30:23 -07:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_cfm_health);
|
2012-09-19 19:21:06 -07:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_cfm_remote_opstate);
|
bfd: Implement Bidirectional Forwarding Detection.
Traditionally, Open vSwitch has used a variant of 802.1ag "CFM" for
interface liveness detection. This has served us well until now,
but has several serious drawbacks which have steadily become more
inconvenient. First, the 802.1ag standard does not implement
several useful features forcing us to (optionally) break
compatibility. Second, 802.1.ag is not particularly popular
outside of carrier grade networking equipment. Third, 802.1ag is
simply quite awkward.
In an effort to solve the aforementioned problems, this patch
implements BFD which is ubiquitous, well designed, straight
forward, and implements required features in a standard way. The
initial cut of the protocol focuses on getting the basics of the
specification correct, leaving performance optimizations, and
advanced features as future work. The protocol should be
considered experimental pending future testing.
Signed-off-by: Ethan Jackson <ethan@nicira.com>
2012-06-08 12:42:42 -07:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_bfd_status);
|
2011-09-08 16:19:10 -07:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_lacp_current);
|
2014-04-10 12:50:10 +02:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_interface_col_error);
|
2010-08-11 15:29:36 -07:00
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_interface_col_external_ids);
|
|
|
|
|
|
2011-03-29 17:05:52 -07:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_controller_col_is_connected);
|
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_controller_col_role);
|
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_controller_col_status);
|
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_controller_col_external_ids);
|
|
|
|
|
|
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_qos_col_external_ids);
|
|
|
|
|
|
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_queue_col_external_ids);
|
|
|
|
|
|
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_mirror_col_external_ids);
|
2011-11-20 15:12:36 -08:00
|
|
|
|
ovsdb_idl_omit_alert(idl, &ovsrec_mirror_col_statistics);
|
2011-03-29 17:05:52 -07:00
|
|
|
|
|
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_netflow_col_external_ids);
|
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_sflow_col_external_ids);
|
2013-04-22 10:01:14 -07:00
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_ipfix_col_external_ids);
|
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_flow_sample_collector_set_col_external_ids);
|
2011-03-29 17:05:52 -07:00
|
|
|
|
|
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_manager_col_external_ids);
|
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_manager_col_inactivity_probe);
|
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_manager_col_is_connected);
|
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_manager_col_max_backoff);
|
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_manager_col_status);
|
|
|
|
|
|
|
|
|
|
ovsdb_idl_omit(idl, &ovsrec_ssl_col_external_ids);
|
|
|
|
|
|
2010-06-10 14:17:41 -07:00
|
|
|
|
/* Register unixctl commands. */
|
2016-03-18 17:14:16 +00:00
|
|
|
|
unixctl_command_register("qos/show-types", "interface", 1, 1,
|
|
|
|
|
qos_unixctl_show_types, NULL);
|
2011-12-02 15:29:19 -08:00
|
|
|
|
unixctl_command_register("qos/show", "interface", 1, 1,
|
|
|
|
|
qos_unixctl_show, NULL);
|
Add offload packets statistics
Add argument '--offload-stats' for command ovs-appctl bridge/dump-flows
to display the offloaded packets statistics.
The commands display as below:
orignal command:
ovs-appctl bridge/dump-flows br0
duration=574s, n_packets=1152, n_bytes=110768, priority=0,actions=NORMAL
table_id=254, duration=574s, n_packets=0, n_bytes=0, priority=2,recirc_id=0,actions=drop
table_id=254, duration=574s, n_packets=0, n_bytes=0, priority=0,reg0=0x1,actions=controller(reason=)
table_id=254, duration=574s, n_packets=0, n_bytes=0, priority=0,reg0=0x2,actions=drop
table_id=254, duration=574s, n_packets=0, n_bytes=0, priority=0,reg0=0x3,actions=drop
new command with argument '--offload-stats'
Notice: 'n_offload_packets' are a subset of n_packets and 'n_offload_bytes' are
a subset of n_bytes.
ovs-appctl bridge/dump-flows --offload-stats br0
duration=582s, n_packets=1152, n_bytes=110768, n_offload_packets=1107, n_offload_bytes=107992, priority=0,actions=NORMAL
table_id=254, duration=582s, n_packets=0, n_bytes=0, n_offload_packets=0, n_offload_bytes=0, priority=2,recirc_id=0,actions=drop
table_id=254, duration=582s, n_packets=0, n_bytes=0, n_offload_packets=0, n_offload_bytes=0, priority=0,reg0=0x1,actions=controller(reason=)
table_id=254, duration=582s, n_packets=0, n_bytes=0, n_offload_packets=0, n_offload_bytes=0, priority=0,reg0=0x2,actions=drop
table_id=254, duration=582s, n_packets=0, n_bytes=0, n_offload_packets=0, n_offload_bytes=0, priority=0,reg0=0x3,actions=drop
Signed-off-by: zhaozhanxu <zhaozhanxu@163.com>
Signed-off-by: Simon Horman <simon.horman@netronome.com>
2019-12-05 14:26:25 +08:00
|
|
|
|
unixctl_command_register("bridge/dump-flows", "[--offload-stats] bridge",
|
|
|
|
|
1, 2, bridge_unixctl_dump_flows, NULL);
|
2011-12-02 15:29:19 -08:00
|
|
|
|
unixctl_command_register("bridge/reconnect", "[bridge]", 0, 1,
|
2011-09-26 14:59:35 -07:00
|
|
|
|
bridge_unixctl_reconnect, NULL);
|
2011-04-13 17:58:26 -07:00
|
|
|
|
lacp_init();
|
2010-06-10 14:17:41 -07:00
|
|
|
|
bond_init();
|
2011-05-13 16:53:24 -07:00
|
|
|
|
cfm_init();
|
2015-07-15 23:41:05 +08:00
|
|
|
|
bfd_init();
|
2014-06-16 10:48:01 -07:00
|
|
|
|
ovs_numa_init();
|
2012-01-13 18:49:36 -08:00
|
|
|
|
stp_init();
|
2015-02-20 14:17:11 -05:00
|
|
|
|
lldp_init();
|
2014-08-22 09:01:34 -07:00
|
|
|
|
rstp_init();
|
2016-10-25 15:44:43 -02:00
|
|
|
|
ifaces_changed = seq_create();
|
|
|
|
|
last_ifaces_changed = seq_read(ifaces_changed);
|
2015-07-31 14:35:02 -03:00
|
|
|
|
ifnotifier = if_notifier_create(if_change_cb, NULL);
|
2019-11-05 18:20:51 +01:00
|
|
|
|
if_notifier_manual_set_cb(if_change_cb);
|
2010-06-10 14:17:41 -07:00
|
|
|
|
}
|
|
|
|
|
|
2010-12-13 13:08:31 -08:00
|
|
|
|
void
|
2017-04-24 18:55:04 -07:00
|
|
|
|
bridge_exit(bool delete_datapath)
|
2010-12-13 13:08:31 -08:00
|
|
|
|
{
|
2019-11-05 18:20:51 +01:00
|
|
|
|
if_notifier_manual_set_cb(NULL);
|
2015-07-31 14:35:02 -03:00
|
|
|
|
if_notifier_destroy(ifnotifier);
|
2016-10-25 15:44:43 -02:00
|
|
|
|
seq_destroy(ifaces_changed);
|
ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables
This patch consumes the CT_Zone and CT_Timeout_Policy tables, maintains
the zone-based configuration in the vswitchd. Whenever there is a
database change, vswitchd will read the datapath, CT_Zone, and
CT_Timeout_Policy tables from ovsdb, builds an internal snapshot of the
database configuration in bridge.c, and pushes down the change into
ofproto and dpif layer.
If a new zone-based timeout policy is added, it updates the zone to
timeout policy mapping in the per datapath type datapath structure in
dpif-backer, and pushes down the timeout policy into the datapath via
dpif interface.
If a timeout policy is no longer used, for kernel datapath, vswitchd
may not be able to remove it from datapath immediately since
datapath flows can still reference the to-be-deleted timeout policies.
Thus, we keep an timeout policy kill list, that vswitchd will go
back to the list periodically and try to kill the unused timeout policies.
Signed-off-by: Yi-Hung Wei <yihung.wei@gmail.com>
Signed-off-by: Justin Pettit <jpettit@ovn.org>
2019-08-28 15:14:26 -07:00
|
|
|
|
|
|
|
|
|
struct datapath *dp, *next;
|
|
|
|
|
HMAP_FOR_EACH_SAFE (dp, next, node, &all_datapaths) {
|
|
|
|
|
datapath_destroy(dp);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
struct bridge *br, *next_br;
|
2011-04-04 14:11:16 -07:00
|
|
|
|
HMAP_FOR_EACH_SAFE (br, next_br, node, &all_bridges) {
|
2017-04-24 18:55:04 -07:00
|
|
|
|
bridge_destroy(br, delete_datapath);
|
2010-12-13 13:08:31 -08:00
|
|
|
|
}
|
ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables
This patch consumes the CT_Zone and CT_Timeout_Policy tables, maintains
the zone-based configuration in the vswitchd. Whenever there is a
database change, vswitchd will read the datapath, CT_Zone, and
CT_Timeout_Policy tables from ovsdb, builds an internal snapshot of the
database configuration in bridge.c, and pushes down the change into
ofproto and dpif layer.
If a new zone-based timeout policy is added, it updates the zone to
timeout policy mapping in the per datapath type datapath structure in
dpif-backer, and pushes down the timeout policy into the datapath via
dpif interface.
If a timeout policy is no longer used, for kernel datapath, vswitchd
may not be able to remove it from datapath immediately since
datapath flows can still reference the to-be-deleted timeout policies.
Thus, we keep an timeout policy kill list, that vswitchd will go
back to the list periodically and try to kill the unused timeout policies.
Signed-off-by: Yi-Hung Wei <yihung.wei@gmail.com>
Signed-off-by: Justin Pettit <jpettit@ovn.org>
2019-08-28 15:14:26 -07:00
|
|
|
|
|
2010-12-13 13:08:31 -08:00
|
|
|
|
ovsdb_idl_destroy(idl);
|
|
|
|
|
}
|
|
|
|
|
|
2010-04-26 10:48:31 -07:00
|
|
|
|
/* Looks at the list of managers in 'ovs_cfg' and extracts their remote IP
|
|
|
|
|
* addresses and ports into '*managersp' and '*n_managersp'. The caller is
|
|
|
|
|
* responsible for freeing '*managersp' (with free()).
|
|
|
|
|
*
|
|
|
|
|
* You may be asking yourself "why does ovs-vswitchd care?", because
|
|
|
|
|
* ovsdb-server is responsible for connecting to the managers, and ovs-vswitchd
|
|
|
|
|
* should not be and in fact is not directly involved in that. But
|
|
|
|
|
* ovs-vswitchd needs to make sure that ovsdb-server can reach the managers, so
|
|
|
|
|
* it has to tell in-band control where the managers are to enable that.
|
2015-04-20 15:01:40 -07:00
|
|
|
|
* (Thus, only managers connected in-band and with non-loopback addresses
|
|
|
|
|
* are collected.)
|
2010-04-26 10:48:31 -07:00
|
|
|
|
*/
|
|
|
|
|
static void
|
2010-11-05 10:22:18 -07:00
|
|
|
|
collect_in_band_managers(const struct ovsrec_open_vswitch *ovs_cfg,
|
|
|
|
|
struct sockaddr_in **managersp, size_t *n_managersp)
|
2010-04-26 10:48:31 -07:00
|
|
|
|
{
|
|
|
|
|
struct sockaddr_in *managers = NULL;
|
|
|
|
|
size_t n_managers = 0;
|
2011-03-25 15:26:30 -07:00
|
|
|
|
struct sset targets;
|
2010-11-05 10:22:18 -07:00
|
|
|
|
size_t i;
|
|
|
|
|
|
2011-02-18 09:50:12 -08:00
|
|
|
|
/* Collect all of the potential targets from the "targets" columns of the
|
|
|
|
|
* rows pointed to by "manager_options", excluding any that are
|
|
|
|
|
* out-of-band. */
|
2011-03-25 15:26:30 -07:00
|
|
|
|
sset_init(&targets);
|
2010-11-05 10:22:18 -07:00
|
|
|
|
for (i = 0; i < ovs_cfg->n_manager_options; i++) {
|
|
|
|
|
struct ovsrec_manager *m = ovs_cfg->manager_options[i];
|
|
|
|
|
|
|
|
|
|
if (m->connection_mode && !strcmp(m->connection_mode, "out-of-band")) {
|
2011-03-25 15:26:30 -07:00
|
|
|
|
sset_find_and_delete(&targets, m->target);
|
2010-11-05 10:22:18 -07:00
|
|
|
|
} else {
|
2011-03-25 15:26:30 -07:00
|
|
|
|
sset_add(&targets, m->target);
|
2010-11-05 10:22:18 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
2010-04-26 10:48:31 -07:00
|
|
|
|
|
2010-11-05 10:22:18 -07:00
|
|
|
|
/* Now extract the targets' IP addresses. */
|
2011-03-25 15:26:30 -07:00
|
|
|
|
if (!sset_is_empty(&targets)) {
|
|
|
|
|
const char *target;
|
2010-04-26 10:48:31 -07:00
|
|
|
|
|
2011-03-25 15:26:30 -07:00
|
|
|
|
managers = xmalloc(sset_count(&targets) * sizeof *managers);
|
|
|
|
|
SSET_FOR_EACH (target, &targets) {
|
2014-08-05 13:51:19 -07:00
|
|
|
|
union {
|
|
|
|
|
struct sockaddr_storage ss;
|
|
|
|
|
struct sockaddr_in in;
|
|
|
|
|
} sa;
|
2010-04-26 10:48:31 -07:00
|
|
|
|
|
2015-04-20 15:01:40 -07:00
|
|
|
|
/* Ignore loopback. */
|
2015-03-11 13:32:01 -07:00
|
|
|
|
if (stream_parse_target_with_default_port(target, OVSDB_PORT,
|
2014-08-05 13:51:19 -07:00
|
|
|
|
&sa.ss)
|
2015-04-20 15:01:40 -07:00
|
|
|
|
&& sa.ss.ss_family == AF_INET
|
|
|
|
|
&& sa.in.sin_addr.s_addr != htonl(INADDR_LOOPBACK)) {
|
2014-08-05 13:51:19 -07:00
|
|
|
|
managers[n_managers++] = sa.in;
|
2010-04-26 10:48:31 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
2011-03-25 15:26:30 -07:00
|
|
|
|
sset_destroy(&targets);
|
2010-04-26 10:48:31 -07:00
|
|
|
|
|
|
|
|
|
*managersp = managers;
|
|
|
|
|
*n_managersp = n_managers;
|
|
|
|
|
}
|
|
|
|
|
|
2017-01-27 16:41:36 -08:00
|
|
|
|
static void
|
|
|
|
|
config_ofproto_types(const struct smap *other_config)
|
|
|
|
|
{
|
|
|
|
|
struct sset types;
|
|
|
|
|
const char *type;
|
|
|
|
|
|
|
|
|
|
/* Pass custom configuration to datapath types. */
|
|
|
|
|
sset_init(&types);
|
|
|
|
|
ofproto_enumerate_types(&types);
|
|
|
|
|
SSET_FOR_EACH (type, &types) {
|
|
|
|
|
ofproto_type_set_config(type, other_config);
|
|
|
|
|
}
|
|
|
|
|
sset_destroy(&types);
|
|
|
|
|
}
|
|
|
|
|
|
ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables
This patch consumes the CT_Zone and CT_Timeout_Policy tables, maintains
the zone-based configuration in the vswitchd. Whenever there is a
database change, vswitchd will read the datapath, CT_Zone, and
CT_Timeout_Policy tables from ovsdb, builds an internal snapshot of the
database configuration in bridge.c, and pushes down the change into
ofproto and dpif layer.
If a new zone-based timeout policy is added, it updates the zone to
timeout policy mapping in the per datapath type datapath structure in
dpif-backer, and pushes down the timeout policy into the datapath via
dpif interface.
If a timeout policy is no longer used, for kernel datapath, vswitchd
may not be able to remove it from datapath immediately since
datapath flows can still reference the to-be-deleted timeout policies.
Thus, we keep an timeout policy kill list, that vswitchd will go
back to the list periodically and try to kill the unused timeout policies.
Signed-off-by: Yi-Hung Wei <yihung.wei@gmail.com>
Signed-off-by: Justin Pettit <jpettit@ovn.org>
2019-08-28 15:14:26 -07:00
|
|
|
|
static void
|
|
|
|
|
get_timeout_policy_from_ovsrec(struct simap *tp,
|
|
|
|
|
const struct ovsrec_ct_timeout_policy *tp_cfg)
|
|
|
|
|
{
|
|
|
|
|
for (size_t i = 0; i < tp_cfg->n_timeouts; i++) {
|
|
|
|
|
simap_put(tp, tp_cfg->key_timeouts[i], tp_cfg->value_timeouts[i]);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static struct ct_zone *
|
|
|
|
|
ct_zone_lookup(struct hmap *ct_zones, uint16_t zone_id)
|
|
|
|
|
{
|
|
|
|
|
struct ct_zone *ct_zone;
|
|
|
|
|
|
|
|
|
|
HMAP_FOR_EACH_WITH_HASH (ct_zone, node, hash_int(zone_id, 0), ct_zones) {
|
|
|
|
|
if (ct_zone->zone_id == zone_id) {
|
|
|
|
|
return ct_zone;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
return NULL;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static struct ct_zone *
|
|
|
|
|
ct_zone_alloc(uint16_t zone_id, struct ovsrec_ct_timeout_policy *tp_cfg)
|
|
|
|
|
{
|
|
|
|
|
struct ct_zone *ct_zone = xzalloc(sizeof *ct_zone);
|
|
|
|
|
|
|
|
|
|
ct_zone->zone_id = zone_id;
|
|
|
|
|
simap_init(&ct_zone->tp);
|
|
|
|
|
get_timeout_policy_from_ovsrec(&ct_zone->tp, tp_cfg);
|
|
|
|
|
return ct_zone;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
ct_zone_remove_and_destroy(struct datapath *dp, struct ct_zone *ct_zone)
|
|
|
|
|
{
|
|
|
|
|
hmap_remove(&dp->ct_zones, &ct_zone->node);
|
|
|
|
|
simap_destroy(&ct_zone->tp);
|
|
|
|
|
free(ct_zone);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Replace 'old_tp' by 'new_tp' (destroyed 'new_tp'). Returns true if 'old_tp'
|
|
|
|
|
* and 'new_tp' contains different data, false if they are the same. */
|
|
|
|
|
static bool
|
|
|
|
|
update_timeout_policy(struct simap *old_tp, struct simap *new_tp)
|
|
|
|
|
{
|
|
|
|
|
bool changed = !simap_equal(old_tp, new_tp);
|
|
|
|
|
if (changed) {
|
|
|
|
|
simap_swap(old_tp, new_tp);
|
|
|
|
|
}
|
|
|
|
|
simap_destroy(new_tp);
|
|
|
|
|
return changed;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static struct datapath *
|
|
|
|
|
datapath_lookup(const char *type)
|
|
|
|
|
{
|
|
|
|
|
struct datapath *dp;
|
|
|
|
|
|
|
|
|
|
HMAP_FOR_EACH_WITH_HASH (dp, node, hash_string(type, 0), &all_datapaths) {
|
|
|
|
|
if (!strcmp(dp->type, type)) {
|
|
|
|
|
return dp;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
return NULL;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static struct datapath *
|
|
|
|
|
datapath_create(const char *type)
|
|
|
|
|
{
|
|
|
|
|
struct datapath *dp = xzalloc(sizeof *dp);
|
|
|
|
|
dp->type = xstrdup(type);
|
|
|
|
|
hmap_init(&dp->ct_zones);
|
|
|
|
|
hmap_insert(&all_datapaths, &dp->node, hash_string(type, 0));
|
2019-10-04 13:48:58 -07:00
|
|
|
|
smap_init(&dp->caps);
|
ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables
This patch consumes the CT_Zone and CT_Timeout_Policy tables, maintains
the zone-based configuration in the vswitchd. Whenever there is a
database change, vswitchd will read the datapath, CT_Zone, and
CT_Timeout_Policy tables from ovsdb, builds an internal snapshot of the
database configuration in bridge.c, and pushes down the change into
ofproto and dpif layer.
If a new zone-based timeout policy is added, it updates the zone to
timeout policy mapping in the per datapath type datapath structure in
dpif-backer, and pushes down the timeout policy into the datapath via
dpif interface.
If a timeout policy is no longer used, for kernel datapath, vswitchd
may not be able to remove it from datapath immediately since
datapath flows can still reference the to-be-deleted timeout policies.
Thus, we keep an timeout policy kill list, that vswitchd will go
back to the list periodically and try to kill the unused timeout policies.
Signed-off-by: Yi-Hung Wei <yihung.wei@gmail.com>
Signed-off-by: Justin Pettit <jpettit@ovn.org>
2019-08-28 15:14:26 -07:00
|
|
|
|
return dp;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
datapath_destroy(struct datapath *dp)
|
|
|
|
|
{
|
|
|
|
|
if (dp) {
|
|
|
|
|
struct ct_zone *ct_zone, *next;
|
|
|
|
|
HMAP_FOR_EACH_SAFE (ct_zone, next, node, &dp->ct_zones) {
|
|
|
|
|
ofproto_ct_del_zone_timeout_policy(dp->type, ct_zone->zone_id);
|
|
|
|
|
ct_zone_remove_and_destroy(dp, ct_zone);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
hmap_remove(&all_datapaths, &dp->node);
|
|
|
|
|
hmap_destroy(&dp->ct_zones);
|
|
|
|
|
free(dp->type);
|
2019-10-04 13:48:58 -07:00
|
|
|
|
smap_destroy(&dp->caps);
|
ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables
This patch consumes the CT_Zone and CT_Timeout_Policy tables, maintains
the zone-based configuration in the vswitchd. Whenever there is a
database change, vswitchd will read the datapath, CT_Zone, and
CT_Timeout_Policy tables from ovsdb, builds an internal snapshot of the
database configuration in bridge.c, and pushes down the change into
ofproto and dpif layer.
If a new zone-based timeout policy is added, it updates the zone to
timeout policy mapping in the per datapath type datapath structure in
dpif-backer, and pushes down the timeout policy into the datapath via
dpif interface.
If a timeout policy is no longer used, for kernel datapath, vswitchd
may not be able to remove it from datapath immediately since
datapath flows can still reference the to-be-deleted timeout policies.
Thus, we keep an timeout policy kill list, that vswitchd will go
back to the list periodically and try to kill the unused timeout policies.
Signed-off-by: Yi-Hung Wei <yihung.wei@gmail.com>
Signed-off-by: Justin Pettit <jpettit@ovn.org>
2019-08-28 15:14:26 -07:00
|
|
|
|
free(dp);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
ct_zones_reconfigure(struct datapath *dp, struct ovsrec_datapath *dp_cfg)
|
|
|
|
|
{
|
|
|
|
|
struct ct_zone *ct_zone, *next;
|
|
|
|
|
|
|
|
|
|
/* Add new 'ct_zone's or update existing 'ct_zone's based on the database
|
|
|
|
|
* state. */
|
|
|
|
|
for (size_t i = 0; i < dp_cfg->n_ct_zones; i++) {
|
|
|
|
|
uint16_t zone_id = dp_cfg->key_ct_zones[i];
|
|
|
|
|
struct ovsrec_ct_zone *zone_cfg = dp_cfg->value_ct_zones[i];
|
|
|
|
|
struct ovsrec_ct_timeout_policy *tp_cfg = zone_cfg->timeout_policy;
|
|
|
|
|
|
|
|
|
|
ct_zone = ct_zone_lookup(&dp->ct_zones, zone_id);
|
|
|
|
|
if (ct_zone) {
|
|
|
|
|
struct simap new_tp = SIMAP_INITIALIZER(&new_tp);
|
|
|
|
|
get_timeout_policy_from_ovsrec(&new_tp, tp_cfg);
|
|
|
|
|
if (update_timeout_policy(&ct_zone->tp, &new_tp)) {
|
|
|
|
|
ofproto_ct_set_zone_timeout_policy(dp->type, ct_zone->zone_id,
|
|
|
|
|
&ct_zone->tp);
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
ct_zone = ct_zone_alloc(zone_id, tp_cfg);
|
|
|
|
|
hmap_insert(&dp->ct_zones, &ct_zone->node, hash_int(zone_id, 0));
|
|
|
|
|
ofproto_ct_set_zone_timeout_policy(dp->type, ct_zone->zone_id,
|
|
|
|
|
&ct_zone->tp);
|
|
|
|
|
}
|
|
|
|
|
ct_zone->last_used = idl_seqno;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Purge 'ct_zone's no longer found in the database. */
|
|
|
|
|
HMAP_FOR_EACH_SAFE (ct_zone, next, node, &dp->ct_zones) {
|
|
|
|
|
if (ct_zone->last_used != idl_seqno) {
|
|
|
|
|
ofproto_ct_del_zone_timeout_policy(dp->type, ct_zone->zone_id);
|
|
|
|
|
ct_zone_remove_and_destroy(dp, ct_zone);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2019-10-04 13:48:58 -07:00
|
|
|
|
static void
|
|
|
|
|
dp_capability_reconfigure(struct datapath *dp,
|
|
|
|
|
struct ovsrec_datapath *dp_cfg)
|
|
|
|
|
{
|
|
|
|
|
struct smap_node *node;
|
|
|
|
|
struct smap cap;
|
|
|
|
|
|
|
|
|
|
smap_init(&cap);
|
|
|
|
|
ofproto_get_datapath_cap(dp->type, &cap);
|
|
|
|
|
|
|
|
|
|
SMAP_FOR_EACH (node, &cap) {
|
|
|
|
|
ovsrec_datapath_update_capabilities_setkey(dp_cfg, node->key,
|
|
|
|
|
node->value);
|
|
|
|
|
}
|
|
|
|
|
smap_destroy(&cap);
|
|
|
|
|
}
|
|
|
|
|
|
ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables
This patch consumes the CT_Zone and CT_Timeout_Policy tables, maintains
the zone-based configuration in the vswitchd. Whenever there is a
database change, vswitchd will read the datapath, CT_Zone, and
CT_Timeout_Policy tables from ovsdb, builds an internal snapshot of the
database configuration in bridge.c, and pushes down the change into
ofproto and dpif layer.
If a new zone-based timeout policy is added, it updates the zone to
timeout policy mapping in the per datapath type datapath structure in
dpif-backer, and pushes down the timeout policy into the datapath via
dpif interface.
If a timeout policy is no longer used, for kernel datapath, vswitchd
may not be able to remove it from datapath immediately since
datapath flows can still reference the to-be-deleted timeout policies.
Thus, we keep an timeout policy kill list, that vswitchd will go
back to the list periodically and try to kill the unused timeout policies.
Signed-off-by: Yi-Hung Wei <yihung.wei@gmail.com>
Signed-off-by: Justin Pettit <jpettit@ovn.org>
2019-08-28 15:14:26 -07:00
|
|
|
|
static void
|
|
|
|
|
datapath_reconfigure(const struct ovsrec_open_vswitch *cfg)
|
|
|
|
|
{
|
|
|
|
|
struct datapath *dp, *next;
|
|
|
|
|
|
|
|
|
|
/* Add new 'datapath's or update existing ones. */
|
|
|
|
|
for (size_t i = 0; i < cfg->n_datapaths; i++) {
|
|
|
|
|
struct ovsrec_datapath *dp_cfg = cfg->value_datapaths[i];
|
|
|
|
|
char *dp_name = cfg->key_datapaths[i];
|
|
|
|
|
|
|
|
|
|
dp = datapath_lookup(dp_name);
|
|
|
|
|
if (!dp) {
|
|
|
|
|
dp = datapath_create(dp_name);
|
2019-10-04 13:48:58 -07:00
|
|
|
|
dp_capability_reconfigure(dp, dp_cfg);
|
ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables
This patch consumes the CT_Zone and CT_Timeout_Policy tables, maintains
the zone-based configuration in the vswitchd. Whenever there is a
database change, vswitchd will read the datapath, CT_Zone, and
CT_Timeout_Policy tables from ovsdb, builds an internal snapshot of the
database configuration in bridge.c, and pushes down the change into
ofproto and dpif layer.
If a new zone-based timeout policy is added, it updates the zone to
timeout policy mapping in the per datapath type datapath structure in
dpif-backer, and pushes down the timeout policy into the datapath via
dpif interface.
If a timeout policy is no longer used, for kernel datapath, vswitchd
may not be able to remove it from datapath immediately since
datapath flows can still reference the to-be-deleted timeout policies.
Thus, we keep an timeout policy kill list, that vswitchd will go
back to the list periodically and try to kill the unused timeout policies.
Signed-off-by: Yi-Hung Wei <yihung.wei@gmail.com>
Signed-off-by: Justin Pettit <jpettit@ovn.org>
2019-08-28 15:14:26 -07:00
|
|
|
|
}
|
|
|
|
|
dp->last_used = idl_seqno;
|
|
|
|
|
ct_zones_reconfigure(dp, dp_cfg);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Purge deleted 'datapath's. */
|
|
|
|
|
HMAP_FOR_EACH_SAFE (dp, next, node, &all_datapaths) {
|
|
|
|
|
if (dp->last_used != idl_seqno) {
|
|
|
|
|
datapath_destroy(dp);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2010-06-10 14:17:41 -07:00
|
|
|
|
static void
|
2009-12-03 11:28:40 -08:00
|
|
|
|
bridge_reconfigure(const struct ovsrec_open_vswitch *ovs_cfg)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2013-12-11 17:55:26 -08:00
|
|
|
|
struct sockaddr_in *managers;
|
|
|
|
|
struct bridge *br, *next;
|
|
|
|
|
int sflow_bridge_number;
|
|
|
|
|
size_t n_managers;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
|
|
|
|
COVERAGE_INC(bridge_reconfigure);
|
|
|
|
|
|
2013-09-24 13:39:56 -07:00
|
|
|
|
ofproto_set_flow_limit(smap_get_int(&ovs_cfg->other_config, "flow-limit",
|
|
|
|
|
OFPROTO_FLOW_LIMIT_DEFAULT));
|
2014-03-05 16:56:05 -08:00
|
|
|
|
ofproto_set_max_idle(smap_get_int(&ovs_cfg->other_config, "max-idle",
|
|
|
|
|
OFPROTO_MAX_IDLE_DEFAULT));
|
2019-07-21 11:34:21 +03:00
|
|
|
|
ofproto_set_max_revalidator(smap_get_int(&ovs_cfg->other_config,
|
|
|
|
|
"max-revalidator",
|
|
|
|
|
OFPROTO_MAX_REVALIDATOR_DEFAULT));
|
2019-07-21 11:34:23 +03:00
|
|
|
|
ofproto_set_min_revalidate_pps(
|
|
|
|
|
smap_get_int(&ovs_cfg->other_config, "min-revalidate-pps",
|
|
|
|
|
OFPROTO_MIN_REVALIDATE_PPS_DEFAULT));
|
2017-03-01 17:47:59 -05:00
|
|
|
|
ofproto_set_vlan_limit(smap_get_int(&ovs_cfg->other_config, "vlan-limit",
|
|
|
|
|
LEGACY_MAX_VLAN_HEADERS));
|
2018-04-19 14:09:38 -03:00
|
|
|
|
ofproto_set_bundle_idle_timeout(smap_get_int(&ovs_cfg->other_config,
|
|
|
|
|
"bundle-idle-timeout", 0));
|
2013-11-08 13:47:49 -08:00
|
|
|
|
ofproto_set_threads(
|
2013-09-24 13:39:56 -07:00
|
|
|
|
smap_get_int(&ovs_cfg->other_config, "n-handler-threads", 0),
|
|
|
|
|
smap_get_int(&ovs_cfg->other_config, "n-revalidator-threads", 0));
|
2013-08-15 00:23:54 -07:00
|
|
|
|
|
2012-04-20 19:11:35 -07:00
|
|
|
|
/* Destroy "struct bridge"s, "struct port"s, and "struct iface"s according
|
2013-12-11 17:55:26 -08:00
|
|
|
|
* to 'ovs_cfg', with only very minimal configuration otherwise.
|
2011-04-08 13:50:21 -07:00
|
|
|
|
*
|
2012-04-20 19:11:35 -07:00
|
|
|
|
* This is mostly an update to bridge data structures. Nothing is pushed
|
|
|
|
|
* down to ofproto or lower layers. */
|
2011-04-08 13:50:21 -07:00
|
|
|
|
add_del_bridges(ovs_cfg);
|
2011-04-04 14:11:16 -07:00
|
|
|
|
HMAP_FOR_EACH (br, node, &all_bridges) {
|
2016-04-25 11:27:58 -07:00
|
|
|
|
bridge_collect_wanted_ports(br, &br->wanted_ports);
|
2013-12-11 17:55:26 -08:00
|
|
|
|
bridge_del_ports(br, &br->wanted_ports);
|
2009-12-03 11:28:40 -08:00
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2013-12-11 17:55:26 -08:00
|
|
|
|
/* Start pushing configuration changes down to the ofproto layer:
|
|
|
|
|
*
|
|
|
|
|
* - Delete ofprotos that are no longer configured.
|
|
|
|
|
*
|
|
|
|
|
* - Delete ports that are no longer configured.
|
|
|
|
|
*
|
|
|
|
|
* - Reconfigure existing ports to their desired configurations, or
|
|
|
|
|
* delete them if not possible.
|
|
|
|
|
*
|
|
|
|
|
* We have to do all the deletions before we can do any additions, because
|
|
|
|
|
* the ports to be added might require resources that will be freed up by
|
|
|
|
|
* deletions (they might especially overlap in name). */
|
|
|
|
|
bridge_delete_ofprotos();
|
2012-04-20 19:11:35 -07:00
|
|
|
|
HMAP_FOR_EACH (br, node, &all_bridges) {
|
2013-12-11 17:55:26 -08:00
|
|
|
|
if (br->ofproto) {
|
|
|
|
|
bridge_delete_or_reconfigure_ports(br);
|
2009-12-03 11:28:40 -08:00
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2012-07-18 10:59:52 -07:00
|
|
|
|
|
2013-12-11 17:55:26 -08:00
|
|
|
|
/* Finish pushing configuration changes to the ofproto layer:
|
|
|
|
|
*
|
|
|
|
|
* - Create ofprotos that are missing.
|
|
|
|
|
*
|
|
|
|
|
* - Add ports that are missing. */
|
|
|
|
|
HMAP_FOR_EACH_SAFE (br, next, node, &all_bridges) {
|
|
|
|
|
if (!br->ofproto) {
|
|
|
|
|
int error;
|
2012-04-20 19:11:35 -07:00
|
|
|
|
|
2013-12-11 17:55:26 -08:00
|
|
|
|
error = ofproto_create(br->name, br->type, &br->ofproto);
|
|
|
|
|
if (error) {
|
|
|
|
|
VLOG_ERR("failed to create bridge %s: %s", br->name,
|
|
|
|
|
ovs_strerror(error));
|
|
|
|
|
shash_destroy(&br->wanted_ports);
|
2016-02-04 09:48:54 -08:00
|
|
|
|
bridge_destroy(br, true);
|
2014-10-16 15:23:11 -07:00
|
|
|
|
} else {
|
|
|
|
|
/* Trigger storing datapath version. */
|
|
|
|
|
seq_change(connectivity_seq_get());
|
2012-03-02 13:26:35 -08:00
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
2017-02-15 10:02:40 -08:00
|
|
|
|
|
|
|
|
|
config_ofproto_types(&ovs_cfg->other_config);
|
|
|
|
|
|
2011-05-04 10:18:23 -07:00
|
|
|
|
HMAP_FOR_EACH (br, node, &all_bridges) {
|
2013-12-11 17:55:26 -08:00
|
|
|
|
bridge_add_ports(br, &br->wanted_ports);
|
|
|
|
|
shash_destroy(&br->wanted_ports);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2013-12-11 17:55:26 -08:00
|
|
|
|
reconfigure_system_stats(ovs_cfg);
|
ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables
This patch consumes the CT_Zone and CT_Timeout_Policy tables, maintains
the zone-based configuration in the vswitchd. Whenever there is a
database change, vswitchd will read the datapath, CT_Zone, and
CT_Timeout_Policy tables from ovsdb, builds an internal snapshot of the
database configuration in bridge.c, and pushes down the change into
ofproto and dpif layer.
If a new zone-based timeout policy is added, it updates the zone to
timeout policy mapping in the per datapath type datapath structure in
dpif-backer, and pushes down the timeout policy into the datapath via
dpif interface.
If a timeout policy is no longer used, for kernel datapath, vswitchd
may not be able to remove it from datapath immediately since
datapath flows can still reference the to-be-deleted timeout policies.
Thus, we keep an timeout policy kill list, that vswitchd will go
back to the list periodically and try to kill the unused timeout policies.
Signed-off-by: Yi-Hung Wei <yihung.wei@gmail.com>
Signed-off-by: Justin Pettit <jpettit@ovn.org>
2019-08-28 15:14:26 -07:00
|
|
|
|
datapath_reconfigure(ovs_cfg);
|
2012-04-20 19:11:35 -07:00
|
|
|
|
|
2011-04-08 13:50:21 -07:00
|
|
|
|
/* Complete the configuration. */
|
|
|
|
|
sflow_bridge_number = 0;
|
|
|
|
|
collect_in_band_managers(ovs_cfg, &managers, &n_managers);
|
2011-04-04 14:11:16 -07:00
|
|
|
|
HMAP_FOR_EACH (br, node, &all_bridges) {
|
2011-03-21 10:07:39 -07:00
|
|
|
|
struct port *port;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-11-30 12:09:35 -08:00
|
|
|
|
/* We need the datapath ID early to allow LACP ports to use it as the
|
|
|
|
|
* default system ID. */
|
|
|
|
|
bridge_configure_datapath_id(br);
|
|
|
|
|
|
2011-03-21 10:07:39 -07:00
|
|
|
|
HMAP_FOR_EACH (port, hmap_node, &br->ports) {
|
2011-03-21 10:24:32 -07:00
|
|
|
|
struct iface *iface;
|
2009-10-02 13:29:01 -07:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
port_configure(port);
|
2010-06-17 15:04:12 -07:00
|
|
|
|
|
2011-05-25 13:23:49 -07:00
|
|
|
|
LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
|
2014-01-30 16:57:16 -08:00
|
|
|
|
iface_set_ofport(iface->cfg, iface->ofp_port);
|
2014-04-10 12:50:10 +02:00
|
|
|
|
/* Clear eventual previous errors */
|
|
|
|
|
ovsrec_interface_set_error(iface->cfg, NULL);
|
2011-04-08 13:50:21 -07:00
|
|
|
|
iface_configure_cfm(iface);
|
|
|
|
|
iface_configure_qos(iface, port->cfg->qos);
|
2014-02-19 11:59:33 +01:00
|
|
|
|
iface_set_mac(br, port, iface);
|
bfd: Implement Bidirectional Forwarding Detection.
Traditionally, Open vSwitch has used a variant of 802.1ag "CFM" for
interface liveness detection. This has served us well until now,
but has several serious drawbacks which have steadily become more
inconvenient. First, the 802.1ag standard does not implement
several useful features forcing us to (optionally) break
compatibility. Second, 802.1.ag is not particularly popular
outside of carrier grade networking equipment. Third, 802.1ag is
simply quite awkward.
In an effort to solve the aforementioned problems, this patch
implements BFD which is ubiquitous, well designed, straight
forward, and implements required features in a standard way. The
initial cut of the protocol focuses on getting the basics of the
specification correct, leaving performance optimizations, and
advanced features as future work. The protocol should be
considered experimental pending future testing.
Signed-off-by: Ethan Jackson <ethan@nicira.com>
2012-06-08 12:42:42 -07:00
|
|
|
|
ofproto_port_set_bfd(br->ofproto, iface->ofp_port,
|
|
|
|
|
&iface->cfg->bfd);
|
2015-02-20 14:17:11 -05:00
|
|
|
|
ofproto_port_set_lldp(br->ofproto, iface->ofp_port,
|
|
|
|
|
&iface->cfg->lldp);
|
2016-07-27 17:44:42 +03:00
|
|
|
|
ofproto_port_set_config(br->ofproto, iface->ofp_port,
|
|
|
|
|
&iface->cfg->other_config);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
2011-05-11 12:26:06 -07:00
|
|
|
|
bridge_configure_mirrors(br);
|
Option to forward BPDU (Ethernet control class) frames
Currently, a NORMAL action bridge drops reserved-multicast-mac addresses;
01-80-c2-00-00-[f0:ff]. A node that does not implement STP should have an
option to forward such frames.
This commit proposes to have a configuration option to allow forwarding of
BPDU class frames. To ensure backward compatibility, this option is
disabled by default.
This config can be set using bridge's other-config column, for e.g
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
Changing this option can revalidate all flows in a software-OVS
implementation (ofproto-dpif)
--------
unit tests:
------------
make config changes, test runtime behavior
-- test runtime behavior --
continuously send packets to br0 with dest-mac=01:80:c2:00:00:00
ovs-dpctl dump-flows br0
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
ovs-dpctl dump-flows br0
ovs-vsctl set bridge br0 other-config:forward-bpdu=false
ovs-dpctl dump-flows br0
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
ovs-dpctl dump-flows br0
ovs-vsctl remove bridge br0 other-config forward-bpdu=true
ovs-dpctl dump-flows br0
--result--
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:29550, bytes:1773000, used:0.004s, actions:drop
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:8209, bytes:492540, used:0.000s, actions:2,0
ovs-vsctl set bridge br0 other-config:forward-bpdu=false
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:19, bytes:1140, used:0.000s, actions:drop
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:29, bytes:1740, used:0.000s, actions:2,0
ovs-vsctl remove bridge br0 other-config forward-bpdu=true
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:0, bytes:0, used:never, actions:drop
Bug #6624
Reported-by: Niklas Andersson <nandersson@nicira.com>
2011-08-09 11:08:27 -07:00
|
|
|
|
bridge_configure_forward_bpdu(br);
|
2012-12-08 12:32:33 -08:00
|
|
|
|
bridge_configure_mac_table(br);
|
2014-06-18 22:14:35 -03:00
|
|
|
|
bridge_configure_mcast_snooping(br);
|
2011-05-11 12:26:06 -07:00
|
|
|
|
bridge_configure_remotes(br, managers, n_managers);
|
2011-04-08 13:50:21 -07:00
|
|
|
|
bridge_configure_netflow(br);
|
|
|
|
|
bridge_configure_sflow(br, &sflow_bridge_number);
|
2013-04-22 10:01:14 -07:00
|
|
|
|
bridge_configure_ipfix(br);
|
2015-03-05 11:12:21 -08:00
|
|
|
|
bridge_configure_spanning_tree(br);
|
2012-02-01 10:27:30 -08:00
|
|
|
|
bridge_configure_tables(br);
|
2012-12-26 15:00:06 -08:00
|
|
|
|
bridge_configure_dp_desc(br);
|
2020-01-13 12:29:10 +03:00
|
|
|
|
bridge_configure_serial_desc(br);
|
2015-02-20 14:17:11 -05:00
|
|
|
|
bridge_configure_aa(br);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2011-04-08 13:50:21 -07:00
|
|
|
|
free(managers);
|
2013-09-30 13:07:35 -07:00
|
|
|
|
|
|
|
|
|
/* The ofproto-dpif provider does some final reconfiguration in its
|
|
|
|
|
* ->type_run() function. We have to call it before notifying the database
|
|
|
|
|
* client that reconfiguration is complete, otherwise there is a very
|
|
|
|
|
* narrow race window in which e.g. ofproto/trace will not recognize the
|
|
|
|
|
* new configuration (sometimes this causes unit test failures). */
|
|
|
|
|
bridge_run__();
|
2011-04-08 13:50:21 -07:00
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2012-04-20 19:11:35 -07:00
|
|
|
|
/* Delete ofprotos which aren't configured or have the wrong type. Create
|
|
|
|
|
* ofprotos which don't exist but need to. */
|
2011-04-08 13:50:21 -07:00
|
|
|
|
static void
|
2013-12-11 17:55:26 -08:00
|
|
|
|
bridge_delete_ofprotos(void)
|
2011-04-08 13:50:21 -07:00
|
|
|
|
{
|
2013-12-11 17:55:26 -08:00
|
|
|
|
struct bridge *br;
|
2011-05-09 09:33:02 -07:00
|
|
|
|
struct sset names;
|
|
|
|
|
struct sset types;
|
2011-04-08 13:50:21 -07:00
|
|
|
|
const char *type;
|
2009-12-01 01:14:33 -08:00
|
|
|
|
|
2012-04-20 19:11:35 -07:00
|
|
|
|
/* Delete ofprotos with no bridge or with the wrong type. */
|
2011-05-09 09:33:02 -07:00
|
|
|
|
sset_init(&names);
|
|
|
|
|
sset_init(&types);
|
|
|
|
|
ofproto_enumerate_types(&types);
|
|
|
|
|
SSET_FOR_EACH (type, &types) {
|
2011-04-08 13:50:21 -07:00
|
|
|
|
const char *name;
|
2010-10-11 10:28:28 -07:00
|
|
|
|
|
2011-05-09 09:33:02 -07:00
|
|
|
|
ofproto_enumerate_names(type, &names);
|
|
|
|
|
SSET_FOR_EACH (name, &names) {
|
2012-04-20 19:11:35 -07:00
|
|
|
|
br = bridge_lookup(name);
|
2011-04-08 13:50:21 -07:00
|
|
|
|
if (!br || strcmp(type, br->type)) {
|
2011-05-09 09:33:02 -07:00
|
|
|
|
ofproto_delete(name, type);
|
2010-10-11 10:28:28 -07:00
|
|
|
|
}
|
2010-11-15 16:20:01 -08:00
|
|
|
|
}
|
|
|
|
|
}
|
2011-05-09 09:33:02 -07:00
|
|
|
|
sset_destroy(&names);
|
|
|
|
|
sset_destroy(&types);
|
2013-12-11 17:55:26 -08:00
|
|
|
|
}
|
2009-12-03 11:28:40 -08:00
|
|
|
|
|
2013-12-11 17:55:26 -08:00
|
|
|
|
static ofp_port_t *
|
|
|
|
|
add_ofp_port(ofp_port_t port, ofp_port_t *ports, size_t *n, size_t *allocated)
|
|
|
|
|
{
|
|
|
|
|
if (*n >= *allocated) {
|
|
|
|
|
ports = x2nrealloc(ports, allocated, sizeof *ports);
|
|
|
|
|
}
|
|
|
|
|
ports[(*n)++] = port;
|
|
|
|
|
return ports;
|
|
|
|
|
}
|
2012-04-20 19:11:35 -07:00
|
|
|
|
|
2016-08-29 19:01:13 -07:00
|
|
|
|
/* Configures the MTU of 'netdev' based on the "mtu_request" column
|
2016-09-02 09:53:00 -07:00
|
|
|
|
* in 'iface_cfg'. */
|
2016-08-29 19:01:13 -07:00
|
|
|
|
static int
|
|
|
|
|
iface_set_netdev_mtu(const struct ovsrec_interface *iface_cfg,
|
2016-09-02 09:53:00 -07:00
|
|
|
|
struct netdev *netdev)
|
2016-08-29 19:01:13 -07:00
|
|
|
|
{
|
2016-09-02 09:53:00 -07:00
|
|
|
|
if (iface_cfg->n_mtu_request == 1) {
|
|
|
|
|
/* The user explicitly asked for this MTU. */
|
|
|
|
|
netdev_mtu_user_config(netdev, true);
|
|
|
|
|
/* Try to set the MTU to the requested value. */
|
2016-08-29 19:01:13 -07:00
|
|
|
|
return netdev_set_mtu(netdev, *iface_cfg->mtu_request);
|
|
|
|
|
}
|
2016-09-02 09:53:00 -07:00
|
|
|
|
|
|
|
|
|
/* The user didn't explicitly asked for any MTU. */
|
|
|
|
|
netdev_mtu_user_config(netdev, false);
|
2016-08-29 19:01:13 -07:00
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
2013-12-11 17:55:26 -08:00
|
|
|
|
static void
|
|
|
|
|
bridge_delete_or_reconfigure_ports(struct bridge *br)
|
|
|
|
|
{
|
|
|
|
|
struct ofproto_port ofproto_port;
|
|
|
|
|
struct ofproto_port_dump dump;
|
|
|
|
|
|
bridge: When ports disappear from a datapath, add them back.
Before commit 2a73b1d73d4bdb (bridge: Reconfigure in single pass.), if a
port disappeared, for one reason or another, from a datapath, the next
bridge reconfiguration pass would notice and, if the port was still
configured in the database, add the port back to the datapath. That
commit, however, removed the logic from bridge_refresh_ofp_port() that
did that and failed to add the same logic to the replacement function
bridge_delete_or_reconfigure_ports(). This commit fixes the problem.
To see this problem on a Linux kernel system:
ovs-vsctl add-br br0 # 1
tunctl -t tap # 2
ovs-vsctl add-port br0 tap # 3
ovs-dpctl show # 4
tunctl -d tap # 5
ovs-dpctl show # 6
tunctl -t tap # 7
ovs-vsctl del-port tap -- add-port br0 tap # 8
ovs-dpctl show # 9
Steps 1-4 create a bridge and a tap and add it to the bridge and
demonstrate that the tap is part of the datapath. Step 5 and 6 delete
the tap and demonstrate that it has therefore disappeared from the
datapath. Step 7 recreates a tap with the same name, and step 8
forces ovs-vswitchd to reconfigure. Step 9 shows the effect of the
fix: without the fix, the new tap is not added back to the datapath;
with this fix, it is.
Special thanks to Gurucharan Shetty <gshetty@nicira.com> for finding a
simple reproduction case and then bisecting to find the commit that
introduced the problem.
Bug #1238467.
Reported-by: Ronald Lee <ronaldlee@vmware.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Ethan Jackson <ethan@nicira.com>
2014-04-23 18:33:36 -07:00
|
|
|
|
struct sset ofproto_ports;
|
|
|
|
|
struct port *port, *port_next;
|
|
|
|
|
|
2013-12-11 17:55:26 -08:00
|
|
|
|
/* List of "ofp_port"s to delete. We make a list instead of deleting them
|
|
|
|
|
* right away because ofproto implementations aren't necessarily able to
|
|
|
|
|
* iterate through a changing list of ports in an entirely robust way. */
|
|
|
|
|
ofp_port_t *del;
|
|
|
|
|
size_t n, allocated;
|
|
|
|
|
size_t i;
|
|
|
|
|
|
|
|
|
|
del = NULL;
|
|
|
|
|
n = allocated = 0;
|
bridge: When ports disappear from a datapath, add them back.
Before commit 2a73b1d73d4bdb (bridge: Reconfigure in single pass.), if a
port disappeared, for one reason or another, from a datapath, the next
bridge reconfiguration pass would notice and, if the port was still
configured in the database, add the port back to the datapath. That
commit, however, removed the logic from bridge_refresh_ofp_port() that
did that and failed to add the same logic to the replacement function
bridge_delete_or_reconfigure_ports(). This commit fixes the problem.
To see this problem on a Linux kernel system:
ovs-vsctl add-br br0 # 1
tunctl -t tap # 2
ovs-vsctl add-port br0 tap # 3
ovs-dpctl show # 4
tunctl -d tap # 5
ovs-dpctl show # 6
tunctl -t tap # 7
ovs-vsctl del-port tap -- add-port br0 tap # 8
ovs-dpctl show # 9
Steps 1-4 create a bridge and a tap and add it to the bridge and
demonstrate that the tap is part of the datapath. Step 5 and 6 delete
the tap and demonstrate that it has therefore disappeared from the
datapath. Step 7 recreates a tap with the same name, and step 8
forces ovs-vswitchd to reconfigure. Step 9 shows the effect of the
fix: without the fix, the new tap is not added back to the datapath;
with this fix, it is.
Special thanks to Gurucharan Shetty <gshetty@nicira.com> for finding a
simple reproduction case and then bisecting to find the commit that
introduced the problem.
Bug #1238467.
Reported-by: Ronald Lee <ronaldlee@vmware.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Ethan Jackson <ethan@nicira.com>
2014-04-23 18:33:36 -07:00
|
|
|
|
sset_init(&ofproto_ports);
|
2012-04-20 19:11:35 -07:00
|
|
|
|
|
bridge: When ports disappear from a datapath, add them back.
Before commit 2a73b1d73d4bdb (bridge: Reconfigure in single pass.), if a
port disappeared, for one reason or another, from a datapath, the next
bridge reconfiguration pass would notice and, if the port was still
configured in the database, add the port back to the datapath. That
commit, however, removed the logic from bridge_refresh_ofp_port() that
did that and failed to add the same logic to the replacement function
bridge_delete_or_reconfigure_ports(). This commit fixes the problem.
To see this problem on a Linux kernel system:
ovs-vsctl add-br br0 # 1
tunctl -t tap # 2
ovs-vsctl add-port br0 tap # 3
ovs-dpctl show # 4
tunctl -d tap # 5
ovs-dpctl show # 6
tunctl -t tap # 7
ovs-vsctl del-port tap -- add-port br0 tap # 8
ovs-dpctl show # 9
Steps 1-4 create a bridge and a tap and add it to the bridge and
demonstrate that the tap is part of the datapath. Step 5 and 6 delete
the tap and demonstrate that it has therefore disappeared from the
datapath. Step 7 recreates a tap with the same name, and step 8
forces ovs-vswitchd to reconfigure. Step 9 shows the effect of the
fix: without the fix, the new tap is not added back to the datapath;
with this fix, it is.
Special thanks to Gurucharan Shetty <gshetty@nicira.com> for finding a
simple reproduction case and then bisecting to find the commit that
introduced the problem.
Bug #1238467.
Reported-by: Ronald Lee <ronaldlee@vmware.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Ethan Jackson <ethan@nicira.com>
2014-04-23 18:33:36 -07:00
|
|
|
|
/* Main task: Iterate over the ports in 'br->ofproto' and remove the ports
|
|
|
|
|
* that are not configured in the database. (This commonly happens when
|
|
|
|
|
* ports have been deleted, e.g. with "ovs-vsctl del-port".)
|
|
|
|
|
*
|
|
|
|
|
* Side tasks: Reconfigure the ports that are still in 'br'. Delete ports
|
|
|
|
|
* that have the wrong OpenFlow port number (and arrange to add them back
|
|
|
|
|
* with the correct OpenFlow port number). */
|
2013-12-11 17:55:26 -08:00
|
|
|
|
OFPROTO_PORT_FOR_EACH (&ofproto_port, &dump, br->ofproto) {
|
2013-12-11 15:40:52 -08:00
|
|
|
|
ofp_port_t requested_ofp_port;
|
2013-12-11 17:55:26 -08:00
|
|
|
|
struct iface *iface;
|
2012-04-20 19:11:35 -07:00
|
|
|
|
|
bridge: When ports disappear from a datapath, add them back.
Before commit 2a73b1d73d4bdb (bridge: Reconfigure in single pass.), if a
port disappeared, for one reason or another, from a datapath, the next
bridge reconfiguration pass would notice and, if the port was still
configured in the database, add the port back to the datapath. That
commit, however, removed the logic from bridge_refresh_ofp_port() that
did that and failed to add the same logic to the replacement function
bridge_delete_or_reconfigure_ports(). This commit fixes the problem.
To see this problem on a Linux kernel system:
ovs-vsctl add-br br0 # 1
tunctl -t tap # 2
ovs-vsctl add-port br0 tap # 3
ovs-dpctl show # 4
tunctl -d tap # 5
ovs-dpctl show # 6
tunctl -t tap # 7
ovs-vsctl del-port tap -- add-port br0 tap # 8
ovs-dpctl show # 9
Steps 1-4 create a bridge and a tap and add it to the bridge and
demonstrate that the tap is part of the datapath. Step 5 and 6 delete
the tap and demonstrate that it has therefore disappeared from the
datapath. Step 7 recreates a tap with the same name, and step 8
forces ovs-vswitchd to reconfigure. Step 9 shows the effect of the
fix: without the fix, the new tap is not added back to the datapath;
with this fix, it is.
Special thanks to Gurucharan Shetty <gshetty@nicira.com> for finding a
simple reproduction case and then bisecting to find the commit that
introduced the problem.
Bug #1238467.
Reported-by: Ronald Lee <ronaldlee@vmware.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Ethan Jackson <ethan@nicira.com>
2014-04-23 18:33:36 -07:00
|
|
|
|
sset_add(&ofproto_ports, ofproto_port.name);
|
|
|
|
|
|
2013-12-11 17:55:26 -08:00
|
|
|
|
iface = iface_lookup(br, ofproto_port.name);
|
|
|
|
|
if (!iface) {
|
|
|
|
|
/* No such iface is configured, so we should delete this
|
|
|
|
|
* ofproto_port.
|
|
|
|
|
*
|
|
|
|
|
* As a corner case exception, keep the port if it's a bond fake
|
|
|
|
|
* interface. */
|
|
|
|
|
if (bridge_has_bond_fake_iface(br, ofproto_port.name)
|
|
|
|
|
&& !strcmp(ofproto_port.type, "internal")) {
|
2012-04-20 19:11:35 -07:00
|
|
|
|
continue;
|
|
|
|
|
}
|
2013-12-11 17:55:26 -08:00
|
|
|
|
goto delete;
|
|
|
|
|
}
|
2012-04-20 19:11:35 -07:00
|
|
|
|
|
2018-02-23 14:03:15 -08:00
|
|
|
|
const char *netdev_type = ofproto_port_open_type(br->ofproto,
|
|
|
|
|
iface->type);
|
|
|
|
|
if (strcmp(ofproto_port.type, netdev_type)
|
2014-04-10 12:50:10 +02:00
|
|
|
|
|| netdev_set_config(iface->netdev, &iface->cfg->options, NULL)) {
|
2013-12-11 17:55:26 -08:00
|
|
|
|
/* The interface is the wrong type or can't be configured.
|
|
|
|
|
* Delete it. */
|
|
|
|
|
goto delete;
|
2012-04-20 19:11:35 -07:00
|
|
|
|
}
|
2016-08-09 17:01:15 +01:00
|
|
|
|
|
2016-09-02 09:53:00 -07:00
|
|
|
|
iface_set_netdev_mtu(iface->cfg, iface->netdev);
|
2012-04-20 19:11:35 -07:00
|
|
|
|
|
2013-12-11 15:40:52 -08:00
|
|
|
|
/* If the requested OpenFlow port for 'iface' changed, and it's not
|
|
|
|
|
* already the correct port, then we might want to temporarily delete
|
|
|
|
|
* this interface, so we can add it back again with the new OpenFlow
|
|
|
|
|
* port number. */
|
|
|
|
|
requested_ofp_port = iface_get_requested_ofp_port(iface->cfg);
|
|
|
|
|
if (iface->ofp_port != OFPP_LOCAL &&
|
|
|
|
|
requested_ofp_port != OFPP_NONE &&
|
|
|
|
|
requested_ofp_port != iface->ofp_port) {
|
|
|
|
|
ofp_port_t victim_request;
|
|
|
|
|
struct iface *victim;
|
|
|
|
|
|
|
|
|
|
/* Check for an existing OpenFlow port currently occupying
|
|
|
|
|
* 'iface''s requested port number. If there isn't one, then
|
|
|
|
|
* delete this port. Otherwise we need to consider further. */
|
|
|
|
|
victim = iface_from_ofp_port(br, requested_ofp_port);
|
|
|
|
|
if (!victim) {
|
|
|
|
|
goto delete;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* 'victim' is a port currently using 'iface''s requested port
|
|
|
|
|
* number. Unless 'victim' specifically requested that port
|
|
|
|
|
* number, too, then we can delete both 'iface' and 'victim'
|
|
|
|
|
* temporarily. (We'll add both of them back again later with new
|
|
|
|
|
* OpenFlow port numbers.)
|
|
|
|
|
*
|
|
|
|
|
* If 'victim' did request port number 'requested_ofp_port', just
|
|
|
|
|
* like 'iface', then that's a configuration inconsistency that we
|
|
|
|
|
* can't resolve. We might as well let it keep its current port
|
|
|
|
|
* number. */
|
|
|
|
|
victim_request = iface_get_requested_ofp_port(victim->cfg);
|
|
|
|
|
if (victim_request != requested_ofp_port) {
|
|
|
|
|
del = add_ofp_port(victim->ofp_port, del, &n, &allocated);
|
|
|
|
|
iface_destroy(victim);
|
|
|
|
|
goto delete;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2013-12-11 17:55:26 -08:00
|
|
|
|
/* Keep it. */
|
|
|
|
|
continue;
|
|
|
|
|
|
|
|
|
|
delete:
|
|
|
|
|
iface_destroy(iface);
|
|
|
|
|
del = add_ofp_port(ofproto_port.ofp_port, del, &n, &allocated);
|
|
|
|
|
}
|
|
|
|
|
for (i = 0; i < n; i++) {
|
|
|
|
|
ofproto_port_del(br->ofproto, del[i]);
|
|
|
|
|
}
|
|
|
|
|
free(del);
|
bridge: When ports disappear from a datapath, add them back.
Before commit 2a73b1d73d4bdb (bridge: Reconfigure in single pass.), if a
port disappeared, for one reason or another, from a datapath, the next
bridge reconfiguration pass would notice and, if the port was still
configured in the database, add the port back to the datapath. That
commit, however, removed the logic from bridge_refresh_ofp_port() that
did that and failed to add the same logic to the replacement function
bridge_delete_or_reconfigure_ports(). This commit fixes the problem.
To see this problem on a Linux kernel system:
ovs-vsctl add-br br0 # 1
tunctl -t tap # 2
ovs-vsctl add-port br0 tap # 3
ovs-dpctl show # 4
tunctl -d tap # 5
ovs-dpctl show # 6
tunctl -t tap # 7
ovs-vsctl del-port tap -- add-port br0 tap # 8
ovs-dpctl show # 9
Steps 1-4 create a bridge and a tap and add it to the bridge and
demonstrate that the tap is part of the datapath. Step 5 and 6 delete
the tap and demonstrate that it has therefore disappeared from the
datapath. Step 7 recreates a tap with the same name, and step 8
forces ovs-vswitchd to reconfigure. Step 9 shows the effect of the
fix: without the fix, the new tap is not added back to the datapath;
with this fix, it is.
Special thanks to Gurucharan Shetty <gshetty@nicira.com> for finding a
simple reproduction case and then bisecting to find the commit that
introduced the problem.
Bug #1238467.
Reported-by: Ronald Lee <ronaldlee@vmware.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Ethan Jackson <ethan@nicira.com>
2014-04-23 18:33:36 -07:00
|
|
|
|
|
|
|
|
|
/* Iterate over this module's idea of interfaces in 'br'. Remove any ports
|
|
|
|
|
* that we didn't see when we iterated through the datapath, i.e. ports
|
|
|
|
|
* that disappeared underneath use. This is an unusual situation, but it
|
|
|
|
|
* can happen in some cases:
|
|
|
|
|
*
|
|
|
|
|
* - An admin runs a command like "ovs-dpctl del-port" (which is a bad
|
|
|
|
|
* idea but could happen).
|
|
|
|
|
*
|
|
|
|
|
* - The port represented a device that disappeared, e.g. a tuntap
|
|
|
|
|
* device destroyed via "tunctl -d", a physical Ethernet device
|
|
|
|
|
* whose module was just unloaded via "rmmod", or a virtual NIC for a
|
|
|
|
|
* VM whose VM was just terminated. */
|
|
|
|
|
HMAP_FOR_EACH_SAFE (port, port_next, hmap_node, &br->ports) {
|
|
|
|
|
struct iface *iface, *iface_next;
|
|
|
|
|
|
|
|
|
|
LIST_FOR_EACH_SAFE (iface, iface_next, port_elem, &port->ifaces) {
|
|
|
|
|
if (!sset_contains(&ofproto_ports, iface->name)) {
|
|
|
|
|
iface_destroy__(iface);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2016-03-25 14:10:22 -07:00
|
|
|
|
if (ovs_list_is_empty(&port->ifaces)) {
|
bridge: When ports disappear from a datapath, add them back.
Before commit 2a73b1d73d4bdb (bridge: Reconfigure in single pass.), if a
port disappeared, for one reason or another, from a datapath, the next
bridge reconfiguration pass would notice and, if the port was still
configured in the database, add the port back to the datapath. That
commit, however, removed the logic from bridge_refresh_ofp_port() that
did that and failed to add the same logic to the replacement function
bridge_delete_or_reconfigure_ports(). This commit fixes the problem.
To see this problem on a Linux kernel system:
ovs-vsctl add-br br0 # 1
tunctl -t tap # 2
ovs-vsctl add-port br0 tap # 3
ovs-dpctl show # 4
tunctl -d tap # 5
ovs-dpctl show # 6
tunctl -t tap # 7
ovs-vsctl del-port tap -- add-port br0 tap # 8
ovs-dpctl show # 9
Steps 1-4 create a bridge and a tap and add it to the bridge and
demonstrate that the tap is part of the datapath. Step 5 and 6 delete
the tap and demonstrate that it has therefore disappeared from the
datapath. Step 7 recreates a tap with the same name, and step 8
forces ovs-vswitchd to reconfigure. Step 9 shows the effect of the
fix: without the fix, the new tap is not added back to the datapath;
with this fix, it is.
Special thanks to Gurucharan Shetty <gshetty@nicira.com> for finding a
simple reproduction case and then bisecting to find the commit that
introduced the problem.
Bug #1238467.
Reported-by: Ronald Lee <ronaldlee@vmware.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Ethan Jackson <ethan@nicira.com>
2014-04-23 18:33:36 -07:00
|
|
|
|
port_destroy(port);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
sset_destroy(&ofproto_ports);
|
2013-12-11 17:55:26 -08:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
2013-12-11 15:40:52 -08:00
|
|
|
|
bridge_add_ports__(struct bridge *br, const struct shash *wanted_ports,
|
|
|
|
|
bool with_requested_port)
|
2013-12-11 17:55:26 -08:00
|
|
|
|
{
|
|
|
|
|
struct shash_node *port_node;
|
|
|
|
|
|
|
|
|
|
SHASH_FOR_EACH (port_node, wanted_ports) {
|
|
|
|
|
const struct ovsrec_port *port_cfg = port_node->data;
|
|
|
|
|
size_t i;
|
|
|
|
|
|
|
|
|
|
for (i = 0; i < port_cfg->n_interfaces; i++) {
|
|
|
|
|
const struct ovsrec_interface *iface_cfg = port_cfg->interfaces[i];
|
2013-12-11 15:40:52 -08:00
|
|
|
|
ofp_port_t requested_ofp_port;
|
|
|
|
|
|
|
|
|
|
requested_ofp_port = iface_get_requested_ofp_port(iface_cfg);
|
|
|
|
|
if ((requested_ofp_port != OFPP_NONE) == with_requested_port) {
|
|
|
|
|
struct iface *iface = iface_lookup(br, iface_cfg->name);
|
2013-12-11 17:55:26 -08:00
|
|
|
|
|
2013-12-11 15:40:52 -08:00
|
|
|
|
if (!iface) {
|
|
|
|
|
iface_create(br, iface_cfg, port_cfg);
|
|
|
|
|
}
|
2013-12-11 17:55:26 -08:00
|
|
|
|
}
|
2012-04-20 19:11:35 -07:00
|
|
|
|
}
|
2011-04-08 13:50:21 -07:00
|
|
|
|
}
|
2009-12-11 17:03:35 -08:00
|
|
|
|
}
|
2010-12-03 14:41:38 -08:00
|
|
|
|
|
2013-12-11 15:40:52 -08:00
|
|
|
|
static void
|
|
|
|
|
bridge_add_ports(struct bridge *br, const struct shash *wanted_ports)
|
|
|
|
|
{
|
|
|
|
|
/* First add interfaces that request a particular port number. */
|
|
|
|
|
bridge_add_ports__(br, wanted_ports, true);
|
|
|
|
|
|
|
|
|
|
/* Then add interfaces that want automatic port number assignment.
|
|
|
|
|
* We add these afterward to avoid accidentally taking a specifically
|
|
|
|
|
* requested port number. */
|
|
|
|
|
bridge_add_ports__(br, wanted_ports, false);
|
|
|
|
|
}
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
static void
|
|
|
|
|
port_configure(struct port *port)
|
|
|
|
|
{
|
|
|
|
|
const struct ovsrec_port *cfg = port->cfg;
|
|
|
|
|
struct bond_settings bond_settings;
|
|
|
|
|
struct lacp_settings lacp_settings;
|
|
|
|
|
struct ofproto_bundle_settings s;
|
|
|
|
|
struct iface *iface;
|
2010-09-27 11:39:41 -07:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
/* Get name. */
|
|
|
|
|
s.name = port->name;
|
2010-10-11 10:28:28 -07:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
/* Get slaves. */
|
|
|
|
|
s.n_slaves = 0;
|
2016-03-25 14:10:22 -07:00
|
|
|
|
s.slaves = xmalloc(ovs_list_size(&port->ifaces) * sizeof *s.slaves);
|
2011-05-11 12:26:06 -07:00
|
|
|
|
LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
|
2011-05-09 09:24:39 -07:00
|
|
|
|
s.slaves[s.n_slaves++] = iface->ofp_port;
|
2011-05-11 12:26:06 -07:00
|
|
|
|
}
|
2010-12-03 14:41:38 -08:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
/* Get VLAN tag. */
|
|
|
|
|
s.vlan = -1;
|
2011-12-12 14:44:23 -08:00
|
|
|
|
if (cfg->tag && *cfg->tag >= 0 && *cfg->tag <= 4095) {
|
|
|
|
|
s.vlan = *cfg->tag;
|
2011-05-11 12:26:06 -07:00
|
|
|
|
}
|
datapath: Change listing ports to use an iterator concept.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to add new
features to the kernel vport layer without changing userspace software. In
turn, that means that the odp_port structure must become variable-length.
This does not, however, fit in well with the ODP_PORT_LIST ioctl in its
current form, because that would require userspace to know how much space
to allocate for each port in advance, or to allocate as much space as
could possibly be needed. Neither choice is very attractive.
This commit prepares for a different solution, by replacing ODP_PORT_LIST
by a new ioctl ODP_VPORT_DUMP that retrieves information about a single
vport from the datapath on each call. It is much cleaner to allocate the
maximum amount of space for a single vport than to do so for possibly a
large number of vports.
It would be faster to retrieve a number of vports in batch instead of just
one at a time, but that will naturally happen later when the kernel
datapath interface is changed to use Netlink, so this patch does not bother
with it.
The Netlink version won't need to take the starting port number from
userspace, since Netlink sockets can keep track of that state as part
of their "dump" feature.
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2011-01-10 13:12:12 -08:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
/* Get VLAN trunks. */
|
|
|
|
|
s.trunks = NULL;
|
2011-09-23 17:03:03 -07:00
|
|
|
|
if (cfg->n_trunks) {
|
2011-05-11 12:26:06 -07:00
|
|
|
|
s.trunks = vlan_bitmap_from_array(cfg->trunks, cfg->n_trunks);
|
2011-09-23 17:03:03 -07:00
|
|
|
|
}
|
|
|
|
|
|
2017-03-01 17:48:00 -05:00
|
|
|
|
s.cvlans = NULL;
|
|
|
|
|
if (cfg->n_cvlans) {
|
|
|
|
|
s.cvlans = vlan_bitmap_from_array(cfg->cvlans, cfg->n_cvlans);
|
|
|
|
|
}
|
|
|
|
|
|
2011-09-23 17:03:03 -07:00
|
|
|
|
/* Get VLAN mode. */
|
|
|
|
|
if (cfg->vlan_mode) {
|
|
|
|
|
if (!strcmp(cfg->vlan_mode, "access")) {
|
|
|
|
|
s.vlan_mode = PORT_VLAN_ACCESS;
|
|
|
|
|
} else if (!strcmp(cfg->vlan_mode, "trunk")) {
|
|
|
|
|
s.vlan_mode = PORT_VLAN_TRUNK;
|
|
|
|
|
} else if (!strcmp(cfg->vlan_mode, "native-tagged")) {
|
|
|
|
|
s.vlan_mode = PORT_VLAN_NATIVE_TAGGED;
|
|
|
|
|
} else if (!strcmp(cfg->vlan_mode, "native-untagged")) {
|
|
|
|
|
s.vlan_mode = PORT_VLAN_NATIVE_UNTAGGED;
|
2017-03-01 17:48:00 -05:00
|
|
|
|
} else if (!strcmp(cfg->vlan_mode, "dot1q-tunnel")) {
|
|
|
|
|
s.vlan_mode = PORT_VLAN_DOT1Q_TUNNEL;
|
2011-09-23 17:03:03 -07:00
|
|
|
|
} else {
|
|
|
|
|
/* This "can't happen" because ovsdb-server should prevent it. */
|
2014-04-09 17:19:17 +02:00
|
|
|
|
VLOG_WARN("port %s: unknown VLAN mode %s, falling "
|
|
|
|
|
"back to trunk mode", port->name, cfg->vlan_mode);
|
2011-09-23 17:03:03 -07:00
|
|
|
|
s.vlan_mode = PORT_VLAN_TRUNK;
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
if (s.vlan >= 0) {
|
|
|
|
|
s.vlan_mode = PORT_VLAN_ACCESS;
|
2017-03-01 17:48:00 -05:00
|
|
|
|
if (cfg->n_trunks || cfg->n_cvlans) {
|
2014-04-09 17:19:17 +02:00
|
|
|
|
VLOG_WARN("port %s: ignoring trunks in favor of implicit vlan",
|
|
|
|
|
port->name);
|
2011-09-23 17:03:03 -07:00
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
s.vlan_mode = PORT_VLAN_TRUNK;
|
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2017-03-01 17:48:00 -05:00
|
|
|
|
|
|
|
|
|
const char *qe = smap_get_def(&cfg->other_config, "qinq-ethtype", "");
|
|
|
|
|
s.qinq_ethtype = (!strcmp(qe, "802.1q")
|
|
|
|
|
? ETH_TYPE_VLAN_8021Q
|
|
|
|
|
: ETH_TYPE_VLAN_8021AD);
|
|
|
|
|
|
2019-05-12 05:50:59 +00:00
|
|
|
|
const char *pt = smap_get_def(&cfg->other_config, "priority-tags", "");
|
|
|
|
|
if (!strcmp(pt, "if-nonzero") || !strcmp(pt, "true")) {
|
|
|
|
|
s.use_priority_tags = PORT_PRIORITY_TAGS_IF_NONZERO;
|
2019-05-12 05:51:00 +00:00
|
|
|
|
} else if (!strcmp(pt, "always")) {
|
|
|
|
|
s.use_priority_tags = PORT_PRIORITY_TAGS_ALWAYS;
|
2019-05-12 05:50:59 +00:00
|
|
|
|
} else {
|
|
|
|
|
s.use_priority_tags = PORT_PRIORITY_TAGS_NEVER;
|
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
/* Get LACP settings. */
|
|
|
|
|
s.lacp = port_configure_lacp(port, &lacp_settings);
|
|
|
|
|
if (s.lacp) {
|
|
|
|
|
size_t i = 0;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
s.lacp_slaves = xmalloc(s.n_slaves * sizeof *s.lacp_slaves);
|
|
|
|
|
LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
|
|
|
|
|
iface_configure_lacp(iface, &s.lacp_slaves[i++]);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2011-05-11 12:26:06 -07:00
|
|
|
|
} else {
|
|
|
|
|
s.lacp_slaves = NULL;
|
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
/* Get bond settings. */
|
|
|
|
|
if (s.n_slaves > 1) {
|
|
|
|
|
s.bond = &bond_settings;
|
2013-02-04 18:28:57 -08:00
|
|
|
|
port_configure_bond(port, &bond_settings);
|
2011-05-11 12:26:06 -07:00
|
|
|
|
} else {
|
|
|
|
|
s.bond = NULL;
|
2011-05-16 14:40:03 -07:00
|
|
|
|
LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
|
|
|
|
|
netdev_set_miimon_interval(iface->netdev, 0);
|
|
|
|
|
}
|
2011-05-11 12:26:06 -07:00
|
|
|
|
}
|
2009-12-11 17:03:35 -08:00
|
|
|
|
|
2016-11-14 00:30:39 +11:00
|
|
|
|
/* Protected port mode */
|
2017-12-12 13:17:40 -08:00
|
|
|
|
s.protected = cfg->protected_;
|
2016-11-14 00:30:39 +11:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
/* Register. */
|
|
|
|
|
ofproto_bundle_register(port->bridge->ofproto, port, &s);
|
2009-12-03 11:28:40 -08:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
/* Clean up. */
|
2017-04-07 14:43:41 -07:00
|
|
|
|
free(s.cvlans);
|
2011-06-07 13:19:41 -07:00
|
|
|
|
free(s.slaves);
|
2011-05-11 12:26:06 -07:00
|
|
|
|
free(s.trunks);
|
|
|
|
|
free(s.lacp_slaves);
|
|
|
|
|
}
|
2009-12-03 11:28:40 -08:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
/* Pick local port hardware address and datapath ID for 'br'. */
|
|
|
|
|
static void
|
|
|
|
|
bridge_configure_datapath_id(struct bridge *br)
|
|
|
|
|
{
|
2015-08-28 14:55:11 -07:00
|
|
|
|
struct eth_addr ea;
|
2011-05-04 10:20:04 -07:00
|
|
|
|
uint64_t dpid;
|
|
|
|
|
struct iface *local_iface;
|
|
|
|
|
struct iface *hw_addr_iface;
|
|
|
|
|
char *dpid_string;
|
2009-12-03 11:28:40 -08:00
|
|
|
|
|
2015-08-28 14:55:11 -07:00
|
|
|
|
bridge_pick_local_hw_addr(br, &ea, &hw_addr_iface);
|
2011-05-09 09:24:39 -07:00
|
|
|
|
local_iface = iface_from_ofp_port(br, OFPP_LOCAL);
|
2011-05-04 10:20:04 -07:00
|
|
|
|
if (local_iface) {
|
|
|
|
|
int error = netdev_set_etheraddr(local_iface->netdev, ea);
|
|
|
|
|
if (error) {
|
|
|
|
|
static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
|
|
|
|
|
VLOG_ERR_RL(&rl, "bridge %s: failed to set bridge "
|
|
|
|
|
"Ethernet address: %s",
|
2013-06-24 10:54:49 -07:00
|
|
|
|
br->name, ovs_strerror(error));
|
2011-05-04 10:20:04 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
2015-08-28 14:55:11 -07:00
|
|
|
|
br->ea = ea;
|
2009-12-03 11:28:40 -08:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
dpid = bridge_pick_datapath_id(br, ea, hw_addr_iface);
|
2012-06-26 14:43:08 -07:00
|
|
|
|
if (dpid != ofproto_get_datapath_id(br->ofproto)) {
|
|
|
|
|
VLOG_INFO("bridge %s: using datapath ID %016"PRIx64, br->name, dpid);
|
|
|
|
|
ofproto_set_datapath_id(br->ofproto, dpid);
|
|
|
|
|
}
|
2009-12-03 11:28:40 -08:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
dpid_string = xasprintf("%016"PRIx64, dpid);
|
|
|
|
|
ovsrec_bridge_set_datapath_id(br->cfg, dpid_string);
|
|
|
|
|
free(dpid_string);
|
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2012-11-19 14:59:30 +09:00
|
|
|
|
/* Returns a bitmap of "enum ofputil_protocol"s that are allowed for use with
|
|
|
|
|
* 'br'. */
|
|
|
|
|
static uint32_t
|
|
|
|
|
bridge_get_allowed_versions(struct bridge *br)
|
|
|
|
|
{
|
2015-10-12 11:27:30 -07:00
|
|
|
|
if (!br->cfg->n_protocols) {
|
2012-11-19 14:59:30 +09:00
|
|
|
|
return 0;
|
2015-10-12 11:27:30 -07:00
|
|
|
|
}
|
2012-11-19 14:59:30 +09:00
|
|
|
|
|
2014-05-09 13:45:03 -07:00
|
|
|
|
return ofputil_versions_from_strings(br->cfg->protocols,
|
|
|
|
|
br->cfg->n_protocols);
|
2012-11-19 14:59:30 +09:00
|
|
|
|
}
|
|
|
|
|
|
2019-08-02 10:29:52 +02:00
|
|
|
|
static int
|
|
|
|
|
bridge_get_controller_queue_size(struct bridge *br,
|
|
|
|
|
struct ovsrec_controller *c)
|
|
|
|
|
{
|
|
|
|
|
if (c && c->controller_queue_size) {
|
|
|
|
|
return *c->controller_queue_size;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
int queue_size = smap_get_int(&br->cfg->other_config,
|
|
|
|
|
"controller-queue-size",
|
|
|
|
|
BRIDGE_CONTROLLER_PACKET_QUEUE_DEFAULT_SIZE);
|
|
|
|
|
if (queue_size < BRIDGE_CONTROLLER_PACKET_QUEUE_MIN_SIZE ||
|
|
|
|
|
queue_size > BRIDGE_CONTROLLER_PACKET_QUEUE_MAX_SIZE) {
|
|
|
|
|
return BRIDGE_CONTROLLER_PACKET_QUEUE_DEFAULT_SIZE;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return queue_size;
|
|
|
|
|
}
|
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
/* Set NetFlow configuration on 'br'. */
|
|
|
|
|
static void
|
|
|
|
|
bridge_configure_netflow(struct bridge *br)
|
|
|
|
|
{
|
|
|
|
|
struct ovsrec_netflow *cfg = br->cfg->netflow;
|
|
|
|
|
struct netflow_options opts;
|
2010-01-04 13:08:37 -08:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
if (!cfg) {
|
|
|
|
|
ofproto_set_netflow(br->ofproto, NULL);
|
|
|
|
|
return;
|
|
|
|
|
}
|
2010-02-05 15:58:27 -08:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
memset(&opts, 0, sizeof opts);
|
2010-01-04 13:08:37 -08:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
/* Get default NetFlow configuration from datapath.
|
|
|
|
|
* Apply overrides from 'cfg'. */
|
|
|
|
|
ofproto_get_netflow_ids(br->ofproto, &opts.engine_type, &opts.engine_id);
|
|
|
|
|
if (cfg->engine_type) {
|
|
|
|
|
opts.engine_type = *cfg->engine_type;
|
|
|
|
|
}
|
|
|
|
|
if (cfg->engine_id) {
|
|
|
|
|
opts.engine_id = *cfg->engine_id;
|
|
|
|
|
}
|
2010-01-04 13:08:37 -08:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
/* Configure active timeout interval. */
|
|
|
|
|
opts.active_timeout = cfg->active_timeout;
|
|
|
|
|
if (!opts.active_timeout) {
|
|
|
|
|
opts.active_timeout = -1;
|
|
|
|
|
} else if (opts.active_timeout < 0) {
|
|
|
|
|
VLOG_WARN("bridge %s: active timeout interval set to negative "
|
|
|
|
|
"value, using default instead (%d seconds)", br->name,
|
|
|
|
|
NF_ACTIVE_TIMEOUT_DEFAULT);
|
|
|
|
|
opts.active_timeout = -1;
|
|
|
|
|
}
|
2010-01-04 13:08:37 -08:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
/* Add engine ID to interface number to disambiguate bridgs? */
|
|
|
|
|
opts.add_id_to_iface = cfg->add_id_to_interface;
|
|
|
|
|
if (opts.add_id_to_iface) {
|
|
|
|
|
if (opts.engine_id > 0x7f) {
|
|
|
|
|
VLOG_WARN("bridge %s: NetFlow port mangling may conflict with "
|
|
|
|
|
"another vswitch, choose an engine id less than 128",
|
|
|
|
|
br->name);
|
|
|
|
|
}
|
|
|
|
|
if (hmap_count(&br->ports) > 508) {
|
|
|
|
|
VLOG_WARN("bridge %s: NetFlow port mangling will conflict with "
|
|
|
|
|
"another port when more than 508 ports are used",
|
|
|
|
|
br->name);
|
|
|
|
|
}
|
|
|
|
|
}
|
2010-01-04 13:08:37 -08:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
/* Collectors. */
|
|
|
|
|
sset_init(&opts.collectors);
|
|
|
|
|
sset_add_array(&opts.collectors, cfg->targets, cfg->n_targets);
|
2010-02-05 15:58:27 -08:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
/* Configure. */
|
|
|
|
|
if (ofproto_set_netflow(br->ofproto, &opts)) {
|
|
|
|
|
VLOG_ERR("bridge %s: problem setting netflow collectors", br->name);
|
|
|
|
|
}
|
|
|
|
|
sset_destroy(&opts.collectors);
|
|
|
|
|
}
|
2010-01-04 13:08:37 -08:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
/* Set sFlow configuration on 'br'. */
|
|
|
|
|
static void
|
|
|
|
|
bridge_configure_sflow(struct bridge *br, int *sflow_bridge_number)
|
|
|
|
|
{
|
|
|
|
|
const struct ovsrec_sflow *cfg = br->cfg->sflow;
|
|
|
|
|
struct ovsrec_controller **controllers;
|
|
|
|
|
struct ofproto_sflow_options oso;
|
|
|
|
|
size_t n_controllers;
|
|
|
|
|
size_t i;
|
2010-01-04 13:08:37 -08:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
if (!cfg) {
|
|
|
|
|
ofproto_set_sflow(br->ofproto, NULL);
|
|
|
|
|
return;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2011-03-21 10:07:39 -07:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
memset(&oso, 0, sizeof oso);
|
2009-10-02 13:29:01 -07:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
sset_init(&oso.targets);
|
|
|
|
|
sset_add_array(&oso.targets, cfg->targets, cfg->n_targets);
|
2010-06-17 15:04:12 -07:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
oso.sampling_rate = SFL_DEFAULT_SAMPLING_RATE;
|
|
|
|
|
if (cfg->sampling) {
|
|
|
|
|
oso.sampling_rate = *cfg->sampling;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2011-05-04 10:20:04 -07:00
|
|
|
|
|
|
|
|
|
oso.polling_interval = SFL_DEFAULT_POLLING_INTERVAL;
|
|
|
|
|
if (cfg->polling) {
|
|
|
|
|
oso.polling_interval = *cfg->polling;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2009-12-11 17:03:35 -08:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
oso.header_len = SFL_DEFAULT_HEADER_SIZE;
|
|
|
|
|
if (cfg->header) {
|
|
|
|
|
oso.header_len = *cfg->header;
|
|
|
|
|
}
|
2011-04-06 16:59:22 -07:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
oso.sub_id = (*sflow_bridge_number)++;
|
|
|
|
|
oso.agent_device = cfg->agent;
|
2011-04-06 16:59:22 -07:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
oso.control_ip = NULL;
|
|
|
|
|
n_controllers = bridge_get_controllers(br, &controllers);
|
|
|
|
|
for (i = 0; i < n_controllers; i++) {
|
|
|
|
|
if (controllers[i]->local_ip) {
|
|
|
|
|
oso.control_ip = controllers[i]->local_ip;
|
|
|
|
|
break;
|
2010-11-15 16:20:01 -08:00
|
|
|
|
}
|
|
|
|
|
}
|
2011-05-04 10:20:04 -07:00
|
|
|
|
ofproto_set_sflow(br->ofproto, &oso);
|
2010-11-15 16:20:01 -08:00
|
|
|
|
|
2011-05-04 10:20:04 -07:00
|
|
|
|
sset_destroy(&oso.targets);
|
|
|
|
|
}
|
2011-01-28 12:44:00 -08:00
|
|
|
|
|
2013-11-20 10:57:53 -08:00
|
|
|
|
/* Returns whether a IPFIX row is valid. */
|
|
|
|
|
static bool
|
|
|
|
|
ovsrec_ipfix_is_valid(const struct ovsrec_ipfix *ipfix)
|
|
|
|
|
{
|
|
|
|
|
return ipfix && ipfix->n_targets > 0;
|
|
|
|
|
}
|
|
|
|
|
|
2013-11-20 10:57:52 -08:00
|
|
|
|
/* Returns whether a Flow_Sample_Collector_Set row is valid. */
|
|
|
|
|
static bool
|
|
|
|
|
ovsrec_fscs_is_valid(const struct ovsrec_flow_sample_collector_set *fscs,
|
|
|
|
|
const struct bridge *br)
|
|
|
|
|
{
|
2013-11-20 10:57:53 -08:00
|
|
|
|
return ovsrec_ipfix_is_valid(fscs->ipfix) && fscs->bridge == br->cfg;
|
2013-11-20 10:57:52 -08:00
|
|
|
|
}
|
|
|
|
|
|
2013-04-22 10:01:14 -07:00
|
|
|
|
/* Set IPFIX configuration on 'br'. */
|
|
|
|
|
static void
|
|
|
|
|
bridge_configure_ipfix(struct bridge *br)
|
|
|
|
|
{
|
|
|
|
|
const struct ovsrec_ipfix *be_cfg = br->cfg->ipfix;
|
2013-11-20 10:57:53 -08:00
|
|
|
|
bool valid_be_cfg = ovsrec_ipfix_is_valid(be_cfg);
|
2013-04-22 10:01:14 -07:00
|
|
|
|
const struct ovsrec_flow_sample_collector_set *fe_cfg;
|
|
|
|
|
struct ofproto_ipfix_bridge_exporter_options be_opts;
|
|
|
|
|
struct ofproto_ipfix_flow_exporter_options *fe_opts = NULL;
|
|
|
|
|
size_t n_fe_opts = 0;
|
2016-06-24 17:10:07 -07:00
|
|
|
|
const char *virtual_obs_id;
|
2013-04-22 10:01:14 -07:00
|
|
|
|
|
|
|
|
|
OVSREC_FLOW_SAMPLE_COLLECTOR_SET_FOR_EACH(fe_cfg, idl) {
|
2013-11-20 10:57:52 -08:00
|
|
|
|
if (ovsrec_fscs_is_valid(fe_cfg, br)) {
|
2013-04-22 10:01:14 -07:00
|
|
|
|
n_fe_opts++;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2013-11-20 10:57:53 -08:00
|
|
|
|
if (!valid_be_cfg && n_fe_opts == 0) {
|
2013-04-22 10:01:14 -07:00
|
|
|
|
ofproto_set_ipfix(br->ofproto, NULL, NULL, 0);
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2013-11-20 10:57:53 -08:00
|
|
|
|
if (valid_be_cfg) {
|
2013-04-22 10:01:14 -07:00
|
|
|
|
memset(&be_opts, 0, sizeof be_opts);
|
|
|
|
|
|
|
|
|
|
sset_init(&be_opts.targets);
|
|
|
|
|
sset_add_array(&be_opts.targets, be_cfg->targets, be_cfg->n_targets);
|
|
|
|
|
|
|
|
|
|
if (be_cfg->sampling) {
|
|
|
|
|
be_opts.sampling_rate = *be_cfg->sampling;
|
|
|
|
|
} else {
|
|
|
|
|
be_opts.sampling_rate = SFL_DEFAULT_SAMPLING_RATE;
|
|
|
|
|
}
|
|
|
|
|
if (be_cfg->obs_domain_id) {
|
|
|
|
|
be_opts.obs_domain_id = *be_cfg->obs_domain_id;
|
|
|
|
|
}
|
|
|
|
|
if (be_cfg->obs_point_id) {
|
|
|
|
|
be_opts.obs_point_id = *be_cfg->obs_point_id;
|
|
|
|
|
}
|
2013-08-21 13:49:04 -07:00
|
|
|
|
if (be_cfg->cache_active_timeout) {
|
|
|
|
|
be_opts.cache_active_timeout = *be_cfg->cache_active_timeout;
|
|
|
|
|
}
|
|
|
|
|
if (be_cfg->cache_max_flows) {
|
|
|
|
|
be_opts.cache_max_flows = *be_cfg->cache_max_flows;
|
|
|
|
|
}
|
2014-08-17 20:19:36 -07:00
|
|
|
|
|
|
|
|
|
be_opts.enable_tunnel_sampling = smap_get_bool(&be_cfg->other_config,
|
|
|
|
|
"enable-tunnel-sampling", true);
|
|
|
|
|
|
|
|
|
|
be_opts.enable_input_sampling = !smap_get_bool(&be_cfg->other_config,
|
|
|
|
|
"enable-input-sampling", false);
|
|
|
|
|
|
|
|
|
|
be_opts.enable_output_sampling = !smap_get_bool(&be_cfg->other_config,
|
|
|
|
|
"enable-output-sampling", false);
|
2016-06-24 17:10:07 -07:00
|
|
|
|
|
|
|
|
|
virtual_obs_id = smap_get(&be_cfg->other_config, "virtual_obs_id");
|
2016-06-24 21:23:16 -07:00
|
|
|
|
be_opts.virtual_obs_id = nullable_xstrdup(virtual_obs_id);
|
2013-04-22 10:01:14 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (n_fe_opts > 0) {
|
|
|
|
|
struct ofproto_ipfix_flow_exporter_options *opts;
|
|
|
|
|
fe_opts = xcalloc(n_fe_opts, sizeof *fe_opts);
|
|
|
|
|
opts = fe_opts;
|
|
|
|
|
OVSREC_FLOW_SAMPLE_COLLECTOR_SET_FOR_EACH(fe_cfg, idl) {
|
2013-11-20 10:57:52 -08:00
|
|
|
|
if (ovsrec_fscs_is_valid(fe_cfg, br)) {
|
2013-04-22 10:01:14 -07:00
|
|
|
|
opts->collector_set_id = fe_cfg->id;
|
|
|
|
|
sset_init(&opts->targets);
|
|
|
|
|
sset_add_array(&opts->targets, fe_cfg->ipfix->targets,
|
|
|
|
|
fe_cfg->ipfix->n_targets);
|
2013-08-21 13:49:04 -07:00
|
|
|
|
opts->cache_active_timeout = fe_cfg->ipfix->cache_active_timeout
|
|
|
|
|
? *fe_cfg->ipfix->cache_active_timeout : 0;
|
|
|
|
|
opts->cache_max_flows = fe_cfg->ipfix->cache_max_flows
|
|
|
|
|
? *fe_cfg->ipfix->cache_max_flows : 0;
|
ipfix: Support tunnel information for Flow IPFIX.
Add support to export tunnel information for flow-based IPFIX.
The original steps to configure flow level IPFIX:
1) Create a new record in Flow_Sample_Collector_Set table:
'ovs-vsctl -- create Flow_Sample_Collector_Set id=1 bridge="Bridge UUID"'
2) Add IPFIX configuration which is referred by corresponding
row in Flow_Sample_Collector_Set table:
'ovs-vsctl -- set Flow_Sample_Collector_Set
"Flow_Sample_Collector_Set UUID" ipfix=@i -- --id=@i create IPFIX
targets=\"IP:4739\" obs_domain_id=123 obs_point_id=456
cache_active_timeout=60 cache_max_flows=13'
3) Add sample action to the flows:
'ovs-ofctl add-flow mybridge in_port=1,
actions=sample'('probability=65535,collector_set_id=1,
obs_domain_id=123,obs_point_id=456')',output:3'
NXAST_SAMPLE action was used in step 3. In order to support exporting tunnel
information, the NXAST_SAMPLE2 action was added and with NXAST_SAMPLE2 action
in this patch, the step 3 should be configured like below:
'ovs-ofctl add-flow mybridge in_port=1,
actions=sample'('probability=65535,collector_set_id=1,obs_domain_id=123,
obs_point_id=456,sampling_port=3')',output:3'
'sampling_port' can be equal to ingress port or one of egress ports. If sampling
port is equal to output port and the output port is a tunnel port,
OVS_USERSPACE_ATTR_EGRESS_TUN_PORT will be set in the datapath flow sample action.
When flow sample action upcall happens, tunnel information will be retrieved from
the datapath and then IPFIX can export egress tunnel port information. If
samping_port=65535 (OFPP_NONE), flow-based IPFIX will keep the same behavior
as before.
This patch mainly do three tasks:
1) Add a new flow sample action NXAST_SAMPLE2 to support exporting
tunnel information. NXAST_SAMPLE2 action has a new added field
'sampling_port'.
2) Use 'other_configure: enable-tunnel-sampling' to enable or disable
exporting tunnel information.
3) If 'sampling_port' is equal to output port and output port is a tunnel
port, the translation of OpenFlow "sample" action should first emit
set(tunnel(...)), then the sample action itself. It makes sure the
egress tunnel information can be sampled.
4) Add a test of flow-based IPFIX for tunnel set.
How to test flow-based IPFIX:
1) Setup a test environment with two Linux host with Docker supported
2) Create a Docker container and a GRE tunnel port on each host
3) Use ovs-docker to add the container on the bridge
4) Listen on port 4739 on the collector machine and use wireshark to filter
'cflow' packets.
5) Configure flow-based IPFIX:
- 'ovs-vsctl -- create Flow_Sample_Collector_Set id=1 bridge="Bridge UUID"'
- 'ovs-vsctl -- set Flow_Sample_Collector_Set
"Flow_Sample_Collector_Set UUID" ipfix=@i -- --id=@i create IPFIX \
targets=\"IP:4739\" cache_active_timeout=60 cache_max_flows=13 \
other_config:enable-tunnel-sampling=true'
- 'ovs-ofctl add-flow mybridge in_port=1,
actions=sample'('probability=65535,collector_set_id=1,obs_domain_id=123,
obs_point_id=456,sampling_port=3')',output:3'
Note: The in-port is container port. The output port and sampling_port
are both open flow port and the output port is a GRE tunnel port.
6) Ping from the container whose host enabled flow-based IPFIX.
7) Get the IPFIX template pakcets and IPFIX information packets.
Signed-off-by: Benli Ye <daniely@vmware.com>
Signed-off-by: Ben Pfaff <blp@ovn.org>
2016-06-14 16:53:34 +08:00
|
|
|
|
opts->enable_tunnel_sampling = smap_get_bool(
|
|
|
|
|
&fe_cfg->ipfix->other_config,
|
|
|
|
|
"enable-tunnel-sampling", true);
|
2016-06-24 17:10:07 -07:00
|
|
|
|
virtual_obs_id = smap_get(&fe_cfg->ipfix->other_config,
|
|
|
|
|
"virtual_obs_id");
|
2016-06-24 21:23:16 -07:00
|
|
|
|
opts->virtual_obs_id = nullable_xstrdup(virtual_obs_id);
|
2013-04-22 10:01:14 -07:00
|
|
|
|
opts++;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2013-11-20 10:57:53 -08:00
|
|
|
|
ofproto_set_ipfix(br->ofproto, valid_be_cfg ? &be_opts : NULL, fe_opts,
|
2013-04-22 10:01:14 -07:00
|
|
|
|
n_fe_opts);
|
|
|
|
|
|
2013-11-20 10:57:53 -08:00
|
|
|
|
if (valid_be_cfg) {
|
2013-04-22 10:01:14 -07:00
|
|
|
|
sset_destroy(&be_opts.targets);
|
2016-06-24 17:10:07 -07:00
|
|
|
|
free(be_opts.virtual_obs_id);
|
2013-04-22 10:01:14 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (n_fe_opts > 0) {
|
|
|
|
|
struct ofproto_ipfix_flow_exporter_options *opts = fe_opts;
|
|
|
|
|
size_t i;
|
|
|
|
|
for (i = 0; i < n_fe_opts; i++) {
|
|
|
|
|
sset_destroy(&opts->targets);
|
2016-06-24 17:10:07 -07:00
|
|
|
|
free(opts->virtual_obs_id);
|
2013-04-22 10:01:14 -07:00
|
|
|
|
opts++;
|
|
|
|
|
}
|
|
|
|
|
free(fe_opts);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2011-10-14 09:48:17 -07:00
|
|
|
|
static void
|
|
|
|
|
port_configure_stp(const struct ofproto *ofproto, struct port *port,
|
|
|
|
|
struct ofproto_port_stp_settings *port_s,
|
|
|
|
|
int *port_num_counter, unsigned long *port_num_bitmap)
|
|
|
|
|
{
|
|
|
|
|
const char *config_str;
|
|
|
|
|
struct iface *iface;
|
|
|
|
|
|
2012-08-29 16:00:31 -07:00
|
|
|
|
if (!smap_get_bool(&port->cfg->other_config, "stp-enable", true)) {
|
2011-10-14 09:48:17 -07:00
|
|
|
|
port_s->enable = false;
|
|
|
|
|
return;
|
|
|
|
|
} else {
|
|
|
|
|
port_s->enable = true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* STP over bonds is not supported. */
|
2016-03-25 14:10:22 -07:00
|
|
|
|
if (!ovs_list_is_singleton(&port->ifaces)) {
|
2011-10-14 09:48:17 -07:00
|
|
|
|
VLOG_ERR("port %s: cannot enable STP on bonds, disabling",
|
|
|
|
|
port->name);
|
|
|
|
|
port_s->enable = false;
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2016-03-25 14:10:22 -07:00
|
|
|
|
iface = CONTAINER_OF(ovs_list_front(&port->ifaces), struct iface, port_elem);
|
2011-10-14 09:48:17 -07:00
|
|
|
|
|
|
|
|
|
/* Internal ports shouldn't participate in spanning tree, so
|
|
|
|
|
* skip them. */
|
|
|
|
|
if (!strcmp(iface->type, "internal")) {
|
|
|
|
|
VLOG_DBG("port %s: disable STP on internal ports", port->name);
|
|
|
|
|
port_s->enable = false;
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* STP on mirror output ports is not supported. */
|
|
|
|
|
if (ofproto_is_mirror_output_bundle(ofproto, port)) {
|
|
|
|
|
VLOG_DBG("port %s: disable STP on mirror ports", port->name);
|
|
|
|
|
port_s->enable = false;
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2012-05-22 01:53:07 -07:00
|
|
|
|
config_str = smap_get(&port->cfg->other_config, "stp-port-num");
|
2011-10-14 09:48:17 -07:00
|
|
|
|
if (config_str) {
|
|
|
|
|
unsigned long int port_num = strtoul(config_str, NULL, 0);
|
|
|
|
|
int port_idx = port_num - 1;
|
|
|
|
|
|
|
|
|
|
if (port_num < 1 || port_num > STP_MAX_PORTS) {
|
|
|
|
|
VLOG_ERR("port %s: invalid stp-port-num", port->name);
|
|
|
|
|
port_s->enable = false;
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (bitmap_is_set(port_num_bitmap, port_idx)) {
|
|
|
|
|
VLOG_ERR("port %s: duplicate stp-port-num %lu, disabling",
|
|
|
|
|
port->name, port_num);
|
|
|
|
|
port_s->enable = false;
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
bitmap_set1(port_num_bitmap, port_idx);
|
|
|
|
|
port_s->port_num = port_idx;
|
|
|
|
|
} else {
|
2012-08-21 16:48:36 -07:00
|
|
|
|
if (*port_num_counter >= STP_MAX_PORTS) {
|
2011-10-14 09:48:17 -07:00
|
|
|
|
VLOG_ERR("port %s: too many STP ports, disabling", port->name);
|
|
|
|
|
port_s->enable = false;
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
port_s->port_num = (*port_num_counter)++;
|
|
|
|
|
}
|
|
|
|
|
|
2012-05-22 01:53:07 -07:00
|
|
|
|
config_str = smap_get(&port->cfg->other_config, "stp-path-cost");
|
2011-10-14 09:48:17 -07:00
|
|
|
|
if (config_str) {
|
|
|
|
|
port_s->path_cost = strtoul(config_str, NULL, 10);
|
|
|
|
|
} else {
|
2012-02-15 14:23:38 -08:00
|
|
|
|
enum netdev_features current;
|
2012-11-03 18:00:39 -07:00
|
|
|
|
unsigned int mbps;
|
2011-10-14 09:48:17 -07:00
|
|
|
|
|
2012-11-03 18:00:39 -07:00
|
|
|
|
netdev_get_features(iface->netdev, ¤t, NULL, NULL, NULL);
|
|
|
|
|
mbps = netdev_features_to_bps(current, 100 * 1000 * 1000) / 1000000;
|
|
|
|
|
port_s->path_cost = stp_convert_speed_to_cost(mbps);
|
2011-10-14 09:48:17 -07:00
|
|
|
|
}
|
|
|
|
|
|
2012-05-22 01:53:07 -07:00
|
|
|
|
config_str = smap_get(&port->cfg->other_config, "stp-port-priority");
|
2011-10-14 09:48:17 -07:00
|
|
|
|
if (config_str) {
|
|
|
|
|
port_s->priority = strtoul(config_str, NULL, 0);
|
|
|
|
|
} else {
|
|
|
|
|
port_s->priority = STP_DEFAULT_PORT_PRIORITY;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2014-08-22 09:01:34 -07:00
|
|
|
|
static void
|
|
|
|
|
port_configure_rstp(const struct ofproto *ofproto, struct port *port,
|
|
|
|
|
struct ofproto_port_rstp_settings *port_s, int *port_num_counter)
|
|
|
|
|
{
|
|
|
|
|
const char *config_str;
|
|
|
|
|
struct iface *iface;
|
|
|
|
|
|
|
|
|
|
if (!smap_get_bool(&port->cfg->other_config, "rstp-enable", true)) {
|
|
|
|
|
port_s->enable = false;
|
|
|
|
|
return;
|
|
|
|
|
} else {
|
|
|
|
|
port_s->enable = true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* RSTP over bonds is not supported. */
|
2016-03-25 14:10:22 -07:00
|
|
|
|
if (!ovs_list_is_singleton(&port->ifaces)) {
|
2014-08-22 09:01:34 -07:00
|
|
|
|
VLOG_ERR("port %s: cannot enable RSTP on bonds, disabling",
|
|
|
|
|
port->name);
|
|
|
|
|
port_s->enable = false;
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2016-03-25 14:10:22 -07:00
|
|
|
|
iface = CONTAINER_OF(ovs_list_front(&port->ifaces), struct iface, port_elem);
|
2014-08-22 09:01:34 -07:00
|
|
|
|
|
|
|
|
|
/* Internal ports shouldn't participate in spanning tree, so
|
|
|
|
|
* skip them. */
|
|
|
|
|
if (!strcmp(iface->type, "internal")) {
|
|
|
|
|
VLOG_DBG("port %s: disable RSTP on internal ports", port->name);
|
|
|
|
|
port_s->enable = false;
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* RSTP on mirror output ports is not supported. */
|
|
|
|
|
if (ofproto_is_mirror_output_bundle(ofproto, port)) {
|
|
|
|
|
VLOG_DBG("port %s: disable RSTP on mirror ports", port->name);
|
|
|
|
|
port_s->enable = false;
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
config_str = smap_get(&port->cfg->other_config, "rstp-port-num");
|
|
|
|
|
if (config_str) {
|
|
|
|
|
unsigned long int port_num = strtoul(config_str, NULL, 0);
|
|
|
|
|
if (port_num < 1 || port_num > RSTP_MAX_PORTS) {
|
|
|
|
|
VLOG_ERR("port %s: invalid rstp-port-num", port->name);
|
|
|
|
|
port_s->enable = false;
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
port_s->port_num = port_num;
|
2014-09-09 09:01:16 -07:00
|
|
|
|
} else {
|
2014-08-22 09:01:34 -07:00
|
|
|
|
if (*port_num_counter >= RSTP_MAX_PORTS) {
|
|
|
|
|
VLOG_ERR("port %s: too many RSTP ports, disabling", port->name);
|
|
|
|
|
port_s->enable = false;
|
|
|
|
|
return;
|
|
|
|
|
}
|
2014-09-09 09:01:16 -07:00
|
|
|
|
/* If rstp-port-num is not specified, use 0.
|
|
|
|
|
* rstp_port_set_port_number() will look for the first free one. */
|
2014-08-22 09:01:34 -07:00
|
|
|
|
port_s->port_num = 0;
|
|
|
|
|
}
|
|
|
|
|
|
2017-05-19 00:20:42 -07:00
|
|
|
|
/* Increment the port num counter, because we only support
|
|
|
|
|
* RSTP_MAX_PORTS rstp ports. */
|
|
|
|
|
(*port_num_counter)++;
|
|
|
|
|
|
2014-08-22 09:01:34 -07:00
|
|
|
|
config_str = smap_get(&port->cfg->other_config, "rstp-path-cost");
|
|
|
|
|
if (config_str) {
|
|
|
|
|
port_s->path_cost = strtoul(config_str, NULL, 10);
|
|
|
|
|
} else {
|
|
|
|
|
enum netdev_features current;
|
|
|
|
|
unsigned int mbps;
|
|
|
|
|
|
|
|
|
|
netdev_get_features(iface->netdev, ¤t, NULL, NULL, NULL);
|
|
|
|
|
mbps = netdev_features_to_bps(current, 100 * 1000 * 1000) / 1000000;
|
|
|
|
|
port_s->path_cost = rstp_convert_speed_to_cost(mbps);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
config_str = smap_get(&port->cfg->other_config, "rstp-port-priority");
|
|
|
|
|
if (config_str) {
|
|
|
|
|
port_s->priority = strtoul(config_str, NULL, 0);
|
|
|
|
|
} else {
|
|
|
|
|
port_s->priority = RSTP_DEFAULT_PORT_PRIORITY;
|
|
|
|
|
}
|
|
|
|
|
|
2016-07-20 16:44:09 -07:00
|
|
|
|
port_s->admin_p2p_mac_state = smap_get_ullong(
|
|
|
|
|
&port->cfg->other_config, "rstp-admin-p2p-mac",
|
|
|
|
|
RSTP_ADMIN_P2P_MAC_FORCE_TRUE);
|
2014-11-14 14:07:50 -08:00
|
|
|
|
|
|
|
|
|
port_s->admin_port_state = smap_get_bool(&port->cfg->other_config,
|
|
|
|
|
"rstp-admin-port-state", true);
|
|
|
|
|
|
2014-08-22 09:01:34 -07:00
|
|
|
|
port_s->admin_edge_port = smap_get_bool(&port->cfg->other_config,
|
|
|
|
|
"rstp-port-admin-edge", false);
|
|
|
|
|
port_s->auto_edge = smap_get_bool(&port->cfg->other_config,
|
|
|
|
|
"rstp-port-auto-edge", true);
|
|
|
|
|
port_s->mcheck = smap_get_bool(&port->cfg->other_config,
|
|
|
|
|
"rstp-port-mcheck", false);
|
|
|
|
|
}
|
|
|
|
|
|
2011-10-14 09:48:17 -07:00
|
|
|
|
/* Set spanning tree configuration on 'br'. */
|
|
|
|
|
static void
|
2015-03-05 11:12:21 -08:00
|
|
|
|
bridge_configure_stp(struct bridge *br, bool enable_stp)
|
2011-10-14 09:48:17 -07:00
|
|
|
|
{
|
2015-03-05 11:12:21 -08:00
|
|
|
|
if (!enable_stp) {
|
2014-08-22 09:01:34 -07:00
|
|
|
|
ofproto_set_stp(br->ofproto, NULL);
|
2011-10-14 09:48:17 -07:00
|
|
|
|
} else {
|
|
|
|
|
struct ofproto_stp_settings br_s;
|
|
|
|
|
const char *config_str;
|
|
|
|
|
struct port *port;
|
|
|
|
|
int port_num_counter;
|
|
|
|
|
unsigned long *port_num_bitmap;
|
|
|
|
|
|
2012-05-22 01:53:07 -07:00
|
|
|
|
config_str = smap_get(&br->cfg->other_config, "stp-system-id");
|
2011-10-14 09:48:17 -07:00
|
|
|
|
if (config_str) {
|
2015-08-28 14:55:11 -07:00
|
|
|
|
struct eth_addr ea;
|
2011-10-14 09:48:17 -07:00
|
|
|
|
|
2015-08-28 14:55:11 -07:00
|
|
|
|
if (eth_addr_from_string(config_str, &ea)) {
|
2011-10-14 09:48:17 -07:00
|
|
|
|
br_s.system_id = eth_addr_to_uint64(ea);
|
|
|
|
|
} else {
|
|
|
|
|
br_s.system_id = eth_addr_to_uint64(br->ea);
|
|
|
|
|
VLOG_ERR("bridge %s: invalid stp-system-id, defaulting "
|
|
|
|
|
"to "ETH_ADDR_FMT, br->name, ETH_ADDR_ARGS(br->ea));
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
br_s.system_id = eth_addr_to_uint64(br->ea);
|
|
|
|
|
}
|
|
|
|
|
|
2016-07-20 16:44:09 -07:00
|
|
|
|
br_s.priority = smap_get_ullong(&br->cfg->other_config, "stp-priority",
|
|
|
|
|
STP_DEFAULT_BRIDGE_PRIORITY);
|
|
|
|
|
br_s.hello_time = smap_get_ullong(&br->cfg->other_config,
|
|
|
|
|
"stp-hello-time",
|
|
|
|
|
STP_DEFAULT_HELLO_TIME);
|
2011-10-14 09:48:17 -07:00
|
|
|
|
|
2016-07-20 16:44:09 -07:00
|
|
|
|
br_s.max_age = smap_get_ullong(&br->cfg->other_config, "stp-max-age",
|
2017-03-07 05:11:29 -08:00
|
|
|
|
STP_DEFAULT_MAX_AGE / 1000) * 1000;
|
2016-07-20 16:44:09 -07:00
|
|
|
|
br_s.fwd_delay = smap_get_ullong(&br->cfg->other_config,
|
|
|
|
|
"stp-forward-delay",
|
|
|
|
|
STP_DEFAULT_FWD_DELAY / 1000) * 1000;
|
2011-10-14 09:48:17 -07:00
|
|
|
|
|
|
|
|
|
/* Configure STP on the bridge. */
|
|
|
|
|
if (ofproto_set_stp(br->ofproto, &br_s)) {
|
|
|
|
|
VLOG_ERR("bridge %s: could not enable STP", br->name);
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Users must either set the port number with the "stp-port-num"
|
|
|
|
|
* configuration on all ports or none. If manual configuration
|
|
|
|
|
* is not done, then we allocate them sequentially. */
|
|
|
|
|
port_num_counter = 0;
|
|
|
|
|
port_num_bitmap = bitmap_allocate(STP_MAX_PORTS);
|
|
|
|
|
HMAP_FOR_EACH (port, hmap_node, &br->ports) {
|
|
|
|
|
struct ofproto_port_stp_settings port_s;
|
|
|
|
|
struct iface *iface;
|
|
|
|
|
|
|
|
|
|
port_configure_stp(br->ofproto, port, &port_s,
|
|
|
|
|
&port_num_counter, port_num_bitmap);
|
|
|
|
|
|
|
|
|
|
/* As bonds are not supported, just apply configuration to
|
|
|
|
|
* all interfaces. */
|
|
|
|
|
LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
|
|
|
|
|
if (ofproto_port_set_stp(br->ofproto, iface->ofp_port,
|
|
|
|
|
&port_s)) {
|
|
|
|
|
VLOG_ERR("port %s: could not enable STP", port->name);
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2014-03-23 23:00:17 -07:00
|
|
|
|
if (bitmap_scan(port_num_bitmap, 1, 0, STP_MAX_PORTS) != STP_MAX_PORTS
|
2011-10-14 09:48:17 -07:00
|
|
|
|
&& port_num_counter) {
|
|
|
|
|
VLOG_ERR("bridge %s: must manually configure all STP port "
|
|
|
|
|
"IDs or none, disabling", br->name);
|
|
|
|
|
ofproto_set_stp(br->ofproto, NULL);
|
|
|
|
|
}
|
|
|
|
|
bitmap_free(port_num_bitmap);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2014-08-22 09:01:34 -07:00
|
|
|
|
static void
|
2015-03-05 11:12:21 -08:00
|
|
|
|
bridge_configure_rstp(struct bridge *br, bool enable_rstp)
|
2014-08-22 09:01:34 -07:00
|
|
|
|
{
|
2015-03-05 11:12:21 -08:00
|
|
|
|
if (!enable_rstp) {
|
2014-08-22 09:01:34 -07:00
|
|
|
|
ofproto_set_rstp(br->ofproto, NULL);
|
|
|
|
|
} else {
|
|
|
|
|
struct ofproto_rstp_settings br_s;
|
|
|
|
|
const char *config_str;
|
|
|
|
|
struct port *port;
|
|
|
|
|
int port_num_counter;
|
|
|
|
|
|
|
|
|
|
config_str = smap_get(&br->cfg->other_config, "rstp-address");
|
|
|
|
|
if (config_str) {
|
2015-08-28 14:55:11 -07:00
|
|
|
|
struct eth_addr ea;
|
2014-08-22 09:01:34 -07:00
|
|
|
|
|
2015-08-28 14:55:11 -07:00
|
|
|
|
if (eth_addr_from_string(config_str, &ea)) {
|
2014-08-22 09:01:34 -07:00
|
|
|
|
br_s.address = eth_addr_to_uint64(ea);
|
|
|
|
|
}
|
|
|
|
|
else {
|
|
|
|
|
br_s.address = eth_addr_to_uint64(br->ea);
|
|
|
|
|
VLOG_ERR("bridge %s: invalid rstp-address, defaulting "
|
|
|
|
|
"to "ETH_ADDR_FMT, br->name, ETH_ADDR_ARGS(br->ea));
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
else {
|
|
|
|
|
br_s.address = eth_addr_to_uint64(br->ea);
|
|
|
|
|
}
|
|
|
|
|
|
2016-07-20 16:44:09 -07:00
|
|
|
|
const struct smap *oc = &br->cfg->other_config;
|
|
|
|
|
br_s.priority = smap_get_ullong(oc, "rstp-priority",
|
|
|
|
|
RSTP_DEFAULT_PRIORITY);
|
|
|
|
|
br_s.ageing_time = smap_get_ullong(oc, "rstp-ageing-time",
|
|
|
|
|
RSTP_DEFAULT_AGEING_TIME);
|
|
|
|
|
br_s.force_protocol_version = smap_get_ullong(
|
|
|
|
|
oc, "rstp-force-protocol-version", FPV_DEFAULT);
|
|
|
|
|
br_s.bridge_max_age = smap_get_ullong(oc, "rstp-max-age",
|
|
|
|
|
RSTP_DEFAULT_BRIDGE_MAX_AGE);
|
|
|
|
|
br_s.bridge_forward_delay = smap_get_ullong(
|
|
|
|
|
oc, "rstp-forward-delay", RSTP_DEFAULT_BRIDGE_FORWARD_DELAY);
|
|
|
|
|
br_s.transmit_hold_count = smap_get_ullong(
|
|
|
|
|
oc, "rstp-transmit-hold-count", RSTP_DEFAULT_TRANSMIT_HOLD_COUNT);
|
2014-08-22 09:01:34 -07:00
|
|
|
|
|
|
|
|
|
/* Configure RSTP on the bridge. */
|
|
|
|
|
if (ofproto_set_rstp(br->ofproto, &br_s)) {
|
|
|
|
|
VLOG_ERR("bridge %s: could not enable RSTP", br->name);
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
port_num_counter = 0;
|
|
|
|
|
HMAP_FOR_EACH (port, hmap_node, &br->ports) {
|
|
|
|
|
struct ofproto_port_rstp_settings port_s;
|
|
|
|
|
struct iface *iface;
|
|
|
|
|
|
|
|
|
|
port_configure_rstp(br->ofproto, port, &port_s,
|
|
|
|
|
&port_num_counter);
|
|
|
|
|
|
|
|
|
|
/* As bonds are not supported, just apply configuration to
|
|
|
|
|
* all interfaces. */
|
|
|
|
|
LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
|
|
|
|
|
if (ofproto_port_set_rstp(br->ofproto, iface->ofp_port,
|
|
|
|
|
&port_s)) {
|
|
|
|
|
VLOG_ERR("port %s: could not enable RSTP", port->name);
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2015-03-05 11:12:21 -08:00
|
|
|
|
static void
|
|
|
|
|
bridge_configure_spanning_tree(struct bridge *br)
|
|
|
|
|
{
|
|
|
|
|
bool enable_rstp = br->cfg->rstp_enable;
|
|
|
|
|
bool enable_stp = br->cfg->stp_enable;
|
|
|
|
|
|
|
|
|
|
if (enable_rstp && enable_stp) {
|
|
|
|
|
VLOG_WARN("%s: RSTP and STP are mutually exclusive but both are "
|
|
|
|
|
"configured; enabling RSTP", br->name);
|
|
|
|
|
enable_stp = false;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
bridge_configure_stp(br, enable_stp);
|
|
|
|
|
bridge_configure_rstp(br, enable_rstp);
|
|
|
|
|
}
|
|
|
|
|
|
2011-05-04 10:18:23 -07:00
|
|
|
|
static bool
|
|
|
|
|
bridge_has_bond_fake_iface(const struct bridge *br, const char *name)
|
|
|
|
|
{
|
|
|
|
|
const struct port *port = port_lookup(br, name);
|
|
|
|
|
return port && port_is_bond_fake_iface(port);
|
2009-12-11 17:03:35 -08:00
|
|
|
|
}
|
|
|
|
|
|
2011-05-04 10:18:23 -07:00
|
|
|
|
static bool
|
|
|
|
|
port_is_bond_fake_iface(const struct port *port)
|
2009-12-11 17:03:35 -08:00
|
|
|
|
{
|
2016-03-25 14:10:22 -07:00
|
|
|
|
return port->cfg->bond_fake_iface && !ovs_list_is_short(&port->ifaces);
|
2011-05-04 10:18:23 -07:00
|
|
|
|
}
|
2009-12-11 17:03:35 -08:00
|
|
|
|
|
2011-04-08 13:50:21 -07:00
|
|
|
|
static void
|
|
|
|
|
add_del_bridges(const struct ovsrec_open_vswitch *cfg)
|
|
|
|
|
{
|
|
|
|
|
struct bridge *br, *next;
|
2016-02-02 13:28:11 -08:00
|
|
|
|
struct shash_node *node;
|
2011-04-08 13:50:21 -07:00
|
|
|
|
struct shash new_br;
|
|
|
|
|
size_t i;
|
|
|
|
|
|
|
|
|
|
/* Collect new bridges' names and types. */
|
|
|
|
|
shash_init(&new_br);
|
|
|
|
|
for (i = 0; i < cfg->n_bridges; i++) {
|
2011-10-14 10:17:41 -07:00
|
|
|
|
static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
|
2011-04-08 13:50:21 -07:00
|
|
|
|
const struct ovsrec_bridge *br_cfg = cfg->bridges[i];
|
2011-10-14 10:17:41 -07:00
|
|
|
|
|
2016-02-03 14:45:30 -08:00
|
|
|
|
if (strchr(br_cfg->name, '/') || strchr(br_cfg->name, '\\')) {
|
2011-10-14 10:17:41 -07:00
|
|
|
|
/* Prevent remote ovsdb-server users from accessing arbitrary
|
2016-02-03 14:45:30 -08:00
|
|
|
|
* directories, e.g. consider a bridge named "../../../etc/".
|
|
|
|
|
*
|
|
|
|
|
* Prohibiting "\" is only necessary on Windows but it's no great
|
|
|
|
|
* loss elsewhere. */
|
2011-10-14 10:17:41 -07:00
|
|
|
|
VLOG_WARN_RL(&rl, "ignoring bridge with invalid name \"%s\"",
|
|
|
|
|
br_cfg->name);
|
|
|
|
|
} else if (!shash_add_once(&new_br, br_cfg->name, br_cfg)) {
|
|
|
|
|
VLOG_WARN_RL(&rl, "bridge %s specified twice", br_cfg->name);
|
2011-04-08 13:50:21 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Get rid of deleted bridges or those whose types have changed.
|
|
|
|
|
* Update 'cfg' of bridges that still exist. */
|
|
|
|
|
HMAP_FOR_EACH_SAFE (br, next, node, &all_bridges) {
|
|
|
|
|
br->cfg = shash_find_data(&new_br, br->name);
|
2011-05-09 09:33:02 -07:00
|
|
|
|
if (!br->cfg || strcmp(br->type, ofproto_normalize_type(
|
|
|
|
|
br->cfg->datapath_type))) {
|
2016-02-04 09:48:54 -08:00
|
|
|
|
bridge_destroy(br, true);
|
2011-04-08 13:50:21 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Add new bridges. */
|
2016-02-02 13:28:11 -08:00
|
|
|
|
SHASH_FOR_EACH(node, &new_br) {
|
|
|
|
|
const struct ovsrec_bridge *br_cfg = node->data;
|
2017-08-02 15:03:06 -07:00
|
|
|
|
if (!bridge_lookup(br_cfg->name)) {
|
2011-04-08 13:50:21 -07:00
|
|
|
|
bridge_create(br_cfg);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
shash_destroy(&new_br);
|
|
|
|
|
}
|
|
|
|
|
|
2012-04-24 16:28:18 -07:00
|
|
|
|
/* Configures 'netdev' based on the "options" column in 'iface_cfg'.
|
|
|
|
|
* Returns 0 if successful, otherwise a positive errno value. */
|
|
|
|
|
static int
|
|
|
|
|
iface_set_netdev_config(const struct ovsrec_interface *iface_cfg,
|
2014-04-10 12:50:10 +02:00
|
|
|
|
struct netdev *netdev, char **errp)
|
2012-04-24 16:28:18 -07:00
|
|
|
|
{
|
2014-04-10 12:50:10 +02:00
|
|
|
|
return netdev_set_config(netdev, &iface_cfg->options, errp);
|
2012-04-24 16:28:18 -07:00
|
|
|
|
}
|
|
|
|
|
|
2014-01-15 12:41:23 +09:00
|
|
|
|
/* Opens a network device for 'if_cfg' and configures it. Adds the network
|
|
|
|
|
* device to br->ofproto and stores the OpenFlow port number in '*ofp_portp'.
|
2012-04-24 16:53:01 -07:00
|
|
|
|
*
|
|
|
|
|
* If successful, returns 0 and stores the network device in '*netdevp'. On
|
|
|
|
|
* failure, returns a positive errno value and stores NULL in '*netdevp'. */
|
|
|
|
|
static int
|
|
|
|
|
iface_do_create(const struct bridge *br,
|
2013-12-11 17:55:26 -08:00
|
|
|
|
const struct ovsrec_interface *iface_cfg,
|
2014-04-10 12:50:10 +02:00
|
|
|
|
ofp_port_t *ofp_portp, struct netdev **netdevp,
|
|
|
|
|
char **errp)
|
2012-04-24 16:53:01 -07:00
|
|
|
|
{
|
2013-05-16 22:37:53 -07:00
|
|
|
|
struct netdev *netdev = NULL;
|
2012-04-24 16:53:01 -07:00
|
|
|
|
int error;
|
2016-07-04 15:19:56 -03:00
|
|
|
|
const char *type;
|
2012-04-24 16:53:01 -07:00
|
|
|
|
|
2013-05-16 14:11:51 -07:00
|
|
|
|
if (netdev_is_reserved_name(iface_cfg->name)) {
|
|
|
|
|
VLOG_WARN("could not create interface %s, name is reserved",
|
|
|
|
|
iface_cfg->name);
|
|
|
|
|
error = EINVAL;
|
|
|
|
|
goto error;
|
|
|
|
|
}
|
|
|
|
|
|
2018-02-23 14:03:15 -08:00
|
|
|
|
type = ofproto_port_open_type(br->ofproto,
|
2016-07-04 15:19:56 -03:00
|
|
|
|
iface_get_type(iface_cfg, br->cfg));
|
|
|
|
|
error = netdev_open(iface_cfg->name, type, &netdev);
|
2012-04-24 16:53:01 -07:00
|
|
|
|
if (error) {
|
2014-04-10 12:50:10 +02:00
|
|
|
|
VLOG_WARN_BUF(errp, "could not open network device %s (%s)",
|
|
|
|
|
iface_cfg->name, ovs_strerror(error));
|
2012-04-24 16:53:01 -07:00
|
|
|
|
goto error;
|
|
|
|
|
}
|
|
|
|
|
|
2014-04-10 12:50:10 +02:00
|
|
|
|
error = iface_set_netdev_config(iface_cfg, netdev, errp);
|
2012-04-24 16:53:01 -07:00
|
|
|
|
if (error) {
|
|
|
|
|
goto error;
|
|
|
|
|
}
|
|
|
|
|
|
2016-09-02 09:53:00 -07:00
|
|
|
|
iface_set_netdev_mtu(iface_cfg, netdev);
|
2016-08-29 19:01:13 -07:00
|
|
|
|
|
2013-12-11 17:55:26 -08:00
|
|
|
|
*ofp_portp = iface_pick_ofport(iface_cfg);
|
|
|
|
|
error = ofproto_port_add(br->ofproto, netdev, ofp_portp);
|
|
|
|
|
if (error) {
|
2019-09-16 11:16:57 -04:00
|
|
|
|
static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
|
|
|
|
|
|
|
|
|
|
*errp = xasprintf("could not add network device %s to ofproto (%s)",
|
|
|
|
|
iface_cfg->name, ovs_strerror(error));
|
|
|
|
|
if (!VLOG_DROP_WARN(&rl)) {
|
|
|
|
|
VLOG_WARN("%s", *errp);
|
|
|
|
|
}
|
2013-12-11 17:55:26 -08:00
|
|
|
|
goto error;
|
2012-04-24 16:53:01 -07:00
|
|
|
|
}
|
|
|
|
|
|
2013-12-11 17:55:26 -08:00
|
|
|
|
VLOG_INFO("bridge %s: added interface %s on port %d",
|
|
|
|
|
br->name, iface_cfg->name, *ofp_portp);
|
|
|
|
|
|
2012-04-24 16:53:01 -07:00
|
|
|
|
*netdevp = netdev;
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
|
|
error:
|
|
|
|
|
*netdevp = NULL;
|
|
|
|
|
netdev_close(netdev);
|
|
|
|
|
return error;
|
|
|
|
|
}
|
|
|
|
|
|
2012-04-20 19:11:35 -07:00
|
|
|
|
/* Creates a new iface on 'br' based on 'if_cfg'. The new iface has OpenFlow
|
2013-06-04 12:46:38 -07:00
|
|
|
|
* port number 'ofp_port'. If ofp_port is OFPP_NONE, an OpenFlow port is
|
2012-04-20 19:11:35 -07:00
|
|
|
|
* automatically allocated for the iface. Takes ownership of and
|
2012-04-24 16:39:50 -07:00
|
|
|
|
* deallocates 'if_cfg'.
|
|
|
|
|
*
|
|
|
|
|
* Return true if an iface is successfully created, false otherwise. */
|
|
|
|
|
static bool
|
2013-12-11 17:55:26 -08:00
|
|
|
|
iface_create(struct bridge *br, const struct ovsrec_interface *iface_cfg,
|
|
|
|
|
const struct ovsrec_port *port_cfg)
|
2011-04-08 13:50:21 -07:00
|
|
|
|
{
|
2012-04-24 16:53:01 -07:00
|
|
|
|
struct netdev *netdev;
|
2012-04-20 19:11:35 -07:00
|
|
|
|
struct iface *iface;
|
2013-12-11 17:55:26 -08:00
|
|
|
|
ofp_port_t ofp_port;
|
2012-04-20 19:11:35 -07:00
|
|
|
|
struct port *port;
|
2014-04-10 12:50:10 +02:00
|
|
|
|
char *errp = NULL;
|
2012-04-20 19:11:35 -07:00
|
|
|
|
int error;
|
2011-11-23 17:03:31 -08:00
|
|
|
|
|
2013-11-20 17:12:40 -08:00
|
|
|
|
/* Do the bits that can fail up front. */
|
2012-11-06 13:14:55 -08:00
|
|
|
|
ovs_assert(!iface_lookup(br, iface_cfg->name));
|
2016-04-25 11:27:58 -07:00
|
|
|
|
error = iface_do_create(br, iface_cfg, &ofp_port, &netdev, &errp);
|
2012-04-20 19:11:35 -07:00
|
|
|
|
if (error) {
|
2014-04-10 12:50:10 +02:00
|
|
|
|
iface_clear_db_record(iface_cfg, errp);
|
|
|
|
|
free(errp);
|
2013-12-11 17:55:26 -08:00
|
|
|
|
return false;
|
2012-04-20 19:11:35 -07:00
|
|
|
|
}
|
2012-04-06 18:38:48 -07:00
|
|
|
|
|
2012-04-24 16:53:01 -07:00
|
|
|
|
/* Get or create the port structure. */
|
|
|
|
|
port = port_lookup(br, port_cfg->name);
|
|
|
|
|
if (!port) {
|
|
|
|
|
port = port_create(br, port_cfg);
|
2012-04-20 19:11:35 -07:00
|
|
|
|
}
|
|
|
|
|
|
2012-04-24 16:53:01 -07:00
|
|
|
|
/* Create the iface structure. */
|
|
|
|
|
iface = xzalloc(sizeof *iface);
|
2016-03-25 14:10:22 -07:00
|
|
|
|
ovs_list_push_back(&port->ifaces, &iface->port_elem);
|
2012-04-24 16:53:01 -07:00
|
|
|
|
hmap_insert(&br->iface_by_name, &iface->name_node,
|
|
|
|
|
hash_string(iface_cfg->name, 0));
|
|
|
|
|
iface->port = port;
|
|
|
|
|
iface->name = xstrdup(iface_cfg->name);
|
2013-12-11 17:55:26 -08:00
|
|
|
|
iface->ofp_port = ofp_port;
|
2012-04-24 16:53:01 -07:00
|
|
|
|
iface->netdev = netdev;
|
|
|
|
|
iface->type = iface_get_type(iface_cfg, br->cfg);
|
|
|
|
|
iface->cfg = iface_cfg;
|
2013-12-11 17:55:26 -08:00
|
|
|
|
hmap_insert(&br->ifaces, &iface->ofp_port_node,
|
|
|
|
|
hash_ofp_port(ofp_port));
|
2012-04-24 14:56:53 -07:00
|
|
|
|
|
2012-04-24 16:53:01 -07:00
|
|
|
|
/* Populate initial status in database. */
|
|
|
|
|
iface_refresh_stats(iface);
|
2014-04-03 13:12:35 -07:00
|
|
|
|
iface_refresh_netdev_status(iface);
|
2012-04-20 19:11:35 -07:00
|
|
|
|
|
|
|
|
|
/* Add bond fake iface if necessary. */
|
|
|
|
|
if (port_is_bond_fake_iface(port)) {
|
2012-04-24 14:56:53 -07:00
|
|
|
|
struct ofproto_port ofproto_port;
|
|
|
|
|
|
2012-04-20 19:11:35 -07:00
|
|
|
|
if (ofproto_port_query_by_name(br->ofproto, port->name,
|
|
|
|
|
&ofproto_port)) {
|
|
|
|
|
error = netdev_open(port->name, "internal", &netdev);
|
|
|
|
|
if (!error) {
|
2013-12-11 15:40:52 -08:00
|
|
|
|
ofp_port_t fake_ofp_port = OFPP_NONE;
|
2013-01-24 13:57:37 -08:00
|
|
|
|
ofproto_port_add(br->ofproto, netdev, &fake_ofp_port);
|
2012-04-20 19:11:35 -07:00
|
|
|
|
netdev_close(netdev);
|
2011-04-08 13:50:21 -07:00
|
|
|
|
} else {
|
2012-04-20 19:11:35 -07:00
|
|
|
|
VLOG_WARN("could not open network device %s (%s)",
|
2013-06-24 10:54:49 -07:00
|
|
|
|
port->name, ovs_strerror(error));
|
2011-04-08 13:50:21 -07:00
|
|
|
|
}
|
2012-04-20 19:11:35 -07:00
|
|
|
|
} else {
|
|
|
|
|
/* Already exists, nothing to do. */
|
|
|
|
|
ofproto_port_destroy(&ofproto_port);
|
2011-04-08 13:50:21 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
2012-04-24 16:39:50 -07:00
|
|
|
|
|
2013-12-11 17:55:26 -08:00
|
|
|
|
return true;
|
2011-04-08 13:50:21 -07:00
|
|
|
|
}
|
|
|
|
|
|
Option to forward BPDU (Ethernet control class) frames
Currently, a NORMAL action bridge drops reserved-multicast-mac addresses;
01-80-c2-00-00-[f0:ff]. A node that does not implement STP should have an
option to forward such frames.
This commit proposes to have a configuration option to allow forwarding of
BPDU class frames. To ensure backward compatibility, this option is
disabled by default.
This config can be set using bridge's other-config column, for e.g
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
Changing this option can revalidate all flows in a software-OVS
implementation (ofproto-dpif)
--------
unit tests:
------------
make config changes, test runtime behavior
-- test runtime behavior --
continuously send packets to br0 with dest-mac=01:80:c2:00:00:00
ovs-dpctl dump-flows br0
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
ovs-dpctl dump-flows br0
ovs-vsctl set bridge br0 other-config:forward-bpdu=false
ovs-dpctl dump-flows br0
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
ovs-dpctl dump-flows br0
ovs-vsctl remove bridge br0 other-config forward-bpdu=true
ovs-dpctl dump-flows br0
--result--
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:29550, bytes:1773000, used:0.004s, actions:drop
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:8209, bytes:492540, used:0.000s, actions:2,0
ovs-vsctl set bridge br0 other-config:forward-bpdu=false
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:19, bytes:1140, used:0.000s, actions:drop
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:29, bytes:1740, used:0.000s, actions:2,0
ovs-vsctl remove bridge br0 other-config forward-bpdu=true
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:0, bytes:0, used:never, actions:drop
Bug #6624
Reported-by: Niklas Andersson <nandersson@nicira.com>
2011-08-09 11:08:27 -07:00
|
|
|
|
/* Set forward BPDU option. */
|
|
|
|
|
static void
|
|
|
|
|
bridge_configure_forward_bpdu(struct bridge *br)
|
|
|
|
|
{
|
2012-05-22 01:53:07 -07:00
|
|
|
|
ofproto_set_forward_bpdu(br->ofproto,
|
|
|
|
|
smap_get_bool(&br->cfg->other_config,
|
|
|
|
|
"forward-bpdu",
|
|
|
|
|
false));
|
Option to forward BPDU (Ethernet control class) frames
Currently, a NORMAL action bridge drops reserved-multicast-mac addresses;
01-80-c2-00-00-[f0:ff]. A node that does not implement STP should have an
option to forward such frames.
This commit proposes to have a configuration option to allow forwarding of
BPDU class frames. To ensure backward compatibility, this option is
disabled by default.
This config can be set using bridge's other-config column, for e.g
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
Changing this option can revalidate all flows in a software-OVS
implementation (ofproto-dpif)
--------
unit tests:
------------
make config changes, test runtime behavior
-- test runtime behavior --
continuously send packets to br0 with dest-mac=01:80:c2:00:00:00
ovs-dpctl dump-flows br0
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
ovs-dpctl dump-flows br0
ovs-vsctl set bridge br0 other-config:forward-bpdu=false
ovs-dpctl dump-flows br0
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
ovs-dpctl dump-flows br0
ovs-vsctl remove bridge br0 other-config forward-bpdu=true
ovs-dpctl dump-flows br0
--result--
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:29550, bytes:1773000, used:0.004s, actions:drop
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:8209, bytes:492540, used:0.000s, actions:2,0
ovs-vsctl set bridge br0 other-config:forward-bpdu=false
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:19, bytes:1140, used:0.000s, actions:drop
ovs-vsctl set bridge br0 other-config:forward-bpdu=true
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:29, bytes:1740, used:0.000s, actions:2,0
ovs-vsctl remove bridge br0 other-config forward-bpdu=true
ovs-dpctl dump-flows br0
in_port(1),eth(src=00:0c:29:d1:39:42,dst=01:80:c2:00:00:00), packets:0, bytes:0, used:never, actions:drop
Bug #6624
Reported-by: Niklas Andersson <nandersson@nicira.com>
2011-08-09 11:08:27 -07:00
|
|
|
|
}
|
|
|
|
|
|
2012-12-08 12:32:33 -08:00
|
|
|
|
/* Set MAC learning table configuration for 'br'. */
|
2012-02-01 15:04:51 -08:00
|
|
|
|
static void
|
2012-12-08 12:32:33 -08:00
|
|
|
|
bridge_configure_mac_table(struct bridge *br)
|
2012-02-01 15:04:51 -08:00
|
|
|
|
{
|
2016-07-20 16:44:09 -07:00
|
|
|
|
const struct smap *oc = &br->cfg->other_config;
|
|
|
|
|
int idle_time = smap_get_int(oc, "mac-aging-time", 0);
|
|
|
|
|
if (!idle_time) {
|
|
|
|
|
idle_time = MAC_ENTRY_DEFAULT_IDLE_TIME;
|
|
|
|
|
}
|
2012-12-08 12:32:33 -08:00
|
|
|
|
|
2016-07-20 16:44:09 -07:00
|
|
|
|
int mac_table_size = smap_get_int(oc, "mac-table-size", 0);
|
|
|
|
|
if (!mac_table_size) {
|
|
|
|
|
mac_table_size = MAC_DEFAULT_MAX;
|
|
|
|
|
}
|
2012-12-08 12:32:33 -08:00
|
|
|
|
|
|
|
|
|
ofproto_set_mac_table_config(br->ofproto, idle_time, mac_table_size);
|
2012-02-01 15:04:51 -08:00
|
|
|
|
}
|
|
|
|
|
|
2014-06-18 22:14:35 -03:00
|
|
|
|
/* Set multicast snooping table configuration for 'br'. */
|
|
|
|
|
static void
|
|
|
|
|
bridge_configure_mcast_snooping(struct bridge *br)
|
|
|
|
|
{
|
|
|
|
|
if (!br->cfg->mcast_snooping_enable) {
|
|
|
|
|
ofproto_set_mcast_snooping(br->ofproto, NULL);
|
|
|
|
|
} else {
|
|
|
|
|
struct port *port;
|
|
|
|
|
struct ofproto_mcast_snooping_settings br_s;
|
2016-07-20 16:44:09 -07:00
|
|
|
|
|
|
|
|
|
const struct smap *oc = &br->cfg->other_config;
|
|
|
|
|
int idle_time = smap_get_int(oc, "mcast-snooping-aging-time", 0);
|
|
|
|
|
br_s.idle_time = idle_time ? idle_time : MCAST_ENTRY_DEFAULT_IDLE_TIME;
|
|
|
|
|
int max_entries = smap_get_int(oc, "mcast-snooping-table-size", 0);
|
|
|
|
|
br_s.max_entries = (max_entries
|
|
|
|
|
? max_entries
|
2014-06-18 22:14:35 -03:00
|
|
|
|
: MCAST_DEFAULT_MAX_ENTRIES);
|
|
|
|
|
|
2016-07-20 16:44:09 -07:00
|
|
|
|
br_s.flood_unreg = !smap_get_bool(
|
|
|
|
|
oc, "mcast-snooping-disable-flood-unregistered", false);
|
2014-06-18 22:14:35 -03:00
|
|
|
|
|
|
|
|
|
/* Configure multicast snooping on the bridge */
|
|
|
|
|
if (ofproto_set_mcast_snooping(br->ofproto, &br_s)) {
|
|
|
|
|
VLOG_ERR("bridge %s: could not enable multicast snooping",
|
|
|
|
|
br->name);
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
HMAP_FOR_EACH (port, hmap_node, &br->ports) {
|
2014-12-11 09:38:19 -02:00
|
|
|
|
struct ofproto_mcast_snooping_port_settings port_s;
|
|
|
|
|
port_s.flood = smap_get_bool(&port->cfg->other_config,
|
2014-06-18 22:14:35 -03:00
|
|
|
|
"mcast-snooping-flood", false);
|
2014-12-11 09:38:19 -02:00
|
|
|
|
port_s.flood_reports = smap_get_bool(&port->cfg->other_config,
|
|
|
|
|
"mcast-snooping-flood-reports", false);
|
|
|
|
|
if (ofproto_port_set_mcast_snooping(br->ofproto, port, &port_s)) {
|
2014-06-18 22:14:35 -03:00
|
|
|
|
VLOG_ERR("port %s: could not configure mcast snooping",
|
|
|
|
|
port->name);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static void
|
2015-08-28 14:55:11 -07:00
|
|
|
|
find_local_hw_addr(const struct bridge *br, struct eth_addr *ea,
|
2014-02-19 11:59:33 +01:00
|
|
|
|
const struct port *fake_br, struct iface **hw_addr_iface)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2011-11-30 12:09:35 -08:00
|
|
|
|
struct hmapx mirror_output_ports;
|
2011-03-21 10:07:39 -07:00
|
|
|
|
struct port *port;
|
2011-08-26 15:05:53 -07:00
|
|
|
|
bool found_addr = false;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
int error;
|
2011-11-30 12:09:35 -08:00
|
|
|
|
int i;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-11-30 12:09:35 -08:00
|
|
|
|
/* Mirror output ports don't participate in picking the local hardware
|
|
|
|
|
* address. ofproto can't help us find out whether a given port is a
|
|
|
|
|
* mirror output because we haven't configured mirrors yet, so we need to
|
|
|
|
|
* accumulate them ourselves. */
|
|
|
|
|
hmapx_init(&mirror_output_ports);
|
|
|
|
|
for (i = 0; i < br->cfg->n_mirrors; i++) {
|
|
|
|
|
struct ovsrec_mirror *m = br->cfg->mirrors[i];
|
|
|
|
|
if (m->output_port) {
|
|
|
|
|
hmapx_add(&mirror_output_ports, m->output_port);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2009-12-14 13:09:47 -08:00
|
|
|
|
/* Otherwise choose the minimum non-local MAC address among all of the
|
|
|
|
|
* interfaces. */
|
2011-03-21 10:07:39 -07:00
|
|
|
|
HMAP_FOR_EACH (port, hmap_node, &br->ports) {
|
2015-08-28 14:55:11 -07:00
|
|
|
|
struct eth_addr iface_ea;
|
2011-03-21 10:24:32 -07:00
|
|
|
|
struct iface *candidate;
|
2009-07-22 12:21:25 -07:00
|
|
|
|
struct iface *iface;
|
|
|
|
|
|
|
|
|
|
/* Mirror output ports don't participate. */
|
2011-11-30 12:09:35 -08:00
|
|
|
|
if (hmapx_contains(&mirror_output_ports, port->cfg)) {
|
2009-07-08 13:19:16 -07:00
|
|
|
|
continue;
|
|
|
|
|
}
|
2009-07-22 12:21:25 -07:00
|
|
|
|
|
|
|
|
|
/* Choose the MAC address to represent the port. */
|
2011-03-21 10:24:32 -07:00
|
|
|
|
iface = NULL;
|
2015-08-28 14:55:11 -07:00
|
|
|
|
if (port->cfg->mac && eth_addr_from_string(port->cfg->mac,
|
|
|
|
|
&iface_ea)) {
|
2009-08-05 14:50:54 -07:00
|
|
|
|
/* Find the interface with this Ethernet address (if any) so that
|
|
|
|
|
* we can provide the correct devname to the caller. */
|
2011-03-21 10:24:32 -07:00
|
|
|
|
LIST_FOR_EACH (candidate, port_elem, &port->ifaces) {
|
2015-08-28 14:55:11 -07:00
|
|
|
|
struct eth_addr candidate_ea;
|
|
|
|
|
if (!netdev_get_etheraddr(candidate->netdev, &candidate_ea)
|
2009-08-05 14:50:54 -07:00
|
|
|
|
&& eth_addr_equals(iface_ea, candidate_ea)) {
|
|
|
|
|
iface = candidate;
|
|
|
|
|
}
|
|
|
|
|
}
|
2009-07-22 12:21:25 -07:00
|
|
|
|
} else {
|
|
|
|
|
/* Choose the interface whose MAC address will represent the port.
|
|
|
|
|
* The Linux kernel bonding code always chooses the MAC address of
|
|
|
|
|
* the first slave added to a bond, and the Fedora networking
|
|
|
|
|
* scripts always add slaves to a bond in alphabetical order, so
|
|
|
|
|
* for compatibility we choose the interface with the name that is
|
|
|
|
|
* first in alphabetical order. */
|
2011-03-21 10:24:32 -07:00
|
|
|
|
LIST_FOR_EACH (candidate, port_elem, &port->ifaces) {
|
|
|
|
|
if (!iface || strcmp(candidate->name, iface->name) < 0) {
|
2009-07-22 12:21:25 -07:00
|
|
|
|
iface = candidate;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2016-07-02 21:16:55 -07:00
|
|
|
|
/* A port always has at least one interface. */
|
|
|
|
|
ovs_assert(iface != NULL);
|
|
|
|
|
|
2009-07-22 12:21:25 -07:00
|
|
|
|
/* The local port doesn't count (since we're trying to choose its
|
2009-12-14 13:09:47 -08:00
|
|
|
|
* MAC address anyway). */
|
2011-05-09 09:24:39 -07:00
|
|
|
|
if (iface->ofp_port == OFPP_LOCAL) {
|
2009-07-08 13:19:16 -07:00
|
|
|
|
continue;
|
|
|
|
|
}
|
2009-07-22 12:21:25 -07:00
|
|
|
|
|
2014-02-19 11:59:33 +01:00
|
|
|
|
/* For fake bridges we only choose from ports with the same tag */
|
|
|
|
|
if (fake_br && fake_br->cfg && fake_br->cfg->tag) {
|
|
|
|
|
if (!port->cfg->tag) {
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
if (*port->cfg->tag != *fake_br->cfg->tag) {
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2009-07-22 12:21:25 -07:00
|
|
|
|
/* Grab MAC. */
|
2015-08-28 14:55:11 -07:00
|
|
|
|
error = netdev_get_etheraddr(iface->netdev, &iface_ea);
|
2009-07-22 12:21:25 -07:00
|
|
|
|
if (error) {
|
|
|
|
|
continue;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
2009-07-22 12:21:25 -07:00
|
|
|
|
|
|
|
|
|
/* Compare against our current choice. */
|
|
|
|
|
if (!eth_addr_is_multicast(iface_ea) &&
|
2009-12-14 13:09:47 -08:00
|
|
|
|
!eth_addr_is_local(iface_ea) &&
|
2009-07-22 12:21:25 -07:00
|
|
|
|
!eth_addr_is_reserved(iface_ea) &&
|
|
|
|
|
!eth_addr_is_zero(iface_ea) &&
|
2015-08-28 14:55:11 -07:00
|
|
|
|
(!found_addr || eth_addr_compare_3way(iface_ea, *ea) < 0))
|
2009-07-22 12:21:25 -07:00
|
|
|
|
{
|
2015-08-28 14:55:11 -07:00
|
|
|
|
*ea = iface_ea;
|
2009-08-19 13:03:46 -07:00
|
|
|
|
*hw_addr_iface = iface;
|
2011-08-26 15:05:53 -07:00
|
|
|
|
found_addr = true;
|
2009-07-22 12:21:25 -07:00
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2011-11-30 12:09:35 -08:00
|
|
|
|
|
2012-12-03 19:05:08 -08:00
|
|
|
|
if (!found_addr) {
|
2015-08-28 14:55:11 -07:00
|
|
|
|
*ea = br->default_ea;
|
2012-12-03 19:05:08 -08:00
|
|
|
|
*hw_addr_iface = NULL;
|
|
|
|
|
}
|
|
|
|
|
|
2011-11-30 12:09:35 -08:00
|
|
|
|
hmapx_destroy(&mirror_output_ports);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2014-02-19 11:59:32 +01:00
|
|
|
|
static void
|
2015-08-28 14:55:11 -07:00
|
|
|
|
bridge_pick_local_hw_addr(struct bridge *br, struct eth_addr *ea,
|
2014-02-19 11:59:32 +01:00
|
|
|
|
struct iface **hw_addr_iface)
|
|
|
|
|
{
|
|
|
|
|
*hw_addr_iface = NULL;
|
|
|
|
|
|
|
|
|
|
/* Did the user request a particular MAC? */
|
2016-07-20 16:44:09 -07:00
|
|
|
|
const char *hwaddr = smap_get_def(&br->cfg->other_config, "hwaddr", "");
|
|
|
|
|
if (eth_addr_from_string(hwaddr, ea)) {
|
2015-08-28 14:55:11 -07:00
|
|
|
|
if (eth_addr_is_multicast(*ea)) {
|
2014-02-19 11:59:32 +01:00
|
|
|
|
VLOG_ERR("bridge %s: cannot set MAC address to multicast "
|
2015-08-28 14:55:11 -07:00
|
|
|
|
"address "ETH_ADDR_FMT, br->name, ETH_ADDR_ARGS(*ea));
|
|
|
|
|
} else if (eth_addr_is_zero(*ea)) {
|
2014-02-19 11:59:32 +01:00
|
|
|
|
VLOG_ERR("bridge %s: cannot set MAC address to zero", br->name);
|
|
|
|
|
} else {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Find a local hw address */
|
2014-02-19 11:59:33 +01:00
|
|
|
|
find_local_hw_addr(br, ea, NULL, hw_addr_iface);
|
2014-02-19 11:59:32 +01:00
|
|
|
|
}
|
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
/* Choose and returns the datapath ID for bridge 'br' given that the bridge
|
|
|
|
|
* Ethernet address is 'bridge_ea'. If 'bridge_ea' is the Ethernet address of
|
2009-07-23 14:50:55 -07:00
|
|
|
|
* an interface on 'br', then that interface must be passed in as
|
|
|
|
|
* 'hw_addr_iface'; if 'bridge_ea' was derived some other way, then
|
|
|
|
|
* 'hw_addr_iface' must be passed in as a null pointer. */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static uint64_t
|
|
|
|
|
bridge_pick_datapath_id(struct bridge *br,
|
2015-08-28 14:55:11 -07:00
|
|
|
|
const struct eth_addr bridge_ea,
|
2009-07-23 14:50:55 -07:00
|
|
|
|
struct iface *hw_addr_iface)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
|
|
|
|
/*
|
|
|
|
|
* The procedure for choosing a bridge MAC address will, in the most
|
|
|
|
|
* ordinary case, also choose a unique MAC that we can use as a datapath
|
|
|
|
|
* ID. In some special cases, though, multiple bridges will end up with
|
|
|
|
|
* the same MAC address. This is OK for the bridges, but it will confuse
|
|
|
|
|
* the OpenFlow controller, because each datapath needs a unique datapath
|
|
|
|
|
* ID.
|
|
|
|
|
*
|
|
|
|
|
* Datapath IDs must be unique. It is also very desirable that they be
|
|
|
|
|
* stable from one run to the next, so that policy set on a datapath
|
|
|
|
|
* "sticks".
|
|
|
|
|
*/
|
2009-12-11 17:03:35 -08:00
|
|
|
|
const char *datapath_id;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
uint64_t dpid;
|
|
|
|
|
|
2016-07-20 16:44:09 -07:00
|
|
|
|
datapath_id = smap_get_def(&br->cfg->other_config, "datapath-id", "");
|
|
|
|
|
if (dpid_from_string(datapath_id, &dpid)) {
|
2009-07-08 13:19:16 -07:00
|
|
|
|
return dpid;
|
|
|
|
|
}
|
|
|
|
|
|
2011-11-08 13:53:38 -08:00
|
|
|
|
if (!hw_addr_iface) {
|
2009-07-08 13:19:16 -07:00
|
|
|
|
/*
|
|
|
|
|
* A purely internal bridge, that is, one that has no non-virtual
|
2011-11-08 13:53:38 -08:00
|
|
|
|
* network devices on it at all, is difficult because it has no
|
2009-07-08 13:19:16 -07:00
|
|
|
|
* natural unique identifier at all.
|
|
|
|
|
*
|
|
|
|
|
* When the host is a XenServer, we handle this case by hashing the
|
|
|
|
|
* host's UUID with the name of the bridge. Names of bridges are
|
|
|
|
|
* persistent across XenServer reboots, although they can be reused if
|
|
|
|
|
* an internal network is destroyed and then a new one is later
|
|
|
|
|
* created, so this is fairly effective.
|
|
|
|
|
*
|
|
|
|
|
* When the host is not a XenServer, we punt by using a random MAC
|
|
|
|
|
* address on each run.
|
|
|
|
|
*/
|
|
|
|
|
const char *host_uuid = xenserver_get_host_uuid();
|
|
|
|
|
if (host_uuid) {
|
|
|
|
|
char *combined = xasprintf("%s,%s", host_uuid, br->name);
|
|
|
|
|
dpid = dpid_from_hash(combined, strlen(combined));
|
|
|
|
|
free(combined);
|
|
|
|
|
return dpid;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return eth_addr_to_uint64(bridge_ea);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static uint64_t
|
|
|
|
|
dpid_from_hash(const void *data, size_t n)
|
|
|
|
|
{
|
2015-08-28 14:55:11 -07:00
|
|
|
|
union {
|
|
|
|
|
uint8_t bytes[SHA1_DIGEST_SIZE];
|
|
|
|
|
struct eth_addr ea;
|
|
|
|
|
} hash;
|
|
|
|
|
|
|
|
|
|
sha1_bytes(data, n, hash.bytes);
|
|
|
|
|
eth_addr_mark_random(&hash.ea);
|
|
|
|
|
return eth_addr_to_uint64(hash.ea);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2010-12-21 16:26:21 -08:00
|
|
|
|
static void
|
2014-04-03 13:12:35 -07:00
|
|
|
|
iface_refresh_netdev_status(struct iface *iface)
|
2010-12-21 16:26:21 -08:00
|
|
|
|
{
|
2012-05-22 03:47:36 -07:00
|
|
|
|
struct smap smap;
|
2011-01-05 11:51:15 -08:00
|
|
|
|
|
2012-02-15 14:23:38 -08:00
|
|
|
|
enum netdev_features current;
|
2014-04-03 13:12:35 -07:00
|
|
|
|
enum netdev_flags flags;
|
|
|
|
|
const char *link_state;
|
2015-08-28 14:55:11 -07:00
|
|
|
|
struct eth_addr mac;
|
2014-04-03 13:12:35 -07:00
|
|
|
|
int64_t bps, mtu_64, ifindex64, link_resets;
|
|
|
|
|
int mtu, error;
|
2011-01-17 15:37:13 -08:00
|
|
|
|
|
2011-04-13 11:10:44 -07:00
|
|
|
|
if (iface_is_synthetic(iface)) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2014-05-30 10:19:26 -07:00
|
|
|
|
if (iface->change_seq == netdev_get_change_seq(iface->netdev)
|
|
|
|
|
&& !status_txn_try_again) {
|
2014-04-03 13:12:35 -07:00
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
iface->change_seq = netdev_get_change_seq(iface->netdev);
|
|
|
|
|
|
2012-05-22 03:47:36 -07:00
|
|
|
|
smap_init(&smap);
|
2011-01-05 11:51:15 -08:00
|
|
|
|
|
2012-12-16 16:42:17 -08:00
|
|
|
|
if (!netdev_get_status(iface->netdev, &smap)) {
|
2012-05-22 01:53:07 -07:00
|
|
|
|
ovsrec_interface_set_status(iface->cfg, &smap);
|
2011-01-05 11:51:15 -08:00
|
|
|
|
} else {
|
2012-05-22 01:53:07 -07:00
|
|
|
|
ovsrec_interface_set_status(iface->cfg, NULL);
|
2011-01-05 11:51:15 -08:00
|
|
|
|
}
|
|
|
|
|
|
2012-05-22 03:47:36 -07:00
|
|
|
|
smap_destroy(&smap);
|
2011-01-17 15:37:13 -08:00
|
|
|
|
|
2014-04-03 13:12:35 -07:00
|
|
|
|
error = netdev_get_flags(iface->netdev, &flags);
|
|
|
|
|
if (!error) {
|
|
|
|
|
const char *state = flags & NETDEV_UP ? "up" : "down";
|
|
|
|
|
|
|
|
|
|
ovsrec_interface_set_admin_state(iface->cfg, state);
|
|
|
|
|
} else {
|
|
|
|
|
ovsrec_interface_set_admin_state(iface->cfg, NULL);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
link_state = netdev_get_carrier(iface->netdev) ? "up" : "down";
|
|
|
|
|
ovsrec_interface_set_link_state(iface->cfg, link_state);
|
|
|
|
|
|
|
|
|
|
link_resets = netdev_get_carrier_resets(iface->netdev);
|
|
|
|
|
ovsrec_interface_set_link_resets(iface->cfg, &link_resets, 1);
|
|
|
|
|
|
2011-01-17 15:37:13 -08:00
|
|
|
|
error = netdev_get_features(iface->netdev, ¤t, NULL, NULL, NULL);
|
2012-11-03 18:00:39 -07:00
|
|
|
|
bps = !error ? netdev_features_to_bps(current, 0) : 0;
|
|
|
|
|
if (bps) {
|
2011-01-17 15:37:13 -08:00
|
|
|
|
ovsrec_interface_set_duplex(iface->cfg,
|
|
|
|
|
netdev_features_is_full_duplex(current)
|
|
|
|
|
? "full" : "half");
|
|
|
|
|
ovsrec_interface_set_link_speed(iface->cfg, &bps, 1);
|
2013-03-05 16:25:32 -08:00
|
|
|
|
} else {
|
2011-01-17 15:37:13 -08:00
|
|
|
|
ovsrec_interface_set_duplex(iface->cfg, NULL);
|
|
|
|
|
ovsrec_interface_set_link_speed(iface->cfg, NULL, 0);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
error = netdev_get_mtu(iface->netdev, &mtu);
|
2011-09-12 17:12:52 -07:00
|
|
|
|
if (!error) {
|
2011-01-17 15:37:13 -08:00
|
|
|
|
mtu_64 = mtu;
|
|
|
|
|
ovsrec_interface_set_mtu(iface->cfg, &mtu_64, 1);
|
2013-03-12 14:54:37 -07:00
|
|
|
|
} else {
|
2011-01-17 15:37:13 -08:00
|
|
|
|
ovsrec_interface_set_mtu(iface->cfg, NULL, 0);
|
|
|
|
|
}
|
2013-03-12 14:47:22 -07:00
|
|
|
|
|
2015-08-28 14:55:11 -07:00
|
|
|
|
error = netdev_get_etheraddr(iface->netdev, &mac);
|
2013-03-12 14:47:22 -07:00
|
|
|
|
if (!error) {
|
2015-12-07 15:00:16 -08:00
|
|
|
|
char mac_string[ETH_ADDR_STRLEN + 1];
|
2013-03-12 14:47:22 -07:00
|
|
|
|
|
2015-12-07 15:00:16 -08:00
|
|
|
|
snprintf(mac_string, sizeof mac_string,
|
|
|
|
|
ETH_ADDR_FMT, ETH_ADDR_ARGS(mac));
|
2013-03-12 14:47:22 -07:00
|
|
|
|
ovsrec_interface_set_mac_in_use(iface->cfg, mac_string);
|
|
|
|
|
} else {
|
|
|
|
|
ovsrec_interface_set_mac_in_use(iface->cfg, NULL);
|
|
|
|
|
}
|
2013-07-08 13:36:06 -07:00
|
|
|
|
|
|
|
|
|
/* The netdev may return a negative number (such as -EOPNOTSUPP)
|
|
|
|
|
* if there is no valid ifindex number. */
|
|
|
|
|
ifindex64 = netdev_get_ifindex(iface->netdev);
|
|
|
|
|
if (ifindex64 < 0) {
|
|
|
|
|
ifindex64 = 0;
|
|
|
|
|
}
|
|
|
|
|
ovsrec_interface_set_ifindex(iface->cfg, &ifindex64, 1);
|
2010-12-21 16:26:21 -08:00
|
|
|
|
}
|
|
|
|
|
|
2014-04-03 13:12:35 -07:00
|
|
|
|
static void
|
|
|
|
|
iface_refresh_ofproto_status(struct iface *iface)
|
|
|
|
|
{
|
2014-05-30 15:07:31 -07:00
|
|
|
|
int current;
|
2019-03-22 15:58:39 +03:00
|
|
|
|
int error;
|
|
|
|
|
char *errp = NULL;
|
2014-04-03 13:12:35 -07:00
|
|
|
|
|
|
|
|
|
if (iface_is_synthetic(iface)) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2019-03-22 15:58:39 +03:00
|
|
|
|
error = ofproto_vport_get_status(iface->port->bridge->ofproto,
|
|
|
|
|
iface->ofp_port, &errp);
|
|
|
|
|
if (error && error != EOPNOTSUPP) {
|
|
|
|
|
/* Need to verify to avoid race with transaction from
|
|
|
|
|
* 'bridge_reconfigure' that clears errors explicitly. */
|
|
|
|
|
ovsrec_interface_verify_error(iface->cfg);
|
|
|
|
|
ovsrec_interface_set_error(iface->cfg,
|
|
|
|
|
errp ? errp : ovs_strerror(error));
|
|
|
|
|
free(errp);
|
|
|
|
|
}
|
|
|
|
|
|
2014-04-03 13:12:35 -07:00
|
|
|
|
current = ofproto_port_is_lacp_current(iface->port->bridge->ofproto,
|
|
|
|
|
iface->ofp_port);
|
|
|
|
|
if (current >= 0) {
|
|
|
|
|
bool bl = current;
|
|
|
|
|
ovsrec_interface_set_lacp_current(iface->cfg, &bl, 1);
|
|
|
|
|
} else {
|
|
|
|
|
ovsrec_interface_set_lacp_current(iface->cfg, NULL, 0);
|
|
|
|
|
}
|
|
|
|
|
|
2014-05-30 15:07:31 -07:00
|
|
|
|
if (ofproto_port_cfm_status_changed(iface->port->bridge->ofproto,
|
2014-05-30 10:19:26 -07:00
|
|
|
|
iface->ofp_port)
|
|
|
|
|
|| status_txn_try_again) {
|
2014-05-30 15:07:31 -07:00
|
|
|
|
iface_refresh_cfm_stats(iface);
|
|
|
|
|
}
|
2014-04-03 13:12:35 -07:00
|
|
|
|
|
2014-05-30 15:07:31 -07:00
|
|
|
|
if (ofproto_port_bfd_status_changed(iface->port->bridge->ofproto,
|
2014-05-30 10:19:26 -07:00
|
|
|
|
iface->ofp_port)
|
|
|
|
|
|| status_txn_try_again) {
|
2014-05-30 15:07:31 -07:00
|
|
|
|
struct smap smap;
|
|
|
|
|
|
|
|
|
|
smap_init(&smap);
|
|
|
|
|
ofproto_port_get_bfd_status(iface->port->bridge->ofproto,
|
|
|
|
|
iface->ofp_port, &smap);
|
2014-04-03 13:12:35 -07:00
|
|
|
|
ovsrec_interface_set_bfd_status(iface->cfg, &smap);
|
2014-05-30 15:07:31 -07:00
|
|
|
|
smap_destroy(&smap);
|
2014-04-03 13:12:35 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2012-08-14 14:08:09 -07:00
|
|
|
|
/* Writes 'iface''s CFM statistics to the database. 'iface' must not be
|
|
|
|
|
* synthetic. */
|
2011-09-08 16:15:36 -07:00
|
|
|
|
static void
|
2010-11-15 16:20:01 -08:00
|
|
|
|
iface_refresh_cfm_stats(struct iface *iface)
|
|
|
|
|
{
|
2011-05-12 15:28:43 -07:00
|
|
|
|
const struct ovsrec_interface *cfg = iface->cfg;
|
2014-06-09 18:35:35 -07:00
|
|
|
|
struct cfm_status status;
|
2014-04-03 10:20:44 -07:00
|
|
|
|
int error;
|
2013-03-06 09:25:40 -08:00
|
|
|
|
|
2014-04-03 10:20:44 -07:00
|
|
|
|
error = ofproto_port_get_cfm_status(iface->port->bridge->ofproto,
|
|
|
|
|
iface->ofp_port, &status);
|
2014-05-30 15:07:31 -07:00
|
|
|
|
if (error > 0) {
|
2013-03-06 09:25:40 -08:00
|
|
|
|
ovsrec_interface_set_cfm_fault(cfg, NULL, 0);
|
|
|
|
|
ovsrec_interface_set_cfm_fault_status(cfg, NULL, 0);
|
|
|
|
|
ovsrec_interface_set_cfm_remote_opstate(cfg, NULL);
|
2013-10-22 05:16:23 +00:00
|
|
|
|
ovsrec_interface_set_cfm_flap_count(cfg, NULL, 0);
|
2013-03-06 09:25:40 -08:00
|
|
|
|
ovsrec_interface_set_cfm_health(cfg, NULL, 0);
|
|
|
|
|
ovsrec_interface_set_cfm_remote_mpids(cfg, NULL, 0);
|
|
|
|
|
} else {
|
2012-02-07 14:35:09 -08:00
|
|
|
|
const char *reasons[CFM_FAULT_N_REASONS];
|
2013-03-06 09:25:40 -08:00
|
|
|
|
int64_t cfm_health = status.health;
|
2013-10-22 05:16:23 +00:00
|
|
|
|
int64_t cfm_flap_count = status.flap_count;
|
2013-03-06 09:25:40 -08:00
|
|
|
|
bool faulted = status.faults != 0;
|
2012-02-07 14:35:09 -08:00
|
|
|
|
size_t i, j;
|
|
|
|
|
|
2013-03-06 09:25:40 -08:00
|
|
|
|
ovsrec_interface_set_cfm_fault(cfg, &faulted, 1);
|
|
|
|
|
|
2012-02-07 14:35:09 -08:00
|
|
|
|
j = 0;
|
|
|
|
|
for (i = 0; i < CFM_FAULT_N_REASONS; i++) {
|
|
|
|
|
int reason = 1 << i;
|
2013-03-06 09:25:40 -08:00
|
|
|
|
if (status.faults & reason) {
|
2012-02-07 14:35:09 -08:00
|
|
|
|
reasons[j++] = cfm_fault_reason_to_str(reason);
|
|
|
|
|
}
|
|
|
|
|
}
|
2015-02-19 13:10:51 -05:00
|
|
|
|
ovsrec_interface_set_cfm_fault_status(cfg, reasons, j);
|
2012-08-10 16:14:45 -07:00
|
|
|
|
|
2013-10-22 05:16:23 +00:00
|
|
|
|
ovsrec_interface_set_cfm_flap_count(cfg, &cfm_flap_count, 1);
|
|
|
|
|
|
2013-03-06 14:47:11 -08:00
|
|
|
|
if (status.remote_opstate >= 0) {
|
|
|
|
|
const char *remote_opstate = status.remote_opstate ? "up" : "down";
|
|
|
|
|
ovsrec_interface_set_cfm_remote_opstate(cfg, remote_opstate);
|
|
|
|
|
} else {
|
|
|
|
|
ovsrec_interface_set_cfm_remote_opstate(cfg, NULL);
|
|
|
|
|
}
|
|
|
|
|
|
2013-03-06 09:25:40 -08:00
|
|
|
|
ovsrec_interface_set_cfm_remote_mpids(cfg,
|
|
|
|
|
(const int64_t *)status.rmps,
|
|
|
|
|
status.n_rmps);
|
2013-03-06 14:50:26 -08:00
|
|
|
|
if (cfm_health >= 0) {
|
|
|
|
|
ovsrec_interface_set_cfm_health(cfg, &cfm_health, 1);
|
|
|
|
|
} else {
|
|
|
|
|
ovsrec_interface_set_cfm_health(cfg, NULL, 0);
|
|
|
|
|
}
|
2013-07-23 13:09:38 -07:00
|
|
|
|
|
|
|
|
|
free(status.rmps);
|
2012-04-05 14:30:23 -07:00
|
|
|
|
}
|
2010-11-15 16:20:01 -08:00
|
|
|
|
}
|
|
|
|
|
|
2010-06-23 11:02:46 -07:00
|
|
|
|
static void
|
|
|
|
|
iface_refresh_stats(struct iface *iface)
|
|
|
|
|
{
|
2018-01-09 07:55:37 +00:00
|
|
|
|
struct netdev_custom_stats custom_stats;
|
|
|
|
|
struct netdev_stats stats;
|
|
|
|
|
int n;
|
|
|
|
|
uint32_t i, counters_size;
|
|
|
|
|
|
2011-05-24 11:02:31 -07:00
|
|
|
|
#define IFACE_STATS \
|
2016-05-05 09:46:01 +01:00
|
|
|
|
IFACE_STAT(rx_packets, "rx_packets") \
|
|
|
|
|
IFACE_STAT(tx_packets, "tx_packets") \
|
|
|
|
|
IFACE_STAT(rx_bytes, "rx_bytes") \
|
|
|
|
|
IFACE_STAT(tx_bytes, "tx_bytes") \
|
|
|
|
|
IFACE_STAT(rx_dropped, "rx_dropped") \
|
|
|
|
|
IFACE_STAT(tx_dropped, "tx_dropped") \
|
|
|
|
|
IFACE_STAT(rx_errors, "rx_errors") \
|
|
|
|
|
IFACE_STAT(tx_errors, "tx_errors") \
|
|
|
|
|
IFACE_STAT(rx_frame_errors, "rx_frame_err") \
|
|
|
|
|
IFACE_STAT(rx_over_errors, "rx_over_err") \
|
|
|
|
|
IFACE_STAT(rx_crc_errors, "rx_crc_err") \
|
2019-09-03 19:28:26 +08:00
|
|
|
|
IFACE_STAT(rx_missed_errors, "rx_missed_errors") \
|
2016-05-05 09:46:01 +01:00
|
|
|
|
IFACE_STAT(collisions, "collisions") \
|
|
|
|
|
IFACE_STAT(rx_1_to_64_packets, "rx_1_to_64_packets") \
|
|
|
|
|
IFACE_STAT(rx_65_to_127_packets, "rx_65_to_127_packets") \
|
|
|
|
|
IFACE_STAT(rx_128_to_255_packets, "rx_128_to_255_packets") \
|
|
|
|
|
IFACE_STAT(rx_256_to_511_packets, "rx_256_to_511_packets") \
|
|
|
|
|
IFACE_STAT(rx_512_to_1023_packets, "rx_512_to_1023_packets") \
|
2017-06-26 10:30:55 +00:00
|
|
|
|
IFACE_STAT(rx_1024_to_1522_packets, "rx_1024_to_1522_packets") \
|
2016-05-05 09:46:01 +01:00
|
|
|
|
IFACE_STAT(rx_1523_to_max_packets, "rx_1523_to_max_packets") \
|
|
|
|
|
IFACE_STAT(tx_1_to_64_packets, "tx_1_to_64_packets") \
|
|
|
|
|
IFACE_STAT(tx_65_to_127_packets, "tx_65_to_127_packets") \
|
|
|
|
|
IFACE_STAT(tx_128_to_255_packets, "tx_128_to_255_packets") \
|
|
|
|
|
IFACE_STAT(tx_256_to_511_packets, "tx_256_to_511_packets") \
|
|
|
|
|
IFACE_STAT(tx_512_to_1023_packets, "tx_512_to_1023_packets") \
|
2017-06-26 10:30:55 +00:00
|
|
|
|
IFACE_STAT(tx_1024_to_1522_packets, "tx_1024_to_1522_packets") \
|
2016-05-05 09:46:01 +01:00
|
|
|
|
IFACE_STAT(tx_1523_to_max_packets, "tx_1523_to_max_packets") \
|
|
|
|
|
IFACE_STAT(tx_multicast_packets, "tx_multicast_packets") \
|
|
|
|
|
IFACE_STAT(rx_broadcast_packets, "rx_broadcast_packets") \
|
|
|
|
|
IFACE_STAT(tx_broadcast_packets, "tx_broadcast_packets") \
|
|
|
|
|
IFACE_STAT(rx_undersized_errors, "rx_undersized_errors") \
|
|
|
|
|
IFACE_STAT(rx_oversize_errors, "rx_oversize_errors") \
|
|
|
|
|
IFACE_STAT(rx_fragmented_errors, "rx_fragmented_errors") \
|
|
|
|
|
IFACE_STAT(rx_jabber_errors, "rx_jabber_errors")
|
2011-05-24 11:02:31 -07:00
|
|
|
|
|
2013-05-03 15:36:56 -07:00
|
|
|
|
#define IFACE_STAT(MEMBER, NAME) + 1
|
|
|
|
|
enum { N_IFACE_STATS = IFACE_STATS };
|
2011-05-24 11:02:31 -07:00
|
|
|
|
#undef IFACE_STAT
|
2010-06-23 11:02:46 -07:00
|
|
|
|
|
2011-04-13 11:10:44 -07:00
|
|
|
|
if (iface_is_synthetic(iface)) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2018-01-09 07:55:37 +00:00
|
|
|
|
netdev_get_custom_stats(iface->netdev, &custom_stats);
|
|
|
|
|
|
|
|
|
|
counters_size = custom_stats.size + N_IFACE_STATS;
|
|
|
|
|
int64_t *values = xmalloc(counters_size * sizeof(int64_t));
|
|
|
|
|
const char **keys = xmalloc(counters_size * sizeof(char *));
|
|
|
|
|
|
2010-06-23 11:02:46 -07:00
|
|
|
|
/* Intentionally ignore return value, since errors will set 'stats' to
|
|
|
|
|
* all-1s, and we will deal with that correctly below. */
|
|
|
|
|
netdev_get_stats(iface->netdev, &stats);
|
|
|
|
|
|
2013-05-03 15:36:56 -07:00
|
|
|
|
/* Copy statistics into keys[] and values[]. */
|
|
|
|
|
n = 0;
|
|
|
|
|
#define IFACE_STAT(MEMBER, NAME) \
|
|
|
|
|
if (stats.MEMBER != UINT64_MAX) { \
|
|
|
|
|
keys[n] = NAME; \
|
|
|
|
|
values[n] = stats.MEMBER; \
|
|
|
|
|
n++; \
|
|
|
|
|
}
|
2011-05-24 11:02:31 -07:00
|
|
|
|
IFACE_STATS;
|
|
|
|
|
#undef IFACE_STAT
|
2018-01-09 07:55:37 +00:00
|
|
|
|
|
|
|
|
|
/* Copy custom statistics into keys[] and values[]. */
|
|
|
|
|
if (custom_stats.size && custom_stats.counters) {
|
|
|
|
|
for (i = 0 ; i < custom_stats.size ; i++) {
|
|
|
|
|
values[n] = custom_stats.counters[i].value;
|
|
|
|
|
keys[n] = custom_stats.counters[i].name;
|
|
|
|
|
n++;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
ovs_assert(n <= counters_size);
|
2010-06-23 11:02:46 -07:00
|
|
|
|
|
2013-05-03 15:36:56 -07:00
|
|
|
|
ovsrec_interface_set_statistics(iface->cfg, keys, values, n);
|
2011-05-24 11:02:31 -07:00
|
|
|
|
#undef IFACE_STATS
|
2018-01-09 07:55:37 +00:00
|
|
|
|
|
|
|
|
|
free(values);
|
|
|
|
|
free(keys);
|
2018-01-23 08:55:06 +03:00
|
|
|
|
netdev_free_custom_stats_counters(&custom_stats);
|
2010-06-23 11:02:46 -07:00
|
|
|
|
}
|
|
|
|
|
|
2014-10-16 15:23:11 -07:00
|
|
|
|
static void
|
|
|
|
|
br_refresh_datapath_info(struct bridge *br)
|
|
|
|
|
{
|
|
|
|
|
const char *version;
|
|
|
|
|
|
|
|
|
|
version = (br->ofproto && br->ofproto->ofproto_class->get_datapath_version
|
|
|
|
|
? br->ofproto->ofproto_class->get_datapath_version(br->ofproto)
|
|
|
|
|
: NULL);
|
|
|
|
|
|
|
|
|
|
ovsrec_bridge_set_datapath_version(br->cfg,
|
|
|
|
|
version ? version : "<unknown>");
|
|
|
|
|
}
|
|
|
|
|
|
2011-10-14 09:48:17 -07:00
|
|
|
|
static void
|
|
|
|
|
br_refresh_stp_status(struct bridge *br)
|
|
|
|
|
{
|
2012-05-22 01:53:07 -07:00
|
|
|
|
struct smap smap = SMAP_INITIALIZER(&smap);
|
2011-10-14 09:48:17 -07:00
|
|
|
|
struct ofproto *ofproto = br->ofproto;
|
|
|
|
|
struct ofproto_stp_status status;
|
|
|
|
|
|
|
|
|
|
if (ofproto_get_stp_status(ofproto, &status)) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (!status.enabled) {
|
2012-05-22 01:53:07 -07:00
|
|
|
|
ovsrec_bridge_set_status(br->cfg, NULL);
|
2011-10-14 09:48:17 -07:00
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2012-05-22 01:53:07 -07:00
|
|
|
|
smap_add_format(&smap, "stp_bridge_id", STP_ID_FMT,
|
|
|
|
|
STP_ID_ARGS(status.bridge_id));
|
|
|
|
|
smap_add_format(&smap, "stp_designated_root", STP_ID_FMT,
|
|
|
|
|
STP_ID_ARGS(status.designated_root));
|
|
|
|
|
smap_add_format(&smap, "stp_root_path_cost", "%d", status.root_path_cost);
|
2011-10-14 09:48:17 -07:00
|
|
|
|
|
2012-05-22 01:53:07 -07:00
|
|
|
|
ovsrec_bridge_set_status(br->cfg, &smap);
|
|
|
|
|
smap_destroy(&smap);
|
2011-10-14 09:48:17 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
port_refresh_stp_status(struct port *port)
|
|
|
|
|
{
|
|
|
|
|
struct ofproto *ofproto = port->bridge->ofproto;
|
|
|
|
|
struct iface *iface;
|
|
|
|
|
struct ofproto_port_stp_status status;
|
2012-05-22 01:53:07 -07:00
|
|
|
|
struct smap smap;
|
2011-10-14 09:48:17 -07:00
|
|
|
|
|
2011-10-26 11:39:46 -07:00
|
|
|
|
if (port_is_synthetic(port)) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2011-10-14 09:48:17 -07:00
|
|
|
|
/* STP doesn't currently support bonds. */
|
2016-03-25 14:10:22 -07:00
|
|
|
|
if (!ovs_list_is_singleton(&port->ifaces)) {
|
2012-05-22 01:53:07 -07:00
|
|
|
|
ovsrec_port_set_status(port->cfg, NULL);
|
2011-10-14 09:48:17 -07:00
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2016-03-25 14:10:22 -07:00
|
|
|
|
iface = CONTAINER_OF(ovs_list_front(&port->ifaces), struct iface, port_elem);
|
2011-10-14 09:48:17 -07:00
|
|
|
|
if (ofproto_port_get_stp_status(ofproto, iface->ofp_port, &status)) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (!status.enabled) {
|
2012-05-22 01:53:07 -07:00
|
|
|
|
ovsrec_port_set_status(port->cfg, NULL);
|
2011-10-14 09:48:17 -07:00
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2011-11-14 15:04:14 -08:00
|
|
|
|
/* Set Status column. */
|
2012-05-22 01:53:07 -07:00
|
|
|
|
smap_init(&smap);
|
2017-03-17 13:38:55 -07:00
|
|
|
|
smap_add_format(&smap, "stp_port_id", "%d", status.port_id);
|
2012-05-22 01:53:07 -07:00
|
|
|
|
smap_add(&smap, "stp_state", stp_state_name(status.state));
|
|
|
|
|
smap_add_format(&smap, "stp_sec_in_state", "%u", status.sec_in_state);
|
|
|
|
|
smap_add(&smap, "stp_role", stp_role_name(status.role));
|
|
|
|
|
ovsrec_port_set_status(port->cfg, &smap);
|
|
|
|
|
smap_destroy(&smap);
|
2013-11-26 05:44:18 +00:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
port_refresh_stp_stats(struct port *port)
|
|
|
|
|
{
|
|
|
|
|
struct ofproto *ofproto = port->bridge->ofproto;
|
|
|
|
|
struct iface *iface;
|
|
|
|
|
struct ofproto_port_stp_stats stats;
|
2015-02-19 13:10:51 -05:00
|
|
|
|
const char *keys[3];
|
2013-11-26 05:44:18 +00:00
|
|
|
|
int64_t int_values[3];
|
|
|
|
|
|
|
|
|
|
if (port_is_synthetic(port)) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* STP doesn't currently support bonds. */
|
2016-03-25 14:10:22 -07:00
|
|
|
|
if (!ovs_list_is_singleton(&port->ifaces)) {
|
2013-11-26 05:44:18 +00:00
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2016-03-25 14:10:22 -07:00
|
|
|
|
iface = CONTAINER_OF(ovs_list_front(&port->ifaces), struct iface, port_elem);
|
2013-11-26 05:44:18 +00:00
|
|
|
|
if (ofproto_port_get_stp_stats(ofproto, iface->ofp_port, &stats)) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (!stats.enabled) {
|
|
|
|
|
ovsrec_port_set_statistics(port->cfg, NULL, NULL, 0);
|
|
|
|
|
return;
|
|
|
|
|
}
|
2011-11-14 15:04:14 -08:00
|
|
|
|
|
|
|
|
|
/* Set Statistics column. */
|
|
|
|
|
keys[0] = "stp_tx_count";
|
2013-11-26 05:44:18 +00:00
|
|
|
|
int_values[0] = stats.tx_count;
|
2011-11-14 15:04:14 -08:00
|
|
|
|
keys[1] = "stp_rx_count";
|
2013-11-26 05:44:18 +00:00
|
|
|
|
int_values[1] = stats.rx_count;
|
2011-11-14 15:04:14 -08:00
|
|
|
|
keys[2] = "stp_error_count";
|
2013-11-26 05:44:18 +00:00
|
|
|
|
int_values[2] = stats.error_count;
|
2011-11-14 15:04:14 -08:00
|
|
|
|
|
|
|
|
|
ovsrec_port_set_statistics(port->cfg, keys, int_values,
|
|
|
|
|
ARRAY_SIZE(int_values));
|
2011-10-14 09:48:17 -07:00
|
|
|
|
}
|
|
|
|
|
|
2014-08-22 09:01:34 -07:00
|
|
|
|
static void
|
|
|
|
|
br_refresh_rstp_status(struct bridge *br)
|
|
|
|
|
{
|
|
|
|
|
struct smap smap = SMAP_INITIALIZER(&smap);
|
|
|
|
|
struct ofproto *ofproto = br->ofproto;
|
|
|
|
|
struct ofproto_rstp_status status;
|
|
|
|
|
|
|
|
|
|
if (ofproto_get_rstp_status(ofproto, &status)) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
if (!status.enabled) {
|
|
|
|
|
ovsrec_bridge_set_rstp_status(br->cfg, NULL);
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
smap_add_format(&smap, "rstp_bridge_id", RSTP_ID_FMT,
|
|
|
|
|
RSTP_ID_ARGS(status.bridge_id));
|
2014-11-13 14:55:25 -08:00
|
|
|
|
smap_add_format(&smap, "rstp_root_path_cost", "%"PRIu32,
|
2014-08-22 09:01:34 -07:00
|
|
|
|
status.root_path_cost);
|
|
|
|
|
smap_add_format(&smap, "rstp_root_id", RSTP_ID_FMT,
|
|
|
|
|
RSTP_ID_ARGS(status.root_id));
|
|
|
|
|
smap_add_format(&smap, "rstp_designated_id", RSTP_ID_FMT,
|
|
|
|
|
RSTP_ID_ARGS(status.designated_id));
|
|
|
|
|
smap_add_format(&smap, "rstp_designated_port_id", RSTP_PORT_ID_FMT,
|
|
|
|
|
status.designated_port_id);
|
|
|
|
|
smap_add_format(&smap, "rstp_bridge_port_id", RSTP_PORT_ID_FMT,
|
|
|
|
|
status.bridge_port_id);
|
|
|
|
|
ovsrec_bridge_set_rstp_status(br->cfg, &smap);
|
|
|
|
|
smap_destroy(&smap);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
port_refresh_rstp_status(struct port *port)
|
|
|
|
|
{
|
|
|
|
|
struct ofproto *ofproto = port->bridge->ofproto;
|
|
|
|
|
struct iface *iface;
|
|
|
|
|
struct ofproto_port_rstp_status status;
|
|
|
|
|
struct smap smap;
|
|
|
|
|
|
|
|
|
|
if (port_is_synthetic(port)) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* RSTP doesn't currently support bonds. */
|
2016-03-25 14:10:22 -07:00
|
|
|
|
if (!ovs_list_is_singleton(&port->ifaces)) {
|
2014-08-22 09:01:34 -07:00
|
|
|
|
ovsrec_port_set_rstp_status(port->cfg, NULL);
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2016-03-25 14:10:22 -07:00
|
|
|
|
iface = CONTAINER_OF(ovs_list_front(&port->ifaces), struct iface, port_elem);
|
2014-08-22 09:01:34 -07:00
|
|
|
|
if (ofproto_port_get_rstp_status(ofproto, iface->ofp_port, &status)) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (!status.enabled) {
|
|
|
|
|
ovsrec_port_set_rstp_status(port->cfg, NULL);
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
/* Set Status column. */
|
|
|
|
|
smap_init(&smap);
|
|
|
|
|
|
|
|
|
|
smap_add_format(&smap, "rstp_port_id", RSTP_PORT_ID_FMT,
|
|
|
|
|
status.port_id);
|
|
|
|
|
smap_add_format(&smap, "rstp_port_role", "%s",
|
|
|
|
|
rstp_port_role_name(status.role));
|
|
|
|
|
smap_add_format(&smap, "rstp_port_state", "%s",
|
|
|
|
|
rstp_state_name(status.state));
|
2014-11-13 14:55:25 -08:00
|
|
|
|
smap_add_format(&smap, "rstp_designated_bridge_id", RSTP_ID_FMT,
|
|
|
|
|
RSTP_ID_ARGS(status.designated_bridge_id));
|
|
|
|
|
smap_add_format(&smap, "rstp_designated_port_id", RSTP_PORT_ID_FMT,
|
|
|
|
|
status.designated_port_id);
|
|
|
|
|
smap_add_format(&smap, "rstp_designated_path_cost", "%"PRIu32,
|
|
|
|
|
status.designated_path_cost);
|
2014-08-22 09:01:34 -07:00
|
|
|
|
|
|
|
|
|
ovsrec_port_set_rstp_status(port->cfg, &smap);
|
|
|
|
|
smap_destroy(&smap);
|
2019-12-30 16:19:39 -08:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
port_refresh_rstp_stats(struct port *port)
|
|
|
|
|
{
|
|
|
|
|
struct ofproto *ofproto = port->bridge->ofproto;
|
|
|
|
|
struct iface *iface;
|
|
|
|
|
struct ofproto_port_rstp_status status;
|
|
|
|
|
const char *keys[4];
|
|
|
|
|
int64_t int_values[4];
|
|
|
|
|
|
|
|
|
|
if (port_is_synthetic(port)) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* RSTP doesn't currently support bonds. */
|
|
|
|
|
if (!ovs_list_is_singleton(&port->ifaces)) {
|
|
|
|
|
ovsrec_port_set_rstp_statistics(port->cfg, NULL, NULL, 0);
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
iface = CONTAINER_OF(ovs_list_front(&port->ifaces), struct iface, port_elem);
|
|
|
|
|
if (ofproto_port_get_rstp_status(ofproto, iface->ofp_port, &status)) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (!status.enabled) {
|
|
|
|
|
ovsrec_port_set_rstp_statistics(port->cfg, NULL, NULL, 0);
|
|
|
|
|
return;
|
|
|
|
|
}
|
2014-08-22 09:01:34 -07:00
|
|
|
|
|
|
|
|
|
/* Set Statistics column. */
|
|
|
|
|
keys[0] = "rstp_tx_count";
|
|
|
|
|
int_values[0] = status.tx_count;
|
|
|
|
|
keys[1] = "rstp_rx_count";
|
|
|
|
|
int_values[1] = status.rx_count;
|
|
|
|
|
keys[2] = "rstp_uptime";
|
|
|
|
|
int_values[2] = status.uptime;
|
2015-02-19 10:19:21 -08:00
|
|
|
|
keys[3] = "rstp_error_count";
|
|
|
|
|
int_values[3] = status.error_count;
|
2014-08-22 09:01:34 -07:00
|
|
|
|
ovsrec_port_set_rstp_statistics(port->cfg, keys, int_values,
|
|
|
|
|
ARRAY_SIZE(int_values));
|
|
|
|
|
}
|
|
|
|
|
|
2014-10-04 23:35:30 -07:00
|
|
|
|
static void
|
|
|
|
|
port_refresh_bond_status(struct port *port, bool force_update)
|
|
|
|
|
{
|
2015-08-28 14:55:11 -07:00
|
|
|
|
struct eth_addr mac;
|
2014-10-04 23:35:30 -07:00
|
|
|
|
|
|
|
|
|
/* Return if port is not a bond */
|
2016-03-25 14:10:22 -07:00
|
|
|
|
if (ovs_list_is_singleton(&port->ifaces)) {
|
2014-10-04 23:35:30 -07:00
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2015-08-28 14:55:11 -07:00
|
|
|
|
if (bond_get_changed_active_slave(port->name, &mac, force_update)) {
|
2014-10-04 23:35:30 -07:00
|
|
|
|
struct ds mac_s;
|
|
|
|
|
|
|
|
|
|
ds_init(&mac_s);
|
|
|
|
|
ds_put_format(&mac_s, ETH_ADDR_FMT, ETH_ADDR_ARGS(mac));
|
|
|
|
|
ovsrec_port_set_bond_active_slave(port->cfg, ds_cstr(&mac_s));
|
|
|
|
|
ds_destroy(&mac_s);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2011-06-20 14:21:06 -07:00
|
|
|
|
static bool
|
|
|
|
|
enable_system_stats(const struct ovsrec_open_vswitch *cfg)
|
|
|
|
|
{
|
2012-05-22 01:53:07 -07:00
|
|
|
|
return smap_get_bool(&cfg->other_config, "enable-statistics", false);
|
2011-06-20 14:21:06 -07:00
|
|
|
|
}
|
|
|
|
|
|
2010-09-22 16:45:30 -07:00
|
|
|
|
static void
|
2012-07-18 10:59:52 -07:00
|
|
|
|
reconfigure_system_stats(const struct ovsrec_open_vswitch *cfg)
|
2010-09-22 16:45:30 -07:00
|
|
|
|
{
|
2012-07-18 10:59:52 -07:00
|
|
|
|
bool enable = enable_system_stats(cfg);
|
2010-09-22 16:45:30 -07:00
|
|
|
|
|
2012-07-18 10:59:52 -07:00
|
|
|
|
system_stats_enable(enable);
|
|
|
|
|
if (!enable) {
|
|
|
|
|
ovsrec_open_vswitch_set_statistics(cfg, NULL);
|
2011-06-20 14:21:06 -07:00
|
|
|
|
}
|
2012-07-18 10:59:52 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
run_system_stats(void)
|
|
|
|
|
{
|
|
|
|
|
const struct ovsrec_open_vswitch *cfg = ovsrec_open_vswitch_first(idl);
|
|
|
|
|
struct smap *stats;
|
|
|
|
|
|
|
|
|
|
stats = system_stats_run();
|
|
|
|
|
if (stats && cfg) {
|
|
|
|
|
struct ovsdb_idl_txn *txn;
|
|
|
|
|
struct ovsdb_datum datum;
|
|
|
|
|
|
|
|
|
|
txn = ovsdb_idl_txn_create(idl);
|
|
|
|
|
ovsdb_datum_from_smap(&datum, stats);
|
2016-08-31 22:03:27 -07:00
|
|
|
|
smap_destroy(stats);
|
2012-07-18 10:59:52 -07:00
|
|
|
|
ovsdb_idl_txn_write(&cfg->header_, &ovsrec_open_vswitch_col_statistics,
|
|
|
|
|
&datum);
|
|
|
|
|
ovsdb_idl_txn_commit(txn);
|
|
|
|
|
ovsdb_idl_txn_destroy(txn);
|
2010-09-22 16:45:30 -07:00
|
|
|
|
|
2012-07-18 10:59:52 -07:00
|
|
|
|
free(stats);
|
|
|
|
|
}
|
2010-09-22 16:45:30 -07:00
|
|
|
|
}
|
|
|
|
|
|
2013-12-16 09:20:12 -08:00
|
|
|
|
static const char *
|
2013-02-11 23:55:31 -08:00
|
|
|
|
ofp12_controller_role_to_str(enum ofp12_controller_role role)
|
2011-01-21 11:01:45 -08:00
|
|
|
|
{
|
|
|
|
|
switch (role) {
|
2013-02-11 23:55:31 -08:00
|
|
|
|
case OFPCR12_ROLE_EQUAL:
|
2011-01-21 11:01:45 -08:00
|
|
|
|
return "other";
|
2013-02-11 23:55:31 -08:00
|
|
|
|
case OFPCR12_ROLE_MASTER:
|
2011-01-21 11:01:45 -08:00
|
|
|
|
return "master";
|
2013-02-11 23:55:31 -08:00
|
|
|
|
case OFPCR12_ROLE_SLAVE:
|
2011-01-21 11:01:45 -08:00
|
|
|
|
return "slave";
|
2013-02-11 23:55:31 -08:00
|
|
|
|
case OFPCR12_ROLE_NOCHANGE:
|
2011-01-21 11:01:45 -08:00
|
|
|
|
default:
|
2018-10-24 14:23:38 -07:00
|
|
|
|
return NULL;
|
2011-01-21 11:01:45 -08:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
2011-06-30 15:15:46 -07:00
|
|
|
|
refresh_controller_status(void)
|
2011-01-21 11:01:45 -08:00
|
|
|
|
{
|
2011-06-30 15:15:46 -07:00
|
|
|
|
struct bridge *br;
|
|
|
|
|
|
|
|
|
|
/* Accumulate status for controllers on all bridges. */
|
|
|
|
|
HMAP_FOR_EACH (br, node, &all_bridges) {
|
2017-05-10 15:10:59 -07:00
|
|
|
|
struct shash info = SHASH_INITIALIZER(&info);
|
2011-06-30 15:15:46 -07:00
|
|
|
|
ofproto_get_ofproto_controller_info(br->ofproto, &info);
|
2011-01-21 11:01:45 -08:00
|
|
|
|
|
2017-05-10 15:10:59 -07:00
|
|
|
|
/* Update each controller of the bridge in the database with
|
|
|
|
|
* current status. */
|
|
|
|
|
struct ovsrec_controller **controllers;
|
|
|
|
|
size_t n_controllers = bridge_get_controllers(br, &controllers);
|
|
|
|
|
size_t i;
|
|
|
|
|
for (i = 0; i < n_controllers; i++) {
|
|
|
|
|
struct ovsrec_controller *cfg = controllers[i];
|
|
|
|
|
struct ofproto_controller_info *cinfo =
|
|
|
|
|
shash_find_data(&info, cfg->target);
|
2011-01-24 17:01:53 -08:00
|
|
|
|
|
2017-09-06 15:08:10 -07:00
|
|
|
|
/* cinfo is NULL when 'cfg->target' is a passive connection. */
|
|
|
|
|
if (cinfo) {
|
|
|
|
|
ovsrec_controller_set_is_connected(cfg, cinfo->is_connected);
|
|
|
|
|
const char *role = ofp12_controller_role_to_str(cinfo->role);
|
|
|
|
|
ovsrec_controller_set_role(cfg, role);
|
|
|
|
|
ovsrec_controller_set_status(cfg, &cinfo->pairs);
|
|
|
|
|
} else {
|
|
|
|
|
ovsrec_controller_set_is_connected(cfg, false);
|
|
|
|
|
ovsrec_controller_set_role(cfg, NULL);
|
|
|
|
|
ovsrec_controller_set_status(cfg, NULL);
|
|
|
|
|
}
|
2011-01-24 17:01:53 -08:00
|
|
|
|
}
|
2011-01-21 11:01:45 -08:00
|
|
|
|
|
2017-05-10 15:10:59 -07:00
|
|
|
|
ofproto_free_ofproto_controller_info(&info);
|
|
|
|
|
}
|
2011-01-21 11:01:45 -08:00
|
|
|
|
}
|
2013-03-19 14:02:48 -07:00
|
|
|
|
|
2014-09-18 14:35:30 -07:00
|
|
|
|
/* Update interface and mirror statistics if necessary. */
|
|
|
|
|
static void
|
|
|
|
|
run_stats_update(void)
|
|
|
|
|
{
|
|
|
|
|
const struct ovsrec_open_vswitch *cfg = ovsrec_open_vswitch_first(idl);
|
|
|
|
|
int stats_interval;
|
|
|
|
|
|
|
|
|
|
if (!cfg) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Statistics update interval should always be greater than or equal to
|
|
|
|
|
* 5000 ms. */
|
|
|
|
|
stats_interval = MAX(smap_get_int(&cfg->other_config,
|
|
|
|
|
"stats-update-interval",
|
|
|
|
|
5000), 5000);
|
|
|
|
|
if (stats_timer_interval != stats_interval) {
|
|
|
|
|
stats_timer_interval = stats_interval;
|
|
|
|
|
stats_timer = LLONG_MIN;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (time_msec() >= stats_timer) {
|
|
|
|
|
enum ovsdb_idl_txn_status status;
|
|
|
|
|
|
|
|
|
|
/* Rate limit the update. Do not start a new update if the
|
|
|
|
|
* previous one is not done. */
|
|
|
|
|
if (!stats_txn) {
|
|
|
|
|
struct bridge *br;
|
|
|
|
|
|
|
|
|
|
stats_txn = ovsdb_idl_txn_create(idl);
|
|
|
|
|
HMAP_FOR_EACH (br, node, &all_bridges) {
|
|
|
|
|
struct port *port;
|
|
|
|
|
struct mirror *m;
|
|
|
|
|
|
|
|
|
|
HMAP_FOR_EACH (port, hmap_node, &br->ports) {
|
|
|
|
|
struct iface *iface;
|
|
|
|
|
|
|
|
|
|
LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
|
|
|
|
|
iface_refresh_stats(iface);
|
|
|
|
|
}
|
|
|
|
|
port_refresh_stp_stats(port);
|
2019-12-30 16:19:39 -08:00
|
|
|
|
port_refresh_rstp_stats(port);
|
2014-09-18 14:35:30 -07:00
|
|
|
|
}
|
|
|
|
|
HMAP_FOR_EACH (m, hmap_node, &br->mirrors) {
|
|
|
|
|
mirror_refresh_stats(m);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
refresh_controller_status();
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
status = ovsdb_idl_txn_commit(stats_txn);
|
|
|
|
|
if (status != TXN_INCOMPLETE) {
|
|
|
|
|
stats_timer = time_msec() + stats_timer_interval;
|
|
|
|
|
ovsdb_idl_txn_destroy(stats_txn);
|
|
|
|
|
stats_txn = NULL;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2015-03-31 17:07:03 -07:00
|
|
|
|
static void
|
|
|
|
|
stats_update_wait(void)
|
|
|
|
|
{
|
|
|
|
|
/* If the 'stats_txn' is non-null (transaction incomplete), waits for the
|
|
|
|
|
* transaction to complete. Otherwise, waits for the 'stats_timer'. */
|
|
|
|
|
if (stats_txn) {
|
|
|
|
|
ovsdb_idl_txn_wait(stats_txn);
|
|
|
|
|
} else {
|
|
|
|
|
poll_timer_wait_until(stats_timer);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2014-09-18 14:35:30 -07:00
|
|
|
|
/* Update bridge/port/interface status if necessary. */
|
|
|
|
|
static void
|
|
|
|
|
run_status_update(void)
|
|
|
|
|
{
|
2014-09-29 18:09:57 +00:00
|
|
|
|
if (!status_txn) {
|
|
|
|
|
uint64_t seq;
|
2014-09-18 14:35:30 -07:00
|
|
|
|
|
|
|
|
|
/* Rate limit the update. Do not start a new update if the
|
|
|
|
|
* previous one is not done. */
|
2014-09-29 18:09:57 +00:00
|
|
|
|
seq = seq_read(connectivity_seq_get());
|
|
|
|
|
if (seq != connectivity_seqno || status_txn_try_again) {
|
2018-05-03 15:08:01 -04:00
|
|
|
|
const struct ovsrec_open_vswitch *cfg =
|
|
|
|
|
ovsrec_open_vswitch_first(idl);
|
2014-09-18 14:35:30 -07:00
|
|
|
|
struct bridge *br;
|
|
|
|
|
|
|
|
|
|
connectivity_seqno = seq;
|
|
|
|
|
status_txn = ovsdb_idl_txn_create(idl);
|
2018-05-03 15:08:01 -04:00
|
|
|
|
dpdk_status(cfg);
|
2014-09-18 14:35:30 -07:00
|
|
|
|
HMAP_FOR_EACH (br, node, &all_bridges) {
|
|
|
|
|
struct port *port;
|
|
|
|
|
|
|
|
|
|
br_refresh_stp_status(br);
|
|
|
|
|
br_refresh_rstp_status(br);
|
2014-10-16 15:23:11 -07:00
|
|
|
|
br_refresh_datapath_info(br);
|
2014-09-18 14:35:30 -07:00
|
|
|
|
HMAP_FOR_EACH (port, hmap_node, &br->ports) {
|
|
|
|
|
struct iface *iface;
|
|
|
|
|
|
|
|
|
|
port_refresh_stp_status(port);
|
|
|
|
|
port_refresh_rstp_status(port);
|
2014-10-04 23:35:30 -07:00
|
|
|
|
port_refresh_bond_status(port, status_txn_try_again);
|
2014-09-18 14:35:30 -07:00
|
|
|
|
LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
|
|
|
|
|
iface_refresh_netdev_status(iface);
|
|
|
|
|
iface_refresh_ofproto_status(iface);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
2014-09-29 18:09:57 +00:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Commit the transaction and get the status. If the transaction finishes,
|
|
|
|
|
* then destroy the transaction. Otherwise, keep it so that we can check
|
|
|
|
|
* progress the next time that this function is called. */
|
|
|
|
|
if (status_txn) {
|
|
|
|
|
enum ovsdb_idl_txn_status status;
|
2014-09-18 14:35:30 -07:00
|
|
|
|
|
|
|
|
|
status = ovsdb_idl_txn_commit(status_txn);
|
|
|
|
|
if (status != TXN_INCOMPLETE) {
|
|
|
|
|
ovsdb_idl_txn_destroy(status_txn);
|
|
|
|
|
status_txn = NULL;
|
|
|
|
|
|
|
|
|
|
/* Sets the 'status_txn_try_again' if the transaction fails. */
|
|
|
|
|
if (status == TXN_SUCCESS || status == TXN_UNCHANGED) {
|
|
|
|
|
status_txn_try_again = false;
|
|
|
|
|
} else {
|
|
|
|
|
status_txn_try_again = true;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
2015-02-20 14:17:11 -05:00
|
|
|
|
|
|
|
|
|
/* Refresh AA port status if necessary. */
|
|
|
|
|
if (time_msec() >= aa_refresh_timer) {
|
|
|
|
|
struct bridge *br;
|
|
|
|
|
|
|
|
|
|
HMAP_FOR_EACH (br, node, &all_bridges) {
|
|
|
|
|
if (bridge_aa_need_refresh(br)) {
|
|
|
|
|
struct ovsdb_idl_txn *txn;
|
|
|
|
|
|
|
|
|
|
txn = ovsdb_idl_txn_create(idl);
|
|
|
|
|
bridge_aa_refresh_queued(br);
|
|
|
|
|
ovsdb_idl_txn_commit(txn);
|
|
|
|
|
ovsdb_idl_txn_destroy(txn);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
aa_refresh_timer = time_msec() + AA_REFRESH_INTERVAL;
|
|
|
|
|
}
|
2014-09-18 14:35:30 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
status_update_wait(void)
|
|
|
|
|
{
|
|
|
|
|
/* If the 'status_txn' is non-null (transaction incomplete), waits for the
|
|
|
|
|
* transaction to complete. If the status update to database needs to be
|
|
|
|
|
* run again (transaction fails), registers a timeout in
|
|
|
|
|
* 'STATUS_CHECK_AGAIN_MSEC'. Otherwise, waits on the global connectivity
|
|
|
|
|
* sequence number. */
|
|
|
|
|
if (status_txn) {
|
|
|
|
|
ovsdb_idl_txn_wait(status_txn);
|
|
|
|
|
} else if (status_txn_try_again) {
|
|
|
|
|
poll_timer_wait_until(time_msec() + STATUS_CHECK_AGAIN_MSEC);
|
|
|
|
|
} else {
|
|
|
|
|
seq_wait(connectivity_seq_get(), connectivity_seqno);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2013-09-30 13:07:35 -07:00
|
|
|
|
static void
|
|
|
|
|
bridge_run__(void)
|
|
|
|
|
{
|
|
|
|
|
struct bridge *br;
|
|
|
|
|
struct sset types;
|
|
|
|
|
const char *type;
|
|
|
|
|
|
|
|
|
|
/* Let each datapath type do the work that it needs to do. */
|
|
|
|
|
sset_init(&types);
|
|
|
|
|
ofproto_enumerate_types(&types);
|
|
|
|
|
SSET_FOR_EACH (type, &types) {
|
|
|
|
|
ofproto_type_run(type);
|
|
|
|
|
}
|
|
|
|
|
sset_destroy(&types);
|
|
|
|
|
|
|
|
|
|
/* Let each bridge do the work that it needs to do. */
|
|
|
|
|
HMAP_FOR_EACH (br, node, &all_bridges) {
|
|
|
|
|
ofproto_run(br->ofproto);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2010-06-10 14:17:41 -07:00
|
|
|
|
void
|
2009-07-08 13:19:16 -07:00
|
|
|
|
bridge_run(void)
|
|
|
|
|
{
|
2012-12-08 18:23:12 -05:00
|
|
|
|
static struct ovsrec_open_vswitch null_cfg;
|
2010-08-05 09:58:58 -07:00
|
|
|
|
const struct ovsrec_open_vswitch *cfg;
|
|
|
|
|
|
2012-12-08 18:23:12 -05:00
|
|
|
|
ovsrec_open_vswitch_init(&null_cfg);
|
2012-07-18 10:56:21 -07:00
|
|
|
|
|
2013-12-11 17:55:26 -08:00
|
|
|
|
ovsdb_idl_run(idl);
|
2011-07-26 16:49:03 -07:00
|
|
|
|
|
2015-07-31 14:35:02 -03:00
|
|
|
|
if_notifier_run();
|
|
|
|
|
|
2013-12-11 17:55:26 -08:00
|
|
|
|
if (ovsdb_idl_is_lock_contended(idl)) {
|
|
|
|
|
static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 1);
|
|
|
|
|
struct bridge *br, *next_br;
|
2011-07-26 16:49:03 -07:00
|
|
|
|
|
2013-12-11 17:55:26 -08:00
|
|
|
|
VLOG_ERR_RL(&rl, "another ovs-vswitchd process is running, "
|
|
|
|
|
"disabling this process (pid %ld) until it goes away",
|
|
|
|
|
(long int) getpid());
|
2012-04-20 19:11:35 -07:00
|
|
|
|
|
2013-12-11 17:55:26 -08:00
|
|
|
|
HMAP_FOR_EACH_SAFE (br, next_br, node, &all_bridges) {
|
2016-02-04 09:48:54 -08:00
|
|
|
|
bridge_destroy(br, false);
|
2011-07-26 16:49:03 -07:00
|
|
|
|
}
|
2013-12-11 17:55:26 -08:00
|
|
|
|
/* Since we will not be running system_stats_run() in this process
|
|
|
|
|
* with the current situation of multiple ovs-vswitchd daemons,
|
|
|
|
|
* disable system stats collection. */
|
|
|
|
|
system_stats_enable(false);
|
|
|
|
|
return;
|
2015-04-01 16:11:19 -07:00
|
|
|
|
} else if (!ovsdb_idl_has_lock(idl)
|
|
|
|
|
|| !ovsdb_idl_has_ever_connected(idl)) {
|
|
|
|
|
/* Returns if not holding the lock or not done retrieving db
|
|
|
|
|
* contents. */
|
2013-12-11 17:55:26 -08:00
|
|
|
|
return;
|
2011-07-26 16:49:03 -07:00
|
|
|
|
}
|
|
|
|
|
cfg = ovsrec_open_vswitch_first(idl);
|
|
|
|
|
|
2016-04-29 13:44:01 -04:00
|
|
|
|
if (cfg) {
|
2017-06-13 18:03:29 +03:00
|
|
|
|
netdev_set_flow_api_enabled(&cfg->other_config);
|
2016-04-29 13:44:01 -04:00
|
|
|
|
dpdk_init(&cfg->other_config);
|
2020-01-17 18:47:55 -03:00
|
|
|
|
userspace_tso_init(&cfg->other_config);
|
2016-04-29 13:44:01 -04:00
|
|
|
|
}
|
|
|
|
|
|
2012-10-08 17:57:22 -07:00
|
|
|
|
/* Initialize the ofproto library. This only needs to run once, but
|
|
|
|
|
* it must be done after the configuration is set. If the
|
|
|
|
|
* initialization has already occurred, bridge_init_ofproto()
|
|
|
|
|
* returns immediately. */
|
|
|
|
|
bridge_init_ofproto(cfg);
|
|
|
|
|
|
2013-05-28 12:52:36 +00:00
|
|
|
|
/* Once the value of flow-restore-wait is false, we no longer should
|
|
|
|
|
* check its value from the database. */
|
|
|
|
|
if (cfg && ofproto_get_flow_restore_wait()) {
|
|
|
|
|
ofproto_set_flow_restore_wait(smap_get_bool(&cfg->other_config,
|
|
|
|
|
"flow-restore-wait", false));
|
|
|
|
|
}
|
|
|
|
|
|
2013-09-30 13:07:35 -07:00
|
|
|
|
bridge_run__();
|
2010-06-10 14:17:41 -07:00
|
|
|
|
|
2011-01-25 15:27:54 -08:00
|
|
|
|
/* Re-configure SSL. We do this on every trip through the main loop,
|
|
|
|
|
* instead of just when the database changes, because the contents of the
|
|
|
|
|
* key and certificate files can change without the database changing.
|
|
|
|
|
*
|
|
|
|
|
* We do this before bridge_reconfigure() because that function might
|
|
|
|
|
* initiate SSL connections and thus requires SSL to be configured. */
|
|
|
|
|
if (cfg && cfg->ssl) {
|
|
|
|
|
const struct ovsrec_ssl *ssl = cfg->ssl;
|
|
|
|
|
|
|
|
|
|
stream_ssl_set_key_and_cert(ssl->private_key, ssl->certificate);
|
|
|
|
|
stream_ssl_set_ca_cert_file(ssl->ca_cert, ssl->bootstrap_ca_cert);
|
|
|
|
|
}
|
2011-05-10 09:17:37 -07:00
|
|
|
|
|
2016-10-25 15:44:43 -02:00
|
|
|
|
if (ovsdb_idl_get_seqno(idl) != idl_seqno ||
|
|
|
|
|
if_notifier_changed(ifnotifier)) {
|
2013-12-11 17:55:26 -08:00
|
|
|
|
struct ovsdb_idl_txn *txn;
|
2013-04-11 15:47:08 -07:00
|
|
|
|
|
2013-12-11 17:55:26 -08:00
|
|
|
|
idl_seqno = ovsdb_idl_get_seqno(idl);
|
|
|
|
|
txn = ovsdb_idl_txn_create(idl);
|
|
|
|
|
bridge_reconfigure(cfg ? cfg : &null_cfg);
|
2013-04-11 15:47:08 -07:00
|
|
|
|
|
2013-12-11 17:55:26 -08:00
|
|
|
|
if (cfg) {
|
|
|
|
|
ovsrec_open_vswitch_set_cur_cfg(cfg, cfg->next_cfg);
|
2015-03-24 10:39:11 +00:00
|
|
|
|
discover_types(cfg);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2010-06-23 11:02:46 -07:00
|
|
|
|
|
2013-12-11 17:55:26 -08:00
|
|
|
|
/* If we are completing our initial configuration for this run
|
|
|
|
|
* of ovs-vswitchd, then keep the transaction around to monitor
|
|
|
|
|
* it for completion. */
|
|
|
|
|
if (initial_config_done) {
|
2014-05-30 10:19:26 -07:00
|
|
|
|
/* Always sets the 'status_txn_try_again' to check again,
|
|
|
|
|
* in case that this transaction fails. */
|
|
|
|
|
status_txn_try_again = true;
|
2013-12-11 17:55:26 -08:00
|
|
|
|
ovsdb_idl_txn_commit(txn);
|
|
|
|
|
ovsdb_idl_txn_destroy(txn);
|
|
|
|
|
} else {
|
|
|
|
|
initial_config_done = true;
|
|
|
|
|
daemonize_txn = txn;
|
|
|
|
|
}
|
2012-04-20 19:11:35 -07:00
|
|
|
|
}
|
|
|
|
|
|
2013-04-10 10:33:39 -07:00
|
|
|
|
if (daemonize_txn) {
|
|
|
|
|
enum ovsdb_idl_txn_status status = ovsdb_idl_txn_commit(daemonize_txn);
|
|
|
|
|
if (status != TXN_INCOMPLETE) {
|
|
|
|
|
ovsdb_idl_txn_destroy(daemonize_txn);
|
|
|
|
|
daemonize_txn = NULL;
|
|
|
|
|
|
|
|
|
|
/* ovs-vswitchd has completed initialization, so allow the
|
|
|
|
|
* process that forked us to exit successfully. */
|
|
|
|
|
daemonize_complete();
|
|
|
|
|
|
async-append: Refactor to avoid requiring enabling while single threaded.
Until now, the async append interface has required async_append_enable()
to be called while the process was still single-threaded, with the
rationale being that async_append_enable() could race with
async_append_write() on some existing async_append object. This was a
difficult problem when the async append interface was introduced, because
at the time Open vSwitch did not have any infrastructure for inter-thread
synchronization.
Now it is easy to solve, by introducing synchronization into the
async append module. However, that's more or less wasted, because the
client is already required to serialize access to async append objects.
Moreover, vlog, the only existing client, needs to serialize access for
other reasons, so it wouldn't even be possible to just drop the client's
synchronization.
This commit therefore takes another approach. It drops the
async_append_enable() interface entirely. Now any existing async_append
object is always enabled. The responsibility for "enabling", then, now
rests in whether the client creates and uses an async_append object, and
so vlog now takes care of that by itself. Also, since vlog now has to
deal with sometimes having an async_append and sometimes not having one,
we might as well allow creating an async_append to fail, thereby slightly
simplifying the "no async I/O" implementation from "write synchronously"
to "always fail creating an async_append".
Reported-by: Shih-Hao Li <shihli@nicira.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-08-02 17:32:25 -07:00
|
|
|
|
vlog_enable_async();
|
2013-07-10 11:43:46 -07:00
|
|
|
|
|
2013-04-10 10:33:39 -07:00
|
|
|
|
VLOG_INFO_ONCE("%s (Open vSwitch) %s", program_name, VERSION);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2014-09-18 14:35:30 -07:00
|
|
|
|
run_stats_update();
|
|
|
|
|
run_status_update();
|
2012-07-18 10:59:52 -07:00
|
|
|
|
run_system_stats();
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void
|
|
|
|
|
bridge_wait(void)
|
|
|
|
|
{
|
2012-10-11 17:17:40 -07:00
|
|
|
|
struct sset types;
|
|
|
|
|
const char *type;
|
|
|
|
|
|
2010-06-10 14:17:41 -07:00
|
|
|
|
ovsdb_idl_wait(idl);
|
2013-04-10 10:33:39 -07:00
|
|
|
|
if (daemonize_txn) {
|
|
|
|
|
ovsdb_idl_txn_wait(daemonize_txn);
|
|
|
|
|
}
|
2012-04-06 18:38:48 -07:00
|
|
|
|
|
2015-07-31 14:35:02 -03:00
|
|
|
|
if_notifier_wait();
|
|
|
|
|
|
2012-10-11 17:17:40 -07:00
|
|
|
|
sset_init(&types);
|
|
|
|
|
ofproto_enumerate_types(&types);
|
|
|
|
|
SSET_FOR_EACH (type, &types) {
|
|
|
|
|
ofproto_type_wait(type);
|
|
|
|
|
}
|
|
|
|
|
sset_destroy(&types);
|
|
|
|
|
|
2011-07-26 16:49:03 -07:00
|
|
|
|
if (!hmap_is_empty(&all_bridges)) {
|
|
|
|
|
struct bridge *br;
|
2011-03-25 13:36:43 -07:00
|
|
|
|
|
2011-07-26 16:49:03 -07:00
|
|
|
|
HMAP_FOR_EACH (br, node, &all_bridges) {
|
|
|
|
|
ofproto_wait(br->ofproto);
|
|
|
|
|
}
|
2015-03-31 17:07:03 -07:00
|
|
|
|
stats_update_wait();
|
2015-03-31 16:53:47 -07:00
|
|
|
|
status_update_wait();
|
2011-03-25 13:36:43 -07:00
|
|
|
|
}
|
2012-07-18 10:59:52 -07:00
|
|
|
|
|
|
|
|
|
system_stats_wait();
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2012-05-08 15:44:21 -07:00
|
|
|
|
|
|
|
|
|
/* Adds some memory usage statistics for bridges into 'usage', for use with
|
|
|
|
|
* memory_report(). */
|
|
|
|
|
void
|
|
|
|
|
bridge_get_memory_usage(struct simap *usage)
|
|
|
|
|
{
|
|
|
|
|
struct bridge *br;
|
2013-11-20 17:41:02 -08:00
|
|
|
|
struct sset types;
|
|
|
|
|
const char *type;
|
|
|
|
|
|
|
|
|
|
sset_init(&types);
|
|
|
|
|
ofproto_enumerate_types(&types);
|
|
|
|
|
SSET_FOR_EACH (type, &types) {
|
|
|
|
|
ofproto_type_get_memory_usage(type, usage);
|
|
|
|
|
}
|
|
|
|
|
sset_destroy(&types);
|
2012-05-08 15:44:21 -07:00
|
|
|
|
|
|
|
|
|
HMAP_FOR_EACH (br, node, &all_bridges) {
|
|
|
|
|
ofproto_get_memory_usage(br->ofproto, usage);
|
|
|
|
|
}
|
|
|
|
|
}
|
2009-07-15 11:05:37 -07:00
|
|
|
|
|
2011-03-11 13:44:16 -08:00
|
|
|
|
/* QoS unixctl user interface functions. */
|
|
|
|
|
|
|
|
|
|
struct qos_unixctl_show_cbdata {
|
|
|
|
|
struct ds *ds;
|
|
|
|
|
struct iface *iface;
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
static void
|
2013-08-27 17:15:53 -07:00
|
|
|
|
qos_unixctl_show_queue(unsigned int queue_id,
|
|
|
|
|
const struct smap *details,
|
|
|
|
|
struct iface *iface,
|
|
|
|
|
struct ds *ds)
|
2011-03-11 13:44:16 -08:00
|
|
|
|
{
|
|
|
|
|
struct netdev_queue_stats stats;
|
2012-05-22 03:47:36 -07:00
|
|
|
|
struct smap_node *node;
|
2011-03-11 13:44:16 -08:00
|
|
|
|
int error;
|
|
|
|
|
|
|
|
|
|
ds_put_cstr(ds, "\n");
|
|
|
|
|
if (queue_id) {
|
|
|
|
|
ds_put_format(ds, "Queue %u:\n", queue_id);
|
|
|
|
|
} else {
|
|
|
|
|
ds_put_cstr(ds, "Default:\n");
|
|
|
|
|
}
|
|
|
|
|
|
2012-05-22 03:47:36 -07:00
|
|
|
|
SMAP_FOR_EACH (node, details) {
|
2018-05-25 17:11:07 -07:00
|
|
|
|
ds_put_format(ds, " %s: %s\n", node->key, node->value);
|
2011-03-11 13:44:16 -08:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
error = netdev_get_queue_stats(iface->netdev, queue_id, &stats);
|
|
|
|
|
if (!error) {
|
|
|
|
|
if (stats.tx_packets != UINT64_MAX) {
|
2018-05-25 17:11:07 -07:00
|
|
|
|
ds_put_format(ds, " tx_packets: %"PRIu64"\n", stats.tx_packets);
|
2011-03-11 13:44:16 -08:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (stats.tx_bytes != UINT64_MAX) {
|
2018-05-25 17:11:07 -07:00
|
|
|
|
ds_put_format(ds, " tx_bytes: %"PRIu64"\n", stats.tx_bytes);
|
2011-03-11 13:44:16 -08:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (stats.tx_errors != UINT64_MAX) {
|
2018-05-25 17:11:07 -07:00
|
|
|
|
ds_put_format(ds, " tx_errors: %"PRIu64"\n", stats.tx_errors);
|
2011-03-11 13:44:16 -08:00
|
|
|
|
}
|
|
|
|
|
} else {
|
2018-05-25 17:11:07 -07:00
|
|
|
|
ds_put_format(ds, " Failed to get statistics for queue %u: %s",
|
2013-06-24 10:54:49 -07:00
|
|
|
|
queue_id, ovs_strerror(error));
|
2011-03-11 13:44:16 -08:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2016-03-18 17:14:16 +00:00
|
|
|
|
static void
|
|
|
|
|
qos_unixctl_show_types(struct unixctl_conn *conn, int argc OVS_UNUSED,
|
|
|
|
|
const char *argv[], void *aux OVS_UNUSED)
|
|
|
|
|
{
|
|
|
|
|
struct ds ds = DS_EMPTY_INITIALIZER;
|
|
|
|
|
struct sset types = SSET_INITIALIZER(&types);
|
|
|
|
|
struct iface *iface;
|
|
|
|
|
const char * types_name;
|
|
|
|
|
int error;
|
|
|
|
|
|
|
|
|
|
iface = iface_find(argv[1]);
|
|
|
|
|
if (!iface) {
|
|
|
|
|
unixctl_command_reply_error(conn, "no such interface");
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
error = netdev_get_qos_types(iface->netdev, &types);
|
|
|
|
|
if (!error) {
|
|
|
|
|
if (!sset_is_empty(&types)) {
|
|
|
|
|
SSET_FOR_EACH (types_name, &types) {
|
|
|
|
|
ds_put_format(&ds, "QoS type: %s\n", types_name);
|
|
|
|
|
}
|
|
|
|
|
unixctl_command_reply(conn, ds_cstr(&ds));
|
|
|
|
|
} else {
|
|
|
|
|
ds_put_format(&ds, "No QoS types supported for interface: %s\n",
|
|
|
|
|
iface->name);
|
|
|
|
|
unixctl_command_reply(conn, ds_cstr(&ds));
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
ds_put_format(&ds, "%s: failed to retrieve supported QoS types (%s)",
|
|
|
|
|
iface->name, ovs_strerror(error));
|
|
|
|
|
unixctl_command_reply_error(conn, ds_cstr(&ds));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
sset_destroy(&types);
|
|
|
|
|
ds_destroy(&ds);
|
|
|
|
|
}
|
|
|
|
|
|
2011-03-11 13:44:16 -08:00
|
|
|
|
static void
|
2011-12-02 15:29:19 -08:00
|
|
|
|
qos_unixctl_show(struct unixctl_conn *conn, int argc OVS_UNUSED,
|
|
|
|
|
const char *argv[], void *aux OVS_UNUSED)
|
2011-03-11 13:44:16 -08:00
|
|
|
|
{
|
|
|
|
|
struct ds ds = DS_EMPTY_INITIALIZER;
|
2012-05-22 03:47:36 -07:00
|
|
|
|
struct smap smap = SMAP_INITIALIZER(&smap);
|
2011-03-11 13:44:16 -08:00
|
|
|
|
struct iface *iface;
|
|
|
|
|
const char *type;
|
2012-05-22 03:47:36 -07:00
|
|
|
|
struct smap_node *node;
|
2016-03-08 23:10:31 +00:00
|
|
|
|
int error;
|
2011-03-11 13:44:16 -08:00
|
|
|
|
|
2011-12-02 15:29:19 -08:00
|
|
|
|
iface = iface_find(argv[1]);
|
2011-03-11 13:44:16 -08:00
|
|
|
|
if (!iface) {
|
2012-02-14 20:53:59 -08:00
|
|
|
|
unixctl_command_reply_error(conn, "no such interface");
|
2011-03-11 13:44:16 -08:00
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2016-03-08 23:10:31 +00:00
|
|
|
|
error = netdev_get_qos(iface->netdev, &type, &smap);
|
|
|
|
|
if (!error) {
|
|
|
|
|
if (*type != '\0') {
|
|
|
|
|
struct netdev_queue_dump dump;
|
|
|
|
|
struct smap details;
|
|
|
|
|
unsigned int queue_id;
|
2011-03-11 13:44:16 -08:00
|
|
|
|
|
2016-03-08 23:10:31 +00:00
|
|
|
|
ds_put_format(&ds, "QoS: %s %s\n", iface->name, type);
|
2013-08-27 17:15:53 -07:00
|
|
|
|
|
2016-03-08 23:10:31 +00:00
|
|
|
|
SMAP_FOR_EACH (node, &smap) {
|
|
|
|
|
ds_put_format(&ds, "%s: %s\n", node->key, node->value);
|
|
|
|
|
}
|
2011-03-11 13:44:16 -08:00
|
|
|
|
|
2016-03-08 23:10:31 +00:00
|
|
|
|
smap_init(&details);
|
|
|
|
|
NETDEV_QUEUE_FOR_EACH (&queue_id, &details, &dump, iface->netdev) {
|
|
|
|
|
qos_unixctl_show_queue(queue_id, &details, iface, &ds);
|
|
|
|
|
}
|
|
|
|
|
smap_destroy(&details);
|
2011-03-11 13:44:16 -08:00
|
|
|
|
|
2016-03-08 23:10:31 +00:00
|
|
|
|
unixctl_command_reply(conn, ds_cstr(&ds));
|
|
|
|
|
} else {
|
|
|
|
|
ds_put_format(&ds, "QoS not configured on %s\n", iface->name);
|
2016-08-02 15:48:27 +02:00
|
|
|
|
unixctl_command_reply(conn, ds_cstr(&ds));
|
2011-03-11 13:44:16 -08:00
|
|
|
|
}
|
|
|
|
|
} else {
|
2016-03-08 23:10:31 +00:00
|
|
|
|
ds_put_format(&ds, "%s: failed to retrieve QOS configuration (%s)\n",
|
|
|
|
|
iface->name, ovs_strerror(error));
|
2012-02-14 20:53:59 -08:00
|
|
|
|
unixctl_command_reply_error(conn, ds_cstr(&ds));
|
2011-03-11 13:44:16 -08:00
|
|
|
|
}
|
|
|
|
|
|
2012-05-22 03:47:36 -07:00
|
|
|
|
smap_destroy(&smap);
|
2011-03-11 13:44:16 -08:00
|
|
|
|
ds_destroy(&ds);
|
|
|
|
|
}
|
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
/* Bridge reconfiguration functions. */
|
2011-04-08 13:50:21 -07:00
|
|
|
|
static void
|
2010-01-22 14:37:10 -05:00
|
|
|
|
bridge_create(const struct ovsrec_bridge *br_cfg)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
|
|
|
|
struct bridge *br;
|
|
|
|
|
|
2012-11-06 13:14:55 -08:00
|
|
|
|
ovs_assert(!bridge_lookup(br_cfg->name));
|
2009-09-28 13:56:42 -07:00
|
|
|
|
br = xzalloc(sizeof *br);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2010-01-22 14:37:10 -05:00
|
|
|
|
br->name = xstrdup(br_cfg->name);
|
2011-05-09 09:33:02 -07:00
|
|
|
|
br->type = xstrdup(ofproto_normalize_type(br_cfg->datapath_type));
|
2010-01-22 14:37:10 -05:00
|
|
|
|
br->cfg = br_cfg;
|
2011-05-10 11:38:24 -07:00
|
|
|
|
|
|
|
|
|
/* Derive the default Ethernet address from the bridge's UUID. This should
|
|
|
|
|
* be unique and it will be stable between ovs-vswitchd runs. */
|
2015-08-28 14:55:11 -07:00
|
|
|
|
memcpy(&br->default_ea, &br_cfg->header_.uuid, ETH_ADDR_LEN);
|
|
|
|
|
eth_addr_mark_random(&br->default_ea);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-03-21 10:07:39 -07:00
|
|
|
|
hmap_init(&br->ports);
|
2010-07-19 11:23:05 -07:00
|
|
|
|
hmap_init(&br->ifaces);
|
2011-04-01 11:42:25 -07:00
|
|
|
|
hmap_init(&br->iface_by_name);
|
2011-05-11 12:26:06 -07:00
|
|
|
|
hmap_init(&br->mirrors);
|
2010-05-05 14:00:47 -07:00
|
|
|
|
|
2015-02-20 14:17:11 -05:00
|
|
|
|
hmap_init(&br->mappings);
|
2011-04-04 14:11:16 -07:00
|
|
|
|
hmap_insert(&all_bridges, &br->node, hash_string(br->name, 0));
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
2016-02-04 09:48:54 -08:00
|
|
|
|
bridge_destroy(struct bridge *br, bool del)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
|
|
|
|
if (br) {
|
2011-05-11 12:26:06 -07:00
|
|
|
|
struct mirror *mirror, *next_mirror;
|
|
|
|
|
struct port *port, *next_port;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
HMAP_FOR_EACH_SAFE (port, next_port, hmap_node, &br->ports) {
|
2011-03-21 10:07:39 -07:00
|
|
|
|
port_destroy(port);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2011-05-11 12:26:06 -07:00
|
|
|
|
HMAP_FOR_EACH_SAFE (mirror, next_mirror, hmap_node, &br->mirrors) {
|
|
|
|
|
mirror_destroy(mirror);
|
2011-04-11 11:22:39 -07:00
|
|
|
|
}
|
2012-04-20 19:11:35 -07:00
|
|
|
|
|
2011-04-04 14:11:16 -07:00
|
|
|
|
hmap_remove(&all_bridges, &br->node);
|
2016-02-04 09:48:54 -08:00
|
|
|
|
ofproto_destroy(br->ofproto, del);
|
2010-07-19 11:23:05 -07:00
|
|
|
|
hmap_destroy(&br->ifaces);
|
2011-03-21 10:07:39 -07:00
|
|
|
|
hmap_destroy(&br->ports);
|
2011-04-01 11:42:25 -07:00
|
|
|
|
hmap_destroy(&br->iface_by_name);
|
2011-05-11 12:26:06 -07:00
|
|
|
|
hmap_destroy(&br->mirrors);
|
2015-02-20 14:17:11 -05:00
|
|
|
|
hmap_destroy(&br->mappings);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
free(br->name);
|
2011-04-08 13:50:21 -07:00
|
|
|
|
free(br->type);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
free(br);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static struct bridge *
|
|
|
|
|
bridge_lookup(const char *name)
|
|
|
|
|
{
|
|
|
|
|
struct bridge *br;
|
|
|
|
|
|
2011-04-04 14:11:16 -07:00
|
|
|
|
HMAP_FOR_EACH_WITH_HASH (br, node, hash_string(name, 0), &all_bridges) {
|
2009-07-08 13:19:16 -07:00
|
|
|
|
if (!strcmp(br->name, name)) {
|
|
|
|
|
return br;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
return NULL;
|
|
|
|
|
}
|
|
|
|
|
|
2009-07-14 13:03:57 -07:00
|
|
|
|
/* Handle requests for a listing of all flows known by the OpenFlow
|
|
|
|
|
* stack, including those normally hidden. */
|
|
|
|
|
static void
|
Add offload packets statistics
Add argument '--offload-stats' for command ovs-appctl bridge/dump-flows
to display the offloaded packets statistics.
The commands display as below:
orignal command:
ovs-appctl bridge/dump-flows br0
duration=574s, n_packets=1152, n_bytes=110768, priority=0,actions=NORMAL
table_id=254, duration=574s, n_packets=0, n_bytes=0, priority=2,recirc_id=0,actions=drop
table_id=254, duration=574s, n_packets=0, n_bytes=0, priority=0,reg0=0x1,actions=controller(reason=)
table_id=254, duration=574s, n_packets=0, n_bytes=0, priority=0,reg0=0x2,actions=drop
table_id=254, duration=574s, n_packets=0, n_bytes=0, priority=0,reg0=0x3,actions=drop
new command with argument '--offload-stats'
Notice: 'n_offload_packets' are a subset of n_packets and 'n_offload_bytes' are
a subset of n_bytes.
ovs-appctl bridge/dump-flows --offload-stats br0
duration=582s, n_packets=1152, n_bytes=110768, n_offload_packets=1107, n_offload_bytes=107992, priority=0,actions=NORMAL
table_id=254, duration=582s, n_packets=0, n_bytes=0, n_offload_packets=0, n_offload_bytes=0, priority=2,recirc_id=0,actions=drop
table_id=254, duration=582s, n_packets=0, n_bytes=0, n_offload_packets=0, n_offload_bytes=0, priority=0,reg0=0x1,actions=controller(reason=)
table_id=254, duration=582s, n_packets=0, n_bytes=0, n_offload_packets=0, n_offload_bytes=0, priority=0,reg0=0x2,actions=drop
table_id=254, duration=582s, n_packets=0, n_bytes=0, n_offload_packets=0, n_offload_bytes=0, priority=0,reg0=0x3,actions=drop
Signed-off-by: zhaozhanxu <zhaozhanxu@163.com>
Signed-off-by: Simon Horman <simon.horman@netronome.com>
2019-12-05 14:26:25 +08:00
|
|
|
|
bridge_unixctl_dump_flows(struct unixctl_conn *conn, int argc,
|
2011-12-02 15:29:19 -08:00
|
|
|
|
const char *argv[], void *aux OVS_UNUSED)
|
2009-07-14 13:03:57 -07:00
|
|
|
|
{
|
|
|
|
|
struct bridge *br;
|
|
|
|
|
struct ds results;
|
2010-08-30 00:24:53 -07:00
|
|
|
|
|
Add offload packets statistics
Add argument '--offload-stats' for command ovs-appctl bridge/dump-flows
to display the offloaded packets statistics.
The commands display as below:
orignal command:
ovs-appctl bridge/dump-flows br0
duration=574s, n_packets=1152, n_bytes=110768, priority=0,actions=NORMAL
table_id=254, duration=574s, n_packets=0, n_bytes=0, priority=2,recirc_id=0,actions=drop
table_id=254, duration=574s, n_packets=0, n_bytes=0, priority=0,reg0=0x1,actions=controller(reason=)
table_id=254, duration=574s, n_packets=0, n_bytes=0, priority=0,reg0=0x2,actions=drop
table_id=254, duration=574s, n_packets=0, n_bytes=0, priority=0,reg0=0x3,actions=drop
new command with argument '--offload-stats'
Notice: 'n_offload_packets' are a subset of n_packets and 'n_offload_bytes' are
a subset of n_bytes.
ovs-appctl bridge/dump-flows --offload-stats br0
duration=582s, n_packets=1152, n_bytes=110768, n_offload_packets=1107, n_offload_bytes=107992, priority=0,actions=NORMAL
table_id=254, duration=582s, n_packets=0, n_bytes=0, n_offload_packets=0, n_offload_bytes=0, priority=2,recirc_id=0,actions=drop
table_id=254, duration=582s, n_packets=0, n_bytes=0, n_offload_packets=0, n_offload_bytes=0, priority=0,reg0=0x1,actions=controller(reason=)
table_id=254, duration=582s, n_packets=0, n_bytes=0, n_offload_packets=0, n_offload_bytes=0, priority=0,reg0=0x2,actions=drop
table_id=254, duration=582s, n_packets=0, n_bytes=0, n_offload_packets=0, n_offload_bytes=0, priority=0,reg0=0x3,actions=drop
Signed-off-by: zhaozhanxu <zhaozhanxu@163.com>
Signed-off-by: Simon Horman <simon.horman@netronome.com>
2019-12-05 14:26:25 +08:00
|
|
|
|
br = bridge_lookup(argv[argc - 1]);
|
2009-07-14 13:03:57 -07:00
|
|
|
|
if (!br) {
|
2012-02-14 20:53:59 -08:00
|
|
|
|
unixctl_command_reply_error(conn, "Unknown bridge");
|
2009-07-14 13:03:57 -07:00
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
Add offload packets statistics
Add argument '--offload-stats' for command ovs-appctl bridge/dump-flows
to display the offloaded packets statistics.
The commands display as below:
orignal command:
ovs-appctl bridge/dump-flows br0
duration=574s, n_packets=1152, n_bytes=110768, priority=0,actions=NORMAL
table_id=254, duration=574s, n_packets=0, n_bytes=0, priority=2,recirc_id=0,actions=drop
table_id=254, duration=574s, n_packets=0, n_bytes=0, priority=0,reg0=0x1,actions=controller(reason=)
table_id=254, duration=574s, n_packets=0, n_bytes=0, priority=0,reg0=0x2,actions=drop
table_id=254, duration=574s, n_packets=0, n_bytes=0, priority=0,reg0=0x3,actions=drop
new command with argument '--offload-stats'
Notice: 'n_offload_packets' are a subset of n_packets and 'n_offload_bytes' are
a subset of n_bytes.
ovs-appctl bridge/dump-flows --offload-stats br0
duration=582s, n_packets=1152, n_bytes=110768, n_offload_packets=1107, n_offload_bytes=107992, priority=0,actions=NORMAL
table_id=254, duration=582s, n_packets=0, n_bytes=0, n_offload_packets=0, n_offload_bytes=0, priority=2,recirc_id=0,actions=drop
table_id=254, duration=582s, n_packets=0, n_bytes=0, n_offload_packets=0, n_offload_bytes=0, priority=0,reg0=0x1,actions=controller(reason=)
table_id=254, duration=582s, n_packets=0, n_bytes=0, n_offload_packets=0, n_offload_bytes=0, priority=0,reg0=0x2,actions=drop
table_id=254, duration=582s, n_packets=0, n_bytes=0, n_offload_packets=0, n_offload_bytes=0, priority=0,reg0=0x3,actions=drop
Signed-off-by: zhaozhanxu <zhaozhanxu@163.com>
Signed-off-by: Simon Horman <simon.horman@netronome.com>
2019-12-05 14:26:25 +08:00
|
|
|
|
bool offload_stats = false;
|
|
|
|
|
for (int i = 1; i < argc - 1; i++) {
|
|
|
|
|
if (!strcmp(argv[i], "--offload-stats")) {
|
|
|
|
|
offload_stats = true;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2009-07-14 13:03:57 -07:00
|
|
|
|
ds_init(&results);
|
Add offload packets statistics
Add argument '--offload-stats' for command ovs-appctl bridge/dump-flows
to display the offloaded packets statistics.
The commands display as below:
orignal command:
ovs-appctl bridge/dump-flows br0
duration=574s, n_packets=1152, n_bytes=110768, priority=0,actions=NORMAL
table_id=254, duration=574s, n_packets=0, n_bytes=0, priority=2,recirc_id=0,actions=drop
table_id=254, duration=574s, n_packets=0, n_bytes=0, priority=0,reg0=0x1,actions=controller(reason=)
table_id=254, duration=574s, n_packets=0, n_bytes=0, priority=0,reg0=0x2,actions=drop
table_id=254, duration=574s, n_packets=0, n_bytes=0, priority=0,reg0=0x3,actions=drop
new command with argument '--offload-stats'
Notice: 'n_offload_packets' are a subset of n_packets and 'n_offload_bytes' are
a subset of n_bytes.
ovs-appctl bridge/dump-flows --offload-stats br0
duration=582s, n_packets=1152, n_bytes=110768, n_offload_packets=1107, n_offload_bytes=107992, priority=0,actions=NORMAL
table_id=254, duration=582s, n_packets=0, n_bytes=0, n_offload_packets=0, n_offload_bytes=0, priority=2,recirc_id=0,actions=drop
table_id=254, duration=582s, n_packets=0, n_bytes=0, n_offload_packets=0, n_offload_bytes=0, priority=0,reg0=0x1,actions=controller(reason=)
table_id=254, duration=582s, n_packets=0, n_bytes=0, n_offload_packets=0, n_offload_bytes=0, priority=0,reg0=0x2,actions=drop
table_id=254, duration=582s, n_packets=0, n_bytes=0, n_offload_packets=0, n_offload_bytes=0, priority=0,reg0=0x3,actions=drop
Signed-off-by: zhaozhanxu <zhaozhanxu@163.com>
Signed-off-by: Simon Horman <simon.horman@netronome.com>
2019-12-05 14:26:25 +08:00
|
|
|
|
ofproto_get_all_flows(br->ofproto, &results, offload_stats);
|
2009-07-14 13:03:57 -07:00
|
|
|
|
|
2012-02-14 20:53:59 -08:00
|
|
|
|
unixctl_command_reply(conn, ds_cstr(&results));
|
2009-07-14 13:03:57 -07:00
|
|
|
|
ds_destroy(&results);
|
|
|
|
|
}
|
|
|
|
|
|
2010-06-18 13:58:42 -07:00
|
|
|
|
/* "bridge/reconnect [BRIDGE]": makes BRIDGE drop all of its controller
|
|
|
|
|
* connections and reconnect. If BRIDGE is not specified, then all bridges
|
|
|
|
|
* drop their controller connections and reconnect. */
|
|
|
|
|
static void
|
2011-12-02 15:29:19 -08:00
|
|
|
|
bridge_unixctl_reconnect(struct unixctl_conn *conn, int argc,
|
|
|
|
|
const char *argv[], void *aux OVS_UNUSED)
|
2010-06-18 13:58:42 -07:00
|
|
|
|
{
|
|
|
|
|
struct bridge *br;
|
2011-12-02 15:29:19 -08:00
|
|
|
|
if (argc > 1) {
|
|
|
|
|
br = bridge_lookup(argv[1]);
|
2010-06-18 13:58:42 -07:00
|
|
|
|
if (!br) {
|
2012-02-14 20:53:59 -08:00
|
|
|
|
unixctl_command_reply_error(conn, "Unknown bridge");
|
2010-06-18 13:58:42 -07:00
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
ofproto_reconnect_controllers(br->ofproto);
|
|
|
|
|
} else {
|
2011-04-04 14:11:16 -07:00
|
|
|
|
HMAP_FOR_EACH (br, node, &all_bridges) {
|
2010-06-18 13:58:42 -07:00
|
|
|
|
ofproto_reconnect_controllers(br->ofproto);
|
|
|
|
|
}
|
|
|
|
|
}
|
2012-02-14 20:53:59 -08:00
|
|
|
|
unixctl_command_reply(conn, NULL);
|
2010-06-18 13:58:42 -07:00
|
|
|
|
}
|
|
|
|
|
|
2010-04-20 10:43:42 -07:00
|
|
|
|
static size_t
|
2010-07-15 14:53:36 -07:00
|
|
|
|
bridge_get_controllers(const struct bridge *br,
|
2010-04-20 10:43:42 -07:00
|
|
|
|
struct ovsrec_controller ***controllersp)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2010-04-20 10:43:42 -07:00
|
|
|
|
struct ovsrec_controller **controllers;
|
|
|
|
|
size_t n_controllers;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2010-07-15 14:53:36 -07:00
|
|
|
|
controllers = br->cfg->controller;
|
|
|
|
|
n_controllers = br->cfg->n_controller;
|
2009-12-03 11:28:40 -08:00
|
|
|
|
|
2010-04-20 10:43:42 -07:00
|
|
|
|
if (n_controllers == 1 && !strcmp(controllers[0]->target, "none")) {
|
|
|
|
|
controllers = NULL;
|
|
|
|
|
n_controllers = 0;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2009-12-03 11:28:40 -08:00
|
|
|
|
|
2010-04-20 10:43:42 -07:00
|
|
|
|
if (controllersp) {
|
|
|
|
|
*controllersp = controllers;
|
|
|
|
|
}
|
|
|
|
|
return n_controllers;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2012-04-20 19:11:35 -07:00
|
|
|
|
static void
|
2013-12-11 17:55:26 -08:00
|
|
|
|
bridge_collect_wanted_ports(struct bridge *br,
|
|
|
|
|
struct shash *wanted_ports)
|
2012-04-20 19:11:35 -07:00
|
|
|
|
{
|
2009-07-30 15:56:17 -07:00
|
|
|
|
size_t i;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2013-12-11 17:55:26 -08:00
|
|
|
|
shash_init(wanted_ports);
|
2012-04-20 19:11:35 -07:00
|
|
|
|
|
2009-12-03 11:28:40 -08:00
|
|
|
|
for (i = 0; i < br->cfg->n_ports; i++) {
|
|
|
|
|
const char *name = br->cfg->ports[i]->name;
|
2013-12-11 17:55:26 -08:00
|
|
|
|
if (!shash_add_once(wanted_ports, name, br->cfg->ports[i])) {
|
2009-12-03 11:28:40 -08:00
|
|
|
|
VLOG_WARN("bridge %s: %s specified twice as bridge port",
|
|
|
|
|
br->name, name);
|
|
|
|
|
}
|
|
|
|
|
}
|
2011-05-04 10:15:31 -07:00
|
|
|
|
if (bridge_get_controllers(br, NULL)
|
2013-12-11 17:55:26 -08:00
|
|
|
|
&& !shash_find(wanted_ports, br->name)) {
|
2011-04-13 11:10:44 -07:00
|
|
|
|
VLOG_WARN("bridge %s: no port named %s, synthesizing one",
|
|
|
|
|
br->name, br->name);
|
2009-06-19 14:09:39 -07:00
|
|
|
|
|
2012-05-22 01:53:07 -07:00
|
|
|
|
ovsrec_interface_init(&br->synth_local_iface);
|
|
|
|
|
ovsrec_port_init(&br->synth_local_port);
|
|
|
|
|
|
2011-04-13 11:10:44 -07:00
|
|
|
|
br->synth_local_port.interfaces = &br->synth_local_ifacep;
|
|
|
|
|
br->synth_local_port.n_interfaces = 1;
|
|
|
|
|
br->synth_local_port.name = br->name;
|
|
|
|
|
|
|
|
|
|
br->synth_local_iface.name = br->name;
|
2011-04-08 13:50:21 -07:00
|
|
|
|
br->synth_local_iface.type = "internal";
|
2011-04-13 11:10:44 -07:00
|
|
|
|
|
|
|
|
|
br->synth_local_ifacep = &br->synth_local_iface;
|
|
|
|
|
|
2013-12-11 17:55:26 -08:00
|
|
|
|
shash_add(wanted_ports, br->name, &br->synth_local_port);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2013-12-11 17:55:26 -08:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Deletes "struct port"s and "struct iface"s under 'br' which aren't
|
|
|
|
|
* consistent with 'br->cfg'. Updates 'br->if_cfg_queue' with interfaces which
|
|
|
|
|
* 'br' needs to complete its configuration. */
|
|
|
|
|
static void
|
|
|
|
|
bridge_del_ports(struct bridge *br, const struct shash *wanted_ports)
|
|
|
|
|
{
|
|
|
|
|
struct shash_node *port_node;
|
|
|
|
|
struct port *port, *next;
|
2011-11-23 17:03:31 -08:00
|
|
|
|
|
2010-05-05 14:00:47 -07:00
|
|
|
|
/* Get rid of deleted ports.
|
2011-11-14 10:28:31 -08:00
|
|
|
|
* Get rid of deleted interfaces on ports that still exist. */
|
2011-03-21 10:07:39 -07:00
|
|
|
|
HMAP_FOR_EACH_SAFE (port, next, hmap_node, &br->ports) {
|
2013-12-11 17:55:26 -08:00
|
|
|
|
port->cfg = shash_find_data(wanted_ports, port->name);
|
2011-04-08 13:50:21 -07:00
|
|
|
|
if (!port->cfg) {
|
2010-05-05 14:00:47 -07:00
|
|
|
|
port_destroy(port);
|
|
|
|
|
} else {
|
2011-04-08 13:50:21 -07:00
|
|
|
|
port_del_ifaces(port);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
2010-05-05 14:00:47 -07:00
|
|
|
|
|
2013-12-11 17:55:26 -08:00
|
|
|
|
/* Update iface->cfg and iface->type in interfaces that still exist. */
|
|
|
|
|
SHASH_FOR_EACH (port_node, wanted_ports) {
|
2017-08-02 15:03:06 -07:00
|
|
|
|
const struct ovsrec_port *port_rec = port_node->data;
|
2012-04-20 19:11:35 -07:00
|
|
|
|
size_t i;
|
|
|
|
|
|
2017-08-02 15:03:06 -07:00
|
|
|
|
for (i = 0; i < port_rec->n_interfaces; i++) {
|
|
|
|
|
const struct ovsrec_interface *cfg = port_rec->interfaces[i];
|
2012-04-20 19:11:35 -07:00
|
|
|
|
struct iface *iface = iface_lookup(br, cfg->name);
|
2012-05-21 13:20:18 -07:00
|
|
|
|
const char *type = iface_get_type(cfg, br->cfg);
|
2012-04-20 19:11:35 -07:00
|
|
|
|
|
|
|
|
|
if (iface) {
|
|
|
|
|
iface->cfg = cfg;
|
2012-05-21 13:20:18 -07:00
|
|
|
|
iface->type = type;
|
2012-08-21 15:44:58 -07:00
|
|
|
|
} else {
|
2013-12-11 17:55:26 -08:00
|
|
|
|
/* We will add new interfaces later. */
|
2012-04-20 19:11:35 -07:00
|
|
|
|
}
|
2010-04-29 14:54:10 -07:00
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2010-08-06 16:49:20 -07:00
|
|
|
|
/* Configures the IP stack for 'br''s local interface properly according to the
|
|
|
|
|
* configuration in 'c'. */
|
|
|
|
|
static void
|
|
|
|
|
bridge_configure_local_iface_netdev(struct bridge *br,
|
|
|
|
|
struct ovsrec_controller *c)
|
|
|
|
|
{
|
|
|
|
|
struct netdev *netdev;
|
|
|
|
|
struct in_addr mask, gateway;
|
|
|
|
|
|
|
|
|
|
struct iface *local_iface;
|
|
|
|
|
struct in_addr ip;
|
|
|
|
|
|
|
|
|
|
/* If there's no local interface or no IP address, give up. */
|
2011-05-09 09:24:39 -07:00
|
|
|
|
local_iface = iface_from_ofp_port(br, OFPP_LOCAL);
|
2015-12-15 18:04:20 -08:00
|
|
|
|
if (!local_iface || !c->local_ip || !ip_parse(c->local_ip, &ip.s_addr)) {
|
2010-08-06 16:49:20 -07:00
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Bring up the local interface. */
|
|
|
|
|
netdev = local_iface->netdev;
|
2013-05-10 08:55:25 -07:00
|
|
|
|
netdev_turn_flags_on(netdev, NETDEV_UP, NULL);
|
2010-08-06 16:49:20 -07:00
|
|
|
|
|
|
|
|
|
/* Configure the IP address and netmask. */
|
|
|
|
|
if (!c->local_netmask
|
2015-12-15 18:04:20 -08:00
|
|
|
|
|| !ip_parse(c->local_netmask, &mask.s_addr)
|
2010-08-06 16:49:20 -07:00
|
|
|
|
|| !mask.s_addr) {
|
|
|
|
|
mask.s_addr = guess_netmask(ip.s_addr);
|
|
|
|
|
}
|
|
|
|
|
if (!netdev_set_in4(netdev, ip, mask)) {
|
|
|
|
|
VLOG_INFO("bridge %s: configured IP address "IP_FMT", netmask "IP_FMT,
|
2012-12-12 15:26:21 -08:00
|
|
|
|
br->name, IP_ARGS(ip.s_addr), IP_ARGS(mask.s_addr));
|
2010-08-06 16:49:20 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Configure the default gateway. */
|
|
|
|
|
if (c->local_gateway
|
2015-12-15 18:04:20 -08:00
|
|
|
|
&& ip_parse(c->local_gateway, &gateway.s_addr)
|
2010-08-06 16:49:20 -07:00
|
|
|
|
&& gateway.s_addr) {
|
|
|
|
|
if (!netdev_add_router(netdev, gateway)) {
|
|
|
|
|
VLOG_INFO("bridge %s: configured gateway "IP_FMT,
|
2012-12-12 15:26:21 -08:00
|
|
|
|
br->name, IP_ARGS(gateway.s_addr));
|
2010-08-06 16:49:20 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2011-10-18 08:57:37 -07:00
|
|
|
|
/* Returns true if 'a' and 'b' are the same except that any number of slashes
|
|
|
|
|
* in either string are treated as equal to any number of slashes in the other,
|
2013-01-15 12:23:46 -08:00
|
|
|
|
* e.g. "x///y" is equal to "x/y".
|
|
|
|
|
*
|
|
|
|
|
* Also, if 'b_stoplen' bytes from 'b' are found to be equal to corresponding
|
|
|
|
|
* bytes from 'a', the function considers this success. Specify 'b_stoplen' as
|
|
|
|
|
* SIZE_MAX to compare all of 'a' to all of 'b' rather than just a prefix of
|
|
|
|
|
* 'b' against a prefix of 'a'.
|
|
|
|
|
*/
|
2011-10-18 08:57:37 -07:00
|
|
|
|
static bool
|
2013-01-15 12:23:46 -08:00
|
|
|
|
equal_pathnames(const char *a, const char *b, size_t b_stoplen)
|
2011-10-18 08:57:37 -07:00
|
|
|
|
{
|
2013-01-15 12:23:46 -08:00
|
|
|
|
const char *b_start = b;
|
2013-01-23 15:12:10 -08:00
|
|
|
|
for (;;) {
|
|
|
|
|
if (b - b_start >= b_stoplen) {
|
|
|
|
|
return true;
|
|
|
|
|
} else if (*a != *b) {
|
|
|
|
|
return false;
|
|
|
|
|
} else if (*a == '/') {
|
2011-10-18 08:57:37 -07:00
|
|
|
|
a += strspn(a, "/");
|
|
|
|
|
b += strspn(b, "/");
|
|
|
|
|
} else if (*a == '\0') {
|
|
|
|
|
return true;
|
|
|
|
|
} else {
|
|
|
|
|
a++;
|
|
|
|
|
b++;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2018-10-26 15:53:55 -07:00
|
|
|
|
static enum ofconn_type
|
|
|
|
|
get_controller_ofconn_type(const char *target, const char *type)
|
|
|
|
|
{
|
|
|
|
|
return (type
|
|
|
|
|
? (!strcmp(type, "primary") ? OFCONN_PRIMARY : OFCONN_SERVICE)
|
|
|
|
|
: (!vconn_verify_name(target) ? OFCONN_PRIMARY : OFCONN_SERVICE));
|
|
|
|
|
}
|
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static void
|
2011-05-11 12:26:06 -07:00
|
|
|
|
bridge_configure_remotes(struct bridge *br,
|
|
|
|
|
const struct sockaddr_in *managers, size_t n_managers)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2012-05-22 01:53:07 -07:00
|
|
|
|
bool disable_in_band;
|
2010-11-02 10:45:33 -07:00
|
|
|
|
|
2010-04-20 10:43:42 -07:00
|
|
|
|
struct ovsrec_controller **controllers;
|
|
|
|
|
size_t n_controllers;
|
2010-08-06 16:49:20 -07:00
|
|
|
|
|
2011-04-08 13:50:21 -07:00
|
|
|
|
enum ofproto_fail_mode fail_mode;
|
2010-08-06 16:49:20 -07:00
|
|
|
|
|
2010-10-19 15:58:35 -07:00
|
|
|
|
/* Check if we should disable in-band control on this bridge. */
|
2012-05-22 01:53:07 -07:00
|
|
|
|
disable_in_band = smap_get_bool(&br->cfg->other_config, "disable-in-band",
|
|
|
|
|
false);
|
2010-10-19 15:58:35 -07:00
|
|
|
|
|
2010-11-02 10:45:33 -07:00
|
|
|
|
/* Set OpenFlow queue ID for in-band control. */
|
2012-05-22 01:53:07 -07:00
|
|
|
|
ofproto_set_in_band_queue(br->ofproto,
|
|
|
|
|
smap_get_int(&br->cfg->other_config,
|
|
|
|
|
"in-band-queue", -1));
|
2010-11-02 10:45:33 -07:00
|
|
|
|
|
2010-10-19 15:58:35 -07:00
|
|
|
|
if (disable_in_band) {
|
|
|
|
|
ofproto_set_extra_in_band_remotes(br->ofproto, NULL, 0);
|
|
|
|
|
} else {
|
|
|
|
|
ofproto_set_extra_in_band_remotes(br->ofproto, managers, n_managers);
|
|
|
|
|
}
|
2010-04-26 10:48:31 -07:00
|
|
|
|
|
bridge.c: prevent controller connects while flow-restore-wait
When force-reload-kmod is used, it shows an error when reinstalling
tlvs during "Restoring saved flows" step:
OFPT_ERROR (xid=0x4): NXTTMFC_ALREADY_MAPPED
This is caused by a race condition between the restore script,
which calls ofctl, and the connected controllers both adding back
the same TLVs.
The restore script already sets flow-restore-wait to true while
doing flow restoration, and sets it back to false after it is
done, and this patch utilizes that fact to prevent the TLV race.
It does this by preventing vswitchd from connecting to
controllers in the controller table while it is in a
flow-restore-wait state.
With this patch, when bridge_configure_remotes() calls
bridge_get_controllers(), it first checks if flow-restore-wait
has been set, and if so, it ignores any controllers in the
controller database and sets n_controllers to 0.
This solution does preserve the management service controller
which is added via bridge_ofproto_controller_for_mgmt() after
checking whether we should call bridge_get_controllers()
(and thus n_controllers is properly set to 1, etc)
VMware-BZ: 2195377
Signed-off-by: Zak Whittington <zwhitt.vmware@gmail.com>
Signed-off-by: Ben Pfaff <blp@ovn.org>
2018-10-25 11:09:09 -07:00
|
|
|
|
n_controllers = (ofproto_get_flow_restore_wait() ? 0
|
|
|
|
|
: bridge_get_controllers(br, &controllers));
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2018-10-24 14:23:38 -07:00
|
|
|
|
/* The set of controllers to pass down to ofproto. */
|
|
|
|
|
struct shash ocs = SHASH_INITIALIZER(&ocs);
|
|
|
|
|
|
|
|
|
|
/* Add managment controller. */
|
|
|
|
|
struct ofproto_controller *oc = xmalloc(sizeof *oc);
|
|
|
|
|
*oc = (struct ofproto_controller) {
|
2018-10-26 15:53:55 -07:00
|
|
|
|
.type = OFCONN_SERVICE,
|
2018-10-24 14:23:38 -07:00
|
|
|
|
.probe_interval = 60,
|
|
|
|
|
.band = OFPROTO_OUT_OF_BAND,
|
|
|
|
|
.enable_async_msgs = true,
|
|
|
|
|
.allowed_versions = bridge_get_allowed_versions(br),
|
2019-08-02 10:29:52 +02:00
|
|
|
|
.max_pktq_size = bridge_get_controller_queue_size(br, NULL),
|
2018-10-24 14:23:38 -07:00
|
|
|
|
};
|
|
|
|
|
shash_add_nocopy(
|
|
|
|
|
&ocs, xasprintf("punix:%s/%s.mgmt", ovs_rundir(), br->name), oc);
|
|
|
|
|
|
|
|
|
|
for (size_t i = 0; i < n_controllers; i++) {
|
2010-08-06 16:49:20 -07:00
|
|
|
|
struct ovsrec_controller *c = controllers[i];
|
2016-06-20 14:19:40 -07:00
|
|
|
|
if (daemon_should_self_confine()
|
|
|
|
|
&& (!strncmp(c->target, "punix:", 6)
|
|
|
|
|
|| !strncmp(c->target, "unix:", 5))) {
|
2010-08-06 16:49:20 -07:00
|
|
|
|
static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
|
2011-10-18 08:57:37 -07:00
|
|
|
|
char *whitelist;
|
|
|
|
|
|
2013-01-15 12:23:46 -08:00
|
|
|
|
if (!strncmp(c->target, "unix:", 5)) {
|
|
|
|
|
/* Connect to a listening socket */
|
|
|
|
|
whitelist = xasprintf("unix:%s/", ovs_rundir());
|
2013-02-08 12:37:18 -08:00
|
|
|
|
if (strchr(c->target, '/') &&
|
|
|
|
|
!equal_pathnames(c->target, whitelist,
|
|
|
|
|
strlen(whitelist))) {
|
|
|
|
|
/* Absolute path specified, but not in ovs_rundir */
|
2013-01-15 12:23:46 -08:00
|
|
|
|
VLOG_ERR_RL(&rl, "bridge %s: Not connecting to socket "
|
|
|
|
|
"controller \"%s\" due to possibility for "
|
|
|
|
|
"remote exploit. Instead, specify socket "
|
|
|
|
|
"in whitelisted \"%s\" or connect to "
|
|
|
|
|
"\"unix:%s/%s.mgmt\" (which is always "
|
|
|
|
|
"available without special configuration).",
|
|
|
|
|
br->name, c->target, whitelist,
|
2011-10-18 08:57:37 -07:00
|
|
|
|
ovs_rundir(), br->name);
|
2013-01-15 12:23:46 -08:00
|
|
|
|
free(whitelist);
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
} else {
|
2015-08-21 15:20:24 -07:00
|
|
|
|
whitelist = xasprintf("punix:%s/%s.",
|
2013-01-15 12:23:46 -08:00
|
|
|
|
ovs_rundir(), br->name);
|
2015-08-21 15:20:24 -07:00
|
|
|
|
if (!equal_pathnames(c->target, whitelist, strlen(whitelist))
|
|
|
|
|
|| strchr(c->target + strlen(whitelist), '/')) {
|
2013-01-15 12:23:46 -08:00
|
|
|
|
/* Prevent remote ovsdb-server users from accessing
|
|
|
|
|
* arbitrary Unix domain sockets and overwriting arbitrary
|
|
|
|
|
* local files. */
|
|
|
|
|
VLOG_ERR_RL(&rl, "bridge %s: Not adding Unix domain socket "
|
|
|
|
|
"controller \"%s\" due to possibility of "
|
|
|
|
|
"overwriting local files. Instead, specify "
|
2015-08-21 15:20:24 -07:00
|
|
|
|
"path in whitelisted format \"%s*\" or "
|
|
|
|
|
"connect to \"unix:%s/%s.mgmt\" (which is "
|
|
|
|
|
"always available without special "
|
|
|
|
|
"configuration).",
|
2013-01-15 12:23:46 -08:00
|
|
|
|
br->name, c->target, whitelist,
|
|
|
|
|
ovs_rundir(), br->name);
|
|
|
|
|
free(whitelist);
|
|
|
|
|
continue;
|
|
|
|
|
}
|
2011-10-18 08:57:37 -07:00
|
|
|
|
}
|
2011-04-14 16:50:26 -07:00
|
|
|
|
|
2011-10-18 08:57:37 -07:00
|
|
|
|
free(whitelist);
|
2011-04-14 16:50:26 -07:00
|
|
|
|
}
|
|
|
|
|
|
2010-08-06 16:49:20 -07:00
|
|
|
|
bridge_configure_local_iface_netdev(br, c);
|
2011-01-06 12:14:23 -08:00
|
|
|
|
|
2018-10-24 14:23:38 -07:00
|
|
|
|
int dscp = smap_get_int(&c->other_config, "dscp", DSCP_DEFAULT);
|
|
|
|
|
if (dscp < 0 || dscp > 63) {
|
|
|
|
|
dscp = DSCP_DEFAULT;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
oc = xmalloc(sizeof *oc);
|
|
|
|
|
*oc = (struct ofproto_controller) {
|
2018-10-26 15:53:55 -07:00
|
|
|
|
.type = get_controller_ofconn_type(c->target, c->type),
|
2018-10-24 14:23:38 -07:00
|
|
|
|
.max_backoff = c->max_backoff ? *c->max_backoff / 1000 : 8,
|
|
|
|
|
.probe_interval = (c->inactivity_probe
|
|
|
|
|
? *c->inactivity_probe / 1000 : 5),
|
|
|
|
|
.band = ((!c->connection_mode
|
|
|
|
|
|| !strcmp(c->connection_mode, "in-band"))
|
|
|
|
|
&& !disable_in_band
|
|
|
|
|
? OFPROTO_IN_BAND : OFPROTO_OUT_OF_BAND),
|
|
|
|
|
.enable_async_msgs = (!c->enable_async_messages
|
|
|
|
|
|| *c->enable_async_messages),
|
|
|
|
|
.allowed_versions = bridge_get_allowed_versions(br),
|
2019-08-02 10:29:52 +02:00
|
|
|
|
.max_pktq_size = bridge_get_controller_queue_size(br, c),
|
2018-10-24 14:23:38 -07:00
|
|
|
|
.rate_limit = (c->controller_rate_limit
|
|
|
|
|
? *c->controller_rate_limit : 0),
|
|
|
|
|
.burst_limit = (c->controller_burst_limit
|
|
|
|
|
? *c->controller_burst_limit : 0),
|
|
|
|
|
.dscp = dscp,
|
|
|
|
|
};
|
|
|
|
|
shash_add(&ocs, c->target, oc);
|
|
|
|
|
}
|
|
|
|
|
ofproto_set_controllers(br->ofproto, &ocs);
|
|
|
|
|
shash_destroy_free_data(&ocs);
|
2011-04-08 13:50:21 -07:00
|
|
|
|
|
|
|
|
|
/* Set the fail-mode. */
|
|
|
|
|
fail_mode = !br->cfg->fail_mode
|
|
|
|
|
|| !strcmp(br->cfg->fail_mode, "standalone")
|
|
|
|
|
? OFPROTO_FAIL_STANDALONE
|
|
|
|
|
: OFPROTO_FAIL_SECURE;
|
|
|
|
|
ofproto_set_fail_mode(br->ofproto, fail_mode);
|
|
|
|
|
|
|
|
|
|
/* Configure OpenFlow controller connection snooping. */
|
|
|
|
|
if (!ofproto_has_snoops(br->ofproto)) {
|
|
|
|
|
struct sset snoops;
|
2011-04-13 17:58:26 -07:00
|
|
|
|
|
2011-04-08 13:50:21 -07:00
|
|
|
|
sset_init(&snoops);
|
|
|
|
|
sset_add_and_free(&snoops, xasprintf("punix:%s/%s.snoop",
|
|
|
|
|
ovs_rundir(), br->name));
|
|
|
|
|
ofproto_set_snoops(br->ofproto, &snoops);
|
|
|
|
|
sset_destroy(&snoops);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
2012-02-01 10:27:30 -08:00
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
bridge_configure_tables(struct bridge *br)
|
|
|
|
|
{
|
|
|
|
|
static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
|
|
|
|
|
int n_tables;
|
2017-08-02 15:03:06 -07:00
|
|
|
|
int i, j;
|
2012-02-01 10:27:30 -08:00
|
|
|
|
|
|
|
|
|
n_tables = ofproto_get_n_tables(br->ofproto);
|
|
|
|
|
j = 0;
|
|
|
|
|
for (i = 0; i < n_tables; i++) {
|
|
|
|
|
struct ofproto_table_settings s;
|
2014-07-21 14:34:02 -07:00
|
|
|
|
bool use_default_prefixes = true;
|
2012-02-01 10:27:30 -08:00
|
|
|
|
|
|
|
|
|
s.name = NULL;
|
|
|
|
|
s.max_flows = UINT_MAX;
|
|
|
|
|
s.groups = NULL;
|
2015-07-02 20:33:08 -07:00
|
|
|
|
s.enable_eviction = false;
|
2012-02-01 10:27:30 -08:00
|
|
|
|
s.n_groups = 0;
|
2013-12-11 11:07:01 -08:00
|
|
|
|
s.n_prefix_fields = 0;
|
|
|
|
|
memset(s.prefix_fields, ~0, sizeof(s.prefix_fields));
|
2012-02-01 10:27:30 -08:00
|
|
|
|
|
|
|
|
|
if (j < br->cfg->n_flow_tables && i == br->cfg->key_flow_tables[j]) {
|
|
|
|
|
struct ovsrec_flow_table *cfg = br->cfg->value_flow_tables[j++];
|
|
|
|
|
|
|
|
|
|
s.name = cfg->name;
|
|
|
|
|
if (cfg->n_flow_limit && *cfg->flow_limit < UINT_MAX) {
|
|
|
|
|
s.max_flows = *cfg->flow_limit;
|
|
|
|
|
}
|
|
|
|
|
|
2015-07-02 20:33:08 -07:00
|
|
|
|
s.enable_eviction = (cfg->overflow_policy
|
|
|
|
|
&& !strcmp(cfg->overflow_policy, "evict"));
|
|
|
|
|
if (cfg->n_groups) {
|
2012-02-01 10:27:30 -08:00
|
|
|
|
s.groups = xmalloc(cfg->n_groups * sizeof *s.groups);
|
2017-08-02 15:03:06 -07:00
|
|
|
|
for (int k = 0; k < cfg->n_groups; k++) {
|
2012-02-01 10:27:30 -08:00
|
|
|
|
const char *string = cfg->groups[k];
|
|
|
|
|
char *msg;
|
|
|
|
|
|
|
|
|
|
msg = mf_parse_subfield__(&s.groups[k], &string);
|
|
|
|
|
if (msg) {
|
|
|
|
|
VLOG_WARN_RL(&rl, "bridge %s table %d: error parsing "
|
|
|
|
|
"'groups' (%s)", br->name, i, msg);
|
|
|
|
|
free(msg);
|
|
|
|
|
} else if (*string) {
|
|
|
|
|
VLOG_WARN_RL(&rl, "bridge %s table %d: 'groups' "
|
|
|
|
|
"element '%s' contains trailing garbage",
|
|
|
|
|
br->name, i, cfg->groups[k]);
|
|
|
|
|
} else {
|
|
|
|
|
s.n_groups++;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
2015-07-02 20:33:08 -07:00
|
|
|
|
|
2013-12-11 11:07:01 -08:00
|
|
|
|
/* Prefix lookup fields. */
|
|
|
|
|
s.n_prefix_fields = 0;
|
2017-08-02 15:03:06 -07:00
|
|
|
|
for (int k = 0; k < cfg->n_prefixes; k++) {
|
2013-12-11 11:07:01 -08:00
|
|
|
|
const char *name = cfg->prefixes[k];
|
2014-05-16 12:51:11 -07:00
|
|
|
|
const struct mf_field *mf;
|
|
|
|
|
|
|
|
|
|
if (strcmp(name, "none") == 0) {
|
2014-07-21 14:34:02 -07:00
|
|
|
|
use_default_prefixes = false;
|
|
|
|
|
s.n_prefix_fields = 0;
|
|
|
|
|
break;
|
2014-05-16 12:51:11 -07:00
|
|
|
|
}
|
|
|
|
|
mf = mf_from_name(name);
|
2013-12-11 11:07:01 -08:00
|
|
|
|
if (!mf) {
|
|
|
|
|
VLOG_WARN("bridge %s: 'prefixes' with unknown field: %s",
|
|
|
|
|
br->name, name);
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
if (mf->flow_be32ofs < 0 || mf->n_bits % 32) {
|
|
|
|
|
VLOG_WARN("bridge %s: 'prefixes' with incompatible field: "
|
|
|
|
|
"%s", br->name, name);
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
if (s.n_prefix_fields >= ARRAY_SIZE(s.prefix_fields)) {
|
|
|
|
|
VLOG_WARN("bridge %s: 'prefixes' with too many fields, "
|
|
|
|
|
"field not used: %s", br->name, name);
|
|
|
|
|
continue;
|
|
|
|
|
}
|
2014-07-21 14:34:02 -07:00
|
|
|
|
use_default_prefixes = false;
|
2013-12-11 11:07:01 -08:00
|
|
|
|
s.prefix_fields[s.n_prefix_fields++] = mf->id;
|
|
|
|
|
}
|
2014-07-21 14:34:02 -07:00
|
|
|
|
}
|
|
|
|
|
if (use_default_prefixes) {
|
|
|
|
|
/* Use default values. */
|
|
|
|
|
s.n_prefix_fields = ARRAY_SIZE(default_prefix_fields);
|
|
|
|
|
memcpy(s.prefix_fields, default_prefix_fields,
|
|
|
|
|
sizeof default_prefix_fields);
|
|
|
|
|
} else {
|
|
|
|
|
struct ds ds = DS_EMPTY_INITIALIZER;
|
2017-08-02 15:03:06 -07:00
|
|
|
|
for (int k = 0; k < s.n_prefix_fields; k++) {
|
2014-07-21 14:34:02 -07:00
|
|
|
|
if (k) {
|
|
|
|
|
ds_put_char(&ds, ',');
|
2013-12-11 11:07:01 -08:00
|
|
|
|
}
|
2014-07-21 14:34:02 -07:00
|
|
|
|
ds_put_cstr(&ds, mf_from_id(s.prefix_fields[k])->name);
|
|
|
|
|
}
|
|
|
|
|
if (s.n_prefix_fields == 0) {
|
|
|
|
|
ds_put_cstr(&ds, "none");
|
2013-12-11 11:07:01 -08:00
|
|
|
|
}
|
2014-07-21 14:34:02 -07:00
|
|
|
|
VLOG_INFO("bridge %s table %d: Prefix lookup with: %s.",
|
|
|
|
|
br->name, i, ds_cstr(&ds));
|
|
|
|
|
ds_destroy(&ds);
|
2012-02-01 10:27:30 -08:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
ofproto_configure_table(br->ofproto, i, &s);
|
|
|
|
|
|
|
|
|
|
free(s.groups);
|
|
|
|
|
}
|
|
|
|
|
for (; j < br->cfg->n_flow_tables; j++) {
|
|
|
|
|
VLOG_WARN_RL(&rl, "bridge %s: ignoring configuration for flow table "
|
|
|
|
|
"%"PRId64" not supported by this datapath", br->name,
|
|
|
|
|
br->cfg->key_flow_tables[j]);
|
|
|
|
|
}
|
|
|
|
|
}
|
2012-12-26 15:00:06 -08:00
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
bridge_configure_dp_desc(struct bridge *br)
|
|
|
|
|
{
|
|
|
|
|
ofproto_set_dp_desc(br->ofproto,
|
|
|
|
|
smap_get(&br->cfg->other_config, "dp-desc"));
|
2020-01-13 12:29:10 +03:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
bridge_configure_serial_desc(struct bridge *br)
|
|
|
|
|
{
|
|
|
|
|
ofproto_set_serial_desc(br->ofproto,
|
|
|
|
|
smap_get(&br->cfg->other_config, "dp-sn"));
|
2012-12-26 15:00:06 -08:00
|
|
|
|
}
|
2015-02-20 14:17:11 -05:00
|
|
|
|
|
|
|
|
|
static struct aa_mapping *
|
|
|
|
|
bridge_aa_mapping_find(struct bridge *br, const int64_t isid)
|
|
|
|
|
{
|
|
|
|
|
struct aa_mapping *m;
|
|
|
|
|
|
|
|
|
|
HMAP_FOR_EACH_IN_BUCKET (m,
|
|
|
|
|
hmap_node,
|
|
|
|
|
hash_bytes(&isid, sizeof isid, 0),
|
|
|
|
|
&br->mappings) {
|
|
|
|
|
if (isid == m->isid) {
|
|
|
|
|
return m;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
return NULL;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static struct aa_mapping *
|
|
|
|
|
bridge_aa_mapping_create(struct bridge *br,
|
|
|
|
|
const int64_t isid,
|
|
|
|
|
const int64_t vlan)
|
|
|
|
|
{
|
|
|
|
|
struct aa_mapping *m;
|
|
|
|
|
|
|
|
|
|
m = xzalloc(sizeof *m);
|
|
|
|
|
m->bridge = br;
|
|
|
|
|
m->isid = isid;
|
|
|
|
|
m->vlan = vlan;
|
|
|
|
|
m->br_name = xstrdup(br->name);
|
|
|
|
|
hmap_insert(&br->mappings,
|
|
|
|
|
&m->hmap_node,
|
|
|
|
|
hash_bytes(&isid, sizeof isid, 0));
|
|
|
|
|
|
|
|
|
|
return m;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
bridge_aa_mapping_destroy(struct aa_mapping *m)
|
|
|
|
|
{
|
|
|
|
|
if (m) {
|
|
|
|
|
struct bridge *br = m->bridge;
|
|
|
|
|
|
|
|
|
|
if (br->ofproto) {
|
|
|
|
|
ofproto_aa_mapping_unregister(br->ofproto, m);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
hmap_remove(&br->mappings, &m->hmap_node);
|
|
|
|
|
if (m->br_name) {
|
|
|
|
|
free(m->br_name);
|
|
|
|
|
}
|
|
|
|
|
free(m);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static bool
|
|
|
|
|
bridge_aa_mapping_configure(struct aa_mapping *m)
|
|
|
|
|
{
|
|
|
|
|
struct aa_mapping_settings s;
|
|
|
|
|
|
|
|
|
|
s.isid = m->isid;
|
|
|
|
|
s.vlan = m->vlan;
|
|
|
|
|
|
|
|
|
|
/* Configure. */
|
|
|
|
|
ofproto_aa_mapping_register(m->bridge->ofproto, m, &s);
|
|
|
|
|
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
bridge_configure_aa(struct bridge *br)
|
|
|
|
|
{
|
|
|
|
|
const struct ovsdb_datum *mc;
|
|
|
|
|
struct ovsrec_autoattach *auto_attach = br->cfg->auto_attach;
|
|
|
|
|
struct aa_settings aa_s;
|
|
|
|
|
struct aa_mapping *m, *next;
|
|
|
|
|
size_t i;
|
|
|
|
|
|
|
|
|
|
if (!auto_attach) {
|
|
|
|
|
ofproto_set_aa(br->ofproto, NULL, NULL);
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
memset(&aa_s, 0, sizeof aa_s);
|
|
|
|
|
aa_s.system_description = auto_attach->system_description;
|
|
|
|
|
aa_s.system_name = auto_attach->system_name;
|
|
|
|
|
ofproto_set_aa(br->ofproto, NULL, &aa_s);
|
|
|
|
|
|
|
|
|
|
mc = ovsrec_autoattach_get_mappings(auto_attach,
|
|
|
|
|
OVSDB_TYPE_INTEGER,
|
|
|
|
|
OVSDB_TYPE_INTEGER);
|
|
|
|
|
HMAP_FOR_EACH_SAFE (m, next, hmap_node, &br->mappings) {
|
|
|
|
|
union ovsdb_atom atom;
|
|
|
|
|
|
|
|
|
|
atom.integer = m->isid;
|
2017-07-06 14:33:42 -07:00
|
|
|
|
if (ovsdb_datum_find_key(mc, &atom, OVSDB_TYPE_INTEGER) == UINT_MAX) {
|
2015-03-03 15:36:28 -08:00
|
|
|
|
VLOG_INFO("Deleting isid=%"PRIu32", vlan=%"PRIu16,
|
|
|
|
|
m->isid, m->vlan);
|
2015-02-20 14:17:11 -05:00
|
|
|
|
bridge_aa_mapping_destroy(m);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Add new mappings and reconfigure existing ones. */
|
|
|
|
|
for (i = 0; i < auto_attach->n_mappings; ++i) {
|
2017-08-02 15:03:06 -07:00
|
|
|
|
m = bridge_aa_mapping_find(br, auto_attach->key_mappings[i]);
|
2015-02-20 14:17:11 -05:00
|
|
|
|
|
|
|
|
|
if (!m) {
|
|
|
|
|
VLOG_INFO("Adding isid=%"PRId64", vlan=%"PRId64,
|
|
|
|
|
auto_attach->key_mappings[i],
|
|
|
|
|
auto_attach->value_mappings[i]);
|
|
|
|
|
m = bridge_aa_mapping_create(br,
|
|
|
|
|
auto_attach->key_mappings[i],
|
|
|
|
|
auto_attach->value_mappings[i]);
|
|
|
|
|
|
|
|
|
|
if (!bridge_aa_mapping_configure(m)) {
|
|
|
|
|
bridge_aa_mapping_destroy(m);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static bool
|
|
|
|
|
bridge_aa_need_refresh(struct bridge *br)
|
|
|
|
|
{
|
|
|
|
|
return ofproto_aa_vlan_get_queue_size(br->ofproto) > 0;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
bridge_aa_update_trunks(struct port *port, struct bridge_aa_vlan *m)
|
|
|
|
|
{
|
|
|
|
|
int64_t *trunks = NULL;
|
|
|
|
|
unsigned int i = 0;
|
|
|
|
|
bool found = false, reconfigure = false;
|
|
|
|
|
|
|
|
|
|
for (i = 0; i < port->cfg->n_trunks; i++) {
|
|
|
|
|
if (port->cfg->trunks[i] == m->vlan) {
|
|
|
|
|
found = true;
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
switch (m->oper) {
|
|
|
|
|
case BRIDGE_AA_VLAN_OPER_ADD:
|
|
|
|
|
if (!found) {
|
|
|
|
|
trunks = xmalloc(sizeof *trunks * (port->cfg->n_trunks + 1));
|
|
|
|
|
|
|
|
|
|
for (i = 0; i < port->cfg->n_trunks; i++) {
|
|
|
|
|
trunks[i] = port->cfg->trunks[i];
|
|
|
|
|
}
|
|
|
|
|
trunks[i++] = m->vlan;
|
|
|
|
|
reconfigure = true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case BRIDGE_AA_VLAN_OPER_REMOVE:
|
|
|
|
|
if (found) {
|
|
|
|
|
unsigned int j = 0;
|
|
|
|
|
|
|
|
|
|
trunks = xmalloc(sizeof *trunks * (port->cfg->n_trunks - 1));
|
|
|
|
|
|
|
|
|
|
for (i = 0; i < port->cfg->n_trunks; i++) {
|
|
|
|
|
if (port->cfg->trunks[i] != m->vlan) {
|
|
|
|
|
trunks[j++] = port->cfg->trunks[i];
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
i = j;
|
|
|
|
|
reconfigure = true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case BRIDGE_AA_VLAN_OPER_UNDEF:
|
|
|
|
|
default:
|
|
|
|
|
VLOG_WARN("unrecognized operation %u", m->oper);
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (reconfigure) {
|
|
|
|
|
/* VLAN switching under trunk mode cause the trunk port to switch all
|
|
|
|
|
* VLANs, see ovs-vswitchd.conf.db
|
|
|
|
|
*/
|
|
|
|
|
if (i == 0) {
|
|
|
|
|
static char *vlan_mode_access = "access";
|
|
|
|
|
ovsrec_port_set_vlan_mode(port->cfg, vlan_mode_access);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (i == 1) {
|
|
|
|
|
static char *vlan_mode_trunk = "trunk";
|
|
|
|
|
ovsrec_port_set_vlan_mode(port->cfg, vlan_mode_trunk);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
ovsrec_port_set_trunks(port->cfg, trunks, i);
|
|
|
|
|
|
|
|
|
|
/* Force reconfigure of the port. */
|
|
|
|
|
port_configure(port);
|
|
|
|
|
}
|
2017-05-26 16:11:40 -07:00
|
|
|
|
|
|
|
|
|
free(trunks);
|
2015-02-20 14:17:11 -05:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
bridge_aa_refresh_queued(struct bridge *br)
|
|
|
|
|
{
|
|
|
|
|
struct ovs_list *list = xmalloc(sizeof *list);
|
2015-04-16 14:49:23 -07:00
|
|
|
|
struct bridge_aa_vlan *node, *next;
|
2015-02-20 14:17:11 -05:00
|
|
|
|
|
2016-03-25 14:10:22 -07:00
|
|
|
|
ovs_list_init(list);
|
2015-02-20 14:17:11 -05:00
|
|
|
|
ofproto_aa_vlan_get_queued(br->ofproto, list);
|
|
|
|
|
|
2015-04-16 14:49:23 -07:00
|
|
|
|
LIST_FOR_EACH_SAFE (node, next, list_node, list) {
|
2015-02-20 14:17:11 -05:00
|
|
|
|
struct port *port;
|
|
|
|
|
|
|
|
|
|
VLOG_INFO("ifname=%s, vlan=%u, oper=%u", node->port_name, node->vlan,
|
|
|
|
|
node->oper);
|
|
|
|
|
|
|
|
|
|
port = port_lookup(br, node->port_name);
|
|
|
|
|
if (port) {
|
|
|
|
|
bridge_aa_update_trunks(port, node);
|
|
|
|
|
}
|
|
|
|
|
|
2016-03-25 14:10:22 -07:00
|
|
|
|
ovs_list_remove(&node->list_node);
|
2015-02-20 14:17:11 -05:00
|
|
|
|
free(node->port_name);
|
|
|
|
|
free(node);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
free(list);
|
|
|
|
|
}
|
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
/* Port functions. */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-03-30 11:03:16 -07:00
|
|
|
|
static struct port *
|
2011-05-11 12:26:06 -07:00
|
|
|
|
port_create(struct bridge *br, const struct ovsrec_port *cfg)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2011-03-30 11:03:16 -07:00
|
|
|
|
struct port *port;
|
|
|
|
|
|
|
|
|
|
port = xzalloc(sizeof *port);
|
|
|
|
|
port->bridge = br;
|
2011-05-11 12:26:06 -07:00
|
|
|
|
port->name = xstrdup(cfg->name);
|
|
|
|
|
port->cfg = cfg;
|
2016-03-25 14:10:22 -07:00
|
|
|
|
ovs_list_init(&port->ifaces);
|
2011-03-30 11:03:16 -07:00
|
|
|
|
|
|
|
|
|
hmap_insert(&br->ports, &port->hmap_node, hash_string(port->name, 0));
|
|
|
|
|
return port;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
/* Deletes interfaces from 'port' that are no longer configured for it. */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static void
|
2011-05-11 12:26:06 -07:00
|
|
|
|
port_del_ifaces(struct port *port)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2011-03-30 11:03:16 -07:00
|
|
|
|
struct iface *iface, *next;
|
|
|
|
|
struct sset new_ifaces;
|
|
|
|
|
size_t i;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-03-30 11:03:16 -07:00
|
|
|
|
/* Collect list of new interfaces. */
|
|
|
|
|
sset_init(&new_ifaces);
|
2011-05-11 12:26:06 -07:00
|
|
|
|
for (i = 0; i < port->cfg->n_interfaces; i++) {
|
2018-03-09 10:45:04 -08:00
|
|
|
|
sset_add(&new_ifaces, port->cfg->interfaces[i]->name);
|
2011-03-30 11:03:16 -07:00
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-03-30 11:03:16 -07:00
|
|
|
|
/* Get rid of deleted interfaces. */
|
|
|
|
|
LIST_FOR_EACH_SAFE (iface, next, port_elem, &port->ifaces) {
|
|
|
|
|
if (!sset_contains(&new_ifaces, iface->name)) {
|
|
|
|
|
iface_destroy(iface);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
2011-03-30 11:03:16 -07:00
|
|
|
|
|
|
|
|
|
sset_destroy(&new_ifaces);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
port_destroy(struct port *port)
|
|
|
|
|
{
|
|
|
|
|
if (port) {
|
|
|
|
|
struct bridge *br = port->bridge;
|
2011-03-21 10:24:32 -07:00
|
|
|
|
struct iface *iface, *next;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
if (br->ofproto) {
|
|
|
|
|
ofproto_bundle_unregister(br->ofproto, port);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-03-21 10:24:32 -07:00
|
|
|
|
LIST_FOR_EACH_SAFE (iface, next, port_elem, &port->ifaces) {
|
2013-12-11 17:55:26 -08:00
|
|
|
|
iface_destroy__(iface);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-03-21 10:07:39 -07:00
|
|
|
|
hmap_remove(&br->ports, &port->hmap_node);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
free(port->name);
|
|
|
|
|
free(port);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static struct port *
|
|
|
|
|
port_lookup(const struct bridge *br, const char *name)
|
|
|
|
|
{
|
2011-03-21 10:07:39 -07:00
|
|
|
|
struct port *port;
|
|
|
|
|
|
|
|
|
|
HMAP_FOR_EACH_WITH_HASH (port, hmap_node, hash_string(name, 0),
|
|
|
|
|
&br->ports) {
|
|
|
|
|
if (!strcmp(port->name, name)) {
|
|
|
|
|
return port;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
return NULL;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-03-21 12:49:44 -07:00
|
|
|
|
static bool
|
|
|
|
|
enable_lacp(struct port *port, bool *activep)
|
|
|
|
|
{
|
|
|
|
|
if (!port->cfg->lacp) {
|
|
|
|
|
/* XXX when LACP implementation has been sufficiently tested, enable by
|
|
|
|
|
* default and make active on bonded ports. */
|
|
|
|
|
return false;
|
|
|
|
|
} else if (!strcmp(port->cfg->lacp, "off")) {
|
|
|
|
|
return false;
|
|
|
|
|
} else if (!strcmp(port->cfg->lacp, "active")) {
|
|
|
|
|
*activep = true;
|
|
|
|
|
return true;
|
|
|
|
|
} else if (!strcmp(port->cfg->lacp, "passive")) {
|
|
|
|
|
*activep = false;
|
|
|
|
|
return true;
|
|
|
|
|
} else {
|
|
|
|
|
VLOG_WARN("port %s: unknown LACP mode %s",
|
|
|
|
|
port->name, port->cfg->lacp);
|
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
static struct lacp_settings *
|
|
|
|
|
port_configure_lacp(struct port *port, struct lacp_settings *s)
|
2011-04-13 17:58:26 -07:00
|
|
|
|
{
|
2011-11-29 19:03:52 -08:00
|
|
|
|
const char *lacp_time, *system_id;
|
2011-04-15 09:40:50 -07:00
|
|
|
|
int priority;
|
2011-04-13 17:58:26 -07:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
if (!enable_lacp(port, &s->active)) {
|
|
|
|
|
return NULL;
|
2011-04-15 17:03:37 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
s->name = port->name;
|
2011-11-29 19:03:52 -08:00
|
|
|
|
|
2012-05-22 01:53:07 -07:00
|
|
|
|
system_id = smap_get(&port->cfg->other_config, "lacp-system-id");
|
2011-12-14 16:34:52 -08:00
|
|
|
|
if (system_id) {
|
2013-11-09 15:44:23 -08:00
|
|
|
|
if (!ovs_scan(system_id, ETH_ADDR_SCAN_FMT,
|
|
|
|
|
ETH_ADDR_SCAN_ARGS(s->id))) {
|
2011-12-14 16:34:52 -08:00
|
|
|
|
VLOG_WARN("port %s: LACP system ID (%s) must be an Ethernet"
|
|
|
|
|
" address.", port->name, system_id);
|
|
|
|
|
return NULL;
|
|
|
|
|
}
|
|
|
|
|
} else {
|
2015-08-28 14:55:11 -07:00
|
|
|
|
s->id = port->bridge->ea;
|
2011-11-29 19:03:52 -08:00
|
|
|
|
}
|
2011-04-15 09:40:50 -07:00
|
|
|
|
|
2011-11-29 13:22:18 -08:00
|
|
|
|
if (eth_addr_is_zero(s->id)) {
|
|
|
|
|
VLOG_WARN("port %s: Invalid zero LACP system ID.", port->name);
|
|
|
|
|
return NULL;
|
|
|
|
|
}
|
|
|
|
|
|
2011-04-15 09:40:50 -07:00
|
|
|
|
/* Prefer bondable links if unspecified. */
|
2012-05-22 01:53:07 -07:00
|
|
|
|
priority = smap_get_int(&port->cfg->other_config, "lacp-system-priority",
|
|
|
|
|
0);
|
2011-05-11 12:26:06 -07:00
|
|
|
|
s->priority = (priority > 0 && priority <= UINT16_MAX
|
|
|
|
|
? priority
|
2016-03-25 14:10:22 -07:00
|
|
|
|
: UINT16_MAX - !ovs_list_is_short(&port->ifaces));
|
2011-04-15 09:40:50 -07:00
|
|
|
|
|
2016-07-20 16:44:09 -07:00
|
|
|
|
lacp_time = smap_get_def(&port->cfg->other_config, "lacp-time", "");
|
|
|
|
|
s->fast = !strcasecmp(lacp_time, "fast");
|
2013-11-04 23:07:10 +00:00
|
|
|
|
|
|
|
|
|
s->fallback_ab_cfg = smap_get_bool(&port->cfg->other_config,
|
|
|
|
|
"lacp-fallback-ab", false);
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
return s;
|
|
|
|
|
}
|
2011-04-13 17:58:26 -07:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
static void
|
|
|
|
|
iface_configure_lacp(struct iface *iface, struct lacp_slave_settings *s)
|
|
|
|
|
{
|
2011-05-12 12:05:42 -07:00
|
|
|
|
int priority, portid, key;
|
2011-04-13 17:58:26 -07:00
|
|
|
|
|
2012-05-22 01:53:07 -07:00
|
|
|
|
portid = smap_get_int(&iface->cfg->other_config, "lacp-port-id", 0);
|
|
|
|
|
priority = smap_get_int(&iface->cfg->other_config, "lacp-port-priority",
|
|
|
|
|
0);
|
|
|
|
|
key = smap_get_int(&iface->cfg->other_config, "lacp-aggregation-key", 0);
|
2011-05-11 12:26:06 -07:00
|
|
|
|
|
|
|
|
|
if (portid <= 0 || portid > UINT16_MAX) {
|
2013-06-19 16:58:44 -07:00
|
|
|
|
portid = ofp_to_u16(iface->ofp_port);
|
2011-04-13 17:58:26 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
if (priority <= 0 || priority > UINT16_MAX) {
|
|
|
|
|
priority = UINT16_MAX;
|
|
|
|
|
}
|
2011-04-13 17:58:26 -07:00
|
|
|
|
|
2011-05-12 12:05:42 -07:00
|
|
|
|
if (key < 0 || key > UINT16_MAX) {
|
|
|
|
|
key = 0;
|
2011-04-13 17:58:26 -07:00
|
|
|
|
}
|
2011-05-12 12:05:42 -07:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
s->name = iface->name;
|
|
|
|
|
s->id = portid;
|
|
|
|
|
s->priority = priority;
|
2011-05-12 12:05:42 -07:00
|
|
|
|
s->key = key;
|
2011-03-21 14:30:33 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-01-18 18:46:58 -08:00
|
|
|
|
static void
|
2013-02-04 18:28:57 -08:00
|
|
|
|
port_configure_bond(struct port *port, struct bond_settings *s)
|
2011-01-18 18:46:58 -08:00
|
|
|
|
{
|
2011-03-30 11:03:16 -07:00
|
|
|
|
const char *detect_s;
|
2011-03-21 12:49:44 -07:00
|
|
|
|
struct iface *iface;
|
2014-10-04 23:35:30 -07:00
|
|
|
|
const char *mac_s;
|
2011-05-16 14:40:03 -07:00
|
|
|
|
int miimon_interval;
|
2011-01-18 18:46:58 -08:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
s->name = port->name;
|
2012-01-11 17:23:38 -08:00
|
|
|
|
s->balance = BM_AB;
|
2011-12-15 13:39:38 -08:00
|
|
|
|
if (port->cfg->bond_mode) {
|
|
|
|
|
if (!bond_mode_from_string(&s->balance, port->cfg->bond_mode)) {
|
|
|
|
|
VLOG_WARN("port %s: unknown bond_mode %s, defaulting to %s",
|
|
|
|
|
port->name, port->cfg->bond_mode,
|
|
|
|
|
bond_mode_to_string(s->balance));
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 1);
|
|
|
|
|
|
2012-01-11 17:23:38 -08:00
|
|
|
|
/* XXX: Post version 1.5.*, the default bond_mode changed from SLB to
|
|
|
|
|
* active-backup. At some point we should remove this warning. */
|
2011-12-15 13:39:38 -08:00
|
|
|
|
VLOG_WARN_RL(&rl, "port %s: Using the default bond_mode %s. Note that"
|
2012-01-11 17:23:38 -08:00
|
|
|
|
" in previous versions, the default bond_mode was"
|
|
|
|
|
" balance-slb", port->name,
|
2011-12-15 13:39:38 -08:00
|
|
|
|
bond_mode_to_string(s->balance));
|
2011-03-30 11:03:16 -07:00
|
|
|
|
}
|
2011-08-05 16:58:02 -07:00
|
|
|
|
if (s->balance == BM_SLB && port->bridge->cfg->n_flood_vlans) {
|
|
|
|
|
VLOG_WARN("port %s: SLB bonds are incompatible with flood_vlans, "
|
|
|
|
|
"please use another bond type or disable flood_vlans",
|
|
|
|
|
port->name);
|
|
|
|
|
}
|
2011-03-21 14:30:33 -07:00
|
|
|
|
|
2012-05-22 01:53:07 -07:00
|
|
|
|
miimon_interval = smap_get_int(&port->cfg->other_config,
|
|
|
|
|
"bond-miimon-interval", 0);
|
2011-05-16 14:40:03 -07:00
|
|
|
|
if (miimon_interval <= 0) {
|
|
|
|
|
miimon_interval = 200;
|
2011-03-30 11:03:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2012-05-22 01:53:07 -07:00
|
|
|
|
detect_s = smap_get(&port->cfg->other_config, "bond-detect-mode");
|
|
|
|
|
if (!detect_s || !strcmp(detect_s, "carrier")) {
|
2011-05-16 14:40:03 -07:00
|
|
|
|
miimon_interval = 0;
|
|
|
|
|
} else if (strcmp(detect_s, "miimon")) {
|
|
|
|
|
VLOG_WARN("port %s: unsupported bond-detect-mode %s, "
|
|
|
|
|
"defaulting to carrier", port->name, detect_s);
|
|
|
|
|
miimon_interval = 0;
|
2011-03-30 11:03:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
s->up_delay = MAX(0, port->cfg->bond_updelay);
|
|
|
|
|
s->down_delay = MAX(0, port->cfg->bond_downdelay);
|
2012-05-22 01:53:07 -07:00
|
|
|
|
s->basis = smap_get_int(&port->cfg->other_config, "bond-hash-basis", 0);
|
|
|
|
|
s->rebalance_interval = smap_get_int(&port->cfg->other_config,
|
|
|
|
|
"bond-rebalance-interval", 10000);
|
2012-01-25 17:41:44 -08:00
|
|
|
|
if (s->rebalance_interval && s->rebalance_interval < 1000) {
|
2011-05-11 12:26:06 -07:00
|
|
|
|
s->rebalance_interval = 1000;
|
2011-03-30 11:03:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2013-11-04 23:07:10 +00:00
|
|
|
|
s->lacp_fallback_ab_cfg = smap_get_bool(&port->cfg->other_config,
|
|
|
|
|
"lacp-fallback-ab", false);
|
|
|
|
|
|
2011-03-21 12:49:44 -07:00
|
|
|
|
LIST_FOR_EACH (iface, port_elem, &port->ifaces) {
|
2011-05-16 14:40:03 -07:00
|
|
|
|
netdev_set_miimon_interval(iface->netdev, miimon_interval);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2014-10-04 23:35:30 -07:00
|
|
|
|
|
|
|
|
|
mac_s = port->cfg->bond_active_slave;
|
|
|
|
|
if (!mac_s || !ovs_scan(mac_s, ETH_ADDR_SCAN_FMT,
|
|
|
|
|
ETH_ADDR_SCAN_ARGS(s->active_slave_mac))) {
|
|
|
|
|
/* OVSDB did not store the last active interface */
|
2015-08-28 14:55:11 -07:00
|
|
|
|
s->active_slave_mac = eth_addr_zero;
|
2014-10-04 23:35:30 -07:00
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2011-10-26 11:39:46 -07:00
|
|
|
|
|
|
|
|
|
/* Returns true if 'port' is synthetic, that is, if we constructed it locally
|
|
|
|
|
* instead of obtaining it from the database. */
|
|
|
|
|
static bool
|
|
|
|
|
port_is_synthetic(const struct port *port)
|
|
|
|
|
{
|
|
|
|
|
return ovsdb_idl_row_is_synthetic(&port->cfg->header_);
|
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
|
|
|
|
/* Interface functions. */
|
|
|
|
|
|
2012-11-15 13:53:16 -08:00
|
|
|
|
static bool
|
|
|
|
|
iface_is_internal(const struct ovsrec_interface *iface,
|
|
|
|
|
const struct ovsrec_bridge *br)
|
|
|
|
|
{
|
|
|
|
|
/* The local port and "internal" ports are always "internal". */
|
|
|
|
|
return !strcmp(iface->type, "internal") || !strcmp(iface->name, br->name);
|
|
|
|
|
}
|
|
|
|
|
|
2012-04-24 15:59:42 -07:00
|
|
|
|
/* Returns the correct network device type for interface 'iface' in bridge
|
|
|
|
|
* 'br'. */
|
|
|
|
|
static const char *
|
|
|
|
|
iface_get_type(const struct ovsrec_interface *iface,
|
|
|
|
|
const struct ovsrec_bridge *br)
|
|
|
|
|
{
|
2012-11-14 15:49:47 -08:00
|
|
|
|
const char *type;
|
|
|
|
|
|
|
|
|
|
/* The local port always has type "internal". Other ports take
|
|
|
|
|
* their type from the database and default to "system" if none is
|
|
|
|
|
* specified. */
|
2012-11-15 13:53:16 -08:00
|
|
|
|
if (iface_is_internal(iface, br)) {
|
2012-11-14 15:49:47 -08:00
|
|
|
|
type = "internal";
|
2012-10-30 17:41:22 -07:00
|
|
|
|
} else {
|
2012-11-14 15:49:47 -08:00
|
|
|
|
type = iface->type[0] ? iface->type : "system";
|
2012-10-30 17:41:22 -07:00
|
|
|
|
}
|
2012-11-14 15:49:47 -08:00
|
|
|
|
|
2016-07-04 15:19:56 -03:00
|
|
|
|
return type;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
2013-12-11 17:55:26 -08:00
|
|
|
|
iface_destroy__(struct iface *iface)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
|
|
|
|
if (iface) {
|
|
|
|
|
struct port *port = iface->port;
|
|
|
|
|
struct bridge *br = port->bridge;
|
2011-03-21 13:25:02 -07:00
|
|
|
|
|
2017-04-20 17:33:28 -07:00
|
|
|
|
VLOG_INFO("bridge %s: deleted interface %s on port %d",
|
|
|
|
|
br->name, iface->name, iface->ofp_port);
|
|
|
|
|
|
2013-06-04 12:46:38 -07:00
|
|
|
|
if (br->ofproto && iface->ofp_port != OFPP_NONE) {
|
2011-05-09 09:24:39 -07:00
|
|
|
|
ofproto_port_unregister(br->ofproto, iface->ofp_port);
|
2011-04-13 17:58:26 -07:00
|
|
|
|
}
|
|
|
|
|
|
2013-06-04 12:46:38 -07:00
|
|
|
|
if (iface->ofp_port != OFPP_NONE) {
|
2011-05-09 09:24:39 -07:00
|
|
|
|
hmap_remove(&br->ifaces, &iface->ofp_port_node);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2016-03-25 14:10:22 -07:00
|
|
|
|
ovs_list_remove(&iface->port_elem);
|
2011-04-01 11:42:25 -07:00
|
|
|
|
hmap_remove(&br->iface_by_name, &iface->name_node);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
bridge: Clean leaking netdevs when route is added.
When adding a route to a bridge, by executing "$appctl ovs/route/add
$IP/$MASK $BR", a reference to the existing netdev is taken and stored
in an instantiated ip_dev struct which is then stored in an addr_list
list in tnl-ports.c. When OvS is signaled to exit, as a result of a
"$appctl $OVS_PID exit --cleanup", for example, the bridge takes care of
destroying its allocated port and iface structs. While destroying and
freeing an iface, the netdev associated with it is also destroyed.
However, for this to happen its ref_cnt must be 0. Otherwise the
destructor of the netdev (specific to each datapath) won't be called. On
the userspace datapath this means a system interface, such as "br0",
wouldn't get deleted upon exit of OvS (when a route happens to be
assocaited).
This was first observed in the "ptap - triangle bridge setup with L2 and
L3 GRE tunnels" test, which runs as part of the system userspace
testsuite and uses the netdev datapath (as opoosed to several tests
which use the dummy datapath, where this issue isn't seen). The test
would pass every other time and fail the rest of the times because the
needed system interfaces (br-p1, br-p2 and br-p3) were already present
(from the previous successfull run which didn't clean up properly),
leading to a failure.
To fix the leak and clean up the interfaces upon exit, on its final
stage before destroying a netdev, in iface_destroy__(), the bridge calls
tnl_port_map_delete_ipdev() which takes care of freeing the instatiated
ip_dev structs that refer to a specific netdev.
An extra test is also introduced which verifies that the resources used
by OvS netdev datapath have been correctly cleaned up between
OVS_TRAFFIC_VSWITCHD_STOP and AT_CLEANUP.
Signed-off-by: Tiago Lam <tiago.lam@intel.com>
Signed-off-by: Ben Pfaff <blp@ovn.org>
2018-06-21 18:39:16 +01:00
|
|
|
|
tnl_port_map_delete_ipdev(netdev_get_name(iface->netdev));
|
|
|
|
|
|
2014-05-16 02:17:58 -07:00
|
|
|
|
/* The user is changing configuration here, so netdev_remove needs to be
|
|
|
|
|
* used as opposed to netdev_close */
|
|
|
|
|
netdev_remove(iface->netdev);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2009-12-05 16:01:06 -08:00
|
|
|
|
free(iface->name);
|
|
|
|
|
free(iface);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2013-12-11 17:55:26 -08:00
|
|
|
|
static void
|
|
|
|
|
iface_destroy(struct iface *iface)
|
|
|
|
|
{
|
|
|
|
|
if (iface) {
|
|
|
|
|
struct port *port = iface->port;
|
|
|
|
|
|
|
|
|
|
iface_destroy__(iface);
|
2016-03-25 14:10:22 -07:00
|
|
|
|
if (ovs_list_is_empty(&port->ifaces)) {
|
2013-12-11 17:55:26 -08:00
|
|
|
|
port_destroy(port);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static struct iface *
|
|
|
|
|
iface_lookup(const struct bridge *br, const char *name)
|
|
|
|
|
{
|
2011-04-01 11:42:25 -07:00
|
|
|
|
struct iface *iface;
|
|
|
|
|
|
|
|
|
|
HMAP_FOR_EACH_WITH_HASH (iface, name_node, hash_string(name, 0),
|
|
|
|
|
&br->iface_by_name) {
|
|
|
|
|
if (!strcmp(iface->name, name)) {
|
|
|
|
|
return iface;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return NULL;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-03-11 13:44:16 -08:00
|
|
|
|
static struct iface *
|
|
|
|
|
iface_find(const char *name)
|
|
|
|
|
{
|
|
|
|
|
const struct bridge *br;
|
|
|
|
|
|
2011-04-04 14:11:16 -07:00
|
|
|
|
HMAP_FOR_EACH (br, node, &all_bridges) {
|
2011-03-11 13:44:16 -08:00
|
|
|
|
struct iface *iface = iface_lookup(br, name);
|
|
|
|
|
|
|
|
|
|
if (iface) {
|
|
|
|
|
return iface;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
return NULL;
|
|
|
|
|
}
|
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static struct iface *
|
2013-06-19 16:58:44 -07:00
|
|
|
|
iface_from_ofp_port(const struct bridge *br, ofp_port_t ofp_port)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2010-07-19 11:23:05 -07:00
|
|
|
|
struct iface *iface;
|
|
|
|
|
|
2013-06-22 10:33:27 -07:00
|
|
|
|
HMAP_FOR_EACH_IN_BUCKET (iface, ofp_port_node, hash_ofp_port(ofp_port),
|
2013-06-19 16:58:44 -07:00
|
|
|
|
&br->ifaces) {
|
2011-05-09 09:24:39 -07:00
|
|
|
|
if (iface->ofp_port == ofp_port) {
|
2010-07-19 11:23:05 -07:00
|
|
|
|
return iface;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
return NULL;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2009-10-02 10:41:05 -07:00
|
|
|
|
|
2009-10-02 13:29:01 -07:00
|
|
|
|
/* Set Ethernet address of 'iface', if one is specified in the configuration
|
|
|
|
|
* file. */
|
|
|
|
|
static void
|
2014-02-19 11:59:33 +01:00
|
|
|
|
iface_set_mac(const struct bridge *br, const struct port *port, struct iface *iface)
|
2009-10-02 13:29:01 -07:00
|
|
|
|
{
|
2015-08-28 14:55:11 -07:00
|
|
|
|
struct eth_addr ea, *mac = NULL;
|
2014-02-19 11:59:33 +01:00
|
|
|
|
struct iface *hw_addr_iface;
|
2009-10-02 13:29:01 -07:00
|
|
|
|
|
2013-12-06 16:18:42 +01:00
|
|
|
|
if (strcmp(iface->type, "internal")) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2015-08-28 14:55:11 -07:00
|
|
|
|
if (iface->cfg->mac && eth_addr_from_string(iface->cfg->mac, &ea)) {
|
|
|
|
|
mac = &ea;
|
2014-02-19 11:59:33 +01:00
|
|
|
|
} else if (port->cfg->fake_bridge) {
|
|
|
|
|
/* Fake bridge and no MAC set in the configuration. Pick a local one. */
|
2015-08-28 14:55:11 -07:00
|
|
|
|
find_local_hw_addr(br, &ea, port, &hw_addr_iface);
|
|
|
|
|
mac = &ea;
|
2013-12-06 16:18:42 +01:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (mac) {
|
2011-05-09 09:24:39 -07:00
|
|
|
|
if (iface->ofp_port == OFPP_LOCAL) {
|
2011-03-29 11:16:31 -07:00
|
|
|
|
VLOG_ERR("interface %s: ignoring mac in Interface record "
|
|
|
|
|
"(use Bridge record to set local port's mac)",
|
|
|
|
|
iface->name);
|
2015-08-28 14:55:11 -07:00
|
|
|
|
} else if (eth_addr_is_multicast(*mac)) {
|
2009-10-02 13:29:01 -07:00
|
|
|
|
VLOG_ERR("interface %s: cannot set MAC to multicast address",
|
|
|
|
|
iface->name);
|
2017-06-29 17:16:51 +08:00
|
|
|
|
} else if (eth_addr_is_zero(*mac)) {
|
|
|
|
|
VLOG_ERR("interface %s: cannot set MAC to all zero address",
|
|
|
|
|
iface->name);
|
2009-10-02 13:29:01 -07:00
|
|
|
|
} else {
|
2015-08-28 14:55:11 -07:00
|
|
|
|
int error = netdev_set_etheraddr(iface->netdev, *mac);
|
2009-10-02 13:29:01 -07:00
|
|
|
|
if (error) {
|
|
|
|
|
VLOG_ERR("interface %s: setting MAC failed (%s)",
|
2013-06-24 10:54:49 -07:00
|
|
|
|
iface->name, ovs_strerror(error));
|
2009-10-02 13:29:01 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
2010-06-17 15:04:12 -07:00
|
|
|
|
|
2010-10-22 13:42:40 -07:00
|
|
|
|
/* Sets the ofport column of 'if_cfg' to 'ofport'. */
|
|
|
|
|
static void
|
2013-06-19 16:58:44 -07:00
|
|
|
|
iface_set_ofport(const struct ovsrec_interface *if_cfg, ofp_port_t ofport)
|
2010-10-22 13:42:40 -07:00
|
|
|
|
{
|
2011-04-13 11:10:44 -07:00
|
|
|
|
if (if_cfg && !ovsdb_idl_row_is_synthetic(&if_cfg->header_)) {
|
2013-12-05 11:43:50 -08:00
|
|
|
|
int64_t port = ofport == OFPP_NONE ? -1 : ofp_to_u16(ofport);
|
|
|
|
|
ovsrec_interface_set_ofport(if_cfg, &port, 1);
|
2010-10-22 13:42:40 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2011-09-28 09:36:13 -07:00
|
|
|
|
/* Clears all of the fields in 'if_cfg' that indicate interface status, and
|
|
|
|
|
* sets the "ofport" field to -1.
|
|
|
|
|
*
|
|
|
|
|
* This is appropriate when 'if_cfg''s interface cannot be created or is
|
|
|
|
|
* otherwise invalid. */
|
|
|
|
|
static void
|
2014-04-10 12:50:10 +02:00
|
|
|
|
iface_clear_db_record(const struct ovsrec_interface *if_cfg, char *errp)
|
2011-09-28 09:36:13 -07:00
|
|
|
|
{
|
|
|
|
|
if (!ovsdb_idl_row_is_synthetic(&if_cfg->header_)) {
|
2014-01-30 16:57:16 -08:00
|
|
|
|
iface_set_ofport(if_cfg, OFPP_NONE);
|
2014-04-10 12:50:10 +02:00
|
|
|
|
ovsrec_interface_set_error(if_cfg, errp);
|
2012-05-22 01:53:07 -07:00
|
|
|
|
ovsrec_interface_set_status(if_cfg, NULL);
|
2011-09-28 09:36:13 -07:00
|
|
|
|
ovsrec_interface_set_admin_state(if_cfg, NULL);
|
|
|
|
|
ovsrec_interface_set_duplex(if_cfg, NULL);
|
|
|
|
|
ovsrec_interface_set_link_speed(if_cfg, NULL, 0);
|
|
|
|
|
ovsrec_interface_set_link_state(if_cfg, NULL);
|
2013-03-12 14:47:22 -07:00
|
|
|
|
ovsrec_interface_set_mac_in_use(if_cfg, NULL);
|
2011-09-28 09:36:13 -07:00
|
|
|
|
ovsrec_interface_set_mtu(if_cfg, NULL, 0);
|
|
|
|
|
ovsrec_interface_set_cfm_fault(if_cfg, NULL, 0);
|
2012-02-07 14:35:09 -08:00
|
|
|
|
ovsrec_interface_set_cfm_fault_status(if_cfg, NULL, 0);
|
2011-09-28 09:36:13 -07:00
|
|
|
|
ovsrec_interface_set_cfm_remote_mpids(if_cfg, NULL, 0);
|
|
|
|
|
ovsrec_interface_set_lacp_current(if_cfg, NULL, 0);
|
|
|
|
|
ovsrec_interface_set_statistics(if_cfg, NULL, NULL, 0);
|
2013-07-08 13:36:06 -07:00
|
|
|
|
ovsrec_interface_set_ifindex(if_cfg, NULL, 0);
|
2011-09-28 09:36:13 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2010-06-17 15:04:12 -07:00
|
|
|
|
static bool
|
2010-06-17 15:43:27 -07:00
|
|
|
|
queue_ids_include(const struct ovsdb_datum *queues, int64_t target)
|
2010-06-17 15:04:12 -07:00
|
|
|
|
{
|
2010-06-17 15:43:27 -07:00
|
|
|
|
union ovsdb_atom atom;
|
2010-06-17 15:04:12 -07:00
|
|
|
|
|
2010-06-17 15:43:27 -07:00
|
|
|
|
atom.integer = target;
|
|
|
|
|
return ovsdb_datum_find_key(queues, &atom, OVSDB_TYPE_INTEGER) != UINT_MAX;
|
2010-06-17 15:04:12 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
2011-04-08 13:50:21 -07:00
|
|
|
|
iface_configure_qos(struct iface *iface, const struct ovsrec_qos *qos)
|
2010-06-17 15:04:12 -07:00
|
|
|
|
{
|
2011-11-16 16:31:05 -08:00
|
|
|
|
struct ofpbuf queues_buf;
|
|
|
|
|
|
|
|
|
|
ofpbuf_init(&queues_buf, 0);
|
|
|
|
|
|
2015-03-18 17:13:01 +01:00
|
|
|
|
if (!qos || qos->type[0] == '\0') {
|
2010-06-17 15:04:12 -07:00
|
|
|
|
netdev_set_qos(iface->netdev, NULL, NULL);
|
|
|
|
|
} else {
|
2013-08-27 17:15:53 -07:00
|
|
|
|
const struct ovsdb_datum *queues;
|
|
|
|
|
struct netdev_queue_dump dump;
|
|
|
|
|
unsigned int queue_id;
|
|
|
|
|
struct smap details;
|
2011-07-20 10:41:16 -07:00
|
|
|
|
bool queue_zero;
|
2010-06-17 15:04:12 -07:00
|
|
|
|
size_t i;
|
|
|
|
|
|
|
|
|
|
/* Configure top-level Qos for 'iface'. */
|
2012-05-22 01:53:07 -07:00
|
|
|
|
netdev_set_qos(iface->netdev, qos->type, &qos->other_config);
|
2010-06-17 15:04:12 -07:00
|
|
|
|
|
|
|
|
|
/* Deconfigure queues that were deleted. */
|
2013-08-27 17:15:53 -07:00
|
|
|
|
queues = ovsrec_qos_get_queues(qos, OVSDB_TYPE_INTEGER,
|
|
|
|
|
OVSDB_TYPE_UUID);
|
|
|
|
|
smap_init(&details);
|
|
|
|
|
NETDEV_QUEUE_FOR_EACH (&queue_id, &details, &dump, iface->netdev) {
|
|
|
|
|
if (!queue_ids_include(queues, queue_id)) {
|
|
|
|
|
netdev_delete_queue(iface->netdev, queue_id);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
smap_destroy(&details);
|
2010-06-17 15:04:12 -07:00
|
|
|
|
|
|
|
|
|
/* Configure queues for 'iface'. */
|
2011-07-20 10:41:16 -07:00
|
|
|
|
queue_zero = false;
|
2010-06-17 15:04:12 -07:00
|
|
|
|
for (i = 0; i < qos->n_queues; i++) {
|
|
|
|
|
const struct ovsrec_queue *queue = qos->value_queues[i];
|
2017-08-02 15:03:06 -07:00
|
|
|
|
queue_id = qos->key_queues[i];
|
2010-06-17 15:04:12 -07:00
|
|
|
|
|
2011-07-20 10:41:16 -07:00
|
|
|
|
if (queue_id == 0) {
|
|
|
|
|
queue_zero = true;
|
|
|
|
|
}
|
|
|
|
|
|
2011-11-16 16:31:05 -08:00
|
|
|
|
if (queue->n_dscp == 1) {
|
|
|
|
|
struct ofproto_port_queue *port_queue;
|
|
|
|
|
|
|
|
|
|
port_queue = ofpbuf_put_uninit(&queues_buf,
|
|
|
|
|
sizeof *port_queue);
|
|
|
|
|
port_queue->queue = queue_id;
|
|
|
|
|
port_queue->dscp = queue->dscp[0];
|
|
|
|
|
}
|
|
|
|
|
|
2012-05-22 01:53:07 -07:00
|
|
|
|
netdev_set_queue(iface->netdev, queue_id, &queue->other_config);
|
2010-06-17 15:04:12 -07:00
|
|
|
|
}
|
2011-07-20 10:41:16 -07:00
|
|
|
|
if (!queue_zero) {
|
2012-05-22 03:47:36 -07:00
|
|
|
|
smap_init(&details);
|
2012-02-16 16:33:14 -08:00
|
|
|
|
netdev_set_queue(iface->netdev, 0, &details);
|
2012-05-22 03:47:36 -07:00
|
|
|
|
smap_destroy(&details);
|
2011-07-20 10:41:16 -07:00
|
|
|
|
}
|
2010-06-17 15:04:12 -07:00
|
|
|
|
}
|
2011-05-11 12:26:06 -07:00
|
|
|
|
|
2013-06-04 12:46:38 -07:00
|
|
|
|
if (iface->ofp_port != OFPP_NONE) {
|
2015-03-02 17:29:44 -08:00
|
|
|
|
const struct ofproto_port_queue *port_queues = queues_buf.data;
|
|
|
|
|
size_t n_queues = queues_buf.size / sizeof *port_queues;
|
2011-11-16 16:31:05 -08:00
|
|
|
|
|
|
|
|
|
ofproto_port_set_queues(iface->port->bridge->ofproto, iface->ofp_port,
|
|
|
|
|
port_queues, n_queues);
|
|
|
|
|
}
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
netdev_set_policing(iface->netdev,
|
2015-03-13 11:30:18 -07:00
|
|
|
|
MIN(UINT32_MAX, iface->cfg->ingress_policing_rate),
|
|
|
|
|
MIN(UINT32_MAX, iface->cfg->ingress_policing_burst));
|
2011-11-16 16:31:05 -08:00
|
|
|
|
|
|
|
|
|
ofpbuf_uninit(&queues_buf);
|
2010-06-17 15:04:12 -07:00
|
|
|
|
}
|
2010-11-15 16:20:01 -08:00
|
|
|
|
|
|
|
|
|
static void
|
2011-04-08 13:50:21 -07:00
|
|
|
|
iface_configure_cfm(struct iface *iface)
|
2010-11-15 16:20:01 -08:00
|
|
|
|
{
|
2011-05-12 15:28:43 -07:00
|
|
|
|
const struct ovsrec_interface *cfg = iface->cfg;
|
2012-05-22 01:53:07 -07:00
|
|
|
|
const char *opstate_str;
|
2012-03-09 18:16:20 -08:00
|
|
|
|
const char *cfm_ccm_vlan;
|
2011-05-13 15:37:23 -07:00
|
|
|
|
struct cfm_settings s;
|
2012-10-12 13:19:35 -07:00
|
|
|
|
struct smap netdev_args;
|
2010-11-15 16:20:01 -08:00
|
|
|
|
|
2011-08-19 13:58:56 -07:00
|
|
|
|
if (!cfg->n_cfm_mpid) {
|
2011-05-09 09:24:39 -07:00
|
|
|
|
ofproto_port_clear_cfm(iface->port->bridge->ofproto, iface->ofp_port);
|
2010-11-15 16:20:01 -08:00
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2012-10-12 13:19:35 -07:00
|
|
|
|
s.check_tnl_key = false;
|
|
|
|
|
smap_init(&netdev_args);
|
|
|
|
|
if (!netdev_get_config(iface->netdev, &netdev_args)) {
|
|
|
|
|
const char *key = smap_get(&netdev_args, "key");
|
|
|
|
|
const char *in_key = smap_get(&netdev_args, "in_key");
|
|
|
|
|
|
|
|
|
|
s.check_tnl_key = (key && !strcmp(key, "flow"))
|
|
|
|
|
|| (in_key && !strcmp(in_key, "flow"));
|
|
|
|
|
}
|
|
|
|
|
smap_destroy(&netdev_args);
|
|
|
|
|
|
2011-05-13 15:37:23 -07:00
|
|
|
|
s.mpid = *cfg->cfm_mpid;
|
2012-05-22 01:53:07 -07:00
|
|
|
|
s.interval = smap_get_int(&iface->cfg->other_config, "cfm_interval", 0);
|
|
|
|
|
cfm_ccm_vlan = smap_get(&iface->cfg->other_config, "cfm_ccm_vlan");
|
|
|
|
|
s.ccm_pcp = smap_get_int(&iface->cfg->other_config, "cfm_ccm_pcp", 0);
|
|
|
|
|
|
2011-05-13 15:37:23 -07:00
|
|
|
|
if (s.interval <= 0) {
|
|
|
|
|
s.interval = 1000;
|
2010-11-15 16:20:01 -08:00
|
|
|
|
}
|
|
|
|
|
|
2012-05-22 01:53:07 -07:00
|
|
|
|
if (!cfm_ccm_vlan) {
|
|
|
|
|
s.ccm_vlan = 0;
|
|
|
|
|
} else if (!strcasecmp("random", cfm_ccm_vlan)) {
|
2012-03-09 18:16:20 -08:00
|
|
|
|
s.ccm_vlan = CFM_RANDOM_VLAN;
|
|
|
|
|
} else {
|
|
|
|
|
s.ccm_vlan = atoi(cfm_ccm_vlan);
|
|
|
|
|
if (s.ccm_vlan == CFM_RANDOM_VLAN) {
|
|
|
|
|
s.ccm_vlan = 0;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2012-05-22 01:53:07 -07:00
|
|
|
|
s.extended = smap_get_bool(&iface->cfg->other_config, "cfm_extended",
|
|
|
|
|
false);
|
2013-05-15 14:31:06 -07:00
|
|
|
|
s.demand = smap_get_bool(&iface->cfg->other_config, "cfm_demand", false);
|
2011-08-30 17:37:06 -07:00
|
|
|
|
|
2012-05-22 01:53:07 -07:00
|
|
|
|
opstate_str = smap_get(&iface->cfg->other_config, "cfm_opstate");
|
|
|
|
|
s.opup = !opstate_str || !strcasecmp("up", opstate_str);
|
2011-10-06 22:43:05 -07:00
|
|
|
|
|
2011-05-13 15:37:23 -07:00
|
|
|
|
ofproto_port_set_cfm(iface->port->bridge->ofproto, iface->ofp_port, &s);
|
2010-11-15 16:20:01 -08:00
|
|
|
|
}
|
2011-03-17 10:48:05 -07:00
|
|
|
|
|
2011-04-13 11:10:44 -07:00
|
|
|
|
/* Returns true if 'iface' is synthetic, that is, if we constructed it locally
|
|
|
|
|
* instead of obtaining it from the database. */
|
|
|
|
|
static bool
|
|
|
|
|
iface_is_synthetic(const struct iface *iface)
|
|
|
|
|
{
|
|
|
|
|
return ovsdb_idl_row_is_synthetic(&iface->cfg->header_);
|
|
|
|
|
}
|
2012-03-10 15:58:10 -08:00
|
|
|
|
|
2013-06-19 16:58:44 -07:00
|
|
|
|
static ofp_port_t
|
2013-12-11 15:40:52 -08:00
|
|
|
|
iface_validate_ofport__(size_t n, int64_t *ofport)
|
|
|
|
|
{
|
|
|
|
|
return (n && *ofport >= 1 && *ofport < ofp_to_u16(OFPP_MAX)
|
|
|
|
|
? u16_to_ofp(*ofport)
|
|
|
|
|
: OFPP_NONE);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static ofp_port_t
|
|
|
|
|
iface_get_requested_ofp_port(const struct ovsrec_interface *cfg)
|
2012-11-20 03:34:03 -08:00
|
|
|
|
{
|
2013-12-11 15:40:52 -08:00
|
|
|
|
return iface_validate_ofport__(cfg->n_ofport_request, cfg->ofport_request);
|
2012-11-20 03:34:03 -08:00
|
|
|
|
}
|
|
|
|
|
|
2013-12-11 15:40:52 -08:00
|
|
|
|
static ofp_port_t
|
|
|
|
|
iface_pick_ofport(const struct ovsrec_interface *cfg)
|
|
|
|
|
{
|
|
|
|
|
ofp_port_t requested_ofport = iface_get_requested_ofp_port(cfg);
|
|
|
|
|
return (requested_ofport != OFPP_NONE
|
|
|
|
|
? requested_ofport
|
|
|
|
|
: iface_validate_ofport__(cfg->n_ofport, cfg->ofport));
|
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
|
|
|
|
/* Port mirroring. */
|
|
|
|
|
|
2010-06-17 15:31:56 -07:00
|
|
|
|
static struct mirror *
|
|
|
|
|
mirror_find_by_uuid(struct bridge *br, const struct uuid *uuid)
|
|
|
|
|
{
|
2011-05-11 12:26:06 -07:00
|
|
|
|
struct mirror *m;
|
2010-06-17 15:31:56 -07:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
HMAP_FOR_EACH_IN_BUCKET (m, hmap_node, uuid_hash(uuid), &br->mirrors) {
|
|
|
|
|
if (uuid_equals(uuid, &m->uuid)) {
|
2010-06-17 15:31:56 -07:00
|
|
|
|
return m;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
return NULL;
|
|
|
|
|
}
|
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static void
|
2011-05-11 12:26:06 -07:00
|
|
|
|
bridge_configure_mirrors(struct bridge *br)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2011-05-11 12:26:06 -07:00
|
|
|
|
const struct ovsdb_datum *mc;
|
|
|
|
|
unsigned long *flood_vlans;
|
|
|
|
|
struct mirror *m, *next;
|
|
|
|
|
size_t i;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2010-06-17 15:31:56 -07:00
|
|
|
|
/* Get rid of deleted mirrors. */
|
2011-05-11 12:26:06 -07:00
|
|
|
|
mc = ovsrec_bridge_get_mirrors(br->cfg, OVSDB_TYPE_UUID);
|
|
|
|
|
HMAP_FOR_EACH_SAFE (m, next, hmap_node, &br->mirrors) {
|
|
|
|
|
union ovsdb_atom atom;
|
|
|
|
|
|
|
|
|
|
atom.uuid = m->uuid;
|
|
|
|
|
if (ovsdb_datum_find_key(mc, &atom, OVSDB_TYPE_UUID) == UINT_MAX) {
|
|
|
|
|
mirror_destroy(m);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2010-06-17 15:31:56 -07:00
|
|
|
|
/* Add new mirrors and reconfigure existing ones. */
|
2010-01-19 10:40:36 -08:00
|
|
|
|
for (i = 0; i < br->cfg->n_mirrors; i++) {
|
2011-05-11 12:26:06 -07:00
|
|
|
|
const struct ovsrec_mirror *cfg = br->cfg->mirrors[i];
|
2017-08-02 15:03:06 -07:00
|
|
|
|
m = mirror_find_by_uuid(br, &cfg->header_.uuid);
|
2011-05-11 12:26:06 -07:00
|
|
|
|
if (!m) {
|
|
|
|
|
m = mirror_create(br, cfg);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2011-11-20 15:12:36 -08:00
|
|
|
|
m->cfg = cfg;
|
|
|
|
|
if (!mirror_configure(m)) {
|
2011-05-11 12:26:06 -07:00
|
|
|
|
mirror_destroy(m);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
2009-11-06 17:13:51 -08:00
|
|
|
|
|
2010-01-19 10:41:46 -08:00
|
|
|
|
/* Update flooded vlans (for RSPAN). */
|
2011-05-11 12:26:06 -07:00
|
|
|
|
flood_vlans = vlan_bitmap_from_array(br->cfg->flood_vlans,
|
|
|
|
|
br->cfg->n_flood_vlans);
|
|
|
|
|
ofproto_set_flood_vlans(br->ofproto, flood_vlans);
|
|
|
|
|
bitmap_free(flood_vlans);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
static struct mirror *
|
|
|
|
|
mirror_create(struct bridge *br, const struct ovsrec_mirror *cfg)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
|
|
|
|
struct mirror *m;
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
m = xzalloc(sizeof *m);
|
2011-04-05 14:17:55 -07:00
|
|
|
|
m->uuid = cfg->header_.uuid;
|
2011-05-11 12:26:06 -07:00
|
|
|
|
hmap_insert(&br->mirrors, &m->hmap_node, uuid_hash(&m->uuid));
|
2009-07-08 13:19:16 -07:00
|
|
|
|
m->bridge = br;
|
2010-06-17 15:31:56 -07:00
|
|
|
|
m->name = xstrdup(cfg->name);
|
2010-01-19 10:40:36 -08:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
return m;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
mirror_destroy(struct mirror *m)
|
|
|
|
|
{
|
|
|
|
|
if (m) {
|
|
|
|
|
struct bridge *br = m->bridge;
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
if (br->ofproto) {
|
|
|
|
|
ofproto_mirror_unregister(br->ofproto, m);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
hmap_remove(&br->mirrors, &m->hmap_node);
|
2010-06-17 15:32:09 -07:00
|
|
|
|
free(m->name);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
free(m);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
2011-05-11 12:26:06 -07:00
|
|
|
|
mirror_collect_ports(struct mirror *m,
|
|
|
|
|
struct ovsrec_port **in_ports, int n_in_ports,
|
|
|
|
|
void ***out_portsp, size_t *n_out_portsp)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2011-05-11 12:26:06 -07:00
|
|
|
|
void **out_ports = xmalloc(n_in_ports * sizeof *out_ports);
|
|
|
|
|
size_t n_out_ports = 0;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
size_t i;
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
for (i = 0; i < n_in_ports; i++) {
|
|
|
|
|
const char *name = in_ports[i]->name;
|
|
|
|
|
struct port *port = port_lookup(m->bridge, name);
|
|
|
|
|
if (port) {
|
|
|
|
|
out_ports[n_out_ports++] = port;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
} else {
|
2010-01-19 10:40:36 -08:00
|
|
|
|
VLOG_WARN("bridge %s: mirror %s cannot match on nonexistent "
|
|
|
|
|
"port %s", m->bridge->name, m->name, name);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
2011-05-11 12:26:06 -07:00
|
|
|
|
*out_portsp = out_ports;
|
|
|
|
|
*n_out_portsp = n_out_ports;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static bool
|
2011-11-20 15:12:36 -08:00
|
|
|
|
mirror_configure(struct mirror *m)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2011-11-20 15:12:36 -08:00
|
|
|
|
const struct ovsrec_mirror *cfg = m->cfg;
|
2011-05-11 12:26:06 -07:00
|
|
|
|
struct ofproto_mirror_settings s;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2010-06-17 15:31:56 -07:00
|
|
|
|
/* Set name. */
|
|
|
|
|
if (strcmp(cfg->name, m->name)) {
|
|
|
|
|
free(m->name);
|
|
|
|
|
m->name = xstrdup(cfg->name);
|
|
|
|
|
}
|
2011-05-11 12:26:06 -07:00
|
|
|
|
s.name = m->name;
|
2010-06-17 15:31:56 -07:00
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
/* Get output port or VLAN. */
|
2010-01-19 10:40:36 -08:00
|
|
|
|
if (cfg->output_port) {
|
2011-05-11 12:26:06 -07:00
|
|
|
|
s.out_bundle = port_lookup(m->bridge, cfg->output_port->name);
|
2011-05-11 12:13:10 -07:00
|
|
|
|
if (!s.out_bundle) {
|
2010-01-19 10:40:36 -08:00
|
|
|
|
VLOG_ERR("bridge %s: mirror %s outputs to port not on bridge",
|
|
|
|
|
m->bridge->name, m->name);
|
2011-05-11 12:26:06 -07:00
|
|
|
|
return false;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2011-05-11 12:26:06 -07:00
|
|
|
|
s.out_vlan = UINT16_MAX;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2010-01-19 10:40:36 -08:00
|
|
|
|
if (cfg->output_vlan) {
|
|
|
|
|
VLOG_ERR("bridge %s: mirror %s specifies both output port and "
|
|
|
|
|
"output vlan; ignoring output vlan",
|
|
|
|
|
m->bridge->name, m->name);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2010-01-19 10:40:36 -08:00
|
|
|
|
} else if (cfg->output_vlan) {
|
2011-05-11 12:26:06 -07:00
|
|
|
|
/* The database should prevent invalid VLAN values. */
|
|
|
|
|
s.out_bundle = NULL;
|
|
|
|
|
s.out_vlan = *cfg->output_vlan;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
} else {
|
2010-01-19 10:40:36 -08:00
|
|
|
|
VLOG_ERR("bridge %s: mirror %s does not specify output; ignoring",
|
|
|
|
|
m->bridge->name, m->name);
|
2011-05-11 12:26:06 -07:00
|
|
|
|
return false;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2016-06-29 14:38:02 -07:00
|
|
|
|
if (cfg->snaplen) {
|
|
|
|
|
s.snaplen = *cfg->snaplen;
|
|
|
|
|
} else {
|
|
|
|
|
s.snaplen = 0;
|
|
|
|
|
}
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
/* Get port selection. */
|
2010-03-15 15:23:22 -07:00
|
|
|
|
if (cfg->select_all) {
|
2011-05-11 12:26:06 -07:00
|
|
|
|
size_t n_ports = hmap_count(&m->bridge->ports);
|
|
|
|
|
void **ports = xmalloc(n_ports * sizeof *ports);
|
2011-05-11 12:13:10 -07:00
|
|
|
|
struct port *port;
|
2011-05-11 12:26:06 -07:00
|
|
|
|
size_t i;
|
|
|
|
|
|
|
|
|
|
i = 0;
|
2011-03-21 10:07:39 -07:00
|
|
|
|
HMAP_FOR_EACH (port, hmap_node, &m->bridge->ports) {
|
2011-05-11 12:26:06 -07:00
|
|
|
|
ports[i++] = port;
|
2010-03-15 15:23:22 -07:00
|
|
|
|
}
|
2011-05-11 12:26:06 -07:00
|
|
|
|
|
|
|
|
|
s.srcs = ports;
|
|
|
|
|
s.n_srcs = n_ports;
|
|
|
|
|
|
|
|
|
|
s.dsts = ports;
|
|
|
|
|
s.n_dsts = n_ports;
|
2010-03-15 15:23:22 -07:00
|
|
|
|
} else {
|
2011-05-11 12:26:06 -07:00
|
|
|
|
/* Get ports, dropping ports that don't exist.
|
|
|
|
|
* The IDL ensures that there are no duplicates. */
|
2010-03-15 15:23:22 -07:00
|
|
|
|
mirror_collect_ports(m, cfg->select_src_port, cfg->n_select_src_port,
|
2011-05-11 12:26:06 -07:00
|
|
|
|
&s.srcs, &s.n_srcs);
|
2010-03-15 15:23:22 -07:00
|
|
|
|
mirror_collect_ports(m, cfg->select_dst_port, cfg->n_select_dst_port,
|
2011-05-11 12:26:06 -07:00
|
|
|
|
&s.dsts, &s.n_dsts);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-05-11 12:26:06 -07:00
|
|
|
|
/* Get VLAN selection. */
|
|
|
|
|
s.src_vlans = vlan_bitmap_from_array(cfg->select_vlan, cfg->n_select_vlan);
|
|
|
|
|
|
|
|
|
|
/* Configure. */
|
|
|
|
|
ofproto_mirror_register(m->bridge->ofproto, m, &s);
|
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
/* Clean up. */
|
2011-05-11 12:26:06 -07:00
|
|
|
|
if (s.srcs != s.dsts) {
|
|
|
|
|
free(s.dsts);
|
|
|
|
|
}
|
|
|
|
|
free(s.srcs);
|
|
|
|
|
free(s.src_vlans);
|
|
|
|
|
|
|
|
|
|
return true;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2011-11-20 15:12:36 -08:00
|
|
|
|
|
2016-04-25 11:27:58 -07:00
|
|
|
|
|
2011-11-20 15:12:36 -08:00
|
|
|
|
static void
|
|
|
|
|
mirror_refresh_stats(struct mirror *m)
|
|
|
|
|
{
|
|
|
|
|
struct ofproto *ofproto = m->bridge->ofproto;
|
|
|
|
|
uint64_t tx_packets, tx_bytes;
|
2015-02-19 13:10:51 -05:00
|
|
|
|
const char *keys[2];
|
2011-11-20 15:12:36 -08:00
|
|
|
|
int64_t values[2];
|
|
|
|
|
size_t stat_cnt = 0;
|
|
|
|
|
|
|
|
|
|
if (ofproto_mirror_get_stats(ofproto, m, &tx_packets, &tx_bytes)) {
|
|
|
|
|
ovsrec_mirror_set_statistics(m->cfg, NULL, NULL, 0);
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (tx_packets != UINT64_MAX) {
|
|
|
|
|
keys[stat_cnt] = "tx_packets";
|
|
|
|
|
values[stat_cnt] = tx_packets;
|
|
|
|
|
stat_cnt++;
|
|
|
|
|
}
|
|
|
|
|
if (tx_bytes != UINT64_MAX) {
|
|
|
|
|
keys[stat_cnt] = "tx_bytes";
|
|
|
|
|
values[stat_cnt] = tx_bytes;
|
|
|
|
|
stat_cnt++;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
ovsrec_mirror_set_statistics(m->cfg, keys, values, stat_cnt);
|
|
|
|
|
}
|
2015-03-24 10:39:11 +00:00
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Add registered netdev and dpif types to ovsdb to allow external
|
|
|
|
|
* applications to query the capabilities of the Open vSwitch instance
|
|
|
|
|
* running on the node.
|
|
|
|
|
*/
|
|
|
|
|
static void
|
|
|
|
|
discover_types(const struct ovsrec_open_vswitch *cfg)
|
|
|
|
|
{
|
|
|
|
|
struct sset types;
|
|
|
|
|
|
|
|
|
|
/* Datapath types. */
|
|
|
|
|
sset_init(&types);
|
|
|
|
|
dp_enumerate_types(&types);
|
|
|
|
|
const char **datapath_types = sset_array(&types);
|
|
|
|
|
ovsrec_open_vswitch_set_datapath_types(cfg, datapath_types,
|
|
|
|
|
sset_count(&types));
|
|
|
|
|
free(datapath_types);
|
|
|
|
|
sset_destroy(&types);
|
|
|
|
|
|
|
|
|
|
/* Port types. */
|
|
|
|
|
sset_init(&types);
|
|
|
|
|
netdev_enumerate_types(&types);
|
|
|
|
|
const char **iface_types = sset_array(&types);
|
|
|
|
|
ovsrec_open_vswitch_set_iface_types(cfg, iface_types, sset_count(&types));
|
|
|
|
|
free(iface_types);
|
|
|
|
|
sset_destroy(&types);
|
|
|
|
|
}
|