mir/openvswitch
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-10-27 15:18:06 +00:00
Code Issues Releases Wiki Activity

Avoid shadowing local variable names.

Browse Source 
All of these changes avoid using the same name for two local variables
within a same function.  None of them are actual bugs as far as I can tell,
but any of them could be confusing to the casual reader.

The one in lib/ovsdb-idl.c is particularly brilliant: inner and outer
loops both using (different) variables named 'i'.

Found with GCC -Wshadow.
This commit is contained in:
Ben Pfaff
2010-09-02 10:09:09 -07:00
parent 1089aab713
commit 2a022368f4
19 changed files with 41 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/netdev-linux.c
View File

@@ -1779,12 +1779,12 @@ netdev_linux_get_in6(const struct netdev *netdev_, struct in6_addr *in6)
if (file != NULL) {
const char *name = netdev_get_name(netdev_);
while (fgets(line, sizeof line, file)) {
struct in6_addr in6;
struct in6_addr in6_tmp;
char ifname[16 + 1];
if (parse_if_inet6_line(line, &in6, ifname)
if (parse_if_inet6_line(line, &in6_tmp, ifname)
&& !strcmp(name, ifname))
{
netdev_dev->in6 = in6;
netdev_dev->in6 = in6_tmp;
break;
}
}