mir/openvswitch
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-10-23 14:57:06 +00:00
Code Issues Releases Wiki Activity

xenserver: Validate controller IP address in xsconsole

Browse Source 
When a switch is using in-band control, the controller must be specified
in dotted quad format, since DNS names cannot be resolved until a
connection to the controller has been established.  This commit
validates the user input in the xsconsole plugin.
This commit is contained in:
Justin Pettit
2009-06-24 21:52:34 -07:00
parent 7c77c24dbd
commit 3dc6fca88b
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
xenserver/usr_lib_xsconsole_plugins-base_XSFeatureVSwitch.py
View File

@@ -12,6 +12,7 @@ log = logging.getLogger("vswitch-cfg-update")
logging.basicConfig(filename="/var/log/vswitch-xsplugin.log", level=logging.DEBUG) logging.basicConfig(filename="/var/log/vswitch-xsplugin.log", level=logging.DEBUG)
import os import os
import socket
import subprocess import subprocess
cfg_mod="/root/vswitch/bin/ovs-cfg-mod" cfg_mod="/root/vswitch/bin/ovs-cfg-mod"
@@ -162,6 +163,14 @@ class VSwitchControllerDialogue(Dialogue):
inputValues = pane.GetFieldValues() inputValues = pane.GetFieldValues()
self.controller = inputValues['address'] self.controller = inputValues['address']
Layout.Inst().PopDialogue() Layout.Inst().PopDialogue()
# Make sure the controller is specified as a valid dotted quad
try:
socket.inet_aton(self.controller)
except socket.error:
Layout.Inst().PushDialogue(InfoDialogue(Lang("Please enter in dotted quad format")))
return True
Layout.Inst().TransientBanner(Lang("Setting controller...")) Layout.Inst().TransientBanner(Lang("Setting controller..."))
try: try:
self.SetController(self.controller) self.SetController(self.controller)