mir/openvswitch
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-10-19 14:37:21 +00:00
Code Issues Releases Wiki Activity

vlog: Avoid use-after-free in corner case.

Browse Source 
Found by valgrind.

Signed-off-by: Ben Pfaff <blp@nicira.com>
This commit is contained in:
Ben Pfaff
2012-06-12 16:45:20 -07:00
parent f7cc6bd82f
commit 487657b2b8
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
lib/vlog.c
View File

@@ -477,6 +477,7 @@ vlog_unixctl_reopen(struct unixctl_conn *conn, int argc OVS_UNUSED,
void void
vlog_init(void) vlog_init(void)
{ {
static char *program_name_copy;
time_t now; time_t now;
if (vlog_inited) { if (vlog_inited) {
@@ -484,7 +485,13 @@ vlog_init(void)
} }
vlog_inited = true; vlog_inited = true;
openlog(program_name, LOG_NDELAY, LOG_DAEMON); /* openlog() is allowed to keep the pointer passed in, without making a
* copy. The daemonize code sometimes frees and replaces 'program_name',
* so make a private copy just for openlog(). (We keep a pointer to the
* private copy to suppress memory leak warnings in case openlog() does
* make its own copy.) */
program_name_copy = program_name ? xstrdup(program_name) : NULL;
openlog(program_name_copy, LOG_NDELAY, LOG_DAEMON);
now = time_wall(); now = time_wall();
if (now < 0) { if (now < 0) {