mir/openvswitch
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-10-25 15:07:05 +00:00
Code Issues Releases Wiki Activity

socket-util: Disable dscp setting on Windows.

Browse Source 
According to msdn documentation, one is discouraged from using
IP_TOS for ipv4 sockets (it apparently does not actually set
anything). Also, IPV6_TCLASS does not work in
Windows (it always returns an error and also is undocumented).
Looks like Microsoft recommends QoS2 APIs to achieve
the same. Till we add those API calls, simply return on Windows.

(Noticed while running unit tests for ipv6. set_dscp would fail.)

Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
Acked-by: Ben Pfaff <blp@nicira.com>
This commit is contained in:
Gurucharan Shetty
2014-05-23 13:26:18 -07:00
parent a532e683cf
commit 5349904d1b
1 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
lib/socket-util.c
View File

@@ -93,6 +93,11 @@ set_dscp(int fd, uint8_t dscp)
int val;
bool success;
#ifdef _WIN32
/* XXX: Consider using QoS2 APIs for Windows to set dscp. */
return 0;
#endif
if (dscp > 63) {
return EINVAL;
}
@@ -101,22 +106,14 @@ set_dscp(int fd, uint8_t dscp)
success = false;
val = dscp << 2;
if (setsockopt(fd, IPPROTO_IP, IP_TOS, &val, sizeof val)) {
#ifndef _WIN32
if (sock_errno() != ENOPROTOOPT) {
#else
if (sock_errno() != WSAENOPROTOOPT) {
#endif
return sock_errno();
}
} else {
success = true;
}
if (setsockopt(fd, IPPROTO_IPV6, IPV6_TCLASS, &val, sizeof val)) {
#ifndef _WIN32
if (sock_errno() != ENOPROTOOPT) {
#else
if (sock_errno() != WSAENOPROTOOPT) {
#endif
return sock_errno();
}
} else {