From 79a245848c3efc04f4667224fbed42bfb7e3e34f Mon Sep 17 00:00:00 2001 From: Ryan Wilson Date: Wed, 21 May 2014 20:11:09 -0700 Subject: [PATCH] TODO: Remove "OpenFlow Group Bucket Stats" from TODO list Signed-off-by: Ryan Wilson Signed-off-by: Ben Pfaff --- TODO | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/TODO b/TODO index dabe49cb0..e11089ac7 100644 --- a/TODO +++ b/TODO @@ -52,23 +52,6 @@ These changes might have backward-compatibility implications; one would have to test the behavior of the reduced cipher list OVS against older versions. -OpenFlow Group Bucket Stats ---------------------------- - -When OpenFlow group support was added, we forgot to support statistics -for individual buckets. xlate_group_bucket() in -ofproto/ofproto-dpif-xlate.c appears to be where we need to increment -the counters, in the case where ctx->xin->resubmit_stats is -nonnull. See the ovs-dev thread starting here: -http://openvswitch.org/pipermail/dev/2014-January/036107.html - -Joe Stringer adds: If this involves resubmit_stats, then it would also -need a new xc_type. The xlate_group_bucket() code would add an entry -to ctx->xin->xcache if it is nonnull. This would also need to follow -the code in xlate_push_stats() and xlate_cache_clear() for the new -xc_type. - - Bash Command Completion -----------------------