mirror of
https://github.com/openvswitch/ovs
synced 2025-10-29 15:28:56 +00:00
Revert "json: New function json_serialized_length()."
This reverts commit1600fa6853. Connections that queue up too much data, because they are monitoring a table that is changing quickly and failing to keep up with the updates, cause problems with buffer management. Since commit60533a405b(jsonrpc-server: Disconnect connections that queue too much data.), ovsdb-server has dealt with them by disconnecting the connection and letting them start up again with a fresh copy of the database. However, this is not ideal because of situations where disconnection happens repeatedly. For example: - A manager toggles a column back and forth between two or more values quickly (in which case the data transmitted over the monitoring connections always increases quickly, without bound). - A manager repeatedly extends the contents of some column in some row (in which case the data transmitted over the monitoring connection grows with O(n**2) in the length of the string). A better way to deal with this problem is to combine updates when they are sent to the monitoring connection, if that connection is not keeping up. In both the above cases, this reduces the data that must be sent to a manageable amount. An upcoming patch implements this new way. This commit reverts part of the previous solution that disconnects backlogged connections, since it is no longer useful. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Andy Zhou <azhou@nicira.com>
This commit is contained in:
@@ -1,5 +1,5 @@
|
||||
/*
|
||||
* Copyright (c) 2009, 2010, 2013 Nicira, Inc.
|
||||
* Copyright (c) 2009, 2010 Nicira, Inc.
|
||||
*
|
||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
@@ -127,8 +127,6 @@ enum {
|
||||
};
|
||||
char *json_to_string(const struct json *, int flags);
|
||||
void json_to_ds(const struct json *, int flags, struct ds *);
|
||||
|
||||
size_t json_serialized_length(const struct json *);
|
||||
|
||||
/* JSON string formatting operations. */
|
||||
|
||||
|
||||
Reference in New Issue
Block a user