mir/openvswitch
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-10-17 14:28:02 +00:00
Code Issues Releases Wiki Activity

ovs python: ovs.stream.open_block() returns success even if the remote is unreachable

Browse Source 
The python function ovs.socket_util.check_connection_completion() uses select()
(provided by python) to monitor the socket file descriptor. The select()
returns 1 when the file descriptor becomes ready. For error cases like -
111 (Connection refused) and 113 (No route to host) (POLLERR), ovs.poller._SelectSelect.poll()
expects the exceptfds list to be set by select(). But that is not the case.
As per the select() man page, writefds list will be set for POLLERR.
Please see "Correspondence between select() and poll() notifications" section of select(2)
man page.

Because of this behavior, ovs.socket_util.check_connection_completion() returns success
even if the remote is unreachable or not listening on the port.

This patch fixes this issue by using poll() to check the connection status similar to
the C implementation of check_connection_completion().

A new function 'get_system_poll() is added in ovs/poller.py which returns the
select.poll() object. If select.poll is monkey patched by eventlet/gevent, it
gets the original select.poll() and returns it.

The test cases added in this patch fails without the fix.

Suggested-by: Ben Pfaff <blp@ovn.org>
Signed-off-by: Numan Siddique <nusiddiq@redhat.com>
Signed-off-by: Ben Pfaff <blp@ovn.org>
Acked-by: Mark Michelson <mmichels@redhat.com>
This commit is contained in:
Numan Siddique
2018-08-07 17:07:58 +05:30
committed by Ben Pfaff
parent 44a629b5b8
commit c1aa16d191
6 changed files with 94 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
python/ovs/stream.py
View File

@@ -191,8 +191,15 @@ class Stream(object):
if error:
return error, None
else:
status = ovs.socket_util.check_connection_completion(sock)
return 0, cls(sock, name, status)
err = ovs.socket_util.check_connection_completion(sock)
if err == errno.EAGAIN or err == errno.EINPROGRESS:
status = errno.EAGAIN
err = 0
elif err == 0:
status = 0
else:
status = err
return err, cls(sock, name, status)
@staticmethod
def _open(suffix, dscp):