mir/openvswitch
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-10-27 15:18:06 +00:00
Code Issues Releases Wiki Activity

daemon: Suppress valgrind warnings from read_pidfile().

Browse Source 
The version of valgrind I have in my test VMs doesn't know what F_GETLK
does, so it complains that l_pid is uninitialized even though fcntl sets
it.  Initializing it ourselves before calling the function avoids a series
of false-positive warnings about use of uninitialized data.
This commit is contained in:
Ben Pfaff
2011-02-01 11:24:51 -08:00
parent 535d6987a7
commit e7668254f2
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/daemon.c
View File

@@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2008, 2009, 2010 Nicira Networks. * Copyright (c) 2008, 2009, 2010, 2011 Nicira Networks.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@@ -536,6 +536,7 @@ read_pidfile(const char *pidfile)
lck.l_whence = SEEK_SET; lck.l_whence = SEEK_SET;
lck.l_start = 0; lck.l_start = 0;
lck.l_len = 0; lck.l_len = 0;
lck.l_pid = 0;
if (fcntl(fileno(file), F_GETLK, &lck)) { if (fcntl(fileno(file), F_GETLK, &lck)) {
error = errno; error = errno;
VLOG_WARN("%s: fcntl: %s", pidfile, strerror(error)); VLOG_WARN("%s: fcntl: %s", pidfile, strerror(error));