mir/openvswitch
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-10-21 14:49:41 +00:00
Code Issues Releases Wiki Activity

process: Check return value of set_nonblocking().

Browse Source 
It's unlikely to fail but checking it can't hurt.

Found by Coverity.

Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Ethan Jackson <ethan@nicira.com>
This commit is contained in:
Ben Pfaff
2013-01-24 13:19:52 -08:00
parent 0d7bb1b4f4
commit e93af6a479
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lib/process.c
View File

@@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2008, 2009, 2010, 2011, 2012 Nicira, Inc. * Copyright (c) 2008, 2009, 2010, 2011, 2012, 2013 Nicira, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@@ -408,14 +408,20 @@ struct stream {
static int static int
stream_open(struct stream *s, size_t max_size) stream_open(struct stream *s, size_t max_size)
{ {
int error;
s->max_size = max_size; s->max_size = max_size;
ds_init(&s->log); ds_init(&s->log);
if (pipe(s->fds)) { if (pipe(s->fds)) {
VLOG_WARN("failed to create pipe: %s", strerror(errno)); VLOG_WARN("failed to create pipe: %s", strerror(errno));
return errno; return errno;
} }
set_nonblocking(s->fds[0]); error = set_nonblocking(s->fds[0]);
return 0; if (error) {
close(s->fds[0]);
close(s->fds[1]);
}
return error;
} }
static void static void