mir/openvswitch
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-10-25 15:07:05 +00:00
Code Issues Releases Wiki Activity

ovsdb-idl: Check prerequisites for ovsdb_idl_txn_verify() also.

Browse Source 
The IDL can only verify prerequisites for columns that it is monitoring,
but it didn't check for that.  This assertion (which is the same as one in
ovsdb_idl_txn_write()) should alert us to such problems.

This would have found the problem fixed by the previous commit.
This commit is contained in:
Ben Pfaff
2010-12-08 14:26:37 -08:00
parent 4e3e7ff9fc
commit ee21cfa751
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/ovsdb-idl.c
View File

@@ -1693,6 +1693,8 @@ ovsdb_idl_txn_verify(const struct ovsdb_idl_row *row_,
size_t column_idx = column - class->columns; size_t column_idx = column - class->columns;
assert(row->new != NULL); assert(row->new != NULL);
assert(row->old == NULL ||
row->table->modes[column_idx] & OVSDB_IDL_MONITOR);
if (!row->old if (!row->old
|| (row->written && bitmap_is_set(row->written, column_idx))) { || (row->written && bitmap_is_set(row->written, column_idx))) {
return; return;