mirror of
https://github.com/openvswitch/ovs
synced 2025-10-25 15:07:05 +00:00
0e15264f96
The protocol used by ovs-appctl has a long-standing bug that there is no way to distinguish "ovs-appctl a b c" from "ovs-appctl 'a b c'". This isn't a big deal because none of the current commands really want to accept arguments that include spaces, but it's kind of a silly limitation. At the same time, the internal API is awkward because every user is stuck doing its own argument parsing, which is no fun. This commit fixes both problems, by adding shell-like quoting to the protocol and modifying the internal API from one that passes a string to one that passes in an array of pre-parsed strings. Command implementations may now specify how many arguments they expect. This simplifies some command implementations significantly. Signed-off-by: Ben Pfaff <blp@nicira.com>
55 lines
1.9 KiB
C
55 lines
1.9 KiB
C
/*
|
|
* Copyright (c) 2008, 2009, 2011 Nicira Networks.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at:
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#ifndef UNIXCTL_H
|
|
#define UNIXCTL_H 1
|
|
|
|
#ifdef __cplusplus
|
|
extern "C" {
|
|
#endif
|
|
|
|
/* Server for Unix domain socket control connection. */
|
|
struct unixctl_server;
|
|
int unixctl_server_create(const char *path, struct unixctl_server **);
|
|
void unixctl_server_run(struct unixctl_server *);
|
|
void unixctl_server_wait(struct unixctl_server *);
|
|
void unixctl_server_destroy(struct unixctl_server *);
|
|
|
|
/* Client for Unix domain socket control connection. */
|
|
struct unixctl_client;
|
|
int unixctl_client_create(const char *path, struct unixctl_client **);
|
|
void unixctl_client_destroy(struct unixctl_client *);
|
|
int unixctl_client_transact(struct unixctl_client *,
|
|
const char *request,
|
|
int *reply_code, char **reply_body);
|
|
const char *unixctl_client_target(const struct unixctl_client *);
|
|
|
|
/* Command registration. */
|
|
struct unixctl_conn;
|
|
typedef void unixctl_cb_func(struct unixctl_conn *,
|
|
int argc, const char *argv[], void *aux);
|
|
void unixctl_command_register(const char *name, const char *usage,
|
|
int min_args, int max_args,
|
|
unixctl_cb_func *cb, void *aux);
|
|
void unixctl_command_reply(struct unixctl_conn *, int code,
|
|
const char *body);
|
|
|
|
#ifdef __cplusplus
|
|
}
|
|
#endif
|
|
|
|
#endif /* unixctl.h */
|