Ben Pfaff c821124b25 ovs-ofctl: Accept only valid flow_mod and flow_stats_request fields. ...

OpenFlow commands have several idiosyncratic fields that are used in some
cases and ignored in others.  Until now, ovs-ofctl has been lax about
allowing some of them in places where they are ignored.  This commit
tightens the checks to exactly what is allowed.

Bug #5979.
Reported-by: Reid Price <reid@nicira.com>

2011-06-23 12:21:13 -07:00

..

.gitignore

Automatically extract error types and codes for formatting.

2011-01-12 13:51:43 -08:00

aes128.c

…

aes128.h

…

automake.mk

Merge 'master' into 'next'.

2011-05-12 12:05:42 -07:00

autopath.c

autopath: Create the autopath action.

2011-04-11 15:56:20 -07:00

autopath.h

autopath: Create the autopath action.

2011-04-11 15:56:20 -07:00

backtrace.c

backtrace: Make backtrace_capture() work on more systems.

2011-05-13 14:37:14 -07:00

backtrace.h

…

bitmap.c

…

bitmap.h

mac-learning: Change mac_learning_set_flood_vlans() to not take ownership.

2011-04-25 17:11:29 -07:00

bond.c

bond: Discontinue use of netdev_monitor.

2011-05-31 14:34:39 -07:00

bond.h

bond: Use CFM for slave status.

2011-05-20 15:54:08 -07:00

byte-order.h

Make the source tree sparse clean.

2011-05-16 13:45:53 -07:00

byteq.c

…

byteq.h

…

cfm.c

CFM: Revert default MA and MD name.

2011-05-26 11:05:00 -07:00

cfm.h

cfm: Require 'name' field for 'cfm' objects.

2011-05-24 15:25:53 -07:00

classifier.c

classifier: New function cls_rule_hash().

2011-06-14 11:21:51 -07:00

classifier.h

classifier: New function cls_rule_hash().

2011-06-14 11:21:51 -07:00

command-line.c

Log anything that could prevent a daemon from starting.

2011-04-04 10:58:55 -07:00

command-line.h

…

common-syn.man

…

common.man

…

compiler.h

compiler: Add macro for GCC "sentinel" attribute.

2011-06-07 17:05:42 -07:00

coverage.c

coverage: Make the coverage counters catalog program-specific.

2010-11-30 10:30:30 -08:00

coverage.h

Suppress sparse warnings for global variables initialized in headers.

2011-05-16 13:40:48 -07:00

csum.c

Make the source tree sparse clean.

2011-05-16 13:45:53 -07:00

csum.h

csum: Annotate byte order to match actual usage.

2011-05-16 13:40:48 -07:00

daemon-syn.man

…

daemon.c

daemon: Disable logging to console after detaching.

2011-06-16 12:28:06 -07:00

daemon.h

Consistently write null pointer constants as NULL instead of 0.

2011-05-16 13:40:47 -07:00

daemon.man

ovs-vswitchd: Complete daemonization only after initial configuration.

2011-02-07 12:50:19 -08:00

dh1024.pem

…

dh2048.pem

…

dh4096.pem

…

dhcp.h

Convert remaining network-byte-order "uint<N>_t"s into "ovs_be<N>"s.

2011-05-16 13:40:47 -07:00

dhparams.h

…

dirs.c.in

Make installation directories overridable at runtime.

2010-11-29 16:29:11 -08:00

dirs.h

Make installation directories overridable at runtime.

2010-11-29 16:29:11 -08:00

dpif-linux.c

dpif-linux: Fix memory and file descriptor leak in dpif_linux_close().

2011-06-07 13:20:35 -07:00

dpif-linux.h

netdev-vport: Implement 'send' function.

2011-04-01 15:52:19 -07:00

dpif-netdev.c

Remove NXAST_DROP_SPOOFED_ARP action.

2011-06-09 16:19:38 -07:00

dpif-provider.h

datapath: Get packet metadata from userspace in odp_packet_cmd_execute().

2011-06-01 13:39:51 -07:00

dpif.c

dpif: Improve logging of upcalls.

2011-06-09 09:21:24 -07:00

dpif.h

dpif: Improve logging of upcalls.

2011-06-09 09:21:24 -07:00

dummy.c

Add new "dummy" netdev and dpif implementations for use in unit tests.

2010-11-29 16:29:10 -08:00

dummy.h

Add new "dummy" netdev and dpif implementations for use in unit tests.

2010-11-29 16:29:10 -08:00

dynamic-string.c

dynamic-string: New function ds_get_preprocessed_line().

2011-03-16 14:53:16 -07:00

dynamic-string.h

dynamic-string: New function ds_get_preprocessed_line().

2011-03-16 14:53:16 -07:00

entropy.c

Log anything that could prevent a daemon from starting.

2011-04-04 10:58:55 -07:00

entropy.h

…

fatal-signal.c

Log anything that could prevent a daemon from starting.

2011-04-04 10:58:55 -07:00

fatal-signal.h

…

flow.c

flow: Give flow_wildcards_hash() a 'basis' parameter.

2011-06-14 11:21:51 -07:00

flow.h

flow: Give flow_wildcards_hash() a 'basis' parameter.

2011-06-14 11:21:51 -07:00

hash.c

hash: Make functions for hashing a few words easier to use.

2010-12-17 14:31:40 -08:00

hash.h

hash: Make functions for hashing a few words easier to use.

2010-12-17 14:31:40 -08:00

hmap.c

hmap: New function hmap_at_position().

2011-01-27 09:26:05 -08:00

hmap.h

hmap: New function hmap_at_position().

2011-01-27 09:26:05 -08:00

hmapx.c

hmapx: New data structure.

2011-05-04 10:27:20 -07:00

hmapx.h

hmapx: New data structure.

2011-05-04 10:27:20 -07:00

json.c

Remove unnecessary #include directives.

2011-05-16 13:40:47 -07:00

json.h

…

jsonrpc.c

poll-loop: Make wakeup logging more portable and easier to understand.

2011-05-13 14:38:15 -07:00

jsonrpc.h

ovsdb-server: Write manager status information to Manager table.

2011-02-01 14:45:20 -08:00

lacp.c

lacp: Loosen lacp_slave_is_current().

2011-06-14 11:17:24 -07:00

lacp.h

lacp: New "lacp-heartbeat" mode.

2011-05-06 13:48:41 -07:00

leak-checker.c

leak-checker: Avoid printing freed pointer.

2011-02-23 15:14:42 -08:00

leak-checker.h

Consistently write null pointer constants as NULL instead of 0.

2011-05-16 13:40:47 -07:00

leak-checker.man

…

learning-switch.c

learning-switch: Also wildcard VLAN priority bits.

2011-06-06 22:07:37 -07:00

learning-switch.h

ovs-controller: Allow --wildcards to specify a wildcard set.

2011-06-01 09:09:20 -07:00

list.c

list: Clarify description of list_moved().

2011-06-07 13:21:26 -07:00

list.h

list: New functions list_is_singleton(), list_is_short().

2011-04-01 15:52:19 -07:00

lockfile.c

lockfile: Don't warn if successful lock takes a little time.

2011-05-13 14:43:44 -07:00

lockfile.h

…

mac-learning.c

mac-learning: Avoid unnecessary call to free().

2011-04-25 17:11:29 -07:00

mac-learning.h

mac-learning: Change mac_learning_set_flood_vlans() to not take ownership.

2011-04-25 17:11:29 -07:00

multipath.c

multipath: Validate multipath actions more thoroughly in multipath_parse().

2011-02-23 09:42:32 -08:00

multipath.h

Implement a new Nicira extension action for multipath link selection.

2010-12-17 14:38:50 -08:00

netdev-dummy.c

netdev: Add methods to do netdev-specific argument comparisons.

2011-06-14 10:28:40 -07:00

netdev-linux.c

Reduce log level for ENODEV errors getting Ethernet address.

2011-06-17 13:38:31 -07:00

netdev-linux.h

netdev-linux: New functions for converting netdev stats formats.

2011-05-02 09:33:12 -07:00

netdev-provider.h

netdev: Add methods to do netdev-specific argument comparisons.

2011-06-14 10:28:40 -07:00

netdev-vport.c

netdev-vport: Don't use ipsec options for either arg in config_equal_ipsec().

2011-06-16 18:04:41 -07:00

netdev-vport.h

datapath: Change userspace vport interface to use Netlink attributes.

2011-01-27 21:08:37 -08:00

netdev.c

netdev: Add methods to do netdev-specific argument comparisons.

2011-06-14 10:28:40 -07:00

netdev.h

netdev: Remove monitors and notifiers.

2011-05-31 14:34:39 -07:00

netlink-protocol.h

netlink-socket: Add functions for joining and leaving multicast groups.

2011-01-27 09:26:05 -08:00

netlink-socket.c

netlink-socket: Log Generic Netlink family names.

2011-01-27 09:26:06 -08:00

netlink-socket.h

netlink-socket: Make dumping and doing transactions on same nl_sock safe.

2011-01-27 09:26:06 -08:00

netlink.c

netlink: Use proper types and functions for half-aligned 64-bit values.

2011-02-05 13:14:49 -08:00

netlink.h

netlink: Avoid "cast increases required alignment of target type" on RISC.

2011-05-26 09:01:29 -07:00

nx-match.c

Better abstract wildcards for Ethernet destination field.

2011-06-07 16:47:42 -07:00

nx-match.def

nicira-ext: Support matching IPv6 Neighbor Discovery messages.

2011-02-02 13:22:34 -08:00

nx-match.h

nicira-ext: Support matching IPv6 Neighbor Discovery messages.

2011-02-02 13:22:34 -08:00

odp-util.c

Remove NXAST_DROP_SPOOFED_ARP action.

2011-06-09 16:19:38 -07:00

odp-util.h

odp-util: Replace ODPUTIL_FLOW_KEY_U32S by new struct odputil_keybuf.

2011-03-30 15:08:47 -07:00

ofp-errors.h

Automatically extract error types and codes for formatting.

2011-01-12 13:51:43 -08:00

ofp-parse.c

ovs-ofctl: Accept only valid flow_mod and flow_stats_request fields.

2011-06-23 12:21:13 -07:00

ofp-parse.h

ovs-ofctl: Accept only valid flow_mod and flow_stats_request fields.

2011-06-23 12:21:13 -07:00

ofp-print.c

ofp-print: Change "table_id" to "table" in flow_mod and flow_stats.

2011-06-14 11:21:52 -07:00

ofp-print.h

…

ofp-util.c

ofp-util: Send table_id correctly in OpenFlow 1.0 flow_mods.

2011-06-15 10:34:13 -07:00

ofp-util.h

Define UINT64_MAX as "unknown" in Open vSwitch specific interfaces.

2011-06-14 11:21:52 -07:00

ofpbuf.c

openflow: Make stats replies more like other OpenFlow messages.

2011-06-14 11:21:50 -07:00

ofpbuf.h

openflow: Make stats replies more like other OpenFlow messages.

2011-06-14 11:21:50 -07:00

ovsdb-data.c

tests: Fix the two Python XFAIL tests.

2011-05-24 11:32:22 -07:00

ovsdb-data.h

ovsdb: Implement garbage collection.

2011-03-10 11:24:00 -08:00

ovsdb-error.c

Add a few more users for ovs_retval_to_string().

2011-04-04 10:58:54 -07:00

ovsdb-error.h

ovsdb: Improve error reporting for some internal errors.

2011-03-10 11:23:59 -08:00

ovsdb-idl-provider.h

ovsdb: Implement garbage collection.

2011-03-10 11:24:00 -08:00

ovsdb-idl.c

ovsdb-idl: Plug hole in state machine.

2011-06-21 15:09:56 -07:00

ovsdb-idl.h

ovsdb-idl: Plug hole in state machine.

2011-06-21 15:09:56 -07:00

ovsdb-parser.c

ovsdb-parser: Use sset instead of svec for detecting unused members.

2011-03-31 16:42:01 -07:00

ovsdb-parser.h

ovsdb-parser: Use sset instead of svec for detecting unused members.

2011-03-31 16:42:01 -07:00

ovsdb-types.c

…

ovsdb-types.h

ovsdb-types: Fix bug in ovsdb_base_type_is_ref().

2011-03-31 16:43:01 -07:00

packets.c

lacp: Move LACP packet data to lacp header file.

2011-04-19 13:49:35 -07:00

packets.h

Fix incorrect byte order annotations.

2011-05-16 13:40:47 -07:00

pcap.c

pcap: Silence warnings about fwrite(3) return value being ignored.

2011-04-12 10:40:15 -07:00

pcap.h

…

poll-loop.c

poll-loop: Fix typo in comment.

2011-05-27 09:13:50 -07:00

poll-loop.h

poll-loop: Make wakeup logging more portable and easier to understand.

2011-05-13 14:38:15 -07:00

process.c

process: Let process_run_capture() caller set maximum capture size.

2011-06-07 17:05:42 -07:00

process.h

process: Let process_run_capture() caller set maximum capture size.

2011-06-07 17:05:42 -07:00

random.c

Log anything that could prevent a daemon from starting.

2011-04-04 10:58:55 -07:00

random.h

random: Add entropy test.

2010-11-15 09:34:18 -08:00

rconn.c

Fix incorrect byte order annotations.

2011-05-16 13:40:47 -07:00

rconn.h

Convert remaining network-byte-order "uint<N>_t"s into "ovs_be<N>"s.

2011-05-16 13:40:47 -07:00

reconnect.c

ovsdb-server: Report time since last connect and disconnect for each manager.

2011-03-14 13:10:02 -07:00

reconnect.h

ovsdb-server: Report time since last connect and disconnect for each manager.

2011-03-14 13:10:02 -07:00

route-table.c

util: Don't read over 'size - 1' bytes of source string in ovs_strlcpy().

2011-02-22 16:33:35 -08:00

route-table.h

lib: route-table improvements.

2011-01-31 18:27:34 -08:00

rtnetlink-link.c

rtnetlink-link: Avoid cast in rtnetlink_link_notifier_register().

2011-06-07 17:05:42 -07:00

rtnetlink-link.h

lib: Show tunnel egress interface in ovsdb

2011-01-04 12:35:59 -08:00

rtnetlink.c

Consistently write null pointer constants as NULL instead of 0.

2011-05-16 13:40:47 -07:00

rtnetlink.h

retnetlink: Add rtnetlink_destroy function.

2011-01-13 13:20:12 -08:00

sat-math.h

…

sflow_agent.c

…

sflow_api.h

…

sflow_poller.c

…

sflow_receiver.c

Make the source tree sparse clean.

2011-05-16 13:45:53 -07:00

sflow_sampler.c

…

sflow.h

…

sha1.c

sha1: Avoid unused variable warnings on big-endian systems.

2011-05-26 09:01:29 -07:00

sha1.h

…

shash.c

shash: New "smap" functions for working with string-to-string maps.

2011-01-27 09:26:06 -08:00

shash.h

shash: New "smap" functions for working with string-to-string maps.

2011-01-27 09:26:06 -08:00

signals.c

signals: New function signal_unregister().

2011-06-07 13:21:26 -07:00

signals.h

signals: New function signal_unregister().

2011-06-07 13:21:26 -07:00

socket-util.c

Convert remaining network-byte-order "uint<N>_t"s into "ovs_be<N>"s.

2011-05-16 13:40:47 -07:00

socket-util.h

Convert remaining network-byte-order "uint<N>_t"s into "ovs_be<N>"s.

2011-05-16 13:40:47 -07:00

sort.c

…

sort.h

…

sset.c

sset: New data type for a set of strings.

2011-03-31 16:42:01 -07:00

sset.h

sset: New data type for a set of strings.

2011-03-31 16:42:01 -07:00

ssl-bootstrap-syn.man

…

ssl-bootstrap.man

…

ssl-peer-ca-cert.man

…

ssl-syn.man

…

ssl.man

…

stream-fd.c

Implement stress option framework.

2010-11-30 13:44:01 -08:00

stream-fd.h

…

stream-nossl.c

stream-ssl: Improve messages when configuring SSL if it is unsupported.

2011-05-10 09:17:37 -07:00

stream-provider.h

Convert stream and vconn interfaces to use ovs_be16, ovs_be32.

2010-11-29 16:29:11 -08:00

stream-ssl.c

stream-ssl: Clear CAs for certificate verification before adding new ones.

2011-06-17 10:50:23 -07:00

stream-ssl.h

Consistently write null pointer constants as NULL instead of 0.

2011-05-16 13:40:47 -07:00

stream-tcp.c

vlog: Make client supply semicolon for VLOG_DEFINE_THIS_MODULE.

2010-10-29 09:48:47 -07:00

stream-unix.c

vlog: Make client supply semicolon for VLOG_DEFINE_THIS_MODULE.

2010-10-29 09:48:47 -07:00

stream.c

stream: Make stream_report_content() tolerate negative size.

2011-02-23 15:14:42 -08:00

stream.h

stream: Make stream_report_content() tolerate negative size.

2011-02-23 15:14:42 -08:00

stress-unixctl.man

Implement stress option framework.

2010-11-30 13:44:01 -08:00

stress.c

Implement stress option framework.

2010-11-30 13:44:01 -08:00

stress.h

Suppress sparse warnings for global variables initialized in headers.

2011-05-16 13:40:48 -07:00

string.c

string: Implement strnlen() if it is missing.

2011-02-22 10:41:34 -08:00

string.h

string: Implement strnlen() if it is missing.

2011-02-22 10:41:34 -08:00

svec.c

ovs-openflowd: Use sset in place of svec.

2011-03-31 16:42:01 -07:00

svec.h

ovs-openflowd: Use sset in place of svec.

2011-03-31 16:42:01 -07:00

table.c

table: Free "error" in cell_to_text().

2011-02-23 11:08:20 -08:00

table.h

Consistently write null pointer constants as NULL instead of 0.

2011-05-16 13:40:47 -07:00

table.man

table: Fix typo in manpage.

2011-03-10 11:24:00 -08:00

tag.c

tag: New function tag_set_union().

2011-04-01 15:52:19 -07:00

tag.h

tag: New function tag_set_union().

2011-04-01 15:52:19 -07:00

timer.c

poll-loop: Make wakeup logging more portable and easier to understand.

2011-05-13 14:38:15 -07:00

timer.h

timer: Remove timer_expired_at() function.

2011-05-19 11:33:29 -07:00

timeval.c

poll-loop: Automatically log reason for wakeup when CPU usage spikes.

2011-05-24 12:23:42 -07:00

timeval.h

poll-loop: Automatically log reason for wakeup when CPU usage spikes.

2011-05-24 12:23:42 -07:00

type-props.h

type-props: New macro for estimating length of a decimal integer.

2011-04-04 10:58:54 -07:00

unaligned.h

Make the source tree sparse clean.

2011-05-16 13:45:53 -07:00

unicode.c

…

unicode.h

…

unixctl-syn.man

…

unixctl.c

Add a few more users for ovs_retval_to_string().

2011-04-04 10:58:54 -07:00

unixctl.h

…

unixctl.man

Add new "dummy" netdev and dpif implementations for use in unit tests.

2010-11-29 16:29:10 -08:00

util.c

util: New function for forming English lists.

2011-06-06 08:58:02 -07:00

util.h

util: New function for forming English lists.

2011-06-06 08:58:02 -07:00

uuid.c

Log anything that could prevent a daemon from starting.

2011-04-04 10:58:55 -07:00

uuid.h

uuid: Correct name of header file in comment.

2011-01-11 18:57:01 -08:00

valgrind.h

…

vconn-active.man

…

vconn-passive.man

…

vconn-provider.h

Convert stream and vconn interfaces to use ovs_be16, ovs_be32.

2010-11-29 16:29:11 -08:00

vconn-stream.c

vconn-stream: Make definitions of tcp_vconn_class, etc., easier to find.

2011-02-15 15:04:04 -08:00

vconn.c

vconn: Fix comparison that should be assignment in vconn_open_block().

2011-02-22 10:14:54 -08:00

vconn.h

openflow: Merge ofp_stats_request and ofp_stats_reply.

2011-06-14 11:21:49 -07:00

vlan-bitmap.c

vlan-bitmap: New data structure.

2011-04-25 17:11:29 -07:00

vlan-bitmap.h

mac-learning: Change mac_learning_set_flood_vlans() to not take ownership.

2011-04-25 17:11:29 -07:00

vlog-syn.man

…

vlog-unixctl.man

…

vlog.c

vlog: Add a little more detail to ratelimit messages

2011-06-21 15:09:08 -07:00

vlog.h

vlog: Add a little more detail to ratelimit messages

2011-06-21 15:09:08 -07:00

vlog.man

…