mirror of
https://github.com/openvswitch/ovs
synced 2025-10-19 14:37:21 +00:00
74ff3298c8
Define struct eth_addr and use it instead of a uint8_t array for all ethernet addresses in OVS userspace. The struct is always the right size, and it can be assigned without an explicit memcpy, which makes code more readable. "struct eth_addr" is a good type name for this as many utility functions are already named accordingly. struct eth_addr can be accessed as bytes as well as ovs_be16's, which makes the struct 16-bit aligned. All use seems to be 16-bit aligned, so some algorithms on the ethernet addresses can be made a bit more efficient making use of this fact. As the struct fits into a register (in 64-bit systems) we pass it by value when possible. This patch also changes the few uses of Linux specific ETH_ALEN to OVS's own ETH_ADDR_LEN, and removes the OFP_ETH_ALEN, as it is no longer needed. This work stemmed from a desire to make all struct flow members assignable for unrelated exploration purposes. However, I think this might be a nice code readability improvement by itself. Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com>
37 lines
1.4 KiB
C
37 lines
1.4 KiB
C
/*
|
|
* Copyright (c) 2008, 2011 Nicira, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at:
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#ifndef CSUM_H
|
|
#define CSUM_H 1
|
|
|
|
#include <stddef.h>
|
|
#include <stdint.h>
|
|
#include "openvswitch/types.h"
|
|
|
|
ovs_be16 csum(const void *, size_t);
|
|
uint32_t csum_add16(uint32_t partial, ovs_be16);
|
|
uint32_t csum_add32(uint32_t partial, ovs_be32);
|
|
uint32_t csum_continue(uint32_t partial, const void *, size_t);
|
|
ovs_be16 csum_finish(uint32_t partial);
|
|
ovs_be16 recalc_csum16(ovs_be16 old_csum, ovs_be16 old_u16, ovs_be16 new_u16);
|
|
ovs_be16 recalc_csum32(ovs_be16 old_csum, ovs_be32 old_u32, ovs_be32 new_u32);
|
|
ovs_be16 recalc_csum48(ovs_be16 old_csum, const struct eth_addr old_mac,
|
|
const struct eth_addr new_mac);
|
|
ovs_be16 recalc_csum128(ovs_be16 old_csum, ovs_16aligned_be32 old_u32[4],
|
|
const ovs_be32 new_u32[4]);
|
|
|
|
#endif /* csum.h */
|