mirror of
https://github.com/openvswitch/ovs
synced 2025-10-17 14:28:02 +00:00
f025bcb7ea
Current code expects there to be a single thread that is responsible for creating rstp and creating and deleting rstp_port objects. rstp objects are also deleted from other threads, as managed by reference counting. rstp port objects are not reference counted, which means that references to rstp ports may only be held while holding the rstp mutex, or by the thread that creates and deletes them. This patch adds reference counting to RSTP ports, which allows ports to be passed from ofproto-dpif to ofproto-dpif-xlate without using the RSTP port number. This simplifies RSTP port reconfiguration, as the port need not be resynchronized with xlate if just the port number changes. This also avoids lookups on the processing of RSTP BPDUs. This patch also: 1. Exposes the rstp mutex so that related thread safety annotations can be used also within rstp-state-machines.c. 2. Internal variants of most setter an getter functions are defined, suffixed with two underscores. These are annotated to be callable only when the mutex is held. 3. Port setters were only called in a specific pattern. The new external port setter combines them in a single rspt_port_set() function. Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Daniele Venturino <daniele.venturino@m3s.it>
47 lines
1.4 KiB
C
47 lines
1.4 KiB
C
/*
|
|
* Copyright (c) 2011-2014 M3S, Srl - Italy
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at:
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
/*
|
|
* Rapid Spanning Tree Protocol (IEEE 802.1D-2004) state machines
|
|
* implementation (header file).
|
|
*
|
|
* Authors:
|
|
* Martino Fornasa <mf@fornasa.it>
|
|
* Daniele Venturino <daniele.venturino@m3s.it>
|
|
*
|
|
* References to IEEE 802.1D-2004 standard are enclosed in square brackets.
|
|
* E.g. [17.3], [Table 17-1], etc.
|
|
*
|
|
*/
|
|
|
|
#ifndef RSTP_STATE_MACHINES_H
|
|
#define RSTP_STATE_MACHINES_H 1
|
|
|
|
#include "rstp-common.h"
|
|
|
|
/* Methods called by the Forwarding Layer, through functions of rstp.h. */
|
|
int move_rstp__(struct rstp *)
|
|
OVS_REQUIRES(rstp_mutex);
|
|
void decrease_rstp_port_timers__(struct rstp *)
|
|
OVS_REQUIRES(rstp_mutex);
|
|
void process_received_bpdu__(struct rstp_port *, const void *, size_t)
|
|
OVS_REQUIRES(rstp_mutex);
|
|
|
|
void updt_roles_tree__(struct rstp *)
|
|
OVS_REQUIRES(rstp_mutex);
|
|
|
|
#endif /* rstp-state-machines.h */
|