mirror of
https://github.com/openvswitch/ovs
synced 2025-10-19 14:37:21 +00:00
f937ccc232
This avoids a fairly common issue in which a developer cuts and pastes a structure definition and forgets to update the structure name inside the OFP_ASSERT, so that the new structure's size doesn't really get checked at all.
57 lines
1.3 KiB
Plaintext
57 lines
1.3 KiB
Plaintext
AT_BANNER([struct alignment checker unit tests])
|
|
|
|
m4_define([check_structs], [$top_srcdir/build-aux/check-structs])
|
|
m4_define([RUN_STRUCT_CHECKER],
|
|
[AT_KEYWORDS([check-structs])
|
|
AT_SKIP_IF([test $HAVE_PYTHON = no])
|
|
AT_DATA([test.h], [$1
|
|
])
|
|
AT_CHECK_UNQUOTED([$PYTHON check_structs test.h], [$2], [$3], [$4])])
|
|
|
|
AT_SETUP([check struct tail padding])
|
|
RUN_STRUCT_CHECKER(
|
|
[struct xyz {
|
|
uint16_t x;
|
|
};],
|
|
[1], [],
|
|
[test.h:3: warning: struct xyz needs 2 bytes of tail padding
|
|
])
|
|
AT_CLEANUP
|
|
|
|
AT_SETUP([check struct internal alignment])
|
|
RUN_STRUCT_CHECKER(
|
|
[struct xyzzy {
|
|
uint16_t x;
|
|
uint32_t y;
|
|
};],
|
|
[1], [],
|
|
[test.h:3: warning: struct xyzzy member y is 2 bytes short of 4-byte alignment
|
|
])
|
|
AT_CLEANUP
|
|
|
|
AT_SETUP([check struct declared size])
|
|
RUN_STRUCT_CHECKER(
|
|
[struct wibble {
|
|
uint64_t z;
|
|
};
|
|
OFP_ASSERT(sizeof(struct wibble) == 12);
|
|
],
|
|
[1], [],
|
|
[test.h:4: warning: struct wibble is 8 bytes long but declared as 12
|
|
])
|
|
AT_CLEANUP
|
|
|
|
AT_SETUP([check wrong struct's declared size])
|
|
RUN_STRUCT_CHECKER(
|
|
[struct moo {
|
|
uint64_t bar;
|
|
};
|
|
OFP_ASSERT(sizeof(struct moo) == 8);
|
|
struct wibble {
|
|
uint64_t z;
|
|
};
|
|
OFP_ASSERT(sizeof(struct moo) == 8);
|
|
], [1], [], [test.h:8: warning: checking size of struct moo but struct wibble was most recently defined
|
|
])
|
|
AT_CLEANUP
|