mirror of
https://github.com/openvswitch/ovs
synced 2025-10-23 14:57:06 +00:00
ofpbuf was complicated due to its wide usage across all layers of OVS, Now we have introduced independent dp_packet which can be used for datapath packet, we can simplify ofpbuf. Following patch removes DPDK mbuf and access API of ofpbuf members. Signed-off-by: Pravin B Shelar <pshelar@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
460 lines
13 KiB
C
460 lines
13 KiB
C
/*
|
|
* Copyright (c) 2009, 2010, 2011, 2012, 2013, 2014 Nicira, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at:
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#include <config.h>
|
|
#undef NDEBUG
|
|
#include "openvswitch/vconn.h"
|
|
#include <assert.h>
|
|
#include <errno.h>
|
|
#include <inttypes.h>
|
|
#include <signal.h>
|
|
#include <stdlib.h>
|
|
#include <unistd.h>
|
|
#include "command-line.h"
|
|
#include "fatal-signal.h"
|
|
#include "ofp-msgs.h"
|
|
#include "ofp-util.h"
|
|
#include "ofpbuf.h"
|
|
#include "openflow/openflow.h"
|
|
#include "ovstest.h"
|
|
#include "poll-loop.h"
|
|
#include "socket-util.h"
|
|
#include "stream.h"
|
|
#include "stream-ssl.h"
|
|
#include "timeval.h"
|
|
#include "util.h"
|
|
#include "openvswitch/vlog.h"
|
|
|
|
struct fake_pvconn {
|
|
const char *type;
|
|
char *pvconn_name;
|
|
char *vconn_name;
|
|
struct pstream *pstream;
|
|
};
|
|
|
|
static void
|
|
check(int a, int b, const char *as, const char *file, int line)
|
|
{
|
|
if (a != b) {
|
|
ovs_fatal(0, "%s:%d: %s is %d but should be %d", file, line, as, a, b);
|
|
}
|
|
}
|
|
|
|
|
|
#define CHECK(A, B) check(A, B, #A, __FILE__, __LINE__)
|
|
|
|
static void
|
|
check_errno(int a, int b, const char *as, const char *file, int line)
|
|
{
|
|
if (a != b) {
|
|
char *str_b = xstrdup(ovs_strerror(abs(b)));
|
|
ovs_fatal(0, "%s:%d: %s is %d (%s) but should be %d (%s)",
|
|
file, line, as, a, ovs_strerror(abs(a)), b, str_b);
|
|
}
|
|
}
|
|
|
|
#define CHECK_ERRNO(A, B) check_errno(A, B, #A, __FILE__, __LINE__)
|
|
|
|
static void
|
|
fpv_create(const char *type, struct fake_pvconn *fpv)
|
|
{
|
|
#ifdef HAVE_OPENSSL
|
|
if (!strcmp(type, "ssl")) {
|
|
stream_ssl_set_private_key_file("testpki-privkey.pem");
|
|
stream_ssl_set_certificate_file("testpki-cert.pem");
|
|
stream_ssl_set_ca_cert_file("testpki-cacert.pem", false);
|
|
}
|
|
#endif
|
|
|
|
fpv->type = type;
|
|
if (!strcmp(type, "unix")) {
|
|
static int unix_count = 0;
|
|
char *bind_path;
|
|
|
|
bind_path = xasprintf("fake-pvconn.%d", unix_count++);
|
|
fpv->pvconn_name = xasprintf("punix:%s", bind_path);
|
|
fpv->vconn_name = xasprintf("unix:%s", bind_path);
|
|
CHECK_ERRNO(pstream_open(fpv->pvconn_name, &fpv->pstream,
|
|
DSCP_DEFAULT), 0);
|
|
free(bind_path);
|
|
} else if (!strcmp(type, "tcp") || !strcmp(type, "ssl")) {
|
|
char *s, *port, *save_ptr = NULL;
|
|
char *open_name;
|
|
|
|
open_name = xasprintf("p%s:0:127.0.0.1", type);
|
|
CHECK_ERRNO(pstream_open(open_name, &fpv->pstream, DSCP_DEFAULT), 0);
|
|
|
|
/* Extract bound port number from pstream name. */
|
|
s = xstrdup(pstream_get_name(fpv->pstream));
|
|
strtok_r(s, ":", &save_ptr);
|
|
port = strtok_r(NULL, ":", &save_ptr);
|
|
|
|
/* Save info. */
|
|
fpv->pvconn_name = xstrdup(pstream_get_name(fpv->pstream));
|
|
fpv->vconn_name = xasprintf("%s:127.0.0.1:%s", type, port);
|
|
|
|
free(open_name);
|
|
free(s);
|
|
} else {
|
|
abort();
|
|
}
|
|
}
|
|
|
|
static struct stream *
|
|
fpv_accept(struct fake_pvconn *fpv)
|
|
{
|
|
struct stream *stream;
|
|
|
|
CHECK_ERRNO(pstream_accept_block(fpv->pstream, &stream), 0);
|
|
|
|
return stream;
|
|
}
|
|
|
|
static void
|
|
fpv_close(struct fake_pvconn *fpv)
|
|
{
|
|
pstream_close(fpv->pstream);
|
|
fpv->pstream = NULL;
|
|
}
|
|
|
|
static void
|
|
fpv_destroy(struct fake_pvconn *fpv)
|
|
{
|
|
fpv_close(fpv);
|
|
free(fpv->pvconn_name);
|
|
free(fpv->vconn_name);
|
|
}
|
|
|
|
/* Connects to a fake_pvconn with vconn_open(), then closes the listener and
|
|
* verifies that vconn_connect() reports 'expected_error'. */
|
|
static void
|
|
test_refuse_connection(int argc OVS_UNUSED, char *argv[])
|
|
{
|
|
const char *type = argv[1];
|
|
struct fake_pvconn fpv;
|
|
struct vconn *vconn;
|
|
int error;
|
|
|
|
fpv_create(type, &fpv);
|
|
CHECK_ERRNO(vconn_open(fpv.vconn_name, 0, DSCP_DEFAULT, &vconn), 0);
|
|
fpv_close(&fpv);
|
|
vconn_run(vconn);
|
|
|
|
error = vconn_connect_block(vconn);
|
|
if (!strcmp(type, "tcp")) {
|
|
if (error != ECONNRESET && error != EPIPE
|
|
#ifdef _WIN32
|
|
&& error != WSAECONNRESET
|
|
#endif
|
|
) {
|
|
ovs_fatal(0, "unexpected vconn_connect() return value %d (%s)",
|
|
error, ovs_strerror(error));
|
|
}
|
|
} else if (!strcmp(type, "unix")) {
|
|
#ifndef _WIN32
|
|
CHECK_ERRNO(error, EPIPE);
|
|
#else
|
|
CHECK_ERRNO(error, WSAECONNRESET);
|
|
#endif
|
|
} else if (!strcmp(type, "ssl")) {
|
|
if (error != EPROTO && error != ECONNRESET) {
|
|
ovs_fatal(0, "unexpected vconn_connect() return value %d (%s)",
|
|
error, ovs_strerror(error));
|
|
}
|
|
} else {
|
|
ovs_fatal(0, "invalid connection type %s", type);
|
|
}
|
|
|
|
vconn_close(vconn);
|
|
fpv_destroy(&fpv);
|
|
}
|
|
|
|
/* Connects to a fake_pvconn with vconn_open(), accepts that connection and
|
|
* closes it immediately, and verifies that vconn_connect() reports
|
|
* 'expected_error'. */
|
|
static void
|
|
test_accept_then_close(int argc OVS_UNUSED, char *argv[])
|
|
{
|
|
const char *type = argv[1];
|
|
struct fake_pvconn fpv;
|
|
struct vconn *vconn;
|
|
int error;
|
|
|
|
fpv_create(type, &fpv);
|
|
CHECK_ERRNO(vconn_open(fpv.vconn_name, 0, DSCP_DEFAULT, &vconn), 0);
|
|
vconn_run(vconn);
|
|
stream_close(fpv_accept(&fpv));
|
|
fpv_close(&fpv);
|
|
|
|
error = vconn_connect_block(vconn);
|
|
if (!strcmp(type, "tcp") || !strcmp(type, "unix")) {
|
|
if (error != ECONNRESET && error != EPIPE
|
|
#ifdef _WIN32
|
|
&& error != WSAECONNRESET
|
|
#endif
|
|
) {
|
|
ovs_fatal(0, "unexpected vconn_connect() return value %d (%s)",
|
|
error, ovs_strerror(error));
|
|
}
|
|
} else {
|
|
CHECK_ERRNO(error, EPROTO);
|
|
}
|
|
|
|
vconn_close(vconn);
|
|
fpv_destroy(&fpv);
|
|
}
|
|
|
|
/* Connects to a fake_pvconn with vconn_open(), accepts that connection and
|
|
* reads the hello message from it, then closes the connection and verifies
|
|
* that vconn_connect() reports 'expected_error'. */
|
|
static void
|
|
test_read_hello(int argc OVS_UNUSED, char *argv[])
|
|
{
|
|
const char *type = argv[1];
|
|
struct fake_pvconn fpv;
|
|
struct vconn *vconn;
|
|
struct stream *stream;
|
|
int error;
|
|
|
|
fpv_create(type, &fpv);
|
|
CHECK_ERRNO(vconn_open(fpv.vconn_name, 0, DSCP_DEFAULT, &vconn), 0);
|
|
vconn_run(vconn);
|
|
stream = fpv_accept(&fpv);
|
|
fpv_destroy(&fpv);
|
|
for (;;) {
|
|
struct ofp_header hello;
|
|
int retval;
|
|
|
|
retval = stream_recv(stream, &hello, sizeof hello);
|
|
if (retval == sizeof hello) {
|
|
enum ofpraw raw;
|
|
|
|
CHECK(hello.version, OFP13_VERSION);
|
|
CHECK(ofpraw_decode_partial(&raw, &hello, sizeof hello), 0);
|
|
CHECK(raw, OFPRAW_OFPT_HELLO);
|
|
CHECK(ntohs(hello.length), sizeof hello);
|
|
break;
|
|
} else {
|
|
CHECK_ERRNO(retval, -EAGAIN);
|
|
}
|
|
|
|
vconn_run(vconn);
|
|
CHECK_ERRNO(vconn_connect(vconn), EAGAIN);
|
|
vconn_run_wait(vconn);
|
|
vconn_connect_wait(vconn);
|
|
stream_recv_wait(stream);
|
|
poll_block();
|
|
}
|
|
stream_close(stream);
|
|
error = vconn_connect_block(vconn);
|
|
if (error != ECONNRESET && error != EPIPE) {
|
|
ovs_fatal(0, "unexpected vconn_connect() return value %d (%s)",
|
|
error, ovs_strerror(error));
|
|
}
|
|
vconn_close(vconn);
|
|
}
|
|
|
|
/* Connects to a fake_pvconn with vconn_open(), accepts that connection and
|
|
* sends the 'out' bytes in 'out_size' to it (presumably an OFPT_HELLO
|
|
* message), then verifies that vconn_connect() reports
|
|
* 'expect_connect_error'. */
|
|
static void
|
|
test_send_hello(const char *type, const void *out, size_t out_size,
|
|
int expect_connect_error)
|
|
{
|
|
struct fake_pvconn fpv;
|
|
struct vconn *vconn;
|
|
bool read_hello, connected;
|
|
struct ofpbuf *msg;
|
|
struct stream *stream;
|
|
size_t n_sent;
|
|
|
|
fpv_create(type, &fpv);
|
|
CHECK_ERRNO(vconn_open(fpv.vconn_name, 0, DSCP_DEFAULT, &vconn), 0);
|
|
vconn_run(vconn);
|
|
stream = fpv_accept(&fpv);
|
|
fpv_destroy(&fpv);
|
|
|
|
n_sent = 0;
|
|
while (n_sent < out_size) {
|
|
int retval;
|
|
|
|
retval = stream_send(stream, (char *) out + n_sent, out_size - n_sent);
|
|
if (retval > 0) {
|
|
n_sent += retval;
|
|
} else if (retval == -EAGAIN) {
|
|
stream_run(stream);
|
|
vconn_run(vconn);
|
|
stream_recv_wait(stream);
|
|
vconn_connect_wait(vconn);
|
|
vconn_run_wait(vconn);
|
|
poll_block();
|
|
} else {
|
|
ovs_fatal(0, "stream_send returned unexpected value %d", retval);
|
|
}
|
|
}
|
|
|
|
read_hello = connected = false;
|
|
for (;;) {
|
|
if (!read_hello) {
|
|
struct ofp_header hello;
|
|
int retval = stream_recv(stream, &hello, sizeof hello);
|
|
if (retval == sizeof hello) {
|
|
enum ofpraw raw;
|
|
|
|
CHECK(hello.version, OFP13_VERSION);
|
|
CHECK(ofpraw_decode_partial(&raw, &hello, sizeof hello), 0);
|
|
CHECK(raw, OFPRAW_OFPT_HELLO);
|
|
CHECK(ntohs(hello.length), sizeof hello);
|
|
read_hello = true;
|
|
} else {
|
|
CHECK_ERRNO(retval, -EAGAIN);
|
|
}
|
|
}
|
|
|
|
vconn_run(vconn);
|
|
if (!connected) {
|
|
int error = vconn_connect(vconn);
|
|
if (error == expect_connect_error) {
|
|
if (!error) {
|
|
connected = true;
|
|
} else {
|
|
stream_close(stream);
|
|
vconn_close(vconn);
|
|
return;
|
|
}
|
|
} else {
|
|
CHECK_ERRNO(error, EAGAIN);
|
|
}
|
|
}
|
|
|
|
if (read_hello && connected) {
|
|
break;
|
|
}
|
|
|
|
vconn_run_wait(vconn);
|
|
if (!connected) {
|
|
vconn_connect_wait(vconn);
|
|
}
|
|
if (!read_hello) {
|
|
stream_recv_wait(stream);
|
|
}
|
|
poll_block();
|
|
}
|
|
stream_close(stream);
|
|
CHECK_ERRNO(vconn_recv_block(vconn, &msg), EOF);
|
|
vconn_close(vconn);
|
|
}
|
|
|
|
/* Try connecting and sending a normal hello, which should succeed. */
|
|
static void
|
|
test_send_plain_hello(int argc OVS_UNUSED, char *argv[])
|
|
{
|
|
const char *type = argv[1];
|
|
struct ofpbuf *hello;
|
|
|
|
hello = ofpraw_alloc_xid(OFPRAW_OFPT_HELLO, OFP13_VERSION,
|
|
htonl(0x12345678), 0);
|
|
test_send_hello(type, hello->data, hello->size, 0);
|
|
ofpbuf_delete(hello);
|
|
}
|
|
|
|
/* Try connecting and sending an extra-long hello, which should succeed (since
|
|
* the specification says that implementations must accept and ignore extra
|
|
* data). */
|
|
static void
|
|
test_send_long_hello(int argc OVS_UNUSED, char *argv[])
|
|
{
|
|
const char *type = argv[1];
|
|
struct ofpbuf *hello;
|
|
enum { EXTRA_BYTES = 8 };
|
|
|
|
hello = ofpraw_alloc_xid(OFPRAW_OFPT_HELLO, OFP13_VERSION,
|
|
htonl(0x12345678), EXTRA_BYTES);
|
|
ofpbuf_put_zeros(hello, EXTRA_BYTES);
|
|
ofpmsg_update_length(hello);
|
|
test_send_hello(type, hello->data, hello->size, 0);
|
|
ofpbuf_delete(hello);
|
|
}
|
|
|
|
/* Try connecting and sending an echo request instead of a hello, which should
|
|
* fail with EPROTO. */
|
|
static void
|
|
test_send_echo_hello(int argc OVS_UNUSED, char *argv[])
|
|
{
|
|
const char *type = argv[1];
|
|
struct ofpbuf *echo;
|
|
|
|
echo = ofpraw_alloc_xid(OFPRAW_OFPT_ECHO_REQUEST, OFP13_VERSION,
|
|
htonl(0x12345678), 0);
|
|
test_send_hello(type, echo->data, echo->size, EPROTO);
|
|
ofpbuf_delete(echo);
|
|
}
|
|
|
|
/* Try connecting and sending a hello packet that has its length field as 0,
|
|
* which should fail with EPROTO. */
|
|
static void
|
|
test_send_short_hello(int argc OVS_UNUSED, char *argv[])
|
|
{
|
|
const char *type = argv[1];
|
|
struct ofp_header hello;
|
|
|
|
memset(&hello, 0, sizeof hello);
|
|
test_send_hello(type, &hello, sizeof hello, EPROTO);
|
|
}
|
|
|
|
/* Try connecting and sending a hello packet that has a bad version, which
|
|
* should fail with EPROTO. */
|
|
static void
|
|
test_send_invalid_version_hello(int argc OVS_UNUSED, char *argv[])
|
|
{
|
|
const char *type = argv[1];
|
|
struct ofpbuf *hello;
|
|
|
|
hello = ofpraw_alloc_xid(OFPRAW_OFPT_HELLO, OFP13_VERSION,
|
|
htonl(0x12345678), 0);
|
|
((struct ofp_header *) hello->data)->version = 0;
|
|
test_send_hello(type, hello->data, hello->size, EPROTO);
|
|
ofpbuf_delete(hello);
|
|
}
|
|
|
|
static const struct command commands[] = {
|
|
{"refuse-connection", NULL, 1, 1, test_refuse_connection},
|
|
{"accept-then-close", NULL, 1, 1, test_accept_then_close},
|
|
{"read-hello", NULL, 1, 1, test_read_hello},
|
|
{"send-plain-hello", NULL, 1, 1, test_send_plain_hello},
|
|
{"send-long-hello", NULL, 1, 1, test_send_long_hello},
|
|
{"send-echo-hello", NULL, 1, 1, test_send_echo_hello},
|
|
{"send-short-hello", NULL, 1, 1, test_send_short_hello},
|
|
{"send-invalid-version-hello", NULL, 1, 1, test_send_invalid_version_hello},
|
|
{NULL, NULL, 0, 0, NULL},
|
|
};
|
|
|
|
static void
|
|
test_vconn_main(int argc, char *argv[])
|
|
{
|
|
set_program_name(argv[0]);
|
|
vlog_set_levels(NULL, VLF_ANY_DESTINATION, VLL_EMER);
|
|
vlog_set_levels(NULL, VLF_CONSOLE, VLL_DBG);
|
|
fatal_ignore_sigpipe();
|
|
|
|
time_alarm(10);
|
|
|
|
run_command(argc - 1, argv + 1, commands);
|
|
}
|
|
|
|
OVSTEST_REGISTER("test-vconn", test_vconn_main);
|