mirror of
https://github.com/openvswitch/ovs
synced 2025-10-23 14:57:06 +00:00
1b870ac0ca
When calling ovs_thread_create() without calling fatal_signal_init() first, ovs_thread_create() some times asserts. This dependency is subtle and not very obvious. The root cause seems to be that, within ovs_thread_create(), the multi-threaded state is declared before all initializations are done. Signed-off-by: Andy Zhou <azhou@ovn.org> Acked-by: Ben Pfaff <blp@ovn.org>
52 lines
1.4 KiB
C
52 lines
1.4 KiB
C
/*
|
|
* Copyright (c) 2016 Nicira, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at:
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#include <config.h>
|
|
#undef NDEBUG
|
|
#include "fatal-signal.h"
|
|
#include "ovs-rcu.h"
|
|
#include "ovs-thread.h"
|
|
#include "ovstest.h"
|
|
#include "util.h"
|
|
|
|
static void *
|
|
quiescer_main(void *aux OVS_UNUSED)
|
|
{
|
|
/* A new thread must be not be quiescent */
|
|
ovs_assert(!ovsrcu_is_quiescent());
|
|
ovsrcu_quiesce_start();
|
|
/* After the above call it must be quiescent */
|
|
ovs_assert(ovsrcu_is_quiescent());
|
|
|
|
return NULL;
|
|
}
|
|
|
|
static void
|
|
test_rcu_quiesce(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
|
|
{
|
|
pthread_t quiescer;
|
|
|
|
quiescer = ovs_thread_create("quiescer", quiescer_main, NULL);
|
|
|
|
/* This is the main thread of the process. After spawning its first
|
|
* thread it must not be quiescent. */
|
|
ovs_assert(!ovsrcu_is_quiescent());
|
|
|
|
xpthread_join(quiescer, NULL);
|
|
}
|
|
|
|
OVSTEST_REGISTER("test-rcu-quiesce", test_rcu_quiesce);
|