mirror of
https://github.com/openvswitch/ovs
synced 2025-10-25 15:07:05 +00:00
3fbbcba776
The hidden rules created by in-band control and fail-open should not be included in the table stats reported via OpenFlow. I seem to recall that this was done correctly in some previous version but it has broken since then. This commit fixes the problem and adds a test that should make it harder to break again in the future. Reported-by: Ashok Chippa <a.n.chippa@gmail.com> Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
53 lines
1.8 KiB
C
53 lines
1.8 KiB
C
/*
|
|
* Copyright (c) 2008, 2009, 2010, 2011, 2013, 2015 Nicira, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at:
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#ifndef FAIL_OPEN_H
|
|
#define FAIL_OPEN_H 1
|
|
|
|
#include <stdbool.h>
|
|
#include <stdint.h>
|
|
#include "ofproto-provider.h"
|
|
|
|
struct connmgr;
|
|
struct fail_open;
|
|
struct ofproto;
|
|
|
|
/* Priority of the rule added by the fail-open subsystem when a switch enters
|
|
* fail-open mode. This priority value uniquely identifies a fail-open flow
|
|
* (OpenFlow priorities max out at 65535 and nothing else in Open vSwitch
|
|
* creates flows with this priority). And "f0" is mnemonic for "fail open"! */
|
|
#define FAIL_OPEN_PRIORITY 0xf0f0f0
|
|
|
|
/* Returns true if 'rule' is one created by the "fail open" logic, false
|
|
* otherwise. */
|
|
static inline bool
|
|
is_fail_open_rule(const struct rule *rule)
|
|
{
|
|
return rule->cr.priority == FAIL_OPEN_PRIORITY;
|
|
}
|
|
|
|
struct fail_open *fail_open_create(struct ofproto *, struct connmgr *);
|
|
void fail_open_destroy(struct fail_open *) OVS_EXCLUDED(ofproto_mutex);
|
|
void fail_open_wait(struct fail_open *);
|
|
bool fail_open_is_active(const struct fail_open *);
|
|
void fail_open_run(struct fail_open *);
|
|
void fail_open_maybe_recover(struct fail_open *) OVS_EXCLUDED(ofproto_mutex);
|
|
void fail_open_flushed(struct fail_open *) OVS_EXCLUDED(ofproto_mutex);
|
|
|
|
int fail_open_count_rules(const struct fail_open *);
|
|
|
|
#endif /* fail-open.h */
|