Daniele Di Proietto efa6665e4d odp-util: Commit ICMP set only for ICMP packets. ...

commit_set_icmp_action() should do its job only if the packet is ICMP,
otherwise there will be two problems:

* A set ICMP action will be inserted in the ODP actions and the flow
  will be slow pathed.
* The tp_src and tp_dst field will be unwildcarded.

Normal TCP or UDP packets won't be impacted, because
commit_set_icmp_action() is called after commit_set_port_action() and it
will see the fields as already committed (TCP/UCP transport ports and ICMP
code/type are stored in the same members in struct flow).

MPLS packets though will hit the bug, causing a nonsensical set action
(which will end up zeroing the transport source port) and an invalid
mask to be generated.

The commit also alters an MPLS testcase to trigger the bug.

2015-12-10 17:38:23 -08:00

..

dpdk

netdev-dpdk: Fix sparse warnings.

2015-05-19 14:47:00 -07:00

.gitignore

tests: Add system-userspace-testsuite.

2015-08-07 12:58:37 -07:00

aes128.at

…

appctl.py

…

atlocal.in

atlocal.in: Hide a harmless error on Windows.

2015-10-16 15:44:39 -07:00

auto-attach.at

auto-attach: Add auto-attach support to bridge layer and command set

2015-03-03 16:19:26 -08:00

automake.mk

tests: Add tunnel-push-pop-ipv6 tests

2015-12-04 08:45:39 -08:00

bfd.at

treewide: Fix doubled "the".

2015-08-03 16:50:01 -07:00

bridge.at

bridge: Add test that ports that disappear get added back to the datapath.

2014-05-22 14:25:50 -07:00

bundle.at

…

cfm.at

timeval: Provide a variation for time/warp command.

2014-06-13 11:31:17 -07:00

check-structs.at

…

classifier.at

ofp-actions: Support mixing "conjunction" and "note" actions.

2015-06-26 08:14:20 -07:00

completion.at

completion.at: Improve portability

2015-11-26 18:37:07 +09:00

daemon-py.at

…

daemon.at

tests: Remove the windows service in case it failed to start

2015-06-23 07:40:27 -07:00

dpctl.at

dpctl.at: tap devices don't exist on Windows.

2015-04-22 08:18:56 -07:00

dpif-netdev.at

Add connection tracking label support.

2015-10-13 15:34:16 -07:00

file_name.at

file_name.at: Skip a symlink related test for Windows.

2014-06-26 16:46:58 -07:00

flowgen.pl

ofp-util: For OF1.0, don't wildcard PCP field when 802.1Q header absent.

2015-08-24 11:01:00 -07:00

glibc.supp

…

heap.at

…

idltest2.ovsschema

ovsdb-idl: Tolerate missing tables and columns.

2015-03-31 17:10:58 -07:00

idltest.ann

…

idltest.ovsschema

…

interface-reconfigure.at

interface-reconfigure.at: Skip POSIX specfic tests for Windows.

2014-06-26 16:53:40 -07:00

json.at

json: Fix parsing of strings that end with a backslash.

2014-06-25 11:39:25 -07:00

jsonrpc-py.at

tests: Automatically initialize OVS_*DIR vars when tests begin.

2015-09-09 10:24:24 -07:00

jsonrpc.at

tests: Automatically initialize OVS_*DIR vars when tests begin.

2015-09-09 10:24:24 -07:00

lacp.at

bridge: Keep bond active slave selection across OVS restart

2014-10-06 10:23:46 -07:00

learn.at

metaflow: Extend size of mf_value to 128 bytes.

2015-06-25 11:08:58 -07:00

lib.at

lib: Add test for library usage

2014-12-15 14:15:25 +01:00

library.at

tests: Automatically initialize OVS_*DIR vars when tests begin.

2015-09-09 10:24:24 -07:00

lockfile.at

lockfile: Modify tests for Windows.

2014-06-24 09:53:10 -07:00

MockXenAPI.py

…

mpls-xlate.at

odp-util: Commit ICMP set only for ICMP packets.

2015-12-10 17:38:23 -08:00

multipath.at

…

odp.at

netdev-vport: Add IPv6 support for build/push/pop tunnel header

2015-12-04 08:32:38 -08:00

ofp-actions.at

conntrack: Add support for NAT.

2015-11-25 16:04:59 -08:00

ofp-errors.at

ofp-errors: Fix bugs in treatment of OpenFlow experimenter errors.

2014-09-04 12:31:00 -07:00

ofp-print.at

ofproto: Implement OF1.4 error code for set-async-config

2015-11-30 11:23:09 -08:00

ofp-util.at

ofp-print: Enable printing OF1.4 version

2014-05-01 07:25:47 -07:00

ofproto-dpif.at

ofp-actions: Look inside write_actions for output ports and groups.

2015-11-29 10:56:23 -08:00

ofproto-macros.at

tnl-arp-cache: Rename module and functions to tnl-neigh-cache.

2015-11-30 10:27:51 -08:00

ofproto.at

Allow flow-based IPv6 tunnels to be configured with OpenFlow

2015-12-04 08:41:58 -08:00

openssl.supp

…

ovn-controller-vtep.at

ovn-controller-vtep.at: Fix a race

2015-11-26 18:37:21 +09:00

ovn-controller.at

ovn: Implement logical patch ports.

2015-10-16 23:52:40 -07:00

ovn-nbctl.at

ovn-nb: Rename Port_Bindings 'macs' column to 'addresses'.

2015-10-16 23:52:41 -07:00

ovn-sbctl.at

ovn-nb: Rename Port_Bindings 'macs' column to 'addresses'.

2015-10-16 23:52:41 -07:00

ovn.at

ovn: support ARP response for known IPs

2015-12-04 08:58:00 -08:00

ovs-macros.at

tests: Make OVS_WAIT_WHILE, OVS_WAIT_UNTIL run even faster in some cases.

2015-11-26 13:28:29 -08:00

ovs-monitor-ipsec.at

tests: Replace ON_EXIT m4 macro by on_exit() shell function.

2015-09-09 10:28:20 -07:00

ovs-ofctl.at

ovs-ofctl: Support multiple tables in replace-flows and diff-flows.

2015-11-30 16:12:11 -08:00

ovs-vsctl.at

tests: Make parse_listening_port entirely reliable.

2015-11-26 13:28:29 -08:00

ovs-vswitchd.at

tests: Replace ON_EXIT m4 macro by on_exit() shell function.

2015-09-09 10:28:20 -07:00

ovs-xapi-sync.at

tests: Replace ON_EXIT m4 macro by on_exit() shell function.

2015-09-09 10:28:20 -07:00

ovsdb-column.at

…

ovsdb-condition.at

ovsdb: Allow comparison on optional scalar types

2014-08-20 10:25:35 -07:00

ovsdb-data.at

json: Fix error message for corner case in json_string_unescape().

2015-05-29 15:17:24 -07:00

ovsdb-execution.at

tests: Automatically initialize OVS_*DIR vars when tests begin.

2015-09-09 10:24:24 -07:00

ovsdb-idl.at

tests: Make parse_listening_port entirely reliable.

2015-11-26 13:28:29 -08:00

ovsdb-log.at

…

ovsdb-macros.at

tests: Automatically initialize OVS_*DIR vars when tests begin.

2015-09-09 10:24:24 -07:00

ovsdb-monitor-sort.pl

ovsdb-monitor.at: Changes for Windows.

2014-05-28 08:34:28 -07:00

ovsdb-monitor.at

tests: Automatically initialize OVS_*DIR vars when tests begin.

2015-09-09 10:24:24 -07:00

ovsdb-mutation.at

…

ovsdb-query.at

…

ovsdb-row.at

build: Allow building with autoconf 2.63

2014-06-27 08:21:44 -07:00

ovsdb-schema.at

…

ovsdb-server.at

tests: Make parse_listening_port entirely reliable.

2015-11-26 13:28:29 -08:00

ovsdb-table.at

…

ovsdb-tool.at

tests: Automatically initialize OVS_*DIR vars when tests begin.

2015-09-09 10:24:24 -07:00

ovsdb-transaction.at

…

ovsdb-trigger.at

…

ovsdb-types.at

…

ovsdb.at

…

ovstest.c

command-line: add ovs_cmdl_context

2015-03-17 08:15:57 -07:00

ovstest.h

command-line: add ovs_cmdl_context

2015-03-17 08:15:57 -07:00

reconnect.at

…

rstp.at

rstp: Refactor rstp_port_set_administrative_bridge_port__().

2014-11-14 14:07:51 -08:00

run-oftest

tests: Check the existance of WHY-OVS.md instead of WHY-OVS.

2014-10-30 10:24:05 -07:00

run-ryu

run-ryu: Use the IANA OpenFlow port number

2015-04-16 15:08:48 +09:00

stp.at

lib/stp,rstp: Add unit more unit tests.

2014-09-09 11:45:43 -07:00

system-common-macros.at

system-traffic: Add internal port conntrack tests.

2015-11-24 14:59:18 -08:00

system-kmod-macros.at

tests: Check for NAT modules in system testsuite.

2015-12-04 15:01:05 -08:00

system-kmod-testsuite.at

tests: Rename kmod-testsuite to system-kmod-testsuite.

2015-08-07 12:58:26 -07:00

system-traffic.at

conntrack: Add support for NAT.

2015-11-25 16:04:59 -08:00

system-userspace-macros.at

system-tests: Make bridge creation more consistent.

2015-11-24 13:33:22 -08:00

system-userspace-testsuite.at

tests: Add system-userspace-testsuite.

2015-08-07 12:58:37 -07:00

test-aa.c

packets: Avoid compile errors.

2015-09-04 16:24:04 -07:00

test-aes128.c

ovs_assert, tests: Support NDEBUG.

2014-10-30 09:14:46 -07:00

test-atomic.c

test-atomic: Bump test duration for multi-thread tests

2015-11-26 18:37:11 +09:00

test-bitmap.c

command-line: add ovs_cmdl_context

2015-03-17 08:15:57 -07:00

test-bundle.c

ofpbuf: Simplify ofpbuf API.

2015-03-03 13:37:39 -08:00

test-byte-order.c

ovs_assert, tests: Support NDEBUG.

2014-10-30 09:14:46 -07:00

test-classifier.c

userspace: Define and use struct eth_addr.

2015-08-28 14:55:11 -07:00

test-cmap.c

bitmap: Convert single bitmap functions to 64-bit.

2015-06-25 11:08:31 -07:00

test-csum.c

test-csum: endianess fix

2015-04-10 08:45:45 -07:00

test-daemon.py

…

test-flows.c

dp-packet: Remove ofpbuf dependency.

2015-03-03 13:37:37 -08:00

test-hash.c

types: Rename and move ovs_u128_equal().

2015-06-09 18:20:02 -07:00

test-heap.c

command-line: add ovs_cmdl_context

2015-03-17 08:15:57 -07:00

test-hindex.c

ovs_assert, tests: Support NDEBUG.

2014-10-30 09:14:46 -07:00

test-hmap.c

ovs_assert, tests: Support NDEBUG.

2014-10-30 09:14:46 -07:00

test-json.c

ovs_assert, tests: Support NDEBUG.

2014-10-30 09:14:46 -07:00

test-json.py

…

test-jsonrpc.c

lib/daemon: support --user option for all OVS daemon

2015-09-30 20:43:46 -07:00

test-jsonrpc.py

…

test-l7.py

system-tests: Workaround for pyftpdlib bug handling IPv6 addresses.

2015-11-25 15:30:16 -08:00

test-lib.c

lib: Add test for library usage

2014-12-15 14:15:25 +01:00

test-list.c

lib/list: Add LIST_FOR_EACH_POP.

2015-04-06 14:02:28 -07:00

test-lockfile.c

lib: Move vlog.h to <openvswitch/vlog.h>

2014-12-15 14:15:19 +01:00

test-multipath.c

ovs_assert, tests: Support NDEBUG.

2014-10-30 09:14:46 -07:00

test-netflow.c

lib/daemon: support --user option for all OVS daemon

2015-09-30 20:43:46 -07:00

test-odp.c

Add connection tracking label support.

2015-10-13 15:34:16 -07:00

test-ofpbuf.c

ofpbuf: Update msg when resizing ofpbuf.

2015-07-20 10:19:12 -07:00

test-ovn.c

test-ovn: Fix memory leak in option processing.

2015-10-22 18:00:16 -07:00

test-ovsdb.c

ovsdb-idl: Add support for change tracking.

2015-11-23 08:47:10 -08:00

test-ovsdb.py

ovsdb-idl: Support for readonly columns that are fetched on-demand

2015-11-23 08:34:54 -08:00

test-packets.c

packets: Add ipv6_parse_masked() function.

2015-11-24 12:48:44 -08:00

test-random.c

ovs_assert, tests: Support NDEBUG.

2014-10-30 09:14:46 -07:00

test-reconnect.c

command-line: add ovs_cmdl_context

2015-03-17 08:15:57 -07:00

test-reconnect.py

…

test-rstp.c

dp-packet: Remove ofpbuf dependency.

2015-03-03 13:37:37 -08:00

test-sflow.c

lib/daemon: support --user option for all OVS daemon

2015-09-30 20:43:46 -07:00

test-sha1.c

ovs_assert, tests: Support NDEBUG.

2014-10-30 09:14:46 -07:00

test-stp.c

dp-packet: Remove ofpbuf dependency.

2015-03-03 13:37:37 -08:00

test-strtok_r.c

…

test-type-props.c

type-props: Suppress warnings in newer Clang and GCC.

2015-07-30 18:00:01 -07:00

test-unix-socket.c

ovs_assert, tests: Support NDEBUG.

2014-10-30 09:14:46 -07:00

test-unix-socket.py

…

test-unixctl.py

…

test-util.c

configure: Stop avoiding -Wformat-zero-length.

2015-06-10 09:19:39 -07:00

test-uuid.c

ovs_assert, tests: Support NDEBUG.

2014-10-30 09:14:46 -07:00

test-vconn.c

command-line: add ovs_cmdl_context

2015-03-17 08:15:57 -07:00

test-vlog.py

…

testsuite.at

tests: Add tunnel-push-pop-ipv6 tests

2015-12-04 08:45:39 -08:00

testsuite.patch

tests: Enable running parallel unit tests for Windows.

2015-02-13 10:41:43 -08:00

tunnel-push-pop-ipv6.at

tests: Add tunnel-push-pop-ipv6 tests

2015-12-04 08:45:39 -08:00

tunnel-push-pop.at

tnl-arp-cache: Rename module and functions to tnl-neigh-cache.

2015-11-30 10:27:51 -08:00

tunnel.at

tun-metadata: Provide error messages during auto-allocation.

2015-09-09 09:43:43 -07:00

unixctl-py.at

tests: Replace ON_EXIT m4 macro by on_exit() shell function.

2015-09-09 10:28:20 -07:00

uuid.at

…

uuidfilt.pl

…

valgrind-wrapper.in

…

vconn.at

tests: Automatically initialize OVS_*DIR vars when tests begin.

2015-09-09 10:24:24 -07:00

vlan-splinters.at

lib/match: Do not format undefined fields.

2014-10-06 15:33:37 -07:00

vlog.at

tests: Replace ON_EXIT m4 macro by on_exit() shell function.

2015-09-09 10:28:20 -07:00

vtep-ctl.at

vtep-ctl.at: Fix a regex

2015-11-26 18:37:26 +09:00