2009-07-08 13:19:16 -07:00
|
|
|
|
/*
|
2013-06-24 10:54:49 -07:00
|
|
|
|
* Copyright (c) 2008, 2009, 2010, 2011, 2012, 2013 Nicira, Inc.
|
2009-07-08 13:19:16 -07:00
|
|
|
|
*
|
2009-06-15 15:11:30 -07:00
|
|
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
|
* you may not use this file except in compliance with the License.
|
|
|
|
|
* You may obtain a copy of the License at:
|
2009-07-08 13:19:16 -07:00
|
|
|
|
*
|
2009-06-15 15:11:30 -07:00
|
|
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
|
*
|
|
|
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
|
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
|
* See the License for the specific language governing permissions and
|
|
|
|
|
* limitations under the License.
|
2009-07-08 13:19:16 -07:00
|
|
|
|
*/
|
|
|
|
|
#include <config.h>
|
|
|
|
|
#include "fatal-signal.h"
|
|
|
|
|
#include <errno.h>
|
|
|
|
|
#include <signal.h>
|
|
|
|
|
#include <stdbool.h>
|
|
|
|
|
#include <stdio.h>
|
2009-12-08 14:11:22 -08:00
|
|
|
|
#include <stdint.h>
|
2009-07-08 13:19:16 -07:00
|
|
|
|
#include <stdlib.h>
|
|
|
|
|
#include <string.h>
|
|
|
|
|
#include <unistd.h>
|
2013-05-09 10:54:04 -07:00
|
|
|
|
#include "ovs-thread.h"
|
2009-12-08 14:11:22 -08:00
|
|
|
|
#include "poll-loop.h"
|
2009-09-21 12:38:58 -07:00
|
|
|
|
#include "shash.h"
|
2011-03-25 15:26:30 -07:00
|
|
|
|
#include "sset.h"
|
2011-03-31 16:23:50 -07:00
|
|
|
|
#include "signals.h"
|
2009-12-08 14:11:22 -08:00
|
|
|
|
#include "socket-util.h"
|
2009-07-08 13:19:16 -07:00
|
|
|
|
#include "util.h"
|
2009-09-21 12:37:20 -07:00
|
|
|
|
#include "vlog.h"
|
|
|
|
|
|
2011-09-22 21:24:12 +09:00
|
|
|
|
#include "type-props.h"
|
|
|
|
|
|
|
|
|
|
#ifndef SIG_ATOMIC_MAX
|
|
|
|
|
#define SIG_ATOMIC_MAX TYPE_MAXIMUM(sig_atomic_t)
|
|
|
|
|
#endif
|
|
|
|
|
|
2010-10-19 14:47:01 -07:00
|
|
|
|
VLOG_DEFINE_THIS_MODULE(fatal_signal);
|
2010-07-16 11:02:49 -07:00
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
/* Signals to catch. */
|
|
|
|
|
static const int fatal_signals[] = { SIGTERM, SIGINT, SIGHUP, SIGALRM };
|
|
|
|
|
|
|
|
|
|
/* Hooks to call upon catching a signal */
|
|
|
|
|
struct hook {
|
2010-01-15 15:28:14 -08:00
|
|
|
|
void (*hook_cb)(void *aux);
|
|
|
|
|
void (*cancel_cb)(void *aux);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
void *aux;
|
|
|
|
|
bool run_at_exit;
|
|
|
|
|
};
|
|
|
|
|
#define MAX_HOOKS 32
|
|
|
|
|
static struct hook hooks[MAX_HOOKS];
|
|
|
|
|
static size_t n_hooks;
|
|
|
|
|
|
2009-12-08 14:11:22 -08:00
|
|
|
|
static int signal_fds[2];
|
|
|
|
|
static volatile sig_atomic_t stored_sig_nr = SIG_ATOMIC_MAX;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2013-07-30 15:31:48 -07:00
|
|
|
|
static struct ovs_mutex mutex;
|
2013-05-09 10:54:04 -07:00
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static void atexit_handler(void);
|
|
|
|
|
static void call_hooks(int sig_nr);
|
|
|
|
|
|
2013-05-09 10:54:04 -07:00
|
|
|
|
/* Initializes the fatal signal handling module. Calling this function is
|
|
|
|
|
* optional, because calling any other function in the module will also
|
|
|
|
|
* initialize it. However, in a multithreaded program, the module must be
|
|
|
|
|
* initialized while the process is still single-threaded. */
|
|
|
|
|
void
|
2009-12-08 14:11:22 -08:00
|
|
|
|
fatal_signal_init(void)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
|
|
|
|
static bool inited = false;
|
2009-12-08 14:11:22 -08:00
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
if (!inited) {
|
|
|
|
|
size_t i;
|
|
|
|
|
|
2013-05-09 10:54:04 -07:00
|
|
|
|
assert_single_threaded();
|
2009-07-08 13:19:16 -07:00
|
|
|
|
inited = true;
|
2009-12-08 14:11:22 -08:00
|
|
|
|
|
Use "error-checking" mutexes in place of other kinds wherever possible.
We've seen a number of deadlocks in the tree since thread safety was
introduced. So far, all of these are self-deadlocks, that is, a single
thread acquiring a lock and then attempting to re-acquire the same lock
recursively. When this has happened, the process simply hung, and it was
somewhat difficult to find the cause.
POSIX "error-checking" mutexes check for this specific problem (and
others). This commit switches from other types of mutexes to
error-checking mutexes everywhere that we can, that is, everywhere that
we're not using recursive mutexes. This ought to help find problems more
quickly in the future.
There might be performance advantages to other kinds of mutexes in some
cases. However, the existing mutex type choices were just guesses, so I'd
rather go for easy detection of errors until we know that other mutex
types actually perform better in specific cases. Also, I did a quick
microbenchmark of glibc mutex types on my host and found that the
error checking mutexes weren't any slower than the other types, at least
when the mutex is uncontended.
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Ethan Jackson <ethan@nicira.com>
2013-08-20 13:40:02 -07:00
|
|
|
|
ovs_mutex_init_recursive(&mutex);
|
2012-09-28 21:06:41 +00:00
|
|
|
|
xpipe_nonblocking(signal_fds);
|
2009-12-08 14:11:22 -08:00
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
for (i = 0; i < ARRAY_SIZE(fatal_signals); i++) {
|
|
|
|
|
int sig_nr = fatal_signals[i];
|
|
|
|
|
struct sigaction old_sa;
|
|
|
|
|
|
2011-03-31 16:23:50 -07:00
|
|
|
|
xsigaction(sig_nr, NULL, &old_sa);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
if (old_sa.sa_handler == SIG_DFL
|
|
|
|
|
&& signal(sig_nr, fatal_signal_handler) == SIG_ERR) {
|
2013-06-24 10:54:49 -07:00
|
|
|
|
VLOG_FATAL("signal failed (%s)", ovs_strerror(errno));
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
atexit(atexit_handler);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2013-05-09 10:54:04 -07:00
|
|
|
|
/* Registers 'hook_cb' to be called from inside poll_block() following a fatal
|
|
|
|
|
* signal. 'hook_cb' does not need to be async-signal-safe. In a
|
|
|
|
|
* multithreaded program 'hook_cb' might be called from any thread, with
|
|
|
|
|
* threads other than the one running 'hook_cb' in unknown states.
|
2009-12-08 14:11:22 -08:00
|
|
|
|
*
|
2013-05-09 10:54:04 -07:00
|
|
|
|
* If 'run_at_exit' is true, 'hook_cb' is also called during normal process
|
|
|
|
|
* termination, e.g. when exit() is called or when main() returns.
|
2010-01-15 15:28:14 -08:00
|
|
|
|
*
|
|
|
|
|
* If the current process forks, fatal_signal_fork() may be called to clear the
|
|
|
|
|
* parent process's fatal signal hooks, so that 'hook_cb' is only called when
|
|
|
|
|
* the child terminates, not when the parent does. When fatal_signal_fork() is
|
|
|
|
|
* called, it calls the 'cancel_cb' function if it is nonnull, passing 'aux',
|
|
|
|
|
* to notify that the hook has been canceled. This allows the hook to free
|
|
|
|
|
* memory, etc. */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
void
|
2010-01-15 15:28:14 -08:00
|
|
|
|
fatal_signal_add_hook(void (*hook_cb)(void *aux), void (*cancel_cb)(void *aux),
|
|
|
|
|
void *aux, bool run_at_exit)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2009-12-08 14:11:22 -08:00
|
|
|
|
fatal_signal_init();
|
2010-01-15 15:28:14 -08:00
|
|
|
|
|
2013-07-30 15:31:48 -07:00
|
|
|
|
ovs_mutex_lock(&mutex);
|
2012-11-06 13:14:55 -08:00
|
|
|
|
ovs_assert(n_hooks < MAX_HOOKS);
|
2010-01-15 15:28:14 -08:00
|
|
|
|
hooks[n_hooks].hook_cb = hook_cb;
|
|
|
|
|
hooks[n_hooks].cancel_cb = cancel_cb;
|
2009-12-08 14:11:22 -08:00
|
|
|
|
hooks[n_hooks].aux = aux;
|
|
|
|
|
hooks[n_hooks].run_at_exit = run_at_exit;
|
|
|
|
|
n_hooks++;
|
2013-07-30 15:31:48 -07:00
|
|
|
|
ovs_mutex_unlock(&mutex);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Handles fatal signal number 'sig_nr'.
|
|
|
|
|
*
|
|
|
|
|
* Ordinarily this is the actual signal handler. When other code needs to
|
|
|
|
|
* handle one of our signals, however, it can register for that signal and, if
|
|
|
|
|
* and when necessary, call this function to do fatal signal processing for it
|
|
|
|
|
* and terminate the process. Currently only timeval.c does this, for SIGALRM.
|
|
|
|
|
* (It is not important whether the other code sets up its signal handler
|
|
|
|
|
* before or after this file, because this file will only set up a signal
|
|
|
|
|
* handler in the case where the signal has its default handling.) */
|
|
|
|
|
void
|
|
|
|
|
fatal_signal_handler(int sig_nr)
|
|
|
|
|
{
|
2009-12-08 14:11:22 -08:00
|
|
|
|
ignore(write(signal_fds[1], "", 1));
|
|
|
|
|
stored_sig_nr = sig_nr;
|
|
|
|
|
}
|
|
|
|
|
|
2010-04-13 09:28:13 -07:00
|
|
|
|
/* Check whether a fatal signal has occurred and, if so, call the fatal signal
|
|
|
|
|
* hooks and exit.
|
|
|
|
|
*
|
|
|
|
|
* This function is called automatically by poll_block(), but specialized
|
|
|
|
|
* programs that may not always call poll_block() on a regular basis should
|
|
|
|
|
* also call it periodically. (Therefore, any function with "block" in its
|
|
|
|
|
* name should call fatal_signal_run() each time it is called, either directly
|
|
|
|
|
* or through poll_block(), because such functions can only used by specialized
|
|
|
|
|
* programs that can afford to block outside their main loop around
|
|
|
|
|
* poll_block().)
|
|
|
|
|
*/
|
2009-12-08 14:11:22 -08:00
|
|
|
|
void
|
|
|
|
|
fatal_signal_run(void)
|
|
|
|
|
{
|
2012-06-26 14:43:54 +00:00
|
|
|
|
sig_atomic_t sig_nr;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2010-03-23 15:27:44 -07:00
|
|
|
|
fatal_signal_init();
|
|
|
|
|
|
|
|
|
|
sig_nr = stored_sig_nr;
|
2009-12-08 14:11:22 -08:00
|
|
|
|
if (sig_nr != SIG_ATOMIC_MAX) {
|
2013-04-16 15:25:10 -07:00
|
|
|
|
char namebuf[SIGNAL_NAME_BUFSIZE];
|
|
|
|
|
|
2013-07-30 15:31:48 -07:00
|
|
|
|
ovs_mutex_lock(&mutex);
|
2013-05-09 10:54:04 -07:00
|
|
|
|
|
2012-05-08 16:54:21 -07:00
|
|
|
|
VLOG_WARN("terminating with signal %d (%s)",
|
2013-04-16 15:25:10 -07:00
|
|
|
|
(int)sig_nr, signal_name(sig_nr, namebuf, sizeof namebuf));
|
2009-12-08 14:11:22 -08:00
|
|
|
|
call_hooks(sig_nr);
|
|
|
|
|
|
|
|
|
|
/* Re-raise the signal with the default handling so that the program
|
|
|
|
|
* termination status reflects that we were killed by this signal */
|
|
|
|
|
signal(sig_nr, SIG_DFL);
|
|
|
|
|
raise(sig_nr);
|
2013-05-09 10:54:04 -07:00
|
|
|
|
|
2013-07-30 15:31:48 -07:00
|
|
|
|
ovs_mutex_unlock(&mutex);
|
2013-05-09 10:54:04 -07:00
|
|
|
|
NOT_REACHED();
|
2009-12-08 14:11:22 -08:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void
|
|
|
|
|
fatal_signal_wait(void)
|
|
|
|
|
{
|
2010-03-23 15:27:44 -07:00
|
|
|
|
fatal_signal_init();
|
2009-12-08 14:11:22 -08:00
|
|
|
|
poll_fd_wait(signal_fds[0], POLLIN);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
atexit_handler(void)
|
|
|
|
|
{
|
2010-01-15 15:28:14 -08:00
|
|
|
|
call_hooks(0);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
call_hooks(int sig_nr)
|
|
|
|
|
{
|
|
|
|
|
static volatile sig_atomic_t recurse = 0;
|
|
|
|
|
if (!recurse) {
|
|
|
|
|
size_t i;
|
|
|
|
|
|
|
|
|
|
recurse = 1;
|
|
|
|
|
|
|
|
|
|
for (i = 0; i < n_hooks; i++) {
|
|
|
|
|
struct hook *h = &hooks[i];
|
|
|
|
|
if (sig_nr || h->run_at_exit) {
|
2010-01-15 15:28:14 -08:00
|
|
|
|
h->hook_cb(h->aux);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2011-03-25 15:26:30 -07:00
|
|
|
|
/* Files to delete on exit. */
|
|
|
|
|
static struct sset files = SSET_INITIALIZER(&files);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2010-01-15 15:28:14 -08:00
|
|
|
|
/* Has a hook function been registered with fatal_signal_add_hook() (and not
|
|
|
|
|
* cleared by fatal_signal_fork())? */
|
|
|
|
|
static bool added_hook;
|
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static void unlink_files(void *aux);
|
2010-01-15 15:28:14 -08:00
|
|
|
|
static void cancel_files(void *aux);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static void do_unlink_files(void);
|
|
|
|
|
|
|
|
|
|
/* Registers 'file' to be unlinked when the program terminates via exit() or a
|
|
|
|
|
* fatal signal. */
|
|
|
|
|
void
|
|
|
|
|
fatal_signal_add_file_to_unlink(const char *file)
|
|
|
|
|
{
|
2013-05-09 10:54:04 -07:00
|
|
|
|
fatal_signal_init();
|
|
|
|
|
|
2013-07-30 15:31:48 -07:00
|
|
|
|
ovs_mutex_lock(&mutex);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
if (!added_hook) {
|
|
|
|
|
added_hook = true;
|
2010-01-15 15:28:14 -08:00
|
|
|
|
fatal_signal_add_hook(unlink_files, cancel_files, NULL, true);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-03-25 15:26:30 -07:00
|
|
|
|
sset_add(&files, file);
|
2013-07-30 15:31:48 -07:00
|
|
|
|
ovs_mutex_unlock(&mutex);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Unregisters 'file' from being unlinked when the program terminates via
|
|
|
|
|
* exit() or a fatal signal. */
|
|
|
|
|
void
|
|
|
|
|
fatal_signal_remove_file_to_unlink(const char *file)
|
|
|
|
|
{
|
2013-05-09 10:54:04 -07:00
|
|
|
|
fatal_signal_init();
|
|
|
|
|
|
2013-07-30 15:31:48 -07:00
|
|
|
|
ovs_mutex_lock(&mutex);
|
2011-03-25 15:26:30 -07:00
|
|
|
|
sset_find_and_delete(&files, file);
|
2013-07-30 15:31:48 -07:00
|
|
|
|
ovs_mutex_unlock(&mutex);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2009-09-21 12:37:20 -07:00
|
|
|
|
/* Like fatal_signal_remove_file_to_unlink(), but also unlinks 'file'.
|
|
|
|
|
* Returns 0 if successful, otherwise a positive errno value. */
|
|
|
|
|
int
|
|
|
|
|
fatal_signal_unlink_file_now(const char *file)
|
|
|
|
|
{
|
2013-05-09 10:54:04 -07:00
|
|
|
|
int error;
|
|
|
|
|
|
|
|
|
|
fatal_signal_init();
|
|
|
|
|
|
2013-07-30 15:31:48 -07:00
|
|
|
|
ovs_mutex_lock(&mutex);
|
2013-05-09 10:54:04 -07:00
|
|
|
|
|
|
|
|
|
error = unlink(file) ? errno : 0;
|
2009-09-21 12:37:20 -07:00
|
|
|
|
if (error) {
|
2013-06-24 10:54:49 -07:00
|
|
|
|
VLOG_WARN("could not unlink \"%s\" (%s)", file, ovs_strerror(error));
|
2009-09-21 12:37:20 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fatal_signal_remove_file_to_unlink(file);
|
|
|
|
|
|
2013-07-30 15:31:48 -07:00
|
|
|
|
ovs_mutex_unlock(&mutex);
|
2013-05-09 10:54:04 -07:00
|
|
|
|
|
2009-09-21 12:37:20 -07:00
|
|
|
|
return error;
|
|
|
|
|
}
|
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static void
|
2010-02-11 10:59:47 -08:00
|
|
|
|
unlink_files(void *aux OVS_UNUSED)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2010-08-30 00:24:53 -07:00
|
|
|
|
do_unlink_files();
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2010-01-15 15:28:14 -08:00
|
|
|
|
static void
|
2010-02-11 11:11:23 -08:00
|
|
|
|
cancel_files(void *aux OVS_UNUSED)
|
2010-01-15 15:28:14 -08:00
|
|
|
|
{
|
2011-03-25 15:26:30 -07:00
|
|
|
|
sset_clear(&files);
|
2010-01-15 15:28:14 -08:00
|
|
|
|
added_hook = false;
|
|
|
|
|
}
|
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
static void
|
|
|
|
|
do_unlink_files(void)
|
|
|
|
|
{
|
2011-03-25 15:26:30 -07:00
|
|
|
|
const char *file;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-03-25 15:26:30 -07:00
|
|
|
|
SSET_FOR_EACH (file, &files) {
|
|
|
|
|
unlink(file);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2010-01-15 15:28:14 -08:00
|
|
|
|
/* Clears all of the fatal signal hooks without executing them. If any of the
|
|
|
|
|
* hooks passed a 'cancel_cb' function to fatal_signal_add_hook(), then those
|
|
|
|
|
* functions will be called, allowing them to free resources, etc.
|
|
|
|
|
*
|
|
|
|
|
* Following a fork, one of the resulting processes can call this function to
|
|
|
|
|
* allow it to terminate without calling the hooks registered before calling
|
|
|
|
|
* this function. New hooks registered after calling this function will take
|
|
|
|
|
* effect normally. */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
void
|
|
|
|
|
fatal_signal_fork(void)
|
|
|
|
|
{
|
|
|
|
|
size_t i;
|
|
|
|
|
|
2013-05-09 10:54:04 -07:00
|
|
|
|
assert_single_threaded();
|
|
|
|
|
|
2010-01-15 15:28:14 -08:00
|
|
|
|
for (i = 0; i < n_hooks; i++) {
|
|
|
|
|
struct hook *h = &hooks[i];
|
|
|
|
|
if (h->cancel_cb) {
|
|
|
|
|
h->cancel_cb(h->aux);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
2010-01-15 15:28:14 -08:00
|
|
|
|
n_hooks = 0;
|
2009-12-08 14:11:22 -08:00
|
|
|
|
|
|
|
|
|
/* Raise any signals that we have already received with the default
|
|
|
|
|
* handler. */
|
|
|
|
|
if (stored_sig_nr != SIG_ATOMIC_MAX) {
|
|
|
|
|
raise(stored_sig_nr);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
}
|