2009-07-08 13:19:16 -07:00
|
|
|
|
/*
|
2014-01-09 16:26:12 -08:00
|
|
|
|
* Copyright (c) 2008, 2009, 2010, 2011, 2012, 2013, 2014 Nicira, Inc.
|
2009-07-08 13:19:16 -07:00
|
|
|
|
*
|
2009-06-15 15:11:30 -07:00
|
|
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
|
* you may not use this file except in compliance with the License.
|
|
|
|
|
* You may obtain a copy of the License at:
|
2009-07-08 13:19:16 -07:00
|
|
|
|
*
|
2009-06-15 15:11:30 -07:00
|
|
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
|
*
|
|
|
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
|
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
|
* See the License for the specific language governing permissions and
|
|
|
|
|
* limitations under the License.
|
2009-07-08 13:19:16 -07:00
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#include <config.h>
|
2017-11-03 13:53:53 +08:00
|
|
|
|
#include "openvswitch/poll-loop.h"
|
2009-07-08 13:19:16 -07:00
|
|
|
|
#include <errno.h>
|
2009-11-06 10:43:50 -08:00
|
|
|
|
#include <inttypes.h>
|
2009-07-08 13:19:16 -07:00
|
|
|
|
#include <poll.h>
|
|
|
|
|
#include <stdlib.h>
|
|
|
|
|
#include <string.h>
|
|
|
|
|
#include "coverage.h"
|
2016-03-03 10:20:46 -08:00
|
|
|
|
#include "openvswitch/dynamic-string.h"
|
2009-12-08 14:11:22 -08:00
|
|
|
|
#include "fatal-signal.h"
|
2016-03-25 14:10:21 -07:00
|
|
|
|
#include "openvswitch/list.h"
|
2013-07-10 10:54:41 -07:00
|
|
|
|
#include "ovs-thread.h"
|
2013-08-06 09:39:10 -07:00
|
|
|
|
#include "seq.h"
|
poll-loop: Make wakeup logging more portable and easier to understand.
Until now, when the poll_loop module's log level was turned up to "debug",
it would log a backtrace of the call stack for the event that caused poll()
to wake up in poll_block(). This was pretty useful from time to time to
find out why ovs-vswitchd was using more CPU than expected, because we
could find out what was causing it to wake up.
But there were some issues. One is simply that the backtrace was printed
as a series of hexadecimal numbers, so GDB or another debugger was needed
to translate it into human-readable format. Compiler optimizations meant
that even the human-readable backtrace wasn't, in my experience, as helpful
as it could have been. And, of course, one needed to have the binary to
interpret the backtrace. When the backtrace couldn't be interpreted or
wasn't meaningful, there was essentially nothing to fall back on.
This commit changes the way that "debug" logging for poll_block() wakeups
works. Instead of logging a backtrace, it logs the source code file name
and line number of the call to a poll_loop function, using __FILE__ and
__LINE__. This is by itself much more meaningful than a sequence of
hexadecimal numbers, since no additional interpretation is necessary. It
can be useful even if the Open vSwitch version is only approximately known.
In addition to the file and line, this commit adds, for wakeups caused by
file descriptors, information about the file descriptor itself: what kind
of file it is (regular file, directory, socket, etc.), the name of the file
(on Linux only), and the local and remote endpoints for socket file
descriptors.
Here are a few examples of the new output format:
932-ms timeout at ../ofproto/in-band.c:507
[POLLIN] on fd 20 (192.168.0.20:35388<->192.168.0.3:6633) at ../lib/stream-fd.c:149
[POLLIN] on fd 7 (FIFO pipe:[48049]) at ../lib/fatal-signal.c:168
2011-05-13 13:06:49 -07:00
|
|
|
|
#include "socket-util.h"
|
2009-07-08 13:19:16 -07:00
|
|
|
|
#include "timeval.h"
|
2014-12-15 14:10:38 +01:00
|
|
|
|
#include "openvswitch/vlog.h"
|
2016-07-12 16:37:34 -05:00
|
|
|
|
#include "openvswitch/hmap.h"
|
2014-01-09 16:26:12 -08:00
|
|
|
|
#include "hash.h"
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2010-10-19 14:47:01 -07:00
|
|
|
|
VLOG_DEFINE_THIS_MODULE(poll_loop);
|
2010-07-16 11:02:49 -07:00
|
|
|
|
|
poll-loop: Create Windows event handles for sockets automatically.
We currently have a poll_fd_wait_event(fd, wevent, events) function that
is used at places common to Windows and Linux where we have to wait on
sockets. On Linux, 'wevent' is always set as zero. On Windows, for sockets,
when we send both 'fd' and 'wevent', we associate them with each other for
'events' and then wait on 'wevent'. Also on Windows, when we only send 'wevent'
to this function, we would simply wait for all events for that 'wevent'.
There is a disadvantage with this approach.
* Windows clients need to create a 'wevent' and then pass it along. This
means that at a lot of places where we create sockets, we also are forced
to create a 'wevent'.
With this commit, we pass the responsibility of creating a 'wevent' to
poll_fd_wait() in case of sockets. That way, a client using poll_fd_wait()
is only concerned about sockets and not about 'wevents'. There is a potential
disadvantage with this change in that we create events more often and that
may have a performance penalty. If that turns out to be the case, we will
eventually need to create a pool of wevents that can be re-used.
In Windows, there are cases where we want to wait on a event (not
associated with any sockets) and then control it using functions
like SetEvent() etc. For that purpose, introduce a new function
poll_wevent_wait(). For this function, the client needs to create a event
and then pass it along as an argument.
Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
Acked-By: Ben Pfaff <blp@nicira.com>
2014-06-27 13:30:49 -07:00
|
|
|
|
COVERAGE_DEFINE(poll_create_node);
|
coverage: Make the coverage counters catalog program-specific.
Until now, the collection of coverage counters supported by a given OVS
program was not specific to that program. That means that, for example,
even though ovs-dpctl does not have anything to do with mac_learning, it
still has a coverage counter for it. This is confusing, at best.
This commit fixes the problem on some systems, in particular on ones that
use GCC and the GNU linker. It uses the feature of the GNU linker
described in its manual as:
If an orphaned section's name is representable as a C identifier then
the linker will automatically see PROVIDE two symbols: __start_SECNAME
and __end_SECNAME, where SECNAME is the name of the section. These
indicate the start address and end address of the orphaned section
respectively.
Systems that don't support these features retain the earlier behavior.
This commit also fixes the annoyance that files that include coverage
counters must be listed on COVERAGE_FILES in lib/automake.mk.
This commit also fixes the annoyance that modifying any source file that
includes a coverage counter caused all programs that link against
libopenvswitch.a to relink, even programs that the source file was not
linked into. For example, modifying ofproto/ofproto.c (which includes
coverage counters) caused tests/test-aes128 to relink, even though
test-aes128 does not link again ofproto.o.
2010-11-01 14:14:27 -07:00
|
|
|
|
COVERAGE_DEFINE(poll_zero_timeout);
|
|
|
|
|
|
2014-01-09 16:26:12 -08:00
|
|
|
|
struct poll_node {
|
|
|
|
|
struct hmap_node hmap_node;
|
|
|
|
|
struct pollfd pollfd; /* Events to pass to time_poll(). */
|
|
|
|
|
HANDLE wevent; /* Events for WaitForMultipleObjects(). */
|
|
|
|
|
const char *where; /* Where poll_node was created. */
|
|
|
|
|
};
|
|
|
|
|
|
2013-07-10 10:54:41 -07:00
|
|
|
|
struct poll_loop {
|
|
|
|
|
/* All active poll waiters. */
|
2014-01-09 16:26:12 -08:00
|
|
|
|
struct hmap poll_nodes;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2013-07-10 10:54:41 -07:00
|
|
|
|
/* Time at which to wake up the next call to poll_block(), LLONG_MIN to
|
|
|
|
|
* wake up immediately, or LLONG_MAX to wait forever. */
|
|
|
|
|
long long int timeout_when; /* In msecs as returned by time_msec(). */
|
|
|
|
|
const char *timeout_where; /* Where 'timeout_when' was set. */
|
|
|
|
|
};
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2013-07-10 10:54:41 -07:00
|
|
|
|
static struct poll_loop *poll_loop(void);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2015-09-30 14:18:47 -07:00
|
|
|
|
/* Look up the node with same fd or wevent. */
|
2014-01-09 16:26:12 -08:00
|
|
|
|
static struct poll_node *
|
poll-loop: Create Windows event handles for sockets automatically.
We currently have a poll_fd_wait_event(fd, wevent, events) function that
is used at places common to Windows and Linux where we have to wait on
sockets. On Linux, 'wevent' is always set as zero. On Windows, for sockets,
when we send both 'fd' and 'wevent', we associate them with each other for
'events' and then wait on 'wevent'. Also on Windows, when we only send 'wevent'
to this function, we would simply wait for all events for that 'wevent'.
There is a disadvantage with this approach.
* Windows clients need to create a 'wevent' and then pass it along. This
means that at a lot of places where we create sockets, we also are forced
to create a 'wevent'.
With this commit, we pass the responsibility of creating a 'wevent' to
poll_fd_wait() in case of sockets. That way, a client using poll_fd_wait()
is only concerned about sockets and not about 'wevents'. There is a potential
disadvantage with this change in that we create events more often and that
may have a performance penalty. If that turns out to be the case, we will
eventually need to create a pool of wevents that can be re-used.
In Windows, there are cases where we want to wait on a event (not
associated with any sockets) and then control it using functions
like SetEvent() etc. For that purpose, introduce a new function
poll_wevent_wait(). For this function, the client needs to create a event
and then pass it along as an argument.
Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
Acked-By: Ben Pfaff <blp@nicira.com>
2014-06-27 13:30:49 -07:00
|
|
|
|
find_poll_node(struct poll_loop *loop, int fd, HANDLE wevent)
|
2014-01-09 16:26:12 -08:00
|
|
|
|
{
|
|
|
|
|
struct poll_node *node;
|
|
|
|
|
|
2015-09-30 14:18:47 -07:00
|
|
|
|
/* Both 'fd' and 'wevent' cannot be set. */
|
|
|
|
|
ovs_assert(!fd != !wevent);
|
|
|
|
|
|
poll-loop: Create Windows event handles for sockets automatically.
We currently have a poll_fd_wait_event(fd, wevent, events) function that
is used at places common to Windows and Linux where we have to wait on
sockets. On Linux, 'wevent' is always set as zero. On Windows, for sockets,
when we send both 'fd' and 'wevent', we associate them with each other for
'events' and then wait on 'wevent'. Also on Windows, when we only send 'wevent'
to this function, we would simply wait for all events for that 'wevent'.
There is a disadvantage with this approach.
* Windows clients need to create a 'wevent' and then pass it along. This
means that at a lot of places where we create sockets, we also are forced
to create a 'wevent'.
With this commit, we pass the responsibility of creating a 'wevent' to
poll_fd_wait() in case of sockets. That way, a client using poll_fd_wait()
is only concerned about sockets and not about 'wevents'. There is a potential
disadvantage with this change in that we create events more often and that
may have a performance penalty. If that turns out to be the case, we will
eventually need to create a pool of wevents that can be re-used.
In Windows, there are cases where we want to wait on a event (not
associated with any sockets) and then control it using functions
like SetEvent() etc. For that purpose, introduce a new function
poll_wevent_wait(). For this function, the client needs to create a event
and then pass it along as an argument.
Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
Acked-By: Ben Pfaff <blp@nicira.com>
2014-06-27 13:30:49 -07:00
|
|
|
|
HMAP_FOR_EACH_WITH_HASH (node, hmap_node,
|
|
|
|
|
hash_2words(fd, (uint32_t)wevent),
|
2014-01-09 16:26:12 -08:00
|
|
|
|
&loop->poll_nodes) {
|
2015-09-30 14:18:47 -07:00
|
|
|
|
if ((fd && node->pollfd.fd == fd)
|
|
|
|
|
|| (wevent && node->wevent == wevent)) {
|
2014-01-09 16:26:12 -08:00
|
|
|
|
return node;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
return NULL;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* On Unix based systems:
|
2009-07-08 13:19:16 -07:00
|
|
|
|
*
|
2014-01-09 16:26:12 -08:00
|
|
|
|
* Registers 'fd' as waiting for the specified 'events' (which should be
|
|
|
|
|
* POLLIN or POLLOUT or POLLIN | POLLOUT). The following call to
|
|
|
|
|
* poll_block() will wake up when 'fd' becomes ready for one or more of the
|
poll-loop: Create Windows event handles for sockets automatically.
We currently have a poll_fd_wait_event(fd, wevent, events) function that
is used at places common to Windows and Linux where we have to wait on
sockets. On Linux, 'wevent' is always set as zero. On Windows, for sockets,
when we send both 'fd' and 'wevent', we associate them with each other for
'events' and then wait on 'wevent'. Also on Windows, when we only send 'wevent'
to this function, we would simply wait for all events for that 'wevent'.
There is a disadvantage with this approach.
* Windows clients need to create a 'wevent' and then pass it along. This
means that at a lot of places where we create sockets, we also are forced
to create a 'wevent'.
With this commit, we pass the responsibility of creating a 'wevent' to
poll_fd_wait() in case of sockets. That way, a client using poll_fd_wait()
is only concerned about sockets and not about 'wevents'. There is a potential
disadvantage with this change in that we create events more often and that
may have a performance penalty. If that turns out to be the case, we will
eventually need to create a pool of wevents that can be re-used.
In Windows, there are cases where we want to wait on a event (not
associated with any sockets) and then control it using functions
like SetEvent() etc. For that purpose, introduce a new function
poll_wevent_wait(). For this function, the client needs to create a event
and then pass it along as an argument.
Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
Acked-By: Ben Pfaff <blp@nicira.com>
2014-06-27 13:30:49 -07:00
|
|
|
|
* requested events. The 'fd's are given to poll() function later.
|
2014-01-09 16:26:12 -08:00
|
|
|
|
*
|
|
|
|
|
* On Windows system:
|
|
|
|
|
*
|
poll-loop: Create Windows event handles for sockets automatically.
We currently have a poll_fd_wait_event(fd, wevent, events) function that
is used at places common to Windows and Linux where we have to wait on
sockets. On Linux, 'wevent' is always set as zero. On Windows, for sockets,
when we send both 'fd' and 'wevent', we associate them with each other for
'events' and then wait on 'wevent'. Also on Windows, when we only send 'wevent'
to this function, we would simply wait for all events for that 'wevent'.
There is a disadvantage with this approach.
* Windows clients need to create a 'wevent' and then pass it along. This
means that at a lot of places where we create sockets, we also are forced
to create a 'wevent'.
With this commit, we pass the responsibility of creating a 'wevent' to
poll_fd_wait() in case of sockets. That way, a client using poll_fd_wait()
is only concerned about sockets and not about 'wevents'. There is a potential
disadvantage with this change in that we create events more often and that
may have a performance penalty. If that turns out to be the case, we will
eventually need to create a pool of wevents that can be re-used.
In Windows, there are cases where we want to wait on a event (not
associated with any sockets) and then control it using functions
like SetEvent() etc. For that purpose, introduce a new function
poll_wevent_wait(). For this function, the client needs to create a event
and then pass it along as an argument.
Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
Acked-By: Ben Pfaff <blp@nicira.com>
2014-06-27 13:30:49 -07:00
|
|
|
|
* If 'fd' is specified, create a new 'wevent'. Association of 'fd' and
|
|
|
|
|
* 'wevent' for 'events' happens in poll_block(). If 'wevent' is specified,
|
|
|
|
|
* it is assumed that it is unrelated to any sockets and poll_block()
|
|
|
|
|
* will wake up on any event on that 'wevent'. It is an error to pass
|
|
|
|
|
* both 'wevent' and 'fd'.
|
|
|
|
|
*
|
|
|
|
|
* The event registration is one-shot: only the following call to
|
|
|
|
|
* poll_block() is affected. The event will need to be re-registered after
|
|
|
|
|
* poll_block() is called if it is to persist.
|
poll-loop: Make wakeup logging more portable and easier to understand.
Until now, when the poll_loop module's log level was turned up to "debug",
it would log a backtrace of the call stack for the event that caused poll()
to wake up in poll_block(). This was pretty useful from time to time to
find out why ovs-vswitchd was using more CPU than expected, because we
could find out what was causing it to wake up.
But there were some issues. One is simply that the backtrace was printed
as a series of hexadecimal numbers, so GDB or another debugger was needed
to translate it into human-readable format. Compiler optimizations meant
that even the human-readable backtrace wasn't, in my experience, as helpful
as it could have been. And, of course, one needed to have the binary to
interpret the backtrace. When the backtrace couldn't be interpreted or
wasn't meaningful, there was essentially nothing to fall back on.
This commit changes the way that "debug" logging for poll_block() wakeups
works. Instead of logging a backtrace, it logs the source code file name
and line number of the call to a poll_loop function, using __FILE__ and
__LINE__. This is by itself much more meaningful than a sequence of
hexadecimal numbers, since no additional interpretation is necessary. It
can be useful even if the Open vSwitch version is only approximately known.
In addition to the file and line, this commit adds, for wakeups caused by
file descriptors, information about the file descriptor itself: what kind
of file it is (regular file, directory, socket, etc.), the name of the file
(on Linux only), and the local and remote endpoints for socket file
descriptors.
Here are a few examples of the new output format:
932-ms timeout at ../ofproto/in-band.c:507
[POLLIN] on fd 20 (192.168.0.20:35388<->192.168.0.3:6633) at ../lib/stream-fd.c:149
[POLLIN] on fd 7 (FIFO pipe:[48049]) at ../lib/fatal-signal.c:168
2011-05-13 13:06:49 -07:00
|
|
|
|
*
|
2013-07-29 15:24:45 -07:00
|
|
|
|
* ('where' is used in debug logging. Commonly one would use poll_fd_wait() to
|
|
|
|
|
* automatically provide the caller's source file and line number for
|
|
|
|
|
* 'where'.) */
|
poll-loop: Create Windows event handles for sockets automatically.
We currently have a poll_fd_wait_event(fd, wevent, events) function that
is used at places common to Windows and Linux where we have to wait on
sockets. On Linux, 'wevent' is always set as zero. On Windows, for sockets,
when we send both 'fd' and 'wevent', we associate them with each other for
'events' and then wait on 'wevent'. Also on Windows, when we only send 'wevent'
to this function, we would simply wait for all events for that 'wevent'.
There is a disadvantage with this approach.
* Windows clients need to create a 'wevent' and then pass it along. This
means that at a lot of places where we create sockets, we also are forced
to create a 'wevent'.
With this commit, we pass the responsibility of creating a 'wevent' to
poll_fd_wait() in case of sockets. That way, a client using poll_fd_wait()
is only concerned about sockets and not about 'wevents'. There is a potential
disadvantage with this change in that we create events more often and that
may have a performance penalty. If that turns out to be the case, we will
eventually need to create a pool of wevents that can be re-used.
In Windows, there are cases where we want to wait on a event (not
associated with any sockets) and then control it using functions
like SetEvent() etc. For that purpose, introduce a new function
poll_wevent_wait(). For this function, the client needs to create a event
and then pass it along as an argument.
Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
Acked-By: Ben Pfaff <blp@nicira.com>
2014-06-27 13:30:49 -07:00
|
|
|
|
static void
|
|
|
|
|
poll_create_node(int fd, HANDLE wevent, short int events, const char *where)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2013-07-10 10:54:41 -07:00
|
|
|
|
struct poll_loop *loop = poll_loop();
|
2014-01-09 16:26:12 -08:00
|
|
|
|
struct poll_node *node;
|
2013-07-10 10:54:41 -07:00
|
|
|
|
|
poll-loop: Create Windows event handles for sockets automatically.
We currently have a poll_fd_wait_event(fd, wevent, events) function that
is used at places common to Windows and Linux where we have to wait on
sockets. On Linux, 'wevent' is always set as zero. On Windows, for sockets,
when we send both 'fd' and 'wevent', we associate them with each other for
'events' and then wait on 'wevent'. Also on Windows, when we only send 'wevent'
to this function, we would simply wait for all events for that 'wevent'.
There is a disadvantage with this approach.
* Windows clients need to create a 'wevent' and then pass it along. This
means that at a lot of places where we create sockets, we also are forced
to create a 'wevent'.
With this commit, we pass the responsibility of creating a 'wevent' to
poll_fd_wait() in case of sockets. That way, a client using poll_fd_wait()
is only concerned about sockets and not about 'wevents'. There is a potential
disadvantage with this change in that we create events more often and that
may have a performance penalty. If that turns out to be the case, we will
eventually need to create a pool of wevents that can be re-used.
In Windows, there are cases where we want to wait on a event (not
associated with any sockets) and then control it using functions
like SetEvent() etc. For that purpose, introduce a new function
poll_wevent_wait(). For this function, the client needs to create a event
and then pass it along as an argument.
Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
Acked-By: Ben Pfaff <blp@nicira.com>
2014-06-27 13:30:49 -07:00
|
|
|
|
COVERAGE_INC(poll_create_node);
|
2014-01-09 16:26:12 -08:00
|
|
|
|
|
poll-loop: Create Windows event handles for sockets automatically.
We currently have a poll_fd_wait_event(fd, wevent, events) function that
is used at places common to Windows and Linux where we have to wait on
sockets. On Linux, 'wevent' is always set as zero. On Windows, for sockets,
when we send both 'fd' and 'wevent', we associate them with each other for
'events' and then wait on 'wevent'. Also on Windows, when we only send 'wevent'
to this function, we would simply wait for all events for that 'wevent'.
There is a disadvantage with this approach.
* Windows clients need to create a 'wevent' and then pass it along. This
means that at a lot of places where we create sockets, we also are forced
to create a 'wevent'.
With this commit, we pass the responsibility of creating a 'wevent' to
poll_fd_wait() in case of sockets. That way, a client using poll_fd_wait()
is only concerned about sockets and not about 'wevents'. There is a potential
disadvantage with this change in that we create events more often and that
may have a performance penalty. If that turns out to be the case, we will
eventually need to create a pool of wevents that can be re-used.
In Windows, there are cases where we want to wait on a event (not
associated with any sockets) and then control it using functions
like SetEvent() etc. For that purpose, introduce a new function
poll_wevent_wait(). For this function, the client needs to create a event
and then pass it along as an argument.
Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
Acked-By: Ben Pfaff <blp@nicira.com>
2014-06-27 13:30:49 -07:00
|
|
|
|
/* Both 'fd' and 'wevent' cannot be set. */
|
2015-09-30 08:40:30 -07:00
|
|
|
|
ovs_assert(!fd != !wevent);
|
2013-07-10 10:54:41 -07:00
|
|
|
|
|
poll-loop: Create Windows event handles for sockets automatically.
We currently have a poll_fd_wait_event(fd, wevent, events) function that
is used at places common to Windows and Linux where we have to wait on
sockets. On Linux, 'wevent' is always set as zero. On Windows, for sockets,
when we send both 'fd' and 'wevent', we associate them with each other for
'events' and then wait on 'wevent'. Also on Windows, when we only send 'wevent'
to this function, we would simply wait for all events for that 'wevent'.
There is a disadvantage with this approach.
* Windows clients need to create a 'wevent' and then pass it along. This
means that at a lot of places where we create sockets, we also are forced
to create a 'wevent'.
With this commit, we pass the responsibility of creating a 'wevent' to
poll_fd_wait() in case of sockets. That way, a client using poll_fd_wait()
is only concerned about sockets and not about 'wevents'. There is a potential
disadvantage with this change in that we create events more often and that
may have a performance penalty. If that turns out to be the case, we will
eventually need to create a pool of wevents that can be re-used.
In Windows, there are cases where we want to wait on a event (not
associated with any sockets) and then control it using functions
like SetEvent() etc. For that purpose, introduce a new function
poll_wevent_wait(). For this function, the client needs to create a event
and then pass it along as an argument.
Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
Acked-By: Ben Pfaff <blp@nicira.com>
2014-06-27 13:30:49 -07:00
|
|
|
|
/* Check for duplicate. If found, "or" the events. */
|
2014-01-09 16:26:12 -08:00
|
|
|
|
node = find_poll_node(loop, fd, wevent);
|
|
|
|
|
if (node) {
|
|
|
|
|
node->pollfd.events |= events;
|
|
|
|
|
} else {
|
|
|
|
|
node = xzalloc(sizeof *node);
|
|
|
|
|
hmap_insert(&loop->poll_nodes, &node->hmap_node,
|
poll-loop: Create Windows event handles for sockets automatically.
We currently have a poll_fd_wait_event(fd, wevent, events) function that
is used at places common to Windows and Linux where we have to wait on
sockets. On Linux, 'wevent' is always set as zero. On Windows, for sockets,
when we send both 'fd' and 'wevent', we associate them with each other for
'events' and then wait on 'wevent'. Also on Windows, when we only send 'wevent'
to this function, we would simply wait for all events for that 'wevent'.
There is a disadvantage with this approach.
* Windows clients need to create a 'wevent' and then pass it along. This
means that at a lot of places where we create sockets, we also are forced
to create a 'wevent'.
With this commit, we pass the responsibility of creating a 'wevent' to
poll_fd_wait() in case of sockets. That way, a client using poll_fd_wait()
is only concerned about sockets and not about 'wevents'. There is a potential
disadvantage with this change in that we create events more often and that
may have a performance penalty. If that turns out to be the case, we will
eventually need to create a pool of wevents that can be re-used.
In Windows, there are cases where we want to wait on a event (not
associated with any sockets) and then control it using functions
like SetEvent() etc. For that purpose, introduce a new function
poll_wevent_wait(). For this function, the client needs to create a event
and then pass it along as an argument.
Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
Acked-By: Ben Pfaff <blp@nicira.com>
2014-06-27 13:30:49 -07:00
|
|
|
|
hash_2words(fd, (uint32_t)wevent));
|
2014-01-09 16:26:12 -08:00
|
|
|
|
node->pollfd.fd = fd;
|
|
|
|
|
node->pollfd.events = events;
|
poll-loop: Create Windows event handles for sockets automatically.
We currently have a poll_fd_wait_event(fd, wevent, events) function that
is used at places common to Windows and Linux where we have to wait on
sockets. On Linux, 'wevent' is always set as zero. On Windows, for sockets,
when we send both 'fd' and 'wevent', we associate them with each other for
'events' and then wait on 'wevent'. Also on Windows, when we only send 'wevent'
to this function, we would simply wait for all events for that 'wevent'.
There is a disadvantage with this approach.
* Windows clients need to create a 'wevent' and then pass it along. This
means that at a lot of places where we create sockets, we also are forced
to create a 'wevent'.
With this commit, we pass the responsibility of creating a 'wevent' to
poll_fd_wait() in case of sockets. That way, a client using poll_fd_wait()
is only concerned about sockets and not about 'wevents'. There is a potential
disadvantage with this change in that we create events more often and that
may have a performance penalty. If that turns out to be the case, we will
eventually need to create a pool of wevents that can be re-used.
In Windows, there are cases where we want to wait on a event (not
associated with any sockets) and then control it using functions
like SetEvent() etc. For that purpose, introduce a new function
poll_wevent_wait(). For this function, the client needs to create a event
and then pass it along as an argument.
Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
Acked-By: Ben Pfaff <blp@nicira.com>
2014-06-27 13:30:49 -07:00
|
|
|
|
#ifdef _WIN32
|
|
|
|
|
if (!wevent) {
|
|
|
|
|
wevent = CreateEvent(NULL, FALSE, FALSE, NULL);
|
|
|
|
|
}
|
|
|
|
|
#endif
|
2014-01-09 16:26:12 -08:00
|
|
|
|
node->wevent = wevent;
|
|
|
|
|
node->where = where;
|
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
poll-loop: Create Windows event handles for sockets automatically.
We currently have a poll_fd_wait_event(fd, wevent, events) function that
is used at places common to Windows and Linux where we have to wait on
sockets. On Linux, 'wevent' is always set as zero. On Windows, for sockets,
when we send both 'fd' and 'wevent', we associate them with each other for
'events' and then wait on 'wevent'. Also on Windows, when we only send 'wevent'
to this function, we would simply wait for all events for that 'wevent'.
There is a disadvantage with this approach.
* Windows clients need to create a 'wevent' and then pass it along. This
means that at a lot of places where we create sockets, we also are forced
to create a 'wevent'.
With this commit, we pass the responsibility of creating a 'wevent' to
poll_fd_wait() in case of sockets. That way, a client using poll_fd_wait()
is only concerned about sockets and not about 'wevents'. There is a potential
disadvantage with this change in that we create events more often and that
may have a performance penalty. If that turns out to be the case, we will
eventually need to create a pool of wevents that can be re-used.
In Windows, there are cases where we want to wait on a event (not
associated with any sockets) and then control it using functions
like SetEvent() etc. For that purpose, introduce a new function
poll_wevent_wait(). For this function, the client needs to create a event
and then pass it along as an argument.
Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
Acked-By: Ben Pfaff <blp@nicira.com>
2014-06-27 13:30:49 -07:00
|
|
|
|
/* Registers 'fd' as waiting for the specified 'events' (which should be POLLIN
|
|
|
|
|
* or POLLOUT or POLLIN | POLLOUT). The following call to poll_block() will
|
|
|
|
|
* wake up when 'fd' becomes ready for one or more of the requested events.
|
|
|
|
|
*
|
|
|
|
|
* On Windows, 'fd' must be a socket.
|
|
|
|
|
*
|
|
|
|
|
* The event registration is one-shot: only the following call to poll_block()
|
|
|
|
|
* is affected. The event will need to be re-registered after poll_block() is
|
|
|
|
|
* called if it is to persist.
|
|
|
|
|
*
|
|
|
|
|
* ('where' is used in debug logging. Commonly one would use poll_fd_wait() to
|
|
|
|
|
* automatically provide the caller's source file and line number for
|
|
|
|
|
* 'where'.) */
|
|
|
|
|
void
|
|
|
|
|
poll_fd_wait_at(int fd, short int events, const char *where)
|
|
|
|
|
{
|
|
|
|
|
poll_create_node(fd, 0, events, where);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#ifdef _WIN32
|
|
|
|
|
/* Registers for the next call to poll_block() to wake up when 'wevent' is
|
|
|
|
|
* signaled.
|
|
|
|
|
*
|
|
|
|
|
* The event registration is one-shot: only the following call to poll_block()
|
|
|
|
|
* is affected. The event will need to be re-registered after poll_block() is
|
|
|
|
|
* called if it is to persist.
|
|
|
|
|
*
|
|
|
|
|
* ('where' is used in debug logging. Commonly one would use
|
|
|
|
|
* poll_wevent_wait() to automatically provide the caller's source file and
|
|
|
|
|
* line number for 'where'.) */
|
|
|
|
|
void
|
|
|
|
|
poll_wevent_wait_at(HANDLE wevent, const char *where)
|
|
|
|
|
{
|
2015-09-30 08:40:30 -07:00
|
|
|
|
poll_create_node(0, wevent, 0, where);
|
poll-loop: Create Windows event handles for sockets automatically.
We currently have a poll_fd_wait_event(fd, wevent, events) function that
is used at places common to Windows and Linux where we have to wait on
sockets. On Linux, 'wevent' is always set as zero. On Windows, for sockets,
when we send both 'fd' and 'wevent', we associate them with each other for
'events' and then wait on 'wevent'. Also on Windows, when we only send 'wevent'
to this function, we would simply wait for all events for that 'wevent'.
There is a disadvantage with this approach.
* Windows clients need to create a 'wevent' and then pass it along. This
means that at a lot of places where we create sockets, we also are forced
to create a 'wevent'.
With this commit, we pass the responsibility of creating a 'wevent' to
poll_fd_wait() in case of sockets. That way, a client using poll_fd_wait()
is only concerned about sockets and not about 'wevents'. There is a potential
disadvantage with this change in that we create events more often and that
may have a performance penalty. If that turns out to be the case, we will
eventually need to create a pool of wevents that can be re-used.
In Windows, there are cases where we want to wait on a event (not
associated with any sockets) and then control it using functions
like SetEvent() etc. For that purpose, introduce a new function
poll_wevent_wait(). For this function, the client needs to create a event
and then pass it along as an argument.
Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
Acked-By: Ben Pfaff <blp@nicira.com>
2014-06-27 13:30:49 -07:00
|
|
|
|
}
|
|
|
|
|
#endif /* _WIN32 */
|
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
/* Causes the following call to poll_block() to block for no more than 'msec'
|
|
|
|
|
* milliseconds. If 'msec' is nonpositive, the following call to poll_block()
|
|
|
|
|
* will not block at all.
|
|
|
|
|
*
|
|
|
|
|
* The timer registration is one-shot: only the following call to poll_block()
|
|
|
|
|
* is affected. The timer will need to be re-registered after poll_block() is
|
poll-loop: Make wakeup logging more portable and easier to understand.
Until now, when the poll_loop module's log level was turned up to "debug",
it would log a backtrace of the call stack for the event that caused poll()
to wake up in poll_block(). This was pretty useful from time to time to
find out why ovs-vswitchd was using more CPU than expected, because we
could find out what was causing it to wake up.
But there were some issues. One is simply that the backtrace was printed
as a series of hexadecimal numbers, so GDB or another debugger was needed
to translate it into human-readable format. Compiler optimizations meant
that even the human-readable backtrace wasn't, in my experience, as helpful
as it could have been. And, of course, one needed to have the binary to
interpret the backtrace. When the backtrace couldn't be interpreted or
wasn't meaningful, there was essentially nothing to fall back on.
This commit changes the way that "debug" logging for poll_block() wakeups
works. Instead of logging a backtrace, it logs the source code file name
and line number of the call to a poll_loop function, using __FILE__ and
__LINE__. This is by itself much more meaningful than a sequence of
hexadecimal numbers, since no additional interpretation is necessary. It
can be useful even if the Open vSwitch version is only approximately known.
In addition to the file and line, this commit adds, for wakeups caused by
file descriptors, information about the file descriptor itself: what kind
of file it is (regular file, directory, socket, etc.), the name of the file
(on Linux only), and the local and remote endpoints for socket file
descriptors.
Here are a few examples of the new output format:
932-ms timeout at ../ofproto/in-band.c:507
[POLLIN] on fd 20 (192.168.0.20:35388<->192.168.0.3:6633) at ../lib/stream-fd.c:149
[POLLIN] on fd 7 (FIFO pipe:[48049]) at ../lib/fatal-signal.c:168
2011-05-13 13:06:49 -07:00
|
|
|
|
* called if it is to persist.
|
|
|
|
|
*
|
2013-07-29 15:24:45 -07:00
|
|
|
|
* ('where' is used in debug logging. Commonly one would use poll_timer_wait()
|
|
|
|
|
* to automatically provide the caller's source file and line number for
|
|
|
|
|
* 'where'.) */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
void
|
2013-07-29 15:24:45 -07:00
|
|
|
|
poll_timer_wait_at(long long int msec, const char *where)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2011-12-19 14:28:42 -08:00
|
|
|
|
long long int now = time_msec();
|
|
|
|
|
long long int when;
|
|
|
|
|
|
|
|
|
|
if (msec <= 0) {
|
|
|
|
|
/* Wake up immediately. */
|
|
|
|
|
when = LLONG_MIN;
|
|
|
|
|
} else if ((unsigned long long int) now + msec <= LLONG_MAX) {
|
|
|
|
|
/* Normal case. */
|
|
|
|
|
when = now + msec;
|
|
|
|
|
} else {
|
|
|
|
|
/* now + msec would overflow. */
|
|
|
|
|
when = LLONG_MAX;
|
|
|
|
|
}
|
|
|
|
|
|
2013-07-29 15:24:45 -07:00
|
|
|
|
poll_timer_wait_until_at(when, where);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2010-05-12 12:53:07 -07:00
|
|
|
|
/* Causes the following call to poll_block() to wake up when the current time,
|
2011-12-19 14:28:42 -08:00
|
|
|
|
* as returned by time_msec(), reaches 'when' or later. If 'when' is earlier
|
2010-05-12 12:53:07 -07:00
|
|
|
|
* than the current time, the following call to poll_block() will not block at
|
|
|
|
|
* all.
|
|
|
|
|
*
|
|
|
|
|
* The timer registration is one-shot: only the following call to poll_block()
|
|
|
|
|
* is affected. The timer will need to be re-registered after poll_block() is
|
poll-loop: Make wakeup logging more portable and easier to understand.
Until now, when the poll_loop module's log level was turned up to "debug",
it would log a backtrace of the call stack for the event that caused poll()
to wake up in poll_block(). This was pretty useful from time to time to
find out why ovs-vswitchd was using more CPU than expected, because we
could find out what was causing it to wake up.
But there were some issues. One is simply that the backtrace was printed
as a series of hexadecimal numbers, so GDB or another debugger was needed
to translate it into human-readable format. Compiler optimizations meant
that even the human-readable backtrace wasn't, in my experience, as helpful
as it could have been. And, of course, one needed to have the binary to
interpret the backtrace. When the backtrace couldn't be interpreted or
wasn't meaningful, there was essentially nothing to fall back on.
This commit changes the way that "debug" logging for poll_block() wakeups
works. Instead of logging a backtrace, it logs the source code file name
and line number of the call to a poll_loop function, using __FILE__ and
__LINE__. This is by itself much more meaningful than a sequence of
hexadecimal numbers, since no additional interpretation is necessary. It
can be useful even if the Open vSwitch version is only approximately known.
In addition to the file and line, this commit adds, for wakeups caused by
file descriptors, information about the file descriptor itself: what kind
of file it is (regular file, directory, socket, etc.), the name of the file
(on Linux only), and the local and remote endpoints for socket file
descriptors.
Here are a few examples of the new output format:
932-ms timeout at ../ofproto/in-band.c:507
[POLLIN] on fd 20 (192.168.0.20:35388<->192.168.0.3:6633) at ../lib/stream-fd.c:149
[POLLIN] on fd 7 (FIFO pipe:[48049]) at ../lib/fatal-signal.c:168
2011-05-13 13:06:49 -07:00
|
|
|
|
* called if it is to persist.
|
|
|
|
|
*
|
2013-07-29 15:24:45 -07:00
|
|
|
|
* ('where' is used in debug logging. Commonly one would use
|
|
|
|
|
* poll_timer_wait_until() to automatically provide the caller's source file
|
|
|
|
|
* and line number for 'where'.) */
|
2010-05-12 12:53:07 -07:00
|
|
|
|
void
|
2013-07-29 15:24:45 -07:00
|
|
|
|
poll_timer_wait_until_at(long long int when, const char *where)
|
2010-05-12 12:53:07 -07:00
|
|
|
|
{
|
2013-07-10 10:54:41 -07:00
|
|
|
|
struct poll_loop *loop = poll_loop();
|
|
|
|
|
if (when < loop->timeout_when) {
|
|
|
|
|
loop->timeout_when = when;
|
|
|
|
|
loop->timeout_where = where;
|
2011-12-19 14:28:42 -08:00
|
|
|
|
}
|
2010-05-12 12:53:07 -07:00
|
|
|
|
}
|
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
/* Causes the following call to poll_block() to wake up immediately, without
|
poll-loop: Make wakeup logging more portable and easier to understand.
Until now, when the poll_loop module's log level was turned up to "debug",
it would log a backtrace of the call stack for the event that caused poll()
to wake up in poll_block(). This was pretty useful from time to time to
find out why ovs-vswitchd was using more CPU than expected, because we
could find out what was causing it to wake up.
But there were some issues. One is simply that the backtrace was printed
as a series of hexadecimal numbers, so GDB or another debugger was needed
to translate it into human-readable format. Compiler optimizations meant
that even the human-readable backtrace wasn't, in my experience, as helpful
as it could have been. And, of course, one needed to have the binary to
interpret the backtrace. When the backtrace couldn't be interpreted or
wasn't meaningful, there was essentially nothing to fall back on.
This commit changes the way that "debug" logging for poll_block() wakeups
works. Instead of logging a backtrace, it logs the source code file name
and line number of the call to a poll_loop function, using __FILE__ and
__LINE__. This is by itself much more meaningful than a sequence of
hexadecimal numbers, since no additional interpretation is necessary. It
can be useful even if the Open vSwitch version is only approximately known.
In addition to the file and line, this commit adds, for wakeups caused by
file descriptors, information about the file descriptor itself: what kind
of file it is (regular file, directory, socket, etc.), the name of the file
(on Linux only), and the local and remote endpoints for socket file
descriptors.
Here are a few examples of the new output format:
932-ms timeout at ../ofproto/in-band.c:507
[POLLIN] on fd 20 (192.168.0.20:35388<->192.168.0.3:6633) at ../lib/stream-fd.c:149
[POLLIN] on fd 7 (FIFO pipe:[48049]) at ../lib/fatal-signal.c:168
2011-05-13 13:06:49 -07:00
|
|
|
|
* blocking.
|
|
|
|
|
*
|
2013-07-29 15:24:45 -07:00
|
|
|
|
* ('where' is used in debug logging. Commonly one would use
|
|
|
|
|
* poll_immediate_wake() to automatically provide the caller's source file and
|
|
|
|
|
* line number for 'where'.) */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
void
|
2013-07-29 15:24:45 -07:00
|
|
|
|
poll_immediate_wake_at(const char *where)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2013-07-29 15:24:45 -07:00
|
|
|
|
poll_timer_wait_at(0, where);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-05-24 12:23:42 -07:00
|
|
|
|
/* Logs, if appropriate, that the poll loop was awakened by an event
|
|
|
|
|
* registered at 'where' (typically a source file and line number). The other
|
|
|
|
|
* arguments have two possible interpretations:
|
|
|
|
|
*
|
|
|
|
|
* - If 'pollfd' is nonnull then it should be the "struct pollfd" that caused
|
2011-05-27 09:13:50 -07:00
|
|
|
|
* the wakeup. 'timeout' is ignored.
|
2011-05-24 12:23:42 -07:00
|
|
|
|
*
|
2011-05-27 09:13:50 -07:00
|
|
|
|
* - If 'pollfd' is NULL then 'timeout' is the number of milliseconds after
|
|
|
|
|
* which the poll loop woke up.
|
2011-05-24 12:23:42 -07:00
|
|
|
|
*/
|
|
|
|
|
static void
|
|
|
|
|
log_wakeup(const char *where, const struct pollfd *pollfd, int timeout)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2012-05-25 13:54:38 -07:00
|
|
|
|
static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(10, 10);
|
2011-05-24 12:23:42 -07:00
|
|
|
|
enum vlog_level level;
|
|
|
|
|
int cpu_usage;
|
|
|
|
|
struct ds s;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-05-24 12:23:42 -07:00
|
|
|
|
cpu_usage = get_cpu_usage();
|
|
|
|
|
if (VLOG_IS_DBG_ENABLED()) {
|
|
|
|
|
level = VLL_DBG;
|
2015-12-22 17:26:47 +03:00
|
|
|
|
} else if (cpu_usage > 50
|
|
|
|
|
&& !thread_is_pmd()
|
|
|
|
|
&& !VLOG_DROP_INFO(&rl)) {
|
2012-08-20 10:52:26 -07:00
|
|
|
|
level = VLL_INFO;
|
2011-05-24 12:23:42 -07:00
|
|
|
|
} else {
|
|
|
|
|
return;
|
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-05-24 12:23:42 -07:00
|
|
|
|
ds_init(&s);
|
|
|
|
|
ds_put_cstr(&s, "wakeup due to ");
|
|
|
|
|
if (pollfd) {
|
|
|
|
|
char *description = describe_fd(pollfd->fd);
|
|
|
|
|
if (pollfd->revents & POLLIN) {
|
|
|
|
|
ds_put_cstr(&s, "[POLLIN]");
|
|
|
|
|
}
|
|
|
|
|
if (pollfd->revents & POLLOUT) {
|
|
|
|
|
ds_put_cstr(&s, "[POLLOUT]");
|
|
|
|
|
}
|
|
|
|
|
if (pollfd->revents & POLLERR) {
|
|
|
|
|
ds_put_cstr(&s, "[POLLERR]");
|
|
|
|
|
}
|
|
|
|
|
if (pollfd->revents & POLLHUP) {
|
|
|
|
|
ds_put_cstr(&s, "[POLLHUP]");
|
|
|
|
|
}
|
|
|
|
|
if (pollfd->revents & POLLNVAL) {
|
|
|
|
|
ds_put_cstr(&s, "[POLLNVAL]");
|
|
|
|
|
}
|
|
|
|
|
ds_put_format(&s, " on fd %d (%s)", pollfd->fd, description);
|
|
|
|
|
free(description);
|
|
|
|
|
} else {
|
|
|
|
|
ds_put_format(&s, "%d-ms timeout", timeout);
|
|
|
|
|
}
|
poll-loop: Make wakeup logging more portable and easier to understand.
Until now, when the poll_loop module's log level was turned up to "debug",
it would log a backtrace of the call stack for the event that caused poll()
to wake up in poll_block(). This was pretty useful from time to time to
find out why ovs-vswitchd was using more CPU than expected, because we
could find out what was causing it to wake up.
But there were some issues. One is simply that the backtrace was printed
as a series of hexadecimal numbers, so GDB or another debugger was needed
to translate it into human-readable format. Compiler optimizations meant
that even the human-readable backtrace wasn't, in my experience, as helpful
as it could have been. And, of course, one needed to have the binary to
interpret the backtrace. When the backtrace couldn't be interpreted or
wasn't meaningful, there was essentially nothing to fall back on.
This commit changes the way that "debug" logging for poll_block() wakeups
works. Instead of logging a backtrace, it logs the source code file name
and line number of the call to a poll_loop function, using __FILE__ and
__LINE__. This is by itself much more meaningful than a sequence of
hexadecimal numbers, since no additional interpretation is necessary. It
can be useful even if the Open vSwitch version is only approximately known.
In addition to the file and line, this commit adds, for wakeups caused by
file descriptors, information about the file descriptor itself: what kind
of file it is (regular file, directory, socket, etc.), the name of the file
(on Linux only), and the local and remote endpoints for socket file
descriptors.
Here are a few examples of the new output format:
932-ms timeout at ../ofproto/in-band.c:507
[POLLIN] on fd 20 (192.168.0.20:35388<->192.168.0.3:6633) at ../lib/stream-fd.c:149
[POLLIN] on fd 7 (FIFO pipe:[48049]) at ../lib/fatal-signal.c:168
2011-05-13 13:06:49 -07:00
|
|
|
|
if (where) {
|
2011-05-24 12:23:42 -07:00
|
|
|
|
ds_put_format(&s, " at %s", where);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2011-05-24 12:23:42 -07:00
|
|
|
|
if (cpu_usage >= 0) {
|
|
|
|
|
ds_put_format(&s, " (%d%% CPU usage)", cpu_usage);
|
|
|
|
|
}
|
|
|
|
|
VLOG(level, "%s", ds_cstr(&s));
|
|
|
|
|
ds_destroy(&s);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2014-01-09 16:26:12 -08:00
|
|
|
|
static void
|
|
|
|
|
free_poll_nodes(struct poll_loop *loop)
|
|
|
|
|
{
|
2022-03-23 12:56:17 +01:00
|
|
|
|
struct poll_node *node;
|
2014-01-09 16:26:12 -08:00
|
|
|
|
|
2022-03-23 12:56:17 +01:00
|
|
|
|
HMAP_FOR_EACH_SAFE (node, hmap_node, &loop->poll_nodes) {
|
2014-01-09 16:26:12 -08:00
|
|
|
|
hmap_remove(&loop->poll_nodes, &node->hmap_node);
|
poll-loop: Create Windows event handles for sockets automatically.
We currently have a poll_fd_wait_event(fd, wevent, events) function that
is used at places common to Windows and Linux where we have to wait on
sockets. On Linux, 'wevent' is always set as zero. On Windows, for sockets,
when we send both 'fd' and 'wevent', we associate them with each other for
'events' and then wait on 'wevent'. Also on Windows, when we only send 'wevent'
to this function, we would simply wait for all events for that 'wevent'.
There is a disadvantage with this approach.
* Windows clients need to create a 'wevent' and then pass it along. This
means that at a lot of places where we create sockets, we also are forced
to create a 'wevent'.
With this commit, we pass the responsibility of creating a 'wevent' to
poll_fd_wait() in case of sockets. That way, a client using poll_fd_wait()
is only concerned about sockets and not about 'wevents'. There is a potential
disadvantage with this change in that we create events more often and that
may have a performance penalty. If that turns out to be the case, we will
eventually need to create a pool of wevents that can be re-used.
In Windows, there are cases where we want to wait on a event (not
associated with any sockets) and then control it using functions
like SetEvent() etc. For that purpose, introduce a new function
poll_wevent_wait(). For this function, the client needs to create a event
and then pass it along as an argument.
Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
Acked-By: Ben Pfaff <blp@nicira.com>
2014-06-27 13:30:49 -07:00
|
|
|
|
#ifdef _WIN32
|
|
|
|
|
if (node->wevent && node->pollfd.fd) {
|
|
|
|
|
WSAEventSelect(node->pollfd.fd, NULL, 0);
|
|
|
|
|
CloseHandle(node->wevent);
|
|
|
|
|
}
|
|
|
|
|
#endif
|
2014-01-09 16:26:12 -08:00
|
|
|
|
free(node);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
/* Blocks until one or more of the events registered with poll_fd_wait()
|
|
|
|
|
* occurs, or until the minimum duration registered with poll_timer_wait()
|
2009-12-18 16:15:01 -08:00
|
|
|
|
* elapses, or not at all if poll_immediate_wake() has been called. */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
void
|
|
|
|
|
poll_block(void)
|
|
|
|
|
{
|
2013-07-10 10:54:41 -07:00
|
|
|
|
struct poll_loop *loop = poll_loop();
|
2014-01-09 16:26:12 -08:00
|
|
|
|
struct poll_node *node;
|
|
|
|
|
struct pollfd *pollfds;
|
|
|
|
|
HANDLE *wevents = NULL;
|
2011-12-19 14:28:42 -08:00
|
|
|
|
int elapsed;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
int retval;
|
2014-01-09 16:26:12 -08:00
|
|
|
|
int i;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2009-12-08 14:11:22 -08:00
|
|
|
|
/* Register fatal signal events before actually doing any real work for
|
|
|
|
|
* poll_block. */
|
|
|
|
|
fatal_signal_wait();
|
|
|
|
|
|
2013-07-10 10:54:41 -07:00
|
|
|
|
if (loop->timeout_when == LLONG_MIN) {
|
2009-07-08 13:19:16 -07:00
|
|
|
|
COVERAGE_INC(poll_zero_timeout);
|
|
|
|
|
}
|
2013-07-10 10:54:41 -07:00
|
|
|
|
|
2014-06-06 09:40:13 -07:00
|
|
|
|
timewarp_run();
|
2014-01-09 16:26:12 -08:00
|
|
|
|
pollfds = xmalloc(hmap_count(&loop->poll_nodes) * sizeof *pollfds);
|
|
|
|
|
|
|
|
|
|
#ifdef _WIN32
|
|
|
|
|
wevents = xmalloc(hmap_count(&loop->poll_nodes) * sizeof *wevents);
|
|
|
|
|
#endif
|
|
|
|
|
|
|
|
|
|
/* Populate with all the fds and events. */
|
|
|
|
|
i = 0;
|
|
|
|
|
HMAP_FOR_EACH (node, hmap_node, &loop->poll_nodes) {
|
|
|
|
|
pollfds[i] = node->pollfd;
|
|
|
|
|
#ifdef _WIN32
|
|
|
|
|
wevents[i] = node->wevent;
|
2014-02-05 10:10:10 -08:00
|
|
|
|
if (node->pollfd.fd && node->wevent) {
|
|
|
|
|
short int wsa_events = 0;
|
|
|
|
|
if (node->pollfd.events & POLLIN) {
|
|
|
|
|
wsa_events |= FD_READ | FD_ACCEPT | FD_CLOSE;
|
|
|
|
|
}
|
|
|
|
|
if (node->pollfd.events & POLLOUT) {
|
|
|
|
|
wsa_events |= FD_WRITE | FD_CONNECT | FD_CLOSE;
|
|
|
|
|
}
|
|
|
|
|
WSAEventSelect(node->pollfd.fd, node->wevent, wsa_events);
|
|
|
|
|
}
|
2014-01-09 16:26:12 -08:00
|
|
|
|
#endif
|
|
|
|
|
i++;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
retval = time_poll(pollfds, hmap_count(&loop->poll_nodes), wevents,
|
2013-07-10 10:54:41 -07:00
|
|
|
|
loop->timeout_when, &elapsed);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
if (retval < 0) {
|
|
|
|
|
static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
|
2013-06-24 10:54:49 -07:00
|
|
|
|
VLOG_ERR_RL(&rl, "poll: %s", ovs_strerror(-retval));
|
2011-05-24 12:23:42 -07:00
|
|
|
|
} else if (!retval) {
|
2013-07-10 10:54:41 -07:00
|
|
|
|
log_wakeup(loop->timeout_where, NULL, elapsed);
|
2013-07-16 10:43:07 -07:00
|
|
|
|
} else if (get_cpu_usage() > 50 || VLOG_IS_DBG_ENABLED()) {
|
2014-01-09 16:26:12 -08:00
|
|
|
|
i = 0;
|
|
|
|
|
HMAP_FOR_EACH (node, hmap_node, &loop->poll_nodes) {
|
|
|
|
|
if (pollfds[i].revents) {
|
|
|
|
|
log_wakeup(node->where, &pollfds[i], 0);
|
2013-07-16 10:43:07 -07:00
|
|
|
|
}
|
2014-01-09 16:26:12 -08:00
|
|
|
|
i++;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2014-01-09 16:26:12 -08:00
|
|
|
|
free_poll_nodes(loop);
|
2013-07-10 10:54:41 -07:00
|
|
|
|
loop->timeout_when = LLONG_MAX;
|
|
|
|
|
loop->timeout_where = NULL;
|
2014-01-09 16:26:12 -08:00
|
|
|
|
free(pollfds);
|
|
|
|
|
free(wevents);
|
2009-12-08 14:11:22 -08:00
|
|
|
|
|
|
|
|
|
/* Handle any pending signals before doing anything else. */
|
|
|
|
|
fatal_signal_run();
|
2013-08-06 09:39:10 -07:00
|
|
|
|
|
|
|
|
|
seq_woke();
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2013-07-16 10:43:07 -07:00
|
|
|
|
static void
|
2013-07-10 10:54:41 -07:00
|
|
|
|
free_poll_loop(void *loop_)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2013-07-10 10:54:41 -07:00
|
|
|
|
struct poll_loop *loop = loop_;
|
|
|
|
|
|
2014-01-09 16:26:12 -08:00
|
|
|
|
free_poll_nodes(loop);
|
|
|
|
|
hmap_destroy(&loop->poll_nodes);
|
2013-07-10 10:54:41 -07:00
|
|
|
|
free(loop);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static struct poll_loop *
|
|
|
|
|
poll_loop(void)
|
|
|
|
|
{
|
|
|
|
|
static struct ovsthread_once once = OVSTHREAD_ONCE_INITIALIZER;
|
|
|
|
|
static pthread_key_t key;
|
|
|
|
|
struct poll_loop *loop;
|
|
|
|
|
|
|
|
|
|
if (ovsthread_once_start(&once)) {
|
|
|
|
|
xpthread_key_create(&key, free_poll_loop);
|
|
|
|
|
ovsthread_once_done(&once);
|
2013-07-16 10:43:07 -07:00
|
|
|
|
}
|
|
|
|
|
|
2013-07-10 10:54:41 -07:00
|
|
|
|
loop = pthread_getspecific(key);
|
|
|
|
|
if (!loop) {
|
|
|
|
|
loop = xzalloc(sizeof *loop);
|
2019-01-10 15:38:01 -08:00
|
|
|
|
loop->timeout_when = LLONG_MAX;
|
2014-01-09 16:26:12 -08:00
|
|
|
|
hmap_init(&loop->poll_nodes);
|
2013-08-06 14:30:01 -07:00
|
|
|
|
xpthread_setspecific(key, loop);
|
2013-07-10 10:54:41 -07:00
|
|
|
|
}
|
|
|
|
|
return loop;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2013-07-10 10:54:41 -07:00
|
|
|
|
|