mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-08-22 09:58:01 +00:00
Code Issues Releases Wiki Activity
ovs/tests/ofp-actions.at

745 lines
22 KiB
Plaintext
Raw Normal View History

Introduce ofpacts, an abstraction of OpenFlow actions. OpenFlow actions have always been somewhat awkward to handle. Moreover, over time we've started creating actions that require more complicated parsing. When we maintain those actions internally in their wire format, we end up parsing them multiple times, whenever we have to look at the set of actions. When we add support for OpenFlow 1.1 or later protocols, the situation will get worse, because these newer protocols support many of the same actions but with different representations. It becomes unrealistic to handle each protocol in its wire format. This commit adopts a new strategy, by converting OpenFlow actions into an internal form from the wire format when they are read, and converting them back to the wire format when flows are dumped. I believe that this will be more maintainable over time. Thanks to Simon Horman and Pravin Shelar for reviews. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-03 22:17:14 -07:00
AT_BANNER([OpenFlow actions])
AT_SETUP([OpenFlow 1.0 action translation])
ofp-actions: Implement writing to metadata field In OpenFlow 1.1, we add support for OFPIT_WRITE_METADATA. This allows us to write to the metadata field. Internally it is represented using ofpact_metadata. We introduce NXAST_WRITE_METADATA to handle writing to the metadata field in OpenFlow 1.0+. This structure reflects OFPIT_WRITE_METADATA. When writing out the structure to OpenFlow 1.1, it uses the OFPIT_WRITE_METADATA instruction only, and not the new NXAST action (which would be redundant). Signed-off-by: Joe Stringer <joe@wand.net.nz> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-10-19 02:37:37 +09:00
AT_KEYWORDS([ofp-actions OF1.0])
Introduce ofpacts, an abstraction of OpenFlow actions. OpenFlow actions have always been somewhat awkward to handle. Moreover, over time we've started creating actions that require more complicated parsing. When we maintain those actions internally in their wire format, we end up parsing them multiple times, whenever we have to look at the set of actions. When we add support for OpenFlow 1.1 or later protocols, the situation will get worse, because these newer protocols support many of the same actions but with different representations. It becomes unrealistic to handle each protocol in its wire format. This commit adopts a new strategy, by converting OpenFlow actions into an internal form from the wire format when they are read, and converting them back to the wire format when flows are dumped. I believe that this will be more maintainable over time. Thanks to Simon Horman and Pravin Shelar for reviews. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-03 22:17:14 -07:00
AT_DATA([test-data], [dnl
# actions=LOCAL
0000 0008 fffe 04d2
# actions=CONTROLLER:1234
0000 0008 fffd 04d2
# actions=mod_vlan_vid:9
0001 0008 0009 0000
# actions=mod_vlan_pcp:6
0002 0008 06 000000
# actions=strip_vlan
0003 0008 00000000
# actions=mod_dl_src:00:11:22:33:44:55
0004 0010 001122334455 000000000000
# actions=mod_dl_dst:10:20:30:40:50:60
0005 0010 102030405060 000000000000
# actions=mod_nw_src:1.2.3.4
0006 0008 01020304
# actions=mod_nw_dst:192.168.0.1
0007 0008 c0a80001
# actions=mod_nw_tos:48
0008 0008 30 000000
# actions=mod_tp_src:80
0009 0008 0050 0000
# actions=mod_tp_dst:443
000a 0008 01bb 0000
ofp-actions: Switch away from odd use of "q" in "enqueue" action format. The formatting of the "enqueue" action uses a "q" to separate the port number from the queue number, as in "enqueue:123q456". This is different from every other action. This commit improves the situation by: * Switching the formatting to use a colon (e.g. "enqueue:123:456"), which is a little less odd-looking but still accepted by older versions of Open vSwitch. * Improving the parser to accept "enqueue(123,456)" also. Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-05-06 10:55:06 -07:00
# actions=enqueue:10:55
Introduce ofpacts, an abstraction of OpenFlow actions. OpenFlow actions have always been somewhat awkward to handle. Moreover, over time we've started creating actions that require more complicated parsing. When we maintain those actions internally in their wire format, we end up parsing them multiple times, whenever we have to look at the set of actions. When we add support for OpenFlow 1.1 or later protocols, the situation will get worse, because these newer protocols support many of the same actions but with different representations. It becomes unrealistic to handle each protocol in its wire format. This commit adopts a new strategy, by converting OpenFlow actions into an internal form from the wire format when they are read, and converting them back to the wire format when flows are dumped. I believe that this will be more maintainable over time. Thanks to Simon Horman and Pravin Shelar for reviews. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-03 22:17:14 -07:00
000b 0010 000a 000000000000 00000037
# actions=resubmit:5
ffff 0010 00002320 0001 0005 00000000
# actions=set_tunnel:0x12345678
ffff 0010 00002320 0002 0000 12345678
# actions=set_queue:2309737729
ffff 0010 00002320 0004 0000 89abcd01
# actions=pop_queue
ffff 0010 00002320 0005 000000000000
# actions=move:NXM_OF_IN_PORT[]->NXM_OF_VLAN_TCI[]
ffff 0018 00002320 0006 0010 0000 0000 00000002 00000802
# actions=load:0xf009->NXM_OF_VLAN_TCI[]
ffff 0018 00002320 0007 000f 00000802 000000000000f009
# actions=note:11.e9.9a.ad.67.f3
ffff 0010 00002320 0008 11e99aad67f3
# actions=set_tunnel64:0xc426384d49c53d60
ffff 0018 00002320 0009 000000000000 c426384d49c53d60
# actions=set_tunnel64:0x885f3298
ffff 0018 00002320 0009 000000000000 00000000885f3298
ovs-ofctl: Generalize action and instruction test commands. Until now, there were four of these commands: parse-ofp10-actions, parse-ofp10-instructions, parse-ofp11-actions, parse-ofp11-instructions. This is painful to add support for new OpenFlow versions and has a ton of cut-and-paste code. This commit generalizes the code to improve on both of those points. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-07 16:03:42 -07:00
# bad OpenFlow10 actions: OFPBIC_UNSUP_INST
ofp-actions: Pretend that OpenFlow 1.0 has instructions. This allows callers to be more uniform, because they don't have to pick out whether they should parse actions or instructions based on the OpenFlow version in use. It also allows the Write-Metadata instruction emulation in OpenFlow 1.0 to be treated just as in OpenFlow 1.1 in the sense that it is allowed in contexts where instructions are allowed in OpenFlow 1.1 and not elsewhere. (The changes in the tests reflect this more accurate treatment.) Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-07 16:09:07 -07:00
& ofp_actions|WARN|write_metadata instruction not allowed here
ofp-actions: Implement writing to metadata field In OpenFlow 1.1, we add support for OFPIT_WRITE_METADATA. This allows us to write to the metadata field. Internally it is represented using ofpact_metadata. We introduce NXAST_WRITE_METADATA to handle writing to the metadata field in OpenFlow 1.0+. This structure reflects OFPIT_WRITE_METADATA. When writing out the structure to OpenFlow 1.1, it uses the OFPIT_WRITE_METADATA instruction only, and not the new NXAST action (which would be redundant). Signed-off-by: Joe Stringer <joe@wand.net.nz> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-10-19 02:37:37 +09:00
ffff 0020 00002320 0016 000000000000 fedcba9876543210 ffffffffffffffff
ovs-ofctl: Generalize action and instruction test commands. Until now, there were four of these commands: parse-ofp10-actions, parse-ofp10-instructions, parse-ofp11-actions, parse-ofp11-instructions. This is painful to add support for new OpenFlow versions and has a ton of cut-and-paste code. This commit generalizes the code to improve on both of those points. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-07 16:03:42 -07:00
# bad OpenFlow10 actions: OFPBIC_UNSUP_INST
ofp-actions: Pretend that OpenFlow 1.0 has instructions. This allows callers to be more uniform, because they don't have to pick out whether they should parse actions or instructions based on the OpenFlow version in use. It also allows the Write-Metadata instruction emulation in OpenFlow 1.0 to be treated just as in OpenFlow 1.1 in the sense that it is allowed in contexts where instructions are allowed in OpenFlow 1.1 and not elsewhere. (The changes in the tests reflect this more accurate treatment.) Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-07 16:09:07 -07:00
& ofp_actions|WARN|write_metadata instruction not allowed here
ofp-actions: Implement writing to metadata field In OpenFlow 1.1, we add support for OFPIT_WRITE_METADATA. This allows us to write to the metadata field. Internally it is represented using ofpact_metadata. We introduce NXAST_WRITE_METADATA to handle writing to the metadata field in OpenFlow 1.0+. This structure reflects OFPIT_WRITE_METADATA. When writing out the structure to OpenFlow 1.1, it uses the OFPIT_WRITE_METADATA instruction only, and not the new NXAST action (which would be redundant). Signed-off-by: Joe Stringer <joe@wand.net.nz> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-10-19 02:37:37 +09:00
ffff 0020 00002320 0016 000000000000 fedcba9876543210 ffff0000ffff0000
Introduce ofpacts, an abstraction of OpenFlow actions. OpenFlow actions have always been somewhat awkward to handle. Moreover, over time we've started creating actions that require more complicated parsing. When we maintain those actions internally in their wire format, we end up parsing them multiple times, whenever we have to look at the set of actions. When we add support for OpenFlow 1.1 or later protocols, the situation will get worse, because these newer protocols support many of the same actions but with different representations. It becomes unrealistic to handle each protocol in its wire format. This commit adopts a new strategy, by converting OpenFlow actions into an internal form from the wire format when they are read, and converting them back to the wire format when flows are dumped. I believe that this will be more maintainable over time. Thanks to Simon Horman and Pravin Shelar for reviews. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-03 22:17:14 -07:00
# actions=multipath(eth_src,50,modulo_n,1,0,NXM_NX_REG0[])
ffff 0020 00002320 000a 0000 0032 0000 0000 0000 0000 0000 0000 001f 00010004
# actions=bundle(eth_src,0,hrw,ofport,slaves:4,8)
ffff 0028 00002320 000c 0001 0000 0000 00000002 0002 0000 00000000 00000000 dnl
0004 0008 00000000
# actions=bundle_load(eth_src,0,hrw,ofport,NXM_NX_REG0[],slaves:4,8)
ffff 0028 00002320 000d 0001 0000 0000 00000002 0002 001f 00010004 00000000 dnl
0004 0008 00000000
# actions=resubmit(10,5)
ffff 0010 00002320 000e 000a 05 000000
# actions=output:NXM_NX_REG1[5..10]
ffff 0018 00002320 000f 0145 00010204 ffff 000000000000
# actions=learn(table=2,idle_timeout=10,hard_timeout=20,fin_idle_timeout=2,fin_hard_timeout=4,priority=80,cookie=0x123456789abcdef0,NXM_OF_VLAN_TCI[0..11],NXM_OF_ETH_DST[]=NXM_OF_ETH_SRC[],output:NXM_OF_IN_PORT[])
ffff 0048 00002320 0010 000a 0014 0050 123456789abcdef0 0000 02 00 0002 0004 dnl
000c 00000802 0000 00000802 0000 dnl
0030 00000406 0000 00000206 0000 dnl
1010 00000002 0000 dnl
00000000
# actions=exit
ffff 0010 00002320 0011 000000000000
# actions=dec_ttl
ffff 0010 00002320 0012 000000000000
# actions=fin_timeout(idle_timeout=10,hard_timeout=20)
ffff 0010 00002320 0013 000a 0014 0000
# actions=controller(reason=invalid_ttl,max_len=1234,id=5678)
ffff 0010 00002320 0014 04d2 162e 02 00
Implement serializing the state of packet traversal in "continuations". One purpose of OpenFlow packet-in messages is to allow a controller to interpose on the path of a packet through the flow tables. If, for example, the controller needs to modify a packet in some way that the switch doesn't directly support, the controller should be able to program the switch to send it the packet, then modify the packet and send it back to the switch to continue through the flow table. That's the theory. In practice, this doesn't work with any but the simplest flow tables. Packet-in messages simply don't include enough context to allow the flow table traversal to continue. For example: * Via "resubmit" actions, an Open vSwitch packet can have an effective "call stack", but a packet-in can't describe it, and so it would be lost. * A packet-in can't preserve the stack used by NXAST_PUSH and NXAST_POP actions. * A packet-in can't preserve the OpenFlow 1.1+ action set. * A packet-in can't preserve the state of Open vSwitch mirroring or connection tracking. This commit introduces a solution called "continuations". A continuation is the state of a packet's traversal through OpenFlow flow tables. A "controller" action with the "pause" flag, which is newly implemented in this commit, generates a continuation and sends it to the OpenFlow controller in a packet-in asynchronous message (only NXT_PACKET_IN2 supports continuations, so the controller must configure them with NXT_SET_PACKET_IN_FORMAT). The controller processes the packet-in, possibly modifying some of its data, and sends it back to the switch with an NXT_RESUME request, which causes flow table traversal to continue. In principle, a single packet can be paused and resumed multiple times. Another way to look at it is: - "pause" is an extension of the existing OFPAT_CONTROLLER action. It sends the packet to the controller, with full pipeline context (some of which is switch implementation dependent, and may thus vary from switch to switch). - A continuation is an extension of OFPT_PACKET_IN, allowing for implementation dependent metadata. - NXT_RESUME is an extension of OFPT_PACKET_OUT, with the semantics that the pipeline processing is continued with the original translation context from where it was left at the time it was paused. Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Jarno Rajahalme <jarno@ovn.org>
2016-02-19 16:10:06 -08:00
# actions=controller(reason=invalid_ttl,max_len=1234,id=5678,userdata=01.02.03.04.05,pause)
ffff 0040 00002320 0025 000000000000 dnl
Support userdata in NXT_PACKET_IN2. Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Jarno Rajahalme <jarno@ovn.org>
2016-02-19 15:53:26 -08:00
0000 0008 04d2 0000 dnl
0001 0008 162e 0000 dnl
0002 0005 02 000000 dnl
Implement serializing the state of packet traversal in "continuations". One purpose of OpenFlow packet-in messages is to allow a controller to interpose on the path of a packet through the flow tables. If, for example, the controller needs to modify a packet in some way that the switch doesn't directly support, the controller should be able to program the switch to send it the packet, then modify the packet and send it back to the switch to continue through the flow table. That's the theory. In practice, this doesn't work with any but the simplest flow tables. Packet-in messages simply don't include enough context to allow the flow table traversal to continue. For example: * Via "resubmit" actions, an Open vSwitch packet can have an effective "call stack", but a packet-in can't describe it, and so it would be lost. * A packet-in can't preserve the stack used by NXAST_PUSH and NXAST_POP actions. * A packet-in can't preserve the OpenFlow 1.1+ action set. * A packet-in can't preserve the state of Open vSwitch mirroring or connection tracking. This commit introduces a solution called "continuations". A continuation is the state of a packet's traversal through OpenFlow flow tables. A "controller" action with the "pause" flag, which is newly implemented in this commit, generates a continuation and sends it to the OpenFlow controller in a packet-in asynchronous message (only NXT_PACKET_IN2 supports continuations, so the controller must configure them with NXT_SET_PACKET_IN_FORMAT). The controller processes the packet-in, possibly modifying some of its data, and sends it back to the switch with an NXT_RESUME request, which causes flow table traversal to continue. In principle, a single packet can be paused and resumed multiple times. Another way to look at it is: - "pause" is an extension of the existing OFPAT_CONTROLLER action. It sends the packet to the controller, with full pipeline context (some of which is switch implementation dependent, and may thus vary from switch to switch). - A continuation is an extension of OFPT_PACKET_IN, allowing for implementation dependent metadata. - NXT_RESUME is an extension of OFPT_PACKET_OUT, with the semantics that the pipeline processing is continued with the original translation context from where it was left at the time it was paused. Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Jarno Rajahalme <jarno@ovn.org>
2016-02-19 16:10:06 -08:00
0003 0009 0102030405 00000000000000 dnl
0004 0004 00000000
Support userdata in NXT_PACKET_IN2. Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Jarno Rajahalme <jarno@ovn.org>
2016-02-19 15:53:26 -08:00
Add Nicira vendor extension action NXAST_DEC_TTL_CNT_IDS. Currently, if a controller having a nonzero id registers to get a OFPR_INVALID_TTL async message, it will not receive it. This is because compose_dec_ttl() only sent the invalid ttl packets to the default controller id. NXAST_DEC_TTL_CNT_IDS is a new action that accepts a list of controller ids, each separated by `,', to which the OFPR_INVALID_TTL packets must be sent. The earlier requirement of the controller having to explicitly register to receive these asynchronous messages is retained. The syntax of this action is: dec_ttl(id1,id2) where id1, id2 are valid controller ids. Signed-off-by: Mehak Mahajan <mmahajan@nicira.com>
2012-08-16 14:25:07 -07:00
# actions=dec_ttl(32768,12345,90,765,1024)
ffff 0020 00002320 0015 000500000000 80003039005A02fd 0400000000000000
Implement IPFIX export Define a new NXAST_SAMPLE OpenFlow vendor action and the corresponding OFPACT_SAMPLE OVS action, to do per-flow packet sampling, translated into a new SAMPLE "flow_sample" dp action. Make the userspace action's userdata size vary depending on the union member used. Add a new "flow_sample" upcall to do per-flow packet sampling. Add a new "ipfix" upcall to do per-bridge packet sampling to IPFIX collectors. Extend the OVSDB schema to support configuring IPFIX collector sets. Add support for configuring multiple IPFIX collectors for per-flow packet sampling. Add support for configuring per-bridge IPFIX sampling. Automatically generate standard IPFIX entity definitions from the IANA specs. Send one IPFIX data record message for every packet sampled by an OpenFlow sample action or received by a bridge configured with IPFIX sampling, and periodically send IPFIX template set messages. Signed-off-by: Romain Lenglet <rlenglet@vmware.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-04-22 10:01:14 -07:00
# actions=sample(probability=12345,collector_set_id=23456,obs_domain_id=34567,obs_point_id=45678)
ffff 0018 00002320 001d 3039 00005BA0 00008707 0000B26E
ofp-actions: Properly check for action that exceeds buffer length. Commit c2d936a44fa (ofp-actions: Centralize all OpenFlow action code for maintainability.) rewrote OpenFlow action parsing but failed to check that actions don't overflow their buffers. This commit fixes the problem and adds negative tests so that this bug doesn't recur. Reported-by: Tomer Pearl <Tomer.Pearl@Contextream.com> Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Justin Pettit <jpettit@nicira.com>
2014-10-23 14:34:04 -07:00
# bad OpenFlow10 actions: OFPBAC_BAD_LEN
& ofp_actions|WARN|OpenFlow action OFPAT_OUTPUT length 240 exceeds action buffer length 8
& ofp_actions|WARN|bad action at offset 0 (OFPBAC_BAD_LEN):
& 00000000 00 00 00 f0 00 00 00 00-
00 00 00 f0 00 00 00 00
# bad OpenFlow10 actions: OFPBAC_BAD_LEN
& ofp_actions|WARN|OpenFlow action OFPAT_OUTPUT length 16 not in valid range [[8,8]]
& ofp_actions|WARN|bad action at offset 0 (OFPBAC_BAD_LEN):
& 00000000 00 00 00 10 ff fe ff ff-00 00 00 00 00 00 00 00
00 00 00 10 ff fe ff ff 00 00 00 00 00 00 00 00
# bad OpenFlow10 actions: OFPBAC_BAD_LEN
& ofp_actions|WARN|OpenFlow action NXAST_DEC_TTL_CNT_IDS length 17 is not a multiple of 8
ffff 0011 00002320 0015 0001 00000000 0000000000000000
ofp-actions: OFPP_ANY (aka OFPP_NONE) is not a valid output port. This is implied by the list of ports that are valid for output in the various versions of the OpenFlow specification. Found by OFTest. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Flavio Leitner <fbl@sysclose.org>
2015-07-29 08:36:07 -07:00
# bad OpenFlow10 actions: OFPBAC_BAD_OUT_PORT
0000 0008 ffff 0000
Add support for connection tracking. This patch adds a new action and fields to OVS that allow connection tracking to be performed. This support works in conjunction with the Linux kernel support merged into the Linux-4.3 development cycle. Packets have two possible states with respect to connection tracking: Untracked packets have not previously passed through the connection tracker, while tracked packets have previously been through the connection tracker. For OpenFlow pipeline processing, untracked packets can become tracked, and they will remain tracked until the end of the pipeline. Tracked packets cannot become untracked. Connections can be unknown, uncommitted, or committed. Packets which are untracked have unknown connection state. To know the connection state, the packet must become tracked. Uncommitted connections have no connection state stored about them, so it is only possible for the connection tracker to identify whether they are a new connection or whether they are invalid. Committed connections have connection state stored beyond the lifetime of the packet, which allows later packets in the same connection to be identified as part of the same established connection, or related to an existing connection - for instance ICMP error responses. The new 'ct' action transitions the packet from "untracked" to "tracked" by sending this flow through the connection tracker. The following parameters are supported initally: - "commit": When commit is executed, the connection moves from uncommitted state to committed state. This signals that information about the connection should be stored beyond the lifetime of the packet within the pipeline. This allows future packets in the same connection to be recognized as part of the same "established" (est) connection, as well as identifying packets in the reply (rpl) direction, or packets related to an existing connection (rel). - "zone=[u16|NXM]": Perform connection tracking in the zone specified. Each zone is an independent connection tracking context. When the "commit" parameter is used, the connection will only be committed in the specified zone, and not in other zones. This is 0 by default. - "table=NUMBER": Fork pipeline processing in two. The original instance of the packet will continue processing the current actions list as an untracked packet. An additional instance of the packet will be sent to the connection tracker, which will be re-injected into the OpenFlow pipeline to resume processing in the specified table, with the ct_state and other ct match fields set. If the table is not specified, then the packet is submitted to the connection tracker, but the pipeline does not fork and the ct match fields are not populated. It is strongly recommended to specify a table later than the current table to prevent loops. When the "table" option is used, the packet that continues processing in the specified table will have the ct_state populated. The ct_state may have any of the following flags set: - Tracked (trk): Connection tracking has occurred. - Reply (rpl): The flow is in the reply direction. - Invalid (inv): The connection tracker couldn't identify the connection. - New (new): This is the beginning of a new connection. - Established (est): This is part of an already existing connection. - Related (rel): This connection is related to an existing connection. For more information, consult the ovs-ofctl(8) man pages. Below is a simple example flow table to allow outbound TCP traffic from port 1 and drop traffic from port 2 that was not initiated by port 1: table=0,priority=1,action=drop table=0,arp,action=normal table=0,in_port=1,tcp,ct_state=-trk,action=ct(commit,zone=9),2 table=0,in_port=2,tcp,ct_state=-trk,action=ct(zone=9,table=1) table=1,in_port=2,ct_state=+trk+est,tcp,action=1 table=1,in_port=2,ct_state=+trk+new,tcp,action=drop Based on original design by Justin Pettit, contributions from Thomas Graf and Daniele Di Proietto. Signed-off-by: Joe Stringer <joestringer@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
2015-08-11 10:56:09 -07:00
# actions=ct()
ffff 0018 00002320 0023 0000 00000000 0000 FF 000000 0000
# actions=ct(commit)
ffff 0018 00002320 0023 0001 00000000 0000 FF 000000 0000
# actions=ct(table=10)
ffff 0018 00002320 0023 0000 00000000 0000 0A 000000 0000
# actions=ct(zone=10)
ffff 0018 00002320 0023 0000 00000000 000A FF 000000 0000
# actions=ct(zone=NXM_NX_REG0[0..15])
ffff 0018 00002320 0023 0000 00010004 000F FF 000000 0000
dnl Can't read 8 bits from register into 16-bit zone.
# bad OpenFlow10 actions: OFPBAC_BAD_SET_LEN
ffff 0018 00002320 0023 0000 00010004 0007 FF 000000 0000
dnl Can't read 32 bits from register into 16-bit zone.
# bad OpenFlow10 actions: OFPBAC_BAD_SET_LEN
ffff 0018 00002320 0023 0000 00010004 001F FF 000000 0000
Add connection tracking mark support. This patch adds a new 32-bit metadata field to the connection tracking interface. When a mark is specified as part of the ct action and the connection is committed, the value is saved with the current connection. Subsequent ct lookups with the table specified will expose this metadata as the "ct_mark" field in the flow. For example, to allow new TCP connections from port 1->2 and only allow established connections from port 2->1, and to associate a mark with those connections: table=0,priority=1,action=drop table=0,arp,action=normal table=0,in_port=1,tcp,action=ct(commit,exec(set_field:1->ct_mark)),2 table=0,in_port=2,ct_state=-trk,tcp,action=ct(table=1) table=1,in_port=2,ct_state=+trk,ct_mark=1,tcp,action=1 Signed-off-by: Joe Stringer <joestringer@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
2015-09-18 13:58:00 -07:00
# actions=ct(commit,exec(load:0xf009->NXM_NX_CT_MARK[]))
ffff 0030 00002320 0023 0001 00000000 0000 FF 000000 0000 dnl
ffff 0018 00002320 0007 001f 0001d604 000000000000f009
# bad OpenFlow10 actions: OFPBAC_BAD_SET_ARGUMENT
& ofp_actions|WARN|cannot set CT fields outside of ct action
ffff 0018 00002320 0007 001f 0001d604 000000000000f009
# bad OpenFlow10 actions: OFPBAC_BAD_SET_ARGUMENT
& meta_flow|WARN|destination field ct_zone is not writable
ffff 0030 00002320 0023 0001 00000000 0000 FF 000000 0000 dnl
ffff 0018 00002320 0007 000f 0001d504 000000000000f009
# bad OpenFlow10 actions: OFPBAC_BAD_ARGUMENT
& ofp_actions|WARN|ct action doesn't support nested action ct
ffff 0030 00002320 0023 0001 00000000 0000 FF 000000 0000 dnl
ffff 0018 00002320 0023 0000 00000000 0000 FF 000000 0000
# bad OpenFlow10 actions: OFPBAC_BAD_ARGUMENT
& ofp_actions|WARN|ct action doesn't support nested modification of reg0
ffff 0030 00002320 0023 0001 00000000 0000 FF 000000 0000 dnl
ffff 0018 00002320 0007 001f 00010004 000000000000f009
Add support for connection tracking helper/ALGs. This patch adds support for specifying a "helper" or ALG to assist connection tracking for protocols that consist of multiple streams. Initially, only support for FTP is included. Below is an example set of flows to allow FTP control connections from port 1->2 to establish active data connections in the reverse direction: table=0,priority=1,action=drop table=0,arp,action=normal table=0,in_port=1,tcp,action=ct(alg=ftp,commit),2 table=0,in_port=2,tcp,ct_state=-trk,action=ct(table=1) table=1,in_port=2,tcp,ct_state=+trk+est,action=1 table=1,in_port=2,tcp,ct_state=+trk+rel,action=ct(commit),1 Signed-off-by: Joe Stringer <joestringer@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
2015-09-15 14:29:16 -07:00
# actions=ct(alg=ftp)
ffff 0018 00002320 0023 0000 00000000 0000 FF 000000 0015
conntrack: Add support for NAT. Extend OVS conntrack interface to cover NAT. New nested NAT action may be included with a CT action. A bare NAT action only mangles existing connections. If a NAT action with src or dst range attribute is included, new (non-committed) connections are mangled according to the NAT attributes. This work extends on a branch by Thomas Graf at https://github.com/tgraf/ovs/tree/nat. Signed-off-by: Jarno Rajahalme <jarno@ovn.org> Acked-by: Ben Pfaff <blp@ovn.org>
2015-11-24 15:47:56 -08:00
# actions=ct(commit,nat(src))
ffff 0028 00002320 0023 0001 00000000 0000 FF 000000 0000 dnl
ffff 0010 00002320 0024 00 00 0001 0000
# actions=ct(commit,nat(dst))
ffff 0028 00002320 0023 0001 00000000 0000 FF 000000 0000 dnl
ffff 0010 00002320 0024 00 00 0002 0000
# actions=ct(nat)
ffff 0028 00002320 0023 0000 00000000 0000 FF 000000 0000 dnl
ffff 0010 00002320 0024 00 00 0000 0000
# actions=ct(commit,nat(src=10.0.0.240,random))
ffff 0030 00002320 0023 0001 00000000 0000 FF 000000 0000 dnl
ffff 0018 00002320 0024 00 00 0011 0001 0a0000f0 00000000
# actions=ct(commit,nat(src=10.0.0.240:32768-65535,random))
ffff 0030 00002320 0023 0001 00000000 0000 FF 000000 0000 dnl
ffff 0018 00002320 0024 00 00 0011 0031 0a0000f0 8000ffff
# actions=ct(commit,nat(dst=10.0.0.128-10.0.0.254,hash))
ffff 0030 00002320 0023 0001 00000000 0000 FF 000000 0000 dnl
ffff 0018 00002320 0024 00 00 000a 0003 0a000080 0a0000fe
# actions=ct(commit,nat(src=10.0.0.240-10.0.0.254:32768-65535,persistent))
ffff 0038 00002320 0023 0001 00000000 0000 FF 000000 0000 dnl
ffff 0020 00002320 0024 00 00 0005 0033 0a0000f0 0a0000fe 8000ffff 00000000
# actions=ct(commit,nat(src=fe80::20c:29ff:fe88:a18b,random))
ffff 0038 00002320 0023 0001 00000000 0000 FF 000000 0000 dnl
ffff 0020 00002320 0024 00 00 0011 0004 fe800000 00000000 020c 29ff fe88 a18b
# actions=ct(commit,nat(src=fe80::20c:29ff:fe88:1-fe80::20c:29ff:fe88:a18b,random))
ffff 0048 00002320 0023 0001 00000000 0000 FF 000000 0000 dnl
ffff 0030 00002320 0024 00 00 0011 000c fe800000 00000000 020c 29ff fe88 0001 fe800000 00000000 020c 29ff fe88 a18b
# actions=ct(commit,nat(src=[fe80::20c:29ff:fe88:1]-[fe80::20c:29ff:fe88:a18b]:255-4096,random))
ffff 0050 00002320 0023 0001 00000000 0000 FF 000000 0000 dnl
ffff 0038 00002320 0024 00 00 0011 003c dnl
fe800000 00000000 020c 29ff fe88 0001 dnl
fe800000 00000000 020c 29ff fe88 a18b dnl
00ff1000 00000000
Implement serializing the state of packet traversal in "continuations". One purpose of OpenFlow packet-in messages is to allow a controller to interpose on the path of a packet through the flow tables. If, for example, the controller needs to modify a packet in some way that the switch doesn't directly support, the controller should be able to program the switch to send it the packet, then modify the packet and send it back to the switch to continue through the flow table. That's the theory. In practice, this doesn't work with any but the simplest flow tables. Packet-in messages simply don't include enough context to allow the flow table traversal to continue. For example: * Via "resubmit" actions, an Open vSwitch packet can have an effective "call stack", but a packet-in can't describe it, and so it would be lost. * A packet-in can't preserve the stack used by NXAST_PUSH and NXAST_POP actions. * A packet-in can't preserve the OpenFlow 1.1+ action set. * A packet-in can't preserve the state of Open vSwitch mirroring or connection tracking. This commit introduces a solution called "continuations". A continuation is the state of a packet's traversal through OpenFlow flow tables. A "controller" action with the "pause" flag, which is newly implemented in this commit, generates a continuation and sends it to the OpenFlow controller in a packet-in asynchronous message (only NXT_PACKET_IN2 supports continuations, so the controller must configure them with NXT_SET_PACKET_IN_FORMAT). The controller processes the packet-in, possibly modifying some of its data, and sends it back to the switch with an NXT_RESUME request, which causes flow table traversal to continue. In principle, a single packet can be paused and resumed multiple times. Another way to look at it is: - "pause" is an extension of the existing OFPAT_CONTROLLER action. It sends the packet to the controller, with full pipeline context (some of which is switch implementation dependent, and may thus vary from switch to switch). - A continuation is an extension of OFPT_PACKET_IN, allowing for implementation dependent metadata. - NXT_RESUME is an extension of OFPT_PACKET_OUT, with the semantics that the pipeline processing is continued with the original translation context from where it was left at the time it was paused. Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Jarno Rajahalme <jarno@ovn.org>
2016-02-19 16:10:06 -08:00
# bad OpenFlow10 actions: NXBRC_MUST_BE_ZERO
ffff 0018 00002320 0025 0000 0005 0000 1122334455 000005
# bad OpenFlow10 actions: NXBRC_MUST_BE_ZERO
ffff 0018 00002320 0025 0000 0005 5000 1122334455 000000
conntrack: Add support for NAT. Extend OVS conntrack interface to cover NAT. New nested NAT action may be included with a CT action. A bare NAT action only mangles existing connections. If a NAT action with src or dst range attribute is included, new (non-committed) connections are mangled according to the NAT attributes. This work extends on a branch by Thomas Graf at https://github.com/tgraf/ovs/tree/nat. Signed-off-by: Jarno Rajahalme <jarno@ovn.org> Acked-by: Ben Pfaff <blp@ovn.org>
2015-11-24 15:47:56 -08:00
# bad OpenFlow10 actions: OFPBAC_BAD_ARGUMENT
ffff 0048 00002320 0023 0001 00000000 0000 FF 000000 0000 dnl
ffff 0030 00002320 0024 00 00 0011 000c fe800000 00000000 020c 29ff fe88 a18b fe800000 00000000 020c 29ff fe88 0001
Introduce ofpacts, an abstraction of OpenFlow actions. OpenFlow actions have always been somewhat awkward to handle. Moreover, over time we've started creating actions that require more complicated parsing. When we maintain those actions internally in their wire format, we end up parsing them multiple times, whenever we have to look at the set of actions. When we add support for OpenFlow 1.1 or later protocols, the situation will get worse, because these newer protocols support many of the same actions but with different representations. It becomes unrealistic to handle each protocol in its wire format. This commit adopts a new strategy, by converting OpenFlow actions into an internal form from the wire format when they are read, and converting them back to the wire format when flows are dumped. I believe that this will be more maintainable over time. Thanks to Simon Horman and Pravin Shelar for reviews. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-03 22:17:14 -07:00
])
sed '/^[[#&]]/d' < test-data > input.txt
sed -n 's/^# //p; /^$/p' < test-data > expout
sed -n 's/^& //p' < test-data > experr
AT_CAPTURE_FILE([input.txt])
AT_CAPTURE_FILE([expout])
AT_CAPTURE_FILE([experr])
AT_CHECK(
ovs-ofctl: Generalize action and instruction test commands. Until now, there were four of these commands: parse-ofp10-actions, parse-ofp10-instructions, parse-ofp11-actions, parse-ofp11-instructions. This is painful to add support for new OpenFlow versions and has a ton of cut-and-paste code. This commit generalizes the code to improve on both of those points. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-07 16:03:42 -07:00
[ovs-ofctl '-vPATTERN:console:%c|%p|%m' parse-actions OpenFlow10 < input.txt],
Introduce ofpacts, an abstraction of OpenFlow actions. OpenFlow actions have always been somewhat awkward to handle. Moreover, over time we've started creating actions that require more complicated parsing. When we maintain those actions internally in their wire format, we end up parsing them multiple times, whenever we have to look at the set of actions. When we add support for OpenFlow 1.1 or later protocols, the situation will get worse, because these newer protocols support many of the same actions but with different representations. It becomes unrealistic to handle each protocol in its wire format. This commit adopts a new strategy, by converting OpenFlow actions into an internal form from the wire format when they are read, and converting them back to the wire format when flows are dumped. I believe that this will be more maintainable over time. Thanks to Simon Horman and Pravin Shelar for reviews. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-03 22:17:14 -07:00
[0], [expout], [experr])
AT_CLEANUP
ofp-actions: Add decoding and encoding OF1.1 instructions and actions. So far, only the Apply-Actions instruction is supported, and only actions that have identical semantics to OpenFlow 1.0 actions. Co-authored-by: Simon Horman <horms@verge.net.au> Co-authored-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-03 22:14:29 -07:00
ofp-actions: Pretend that OpenFlow 1.0 has instructions. This allows callers to be more uniform, because they don't have to pick out whether they should parse actions or instructions based on the OpenFlow version in use. It also allows the Write-Metadata instruction emulation in OpenFlow 1.0 to be treated just as in OpenFlow 1.1 in the sense that it is allowed in contexts where instructions are allowed in OpenFlow 1.1 and not elsewhere. (The changes in the tests reflect this more accurate treatment.) Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-07 16:09:07 -07:00
AT_SETUP([OpenFlow 1.0 "instruction" translations])
AT_KEYWORDS([ofp-actions OF1.0 instruction])
AT_DATA([test-data], [dnl
dnl Try a couple of ordinary actions to make sure they're accepted,
dnl but there's no point in retrying all the actions from the previous test.
# actions=LOCAL
0000 0008 fffe 04d2
# actions=mod_dl_src:00:11:22:33:44:55
0004 0010 001122334455 000000000000
dnl Now check that write_metadata is accepted.
# actions=write_metadata:0xfedcba9876543210
ffff 0020 00002320 0016 000000000000 fedcba9876543210 ffffffffffffffff
# actions=write_metadata:0xfedcba9876543210/0xffff0000ffff0000
ffff 0020 00002320 0016 000000000000 fedcba9876543210 ffff0000ffff0000
])
sed '/^[[#&]]/d' < test-data > input.txt
sed -n 's/^# //p; /^$/p' < test-data > expout
sed -n 's/^& //p' < test-data > experr
AT_CAPTURE_FILE([input.txt])
AT_CAPTURE_FILE([expout])
AT_CAPTURE_FILE([experr])
AT_CHECK(
ovs-ofctl: Generalize action and instruction test commands. Until now, there were four of these commands: parse-ofp10-actions, parse-ofp10-instructions, parse-ofp11-actions, parse-ofp11-instructions. This is painful to add support for new OpenFlow versions and has a ton of cut-and-paste code. This commit generalizes the code to improve on both of those points. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-07 16:03:42 -07:00
[ovs-ofctl '-vPATTERN:console:%c|%p|%m' parse-instructions OpenFlow10 < input.txt],
ofp-actions: Pretend that OpenFlow 1.0 has instructions. This allows callers to be more uniform, because they don't have to pick out whether they should parse actions or instructions based on the OpenFlow version in use. It also allows the Write-Metadata instruction emulation in OpenFlow 1.0 to be treated just as in OpenFlow 1.1 in the sense that it is allowed in contexts where instructions are allowed in OpenFlow 1.1 and not elsewhere. (The changes in the tests reflect this more accurate treatment.) Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-07 16:09:07 -07:00
[0], [expout], [experr])
AT_CLEANUP
ofp-actions: Add decoding and encoding OF1.1 instructions and actions. So far, only the Apply-Actions instruction is supported, and only actions that have identical semantics to OpenFlow 1.0 actions. Co-authored-by: Simon Horman <horms@verge.net.au> Co-authored-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-03 22:14:29 -07:00
AT_SETUP([OpenFlow 1.1 action translation])
ofp-actions: Implement writing to metadata field In OpenFlow 1.1, we add support for OFPIT_WRITE_METADATA. This allows us to write to the metadata field. Internally it is represented using ofpact_metadata. We introduce NXAST_WRITE_METADATA to handle writing to the metadata field in OpenFlow 1.0+. This structure reflects OFPIT_WRITE_METADATA. When writing out the structure to OpenFlow 1.1, it uses the OFPIT_WRITE_METADATA instruction only, and not the new NXAST action (which would be redundant). Signed-off-by: Joe Stringer <joe@wand.net.nz> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-10-19 02:37:37 +09:00
AT_KEYWORDS([ofp-actions OF1.1])
ofp-actions: Add decoding and encoding OF1.1 instructions and actions. So far, only the Apply-Actions instruction is supported, and only actions that have identical semantics to OpenFlow 1.0 actions. Co-authored-by: Simon Horman <horms@verge.net.au> Co-authored-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-03 22:14:29 -07:00
AT_DATA([test-data], [dnl
# actions=LOCAL
0000 0010 fffffffe 04d2 000000000000
# actions=CONTROLLER:1234
0000 0010 fffffffd 04d2 000000000000
OF 1.1 set vlan vid/pcp compatibility. OpenFlow 1.1 set vlan actions only modify existing vlan headers, while OF 1.0 actions push a new vlan header if one does not exist already. Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-10-24 13:19:25 -07:00
# actions=set_vlan_vid:9
ofp-actions: Add decoding and encoding OF1.1 instructions and actions. So far, only the Apply-Actions instruction is supported, and only actions that have identical semantics to OpenFlow 1.0 actions. Co-authored-by: Simon Horman <horms@verge.net.au> Co-authored-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-03 22:14:29 -07:00
0001 0008 0009 0000
OF 1.1 set vlan vid/pcp compatibility. OpenFlow 1.1 set vlan actions only modify existing vlan headers, while OF 1.0 actions push a new vlan header if one does not exist already. Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-10-24 13:19:25 -07:00
# actions=set_vlan_pcp:6
ofp-actions: Add decoding and encoding OF1.1 instructions and actions. So far, only the Apply-Actions instruction is supported, and only actions that have identical semantics to OpenFlow 1.0 actions. Co-authored-by: Simon Horman <horms@verge.net.au> Co-authored-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-03 22:14:29 -07:00
0002 0008 06 000000
# actions=mod_dl_src:00:11:22:33:44:55
0003 0010 001122334455 000000000000
# actions=mod_dl_dst:10:20:30:40:50:60
0004 0010 102030405060 000000000000
# actions=mod_nw_src:1.2.3.4
0005 0008 01020304
# actions=mod_nw_dst:192.168.0.1
0006 0008 c0a80001
# actions=mod_nw_tos:48
0007 0008 30 000000
# actions=mod_tp_src:80
0009 0008 0050 0000
# actions=mod_tp_dst:443
000a 0008 01bb 0000
OF 1.1 pop vlan compatibility. Store the original action code with the strip vlan action, so that it can be printed back properly. Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-10-24 13:19:26 -07:00
# actions=pop_vlan
ofpaction: support OF11 pop_vlan This patch adds support of OF11+ pop_vlan. Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp> [blp@nicira.com added a test] Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-10-18 03:51:58 +09:00
0012 0008 00000000
ofp-actions: Add OpenFlow1.1+ Set Queue action Signed-off-by: Simon Horman <horms@verge.net.au> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-11-30 10:04:06 +09:00
# actions=set_queue:2309737729
0015 0008 89abcd01
OF11: push_vlan support This implementes push_vlan with 802.1Q. NOTE: 802.1AD (QinQ) is not supported. It requires another effort. Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-10-26 13:43:19 +09:00
dnl 802.1ad isn't supported at the moment
dnl # actions=push_vlan:0x88a8
dnl 0011 0008 88a8 0000
# actions=push_vlan:0x8100
0011 0008 8100 0000
ofp-actions: Add decoding and encoding OF1.1 instructions and actions. So far, only the Apply-Actions instruction is supported, and only actions that have identical semantics to OpenFlow 1.0 actions. Co-authored-by: Simon Horman <horms@verge.net.au> Co-authored-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-03 22:14:29 -07:00
# actions=resubmit:5
ffff 0010 00002320 0001 0005 00000000
# actions=set_tunnel:0x12345678
ffff 0010 00002320 0002 0000 12345678
# actions=pop_queue
ffff 0010 00002320 0005 000000000000
# actions=move:NXM_OF_IN_PORT[]->NXM_OF_VLAN_TCI[]
ffff 0018 00002320 0006 0010 0000 0000 00000002 00000802
# actions=load:0xf009->NXM_OF_VLAN_TCI[]
ffff 0018 00002320 0007 000f 00000802 000000000000f009
# actions=note:11.e9.9a.ad.67.f3
ffff 0010 00002320 0008 11e99aad67f3
# actions=set_tunnel64:0xc426384d49c53d60
ffff 0018 00002320 0009 000000000000 c426384d49c53d60
# actions=set_tunnel64:0x885f3298
ffff 0018 00002320 0009 000000000000 00000000885f3298
ofp-actions: Pretend that OpenFlow 1.0 has instructions. This allows callers to be more uniform, because they don't have to pick out whether they should parse actions or instructions based on the OpenFlow version in use. It also allows the Write-Metadata instruction emulation in OpenFlow 1.0 to be treated just as in OpenFlow 1.1 in the sense that it is allowed in contexts where instructions are allowed in OpenFlow 1.1 and not elsewhere. (The changes in the tests reflect this more accurate treatment.) Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-07 16:09:07 -07:00
dnl Write-Metadata is only allowed in contexts that allow instructions.
& ofp_actions|WARN|write_metadata instruction not allowed here
ovs-ofctl: Generalize action and instruction test commands. Until now, there were four of these commands: parse-ofp10-actions, parse-ofp10-instructions, parse-ofp11-actions, parse-ofp11-instructions. This is painful to add support for new OpenFlow versions and has a ton of cut-and-paste code. This commit generalizes the code to improve on both of those points. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-07 16:03:42 -07:00
# bad OpenFlow11 actions: OFPBIC_UNSUP_INST
ofp-actions: Implement writing to metadata field In OpenFlow 1.1, we add support for OFPIT_WRITE_METADATA. This allows us to write to the metadata field. Internally it is represented using ofpact_metadata. We introduce NXAST_WRITE_METADATA to handle writing to the metadata field in OpenFlow 1.0+. This structure reflects OFPIT_WRITE_METADATA. When writing out the structure to OpenFlow 1.1, it uses the OFPIT_WRITE_METADATA instruction only, and not the new NXAST action (which would be redundant). Signed-off-by: Joe Stringer <joe@wand.net.nz> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-10-19 02:37:37 +09:00
ffff 0020 00002320 0016 000000000000 fedcba9876543210 ffffffffffffffff
ofp-actions: Add decoding and encoding OF1.1 instructions and actions. So far, only the Apply-Actions instruction is supported, and only actions that have identical semantics to OpenFlow 1.0 actions. Co-authored-by: Simon Horman <horms@verge.net.au> Co-authored-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-03 22:14:29 -07:00
# actions=multipath(eth_src,50,modulo_n,1,0,NXM_NX_REG0[])
ffff 0020 00002320 000a 0000 0032 0000 0000 0000 0000 0000 0000 001f 00010004
# actions=bundle(eth_src,0,hrw,ofport,slaves:4,8)
ffff 0028 00002320 000c 0001 0000 0000 00000002 0002 0000 00000000 00000000 dnl
0004 0008 00000000
# actions=bundle_load(eth_src,0,hrw,ofport,NXM_NX_REG0[],slaves:4,8)
ffff 0028 00002320 000d 0001 0000 0000 00000002 0002 001f 00010004 00000000 dnl
0004 0008 00000000
# actions=resubmit(10,5)
ffff 0010 00002320 000e 000a 05 000000
# actions=output:NXM_NX_REG1[5..10]
ffff 0018 00002320 000f 0145 00010204 ffff 000000000000
# actions=learn(table=2,idle_timeout=10,hard_timeout=20,fin_idle_timeout=2,fin_hard_timeout=4,priority=80,cookie=0x123456789abcdef0,NXM_OF_VLAN_TCI[0..11],NXM_OF_ETH_DST[]=NXM_OF_ETH_SRC[],output:NXM_OF_IN_PORT[])
ffff 0048 00002320 0010 000a 0014 0050 123456789abcdef0 0000 02 00 0002 0004 dnl
000c 00000802 0000 00000802 0000 dnl
0030 00000406 0000 00000206 0000 dnl
1010 00000002 0000 dnl
00000000
# actions=exit
ffff 0010 00002320 0011 000000000000
lib: support OF11 dec_nw_ttl Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp> [blp@nicira.com changed code to use "dec_ttl" instead of "dec_nw_ttl"] Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-10-18 07:02:04 +09:00
dnl OpenFlow 1.1 OFPAT_DEC_TTL
# actions=dec_ttl
0018 0008 00000000
ofp-actions: Add decoding and encoding OF1.1 instructions and actions. So far, only the Apply-Actions instruction is supported, and only actions that have identical semantics to OpenFlow 1.0 actions. Co-authored-by: Simon Horman <horms@verge.net.au> Co-authored-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-03 22:14:29 -07:00
# actions=fin_timeout(idle_timeout=10,hard_timeout=20)
ffff 0010 00002320 0013 000a 0014 0000
# actions=controller(reason=invalid_ttl,max_len=1234,id=5678)
ffff 0010 00002320 0014 04d2 162e 02 00
Add Nicira vendor extension action NXAST_DEC_TTL_CNT_IDS. Currently, if a controller having a nonzero id registers to get a OFPR_INVALID_TTL async message, it will not receive it. This is because compose_dec_ttl() only sent the invalid ttl packets to the default controller id. NXAST_DEC_TTL_CNT_IDS is a new action that accepts a list of controller ids, each separated by `,', to which the OFPR_INVALID_TTL packets must be sent. The earlier requirement of the controller having to explicitly register to receive these asynchronous messages is retained. The syntax of this action is: dec_ttl(id1,id2) where id1, id2 are valid controller ids. Signed-off-by: Mehak Mahajan <mmahajan@nicira.com>
2012-08-16 14:25:07 -07:00
# actions=dec_ttl(32768,12345,90,765,1024)
ffff 0020 00002320 0015 000500000000 80003039005A02fd 0400000000000000
Implement IPFIX export Define a new NXAST_SAMPLE OpenFlow vendor action and the corresponding OFPACT_SAMPLE OVS action, to do per-flow packet sampling, translated into a new SAMPLE "flow_sample" dp action. Make the userspace action's userdata size vary depending on the union member used. Add a new "flow_sample" upcall to do per-flow packet sampling. Add a new "ipfix" upcall to do per-bridge packet sampling to IPFIX collectors. Extend the OVSDB schema to support configuring IPFIX collector sets. Add support for configuring multiple IPFIX collectors for per-flow packet sampling. Add support for configuring per-bridge IPFIX sampling. Automatically generate standard IPFIX entity definitions from the IANA specs. Send one IPFIX data record message for every packet sampled by an OpenFlow sample action or received by a bridge configured with IPFIX sampling, and periodically send IPFIX template set messages. Signed-off-by: Romain Lenglet <rlenglet@vmware.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-04-22 10:01:14 -07:00
# actions=sample(probability=12345,collector_set_id=23456,obs_domain_id=34567,obs_point_id=45678)
ffff 0018 00002320 001d 3039 00005BA0 00008707 0000B26E
ofp-actions: OFPP_ANY (aka OFPP_NONE) is not a valid output port. This is implied by the list of ports that are valid for output in the various versions of the OpenFlow specification. Found by OFTest. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Flavio Leitner <fbl@sysclose.org>
2015-07-29 08:36:07 -07:00
# bad OpenFlow11 actions: OFPBAC_BAD_OUT_PORT
& ofp_actions|WARN|bad action at offset 0 (OFPBAC_BAD_OUT_PORT):
& 00000000 00 00 00 10 ff ff ff ff-00 00 00 00 00 00 00 00
0000 0010 ffffffff 0000 000000000000
ofp-actions: Add decoding and encoding OF1.1 instructions and actions. So far, only the Apply-Actions instruction is supported, and only actions that have identical semantics to OpenFlow 1.0 actions. Co-authored-by: Simon Horman <horms@verge.net.au> Co-authored-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-03 22:14:29 -07:00
])
sed '/^[[#&]]/d' < test-data > input.txt
sed -n 's/^# //p; /^$/p' < test-data > expout
sed -n 's/^& //p' < test-data > experr
AT_CAPTURE_FILE([input.txt])
AT_CAPTURE_FILE([expout])
AT_CAPTURE_FILE([experr])
AT_CHECK(
ovs-ofctl: Generalize action and instruction test commands. Until now, there were four of these commands: parse-ofp10-actions, parse-ofp10-instructions, parse-ofp11-actions, parse-ofp11-instructions. This is painful to add support for new OpenFlow versions and has a ton of cut-and-paste code. This commit generalizes the code to improve on both of those points. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-07 16:03:42 -07:00
[ovs-ofctl '-vPATTERN:console:%c|%p|%m' parse-actions OpenFlow11 < input.txt],
ofp-actions: Add decoding and encoding OF1.1 instructions and actions. So far, only the Apply-Actions instruction is supported, and only actions that have identical semantics to OpenFlow 1.0 actions. Co-authored-by: Simon Horman <horms@verge.net.au> Co-authored-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-03 22:14:29 -07:00
[0], [expout], [experr])
AT_CLEANUP
AT_SETUP([OpenFlow 1.1 instruction translation])
ofp-actions: Implement writing to metadata field In OpenFlow 1.1, we add support for OFPIT_WRITE_METADATA. This allows us to write to the metadata field. Internally it is represented using ofpact_metadata. We introduce NXAST_WRITE_METADATA to handle writing to the metadata field in OpenFlow 1.0+. This structure reflects OFPIT_WRITE_METADATA. When writing out the structure to OpenFlow 1.1, it uses the OFPIT_WRITE_METADATA instruction only, and not the new NXAST action (which would be redundant). Signed-off-by: Joe Stringer <joe@wand.net.nz> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-10-19 02:37:37 +09:00
AT_KEYWORDS([OF1.1 instruction ofp-actions])
ofp-actions: Add decoding and encoding OF1.1 instructions and actions. So far, only the Apply-Actions instruction is supported, and only actions that have identical semantics to OpenFlow 1.0 actions. Co-authored-by: Simon Horman <horms@verge.net.au> Co-authored-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-03 22:14:29 -07:00
AT_DATA([test-data], [dnl
# actions=LOCAL
0004 0018 00000000 dnl
0000 0010 fffffffe 04d2 000000000000
instruction: support goto-table action Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-10-05 15:56:56 +09:00
dnl Apply-Actions non-zero padding
# actions=drop
# 0: 00 -> (none)
# 1: 04 -> (none)
# 2: 00 -> (none)
# 3: 08 -> (none)
# 4: 00 -> (none)
# 5: 00 -> (none)
# 6: 00 -> (none)
# 7: 01 -> (none)
0004 0008 00000001
ofp-actions: Add decoding and encoding OF1.1 instructions and actions. So far, only the Apply-Actions instruction is supported, and only actions that have identical semantics to OpenFlow 1.0 actions. Co-authored-by: Simon Horman <horms@verge.net.au> Co-authored-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-03 22:14:29 -07:00
dnl Check that an empty Apply-Actions instruction gets dropped.
# actions=drop
# 0: 00 -> (none)
# 1: 04 -> (none)
# 2: 00 -> (none)
# 3: 08 -> (none)
# 4: 00 -> (none)
# 5: 00 -> (none)
# 6: 00 -> (none)
# 7: 00 -> (none)
0004 0008 00000000
ofp-errors: Remove OFPERR_NXBIC_DUP_TYPE OFPERR_NXBIC_DUP_TYPE is currently only used in decode_openflow11_instructions() which is part of a non-NX extension portion of the Open Flow 1.1+ implementation. After recent discussion it has been decided to attempt to only use standardised, albeit less-specific, errors unless errors arise from use of an NX extension. With the above in mind it seems appropriate to: * Use OFPERR_OFPIT_BAD_INSTRUCTION in place of OFPERR_NXBIC_DUP_TYPE. * Remove OFPERR_NXBIC_DUP_TYPE as it is no longer used. An unfortunate side-effect of this change is that the error for the case in question is now less-specific. Signed-off-by: Simon Horman <horms@verge.net.au> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-09-04 15:51:59 +09:00
dnl Duplicate instruction type:
ovs-ofctl: Generalize action and instruction test commands. Until now, there were four of these commands: parse-ofp10-actions, parse-ofp10-instructions, parse-ofp11-actions, parse-ofp11-instructions. This is painful to add support for new OpenFlow versions and has a ton of cut-and-paste code. This commit generalizes the code to improve on both of those points. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-07 16:03:42 -07:00
# bad OpenFlow11 instructions: OFPBIC_DUP_INST
ofp-actions: Add decoding and encoding OF1.1 instructions and actions. So far, only the Apply-Actions instruction is supported, and only actions that have identical semantics to OpenFlow 1.0 actions. Co-authored-by: Simon Horman <horms@verge.net.au> Co-authored-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-03 22:14:29 -07:00
0004 0008 00000000 0004 0008 00000000
dnl Instructions not multiple of 8 in length.
& ofp_actions|WARN|OpenFlow message instructions length 9 is not a multiple of 8
ovs-ofctl: Generalize action and instruction test commands. Until now, there were four of these commands: parse-ofp10-actions, parse-ofp10-instructions, parse-ofp11-actions, parse-ofp11-instructions. This is painful to add support for new OpenFlow versions and has a ton of cut-and-paste code. This commit generalizes the code to improve on both of those points. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-07 16:03:42 -07:00
# bad OpenFlow11 instructions: OFPBIC_BAD_LEN
ofp-actions: Add decoding and encoding OF1.1 instructions and actions. So far, only the Apply-Actions instruction is supported, and only actions that have identical semantics to OpenFlow 1.0 actions. Co-authored-by: Simon Horman <horms@verge.net.au> Co-authored-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-03 22:14:29 -07:00
0004 0009 01 00000000
dnl Goto-Table instruction too long.
ovs-ofctl: Generalize action and instruction test commands. Until now, there were four of these commands: parse-ofp10-actions, parse-ofp10-instructions, parse-ofp11-actions, parse-ofp11-instructions. This is painful to add support for new OpenFlow versions and has a ton of cut-and-paste code. This commit generalizes the code to improve on both of those points. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-07 16:03:42 -07:00
# bad OpenFlow11 instructions: OFPBIC_BAD_LEN
ofp-actions: Add decoding and encoding OF1.1 instructions and actions. So far, only the Apply-Actions instruction is supported, and only actions that have identical semantics to OpenFlow 1.0 actions. Co-authored-by: Simon Horman <horms@verge.net.au> Co-authored-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-03 22:14:29 -07:00
0001 0010 01 000000 0000000000000000
instruction: support goto-table action Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-10-05 15:56:56 +09:00
dnl Goto-Table 1 instruction non-zero padding
# actions=goto_table:1
# 7: 01 -> 00
0001 0008 01 000001
ofp-actions: enforce valid range for table_id in goto_table instruction Found a bug that OVS allows goto_table_id to be smaller than (or equal to) the current table id where the flow resides. It potentially creates an infinite loop when composing actions for a packet. To fix it, we just let OVS returns an error message to prevent such flow to be programmed. Signed-off-by: Jing Ai <jinga@google.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-06-05 13:18:09 -07:00
dnl Goto-Table 1 instruction go back to the previous table.
ofp-actions: Fix error code for invalid table id. Send OFPET_BAD_INSTRUCTION/OFPBIC_BAD_TABLE_ID if table is invalid in goto table instruction. Signed-off-by: Selvamuthukumar <smkumar@merunetworks.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2014-09-24 09:53:13 -07:00
# bad OpenFlow11 instructions: OFPBIC_BAD_TABLE_ID
ofp-actions: enforce valid range for table_id in goto_table instruction Found a bug that OVS allows goto_table_id to be smaller than (or equal to) the current table id where the flow resides. It potentially creates an infinite loop when composing actions for a packet. To fix it, we just let OVS returns an error message to prevent such flow to be programmed. Signed-off-by: Jing Ai <jinga@google.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-06-05 13:18:09 -07:00
2,0001 0008 01 000000
instruction: support goto-table action Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-10-05 15:56:56 +09:00
dnl Goto-Table 1
# actions=goto_table:1
ofp-actions: Add decoding and encoding OF1.1 instructions and actions. So far, only the Apply-Actions instruction is supported, and only actions that have identical semantics to OpenFlow 1.0 actions. Co-authored-by: Simon Horman <horms@verge.net.au> Co-authored-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-03 22:14:29 -07:00
0001 0008 01 000000
ofp-actions: Implement writing to metadata field In OpenFlow 1.1, we add support for OFPIT_WRITE_METADATA. This allows us to write to the metadata field. Internally it is represented using ofpact_metadata. We introduce NXAST_WRITE_METADATA to handle writing to the metadata field in OpenFlow 1.0+. This structure reflects OFPIT_WRITE_METADATA. When writing out the structure to OpenFlow 1.1, it uses the OFPIT_WRITE_METADATA instruction only, and not the new NXAST action (which would be redundant). Signed-off-by: Joe Stringer <joe@wand.net.nz> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-10-19 02:37:37 +09:00
dnl Write-Metadata.
# actions=write_metadata:0xfedcba9876543210
ofp-actions: Add decoding and encoding OF1.1 instructions and actions. So far, only the Apply-Actions instruction is supported, and only actions that have identical semantics to OpenFlow 1.0 actions. Co-authored-by: Simon Horman <horms@verge.net.au> Co-authored-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-03 22:14:29 -07:00
0002 0018 00000000 fedcba9876543210 ffffffffffffffff
ofp-actions: Pretend that OpenFlow 1.0 has instructions. This allows callers to be more uniform, because they don't have to pick out whether they should parse actions or instructions based on the OpenFlow version in use. It also allows the Write-Metadata instruction emulation in OpenFlow 1.0 to be treated just as in OpenFlow 1.1 in the sense that it is allowed in contexts where instructions are allowed in OpenFlow 1.1 and not elsewhere. (The changes in the tests reflect this more accurate treatment.) Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-07 16:09:07 -07:00
dnl Write-Metadata as Nicira extension action is transformed into instruction.
# actions=write_metadata:0xfedcba9876543210
# 1: 04 -> 02
# 3: 28 -> 18
# 8: ff -> fe
# 9: ff -> dc
# 10: 00 -> ba
# 11: 20 -> 98
# 12: 00 -> 76
# 13: 00 -> 54
# 14: 23 -> 32
# 15: 20 -> 10
# 16: 00 -> ff
# 17: 16 -> ff
# 18: 00 -> ff
# 19: 00 -> ff
# 20: 00 -> ff
# 21: 00 -> ff
# 22: 00 -> ff
# 23: 00 -> ff
# 24: fe -> (none)
# 25: dc -> (none)
# 26: ba -> (none)
# 27: 98 -> (none)
# 28: 76 -> (none)
# 29: 54 -> (none)
# 30: 32 -> (none)
# 31: 10 -> (none)
# 32: ff -> (none)
# 33: ff -> (none)
# 34: ff -> (none)
# 35: ff -> (none)
# 36: ff -> (none)
# 37: ff -> (none)
# 38: ff -> (none)
# 39: ff -> (none)
0004 0028 00000000 ffff 0020 00002320 0016 000000000000 fedcba9876543210 ffffffffffffffff
ofp-actions: Implement writing to metadata field In OpenFlow 1.1, we add support for OFPIT_WRITE_METADATA. This allows us to write to the metadata field. Internally it is represented using ofpact_metadata. We introduce NXAST_WRITE_METADATA to handle writing to the metadata field in OpenFlow 1.0+. This structure reflects OFPIT_WRITE_METADATA. When writing out the structure to OpenFlow 1.1, it uses the OFPIT_WRITE_METADATA instruction only, and not the new NXAST action (which would be redundant). Signed-off-by: Joe Stringer <joe@wand.net.nz> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-10-19 02:37:37 +09:00
dnl Write-Metadata with mask.
# actions=write_metadata:0xfedcba9876543210/0xff00ff00ff00ff00
0002 0018 00000000 fedcba9876543210 ff00ff00ff00ff00
ofp-actions: Add decoding and encoding OF1.1 instructions and actions. So far, only the Apply-Actions instruction is supported, and only actions that have identical semantics to OpenFlow 1.0 actions. Co-authored-by: Simon Horman <horms@verge.net.au> Co-authored-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-03 22:14:29 -07:00
dnl Write-Metadata too short.
ovs-ofctl: Generalize action and instruction test commands. Until now, there were four of these commands: parse-ofp10-actions, parse-ofp10-instructions, parse-ofp11-actions, parse-ofp11-instructions. This is painful to add support for new OpenFlow versions and has a ton of cut-and-paste code. This commit generalizes the code to improve on both of those points. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-07 16:03:42 -07:00
# bad OpenFlow11 instructions: OFPBIC_BAD_LEN
ofp-actions: Add decoding and encoding OF1.1 instructions and actions. So far, only the Apply-Actions instruction is supported, and only actions that have identical semantics to OpenFlow 1.0 actions. Co-authored-by: Simon Horman <horms@verge.net.au> Co-authored-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-03 22:14:29 -07:00
0002 0010 00000000 fedcba9876543210
dnl Write-Metadata too long.
ovs-ofctl: Generalize action and instruction test commands. Until now, there were four of these commands: parse-ofp10-actions, parse-ofp10-instructions, parse-ofp11-actions, parse-ofp11-instructions. This is painful to add support for new OpenFlow versions and has a ton of cut-and-paste code. This commit generalizes the code to improve on both of those points. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-07 16:03:42 -07:00
# bad OpenFlow11 instructions: OFPBIC_BAD_LEN
ofp-actions: Add decoding and encoding OF1.1 instructions and actions. So far, only the Apply-Actions instruction is supported, and only actions that have identical semantics to OpenFlow 1.0 actions. Co-authored-by: Simon Horman <horms@verge.net.au> Co-authored-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-03 22:14:29 -07:00
0002 0020 00000000 fedcba9876543210 ffffffffffffffff 0000000000000000
ofp-actions: Implement writing to metadata field In OpenFlow 1.1, we add support for OFPIT_WRITE_METADATA. This allows us to write to the metadata field. Internally it is represented using ofpact_metadata. We introduce NXAST_WRITE_METADATA to handle writing to the metadata field in OpenFlow 1.0+. This structure reflects OFPIT_WRITE_METADATA. When writing out the structure to OpenFlow 1.1, it uses the OFPIT_WRITE_METADATA instruction only, and not the new NXAST action (which would be redundant). Signed-off-by: Joe Stringer <joe@wand.net.nz> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-10-19 02:37:37 +09:00
dnl Write-Metadata duplicated.
ovs-ofctl: Generalize action and instruction test commands. Until now, there were four of these commands: parse-ofp10-actions, parse-ofp10-instructions, parse-ofp11-actions, parse-ofp11-instructions. This is painful to add support for new OpenFlow versions and has a ton of cut-and-paste code. This commit generalizes the code to improve on both of those points. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-07 16:03:42 -07:00
# bad OpenFlow11 instructions: OFPBIC_DUP_INST
ofp-actions: Implement writing to metadata field In OpenFlow 1.1, we add support for OFPIT_WRITE_METADATA. This allows us to write to the metadata field. Internally it is represented using ofpact_metadata. We introduce NXAST_WRITE_METADATA to handle writing to the metadata field in OpenFlow 1.0+. This structure reflects OFPIT_WRITE_METADATA. When writing out the structure to OpenFlow 1.1, it uses the OFPIT_WRITE_METADATA instruction only, and not the new NXAST action (which would be redundant). Signed-off-by: Joe Stringer <joe@wand.net.nz> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-10-19 02:37:37 +09:00
0002 0018 00000000 fedcba9876543210 ff00ff00ff00ff00 0002 0018 00000000 fedcba9876543210 ff00ff00ff00ff00
ofp-actions: Fix the check for instruction ordering and duplication. Open vSwitch enforces that, when instructions appear as Nicira extensions in OpenFlow 1.0 action lists, the instructions appear in the order that an OpenFlow 1.1+ switch would execute them and that no duplicates appear. But the check wasn't general enough, because it had been implemented when only one instruction was implemented and never later generalized. This commit fixes the problem. One of the tests was actually testing for the wrong behavior that the check implemented, so this commit corrects that test. It also updates another test with updated log messages. Reported-by: Jing Ai <ai_jing2000@hotmail.com> Tested-by: Jing Ai <ai_jing2000@hotmail.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-01-03 09:02:52 -08:00
dnl Write-Metadata in wrong position (OpenFlow 1.1+ disregards the order
dnl and OVS reorders it to the canonical order)
# actions=write_metadata:0xfedcba9876543210,goto_table:1
# 1: 01 -> 02
# 3: 08 -> 18
# 4: 01 -> 00
# 8: 00 -> fe
# 9: 02 -> dc
# 10: 00 -> ba
# 11: 18 -> 98
# 12: 00 -> 76
# 13: 00 -> 54
# 14: 00 -> 32
# 15: 00 -> 10
# 16: fe -> ff
# 17: dc -> ff
# 18: ba -> ff
# 19: 98 -> ff
# 20: 76 -> ff
# 21: 54 -> ff
# 22: 32 -> ff
# 23: 10 -> ff
# 24: ff -> 00
# 25: ff -> 01
# 26: ff -> 00
# 27: ff -> 08
# 28: ff -> 01
# 29: ff -> 00
# 30: ff -> 00
# 31: ff -> 00
ofp-actions: Implement writing to metadata field In OpenFlow 1.1, we add support for OFPIT_WRITE_METADATA. This allows us to write to the metadata field. Internally it is represented using ofpact_metadata. We introduce NXAST_WRITE_METADATA to handle writing to the metadata field in OpenFlow 1.0+. This structure reflects OFPIT_WRITE_METADATA. When writing out the structure to OpenFlow 1.1, it uses the OFPIT_WRITE_METADATA instruction only, and not the new NXAST action (which would be redundant). Signed-off-by: Joe Stringer <joe@wand.net.nz> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-10-19 02:37:37 +09:00
0001 0008 01 000000 0002 0018 00000000 fedcba9876543210 ffffffffffffffff
Add support for write-actions Implementation note: All actions which modify a field are added to the action set at the point where "set" actions should be added. In general modifying a field many times is the same as only modifying it the last time so the implementation simply adds all set actions to the action set in the order they are specified. However, this breaks down if two actions modify different portions of the same field. Some examples. 1. load acting a subfield 2. mod_vlan_vid, mod_vlan_pcp If this is considered to be a problem one possible solution would be to either disallow all set actions other than set_field in write_actions. Another possible solution is prohibit problematic the actions listed above in write actions. Signed-off-by: Simon Horman <horms@verge.net.au> [blp@nicira.com simplified and edited the code] Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-10-11 13:23:29 +09:00
dnl empty Write-Actions non-zero padding
# actions=write_actions(drop)
# 0: 00 -> (none)
# 1: 03 -> (none)
# 2: 00 -> (none)
# 3: 08 -> (none)
# 4: 00 -> (none)
# 5: 00 -> (none)
# 6: 00 -> (none)
# 7: 01 -> (none)
0003 0008 00000001
dnl Check that an empty Write-Actions instruction gets dropped.
# actions=write_actions(drop)
# 0: 00 -> (none)
# 1: 03 -> (none)
# 2: 00 -> (none)
# 3: 08 -> (none)
# 4: 00 -> (none)
# 5: 00 -> (none)
# 6: 00 -> (none)
# 7: 00 -> (none)
0003 0008 00000000
ofp-actions: Add decoding and encoding OF1.1 instructions and actions. So far, only the Apply-Actions instruction is supported, and only actions that have identical semantics to OpenFlow 1.0 actions. Co-authored-by: Simon Horman <horms@verge.net.au> Co-authored-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-03 22:14:29 -07:00
instruction/clear-actions: string parser/formater, of packet decoder/encoder Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-10-05 15:56:57 +09:00
dnl Clear-Actions too-long
ovs-ofctl: Generalize action and instruction test commands. Until now, there were four of these commands: parse-ofp10-actions, parse-ofp10-instructions, parse-ofp11-actions, parse-ofp11-instructions. This is painful to add support for new OpenFlow versions and has a ton of cut-and-paste code. This commit generalizes the code to improve on both of those points. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-07 16:03:42 -07:00
# bad OpenFlow11 instructions: OFPBIC_BAD_LEN
instruction/clear-actions: string parser/formater, of packet decoder/encoder Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-10-05 15:56:57 +09:00
0005 0010 00000000 0000000000000000
dnl Clear-Actions non-zero padding
# actions=clear_actions
# 7: 01 -> 00
0005 0008 00000001
dnl Clear-Actions non-zero padding
# actions=clear_actions
# 4: 01 -> 00
ofp-actions: Add decoding and encoding OF1.1 instructions and actions. So far, only the Apply-Actions instruction is supported, and only actions that have identical semantics to OpenFlow 1.0 actions. Co-authored-by: Simon Horman <horms@verge.net.au> Co-authored-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-03 22:14:29 -07:00
0005 0008 01 000000
instruction/clear-actions: string parser/formater, of packet decoder/encoder Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-10-05 15:56:57 +09:00
dnl Clear-Actions
# actions=clear_actions
0005 0008 00000000
ofp-actions: Add decoding and encoding OF1.1 instructions and actions. So far, only the Apply-Actions instruction is supported, and only actions that have identical semantics to OpenFlow 1.0 actions. Co-authored-by: Simon Horman <horms@verge.net.au> Co-authored-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-03 22:14:29 -07:00
dnl Experimenter actions not supported yet.
ovs-ofctl: Generalize action and instruction test commands. Until now, there were four of these commands: parse-ofp10-actions, parse-ofp10-instructions, parse-ofp11-actions, parse-ofp11-instructions. This is painful to add support for new OpenFlow versions and has a ton of cut-and-paste code. This commit generalizes the code to improve on both of those points. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-07 16:03:42 -07:00
# bad OpenFlow11 instructions: OFPBIC_BAD_EXPERIMENTER
ofp-actions: Add decoding and encoding OF1.1 instructions and actions. So far, only the Apply-Actions instruction is supported, and only actions that have identical semantics to OpenFlow 1.0 actions. Co-authored-by: Simon Horman <horms@verge.net.au> Co-authored-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-03 22:14:29 -07:00
ffff 0008 01 000000
dnl Bad instruction number (0 not assigned).
ovs-ofctl: Generalize action and instruction test commands. Until now, there were four of these commands: parse-ofp10-actions, parse-ofp10-instructions, parse-ofp11-actions, parse-ofp11-instructions. This is painful to add support for new OpenFlow versions and has a ton of cut-and-paste code. This commit generalizes the code to improve on both of those points. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-07 16:03:42 -07:00
# bad OpenFlow11 instructions: OFPBIC_UNKNOWN_INST
ofp-actions: Add decoding and encoding OF1.1 instructions and actions. So far, only the Apply-Actions instruction is supported, and only actions that have identical semantics to OpenFlow 1.0 actions. Co-authored-by: Simon Horman <horms@verge.net.au> Co-authored-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-03 22:14:29 -07:00
0000 0008 01 000000
])
sed '/^[[#&]]/d' < test-data > input.txt
sed -n 's/^# //p; /^$/p' < test-data > expout
sed -n 's/^& //p' < test-data > experr
AT_CAPTURE_FILE([input.txt])
AT_CAPTURE_FILE([expout])
AT_CAPTURE_FILE([experr])
AT_CHECK(
ovs-ofctl: Generalize action and instruction test commands. Until now, there were four of these commands: parse-ofp10-actions, parse-ofp10-instructions, parse-ofp11-actions, parse-ofp11-instructions. This is painful to add support for new OpenFlow versions and has a ton of cut-and-paste code. This commit generalizes the code to improve on both of those points. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-07 16:03:42 -07:00
[ovs-ofctl '-vPATTERN:console:%c|%p|%m' parse-instructions OpenFlow11 < input.txt],
ofp-actions: Add decoding and encoding OF1.1 instructions and actions. So far, only the Apply-Actions instruction is supported, and only actions that have identical semantics to OpenFlow 1.0 actions. Co-authored-by: Simon Horman <horms@verge.net.au> Co-authored-by: Isaku Yamahata <yamahata@valinux.co.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-03 22:14:29 -07:00
[0], [expout], [experr])
AT_CLEANUP
ofp-actions: Consider L4 actions after mpls_push as inconsistent After an mpls_push action the resulting packet is MPLS and the MPLS payload is opaque. Thus nothing can be assumed about the packets network protocol and it is inconsistent to apply L4 actions. With regards to actions that affect the packet at other layers of the protocol stack: * L3: The consistency of L3 actions should already be handled correctly by virtue of the dl_type of the flow being temporarily altered during consistency checking by both push_mpls and pop_mpls actions. * MPLS: The consistency checking of MPLS actions appear to already be handled correctly. * VLAN: At this time Open vSwitch on mpls_push an MPLS LSE is always added after any VLAN tags that follow the ethernet header. That is the tag ordering defined prior to OpenFlow1.3. As such VLAN actions should sill be equally valid before and after mpls_push and mpls_pop actions. * L2 actions are equally valid before and after mpls_push and mpls_pop actions. Acked-by: Jarno Rajahalme <jrajahalme@nicira.com> Signed-off-by: Simon Horman <horms@verge.net.au> Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-11-15 18:10:18 +09:00
nx-match: Move all knowledge of OXM/NXM here. This improves the general abstraction of OXM/NXM by eliminating direct knowledge of it from the meta-flow code and other places. Some function renaming might be called for; for example, mf_oxm_header() may not be the best name now that the function is implemented within nx-match. However, these renamings would make this commit larger and harder to review, so I'm postponing them. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: YAMAMOTO Takashi <yamamoto@valinux.co.jp>
2014-09-16 22:13:44 -07:00
dnl Our primary goal here is to verify OpenFlow 1.2-specific changes,
dnl so the list of tests is short.
AT_SETUP([OpenFlow 1.2 action translation])
AT_KEYWORDS([ofp-actions OF1.2])
AT_DATA([test-data], [dnl
# actions=LOCAL
0000 0010 fffffffe 04d2 000000000000
# bad OpenFlow12 actions: OFPBAC_BAD_SET_MASK
& ofp_actions|WARN|bad action at offset 0 (OFPBAC_BAD_SET_MASK):
& 00000000 00 19 00 18 80 00 09 0c-00 00 00 00 12 34 00 00
& 00000010 00 00 ff ff 00 00 00 00-
0019 0018 8000090c 000000001234 00000000ffff 00000000
])
sed '/^[[#&]]/d' < test-data > input.txt
sed -n 's/^# //p; /^$/p' < test-data > expout
sed -n 's/^& //p' < test-data > experr
AT_CAPTURE_FILE([input.txt])
AT_CAPTURE_FILE([expout])
AT_CAPTURE_FILE([experr])
AT_CHECK(
[ovs-ofctl '-vPATTERN:console:%c|%p|%m' parse-actions OpenFlow12 < input.txt],
[0], [expout], [experr])
AT_CLEANUP
ofp-actions: Support "copy_field" ONF extension to OpenFlow 1.3. ONF-JIRA: EXT-320 Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Thomas Graf <tgraf@noironetworks.com>
2014-11-24 14:29:06 -08:00
dnl Our primary goal here is to verify OpenFlow 1.3-specific changes,
dnl so the list of tests is short.
AT_SETUP([OpenFlow 1.3 action translation])
AT_KEYWORDS([ofp-actions OF1.3])
AT_DATA([test-data], [dnl
# actions=LOCAL
0000 0010 fffffffe 04d2 000000000000
dnl Check the Nicira extension form of "move".
# actions=move:NXM_OF_IN_PORT[]->NXM_OF_VLAN_TCI[]
ffff 0018 00002320 0006 0010 0000 0000 00000002 00000802
dnl Check the ONF extension form of "copy_field".
# actions=move:NXM_OF_IN_PORT[]->NXM_OF_VLAN_TCI[]
ffff 0020 4f4e4600 0c80 0000 0010 0000 0000 0000 00000002 00000802 00000000
])
sed '/^[[#&]]/d' < test-data > input.txt
sed -n 's/^# //p; /^$/p' < test-data > expout
sed -n 's/^& //p' < test-data > experr
AT_CAPTURE_FILE([input.txt])
AT_CAPTURE_FILE([expout])
AT_CAPTURE_FILE([experr])
AT_CHECK(
[ovs-ofctl '-vPATTERN:console:%c|%p|%m' parse-actions OpenFlow13 < input.txt],
[0], [expout], [experr])
AT_CLEANUP
ofp-actions: Use specific error code for oxm_hasmask=1 in Set-Field. Based on the OpenFlow 1.5 draft. ONF-JIRA: EXT-425 Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-11 14:13:53 -07:00
dnl Our primary goal here is to verify that OpenFlow 1.5-specific changes,
dnl so the list of tests is short.
ofp-actions: Add support for OpenFlow 1.5 (draft) Copy-Field action. ONF-JIRA: EXT-320 Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-07 16:18:51 -07:00
AT_SETUP([OpenFlow 1.5 action translation])
AT_KEYWORDS([ofp-actions OF1.5])
AT_DATA([test-data], [dnl
# actions=LOCAL
0000 0010 fffffffe 04d2 000000000000
# actions=move:NXM_OF_IN_PORT[]->NXM_OF_VLAN_TCI[]
ofp-actions: Update "copy_field" to latest OF1.5 draft. Since my original prototype, the oxm_id_len field was removed and replaced by 2 bytes of padding. ONF-JIRA: EXT-320 Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Thomas Graf <tgraf@noironetworks.com>
2014-11-24 12:25:56 -08:00
001c 0018 0010 0000 0000 0000 00000002 00000802 00000000
ofp-actions: Add support for OpenFlow 1.5 (draft) Copy-Field action. ONF-JIRA: EXT-320 Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-07 16:18:51 -07:00
ofp-actions: Support OF1.5 (draft) masked Set-Field, merge with reg_load. OpenFlow 1.5 (draft) extends the OFPAT_SET_FIELD action originally introduced in OpenFlow 1.2 so that it can set not just entire fields but any subset of bits within a field as well. This commit adds support for that feature when OpenFlow 1.5 is used. With this feature, OFPAT_SET_FIELD becomes a superset of NXAST_REG_LOAD. Thus, this commit merges the implementations of the two actions into a single ofpact_set_field. ONF-JIRA: EXT-314 Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: YAMAMOTO Takashi <yamamoto@valinux.co.jp>
2014-10-07 16:49:50 -07:00
# actions=set_field:00:00:00:00:12:34/00:00:00:00:ff:ff->eth_src
nx-match: Move all knowledge of OXM/NXM here. This improves the general abstraction of OXM/NXM by eliminating direct knowledge of it from the meta-flow code and other places. Some function renaming might be called for; for example, mf_oxm_header() may not be the best name now that the function is implemented within nx-match. However, these renamings would make this commit larger and harder to review, so I'm postponing them. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: YAMAMOTO Takashi <yamamoto@valinux.co.jp>
2014-09-16 22:13:44 -07:00
0019 0018 8000090c 000000001234 00000000ffff 00000000
ofp-actions: Use specific error code for oxm_hasmask=1 in Set-Field. Based on the OpenFlow 1.5 draft. ONF-JIRA: EXT-425 Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-11 14:13:53 -07:00
ofp-actions: Add support for OpenFlow 1.5 (draft) Copy-Field action. ONF-JIRA: EXT-320 Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-07 16:18:51 -07:00
])
sed '/^[[#&]]/d' < test-data > input.txt
sed -n 's/^# //p; /^$/p' < test-data > expout
sed -n 's/^& //p' < test-data > experr
AT_CAPTURE_FILE([input.txt])
AT_CAPTURE_FILE([expout])
AT_CAPTURE_FILE([experr])
AT_CHECK(
[ovs-ofctl '-vPATTERN:console:%c|%p|%m' parse-actions OpenFlow15 < input.txt],
[0], [expout], [experr])
AT_CLEANUP
ofp-actions: Consider L4 actions after mpls_push as inconsistent After an mpls_push action the resulting packet is MPLS and the MPLS payload is opaque. Thus nothing can be assumed about the packets network protocol and it is inconsistent to apply L4 actions. With regards to actions that affect the packet at other layers of the protocol stack: * L3: The consistency of L3 actions should already be handled correctly by virtue of the dl_type of the flow being temporarily altered during consistency checking by both push_mpls and pop_mpls actions. * MPLS: The consistency checking of MPLS actions appear to already be handled correctly. * VLAN: At this time Open vSwitch on mpls_push an MPLS LSE is always added after any VLAN tags that follow the ethernet header. That is the tag ordering defined prior to OpenFlow1.3. As such VLAN actions should sill be equally valid before and after mpls_push and mpls_pop actions. * L2 actions are equally valid before and after mpls_push and mpls_pop actions. Acked-by: Jarno Rajahalme <jrajahalme@nicira.com> Signed-off-by: Simon Horman <horms@verge.net.au> Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-11-15 18:10:18 +09:00
AT_SETUP([ofp-actions - inconsistent MPLS actions])
OVS_VSWITCHD_START
dnl OK: Use fin_timeout action on TCP flow
AT_CHECK([ovs-ofctl -O OpenFlow11 -vwarn add-flow br0 'tcp actions=fin_timeout(idle_timeout=1)'])
dnl Bad: Use fin_timeout action on TCP flow that has been converted to MPLS
AT_CHECK([ovs-ofctl -O OpenFlow11 -vwarn add-flow br0 'tcp actions=push_mpls:0x8847,fin_timeout(idle_timeout=1)'],
[1], [], [dnl
ofp-actions: Make ofpacts_check() report consistency for all protocols. Until now ofpacts_check() has been told either to enforce consistency or not, but that means that the caller has to know exactly what protocol is going to be in use (because some protocols require consistency to be enforced and others don't). This commit changes ofpacts_check() to just rule out protocols that require enforcement when it detects inconsistencies. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2013-11-15 14:19:57 -08:00
ovs-ofctl: none of the usable flow formats (OpenFlow10,NXM) is among the allowed flow formats (OpenFlow11)
ofp-actions: Consider L4 actions after mpls_push as inconsistent After an mpls_push action the resulting packet is MPLS and the MPLS payload is opaque. Thus nothing can be assumed about the packets network protocol and it is inconsistent to apply L4 actions. With regards to actions that affect the packet at other layers of the protocol stack: * L3: The consistency of L3 actions should already be handled correctly by virtue of the dl_type of the flow being temporarily altered during consistency checking by both push_mpls and pop_mpls actions. * MPLS: The consistency checking of MPLS actions appear to already be handled correctly. * VLAN: At this time Open vSwitch on mpls_push an MPLS LSE is always added after any VLAN tags that follow the ethernet header. That is the tag ordering defined prior to OpenFlow1.3. As such VLAN actions should sill be equally valid before and after mpls_push and mpls_pop actions. * L2 actions are equally valid before and after mpls_push and mpls_pop actions. Acked-by: Jarno Rajahalme <jrajahalme@nicira.com> Signed-off-by: Simon Horman <horms@verge.net.au> Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-11-15 18:10:18 +09:00
])
OVS_VSWITCHD_STOP
AT_CLEANUP
ofp-actions: Only set defined bits when encoding "load" actions. Commit 7eb4b1f1d70345f ("ofp-actions: Support OF1.5 (draft) masked Set-Field, merge with reg_load.") introduced a bug in that a set_field action that set an entire field would be translated incorrectly to reg_load, if the field being set only occupied a portion of the bytes that it contains. For example, an MPLS label is 20 bits but has a 4-byte field, which meant that a set_field would get translated into a reg_load that wrote all 32 bits; in turn, the receiver of that reg_load would reject it because it was attempting to set invalid bits (the top 12 bits). This commit fixes the problem by omitting invalid bits when encoding a reg_load action. Reported-by: Pravin Shelar <pshelar@nicira.com> Tested-by: Pravin Shelar <pshelar@nicira.com> Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: YAMAMOTO Takashi <yamamoto@valinux.co.jp>
2014-12-04 14:31:56 -08:00
AT_SETUP([reg_load <-> set_field translation corner case])
AT_KEYWORDS([ofp-actions])
OVS_VSWITCHD_START
dnl In OpenFlow 1.3, set_field always sets all the bits in the field,
dnl but when we translate to NXAST_LOAD we need to only set the bits that
dnl actually exist (e.g. mpls_label only has 20 bits) otherwise OVS rejects
dnl the "load" action as invalid. Check that we do this correctly.
AT_CHECK([ovs-ofctl -O OpenFlow13 add-flow br0 mpls,actions=set_field:10-\>mpls_label])
AT_CHECK([ovs-ofctl -O OpenFlow10 dump-flows br0 | ofctl_strip], [0], [dnl
NXST_FLOW reply:
mpls actions=load:0xa->OXM_OF_MPLS_LABEL[[]]
])
OVS_VSWITCHD_STOP
AT_CLEANUP
Reference in New Issue Copy Permalink