2009-12-21 13:13:48 -08:00
|
|
|
|
/*
|
2015-02-20 08:44:48 -08:00
|
|
|
|
* Copyright (c) 2008, 2009, 2010, 2011, 2012, 2013, 2014, 2015 Nicira, Inc.
|
2009-12-21 13:13:48 -08:00
|
|
|
|
*
|
|
|
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
|
* you may not use this file except in compliance with the License.
|
|
|
|
|
* You may obtain a copy of the License at:
|
|
|
|
|
*
|
|
|
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
|
*
|
|
|
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
|
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
|
* See the License for the specific language governing permissions and
|
|
|
|
|
* limitations under the License.
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#include <config.h>
|
|
|
|
|
#include "stream-ssl.h"
|
|
|
|
|
#include "dhparams.h"
|
|
|
|
|
#include <ctype.h>
|
|
|
|
|
#include <errno.h>
|
|
|
|
|
#include <inttypes.h>
|
|
|
|
|
#include <string.h>
|
2011-03-30 17:25:36 +02:00
|
|
|
|
#include <sys/types.h>
|
|
|
|
|
#include <sys/socket.h>
|
2009-12-21 13:13:48 -08:00
|
|
|
|
#include <netinet/tcp.h>
|
|
|
|
|
#include <openssl/err.h>
|
2012-08-09 14:18:46 -07:00
|
|
|
|
#include <openssl/rand.h>
|
2009-12-21 13:13:48 -08:00
|
|
|
|
#include <openssl/ssl.h>
|
|
|
|
|
#include <openssl/x509v3.h>
|
|
|
|
|
#include <poll.h>
|
2014-02-06 07:57:12 -08:00
|
|
|
|
#include <fcntl.h>
|
2009-12-21 13:13:48 -08:00
|
|
|
|
#include <sys/stat.h>
|
|
|
|
|
#include <unistd.h>
|
2010-08-11 10:24:40 -07:00
|
|
|
|
#include "coverage.h"
|
2009-12-21 13:13:48 -08:00
|
|
|
|
#include "dynamic-string.h"
|
2012-08-09 14:18:46 -07:00
|
|
|
|
#include "entropy.h"
|
2009-12-21 13:13:48 -08:00
|
|
|
|
#include "ofpbuf.h"
|
|
|
|
|
#include "openflow/openflow.h"
|
|
|
|
|
#include "packets.h"
|
|
|
|
|
#include "poll-loop.h"
|
2010-08-11 10:24:40 -07:00
|
|
|
|
#include "shash.h"
|
2009-12-21 13:13:48 -08:00
|
|
|
|
#include "socket-util.h"
|
|
|
|
|
#include "util.h"
|
|
|
|
|
#include "stream-provider.h"
|
|
|
|
|
#include "stream.h"
|
2010-03-18 16:40:35 -07:00
|
|
|
|
#include "timeval.h"
|
2014-12-15 14:10:38 +01:00
|
|
|
|
#include "openvswitch/vlog.h"
|
2010-07-16 11:02:49 -07:00
|
|
|
|
|
2014-02-06 07:57:12 -08:00
|
|
|
|
#ifdef _WIN32
|
|
|
|
|
/* Ref: https://www.openssl.org/support/faq.html#PROG2
|
|
|
|
|
* Your application must link against the same version of the Win32 C-Runtime
|
|
|
|
|
* against which your openssl libraries were linked. The default version for
|
|
|
|
|
* OpenSSL is /MD - "Multithreaded DLL". If we compile Open vSwitch with
|
|
|
|
|
* something other than /MD, instead of re-compiling OpenSSL
|
|
|
|
|
* toolkit, openssl/applink.c can be #included. Also, it is important
|
|
|
|
|
* to add CRYPTO_malloc_init prior first call to OpenSSL.
|
|
|
|
|
*
|
|
|
|
|
* XXX: The behavior of the following #include when Open vSwitch is
|
|
|
|
|
* compiled with /MD is not tested. */
|
|
|
|
|
#include <openssl/applink.c>
|
|
|
|
|
#define SHUT_RDWR SD_BOTH
|
|
|
|
|
#endif
|
|
|
|
|
|
2010-10-19 14:47:01 -07:00
|
|
|
|
VLOG_DEFINE_THIS_MODULE(stream_ssl);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
|
|
|
|
|
/* Active SSL. */
|
|
|
|
|
|
|
|
|
|
enum ssl_state {
|
|
|
|
|
STATE_TCP_CONNECTING,
|
|
|
|
|
STATE_SSL_CONNECTING
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
enum session_type {
|
|
|
|
|
CLIENT,
|
|
|
|
|
SERVER
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
struct ssl_stream
|
|
|
|
|
{
|
|
|
|
|
struct stream stream;
|
|
|
|
|
enum ssl_state state;
|
|
|
|
|
enum session_type type;
|
|
|
|
|
int fd;
|
|
|
|
|
SSL *ssl;
|
|
|
|
|
struct ofpbuf *txbuf;
|
2010-06-04 16:47:55 -07:00
|
|
|
|
unsigned int session_nr;
|
2009-12-21 13:13:48 -08:00
|
|
|
|
|
|
|
|
|
/* rx_want and tx_want record the result of the last call to SSL_read()
|
|
|
|
|
* and SSL_write(), respectively:
|
|
|
|
|
*
|
|
|
|
|
* - If the call reported that data needed to be read from the file
|
|
|
|
|
* descriptor, the corresponding member is set to SSL_READING.
|
|
|
|
|
*
|
|
|
|
|
* - If the call reported that data needed to be written to the file
|
|
|
|
|
* descriptor, the corresponding member is set to SSL_WRITING.
|
|
|
|
|
*
|
|
|
|
|
* - Otherwise, the member is set to SSL_NOTHING, indicating that the
|
|
|
|
|
* call completed successfully (or with an error) and that there is no
|
|
|
|
|
* need to block.
|
|
|
|
|
*
|
|
|
|
|
* These are needed because there is no way to ask OpenSSL what a data read
|
|
|
|
|
* or write would require without giving it a buffer to receive into or
|
|
|
|
|
* data to send, respectively. (Note that the SSL_want() status is
|
|
|
|
|
* overwritten by each SSL_read() or SSL_write() call, so we can't rely on
|
|
|
|
|
* its value.)
|
|
|
|
|
*
|
|
|
|
|
* A single call to SSL_read() or SSL_write() can perform both reading
|
|
|
|
|
* and writing and thus invalidate not one of these values but actually
|
|
|
|
|
* both. Consider this situation, for example:
|
|
|
|
|
*
|
|
|
|
|
* - SSL_write() blocks on a read, so tx_want gets SSL_READING.
|
|
|
|
|
*
|
|
|
|
|
* - SSL_read() laters succeeds reading from 'fd' and clears out the
|
|
|
|
|
* whole receive buffer, so rx_want gets SSL_READING.
|
|
|
|
|
*
|
|
|
|
|
* - Client calls stream_wait(STREAM_RECV) and stream_wait(STREAM_SEND)
|
|
|
|
|
* and blocks.
|
|
|
|
|
*
|
|
|
|
|
* - Now we're stuck blocking until the peer sends us data, even though
|
|
|
|
|
* SSL_write() could now succeed, which could easily be a deadlock
|
|
|
|
|
* condition.
|
|
|
|
|
*
|
|
|
|
|
* On the other hand, we can't reset both tx_want and rx_want on every call
|
|
|
|
|
* to SSL_read() or SSL_write(), because that would produce livelock,
|
|
|
|
|
* e.g. in this situation:
|
|
|
|
|
*
|
|
|
|
|
* - SSL_write() blocks, so tx_want gets SSL_READING or SSL_WRITING.
|
|
|
|
|
*
|
|
|
|
|
* - SSL_read() blocks, so rx_want gets SSL_READING or SSL_WRITING,
|
|
|
|
|
* but tx_want gets reset to SSL_NOTHING.
|
|
|
|
|
*
|
|
|
|
|
* - Client calls stream_wait(STREAM_RECV) and stream_wait(STREAM_SEND)
|
|
|
|
|
* and blocks.
|
|
|
|
|
*
|
|
|
|
|
* - Client wakes up immediately since SSL_NOTHING in tx_want indicates
|
|
|
|
|
* that no blocking is necessary.
|
|
|
|
|
*
|
|
|
|
|
* The solution we adopt here is to set tx_want to SSL_NOTHING after
|
|
|
|
|
* calling SSL_read() only if the SSL state of the connection changed,
|
|
|
|
|
* which indicates that an SSL-level renegotiation made some progress, and
|
|
|
|
|
* similarly for rx_want and SSL_write(). This prevents both the
|
|
|
|
|
* deadlock and livelock situations above.
|
|
|
|
|
*/
|
|
|
|
|
int rx_want, tx_want;
|
2010-05-05 10:31:44 -07:00
|
|
|
|
|
2010-06-04 16:47:55 -07:00
|
|
|
|
/* A few bytes of header data in case SSL negotiation fails. */
|
2010-05-05 10:31:44 -07:00
|
|
|
|
uint8_t head[2];
|
|
|
|
|
short int n_head;
|
2009-12-21 13:13:48 -08:00
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
/* SSL context created by ssl_init(). */
|
|
|
|
|
static SSL_CTX *ctx;
|
|
|
|
|
|
2010-03-18 16:40:35 -07:00
|
|
|
|
struct ssl_config_file {
|
|
|
|
|
bool read; /* Whether the file was successfully read. */
|
|
|
|
|
char *file_name; /* Configured file name, if any. */
|
2010-03-24 13:15:41 -07:00
|
|
|
|
struct timespec mtime; /* File mtime as of last time we read it. */
|
2010-03-18 16:40:35 -07:00
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
/* SSL configuration files. */
|
|
|
|
|
static struct ssl_config_file private_key;
|
|
|
|
|
static struct ssl_config_file certificate;
|
|
|
|
|
static struct ssl_config_file ca_cert;
|
2009-12-21 13:13:48 -08:00
|
|
|
|
|
2010-03-23 17:19:36 -07:00
|
|
|
|
/* Ordinarily, the SSL client and server verify each other's certificates using
|
|
|
|
|
* a CA certificate. Setting this to false disables this behavior. (This is a
|
|
|
|
|
* security risk.) */
|
|
|
|
|
static bool verify_peer_cert = true;
|
|
|
|
|
|
2009-12-21 13:13:48 -08:00
|
|
|
|
/* Ordinarily, we require a CA certificate for the peer to be locally
|
2010-03-18 16:40:35 -07:00
|
|
|
|
* available. We can, however, bootstrap the CA certificate from the peer at
|
|
|
|
|
* the beginning of our first connection then use that certificate on all
|
|
|
|
|
* subsequent connections, saving it to a file for use in future runs also. In
|
|
|
|
|
* this case, 'bootstrap_ca_cert' is true. */
|
2009-12-21 13:13:48 -08:00
|
|
|
|
static bool bootstrap_ca_cert;
|
|
|
|
|
|
2010-06-04 16:47:55 -07:00
|
|
|
|
/* Session number. Used in debug logging messages to uniquely identify a
|
|
|
|
|
* session. */
|
|
|
|
|
static unsigned int next_session_nr;
|
|
|
|
|
|
2009-12-21 13:13:48 -08:00
|
|
|
|
/* Who knows what can trigger various SSL errors, so let's throttle them down
|
|
|
|
|
* quite a bit. */
|
|
|
|
|
static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(10, 25);
|
|
|
|
|
|
|
|
|
|
static int ssl_init(void);
|
|
|
|
|
static int do_ssl_init(void);
|
|
|
|
|
static bool ssl_wants_io(int ssl_error);
|
|
|
|
|
static void ssl_close(struct stream *);
|
|
|
|
|
static void ssl_clear_txbuf(struct ssl_stream *);
|
2011-01-28 14:39:23 -08:00
|
|
|
|
static void interpret_queued_ssl_error(const char *function);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
static int interpret_ssl_error(const char *function, int ret, int error,
|
|
|
|
|
int *want);
|
2010-02-11 10:59:47 -08:00
|
|
|
|
static DH *tmp_dh_callback(SSL *ssl, int is_export OVS_UNUSED, int keylength);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
static void log_ca_cert(const char *file_name, X509 *cert);
|
2010-03-18 16:40:35 -07:00
|
|
|
|
static void stream_ssl_set_ca_cert_file__(const char *file_name,
|
2011-05-05 10:59:50 -07:00
|
|
|
|
bool bootstrap, bool force);
|
2010-06-04 16:47:55 -07:00
|
|
|
|
static void ssl_protocol_cb(int write_p, int version, int content_type,
|
|
|
|
|
const void *, size_t, SSL *, void *sslv_);
|
2011-05-05 10:59:50 -07:00
|
|
|
|
static bool update_ssl_config(struct ssl_config_file *, const char *file_name);
|
2014-02-06 07:57:12 -08:00
|
|
|
|
static int sock_errno(void);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
|
|
|
|
|
static short int
|
|
|
|
|
want_to_poll_events(int want)
|
|
|
|
|
{
|
|
|
|
|
switch (want) {
|
|
|
|
|
case SSL_NOTHING:
|
2013-12-17 10:32:12 -08:00
|
|
|
|
OVS_NOT_REACHED();
|
2009-12-21 13:13:48 -08:00
|
|
|
|
|
|
|
|
|
case SSL_READING:
|
|
|
|
|
return POLLIN;
|
|
|
|
|
|
|
|
|
|
case SSL_WRITING:
|
|
|
|
|
return POLLOUT;
|
|
|
|
|
|
|
|
|
|
default:
|
2013-12-17 10:32:12 -08:00
|
|
|
|
OVS_NOT_REACHED();
|
2009-12-21 13:13:48 -08:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static int
|
|
|
|
|
new_ssl_stream(const char *name, int fd, enum session_type type,
|
2013-12-17 15:07:12 -08:00
|
|
|
|
enum ssl_state state, struct stream **streamp)
|
2009-12-21 13:13:48 -08:00
|
|
|
|
{
|
|
|
|
|
struct ssl_stream *sslv;
|
|
|
|
|
SSL *ssl = NULL;
|
|
|
|
|
int retval;
|
|
|
|
|
|
|
|
|
|
/* Check for all the needful configuration. */
|
|
|
|
|
retval = 0;
|
2010-03-18 16:40:35 -07:00
|
|
|
|
if (!private_key.read) {
|
2009-12-21 13:13:48 -08:00
|
|
|
|
VLOG_ERR("Private key must be configured to use SSL");
|
|
|
|
|
retval = ENOPROTOOPT;
|
|
|
|
|
}
|
2010-03-18 16:40:35 -07:00
|
|
|
|
if (!certificate.read) {
|
2009-12-21 13:13:48 -08:00
|
|
|
|
VLOG_ERR("Certificate must be configured to use SSL");
|
|
|
|
|
retval = ENOPROTOOPT;
|
|
|
|
|
}
|
2010-03-23 17:19:36 -07:00
|
|
|
|
if (!ca_cert.read && verify_peer_cert && !bootstrap_ca_cert) {
|
2009-12-21 13:13:48 -08:00
|
|
|
|
VLOG_ERR("CA certificate must be configured to use SSL");
|
|
|
|
|
retval = ENOPROTOOPT;
|
|
|
|
|
}
|
2012-08-09 10:49:57 -07:00
|
|
|
|
if (!retval && !SSL_CTX_check_private_key(ctx)) {
|
2009-12-21 13:13:48 -08:00
|
|
|
|
VLOG_ERR("Private key does not match certificate public key: %s",
|
|
|
|
|
ERR_error_string(ERR_get_error(), NULL));
|
|
|
|
|
retval = ENOPROTOOPT;
|
|
|
|
|
}
|
|
|
|
|
if (retval) {
|
|
|
|
|
goto error;
|
|
|
|
|
}
|
|
|
|
|
|
2014-06-13 14:21:36 -07:00
|
|
|
|
/* Disable Nagle.
|
|
|
|
|
* On windows platforms, this can only be called upon TCP connected.
|
|
|
|
|
*/
|
|
|
|
|
if (state == STATE_SSL_CONNECTING) {
|
2014-10-22 15:35:18 -07:00
|
|
|
|
setsockopt_tcp_nodelay(fd);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Create and configure OpenSSL stream. */
|
|
|
|
|
ssl = SSL_new(ctx);
|
|
|
|
|
if (ssl == NULL) {
|
|
|
|
|
VLOG_ERR("SSL_new: %s", ERR_error_string(ERR_get_error(), NULL));
|
|
|
|
|
retval = ENOPROTOOPT;
|
|
|
|
|
goto error;
|
|
|
|
|
}
|
|
|
|
|
if (SSL_set_fd(ssl, fd) == 0) {
|
|
|
|
|
VLOG_ERR("SSL_set_fd: %s", ERR_error_string(ERR_get_error(), NULL));
|
|
|
|
|
retval = ENOPROTOOPT;
|
|
|
|
|
goto error;
|
|
|
|
|
}
|
2010-03-23 17:19:36 -07:00
|
|
|
|
if (!verify_peer_cert || (bootstrap_ca_cert && type == CLIENT)) {
|
2009-12-21 13:13:48 -08:00
|
|
|
|
SSL_set_verify(ssl, SSL_VERIFY_NONE, NULL);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Create and return the ssl_stream. */
|
|
|
|
|
sslv = xmalloc(sizeof *sslv);
|
|
|
|
|
stream_init(&sslv->stream, &ssl_stream_class, EAGAIN, name);
|
|
|
|
|
sslv->state = state;
|
|
|
|
|
sslv->type = type;
|
|
|
|
|
sslv->fd = fd;
|
|
|
|
|
sslv->ssl = ssl;
|
|
|
|
|
sslv->txbuf = NULL;
|
|
|
|
|
sslv->rx_want = sslv->tx_want = SSL_NOTHING;
|
2010-06-04 16:47:55 -07:00
|
|
|
|
sslv->session_nr = next_session_nr++;
|
2010-05-05 10:31:44 -07:00
|
|
|
|
sslv->n_head = 0;
|
2010-06-04 16:47:55 -07:00
|
|
|
|
|
|
|
|
|
if (VLOG_IS_DBG_ENABLED()) {
|
|
|
|
|
SSL_set_msg_callback(ssl, ssl_protocol_cb);
|
|
|
|
|
SSL_set_msg_callback_arg(ssl, sslv);
|
|
|
|
|
}
|
|
|
|
|
|
2009-12-21 13:13:48 -08:00
|
|
|
|
*streamp = &sslv->stream;
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
|
|
error:
|
|
|
|
|
if (ssl) {
|
|
|
|
|
SSL_free(ssl);
|
|
|
|
|
}
|
2014-02-06 07:57:12 -08:00
|
|
|
|
closesocket(fd);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
return retval;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static struct ssl_stream *
|
|
|
|
|
ssl_stream_cast(struct stream *stream)
|
|
|
|
|
{
|
|
|
|
|
stream_assert_class(stream, &ssl_stream_class);
|
|
|
|
|
return CONTAINER_OF(stream, struct ssl_stream, stream);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static int
|
2012-03-10 15:58:10 -08:00
|
|
|
|
ssl_open(const char *name, char *suffix, struct stream **streamp, uint8_t dscp)
|
2009-12-21 13:13:48 -08:00
|
|
|
|
{
|
|
|
|
|
int error, fd;
|
|
|
|
|
|
|
|
|
|
error = ssl_init();
|
|
|
|
|
if (error) {
|
|
|
|
|
return error;
|
|
|
|
|
}
|
|
|
|
|
|
2013-12-17 15:07:12 -08:00
|
|
|
|
error = inet_open_active(SOCK_STREAM, suffix, OFP_OLD_PORT, NULL, &fd,
|
2012-03-10 15:58:10 -08:00
|
|
|
|
dscp);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
if (fd >= 0) {
|
|
|
|
|
int state = error ? STATE_TCP_CONNECTING : STATE_SSL_CONNECTING;
|
2013-12-17 15:07:12 -08:00
|
|
|
|
return new_ssl_stream(name, fd, CLIENT, state, streamp);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
} else {
|
2013-06-24 10:54:49 -07:00
|
|
|
|
VLOG_ERR("%s: connect: %s", name, ovs_strerror(error));
|
2009-12-21 13:13:48 -08:00
|
|
|
|
return error;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static int
|
|
|
|
|
do_ca_cert_bootstrap(struct stream *stream)
|
|
|
|
|
{
|
|
|
|
|
struct ssl_stream *sslv = ssl_stream_cast(stream);
|
|
|
|
|
STACK_OF(X509) *chain;
|
2010-03-18 16:40:35 -07:00
|
|
|
|
X509 *cert;
|
2009-12-21 13:13:48 -08:00
|
|
|
|
FILE *file;
|
|
|
|
|
int error;
|
|
|
|
|
int fd;
|
|
|
|
|
|
|
|
|
|
chain = SSL_get_peer_cert_chain(sslv->ssl);
|
|
|
|
|
if (!chain || !sk_X509_num(chain)) {
|
|
|
|
|
VLOG_ERR("could not bootstrap CA cert: no certificate presented by "
|
|
|
|
|
"peer");
|
|
|
|
|
return EPROTO;
|
|
|
|
|
}
|
2010-03-18 16:40:35 -07:00
|
|
|
|
cert = sk_X509_value(chain, sk_X509_num(chain) - 1);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
|
2010-03-18 16:40:35 -07:00
|
|
|
|
/* Check that 'cert' is self-signed. Otherwise it is not a CA
|
2009-12-21 13:13:48 -08:00
|
|
|
|
* certificate and we should not attempt to use it as one. */
|
2010-03-18 16:40:35 -07:00
|
|
|
|
error = X509_check_issued(cert, cert);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
if (error) {
|
|
|
|
|
VLOG_ERR("could not bootstrap CA cert: obtained certificate is "
|
|
|
|
|
"not self-signed (%s)",
|
|
|
|
|
X509_verify_cert_error_string(error));
|
|
|
|
|
if (sk_X509_num(chain) < 2) {
|
|
|
|
|
VLOG_ERR("only one certificate was received, so probably the peer "
|
|
|
|
|
"is not configured to send its CA certificate");
|
|
|
|
|
}
|
|
|
|
|
return EPROTO;
|
|
|
|
|
}
|
|
|
|
|
|
2010-03-18 16:40:35 -07:00
|
|
|
|
fd = open(ca_cert.file_name, O_CREAT | O_EXCL | O_WRONLY, 0444);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
if (fd < 0) {
|
2010-03-18 16:08:32 -07:00
|
|
|
|
if (errno == EEXIST) {
|
2011-05-05 10:59:50 -07:00
|
|
|
|
VLOG_INFO_RL(&rl, "reading CA cert %s created by another process",
|
|
|
|
|
ca_cert.file_name);
|
|
|
|
|
stream_ssl_set_ca_cert_file__(ca_cert.file_name, true, true);
|
2010-03-18 16:08:32 -07:00
|
|
|
|
return EPROTO;
|
|
|
|
|
} else {
|
|
|
|
|
VLOG_ERR("could not bootstrap CA cert: creating %s failed: %s",
|
2013-06-24 10:54:49 -07:00
|
|
|
|
ca_cert.file_name, ovs_strerror(errno));
|
2010-03-18 16:08:32 -07:00
|
|
|
|
return errno;
|
|
|
|
|
}
|
2009-12-21 13:13:48 -08:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
file = fdopen(fd, "w");
|
|
|
|
|
if (!file) {
|
2010-09-02 10:09:09 -07:00
|
|
|
|
error = errno;
|
2009-12-21 13:13:48 -08:00
|
|
|
|
VLOG_ERR("could not bootstrap CA cert: fdopen failed: %s",
|
2013-06-24 10:54:49 -07:00
|
|
|
|
ovs_strerror(error));
|
2010-03-18 16:40:35 -07:00
|
|
|
|
unlink(ca_cert.file_name);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
return error;
|
|
|
|
|
}
|
|
|
|
|
|
2010-03-18 16:40:35 -07:00
|
|
|
|
if (!PEM_write_X509(file, cert)) {
|
2009-12-21 13:13:48 -08:00
|
|
|
|
VLOG_ERR("could not bootstrap CA cert: PEM_write_X509 to %s failed: "
|
2010-03-18 16:40:35 -07:00
|
|
|
|
"%s", ca_cert.file_name,
|
|
|
|
|
ERR_error_string(ERR_get_error(), NULL));
|
2009-12-21 13:13:48 -08:00
|
|
|
|
fclose(file);
|
2010-03-18 16:40:35 -07:00
|
|
|
|
unlink(ca_cert.file_name);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
return EIO;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (fclose(file)) {
|
2010-09-02 10:09:09 -07:00
|
|
|
|
error = errno;
|
2009-12-21 13:13:48 -08:00
|
|
|
|
VLOG_ERR("could not bootstrap CA cert: writing %s failed: %s",
|
2013-06-24 10:54:49 -07:00
|
|
|
|
ca_cert.file_name, ovs_strerror(error));
|
2010-03-18 16:40:35 -07:00
|
|
|
|
unlink(ca_cert.file_name);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
return error;
|
|
|
|
|
}
|
|
|
|
|
|
2010-03-18 16:40:35 -07:00
|
|
|
|
VLOG_INFO("successfully bootstrapped CA cert to %s", ca_cert.file_name);
|
|
|
|
|
log_ca_cert(ca_cert.file_name, cert);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
bootstrap_ca_cert = false;
|
2010-03-18 16:40:35 -07:00
|
|
|
|
ca_cert.read = true;
|
2009-12-21 13:13:48 -08:00
|
|
|
|
|
2010-03-18 16:40:35 -07:00
|
|
|
|
/* SSL_CTX_add_client_CA makes a copy of cert's relevant data. */
|
|
|
|
|
SSL_CTX_add_client_CA(ctx, cert);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
|
|
|
|
|
/* SSL_CTX_use_certificate() takes ownership of the certificate passed in.
|
2010-03-18 16:40:35 -07:00
|
|
|
|
* 'cert' is owned by sslv->ssl, so we need to duplicate it. */
|
|
|
|
|
cert = X509_dup(cert);
|
|
|
|
|
if (!cert) {
|
2009-12-21 13:13:48 -08:00
|
|
|
|
out_of_memory();
|
|
|
|
|
}
|
2011-06-15 11:50:24 -07:00
|
|
|
|
SSL_CTX_set_cert_store(ctx, X509_STORE_new());
|
2010-03-18 16:40:35 -07:00
|
|
|
|
if (SSL_CTX_load_verify_locations(ctx, ca_cert.file_name, NULL) != 1) {
|
2009-12-21 13:13:48 -08:00
|
|
|
|
VLOG_ERR("SSL_CTX_load_verify_locations: %s",
|
|
|
|
|
ERR_error_string(ERR_get_error(), NULL));
|
|
|
|
|
return EPROTO;
|
|
|
|
|
}
|
|
|
|
|
VLOG_INFO("killing successful connection to retry using CA cert");
|
|
|
|
|
return EPROTO;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static int
|
|
|
|
|
ssl_connect(struct stream *stream)
|
|
|
|
|
{
|
|
|
|
|
struct ssl_stream *sslv = ssl_stream_cast(stream);
|
|
|
|
|
int retval;
|
|
|
|
|
|
|
|
|
|
switch (sslv->state) {
|
|
|
|
|
case STATE_TCP_CONNECTING:
|
|
|
|
|
retval = check_connection_completion(sslv->fd);
|
|
|
|
|
if (retval) {
|
|
|
|
|
return retval;
|
|
|
|
|
}
|
|
|
|
|
sslv->state = STATE_SSL_CONNECTING;
|
2014-10-22 15:35:18 -07:00
|
|
|
|
setsockopt_tcp_nodelay(sslv->fd);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
/* Fall through. */
|
|
|
|
|
|
|
|
|
|
case STATE_SSL_CONNECTING:
|
2010-05-05 10:31:44 -07:00
|
|
|
|
/* Capture the first few bytes of received data so that we can guess
|
2013-06-04 17:35:36 -05:00
|
|
|
|
* what kind of funny data we've been sent if SSL negotiation fails. */
|
2010-05-05 10:31:44 -07:00
|
|
|
|
if (sslv->n_head <= 0) {
|
|
|
|
|
sslv->n_head = recv(sslv->fd, sslv->head, sizeof sslv->head,
|
|
|
|
|
MSG_PEEK);
|
|
|
|
|
}
|
|
|
|
|
|
2009-12-21 13:13:48 -08:00
|
|
|
|
retval = (sslv->type == CLIENT
|
|
|
|
|
? SSL_connect(sslv->ssl) : SSL_accept(sslv->ssl));
|
|
|
|
|
if (retval != 1) {
|
|
|
|
|
int error = SSL_get_error(sslv->ssl, retval);
|
|
|
|
|
if (retval < 0 && ssl_wants_io(error)) {
|
|
|
|
|
return EAGAIN;
|
|
|
|
|
} else {
|
|
|
|
|
int unused;
|
2010-08-11 10:24:40 -07:00
|
|
|
|
|
2009-12-21 13:13:48 -08:00
|
|
|
|
interpret_ssl_error((sslv->type == CLIENT ? "SSL_connect"
|
|
|
|
|
: "SSL_accept"), retval, error, &unused);
|
|
|
|
|
shutdown(sslv->fd, SHUT_RDWR);
|
2010-05-05 10:31:44 -07:00
|
|
|
|
stream_report_content(sslv->head, sslv->n_head, STREAM_SSL,
|
|
|
|
|
THIS_MODULE, stream_get_name(stream));
|
2009-12-21 13:13:48 -08:00
|
|
|
|
return EPROTO;
|
|
|
|
|
}
|
|
|
|
|
} else if (bootstrap_ca_cert) {
|
|
|
|
|
return do_ca_cert_bootstrap(stream);
|
2010-03-23 17:19:36 -07:00
|
|
|
|
} else if (verify_peer_cert
|
|
|
|
|
&& ((SSL_get_verify_mode(sslv->ssl)
|
|
|
|
|
& (SSL_VERIFY_NONE | SSL_VERIFY_PEER))
|
|
|
|
|
!= SSL_VERIFY_PEER)) {
|
2009-12-21 13:13:48 -08:00
|
|
|
|
/* Two or more SSL connections completed at the same time while we
|
|
|
|
|
* were in bootstrap mode. Only one of these can finish the
|
|
|
|
|
* bootstrap successfully. The other one(s) must be rejected
|
|
|
|
|
* because they were not verified against the bootstrapped CA
|
|
|
|
|
* certificate. (Alternatively we could verify them against the CA
|
|
|
|
|
* certificate, but that's more trouble than it's worth. These
|
|
|
|
|
* connections will succeed the next time they retry, assuming that
|
|
|
|
|
* they have a certificate against the correct CA.) */
|
2012-08-13 10:54:31 -07:00
|
|
|
|
VLOG_INFO("rejecting SSL connection during bootstrap race window");
|
2009-12-21 13:13:48 -08:00
|
|
|
|
return EPROTO;
|
|
|
|
|
} else {
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2013-12-17 10:32:12 -08:00
|
|
|
|
OVS_NOT_REACHED();
|
2009-12-21 13:13:48 -08:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
ssl_close(struct stream *stream)
|
|
|
|
|
{
|
|
|
|
|
struct ssl_stream *sslv = ssl_stream_cast(stream);
|
|
|
|
|
ssl_clear_txbuf(sslv);
|
2010-01-07 13:57:53 -08:00
|
|
|
|
|
|
|
|
|
/* Attempt clean shutdown of the SSL connection. This will work most of
|
|
|
|
|
* the time, as long as the kernel send buffer has some free space and the
|
|
|
|
|
* SSL connection isn't renegotiating, etc. That has to be good enough,
|
|
|
|
|
* since we don't have any way to continue the close operation in the
|
|
|
|
|
* background. */
|
|
|
|
|
SSL_shutdown(sslv->ssl);
|
|
|
|
|
|
stream-ssl: Flush OpenSSL error queue after calling SSL_shutdown().
The OpenSSL manpage for SSL_get_error() says this:
In addition to ssl and ret, SSL_get_error() inspects the current
thread's OpenSSL error queue. Thus, SSL_get_error() must be used in
the same thread that performed the TLS/SSL I/O operation, and no other
OpenSSL function calls should appear in between. The current thread's
error queue must be empty before the TLS/SSL I/O operation is
attempted, or SSL_get_error() will not work reliably.
We weren't taking this advice literally enough, which meant that this
would happen:
1. Call SSL_shutdown() on one connection.
2. Call SSL_read() on another connection, returning 0 bytes. (This is
normal. It just means that no more data has arrived yet.)
3. Call SSL_get_error() for that second connection to check whether
the 0-byte return value was a real error. (This should return
SSL_ERROR_WANT_READ to indicate that more data is needed.)
4. Actually get some other error indicating that the SSL_shutdown()
call returned an error.
This commit fixes the problem by flushing the OpenSSL error queue after
calling SSL_shutdown().
Without this commit, starting an ovsdb-server with two active SSL remotes,
running two ovsdb-clients listening for connections from the ovsdb-server
remotes, then killing one of the ovsdb-clients (with e.g. Control+C), will
cause ovsdb-server to drop the other ovsdb-client connnection the next time
that SSL_read() is called on it. With this commit, this scenario works
correctly (e.g. ovsdb-server keeps the remaining connection up).
CC: Jeremy Stribling <strib@nicira.com>
2010-05-13 16:08:14 -07:00
|
|
|
|
/* SSL_shutdown() might have signaled an error, in which case we need to
|
|
|
|
|
* flush it out of the OpenSSL error queue or the next OpenSSL operation
|
|
|
|
|
* will falsely signal an error. */
|
|
|
|
|
ERR_clear_error();
|
|
|
|
|
|
2009-12-21 13:13:48 -08:00
|
|
|
|
SSL_free(sslv->ssl);
|
2014-02-06 07:57:12 -08:00
|
|
|
|
closesocket(sslv->fd);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
free(sslv);
|
|
|
|
|
}
|
|
|
|
|
|
2011-01-28 14:39:23 -08:00
|
|
|
|
static void
|
|
|
|
|
interpret_queued_ssl_error(const char *function)
|
|
|
|
|
{
|
|
|
|
|
int queued_error = ERR_get_error();
|
|
|
|
|
if (queued_error != 0) {
|
|
|
|
|
VLOG_WARN_RL(&rl, "%s: %s",
|
|
|
|
|
function, ERR_error_string(queued_error, NULL));
|
|
|
|
|
} else {
|
|
|
|
|
VLOG_ERR_RL(&rl, "%s: SSL_ERROR_SSL without queued error", function);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2009-12-21 13:13:48 -08:00
|
|
|
|
static int
|
|
|
|
|
interpret_ssl_error(const char *function, int ret, int error,
|
|
|
|
|
int *want)
|
|
|
|
|
{
|
|
|
|
|
*want = SSL_NOTHING;
|
|
|
|
|
|
|
|
|
|
switch (error) {
|
|
|
|
|
case SSL_ERROR_NONE:
|
|
|
|
|
VLOG_ERR_RL(&rl, "%s: unexpected SSL_ERROR_NONE", function);
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case SSL_ERROR_ZERO_RETURN:
|
|
|
|
|
VLOG_ERR_RL(&rl, "%s: unexpected SSL_ERROR_ZERO_RETURN", function);
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case SSL_ERROR_WANT_READ:
|
|
|
|
|
*want = SSL_READING;
|
|
|
|
|
return EAGAIN;
|
|
|
|
|
|
|
|
|
|
case SSL_ERROR_WANT_WRITE:
|
|
|
|
|
*want = SSL_WRITING;
|
|
|
|
|
return EAGAIN;
|
|
|
|
|
|
|
|
|
|
case SSL_ERROR_WANT_CONNECT:
|
|
|
|
|
VLOG_ERR_RL(&rl, "%s: unexpected SSL_ERROR_WANT_CONNECT", function);
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case SSL_ERROR_WANT_ACCEPT:
|
|
|
|
|
VLOG_ERR_RL(&rl, "%s: unexpected SSL_ERROR_WANT_ACCEPT", function);
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case SSL_ERROR_WANT_X509_LOOKUP:
|
|
|
|
|
VLOG_ERR_RL(&rl, "%s: unexpected SSL_ERROR_WANT_X509_LOOKUP",
|
|
|
|
|
function);
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case SSL_ERROR_SYSCALL: {
|
|
|
|
|
int queued_error = ERR_get_error();
|
|
|
|
|
if (queued_error == 0) {
|
|
|
|
|
if (ret < 0) {
|
|
|
|
|
int status = errno;
|
|
|
|
|
VLOG_WARN_RL(&rl, "%s: system error (%s)",
|
2013-06-24 10:54:49 -07:00
|
|
|
|
function, ovs_strerror(status));
|
2009-12-21 13:13:48 -08:00
|
|
|
|
return status;
|
|
|
|
|
} else {
|
|
|
|
|
VLOG_WARN_RL(&rl, "%s: unexpected SSL connection close",
|
|
|
|
|
function);
|
|
|
|
|
return EPROTO;
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
VLOG_WARN_RL(&rl, "%s: %s",
|
|
|
|
|
function, ERR_error_string(queued_error, NULL));
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2011-01-28 14:39:23 -08:00
|
|
|
|
case SSL_ERROR_SSL:
|
|
|
|
|
interpret_queued_ssl_error(function);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
default:
|
|
|
|
|
VLOG_ERR_RL(&rl, "%s: bad SSL error code %d", function, error);
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
return EIO;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static ssize_t
|
|
|
|
|
ssl_recv(struct stream *stream, void *buffer, size_t n)
|
|
|
|
|
{
|
|
|
|
|
struct ssl_stream *sslv = ssl_stream_cast(stream);
|
|
|
|
|
int old_state;
|
|
|
|
|
ssize_t ret;
|
|
|
|
|
|
|
|
|
|
/* Behavior of zero-byte SSL_read is poorly defined. */
|
2012-11-06 13:14:55 -08:00
|
|
|
|
ovs_assert(n > 0);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
|
|
|
|
|
old_state = SSL_get_state(sslv->ssl);
|
|
|
|
|
ret = SSL_read(sslv->ssl, buffer, n);
|
|
|
|
|
if (old_state != SSL_get_state(sslv->ssl)) {
|
|
|
|
|
sslv->tx_want = SSL_NOTHING;
|
|
|
|
|
}
|
|
|
|
|
sslv->rx_want = SSL_NOTHING;
|
|
|
|
|
|
|
|
|
|
if (ret > 0) {
|
|
|
|
|
return ret;
|
|
|
|
|
} else {
|
|
|
|
|
int error = SSL_get_error(sslv->ssl, ret);
|
|
|
|
|
if (error == SSL_ERROR_ZERO_RETURN) {
|
|
|
|
|
return 0;
|
|
|
|
|
} else {
|
2010-01-07 13:58:49 -08:00
|
|
|
|
return -interpret_ssl_error("SSL_read", ret, error,
|
|
|
|
|
&sslv->rx_want);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
ssl_clear_txbuf(struct ssl_stream *sslv)
|
|
|
|
|
{
|
|
|
|
|
ofpbuf_delete(sslv->txbuf);
|
|
|
|
|
sslv->txbuf = NULL;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static int
|
|
|
|
|
ssl_do_tx(struct stream *stream)
|
|
|
|
|
{
|
|
|
|
|
struct ssl_stream *sslv = ssl_stream_cast(stream);
|
|
|
|
|
|
|
|
|
|
for (;;) {
|
|
|
|
|
int old_state = SSL_get_state(sslv->ssl);
|
2015-03-03 15:54:58 -08:00
|
|
|
|
int ret = SSL_write(sslv->ssl, sslv->txbuf->data, sslv->txbuf->size);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
if (old_state != SSL_get_state(sslv->ssl)) {
|
|
|
|
|
sslv->rx_want = SSL_NOTHING;
|
|
|
|
|
}
|
|
|
|
|
sslv->tx_want = SSL_NOTHING;
|
|
|
|
|
if (ret > 0) {
|
|
|
|
|
ofpbuf_pull(sslv->txbuf, ret);
|
2015-03-03 15:54:58 -08:00
|
|
|
|
if (sslv->txbuf->size == 0) {
|
2009-12-21 13:13:48 -08:00
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
int ssl_error = SSL_get_error(sslv->ssl, ret);
|
|
|
|
|
if (ssl_error == SSL_ERROR_ZERO_RETURN) {
|
|
|
|
|
VLOG_WARN_RL(&rl, "SSL_write: connection closed");
|
|
|
|
|
return EPIPE;
|
|
|
|
|
} else {
|
|
|
|
|
return interpret_ssl_error("SSL_write", ret, ssl_error,
|
|
|
|
|
&sslv->tx_want);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static ssize_t
|
|
|
|
|
ssl_send(struct stream *stream, const void *buffer, size_t n)
|
|
|
|
|
{
|
|
|
|
|
struct ssl_stream *sslv = ssl_stream_cast(stream);
|
|
|
|
|
|
|
|
|
|
if (sslv->txbuf) {
|
2010-01-07 13:58:49 -08:00
|
|
|
|
return -EAGAIN;
|
2009-12-21 13:13:48 -08:00
|
|
|
|
} else {
|
|
|
|
|
int error;
|
|
|
|
|
|
|
|
|
|
sslv->txbuf = ofpbuf_clone_data(buffer, n);
|
|
|
|
|
error = ssl_do_tx(stream);
|
|
|
|
|
switch (error) {
|
|
|
|
|
case 0:
|
|
|
|
|
ssl_clear_txbuf(sslv);
|
2010-01-07 13:58:49 -08:00
|
|
|
|
return n;
|
2009-12-21 13:13:48 -08:00
|
|
|
|
case EAGAIN:
|
2010-01-07 13:58:49 -08:00
|
|
|
|
return n;
|
2009-12-21 13:13:48 -08:00
|
|
|
|
default:
|
|
|
|
|
sslv->txbuf = NULL;
|
2010-01-07 13:58:49 -08:00
|
|
|
|
return -error;
|
2009-12-21 13:13:48 -08:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
ssl_run(struct stream *stream)
|
|
|
|
|
{
|
|
|
|
|
struct ssl_stream *sslv = ssl_stream_cast(stream);
|
|
|
|
|
|
|
|
|
|
if (sslv->txbuf && ssl_do_tx(stream) != EAGAIN) {
|
|
|
|
|
ssl_clear_txbuf(sslv);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
ssl_run_wait(struct stream *stream)
|
|
|
|
|
{
|
|
|
|
|
struct ssl_stream *sslv = ssl_stream_cast(stream);
|
|
|
|
|
|
|
|
|
|
if (sslv->tx_want != SSL_NOTHING) {
|
poll-loop: Create Windows event handles for sockets automatically.
We currently have a poll_fd_wait_event(fd, wevent, events) function that
is used at places common to Windows and Linux where we have to wait on
sockets. On Linux, 'wevent' is always set as zero. On Windows, for sockets,
when we send both 'fd' and 'wevent', we associate them with each other for
'events' and then wait on 'wevent'. Also on Windows, when we only send 'wevent'
to this function, we would simply wait for all events for that 'wevent'.
There is a disadvantage with this approach.
* Windows clients need to create a 'wevent' and then pass it along. This
means that at a lot of places where we create sockets, we also are forced
to create a 'wevent'.
With this commit, we pass the responsibility of creating a 'wevent' to
poll_fd_wait() in case of sockets. That way, a client using poll_fd_wait()
is only concerned about sockets and not about 'wevents'. There is a potential
disadvantage with this change in that we create events more often and that
may have a performance penalty. If that turns out to be the case, we will
eventually need to create a pool of wevents that can be re-used.
In Windows, there are cases where we want to wait on a event (not
associated with any sockets) and then control it using functions
like SetEvent() etc. For that purpose, introduce a new function
poll_wevent_wait(). For this function, the client needs to create a event
and then pass it along as an argument.
Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
Acked-By: Ben Pfaff <blp@nicira.com>
2014-06-27 13:30:49 -07:00
|
|
|
|
poll_fd_wait(sslv->fd, want_to_poll_events(sslv->tx_want));
|
2009-12-21 13:13:48 -08:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
ssl_wait(struct stream *stream, enum stream_wait_type wait)
|
|
|
|
|
{
|
|
|
|
|
struct ssl_stream *sslv = ssl_stream_cast(stream);
|
|
|
|
|
|
|
|
|
|
switch (wait) {
|
|
|
|
|
case STREAM_CONNECT:
|
|
|
|
|
if (stream_connect(stream) != EAGAIN) {
|
|
|
|
|
poll_immediate_wake();
|
|
|
|
|
} else {
|
|
|
|
|
switch (sslv->state) {
|
|
|
|
|
case STATE_TCP_CONNECTING:
|
poll-loop: Create Windows event handles for sockets automatically.
We currently have a poll_fd_wait_event(fd, wevent, events) function that
is used at places common to Windows and Linux where we have to wait on
sockets. On Linux, 'wevent' is always set as zero. On Windows, for sockets,
when we send both 'fd' and 'wevent', we associate them with each other for
'events' and then wait on 'wevent'. Also on Windows, when we only send 'wevent'
to this function, we would simply wait for all events for that 'wevent'.
There is a disadvantage with this approach.
* Windows clients need to create a 'wevent' and then pass it along. This
means that at a lot of places where we create sockets, we also are forced
to create a 'wevent'.
With this commit, we pass the responsibility of creating a 'wevent' to
poll_fd_wait() in case of sockets. That way, a client using poll_fd_wait()
is only concerned about sockets and not about 'wevents'. There is a potential
disadvantage with this change in that we create events more often and that
may have a performance penalty. If that turns out to be the case, we will
eventually need to create a pool of wevents that can be re-used.
In Windows, there are cases where we want to wait on a event (not
associated with any sockets) and then control it using functions
like SetEvent() etc. For that purpose, introduce a new function
poll_wevent_wait(). For this function, the client needs to create a event
and then pass it along as an argument.
Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
Acked-By: Ben Pfaff <blp@nicira.com>
2014-06-27 13:30:49 -07:00
|
|
|
|
poll_fd_wait(sslv->fd, POLLOUT);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case STATE_SSL_CONNECTING:
|
|
|
|
|
/* ssl_connect() called SSL_accept() or SSL_connect(), which
|
|
|
|
|
* set up the status that we test here. */
|
poll-loop: Create Windows event handles for sockets automatically.
We currently have a poll_fd_wait_event(fd, wevent, events) function that
is used at places common to Windows and Linux where we have to wait on
sockets. On Linux, 'wevent' is always set as zero. On Windows, for sockets,
when we send both 'fd' and 'wevent', we associate them with each other for
'events' and then wait on 'wevent'. Also on Windows, when we only send 'wevent'
to this function, we would simply wait for all events for that 'wevent'.
There is a disadvantage with this approach.
* Windows clients need to create a 'wevent' and then pass it along. This
means that at a lot of places where we create sockets, we also are forced
to create a 'wevent'.
With this commit, we pass the responsibility of creating a 'wevent' to
poll_fd_wait() in case of sockets. That way, a client using poll_fd_wait()
is only concerned about sockets and not about 'wevents'. There is a potential
disadvantage with this change in that we create events more often and that
may have a performance penalty. If that turns out to be the case, we will
eventually need to create a pool of wevents that can be re-used.
In Windows, there are cases where we want to wait on a event (not
associated with any sockets) and then control it using functions
like SetEvent() etc. For that purpose, introduce a new function
poll_wevent_wait(). For this function, the client needs to create a event
and then pass it along as an argument.
Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
Acked-By: Ben Pfaff <blp@nicira.com>
2014-06-27 13:30:49 -07:00
|
|
|
|
poll_fd_wait(sslv->fd,
|
|
|
|
|
want_to_poll_events(SSL_want(sslv->ssl)));
|
2009-12-21 13:13:48 -08:00
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
default:
|
2013-12-17 10:32:12 -08:00
|
|
|
|
OVS_NOT_REACHED();
|
2009-12-21 13:13:48 -08:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case STREAM_RECV:
|
|
|
|
|
if (sslv->rx_want != SSL_NOTHING) {
|
poll-loop: Create Windows event handles for sockets automatically.
We currently have a poll_fd_wait_event(fd, wevent, events) function that
is used at places common to Windows and Linux where we have to wait on
sockets. On Linux, 'wevent' is always set as zero. On Windows, for sockets,
when we send both 'fd' and 'wevent', we associate them with each other for
'events' and then wait on 'wevent'. Also on Windows, when we only send 'wevent'
to this function, we would simply wait for all events for that 'wevent'.
There is a disadvantage with this approach.
* Windows clients need to create a 'wevent' and then pass it along. This
means that at a lot of places where we create sockets, we also are forced
to create a 'wevent'.
With this commit, we pass the responsibility of creating a 'wevent' to
poll_fd_wait() in case of sockets. That way, a client using poll_fd_wait()
is only concerned about sockets and not about 'wevents'. There is a potential
disadvantage with this change in that we create events more often and that
may have a performance penalty. If that turns out to be the case, we will
eventually need to create a pool of wevents that can be re-used.
In Windows, there are cases where we want to wait on a event (not
associated with any sockets) and then control it using functions
like SetEvent() etc. For that purpose, introduce a new function
poll_wevent_wait(). For this function, the client needs to create a event
and then pass it along as an argument.
Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
Acked-By: Ben Pfaff <blp@nicira.com>
2014-06-27 13:30:49 -07:00
|
|
|
|
poll_fd_wait(sslv->fd, want_to_poll_events(sslv->rx_want));
|
2009-12-21 13:13:48 -08:00
|
|
|
|
} else {
|
|
|
|
|
poll_immediate_wake();
|
|
|
|
|
}
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
case STREAM_SEND:
|
|
|
|
|
if (!sslv->txbuf) {
|
|
|
|
|
/* We have room in our tx queue. */
|
|
|
|
|
poll_immediate_wake();
|
|
|
|
|
} else {
|
|
|
|
|
/* stream_run_wait() will do the right thing; don't bother with
|
|
|
|
|
* redundancy. */
|
|
|
|
|
}
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
default:
|
2013-12-17 10:32:12 -08:00
|
|
|
|
OVS_NOT_REACHED();
|
2009-12-21 13:13:48 -08:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2011-11-24 10:22:22 +09:00
|
|
|
|
const struct stream_class ssl_stream_class = {
|
2009-12-21 13:13:48 -08:00
|
|
|
|
"ssl", /* name */
|
2012-04-11 20:18:34 -07:00
|
|
|
|
true, /* needs_probes */
|
2009-12-21 13:13:48 -08:00
|
|
|
|
ssl_open, /* open */
|
|
|
|
|
ssl_close, /* close */
|
|
|
|
|
ssl_connect, /* connect */
|
|
|
|
|
ssl_recv, /* recv */
|
|
|
|
|
ssl_send, /* send */
|
|
|
|
|
ssl_run, /* run */
|
|
|
|
|
ssl_run_wait, /* run_wait */
|
|
|
|
|
ssl_wait, /* wait */
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
/* Passive SSL. */
|
|
|
|
|
|
|
|
|
|
struct pssl_pstream
|
|
|
|
|
{
|
|
|
|
|
struct pstream pstream;
|
|
|
|
|
int fd;
|
|
|
|
|
};
|
|
|
|
|
|
2011-11-24 10:22:22 +09:00
|
|
|
|
const struct pstream_class pssl_pstream_class;
|
2009-12-21 13:13:48 -08:00
|
|
|
|
|
|
|
|
|
static struct pssl_pstream *
|
|
|
|
|
pssl_pstream_cast(struct pstream *pstream)
|
|
|
|
|
{
|
|
|
|
|
pstream_assert_class(pstream, &pssl_pstream_class);
|
|
|
|
|
return CONTAINER_OF(pstream, struct pssl_pstream, pstream);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static int
|
2012-03-10 15:58:10 -08:00
|
|
|
|
pssl_open(const char *name OVS_UNUSED, char *suffix, struct pstream **pstreamp,
|
|
|
|
|
uint8_t dscp)
|
2009-12-21 13:13:48 -08:00
|
|
|
|
{
|
2014-02-06 16:04:05 -08:00
|
|
|
|
char bound_name[SS_NTOP_BUFSIZE + 16];
|
|
|
|
|
char addrbuf[SS_NTOP_BUFSIZE];
|
|
|
|
|
struct sockaddr_storage ss;
|
2009-12-21 13:13:48 -08:00
|
|
|
|
struct pssl_pstream *pssl;
|
2014-02-06 16:04:05 -08:00
|
|
|
|
uint16_t port;
|
2009-12-21 13:13:48 -08:00
|
|
|
|
int retval;
|
|
|
|
|
int fd;
|
|
|
|
|
|
|
|
|
|
retval = ssl_init();
|
|
|
|
|
if (retval) {
|
|
|
|
|
return retval;
|
|
|
|
|
}
|
|
|
|
|
|
2014-05-19 11:58:14 -07:00
|
|
|
|
fd = inet_open_passive(SOCK_STREAM, suffix, OFP_OLD_PORT, &ss, dscp, true);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
if (fd < 0) {
|
|
|
|
|
return -fd;
|
|
|
|
|
}
|
2014-02-06 16:04:05 -08:00
|
|
|
|
|
|
|
|
|
port = ss_get_port(&ss);
|
|
|
|
|
snprintf(bound_name, sizeof bound_name, "ptcp:%"PRIu16":%s",
|
|
|
|
|
port, ss_format_address(&ss, addrbuf, sizeof addrbuf));
|
2009-12-21 13:13:48 -08:00
|
|
|
|
|
|
|
|
|
pssl = xmalloc(sizeof *pssl);
|
2010-01-07 13:55:35 -08:00
|
|
|
|
pstream_init(&pssl->pstream, &pssl_pstream_class, bound_name);
|
2014-02-06 16:04:05 -08:00
|
|
|
|
pstream_set_bound_port(&pssl->pstream, htons(port));
|
2009-12-21 13:13:48 -08:00
|
|
|
|
pssl->fd = fd;
|
|
|
|
|
*pstreamp = &pssl->pstream;
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
pssl_close(struct pstream *pstream)
|
|
|
|
|
{
|
|
|
|
|
struct pssl_pstream *pssl = pssl_pstream_cast(pstream);
|
2014-02-06 07:57:12 -08:00
|
|
|
|
closesocket(pssl->fd);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
free(pssl);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static int
|
|
|
|
|
pssl_accept(struct pstream *pstream, struct stream **new_streamp)
|
|
|
|
|
{
|
|
|
|
|
struct pssl_pstream *pssl = pssl_pstream_cast(pstream);
|
2014-02-06 16:04:05 -08:00
|
|
|
|
char name[SS_NTOP_BUFSIZE + 16];
|
|
|
|
|
char addrbuf[SS_NTOP_BUFSIZE];
|
|
|
|
|
struct sockaddr_storage ss;
|
|
|
|
|
socklen_t ss_len = sizeof ss;
|
2009-12-21 13:13:48 -08:00
|
|
|
|
int new_fd;
|
|
|
|
|
int error;
|
|
|
|
|
|
2014-02-06 16:04:05 -08:00
|
|
|
|
new_fd = accept(pssl->fd, (struct sockaddr *) &ss, &ss_len);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
if (new_fd < 0) {
|
2014-02-06 07:57:12 -08:00
|
|
|
|
error = sock_errno();
|
|
|
|
|
#ifdef _WIN32
|
|
|
|
|
if (error == WSAEWOULDBLOCK) {
|
|
|
|
|
error = EAGAIN;
|
|
|
|
|
}
|
|
|
|
|
#endif
|
2009-12-21 13:13:48 -08:00
|
|
|
|
if (error != EAGAIN) {
|
2014-02-06 07:57:12 -08:00
|
|
|
|
VLOG_DBG_RL(&rl, "accept: %s", sock_strerror(error));
|
2009-12-21 13:13:48 -08:00
|
|
|
|
}
|
|
|
|
|
return error;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
error = set_nonblocking(new_fd);
|
|
|
|
|
if (error) {
|
2014-02-06 07:57:12 -08:00
|
|
|
|
closesocket(new_fd);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
return error;
|
|
|
|
|
}
|
|
|
|
|
|
2014-02-06 16:04:05 -08:00
|
|
|
|
snprintf(name, sizeof name, "tcp:%s:%"PRIu16,
|
|
|
|
|
ss_format_address(&ss, addrbuf, sizeof addrbuf),
|
|
|
|
|
ss_get_port(&ss));
|
2013-12-17 15:07:12 -08:00
|
|
|
|
return new_ssl_stream(name, new_fd, SERVER, STATE_SSL_CONNECTING,
|
2012-03-10 15:58:10 -08:00
|
|
|
|
new_streamp);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
pssl_wait(struct pstream *pstream)
|
|
|
|
|
{
|
|
|
|
|
struct pssl_pstream *pssl = pssl_pstream_cast(pstream);
|
poll-loop: Create Windows event handles for sockets automatically.
We currently have a poll_fd_wait_event(fd, wevent, events) function that
is used at places common to Windows and Linux where we have to wait on
sockets. On Linux, 'wevent' is always set as zero. On Windows, for sockets,
when we send both 'fd' and 'wevent', we associate them with each other for
'events' and then wait on 'wevent'. Also on Windows, when we only send 'wevent'
to this function, we would simply wait for all events for that 'wevent'.
There is a disadvantage with this approach.
* Windows clients need to create a 'wevent' and then pass it along. This
means that at a lot of places where we create sockets, we also are forced
to create a 'wevent'.
With this commit, we pass the responsibility of creating a 'wevent' to
poll_fd_wait() in case of sockets. That way, a client using poll_fd_wait()
is only concerned about sockets and not about 'wevents'. There is a potential
disadvantage with this change in that we create events more often and that
may have a performance penalty. If that turns out to be the case, we will
eventually need to create a pool of wevents that can be re-used.
In Windows, there are cases where we want to wait on a event (not
associated with any sockets) and then control it using functions
like SetEvent() etc. For that purpose, introduce a new function
poll_wevent_wait(). For this function, the client needs to create a event
and then pass it along as an argument.
Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
Acked-By: Ben Pfaff <blp@nicira.com>
2014-06-27 13:30:49 -07:00
|
|
|
|
poll_fd_wait(pssl->fd, POLLIN);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
}
|
|
|
|
|
|
2011-11-24 10:22:22 +09:00
|
|
|
|
const struct pstream_class pssl_pstream_class = {
|
2009-12-21 13:13:48 -08:00
|
|
|
|
"pssl",
|
2012-04-11 20:18:34 -07:00
|
|
|
|
true,
|
2009-12-21 13:13:48 -08:00
|
|
|
|
pssl_open,
|
|
|
|
|
pssl_close,
|
|
|
|
|
pssl_accept,
|
|
|
|
|
pssl_wait,
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* Returns true if OpenSSL error is WANT_READ or WANT_WRITE, indicating that
|
|
|
|
|
* OpenSSL is requesting that we call it back when the socket is ready for read
|
|
|
|
|
* or writing, respectively.
|
|
|
|
|
*/
|
|
|
|
|
static bool
|
|
|
|
|
ssl_wants_io(int ssl_error)
|
|
|
|
|
{
|
|
|
|
|
return (ssl_error == SSL_ERROR_WANT_WRITE
|
|
|
|
|
|| ssl_error == SSL_ERROR_WANT_READ);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static int
|
|
|
|
|
ssl_init(void)
|
|
|
|
|
{
|
|
|
|
|
static int init_status = -1;
|
|
|
|
|
if (init_status < 0) {
|
|
|
|
|
init_status = do_ssl_init();
|
2012-11-06 13:14:55 -08:00
|
|
|
|
ovs_assert(init_status >= 0);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
}
|
|
|
|
|
return init_status;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static int
|
|
|
|
|
do_ssl_init(void)
|
|
|
|
|
{
|
|
|
|
|
SSL_METHOD *method;
|
|
|
|
|
|
2014-02-06 07:57:12 -08:00
|
|
|
|
#ifdef _WIN32
|
|
|
|
|
/* The following call is needed if we "#include <openssl/applink.c>". */
|
|
|
|
|
CRYPTO_malloc_init();
|
|
|
|
|
#endif
|
2009-12-21 13:13:48 -08:00
|
|
|
|
SSL_library_init();
|
|
|
|
|
SSL_load_error_strings();
|
|
|
|
|
|
2012-08-09 14:18:46 -07:00
|
|
|
|
if (!RAND_status()) {
|
|
|
|
|
/* We occasionally see OpenSSL fail to seed its random number generator
|
|
|
|
|
* in heavily loaded hypervisors. I suspect the following scenario:
|
|
|
|
|
*
|
|
|
|
|
* 1. OpenSSL calls read() to get 32 bytes from /dev/urandom.
|
|
|
|
|
* 2. The kernel generates 10 bytes of randomness and copies it out.
|
|
|
|
|
* 3. A signal arrives (perhaps SIGALRM).
|
|
|
|
|
* 4. The kernel interrupts the system call to service the signal.
|
|
|
|
|
* 5. Userspace gets 10 bytes of entropy.
|
|
|
|
|
* 6. OpenSSL doesn't read again to get the final 22 bytes. Therefore
|
|
|
|
|
* OpenSSL doesn't have enough entropy to consider itself
|
|
|
|
|
* initialized.
|
|
|
|
|
*
|
|
|
|
|
* The only part I'm not entirely sure about is #6, because the OpenSSL
|
|
|
|
|
* code is so hard to read. */
|
|
|
|
|
uint8_t seed[32];
|
|
|
|
|
int retval;
|
|
|
|
|
|
|
|
|
|
VLOG_WARN("OpenSSL random seeding failed, reseeding ourselves");
|
|
|
|
|
|
|
|
|
|
retval = get_entropy(seed, sizeof seed);
|
|
|
|
|
if (retval) {
|
|
|
|
|
VLOG_ERR("failed to obtain entropy (%s)",
|
|
|
|
|
ovs_retval_to_string(retval));
|
|
|
|
|
return retval > 0 ? retval : ENOPROTOOPT;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
RAND_seed(seed, sizeof seed);
|
|
|
|
|
}
|
|
|
|
|
|
2014-06-13 16:24:49 -07:00
|
|
|
|
/* OpenSSL has a bunch of "connection methods": SSLv2_method(),
|
|
|
|
|
* SSLv3_method(), TLSv1_method(), SSLv23_method(), ... Most of these
|
|
|
|
|
* support exactly one version of SSL, e.g. TLSv1_method() supports TLSv1
|
|
|
|
|
* only, not any earlier *or later* version. The only exception is
|
|
|
|
|
* SSLv23_method(), which in fact supports *any* version of SSL and TLS.
|
|
|
|
|
* We don't want SSLv2 or SSLv3 support, so we turn it off below with
|
|
|
|
|
* SSL_CTX_set_options().
|
|
|
|
|
*
|
|
|
|
|
* The cast is needed to avoid a warning with newer versions of OpenSSL in
|
|
|
|
|
* which SSLv23_method() returns a "const" pointer. */
|
|
|
|
|
method = CONST_CAST(SSL_METHOD *, SSLv23_method());
|
2009-12-21 13:13:48 -08:00
|
|
|
|
if (method == NULL) {
|
|
|
|
|
VLOG_ERR("TLSv1_method: %s", ERR_error_string(ERR_get_error(), NULL));
|
|
|
|
|
return ENOPROTOOPT;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
ctx = SSL_CTX_new(method);
|
|
|
|
|
if (ctx == NULL) {
|
|
|
|
|
VLOG_ERR("SSL_CTX_new: %s", ERR_error_string(ERR_get_error(), NULL));
|
|
|
|
|
return ENOPROTOOPT;
|
|
|
|
|
}
|
|
|
|
|
SSL_CTX_set_options(ctx, SSL_OP_NO_SSLv2 | SSL_OP_NO_SSLv3);
|
|
|
|
|
SSL_CTX_set_tmp_dh_callback(ctx, tmp_dh_callback);
|
|
|
|
|
SSL_CTX_set_mode(ctx, SSL_MODE_ENABLE_PARTIAL_WRITE);
|
|
|
|
|
SSL_CTX_set_mode(ctx, SSL_MODE_ACCEPT_MOVING_WRITE_BUFFER);
|
|
|
|
|
SSL_CTX_set_verify(ctx, SSL_VERIFY_PEER | SSL_VERIFY_FAIL_IF_NO_PEER_CERT,
|
|
|
|
|
NULL);
|
|
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static DH *
|
2010-02-11 10:59:47 -08:00
|
|
|
|
tmp_dh_callback(SSL *ssl OVS_UNUSED, int is_export OVS_UNUSED, int keylength)
|
2009-12-21 13:13:48 -08:00
|
|
|
|
{
|
|
|
|
|
struct dh {
|
|
|
|
|
int keylength;
|
|
|
|
|
DH *dh;
|
|
|
|
|
DH *(*constructor)(void);
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
static struct dh dh_table[] = {
|
|
|
|
|
{1024, NULL, get_dh1024},
|
|
|
|
|
{2048, NULL, get_dh2048},
|
|
|
|
|
{4096, NULL, get_dh4096},
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
struct dh *dh;
|
|
|
|
|
|
|
|
|
|
for (dh = dh_table; dh < &dh_table[ARRAY_SIZE(dh_table)]; dh++) {
|
|
|
|
|
if (dh->keylength == keylength) {
|
|
|
|
|
if (!dh->dh) {
|
|
|
|
|
dh->dh = dh->constructor();
|
|
|
|
|
if (!dh->dh) {
|
2011-03-31 14:52:36 -07:00
|
|
|
|
out_of_memory();
|
2009-12-21 13:13:48 -08:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
return dh->dh;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
VLOG_ERR_RL(&rl, "no Diffie-Hellman parameters for key length %d",
|
|
|
|
|
keylength);
|
|
|
|
|
return NULL;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Returns true if SSL is at least partially configured. */
|
|
|
|
|
bool
|
2010-08-30 00:24:53 -07:00
|
|
|
|
stream_ssl_is_configured(void)
|
2009-12-21 13:13:48 -08:00
|
|
|
|
{
|
2010-03-18 16:40:35 -07:00
|
|
|
|
return private_key.file_name || certificate.file_name || ca_cert.file_name;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static bool
|
|
|
|
|
update_ssl_config(struct ssl_config_file *config, const char *file_name)
|
|
|
|
|
{
|
2010-03-24 13:15:41 -07:00
|
|
|
|
struct timespec mtime;
|
2011-05-05 11:25:51 -07:00
|
|
|
|
int error;
|
2010-03-24 13:15:41 -07:00
|
|
|
|
|
|
|
|
|
if (ssl_init() || !file_name) {
|
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* If the file name hasn't changed and neither has the file contents, stop
|
|
|
|
|
* here. */
|
2011-05-05 11:25:51 -07:00
|
|
|
|
error = get_mtime(file_name, &mtime);
|
|
|
|
|
if (error && error != ENOENT) {
|
2013-06-24 10:54:49 -07:00
|
|
|
|
VLOG_ERR_RL(&rl, "%s: stat failed (%s)",
|
|
|
|
|
file_name, ovs_strerror(error));
|
2011-05-05 11:25:51 -07:00
|
|
|
|
}
|
2010-03-24 13:15:41 -07:00
|
|
|
|
if (config->file_name
|
|
|
|
|
&& !strcmp(config->file_name, file_name)
|
|
|
|
|
&& mtime.tv_sec == config->mtime.tv_sec
|
|
|
|
|
&& mtime.tv_nsec == config->mtime.tv_nsec) {
|
2010-03-18 16:40:35 -07:00
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
|
2010-04-14 16:02:38 -07:00
|
|
|
|
/* Update 'config'. */
|
2010-03-24 13:15:41 -07:00
|
|
|
|
config->mtime = mtime;
|
2010-04-14 16:02:38 -07:00
|
|
|
|
if (file_name != config->file_name) {
|
|
|
|
|
free(config->file_name);
|
|
|
|
|
config->file_name = xstrdup(file_name);
|
|
|
|
|
}
|
2010-03-18 16:40:35 -07:00
|
|
|
|
return true;
|
2009-12-21 13:13:48 -08:00
|
|
|
|
}
|
|
|
|
|
|
2010-08-05 09:24:00 -07:00
|
|
|
|
static void
|
|
|
|
|
stream_ssl_set_private_key_file__(const char *file_name)
|
|
|
|
|
{
|
|
|
|
|
if (SSL_CTX_use_PrivateKey_file(ctx, file_name, SSL_FILETYPE_PEM) == 1) {
|
|
|
|
|
private_key.read = true;
|
|
|
|
|
} else {
|
|
|
|
|
VLOG_ERR("SSL_use_PrivateKey_file: %s",
|
|
|
|
|
ERR_error_string(ERR_get_error(), NULL));
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2009-12-21 13:13:48 -08:00
|
|
|
|
void
|
|
|
|
|
stream_ssl_set_private_key_file(const char *file_name)
|
|
|
|
|
{
|
2010-08-05 09:24:00 -07:00
|
|
|
|
if (update_ssl_config(&private_key, file_name)) {
|
|
|
|
|
stream_ssl_set_private_key_file__(file_name);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
}
|
2010-08-05 09:24:00 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
stream_ssl_set_certificate_file__(const char *file_name)
|
|
|
|
|
{
|
|
|
|
|
if (SSL_CTX_use_certificate_chain_file(ctx, file_name) == 1) {
|
|
|
|
|
certificate.read = true;
|
|
|
|
|
} else {
|
|
|
|
|
VLOG_ERR("SSL_use_certificate_file: %s",
|
2009-12-21 13:13:48 -08:00
|
|
|
|
ERR_error_string(ERR_get_error(), NULL));
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void
|
|
|
|
|
stream_ssl_set_certificate_file(const char *file_name)
|
|
|
|
|
{
|
2010-08-05 09:24:00 -07:00
|
|
|
|
if (update_ssl_config(&certificate, file_name)) {
|
|
|
|
|
stream_ssl_set_certificate_file__(file_name);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
}
|
2010-08-05 09:24:00 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Sets the private key and certificate files in one operation. Use this
|
|
|
|
|
* interface, instead of calling stream_ssl_set_private_key_file() and
|
|
|
|
|
* stream_ssl_set_certificate_file() individually, in the main loop of a
|
|
|
|
|
* long-running program whose key and certificate might change at runtime.
|
|
|
|
|
*
|
|
|
|
|
* This is important because of OpenSSL's behavior. If an OpenSSL context
|
|
|
|
|
* already has a certificate, and stream_ssl_set_private_key_file() is called
|
|
|
|
|
* to install a new private key, OpenSSL will report an error because the new
|
|
|
|
|
* private key does not match the old certificate. The other order, of setting
|
|
|
|
|
* a new certificate, then setting a new private key, does work.
|
|
|
|
|
*
|
|
|
|
|
* If this were the only problem, calling stream_ssl_set_certificate_file()
|
|
|
|
|
* before stream_ssl_set_private_key_file() would fix it. But, if the private
|
|
|
|
|
* key is changed before the certificate (e.g. someone "scp"s or "mv"s the new
|
|
|
|
|
* private key in place before the certificate), then OpenSSL would reject that
|
|
|
|
|
* change, and then the change of certificate would succeed, but there would be
|
|
|
|
|
* no associated private key (because it had only changed once and therefore
|
|
|
|
|
* there was no point in re-reading it).
|
|
|
|
|
*
|
|
|
|
|
* This function avoids both problems by, whenever either the certificate or
|
|
|
|
|
* the private key file changes, re-reading both of them, in the correct order.
|
|
|
|
|
*/
|
|
|
|
|
void
|
|
|
|
|
stream_ssl_set_key_and_cert(const char *private_key_file,
|
|
|
|
|
const char *certificate_file)
|
|
|
|
|
{
|
|
|
|
|
if (update_ssl_config(&private_key, private_key_file)
|
|
|
|
|
|| update_ssl_config(&certificate, certificate_file)) {
|
|
|
|
|
stream_ssl_set_certificate_file__(certificate_file);
|
|
|
|
|
stream_ssl_set_private_key_file__(private_key_file);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Reads the X509 certificate or certificates in file 'file_name'. On success,
|
|
|
|
|
* stores the address of the first element in an array of pointers to
|
|
|
|
|
* certificates in '*certs' and the number of certificates in the array in
|
|
|
|
|
* '*n_certs', and returns 0. On failure, stores a null pointer in '*certs', 0
|
|
|
|
|
* in '*n_certs', and returns a positive errno value.
|
|
|
|
|
*
|
|
|
|
|
* The caller is responsible for freeing '*certs'. */
|
|
|
|
|
static int
|
|
|
|
|
read_cert_file(const char *file_name, X509 ***certs, size_t *n_certs)
|
|
|
|
|
{
|
|
|
|
|
FILE *file;
|
|
|
|
|
size_t allocated_certs = 0;
|
|
|
|
|
|
|
|
|
|
*certs = NULL;
|
|
|
|
|
*n_certs = 0;
|
|
|
|
|
|
|
|
|
|
file = fopen(file_name, "r");
|
|
|
|
|
if (!file) {
|
|
|
|
|
VLOG_ERR("failed to open %s for reading: %s",
|
2013-06-24 10:54:49 -07:00
|
|
|
|
file_name, ovs_strerror(errno));
|
2009-12-21 13:13:48 -08:00
|
|
|
|
return errno;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
for (;;) {
|
|
|
|
|
X509 *certificate;
|
|
|
|
|
int c;
|
|
|
|
|
|
|
|
|
|
/* Read certificate from file. */
|
|
|
|
|
certificate = PEM_read_X509(file, NULL, NULL, NULL);
|
|
|
|
|
if (!certificate) {
|
|
|
|
|
size_t i;
|
|
|
|
|
|
|
|
|
|
VLOG_ERR("PEM_read_X509 failed reading %s: %s",
|
|
|
|
|
file_name, ERR_error_string(ERR_get_error(), NULL));
|
|
|
|
|
for (i = 0; i < *n_certs; i++) {
|
|
|
|
|
X509_free((*certs)[i]);
|
|
|
|
|
}
|
|
|
|
|
free(*certs);
|
|
|
|
|
*certs = NULL;
|
|
|
|
|
*n_certs = 0;
|
2014-07-28 15:21:17 +08:00
|
|
|
|
fclose(file);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
return EIO;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Add certificate to array. */
|
|
|
|
|
if (*n_certs >= allocated_certs) {
|
|
|
|
|
*certs = x2nrealloc(*certs, &allocated_certs, sizeof **certs);
|
|
|
|
|
}
|
|
|
|
|
(*certs)[(*n_certs)++] = certificate;
|
|
|
|
|
|
|
|
|
|
/* Are there additional certificates in the file? */
|
|
|
|
|
do {
|
|
|
|
|
c = getc(file);
|
|
|
|
|
} while (isspace(c));
|
|
|
|
|
if (c == EOF) {
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
ungetc(c, file);
|
|
|
|
|
}
|
|
|
|
|
fclose(file);
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
/* Sets 'file_name' as the name of a file containing one or more X509
|
|
|
|
|
* certificates to send to the peer. Typical use in OpenFlow is to send the CA
|
|
|
|
|
* certificate to the peer, which enables a switch to pick up the controller's
|
|
|
|
|
* CA certificate on its first connection. */
|
|
|
|
|
void
|
|
|
|
|
stream_ssl_set_peer_ca_cert_file(const char *file_name)
|
|
|
|
|
{
|
|
|
|
|
X509 **certs;
|
|
|
|
|
size_t n_certs;
|
|
|
|
|
size_t i;
|
|
|
|
|
|
|
|
|
|
if (ssl_init()) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (!read_cert_file(file_name, &certs, &n_certs)) {
|
|
|
|
|
for (i = 0; i < n_certs; i++) {
|
|
|
|
|
if (SSL_CTX_add_extra_chain_cert(ctx, certs[i]) != 1) {
|
|
|
|
|
VLOG_ERR("SSL_CTX_add_extra_chain_cert: %s",
|
|
|
|
|
ERR_error_string(ERR_get_error(), NULL));
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
free(certs);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Logs fingerprint of CA certificate 'cert' obtained from 'file_name'. */
|
|
|
|
|
static void
|
|
|
|
|
log_ca_cert(const char *file_name, X509 *cert)
|
|
|
|
|
{
|
|
|
|
|
unsigned char digest[EVP_MAX_MD_SIZE];
|
|
|
|
|
unsigned int n_bytes;
|
|
|
|
|
struct ds fp;
|
|
|
|
|
char *subject;
|
|
|
|
|
|
|
|
|
|
ds_init(&fp);
|
|
|
|
|
if (!X509_digest(cert, EVP_sha1(), digest, &n_bytes)) {
|
|
|
|
|
ds_put_cstr(&fp, "<out of memory>");
|
|
|
|
|
} else {
|
|
|
|
|
unsigned int i;
|
|
|
|
|
for (i = 0; i < n_bytes; i++) {
|
|
|
|
|
if (i) {
|
|
|
|
|
ds_put_char(&fp, ':');
|
|
|
|
|
}
|
2013-11-25 23:38:48 -08:00
|
|
|
|
ds_put_format(&fp, "%02x", digest[i]);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
subject = X509_NAME_oneline(X509_get_subject_name(cert), NULL, 0);
|
|
|
|
|
VLOG_INFO("Trusting CA cert from %s (%s) (fingerprint %s)", file_name,
|
|
|
|
|
subject ? subject : "<out of memory>", ds_cstr(&fp));
|
2010-08-27 13:30:31 -07:00
|
|
|
|
OPENSSL_free(subject);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
ds_destroy(&fp);
|
|
|
|
|
}
|
|
|
|
|
|
2010-03-18 16:40:35 -07:00
|
|
|
|
static void
|
2011-05-05 10:59:50 -07:00
|
|
|
|
stream_ssl_set_ca_cert_file__(const char *file_name,
|
|
|
|
|
bool bootstrap, bool force)
|
2009-12-21 13:13:48 -08:00
|
|
|
|
{
|
|
|
|
|
X509 **certs;
|
|
|
|
|
size_t n_certs;
|
|
|
|
|
struct stat s;
|
|
|
|
|
|
2011-05-05 10:59:50 -07:00
|
|
|
|
if (!update_ssl_config(&ca_cert, file_name) && !force) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2010-03-23 17:19:36 -07:00
|
|
|
|
if (!strcmp(file_name, "none")) {
|
|
|
|
|
verify_peer_cert = false;
|
|
|
|
|
VLOG_WARN("Peer certificate validation disabled "
|
|
|
|
|
"(this is a security risk)");
|
|
|
|
|
} else if (bootstrap && stat(file_name, &s) && errno == ENOENT) {
|
2009-12-21 13:13:48 -08:00
|
|
|
|
bootstrap_ca_cert = true;
|
|
|
|
|
} else if (!read_cert_file(file_name, &certs, &n_certs)) {
|
|
|
|
|
size_t i;
|
|
|
|
|
|
|
|
|
|
/* Set up list of CAs that the server will accept from the client. */
|
|
|
|
|
for (i = 0; i < n_certs; i++) {
|
|
|
|
|
/* SSL_CTX_add_client_CA makes a copy of the relevant data. */
|
|
|
|
|
if (SSL_CTX_add_client_CA(ctx, certs[i]) != 1) {
|
2013-11-25 23:38:48 -08:00
|
|
|
|
VLOG_ERR("failed to add client certificate %"PRIuSIZE" from %s: %s",
|
2009-12-21 13:13:48 -08:00
|
|
|
|
i, file_name,
|
|
|
|
|
ERR_error_string(ERR_get_error(), NULL));
|
|
|
|
|
} else {
|
|
|
|
|
log_ca_cert(file_name, certs[i]);
|
|
|
|
|
}
|
|
|
|
|
X509_free(certs[i]);
|
|
|
|
|
}
|
2010-02-01 14:35:37 -08:00
|
|
|
|
free(certs);
|
2009-12-21 13:13:48 -08:00
|
|
|
|
|
|
|
|
|
/* Set up CAs for OpenSSL to trust in verifying the peer's
|
|
|
|
|
* certificate. */
|
2011-06-15 11:50:24 -07:00
|
|
|
|
SSL_CTX_set_cert_store(ctx, X509_STORE_new());
|
2009-12-21 13:13:48 -08:00
|
|
|
|
if (SSL_CTX_load_verify_locations(ctx, file_name, NULL) != 1) {
|
|
|
|
|
VLOG_ERR("SSL_CTX_load_verify_locations: %s",
|
|
|
|
|
ERR_error_string(ERR_get_error(), NULL));
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2010-03-18 16:40:35 -07:00
|
|
|
|
bootstrap_ca_cert = false;
|
2009-12-21 13:13:48 -08:00
|
|
|
|
}
|
2010-03-18 16:40:35 -07:00
|
|
|
|
ca_cert.read = true;
|
2009-12-21 13:13:48 -08:00
|
|
|
|
}
|
2010-03-18 16:40:35 -07:00
|
|
|
|
|
|
|
|
|
/* Sets 'file_name' as the name of the file from which to read the CA
|
|
|
|
|
* certificate used to verify the peer within SSL connections. If 'bootstrap'
|
|
|
|
|
* is false, the file must exist. If 'bootstrap' is false, then the file is
|
|
|
|
|
* read if it is exists; if it does not, then it will be created from the CA
|
|
|
|
|
* certificate received from the peer on the first SSL connection. */
|
|
|
|
|
void
|
|
|
|
|
stream_ssl_set_ca_cert_file(const char *file_name, bool bootstrap)
|
|
|
|
|
{
|
2011-05-05 10:59:50 -07:00
|
|
|
|
stream_ssl_set_ca_cert_file__(file_name, bootstrap, false);
|
2010-03-18 16:40:35 -07:00
|
|
|
|
}
|
2010-06-04 16:47:55 -07:00
|
|
|
|
|
|
|
|
|
/* SSL protocol logging. */
|
|
|
|
|
|
|
|
|
|
static const char *
|
|
|
|
|
ssl_alert_level_to_string(uint8_t type)
|
|
|
|
|
{
|
|
|
|
|
switch (type) {
|
|
|
|
|
case 1: return "warning";
|
|
|
|
|
case 2: return "fatal";
|
|
|
|
|
default: return "<unknown>";
|
|
|
|
|
}
|
|
|
|
|
}
|
2010-03-18 16:40:35 -07:00
|
|
|
|
|
2010-06-04 16:47:55 -07:00
|
|
|
|
static const char *
|
|
|
|
|
ssl_alert_description_to_string(uint8_t type)
|
|
|
|
|
{
|
|
|
|
|
switch (type) {
|
|
|
|
|
case 0: return "close_notify";
|
|
|
|
|
case 10: return "unexpected_message";
|
|
|
|
|
case 20: return "bad_record_mac";
|
|
|
|
|
case 21: return "decryption_failed";
|
|
|
|
|
case 22: return "record_overflow";
|
|
|
|
|
case 30: return "decompression_failure";
|
|
|
|
|
case 40: return "handshake_failure";
|
|
|
|
|
case 42: return "bad_certificate";
|
|
|
|
|
case 43: return "unsupported_certificate";
|
|
|
|
|
case 44: return "certificate_revoked";
|
|
|
|
|
case 45: return "certificate_expired";
|
|
|
|
|
case 46: return "certificate_unknown";
|
|
|
|
|
case 47: return "illegal_parameter";
|
|
|
|
|
case 48: return "unknown_ca";
|
|
|
|
|
case 49: return "access_denied";
|
|
|
|
|
case 50: return "decode_error";
|
|
|
|
|
case 51: return "decrypt_error";
|
|
|
|
|
case 60: return "export_restriction";
|
|
|
|
|
case 70: return "protocol_version";
|
|
|
|
|
case 71: return "insufficient_security";
|
|
|
|
|
case 80: return "internal_error";
|
|
|
|
|
case 90: return "user_canceled";
|
|
|
|
|
case 100: return "no_renegotiation";
|
|
|
|
|
default: return "<unknown>";
|
|
|
|
|
}
|
|
|
|
|
}
|
2010-03-18 16:40:35 -07:00
|
|
|
|
|
2010-06-04 16:47:55 -07:00
|
|
|
|
static const char *
|
|
|
|
|
ssl_handshake_type_to_string(uint8_t type)
|
|
|
|
|
{
|
|
|
|
|
switch (type) {
|
|
|
|
|
case 0: return "hello_request";
|
|
|
|
|
case 1: return "client_hello";
|
|
|
|
|
case 2: return "server_hello";
|
|
|
|
|
case 11: return "certificate";
|
|
|
|
|
case 12: return "server_key_exchange";
|
|
|
|
|
case 13: return "certificate_request";
|
|
|
|
|
case 14: return "server_hello_done";
|
|
|
|
|
case 15: return "certificate_verify";
|
|
|
|
|
case 16: return "client_key_exchange";
|
|
|
|
|
case 20: return "finished";
|
|
|
|
|
default: return "<unknown>";
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
ssl_protocol_cb(int write_p, int version OVS_UNUSED, int content_type,
|
|
|
|
|
const void *buf_, size_t len, SSL *ssl OVS_UNUSED, void *sslv_)
|
|
|
|
|
{
|
|
|
|
|
const struct ssl_stream *sslv = sslv_;
|
|
|
|
|
const uint8_t *buf = buf_;
|
|
|
|
|
struct ds details;
|
|
|
|
|
|
|
|
|
|
if (!VLOG_IS_DBG_ENABLED()) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
ds_init(&details);
|
|
|
|
|
if (content_type == 20) {
|
|
|
|
|
ds_put_cstr(&details, "change_cipher_spec");
|
|
|
|
|
} else if (content_type == 21) {
|
|
|
|
|
ds_put_format(&details, "alert: %s, %s",
|
|
|
|
|
ssl_alert_level_to_string(buf[0]),
|
|
|
|
|
ssl_alert_description_to_string(buf[1]));
|
|
|
|
|
} else if (content_type == 22) {
|
|
|
|
|
ds_put_format(&details, "handshake: %s",
|
|
|
|
|
ssl_handshake_type_to_string(buf[0]));
|
|
|
|
|
} else {
|
|
|
|
|
ds_put_format(&details, "type %d", content_type);
|
|
|
|
|
}
|
|
|
|
|
|
2013-11-25 23:38:48 -08:00
|
|
|
|
VLOG_DBG("%s%u%s%s %s (%"PRIuSIZE" bytes)",
|
2010-06-04 16:47:55 -07:00
|
|
|
|
sslv->type == CLIENT ? "client" : "server",
|
|
|
|
|
sslv->session_nr, write_p ? "-->" : "<--",
|
|
|
|
|
stream_get_name(&sslv->stream), ds_cstr(&details), len);
|
|
|
|
|
|
|
|
|
|
ds_destroy(&details);
|
|
|
|
|
}
|