mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-08-22 09:58:01 +00:00
Code Issues Releases Wiki Activity
ovs/configure.ac

219 lines
7.1 KiB
Plaintext
Raw Normal View History

Makefile: Drop vestiges of support for non-GNU Make. Open vSwitch has documented a requirement for GNU Make for a long time, yet it had vestiges catering to other make implementations. This removes those. Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Russell Bryant <russell@ovn.org>
2017-03-07 20:48:08 -08:00
# Copyright (c) 2008, 2009, 2010, 2011, 2012, 2013, 2014, 2015, 2016, 2017 Nicira, Inc.
Import from old repository commit 61ef2b42a9c4ba8e1600f15bb0236765edc2ad45.
2009-07-08 13:19:16 -07:00
#
Update primary code license to Apache 2.0.
2009-06-15 15:11:30 -07:00
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at:
Import from old repository commit 61ef2b42a9c4ba8e1600f15bb0236765edc2ad45.
2009-07-08 13:19:16 -07:00
#
Update primary code license to Apache 2.0.
2009-06-15 15:11:30 -07:00
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
Import from old repository commit 61ef2b42a9c4ba8e1600f15bb0236765edc2ad45.
2009-07-08 13:19:16 -07:00
build: Allow building with autoconf 2.63 Reduces the dependency on autoconf from 2.64 to 2.63 to ease building on older platforms. There is only a few macros missing and they can be provided easily. A handful of tests needed modification. The difference in quoting behaviour between 2.63 and later require the m4_define() to be manually unfolded. The Debian control file is left untouched on purpose. The decision whether to adjust the dependency is left to the respective maintainers. Tested with autoconf 2.63 and 2.69. Cc: Scott Mann <smann@noironetworks.com> Cc: Don Kehn <dkehn@noironetworks.com> Signed-off-by: Thomas Graf <tgraf@noironetworks.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2014-06-27 09:31:57 +02:00
AC_PREREQ(2.63)
Prepare for post-2.13.0 (2.13.90). Acked-by: Gurucharan Shetty <guru@ovn.org> Signed-off-by: Ben Pfaff <blp@ovn.org>
2020-01-21 12:45:00 -08:00
AC_INIT(openvswitch, 2.13.90, bugs@openvswitch.org)
Import from old repository commit 61ef2b42a9c4ba8e1600f15bb0236765edc2ad45.
2009-07-08 13:19:16 -07:00
AC_CONFIG_SRCDIR([datapath/datapath.c])
AC_CONFIG_MACRO_DIR([m4])
AC_CONFIG_AUX_DIR([build-aux])
AC_CONFIG_HEADERS([config.h])
Use Autotest for the Open vSwitch test suite. Autotest doesn't provide a lot of benefit by itself but it does allow us to easily put a wrapper around each test by using a macro to invoke it. (To do that with the built-in Automake test framework you need to write or generate a separate wrapper script for each test, which is a pain.) The next commit will take advantage of this possibility by adding support for code coverage analysis.
2009-07-27 16:40:11 -07:00
AC_CONFIG_TESTDIR([tests])
configure.ac: Enable 'tar-pax' by default Automake defaults to the 'v7' legacy tar format in GNU tar, through passing of the '-o' parameter to GNU tar. Enabling this option results in errors for users with 32 bit UIDs: $ make dist ... tardir=openvswitch-2.3.90 && ${TAR-tar} chof - "$tardir" | GZIP=--best gzip -c >openvswitch-2.3.90.tar.gz tar: value 12345678 out of uid_t range 0..2097151 tar: Exiting with failure status due to previous errors make[1]: Leaving directory `/development/ovs' ... The 'tar-pax' format is a 2001 POSIX standard that allow longer file names and other niceties. Its use is a configuration option in Automake 1.9+. Enable this option. Signed-off-by: Stephen Finucane <stephen.finucane@intel.com> Reviewed-by: Mark D. Gray <mark.d.gray@intel.com> Cc: Panu Matilainen <pmatilai@laiskiainen.org> Signed-off-by: Ben Pfaff <blp@nicira.com>
2015-01-15 09:20:22 +00:00
AM_INIT_AUTOMAKE([tar-pax])
Import from old repository commit 61ef2b42a9c4ba8e1600f15bb0236765edc2ad45.
2009-07-08 13:19:16 -07:00
configure.ac: Check C99 compiler This ends up to add -std=gnu99 and fixes the following compilation problem introduced by commit 08feeb75. ("lib/flow: Use C99 declaration in for statement.") libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -I ../include -I ../lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wno-format-zero-length -Wswitch-enum -Wunused-parameter -Wstrict-aliasing -Wbad-function-cast -Wcast-align -Wmissing-prototypes -Wmissing-field-initializers -g -O2 -MT lib/classifier.lo -MD -MP -MF lib/.deps/classifier.Tpo -c ../lib/classifier.c -o lib/classifier.o ../lib/classifier.c: In function 'miniflow_and_mask_matches_flow': ../lib/classifier.c:1722:5: error: 'for' loop initial declarations are only allowed in C99 mode ../lib/classifier.c:1722:5: note: use option -std=c99 or -std=gnu99 to compile your code Makefile:3013: recipe for target 'lib/classifier.lo' failed % gcc --version gcc (NetBSD nb1 20120916) 4.5.4 Copyright (C) 2010 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. Signed-off-by: YAMAMOTO Takashi <yamamoto@valinux.co.jp> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-05-29 16:12:24 +00:00
AC_PROG_CC_C99
Import from old repository commit 61ef2b42a9c4ba8e1600f15bb0236765edc2ad45.
2009-07-08 13:19:16 -07:00
AM_PROG_CC_C_O
Automatically verify that OVS header files work OK in C++ also. This should help address a recurring problem. This change makes the OVS header files, when parsed by a C++ compiler, require C++11 or later. Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Russell Bryant <russell@ovn.org>
2017-07-31 13:31:43 -07:00
AC_PROG_CXX
Import from old repository commit 61ef2b42a9c4ba8e1600f15bb0236765edc2ad45.
2009-07-08 13:19:16 -07:00
AC_PROG_CPP
AC_PROG_MKDIR_P
debian: Check for accurate Debian changelog version at build time too. When we increment the Open vSwitch version number, we tend to forget to update it in debian/changelog at the same time. Right now this gets fixed up automatically at "make dist" time, but it's even better if we can always have it be correct in the repository. This commit should help with that, by making both "make" and "make dist" refuse to proceed if the version number is out of sync.
2010-07-21 15:38:23 -07:00
AC_PROG_FGREP
Makefile.am: add check that <assert.h> is not used from unexpected files. In general, with a few specific exceptions, ovs_assert is now preferred over assert, so this commit adds a check for that in the top-level Makefile. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
2012-11-07 10:16:27 -08:00
AC_PROG_EGREP
acinclude: Also support pkg-config for configuring dpdk. If available use dpdk pkg-config info of libdpdk to set the right include paths. That for example, allows packagers to provide non default include paths in a common way (pkg-config). Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com> Suggested-by: Luca Boccassi <luca.boccassi@gmail.com> Acked-by: Luca Boccassi <luca.boccassi@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
2017-07-14 08:36:39 +02:00
PKG_PROG_PKG_CONFIG
Import from old repository commit 61ef2b42a9c4ba8e1600f15bb0236765edc2ad45.
2009-07-08 13:19:16 -07:00
Avoid requiring autom4te when it won't necessarily be needed. Commit 7fd3e43db07 (tests: Allow environment specified autom4te.) added a requirement for Autom4te without anyone noticing it in advance. This caused a build failure in the XenServer DDK, which doesn't have Autom4te. Since Autom4te is only needed if the testsuite is modified, this commit makes it optional. (Autom4te is part of Autoconf.) Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
2012-10-04 15:55:43 -07:00
AM_MISSING_PROG([AUTOM4TE], [autom4te])
tests: Allow environment specified autom4te. In the ESX build system, autom4te is in a funny location specified by an environment variable. Before this patch, this environment variable was overridden by the tests automake file. Signed-off-by: Ethan Jackson <ethan@nicira.com>
2012-10-03 15:58:54 -07:00
Import from old repository commit 61ef2b42a9c4ba8e1600f15bb0236765edc2ad45.
2009-07-08 13:19:16 -07:00
AC_USE_SYSTEM_EXTENSIONS
AC_C_BIGENDIAN
AC_SYS_LARGEFILE
openvswitch: Use libtool and allow building shared libs Currently openvswitch builds all libraries static only. However, libopenvswitch is linked into nearly all openvswitch executables making it hardly possible to run openvswitch on embedded devices (for example running OpenWrt). Convert openvswitch to use libtool for building its internal libs. This allows "--enable-shared" and "--enable-static" as configure arguments. Default is "--disable-shared" thus keeping the current behavior with the only change that static libs are installed by "make install". Since the openvswitch library interfaces are internal and thus not stable (yet) encode the openvswitch version into the library name: libopenvswitch-2.0.90.so Binary size is reduced to around 1/3 when using shared libs. Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-12-13 18:54:28 +01:00
LT_INIT([disable-shared])
configure: Make autoconf fail if libtool is not installed. Otherwise users get an error later like: ./configure: line 5093: syntax error near unexpected token `disable-shared' ./configure: line 5093: `LT_INIT(disable-shared)' It's probably friendlier to make configuration fail earlier. Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-12-31 14:20:01 -08:00
m4_pattern_forbid([LT_INIT]) dnl Make autoconf fail if libtool is missing.
Build: Add support for shared libraries and versioning. These changes allow for the building of shared libraries by providing the --enable-shared option to configure. In particular, lib/libopenvwitch.so, lib/libsflow.so, ofproto/libofproto.so, and ovsdb/libovsdb.so will be built. Original behavior of building static remains the same. Additionally, versioning is introduced to each of the libraries objects paving the way for APIs to be built around them. A detailed comment outlining the rules for changing a version number is provided in configure.ac. Note that at this time, the version number is set to 1.0.0, no API is specified yet, and there are no requirements to maintain any sort of compatibility in any of the libraries. Signed-off-by: Scott Mann <smann@noironetworks.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2014-11-07 19:02:09 -08:00
# The following explanation may help to understand the use of the
# version number fields: current, revision, and age.
#
# Consider that there are three possible kinds of reactions from
# users of your library to changes in a shared library:
#
# 1. Programs using the previous version may use the new version as drop-in
# replacement, and programs using the new version can also work with the
# previous one. In other words, no recompiling nor relinking is needed.
# In short, there are no changes to any symbols, no symbols removed,
# and no symbols added. In this case, bump revision only, don't touch
# current nor age.
#
# 2. Programs using the previous version may use the new version as drop-in
# replacement, but programs using the new version may use APIs not
# present in the previous one. In other words, new symbols have been
# added and a program linking against the new version may fail with
configure.ac: Avoid using non-ascii characters in a comment Signed-off-by: YAMAMOTO Takashi <yamamoto@valinux.co.jp> Acked-by: Ben Pfaff <blp@nicira.com>
2015-04-17 16:03:14 +09:00
# "unresolved symbols." If linking against the old version at runtime:
Build: Add support for shared libraries and versioning. These changes allow for the building of shared libraries by providing the --enable-shared option to configure. In particular, lib/libopenvwitch.so, lib/libsflow.so, ofproto/libofproto.so, and ovsdb/libovsdb.so will be built. Original behavior of building static remains the same. Additionally, versioning is introduced to each of the libraries objects paving the way for APIs to be built around them. A detailed comment outlining the rules for changing a version number is provided in configure.ac. Note that at this time, the version number is set to 1.0.0, no API is specified yet, and there are no requirements to maintain any sort of compatibility in any of the libraries. Signed-off-by: Scott Mann <smann@noironetworks.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2014-11-07 19:02:09 -08:00
# set revision to 0, bump current and age.
#
# 3. Programs may need to be changed, recompiled, relinked in order to use
# the new version. This is the case when symbols have been modified or
# deleted. Bump current, set revision and age to 0.
configure: Reset libtool CURRENT version. Since commit f12e09b7b2e5 ("libopenvswitch: Rename to libfoo-X.Y."), the CURRENT libtool number is no longer derived from the OVS MINOR (from vMAJOR.MINOR.MICRO) version, so it can be reset to 0. Developers should attempt to avoid introducing ABI-breaking changes within a particular OVS-X.Y release series. Occasionally due to the nature of a particular bug, this is not possible. In such a case, developers must update the libtool CURRENT version to indicate this breakage to library users. In most OVS library releases, this is expected to remain 0. Signed-off-by: Joe Stringer <joe@ovn.org> Acked-by: Ben Pfaff <blp@ovn.org>
2017-04-21 13:33:55 -07:00
m4_define([libopenvswitch_lt_current], [0])
Build: Add support for shared libraries and versioning. These changes allow for the building of shared libraries by providing the --enable-shared option to configure. In particular, lib/libopenvwitch.so, lib/libsflow.so, ofproto/libofproto.so, and ovsdb/libovsdb.so will be built. Original behavior of building static remains the same. Additionally, versioning is introduced to each of the libraries objects paving the way for APIs to be built around them. A detailed comment outlining the rules for changing a version number is provided in configure.ac. Note that at this time, the version number is set to 1.0.0, no API is specified yet, and there are no requirements to maintain any sort of compatibility in any of the libraries. Signed-off-by: Scott Mann <smann@noironetworks.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2014-11-07 19:02:09 -08:00
m4_define([libopenvswitch_lt_revision], [0])
m4_define([libopenvswitch_lt_age], [0])
LT_CURRENT=libopenvswitch_lt_current
AC_SUBST([LT_CURRENT])
LT_REVISION=libopenvswitch_lt_revision
AC_SUBST([LT_REVISION])
LT_AGE=libopenvswitch_lt_age
AC_SUBST([LT_AGE])
Implement JSON parsing and serialization. This will be used by the upcoming Open vSwitch configuration database.
2009-11-04 14:55:53 -08:00
AC_SEARCH_LIBS([pow], [m])
timeval: Use monotonic time where appropriate. Most of the timekeeping needs of OVS are simply to measure intervals, which means that it is sensitive to changes in the clock. This commit replaces the existing clocks with monotonic timers. An additional set of wall clock timers are added and used in locations that need absolute time. Bug #1858
2010-06-08 17:18:48 -07:00
AC_SEARCH_LIBS([clock_gettime], [rt])
Fix build on FreeBSD. Patch below fixes build on FreeBSD; tested on 10.0-CURRENT. Signed-off-by: Edward Tomasz Napierala <trasz@FreeBSD.org> Signed-off-by: Ben Pfaff <blp@nicira.com>
2011-11-01 13:25:49 +01:00
AC_SEARCH_LIBS([timer_create], [rt])
configure: Check for more specific function to pull in pthread library. On my laptop, pthread_create() is always available without -lpthread, but when I use -fsanitize=address, -lpthread is required to pull in other threading functions such as pthread_rwlock_tryrdlock(). Thus, with -fsanitize=address I have to manually add -lpthread to link commands one way or another. This commit avoids that problem by checking for a function that is sometimes only available in -lpthread. Tested-by: Yifeng Sun <pkusunyifeng@gmail.com> Reviewed-by: Yifeng Sun <pkusunyifeng@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
2018-11-15 08:25:52 -08:00
AC_SEARCH_LIBS([pthread_rwlock_tryrdlock], [pthread])
configure.ac: More enhanced check for pthread library. FreeBSD 12 supports 'pthread_rwlock_tryrdlock' without 'pthread' library. Let's add check for more rare function. OTOH, Travis-CI environment supports 'pthread_rwlockattr_destroy', but does not support 'pthread_rwlock_tryrdlock' without 'pthread'. So, both checks needed. Signed-off-by: Ilya Maximets <i.maximets@samsung.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
2018-12-10 20:05:20 +03:00
AC_SEARCH_LIBS([pthread_rwlockattr_destroy], [pthread])
ovs-thread: Add pthread spin lock support. The patch adds the basic spin lock functions: ovs_spin_{lock, try_lock, unlock, init, destroy}. Signed-off-by: William Tu <u9012063@gmail.com> Acked-by: Ilya Maximets <i.maximets@samsung.com> Acked-by: Ben Pfaff <blp@ovn.org> Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
2019-07-17 13:23:33 -07:00
AC_SEARCH_LIBS([pthread_spin_lock], [pthread])
AC_CHECK_FUNCS([pthread_spin_lock])
New function ovs_strerror() as a thread-safe replacement for strerror(). Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-06-19 15:44:54 -07:00
AC_FUNC_STRERROR_R
Implement JSON parsing and serialization. This will be used by the upcoming Open vSwitch configuration database.
2009-11-04 14:55:53 -08:00
Add build system for compiling under MSVC x64 This patch adds the modifications needed to compile under x64 under Windows: - created a new macro for testing if we are compiling under x64. this will define the linker flag: "/MACHINE:X64" as per documentation (https://msdn.microsoft.com/en-us/library/9yb4317s.aspx). - added x64 pthread libraries under the pthread defines - add documentation on how to build under x64 Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
2015-09-23 17:30:32 +00:00
OVS_CHECK_WIN64
configure.ac: Identify when compiling on windows. Presence of windows.h will set the WIN32 variable. Signed-off-by: Gurucharan Shetty <gshetty@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
2013-11-16 11:42:46 -08:00
OVS_CHECK_WIN32
Add build of ovsext.sln using MSBuild This commit adds to the automake build system the full build required by the forwarding extension solution. It will help a lot in the future CI to check the full build of the project. To configure the forwarding extension to be built one could use the following: ./configure CC=./build-aux/cccl LD="`which link`" LIBS="-lws2_32" \ --prefix="C:/openvswitch/usr" --localstatedir="C:/openvswitch/var" \ --sysconfdir="C:/openvswitch/etc" --with-pthread="C:/pthread" \ --with-vstudioddk="Win8.1 Release" Documentation will be updated in another patch. Signed-off-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Saurabh Shah <ssaurabh@vmware.com>
2014-08-28 13:49:24 +00:00
OVS_CHECK_VISUAL_STUDIO_DDK
Add support for code coverage analysis with gcov and lcov.
2009-07-27 16:42:51 -07:00
OVS_CHECK_COVERAGE
Import from old repository commit 61ef2b42a9c4ba8e1600f15bb0236765edc2ad45.
2009-07-08 13:19:16 -07:00
OVS_CHECK_NDEBUG
OVS_CHECK_NETLINK
OVS_CHECK_OPENSSL
configure: add configuration options for libcap-ng Add configuration option for enabling or disabling linking with libcap-ng. Since capabilities are a security feature, the libcapng option is handled as follows: - no option: use libcapng if it's present --disable-libcapng: do not use libcapng --enable-libcapng: do use libcapng and fail configuration if it's missing On Linux, not linking with libcapng makes all OVS daemons fail when --user option is specified. Signed-off-by: Andy Zhou <azhou@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
2015-09-10 18:44:27 -07:00
OVS_CHECK_LIBCAPNG
Import from old repository commit 61ef2b42a9c4ba8e1600f15bb0236765edc2ad45.
2009-07-08 13:19:16 -07:00
OVS_CHECK_LOGDIR
configure: Check for presence of Python 3. The configure script already checked for Python 2 (>=2.7). Add another check for Python 3 (>=3.4). This will be used later for automatically running tests with Python 3 as well if available. Signed-off-by: Russell Bryant <russell@ovn.org> Acked-by: Ben Pfaff <blp@ovn.org>
2015-12-17 19:58:33 -05:00
OVS_CHECK_PYTHON3
python: Run flake8 at build time. If flake8 is installed, run it at build time. Similar to most Makefile targets, run it once and then only run again if the files change. flake8 is set to ignore all error and warning types that currently occur. Future patches will remove items from the ignore list as they are resolved. Signed-off-by: Russell Bryant <russell@ovn.org> Acked-by: Ben Pfaff <blp@ovn.org>
2015-12-21 20:24:34 -05:00
OVS_CHECK_FLAKE8
make: Check for Sphinx before checking docs Signed-off-by: Stephen Finucane <stephen@that.guru> Signed-off-by: Ben Pfaff <blp@ovn.org>
2017-01-02 11:47:40 +00:00
OVS_CHECK_SPHINX
docs: Only regenerate vswitch.pic when the schema really changes. Until now, vswitch.pic has been rebuilt whenever the schema changed. This is OK when the E-R diagram would really change, but many changes to the schema don't change the E-R diagram, and it surprises people when vswitch.pic changes in such a situation. This commit fixes the problem. Requested-by: Justin Pettit <jpettit@nicira.com>
2010-12-06 09:56:38 -08:00
OVS_CHECK_DOT
Route-table implementation for (Free)BSD This is a trivial implementation of the route-table functionality for FreeBSD, as needed by ofproto/ofproto-dpif-sflow.c. It has not yet been extensively tested. Signed-off-by: Ed Maste <emaste@freebsd.org> Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-06-29 21:11:24 +00:00
OVS_CHECK_IF_DL
Fix glibc 2.7 strtok_r() bug in a more permanent fashion. The glibc 2.7 headers contain a bug that causes strtok_r() to segfault in some circumstances. Until now, we have been working around this problem at each invocation, but this depends on the programmer to remember to do so each time. This commit instead adds a shim that adds a work-around to the string.h header itself, so that it is much more difficult to miss the workaround.
2009-06-10 14:16:40 -07:00
OVS_CHECK_STRTOK_R
netdev-afxdp: add new netdev type for AF_XDP. The patch introduces experimental AF_XDP support for OVS netdev. AF_XDP, the Address Family of the eXpress Data Path, is a new Linux socket type built upon the eBPF and XDP technology. It is aims to have comparable performance to DPDK but cooperate better with existing kernel's networking stack. An AF_XDP socket receives and sends packets from an eBPF/XDP program attached to the netdev, by-passing a couple of Linux kernel's subsystems As a result, AF_XDP socket shows much better performance than AF_PACKET For more details about AF_XDP, please see linux kernel's Documentation/networking/af_xdp.rst. Note that by default, this feature is not compiled in. Signed-off-by: William Tu <u9012063@gmail.com> Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
2019-07-18 13:11:14 -07:00
OVS_CHECK_LINUX_AF_XDP
signals: Use sys_siglist[] instead of strsignal() for thread-safety. strsignal() isn't thread-safe but sys_siglist[] is. Also, according to the glibc manual, BSD has sys_siglist[] but not strsignal(). Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-04-04 23:29:59 -05:00
AC_CHECK_DECLS([sys_siglist], [], [], [[#include <signal.h>]])
stream-ssl: Only re-read certificates and keys if they change. Commit 415f6c0b1 "stream-ssl: Make no-op reconfiguration cheap" caused ovsdb-server to re-read its certificates and keys every 60 seconds just in case they changed. However, doing this causes OpenSSL to drop its connections. This commit solves the problem by making stream-ssl re-read certificates and keys only if the files changed. Bug #2535. Reported-by: Ram Jothikumar <rjothikumar@nicira.com>
2010-03-24 13:15:41 -07:00
AC_CHECK_MEMBERS([struct stat.st_mtim.tv_nsec, struct stat.st_mtimensec],
[], [], [[#include <sys/stat.h>]])
add minimal NetBSD support mostly ride on the existing FreeBSD support. Signed-off-by: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-05-21 17:49:54 +09:00
AC_CHECK_MEMBERS([struct ifreq.ifr_flagshigh], [], [], [[#include <net/if.h>]])
socket-util: Support sendmmsg() regardless of platform. This will have its first user in an upcoming commit. Signed-off-by: Ben Pfaff <blp@ovn.org>
2017-07-12 17:38:33 -07:00
AC_CHECK_MEMBERS([struct mmsghdr.msg_len], [], [], [[#include <sys/socket.h>]])
Support IPv6 link-local address scopes on Linux. I hadn't even heard of this feature before, but it seems to be at least semi-standard to support Linux link-local address scopes via a % suffix, e.g. fe80::1234%eth0 for a link-local address scoped to eth0. This commit adds support. I'd appreciate feedback from folks who understand this feature better than me. Reported-by: Ali Volkan Atli <Volkan.Atli@argela.com.tr> Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Darrell Ball <dlu998@gmail.com> Tested-by: Numan Siddique <nusiddiq@redhat.com> Acked-by: Numan Siddique <nusiddiq@redhat.com>
2017-07-14 14:33:46 -07:00
AC_CHECK_MEMBERS([struct sockaddr_in6.sin6_scope_id], [], [],
[[#include <sys/socket.h>
sparse: Add guards to prevent FreeBSD-incompatible #include order. FreeBSD insists that <sys/types.h> be included before <netinet/in.h> and that <netinet/in.h> be included before <arpa/inet.h>. This adds guards to the "sparse" headers to yield a warning if this order is violated. This commit also adjusts the order of many #includes to suit this requirement. Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Justin Pettit <jpettit@ovn.org>
2017-11-06 14:42:32 -08:00
#include <sys/types.h>
Support IPv6 link-local address scopes on Linux. I hadn't even heard of this feature before, but it seems to be at least semi-standard to support Linux link-local address scopes via a % suffix, e.g. fe80::1234%eth0 for a link-local address scoped to eth0. This commit adds support. I'd appreciate feedback from folks who understand this feature better than me. Reported-by: Ali Volkan Atli <Volkan.Atli@argela.com.tr> Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Darrell Ball <dlu998@gmail.com> Tested-by: Numan Siddique <nusiddiq@redhat.com> Acked-by: Numan Siddique <nusiddiq@redhat.com>
2017-07-14 14:33:46 -07:00
#include <netinet/in.h>]])
timeval: Check for OS-provided clock_gettime on macOS [Problem] Compilation error on newer versions of macOS (Sierra onwards) due to multiple declarations of clock_gettime. [Solution] Have configure check for clock_gettime and check this result in timeval to avoid incorrectly declaring/defining clock_gettime again. [Testing] Source code now successfully builds on macOS. Signed-off-by: Richard Oliver <richard@richard-oliver.co.uk> Signed-off-by: Ben Pfaff <blp@ovn.org>
2017-10-28 16:38:30 +01:00
AC_CHECK_FUNCS([mlockall strnlen getloadavg statvfs getmntent_r sendmmsg clock_gettime])
netlink: provide network namespace id from a msg. The netlink notification's ancillary data contains the network namespace id (netnsid) needed to identify the device correctly. Signed-off-by: Flavio Leitner <fbl@redhat.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
2018-03-29 23:05:26 -03:00
AC_CHECK_HEADERS([mntent.h sys/statvfs.h linux/types.h linux/if_ether.h])
sparse: check if floatn-common.h is available. This skip including floatn-common.h if it's not available since it was introduced in glibc 2.27 and OVS doesn't not actually require that to work with previous glibc version. Fixes: 07aec2ac1 sparse: Support newer GCC/glibc versions. Signed-off-by: Flavio Leitner <fbl@sysclose.org> Signed-off-by: Ben Pfaff <blp@ovn.org>
2018-09-25 17:46:24 -03:00
AC_CHECK_HEADERS([linux/net_namespace.h stdatomic.h bits/floatn-common.h])
configure: Add if_mib.h prerequisites. Signed-off-by: Ed Maste <emaste@freebsd.org> Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-05-23 10:00:57 -04:00
AC_CHECK_HEADERS([net/if_mib.h], [], [], [[#include <sys/types.h>
#include <net/if.h>]])
Import from old repository commit 61ef2b42a9c4ba8e1600f15bb0236765edc2ad45.
2009-07-08 13:19:16 -07:00
Remove --disable-userspace "configure" option, since it breaks "make dist". I had thought that Automake was smart enough to ignore conditionals around EXTRA_DIST, so that all files always got distributed regardless of whether Automake conditionals were set. I was wrong. This commit removes the --disable-userspace option to "configure", which put a conditional around most of Makefile.am and thus unintentionally caused most of the distribution to be left out if --disable-userspace was specified. The alternative (fixing --disable-userspace) seems like too much work--it would require pushing "if ENABLE_USERSPACE" down into lots of subdirectory--and would be difficult to maintain.
2009-07-29 16:48:45 -07:00
OVS_CHECK_PKIDIR
OVS_CHECK_RUNDIR
Make the location of the database separately configurable. The default is unchanged, /etc/openvswitch/conf.db. This makes it possible to transition each Open vSwitch packaging from /etc/openvswitch/conf.db to /var/lib/openvswitch/conf.db independently. Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-27 15:52:21 -07:00
OVS_CHECK_DBDIR
backtrace: Make backtrace_capture() work on more systems. The backtrace_capture() implementation only worked properly with GNU C on systems that have a simple stack frame with a frame pointer. Notably, the x86-64 ABI by default has no frame pointer, so this failed on x86-64. However, glibc has a function named backtrace() that does what we want. This commit tests for this function and uses it when it is present, fixing x86-64 backtraces.
2011-05-13 11:55:22 -07:00
OVS_CHECK_BACKTRACE
autoconf: check for linux/perf_event.h Older Linux prior to version 2.6.32 do not support user mode performance events, They also don't have 'linux/perf_event.h' header file. Add check for those older Linux to conditionally compile perf-counter.c Reported-by: Alex Wang <alexw@nicira.com> Signed-off-by: Andy Zhou <azhou@nicira.com> Acked-by: Alex Wang <alexw@nicira.com>
2015-04-16 12:52:09 -07:00
OVS_CHECK_PERF_EVENT
Remove --disable-userspace "configure" option, since it breaks "make dist". I had thought that Automake was smart enough to ignore conditionals around EXTRA_DIST, so that all files always got distributed regardless of whether Automake conditionals were set. I was wrong. This commit removes the --disable-userspace option to "configure", which put a conditional around most of Makefile.am and thus unintentionally caused most of the distribution to be left out if --disable-userspace was specified. The alternative (fixing --disable-userspace) seems like too much work--it would require pushing "if ENABLE_USERSPACE" down into lots of subdirectory--and would be difficult to maintain.
2009-07-29 16:48:45 -07:00
OVS_CHECK_VALGRIND
OVS_CHECK_SOCKET_LIBS
configure: Reject incompatible XenServer version. Suggested-by: Andrew Evans <aevans@nicira.com>
2011-02-22 14:47:19 -08:00
OVS_CHECK_XENSERVER_VERSION
docs: Add Makefile rule to check syntax of manpages. This should catch future nroff syntax errors immediately, instead of much later.
2011-08-24 10:45:32 -07:00
OVS_CHECK_GROFF
ovs-thread: Add per-thread data support. POSIX defines a portable pthread_key_t API for per-thread data. GCC and C11 have two different forms of per-thread data that are generally faster than the POSIX API, where they are available. This commit adds a macro-based wrapper, DEFINE_PER_THREAD_DATA, that takes advantage of these features where they are available and falls back to the POSIX API otherwise. The Clang compiler implements C11 thread_local in its <threads.h>. This commit also adds a convenience wrapper for the POSIX API, via the DEFINE_PER_THREAD_MALLOCED_DATA macro. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
2013-06-25 13:50:26 -07:00
OVS_CHECK_TLS
Add check for -latomic Later versions of gcc on some architectures push atomic functions out into a separate atomic library; add a check to see when this is required and add it to LIBS if need be. Specifically the problem was observed on GCC 4.8.2 on powerpc architecture for Ubuntu 14.04: https://launchpadlibrarian.net/155235096/buildlog_ubuntu-trusty-powerpc.openvswitch_2.0.0-0ubuntu1_FAILEDTOBUILD.txt.gz Signed-off-by: James Page <james.page@ubuntu.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-12-05 17:29:05 +00:00
OVS_CHECK_ATOMIC_LIBS
configure: Add configure-time check for GCC 4.0+ atomic built-ins. We found out earlier that GCC sometimes produces an error only at link time for atomic built-ins that are not supported on a platform. This actually tries the link at configure time and should thus reliably detect whether the atomic built-ins are really supported. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
2013-07-15 14:13:53 -07:00
OVS_CHECK_GCC4_ATOMICS
ovs-atomic: New library for atomic operations. This library should prove useful for the threading changes coming up. The following commit introduces one (very simple) user. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
2013-06-28 15:54:40 -07:00
OVS_CHECK_ATOMIC_ALWAYS_LOCK_FREE(1)
OVS_CHECK_ATOMIC_ALWAYS_LOCK_FREE(2)
OVS_CHECK_ATOMIC_ALWAYS_LOCK_FREE(4)
OVS_CHECK_ATOMIC_ALWAYS_LOCK_FREE(8)
async-append: New library to allow asynchronous appending to a log file. This will be hooked into the vlog library in an upcoming commit. Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-07-10 11:40:28 -07:00
OVS_CHECK_POSIX_AIO
configure: Distinguish glibc and NetBSD pthread_setname_np() variants. Reported-by: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp> Tested-by: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp> Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-08-01 09:35:56 -07:00
OVS_CHECK_PTHREAD_SET_NAME
Makefile: Compile Linux-specific files based on __linux__ macro. We want to conditionally compile several files based on whether we're building for a Linux host, so we need some Automake conditional for that. Previously this was based on whether Netlink is available and we're not on ESX (since ESX has Netlink but isn't Linux), but it's more straightforward to just test for Linux directly. CC: Luigi Rizzo <rizzo@iet.unipi.it> Signed-off-by: Ben Pfaff <blp@nicira.com>
2014-01-23 15:35:22 -08:00
OVS_CHECK_LINUX_HOST
libX: add new release / version info tags This commit uses the $PACKAGE_VERSION automake variable to construct a release and version info combination which sets the library name to be: libfoo-$(OVS_MAJOR_VERSION).so.$(OVS_MINOR_VERSION).0.$(OVS_MICRO_VERSION) where formerly, it was always: libfoo.so.1.0.0 This allows releases of Open vSwitch libraries to reflect which specific versions they came with, and sets up a psuedo ABI-versioning scheme. In this fashion, future releases of Open vSwitch could be installed alongside older releases, allowing 3rd party utilities linked against previous versions to continue to function. ex: $ ldd /path/to/utility linux-vdso.so.1 (0x00007ffe92cf6000) libopenvswitch-2.so.6 => /lib64/libopenvswitch-2.so.6 (0x00007f733b7a3000) libssl.so.10 => /lib64/libssl.so.10 (0x00007f733b530000) ... Note the library name and version information. Signed-off-by: Aaron Conole <aconole@redhat.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
2017-01-16 14:06:27 -05:00
OVS_LIBTOOL_VERSIONS
Automatically verify that OVS header files work OK in C++ also. This should help address a recurring problem. This change makes the OVS header files, when parsed by a C++ compiler, require C++11 or later. Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Russell Bryant <russell@ovn.org>
2017-07-31 13:31:43 -07:00
OVS_CHECK_CXX
util: Use posix_memalign for xmalloc_cacheline if available A malloc library is expected to provide a better implementation using the knowledge of its internal details. ax_func_posix_memalign.m4 was obtained from: http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob_plain;f=m4/ax_func_posix_memalign.m4 Acked-by: Ben Pfaff <blp@nicira.com> Signed-off-by: YAMAMOTO Takashi <yamamoto@valinux.co.jp>
2014-05-02 17:07:29 +09:00
AX_FUNC_POSIX_MEMALIGN
DNS: Add basic support for asynchronous DNS resolving This patch is a simple implementation for the proposal discussed in https://mail.openvswitch.org/pipermail/ovs-dev/2017-August/337038.html and https://mail.openvswitch.org/pipermail/ovs-dev/2017-October/340013.html. It enables ovs-vswitchd and other utilities to use DNS names when specifying OpenFlow and OVSDB remotes. Below are some of the features and limitations of this patch: - Resolving is asynchornous in daemon context, avoiding blocking main loop; - Resolving is synchronous in general utility context; - Both IPv4 and IPv6 are supported; - The resolving API is thread-safe; - Depends on the unbound library; - When multiple ip addresses are returned, only the first one is used; - /etc/nsswitch.conf isn't respected as unbound library doesn't look at it; - For async-resolving, caller need to retry later; there is no callback. Signed-off-by: Yifeng Sun <pkusunyifeng@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
2018-06-26 14:06:21 -07:00
OVS_CHECK_UNBOUND
fatal-signal: Catch SIGSEGV and print backtrace. The patch catches the SIGSEGV signal and prints the backtrace using libunwind at the monitor daemon. This makes debugging easier when there is no debug symbol package or gdb installed on production systems. The patch works when the ovs-vswitchd compiles even without debug symbol (no -g option), because the object files still have function symbols. For example: |daemon_unix(monitor)|WARN|SIGSEGV detected, backtrace: |daemon_unix(monitor)|WARN|0x0000000000482752 <fatal_signal_handler+0x52> |daemon_unix(monitor)|WARN|0x00007fb4900734b0 <killpg+0x40> |daemon_unix(monitor)|WARN|0x00007fb49013974d <__poll+0x2d> |daemon_unix(monitor)|WARN|0x000000000052b348 <time_poll+0x108> |daemon_unix(monitor)|WARN|0x00000000005153ec <poll_block+0x8c> |daemon_unix(monitor)|WARN|0x000000000058630a <clean_thread_main+0x1aa> |daemon_unix(monitor)|WARN|0x00000000004ffd1d <ovsthread_wrapper+0x7d> |daemon_unix(monitor)|WARN|0x00007fb490b3b6ba <start_thread+0xca> |daemon_unix(monitor)|WARN|0x00007fb49014541d <clone+0x6d> |daemon_unix(monitor)|ERR|1 crashes: pid 122849 died, killed \ (Segmentation fault), core dumped, restarting However, if the object files' symbols are stripped, then we can only get init function plus offset value. This is still useful when trying to see if two bugs have the same root cause, Example: |daemon_unix(monitor)|WARN|SIGSEGV detected, backtrace: |daemon_unix(monitor)|WARN|0x0000000000482752 <_init+0x7d68a> |daemon_unix(monitor)|WARN|0x00007f5f7c8cf4b0 <killpg+0x40> |daemon_unix(monitor)|WARN|0x00007f5f7c99574d <__poll+0x2d> |daemon_unix(monitor)|WARN|0x000000000052b348 <_init+0x126280> |daemon_unix(monitor)|WARN|0x00000000005153ec <_init+0x110324> |daemon_unix(monitor)|WARN|0x0000000000407439 <_init+0x2371> |daemon_unix(monitor)|WARN|0x00007f5f7c8ba830 <__libc_start_main+0xf0> |daemon_unix(monitor)|WARN|0x0000000000408329 <_init+0x3261> |daemon_unix(monitor)|ERR|1 crashes: pid 106155 died, killed \ (Segmentation fault), core dumped, restarting Most C library functions are not async-signal-safe, meaning that it is not safe to call them from a signal handler, for example printf() or fflush(). To be async-signal-safe, the handler only collects the stack info using libunwind, which is signal-safe, and issues 'write' to the pipe, where the monitor thread reads and prints to ovs-vswitchd.log. Tested-at: https://travis-ci.org/williamtu/ovs-travis/builds/590503433 Signed-off-by: William Tu <u9012063@gmail.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
2019-09-27 10:22:55 -07:00
OVS_CHECK_UNWIND
Import from old repository commit 61ef2b42a9c4ba8e1600f15bb0236765edc2ad45.
2009-07-08 13:19:16 -07:00
stdio: New module, initially to provide working [v]snprintf() on Windows. This should transparently define snprintf() and vsnprintf() wrappers for use on Windows. CC: Saurabh Shah <ssaurabh@vmware.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-12-24 09:18:42 -08:00
OVS_CHECK_INCLUDE_NEXT([stdio.h string.h])
Build: Add support for shared libraries and versioning. These changes allow for the building of shared libraries by providing the --enable-shared option to configure. In particular, lib/libopenvwitch.so, lib/libsflow.so, ofproto/libofproto.so, and ovsdb/libovsdb.so will be built. Original behavior of building static remains the same. Additionally, versioning is introduced to each of the libraries objects paving the way for APIs to be built around them. A detailed comment outlining the rules for changing a version number is provided in configure.ac. Note that at this time, the version number is set to 1.0.0, no API is specified yet, and there are no requirements to maintain any sort of compatibility in any of the libraries. Signed-off-by: Scott Mann <smann@noironetworks.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2014-11-07 19:02:09 -08:00
AC_CONFIG_FILES([
lib/stdio.h
lib/string.h
ovsdb/libovsdb.sym
ofproto/libofproto.sym
lib/libsflow.sym
vtep: fix '--enable-shared' build and 'make distcheck'. Found by travis. Broken by commit 9d8215698 ('vtep: Move vtep IDL files into new "libvtep.la".') Signed-off-by: Daniele Di Proietto <diproiettod@vmware.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2015-03-09 13:52:08 +00:00
lib/libopenvswitch.sym
vtep/libvtep.sym])
string: Use workaround for #include_next when it is not available. Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-12-13 09:54:55 -08:00
Remove --disable-userspace "configure" option, since it breaks "make dist". I had thought that Automake was smart enough to ignore conditionals around EXTRA_DIST, so that all files always got distributed regardless of whether Automake conditionals were set. I was wrong. This commit removes the --disable-userspace option to "configure", which put a conditional around most of Makefile.am and thus unintentionally caused most of the distribution to be left out if --disable-userspace was specified. The alternative (fixing --disable-userspace) seems like too much work--it would require pushing "if ENABLE_USERSPACE" down into lots of subdirectory--and would be difficult to maintain.
2009-07-29 16:48:45 -07:00
OVS_ENABLE_OPTION([-Wall])
configure: Remove -Wno-override-init, add -Wextra to compile options. The build is clean against -Wextra at least with GCC 4.4. (-Wextra includes -Woverride-init.) Suggested-by: Alex Wang <alexw@nicira.com> Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
2013-07-22 13:38:25 -07:00
OVS_ENABLE_OPTION([-Wextra])
Remove --disable-userspace "configure" option, since it breaks "make dist". I had thought that Automake was smart enough to ignore conditionals around EXTRA_DIST, so that all files always got distributed regardless of whether Automake conditionals were set. I was wrong. This commit removes the --disable-userspace option to "configure", which put a conditional around most of Makefile.am and thus unintentionally caused most of the distribution to be left out if --disable-userspace was specified. The alternative (fixing --disable-userspace) seems like too much work--it would require pushing "if ENABLE_USERSPACE" down into lots of subdirectory--and would be difficult to maintain.
2009-07-29 16:48:45 -07:00
OVS_ENABLE_OPTION([-Wno-sign-compare])
OVS_ENABLE_OPTION([-Wpointer-arith])
configure: Use -Wformat-security with -Wformat. GCC 6.1 warns that -Wformat-security has no effect without -Wformat, so this commit fixes the problem. The change to _OVS_CHECK_CC_OPTION is needed so that the cache variable name doesn't end up with a space in it, which obviously doesn't work. Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Andy Zhou <azhou@ovn.org>
2016-12-05 14:28:59 -08:00
OVS_ENABLE_OPTION([-Wformat -Wformat-security])
Remove --disable-userspace "configure" option, since it breaks "make dist". I had thought that Automake was smart enough to ignore conditionals around EXTRA_DIST, so that all files always got distributed regardless of whether Automake conditionals were set. I was wrong. This commit removes the --disable-userspace option to "configure", which put a conditional around most of Makefile.am and thus unintentionally caused most of the distribution to be left out if --disable-userspace was specified. The alternative (fixing --disable-userspace) seems like too much work--it would require pushing "if ENABLE_USERSPACE" down into lots of subdirectory--and would be difficult to maintain.
2009-07-29 16:48:45 -07:00
OVS_ENABLE_OPTION([-Wswitch-enum])
OVS_ENABLE_OPTION([-Wunused-parameter])
OVS_ENABLE_OPTION([-Wbad-function-cast])
OVS_ENABLE_OPTION([-Wcast-align])
OVS_ENABLE_OPTION([-Wstrict-prototypes])
OVS_ENABLE_OPTION([-Wold-style-definition])
OVS_ENABLE_OPTION([-Wmissing-prototypes])
OVS_ENABLE_OPTION([-Wmissing-field-initializers])
clang: Add annotations for thread safety check. This commit adds annotations for thread safety check. And the check can be conducted by using -Wthread-safety flag in clang. Co-authored-by: Alex Wang <alexw@nicira.com> Signed-off-by: Alex Wang <alexw@nicira.com> Signed-off-by: Ethan Jackson <ethan@nicira.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2013-07-30 15:31:48 -07:00
OVS_ENABLE_OPTION([-Wthread-safety])
configure: Disable strict aliasing. The C standard allows compilers to do type-based alias analysis, which means that the compiler is allowed to assume that pointers to objects of different types are pointers to different objects. For example, a compiler may assume that "uint16_t *a" and "uint32_t *b" point to different and nonoverlapping locations because the pointed-to types are different. This can lead to surprising "optimizations" with compilers that by default do this kind of analysis, which includes GCC and Clang. The one escape clause that the C standard gives us is that character types must be assumed to alias any other object. We've always tried to use this escape clause to avoid problems with type-based alias analysis in the past. I think that we should continue to try to do this in the future. It's hard to tell what compiler we might want to use in the future, and one never knows what kind of control that compiler allows over alias analysis. However, recently I helped another developer debug a nasty and confusing issue, which turned out to be the result of a surprising compiler optimization due to alias analysis. I've seen enough of these that I don't think it's worthwhile to risk more problems than we have to. Thus, this commit turns off type-based alias analysis in GCC and Clang. Linus Torvalds thinks that type-base alias analysis is not sane, at least as GCC implements it: https://lkml.org/lkml/2003/2/26/158 The GCC manual says that -Wstrict-aliasing is only effective without -fno-strict-aliasing, otherwise I'd keep -Wstrict-aliasing also. Indications are that MSVC doesn't do type-based alias analysis by default. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-09-30 17:03:07 -07:00
OVS_ENABLE_OPTION([-fno-strict-aliasing])
configure: Enable new warning options added in GCC 5. Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Andy Zhou <azhou@ovn.org>
2016-12-05 14:29:24 -08:00
OVS_ENABLE_OPTION([-Wswitch-bool])
OVS_ENABLE_OPTION([-Wlogical-not-parentheses])
OVS_ENABLE_OPTION([-Wsizeof-array-argument])
OVS_ENABLE_OPTION([-Wbool-compare])
configure: Enable new warning options added in GCC 6. -Wnull-dereference is also new in GCC 6 but upon testing it produces far too many false positives to be usable for OVS. Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Andy Zhou <azhou@ovn.org>
2016-12-05 14:38:08 -08:00
OVS_ENABLE_OPTION([-Wshift-negative-value])
OVS_ENABLE_OPTION([-Wduplicated-cond])
configure: Fix -Werror build for NetBSD + clang On NetBSD, clang (clang-3.5.0 from pkgsrc) complains when "clang -g" is used for linking. Specify -Qunused-arguments to suppress the warning. Signed-off-by: YAMAMOTO Takashi <yamamoto@valinux.co.jp> Acked-by: Ben Pfaff <blp@nicira.com>
2015-04-17 17:14:38 +09:00
OVS_ENABLE_OPTION([-Qunused-arguments])
Add -Wshadow for compilers that support it. Signed-off-by: Justin Pettit <jpettit@ovn.org> Acked-by: Ben Pfaff <blp@ovn.org>
2018-02-27 14:14:12 -08:00
OVS_ENABLE_OPTION([-Wshadow])
configure: Enable GCC relevant new 8.x warning options. These don't trigger any new actual warnings in my own build. GCC 8.x adds other new warning options that are enabled by -Wall or -Wextra. This commit doesn't explicitly enable those because OVS already enables -Wall and -Wextra. Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Aaron Conole <aconole@bytheb.org>
2018-06-14 14:49:23 -07:00
OVS_ENABLE_OPTION([-Wmultistatement-macros])
OVS_ENABLE_OPTION([-Wcast-align=strict])
configure: Disable -Wnull-pointer-arithmetic Clang warning. OVS trips over this warning all over the place, so it's not worth leaving on. Signed-off-by: Ben Pfaff <blp@ovn.org> Reviewed-by: Yifeng Sun <pkusunyifeng@gmail.com>
2018-07-09 14:37:55 -07:00
OVS_ENABLE_OPTION([-Wno-null-pointer-arithmetic])
netdev: Clean up class initialization. The macros are hard to read. This makes it a little more readable. Signed-off-by: Ben Pfaff <blp@ovn.org> Signed-off-by: Ian Stokes <ian.stokes@intel.com>
2018-08-15 10:38:09 -07:00
OVS_ENABLE_OPTION([-Warray-bounds-pointer-arithmetic])
Add InMon's sFlow Agent library to the build system. The C source and header files added in this commit is covered under the InMon sFlow license at http://www.inmon.com/technology/sflowlicense.txt The library requires -Wno-unused to compile without warnings, so this commit adds that for building the sFlow code only. Automake can only change compiler flags on a per-library or per-program basis, so sFlow is built as a separate library. The library will be used in upcoming commits.
2009-11-20 09:45:26 -08:00
OVS_CONDITIONAL_CC_OPTION([-Wno-unused], [HAVE_WNO_UNUSED])
sflow: Avoid "unused parameter" warnings from GCC 4.4. With GCC -Wno-unused by itself isn't enough to avoid "unused parameter" warnings, since we also use -Wunused-parameter. We also need to check for and use -Wno-unused-parameter.
2010-07-30 14:47:29 -07:00
OVS_CONDITIONAL_CC_OPTION([-Wno-unused-parameter], [HAVE_WNO_UNUSED_PARAMETER])
configure: Add option --enable-Werror to add -Werror to CFLAGS. -Werror is useful for development, but it screws up configure because it's impossible to guess what new warnings compilers will add in the future. This commit adds a new configure option to add CFLAGS after the configure checks are done. The use of AC_CONFIG_COMMANDS_PRE is based on Eric Blake's suggestion on the autoconf mailing list: "AC_CONFIG_COMMANDS_PRE probably fits the bill as the ideal macro to use for guaranteeing that you inject your shell code at the last possible moment." Requested-by: Andrew Evans <aevans@nicira.com>
2011-04-12 11:43:11 -07:00
OVS_ENABLE_WERROR
configure: Run sparse automatically if C=1 specified on "make" command. The C=1 convention matches the kernel's convention, so running "make C=1" will now get sparse results for both userspace and kernel compiles.
2011-05-06 13:00:49 -07:00
OVS_ENABLE_SPARSE
ctags: include symbols with locking annotations. OVS uses extensively clang annotations for thread safety checks. The ctags tool can't parse them, so they are not included in the tag file. This patch improves the configure script to generate a list of identifiers from the header compiler.h to be ignored by ctags. Signed-off-by: Flavio Leitner <fbl@redhat.com> Signed-off-by: Ben Pfaff <blp@ovn.org> Reviewed-by: Aaron Conole <aconole@redhat.com>
2017-06-26 21:55:50 -03:00
OVS_CTAGS_IDENTIFIERS
dpif-netdev: implement subtable lookup validation. This commit refactors the existing dpif subtable function pointer infrastructure, and implements an autovalidator component. The refactoring of the existing dpcls subtable lookup function handling, making it more generic, and cleaning up how to enable more implementations in future. In order to ensure all implementations provide identical results, the autovalidator is added. The autovalidator itself implements the subtable lookup function prototype, but internally iterates over all other available implementations. The end result is that testing of each implementation becomes automatic, when the auto- validator implementation is selected. Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com> Acked-by: William Tu <u9012063@gmail.com> Signed-off-by: Ian Stokes <ian.stokes@intel.com>
2020-07-13 13:42:10 +01:00
OVS_CHECK_DPCLS_AUTOVALIDATOR
Import from old repository commit 61ef2b42a9c4ba8e1600f15bb0236765edc2ad45.
2009-07-08 13:19:16 -07:00
AC_ARG_VAR(KARCH, [Kernel Architecture String])
AC_SUBST(KARCH)
configure: Remove "26" from Linux variable names. OVS used to support Linux 2.4 and Linux 2.6, but now it only supports Linux 2.6. Linux 3.0 is coming up, and it's just an evolution of 2.6, so OVS should stop referring to it as "2.6". This takes a first step by removing "26" from internal variable names. There should be no user-visible changes.
2011-06-22 09:26:31 -07:00
OVS_CHECK_LINUX
tc: Set 'no_percpu' flag for compatible actions Recent changes in Linux kernel TC action subsystem introduced new TCA_ACT_FLAGS_NO_PERCPU_STATS flag. The purpose of the flag is to request action implementation to skip allocating action stats with expensive percpu allocator and use regular built-in action stats instead. Such approach significantly improves rule insertion rate and reduce memory usage for hardware-offloaded rules that don't need benefits provided by percpu allocated stats (improved software TC fast-path performance). Set the flag for all compatible actions. Modify acinclude.m4 to use OVS-internal pkt_cls.h implementation when TCA_ACT_FLAGS is not defined by kernel headers and to manually define struct nla_bitfield32 in netlink.h (new file) when it is not defined by kernel headers. Signed-off-by: Vlad Buslov <vladbu@mellanox.com> Reviewed-by: Roi Dayan <roid@mellanox.com> Signed-off-by: Simon Horman <simon.horman@netronome.com>
2019-11-04 18:34:49 +02:00
OVS_CHECK_LINUX_NETLINK
compat: Add tc compatibility headers for old kernels Added compatibility headers for actions vlan and tunnel key. Do not use compat code when compiling kernel datapath there is no need for it as TC compatibility is not provided there. In other words, the compat code is only used when compiling user-space code against old kernel headers. Signed-off-by: Paul Blakey <paulb@mellanox.com> Reviewed-by: Roi Dayan <roid@mellanox.com> Acked-by: Flavio Leitner <fbl@sysclose.org> Signed-off-by: Simon Horman <simon.horman@netronome.com>
2017-05-28 14:59:45 +03:00
OVS_CHECK_LINUX_TC
compat: add SCTP netfilter states for older kernels Bake in the SCTP states from the kernel UAPI. This means an older revision of the kernel headers won't interfere with the SCTP display enhancement. Additionally, if a newer version is available, or if x-compiling the datapath module we defer to that version (since this is just meant to provide the missing definitions). This will be used in a future commit. Signed-off-by: Aaron Conole <aconole@redhat.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
2019-05-21 14:16:30 -04:00
OVS_CHECK_LINUX_SCTP_CT
netdev-linux: Fix broken build on Ubuntu 14.04 Patch 29cf9c1b3b9c ("userspace: Add TCP Segmentation Offload support") uses __virtio16 which is defined in kernel 3.19. Ubuntu 14.04 is using 3.13 kernel that lacks the virtio_types definition. This patch fixes that. Fixes: 29cf9c1b3b9c ("userspace: Add TCP Segmentation Offload support") Acked-by: Greg Rose <gvrose8192@gmail.com> Signed-off-by: Yi-Hung Wei <yihung.wei@gmail.com> Signed-off-by: William Tu <u9012063@gmail.com>
2020-07-07 15:59:49 -07:00
OVS_CHECK_LINUX_VIRTIO_TYPES
dpif-netdev: Add DPDK netdev. Following patch adds DPDK netdev-class to userspace datapath. Now OVS can use DPDK port for IO by just configuring DPDK port and then adding dpdk type port to userspace datapath. Refer to INSTALL.DPDK doc for further info. This is based a patch from Gerald Rogers. Signed-off-by: Gerald Rogers <gerald.rogers@intel.com> Signed-off-by: Pravin B Shelar <pshelar@nicira.com> Acked-by: Thomas Graf <tgraf@redhat.com>
2014-03-24 19:23:08 -07:00
OVS_CHECK_DPDK
Add BUILD_MESSAGE() macro This commit introduces the BUILD_MESSAGE() macro. It uses _Pragma("message"), with compilers that support that, to output a warning-like compile-time message without blocking the compilation. Used by next commit. Signed-off-by: Daniele Di Proietto <ddiproietto@vmware.com> Acked-by: Jarno Rajahalme <jrajahalme@nicira.com>
2014-08-29 16:08:11 -07:00
OVS_CHECK_PRAGMA_MESSAGE
build: Respect CFLAGS and LDFLAGS passed to make configure cannot expect that the user will not pass additional CFLAGS and LDFLAGS at make time [0]. Use OVS_CFLAGS and OVS_LDFLAGS instead to collect compiler and linker flags and substitute in Makefile.am. This allows for: ./configure --with-dpdk=[...] make CFLAGS=-Wno-error=foo [0] http://www.gnu.org/software/automake/manual/html_node/Flag-Variables-Ordering.html Signed-off-by: Thomas Graf <tgraf@noironetworks.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2014-09-11 21:34:21 +02:00
AC_SUBST([OVS_CFLAGS])
AC_SUBST([OVS_LDFLAGS])
Import from old repository commit 61ef2b42a9c4ba8e1600f15bb0236765edc2ad45.
2009-07-08 13:19:16 -07:00
configure.ac: Make autoconf in Mingw happy. Autoconf version 2.68 in Mingw environment does not like the new lines in AC_CONFIG_FILES macro. Signed-off-by: Gurucharan Shetty <gshetty@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com>
2013-11-15 15:32:09 -08:00
AC_CONFIG_FILES(Makefile)
AC_CONFIG_FILES(datapath/Makefile)
AC_CONFIG_FILES(datapath/linux/Kbuild)
AC_CONFIG_FILES(datapath/linux/Makefile)
AC_CONFIG_FILES(datapath/linux/Makefile.main)
AC_CONFIG_FILES(tests/atlocal)
lib: Add support for pkgconfig for libopenvswitch. Add rule to generate pkgconfig .pc file from configure. Install pkg-config file to $(libdir)/pkgconfig Signed-off-by: Rob Adams <readams@readams.net> Acked-by: Flavio Leitner <fbl@redhat.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2014-11-13 12:28:41 +01:00
AC_CONFIG_FILES(lib/libopenvswitch.pc)
lib: Add support for pkgconfig for libsflow. Signed-off-by: Thomas Graf <tgraf@noironetworks.com> Acked-by: Flavio Leitner <fbl@redhat.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2014-11-13 12:28:44 +01:00
AC_CONFIG_FILES(lib/libsflow.pc)
lib: Add support for pkgconfig for libofproto. Signed-off-by: Thomas Graf <tgraf@noironetworks.com> Acked-by: Flavio Leitner <fbl@redhat.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2014-11-13 12:28:42 +01:00
AC_CONFIG_FILES(ofproto/libofproto.pc)
lib: Add support for pkgconfig for libovsdb. Signed-off-by: Thomas Graf <tgraf@noironetworks.com> Acked-by: Flavio Leitner <fbl@redhat.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2014-11-13 12:28:43 +01:00
AC_CONFIG_FILES(ovsdb/libovsdb.pc)
lib: Add new header <openvswitch/version.h> to versioning info Exposes the package version as string and the library versioning as numeric macro. OVS_LIB_VERSION may be used to check for a particular version of the interface. OVS_LIB_REVISION and OVS_LIB_AGE exist to map a set of installed headers to a particular shared library instance. Signed-off-by: Thomas Graf <tgraf@noironetworks.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2014-11-24 12:49:00 +01:00
AC_CONFIG_FILES(include/openvswitch/version.h)
Import from old repository commit 61ef2b42a9c4ba8e1600f15bb0236765edc2ad45.
2009-07-08 13:19:16 -07:00
Add build checks for portable OpenFlow structure padding and alignment. This causes the build to fail with an error message if openflow.h contains a structure whose members are not aligned in a portable way.
2010-01-25 10:49:31 -08:00
dnl This makes sure that include/openflow gets created in the build directory.
AC_CONFIG_COMMANDS([include/openflow/openflow.h.stamp])
ovs-bugtool: Add plugins previously used only under XenServer. All of the xen-bugtool plugins that OVS has previously installed only under XenServer are equally useful with Debian and other distributions, so this commit installs and uses them everywhere.
2011-07-06 10:43:03 -07:00
AC_CONFIG_COMMANDS([utilities/bugtool/dummy], [:])
ipsec: Use @PYTHON@ directly instead of "/usr/bin/env python" Using "/usr/bin/env" is against Fedora Packaging Guidelines [1]. Moreover, in this specific case, it also prevent "make rpm-fedora" to successfully complete on "Fedora Rawhide" since "#!/usr/bin/env python" must not be used anymore [2]. [1] https://fedoraproject.org/wiki/Packaging:Guidelines#Shebang_lines [2] https://fedoraproject.org/wiki/Changes/Make_ambiguous_python_shebangs_error CC: Qiuyu Xiao <qiuyu.xiao.qyx@gmail.com> Fixes: 22c5eafb6efa ("ipsec: reintroduce IPsec support for tunneling") Signed-off-by: Timothy Redaelli <tredaelli@redhat.com> Signed-off-by: Ben Pfaff <blp@ovn.org>
2018-11-10 16:29:07 +01:00
AC_CONFIG_COMMANDS([ipsec/dummy], [:])
Add ovsdbmonitor GUI tool by Andy Southgate, contributed by Citrix. With Makefiles and Autoconfiscation by Ben Pfaff. Signed-off-by: Thomas Lacroix <thomas.lacroix@citrix.com> Signed-off-by: Ben Pfaff <blp@nicira.com>
2010-05-11 11:46:52 -07:00
configure: Enable silent rules. Configure has an option which supports quieter compilation. Signed-off-by: Ethan Jackson <ethan@nicira.com> Acked-by: Ben Pfaff <blp@nicira.com> Acked-by: Joe Stringer <joestringer@nicira.com>
2014-01-21 16:22:08 -08:00
m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES])
Import from old repository commit 61ef2b42a9c4ba8e1600f15bb0236765edc2ad45.
2009-07-08 13:19:16 -07:00
AC_OUTPUT
Reference in New Issue Copy Permalink