2009-07-08 13:19:16 -07:00
|
|
|
|
/*
|
2011-01-23 18:48:02 -08:00
|
|
|
|
* Copyright (c) 2008, 2009, 2010, 2011 Nicira Networks.
|
2009-07-08 13:19:16 -07:00
|
|
|
|
*
|
2009-06-15 15:11:30 -07:00
|
|
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
|
* you may not use this file except in compliance with the License.
|
|
|
|
|
* You may obtain a copy of the License at:
|
2009-07-08 13:19:16 -07:00
|
|
|
|
*
|
2009-06-15 15:11:30 -07:00
|
|
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
|
*
|
|
|
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
|
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
|
* See the License for the specific language governing permissions and
|
|
|
|
|
* limitations under the License.
|
2009-07-08 13:19:16 -07:00
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#include <config.h>
|
2009-06-17 14:35:35 -07:00
|
|
|
|
#include "dpif-provider.h"
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
|
|
|
|
#include <assert.h>
|
|
|
|
|
#include <ctype.h>
|
|
|
|
|
#include <errno.h>
|
|
|
|
|
#include <inttypes.h>
|
|
|
|
|
#include <stdlib.h>
|
|
|
|
|
#include <string.h>
|
|
|
|
|
|
|
|
|
|
#include "coverage.h"
|
|
|
|
|
#include "dynamic-string.h"
|
|
|
|
|
#include "flow.h"
|
2010-12-03 14:41:38 -08:00
|
|
|
|
#include "netdev.h"
|
2009-07-08 13:19:16 -07:00
|
|
|
|
#include "netlink.h"
|
|
|
|
|
#include "odp-util.h"
|
|
|
|
|
#include "ofp-print.h"
|
2010-10-19 09:55:40 -07:00
|
|
|
|
#include "ofp-util.h"
|
2009-07-08 13:19:16 -07:00
|
|
|
|
#include "ofpbuf.h"
|
|
|
|
|
#include "packets.h"
|
|
|
|
|
#include "poll-loop.h"
|
2010-02-01 11:36:01 -05:00
|
|
|
|
#include "shash.h"
|
2009-07-06 11:06:36 -07:00
|
|
|
|
#include "svec.h"
|
2011-01-26 07:11:50 -08:00
|
|
|
|
#include "timeval.h"
|
2009-07-08 13:19:16 -07:00
|
|
|
|
#include "util.h"
|
|
|
|
|
#include "valgrind.h"
|
|
|
|
|
#include "vlog.h"
|
2010-07-16 11:02:49 -07:00
|
|
|
|
|
2010-10-19 14:47:01 -07:00
|
|
|
|
VLOG_DEFINE_THIS_MODULE(dpif);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
coverage: Make the coverage counters catalog program-specific.
Until now, the collection of coverage counters supported by a given OVS
program was not specific to that program. That means that, for example,
even though ovs-dpctl does not have anything to do with mac_learning, it
still has a coverage counter for it. This is confusing, at best.
This commit fixes the problem on some systems, in particular on ones that
use GCC and the GNU linker. It uses the feature of the GNU linker
described in its manual as:
If an orphaned section's name is representable as a C identifier then
the linker will automatically see PROVIDE two symbols: __start_SECNAME
and __end_SECNAME, where SECNAME is the name of the section. These
indicate the start address and end address of the orphaned section
respectively.
Systems that don't support these features retain the earlier behavior.
This commit also fixes the annoyance that files that include coverage
counters must be listed on COVERAGE_FILES in lib/automake.mk.
This commit also fixes the annoyance that modifying any source file that
includes a coverage counter caused all programs that link against
libopenvswitch.a to relink, even programs that the source file was not
linked into. For example, modifying ofproto/ofproto.c (which includes
coverage counters) caused tests/test-aes128 to relink, even though
test-aes128 does not link again ofproto.o.
2010-11-01 14:14:27 -07:00
|
|
|
|
COVERAGE_DEFINE(dpif_destroy);
|
|
|
|
|
COVERAGE_DEFINE(dpif_port_add);
|
|
|
|
|
COVERAGE_DEFINE(dpif_port_del);
|
|
|
|
|
COVERAGE_DEFINE(dpif_flow_flush);
|
|
|
|
|
COVERAGE_DEFINE(dpif_flow_get);
|
|
|
|
|
COVERAGE_DEFINE(dpif_flow_put);
|
|
|
|
|
COVERAGE_DEFINE(dpif_flow_del);
|
|
|
|
|
COVERAGE_DEFINE(dpif_flow_query_list);
|
|
|
|
|
COVERAGE_DEFINE(dpif_flow_query_list_n);
|
|
|
|
|
COVERAGE_DEFINE(dpif_execute);
|
|
|
|
|
COVERAGE_DEFINE(dpif_purge);
|
|
|
|
|
|
2010-02-01 11:36:01 -05:00
|
|
|
|
static const struct dpif_class *base_dpif_classes[] = {
|
2010-05-26 10:38:52 -07:00
|
|
|
|
#ifdef HAVE_NETLINK
|
2009-06-17 14:35:35 -07:00
|
|
|
|
&dpif_linux_class,
|
2010-05-26 10:38:52 -07:00
|
|
|
|
#endif
|
2009-06-19 14:09:39 -07:00
|
|
|
|
&dpif_netdev_class,
|
2009-06-16 10:09:10 -07:00
|
|
|
|
};
|
2010-02-01 11:36:01 -05:00
|
|
|
|
|
|
|
|
|
struct registered_dpif_class {
|
2010-11-18 10:07:48 -08:00
|
|
|
|
const struct dpif_class *dpif_class;
|
2010-02-01 11:36:01 -05:00
|
|
|
|
int refcount;
|
|
|
|
|
};
|
|
|
|
|
static struct shash dpif_classes = SHASH_INITIALIZER(&dpif_classes);
|
2009-06-16 10:09:10 -07:00
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
/* Rate limit for individual messages going to or from the datapath, output at
|
|
|
|
|
* DBG level. This is very high because, if these are enabled, it is because
|
|
|
|
|
* we really need to see them. */
|
|
|
|
|
static struct vlog_rate_limit dpmsg_rl = VLOG_RATE_LIMIT_INIT(600, 600);
|
|
|
|
|
|
|
|
|
|
/* Not really much point in logging many dpif errors. */
|
2010-04-06 11:17:39 -07:00
|
|
|
|
static struct vlog_rate_limit error_rl = VLOG_RATE_LIMIT_INIT(60, 5);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-01-26 07:03:39 -08:00
|
|
|
|
static void log_flow_message(const struct dpif *dpif, int error,
|
|
|
|
|
const char *operation,
|
|
|
|
|
const struct nlattr *key, size_t key_len,
|
2011-01-26 07:11:50 -08:00
|
|
|
|
const struct dpif_flow_stats *stats,
|
2011-01-26 07:03:39 -08:00
|
|
|
|
const struct nlattr *actions, size_t actions_len);
|
2009-06-17 14:35:35 -07:00
|
|
|
|
static void log_operation(const struct dpif *, const char *operation,
|
|
|
|
|
int error);
|
|
|
|
|
static bool should_log_flow_message(int error);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2010-02-01 11:36:01 -05:00
|
|
|
|
static void
|
|
|
|
|
dp_initialize(void)
|
|
|
|
|
{
|
|
|
|
|
static int status = -1;
|
|
|
|
|
|
|
|
|
|
if (status < 0) {
|
|
|
|
|
int i;
|
|
|
|
|
|
|
|
|
|
status = 0;
|
|
|
|
|
for (i = 0; i < ARRAY_SIZE(base_dpif_classes); i++) {
|
|
|
|
|
dp_register_provider(base_dpif_classes[i]);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2009-06-19 14:09:09 -07:00
|
|
|
|
/* Performs periodic work needed by all the various kinds of dpifs.
|
|
|
|
|
*
|
2009-07-30 16:04:45 -07:00
|
|
|
|
* If your program opens any dpifs, it must call both this function and
|
|
|
|
|
* netdev_run() within its main poll loop. */
|
2009-06-19 14:09:09 -07:00
|
|
|
|
void
|
|
|
|
|
dp_run(void)
|
|
|
|
|
{
|
2010-02-01 11:36:01 -05:00
|
|
|
|
struct shash_node *node;
|
|
|
|
|
SHASH_FOR_EACH(node, &dpif_classes) {
|
|
|
|
|
const struct registered_dpif_class *registered_class = node->data;
|
2010-11-18 10:07:48 -08:00
|
|
|
|
if (registered_class->dpif_class->run) {
|
|
|
|
|
registered_class->dpif_class->run();
|
2009-06-19 14:09:09 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Arranges for poll_block() to wake up when dp_run() needs to be called.
|
|
|
|
|
*
|
2009-07-30 16:04:45 -07:00
|
|
|
|
* If your program opens any dpifs, it must call both this function and
|
|
|
|
|
* netdev_wait() within its main poll loop. */
|
2009-06-19 14:09:09 -07:00
|
|
|
|
void
|
|
|
|
|
dp_wait(void)
|
|
|
|
|
{
|
2010-02-01 11:36:01 -05:00
|
|
|
|
struct shash_node *node;
|
|
|
|
|
SHASH_FOR_EACH(node, &dpif_classes) {
|
|
|
|
|
const struct registered_dpif_class *registered_class = node->data;
|
2010-11-18 10:07:48 -08:00
|
|
|
|
if (registered_class->dpif_class->wait) {
|
|
|
|
|
registered_class->dpif_class->wait();
|
2009-06-19 14:09:09 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2010-02-01 11:36:01 -05:00
|
|
|
|
/* Registers a new datapath provider. After successful registration, new
|
|
|
|
|
* datapaths of that type can be opened using dpif_open(). */
|
|
|
|
|
int
|
|
|
|
|
dp_register_provider(const struct dpif_class *new_class)
|
|
|
|
|
{
|
|
|
|
|
struct registered_dpif_class *registered_class;
|
|
|
|
|
|
|
|
|
|
if (shash_find(&dpif_classes, new_class->type)) {
|
|
|
|
|
VLOG_WARN("attempted to register duplicate datapath provider: %s",
|
|
|
|
|
new_class->type);
|
|
|
|
|
return EEXIST;
|
|
|
|
|
}
|
2010-01-22 14:37:10 -05:00
|
|
|
|
|
2010-02-01 11:36:01 -05:00
|
|
|
|
registered_class = xmalloc(sizeof *registered_class);
|
2010-11-18 10:07:48 -08:00
|
|
|
|
registered_class->dpif_class = new_class;
|
2010-02-01 11:36:01 -05:00
|
|
|
|
registered_class->refcount = 0;
|
|
|
|
|
|
|
|
|
|
shash_add(&dpif_classes, new_class->type, registered_class);
|
|
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Unregisters a datapath provider. 'type' must have been previously
|
|
|
|
|
* registered and not currently be in use by any dpifs. After unregistration
|
|
|
|
|
* new datapaths of that type cannot be opened using dpif_open(). */
|
|
|
|
|
int
|
|
|
|
|
dp_unregister_provider(const char *type)
|
|
|
|
|
{
|
|
|
|
|
struct shash_node *node;
|
|
|
|
|
struct registered_dpif_class *registered_class;
|
|
|
|
|
|
|
|
|
|
node = shash_find(&dpif_classes, type);
|
|
|
|
|
if (!node) {
|
|
|
|
|
VLOG_WARN("attempted to unregister a datapath provider that is not "
|
|
|
|
|
"registered: %s", type);
|
|
|
|
|
return EAFNOSUPPORT;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
registered_class = node->data;
|
|
|
|
|
if (registered_class->refcount) {
|
|
|
|
|
VLOG_WARN("attempted to unregister in use datapath provider: %s", type);
|
|
|
|
|
return EBUSY;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
shash_delete(&dpif_classes, node);
|
|
|
|
|
free(registered_class);
|
|
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Clears 'types' and enumerates the types of all currently registered datapath
|
|
|
|
|
* providers into it. The caller must first initialize the svec. */
|
2010-01-22 14:37:10 -05:00
|
|
|
|
void
|
|
|
|
|
dp_enumerate_types(struct svec *types)
|
|
|
|
|
{
|
2010-02-01 11:36:01 -05:00
|
|
|
|
struct shash_node *node;
|
2010-01-22 14:37:10 -05:00
|
|
|
|
|
2010-02-01 11:36:01 -05:00
|
|
|
|
dp_initialize();
|
2010-01-22 14:37:10 -05:00
|
|
|
|
svec_clear(types);
|
|
|
|
|
|
2010-02-01 11:36:01 -05:00
|
|
|
|
SHASH_FOR_EACH(node, &dpif_classes) {
|
|
|
|
|
const struct registered_dpif_class *registered_class = node->data;
|
2010-11-18 10:07:48 -08:00
|
|
|
|
svec_add(types, registered_class->dpif_class->type);
|
2010-01-22 14:37:10 -05:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Clears 'names' and enumerates the names of all known created datapaths with
|
|
|
|
|
* the given 'type'. The caller must first initialize the svec. Returns 0 if
|
|
|
|
|
* successful, otherwise a positive errno value.
|
2009-07-06 11:06:36 -07:00
|
|
|
|
*
|
|
|
|
|
* Some kinds of datapaths might not be practically enumerable. This is not
|
|
|
|
|
* considered an error. */
|
|
|
|
|
int
|
2010-01-22 14:37:10 -05:00
|
|
|
|
dp_enumerate_names(const char *type, struct svec *names)
|
2009-07-06 11:06:36 -07:00
|
|
|
|
{
|
2010-02-01 11:36:01 -05:00
|
|
|
|
const struct registered_dpif_class *registered_class;
|
|
|
|
|
const struct dpif_class *dpif_class;
|
|
|
|
|
int error;
|
2009-07-06 11:06:36 -07:00
|
|
|
|
|
2010-02-01 11:36:01 -05:00
|
|
|
|
dp_initialize();
|
2010-01-22 14:37:10 -05:00
|
|
|
|
svec_clear(names);
|
|
|
|
|
|
2010-02-01 11:36:01 -05:00
|
|
|
|
registered_class = shash_find_data(&dpif_classes, type);
|
|
|
|
|
if (!registered_class) {
|
|
|
|
|
VLOG_WARN("could not enumerate unknown type: %s", type);
|
|
|
|
|
return EAFNOSUPPORT;
|
|
|
|
|
}
|
2010-01-22 14:37:10 -05:00
|
|
|
|
|
2010-11-18 10:07:48 -08:00
|
|
|
|
dpif_class = registered_class->dpif_class;
|
2010-02-01 11:36:01 -05:00
|
|
|
|
error = dpif_class->enumerate ? dpif_class->enumerate(names) : 0;
|
2010-01-22 14:37:10 -05:00
|
|
|
|
|
2010-02-01 11:36:01 -05:00
|
|
|
|
if (error) {
|
|
|
|
|
VLOG_WARN("failed to enumerate %s datapaths: %s", dpif_class->type,
|
|
|
|
|
strerror(error));
|
2009-07-06 11:06:36 -07:00
|
|
|
|
}
|
2010-01-22 14:37:10 -05:00
|
|
|
|
|
2010-02-01 11:36:01 -05:00
|
|
|
|
return error;
|
2010-01-22 14:37:10 -05:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Parses 'datapath name', which is of the form type@name into its
|
|
|
|
|
* component pieces. 'name' and 'type' must be freed by the caller. */
|
|
|
|
|
void
|
|
|
|
|
dp_parse_name(const char *datapath_name_, char **name, char **type)
|
|
|
|
|
{
|
|
|
|
|
char *datapath_name = xstrdup(datapath_name_);
|
|
|
|
|
char *separator;
|
|
|
|
|
|
|
|
|
|
separator = strchr(datapath_name, '@');
|
|
|
|
|
if (separator) {
|
|
|
|
|
*separator = '\0';
|
|
|
|
|
*type = datapath_name;
|
|
|
|
|
*name = xstrdup(separator + 1);
|
|
|
|
|
} else {
|
|
|
|
|
*name = datapath_name;
|
|
|
|
|
*type = NULL;
|
|
|
|
|
}
|
2009-07-06 11:06:36 -07:00
|
|
|
|
}
|
|
|
|
|
|
2009-06-17 14:35:35 -07:00
|
|
|
|
static int
|
2010-01-22 14:37:10 -05:00
|
|
|
|
do_open(const char *name, const char *type, bool create, struct dpif **dpifp)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2009-06-17 14:35:35 -07:00
|
|
|
|
struct dpif *dpif = NULL;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
int error;
|
2010-02-01 11:36:01 -05:00
|
|
|
|
struct registered_dpif_class *registered_class;
|
|
|
|
|
|
|
|
|
|
dp_initialize();
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2010-01-22 14:37:10 -05:00
|
|
|
|
if (!type || *type == '\0') {
|
|
|
|
|
type = "system";
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2010-02-01 11:36:01 -05:00
|
|
|
|
registered_class = shash_find_data(&dpif_classes, type);
|
|
|
|
|
if (!registered_class) {
|
|
|
|
|
VLOG_WARN("could not create datapath %s of unknown type %s", name,
|
|
|
|
|
type);
|
|
|
|
|
error = EAFNOSUPPORT;
|
|
|
|
|
goto exit;
|
|
|
|
|
}
|
|
|
|
|
|
2010-11-18 10:06:41 -08:00
|
|
|
|
error = registered_class->dpif_class->open(registered_class->dpif_class,
|
|
|
|
|
name, create, &dpif);
|
2010-02-01 11:36:01 -05:00
|
|
|
|
if (!error) {
|
2010-11-18 10:06:41 -08:00
|
|
|
|
assert(dpif->dpif_class == registered_class->dpif_class);
|
2010-02-01 11:36:01 -05:00
|
|
|
|
registered_class->refcount++;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2009-06-17 14:35:35 -07:00
|
|
|
|
exit:
|
|
|
|
|
*dpifp = error ? NULL : dpif;
|
|
|
|
|
return error;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2010-01-22 14:37:10 -05:00
|
|
|
|
/* Tries to open an existing datapath named 'name' and type 'type'. Will fail
|
|
|
|
|
* if no datapath with 'name' and 'type' exists. 'type' may be either NULL or
|
|
|
|
|
* the empty string to specify the default system type. Returns 0 if
|
|
|
|
|
* successful, otherwise a positive errno value. On success stores a pointer
|
|
|
|
|
* to the datapath in '*dpifp', otherwise a null pointer. */
|
2009-06-17 14:35:35 -07:00
|
|
|
|
int
|
2010-01-22 14:37:10 -05:00
|
|
|
|
dpif_open(const char *name, const char *type, struct dpif **dpifp)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2010-01-22 14:37:10 -05:00
|
|
|
|
return do_open(name, type, false, dpifp);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2010-01-22 14:37:10 -05:00
|
|
|
|
/* Tries to create and open a new datapath with the given 'name' and 'type'.
|
|
|
|
|
* 'type' may be either NULL or the empty string to specify the default system
|
|
|
|
|
* type. Will fail if a datapath with 'name' and 'type' already exists.
|
|
|
|
|
* Returns 0 if successful, otherwise a positive errno value. On success
|
|
|
|
|
* stores a pointer to the datapath in '*dpifp', otherwise a null pointer. */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
int
|
2010-01-22 14:37:10 -05:00
|
|
|
|
dpif_create(const char *name, const char *type, struct dpif **dpifp)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2010-01-22 14:37:10 -05:00
|
|
|
|
return do_open(name, type, true, dpifp);
|
2009-06-17 14:35:35 -07:00
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2010-01-22 14:37:10 -05:00
|
|
|
|
/* Tries to open a datapath with the given 'name' and 'type', creating it if it
|
|
|
|
|
* does not exist. 'type' may be either NULL or the empty string to specify
|
|
|
|
|
* the default system type. Returns 0 if successful, otherwise a positive
|
|
|
|
|
* errno value. On success stores a pointer to the datapath in '*dpifp',
|
|
|
|
|
* otherwise a null pointer. */
|
2009-11-23 11:09:19 -08:00
|
|
|
|
int
|
2010-01-22 14:37:10 -05:00
|
|
|
|
dpif_create_and_open(const char *name, const char *type, struct dpif **dpifp)
|
2009-11-23 11:09:19 -08:00
|
|
|
|
{
|
|
|
|
|
int error;
|
|
|
|
|
|
2010-01-22 14:37:10 -05:00
|
|
|
|
error = dpif_create(name, type, dpifp);
|
2009-11-23 11:09:19 -08:00
|
|
|
|
if (error == EEXIST || error == EBUSY) {
|
2010-01-22 14:37:10 -05:00
|
|
|
|
error = dpif_open(name, type, dpifp);
|
2009-11-23 11:09:19 -08:00
|
|
|
|
if (error) {
|
|
|
|
|
VLOG_WARN("datapath %s already exists but cannot be opened: %s",
|
|
|
|
|
name, strerror(error));
|
|
|
|
|
}
|
|
|
|
|
} else if (error) {
|
|
|
|
|
VLOG_WARN("failed to create datapath %s: %s", name, strerror(error));
|
|
|
|
|
}
|
|
|
|
|
return error;
|
|
|
|
|
}
|
|
|
|
|
|
2009-06-17 14:35:35 -07:00
|
|
|
|
/* Closes and frees the connection to 'dpif'. Does not destroy the datapath
|
|
|
|
|
* itself; call dpif_delete() first, instead, if that is desirable. */
|
|
|
|
|
void
|
|
|
|
|
dpif_close(struct dpif *dpif)
|
|
|
|
|
{
|
|
|
|
|
if (dpif) {
|
2010-02-01 11:36:01 -05:00
|
|
|
|
struct registered_dpif_class *registered_class;
|
|
|
|
|
|
2010-08-30 00:24:53 -07:00
|
|
|
|
registered_class = shash_find_data(&dpif_classes,
|
2010-02-05 15:58:27 -08:00
|
|
|
|
dpif->dpif_class->type);
|
2010-02-01 11:36:01 -05:00
|
|
|
|
assert(registered_class);
|
|
|
|
|
assert(registered_class->refcount);
|
|
|
|
|
|
|
|
|
|
registered_class->refcount--;
|
|
|
|
|
dpif_uninit(dpif, true);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2010-01-22 14:37:10 -05:00
|
|
|
|
/* Returns the name of datapath 'dpif' prefixed with the type
|
|
|
|
|
* (for use in log messages). */
|
2009-06-16 11:00:22 -07:00
|
|
|
|
const char *
|
|
|
|
|
dpif_name(const struct dpif *dpif)
|
|
|
|
|
{
|
2010-01-22 14:37:10 -05:00
|
|
|
|
return dpif->full_name;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Returns the name of datapath 'dpif' without the type
|
|
|
|
|
* (for use in device names). */
|
|
|
|
|
const char *
|
|
|
|
|
dpif_base_name(const struct dpif *dpif)
|
|
|
|
|
{
|
|
|
|
|
return dpif->base_name;
|
2009-06-16 11:00:22 -07:00
|
|
|
|
}
|
|
|
|
|
|
2009-07-06 11:06:36 -07:00
|
|
|
|
/* Enumerates all names that may be used to open 'dpif' into 'all_names'. The
|
|
|
|
|
* Linux datapath, for example, supports opening a datapath both by number,
|
|
|
|
|
* e.g. "dp0", and by the name of the datapath's local port. For some
|
|
|
|
|
* datapaths, this might be an infinite set (e.g. in a file name, slashes may
|
|
|
|
|
* be duplicated any number of times), in which case only the names most likely
|
|
|
|
|
* to be used will be enumerated.
|
|
|
|
|
*
|
|
|
|
|
* The caller must already have initialized 'all_names'. Any existing names in
|
|
|
|
|
* 'all_names' will not be disturbed. */
|
|
|
|
|
int
|
|
|
|
|
dpif_get_all_names(const struct dpif *dpif, struct svec *all_names)
|
|
|
|
|
{
|
2010-01-22 15:14:01 -08:00
|
|
|
|
if (dpif->dpif_class->get_all_names) {
|
|
|
|
|
int error = dpif->dpif_class->get_all_names(dpif, all_names);
|
2009-07-06 11:06:36 -07:00
|
|
|
|
if (error) {
|
|
|
|
|
VLOG_WARN_RL(&error_rl,
|
|
|
|
|
"failed to retrieve names for datpath %s: %s",
|
|
|
|
|
dpif_name(dpif), strerror(error));
|
|
|
|
|
}
|
|
|
|
|
return error;
|
|
|
|
|
} else {
|
2010-01-22 14:37:10 -05:00
|
|
|
|
svec_add(all_names, dpif_base_name(dpif));
|
2009-07-06 11:06:36 -07:00
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
coverage: Make the coverage counters catalog program-specific.
Until now, the collection of coverage counters supported by a given OVS
program was not specific to that program. That means that, for example,
even though ovs-dpctl does not have anything to do with mac_learning, it
still has a coverage counter for it. This is confusing, at best.
This commit fixes the problem on some systems, in particular on ones that
use GCC and the GNU linker. It uses the feature of the GNU linker
described in its manual as:
If an orphaned section's name is representable as a C identifier then
the linker will automatically see PROVIDE two symbols: __start_SECNAME
and __end_SECNAME, where SECNAME is the name of the section. These
indicate the start address and end address of the orphaned section
respectively.
Systems that don't support these features retain the earlier behavior.
This commit also fixes the annoyance that files that include coverage
counters must be listed on COVERAGE_FILES in lib/automake.mk.
This commit also fixes the annoyance that modifying any source file that
includes a coverage counter caused all programs that link against
libopenvswitch.a to relink, even programs that the source file was not
linked into. For example, modifying ofproto/ofproto.c (which includes
coverage counters) caused tests/test-aes128 to relink, even though
test-aes128 does not link again ofproto.o.
2010-11-01 14:14:27 -07:00
|
|
|
|
|
2009-06-17 14:35:35 -07:00
|
|
|
|
/* Destroys the datapath that 'dpif' is connected to, first removing all of its
|
|
|
|
|
* ports. After calling this function, it does not make sense to pass 'dpif'
|
|
|
|
|
* to any functions other than dpif_name() or dpif_close(). */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
int
|
|
|
|
|
dpif_delete(struct dpif *dpif)
|
|
|
|
|
{
|
2009-06-17 14:35:35 -07:00
|
|
|
|
int error;
|
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
COVERAGE_INC(dpif_destroy);
|
2009-06-17 14:35:35 -07:00
|
|
|
|
|
2010-01-22 15:14:01 -08:00
|
|
|
|
error = dpif->dpif_class->destroy(dpif);
|
2009-06-17 14:35:35 -07:00
|
|
|
|
log_operation(dpif, "delete", error);
|
|
|
|
|
return error;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2009-06-17 14:35:35 -07:00
|
|
|
|
/* Retrieves statistics for 'dpif' into 'stats'. Returns 0 if successful,
|
|
|
|
|
* otherwise a positive errno value. */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
int
|
|
|
|
|
dpif_get_dp_stats(const struct dpif *dpif, struct odp_stats *stats)
|
|
|
|
|
{
|
2010-01-22 15:14:01 -08:00
|
|
|
|
int error = dpif->dpif_class->get_stats(dpif, stats);
|
2009-06-17 14:35:35 -07:00
|
|
|
|
if (error) {
|
|
|
|
|
memset(stats, 0, sizeof *stats);
|
|
|
|
|
}
|
|
|
|
|
log_operation(dpif, "get_stats", error);
|
|
|
|
|
return error;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2009-06-17 14:35:35 -07:00
|
|
|
|
/* Retrieves the current IP fragment handling policy for 'dpif' into
|
|
|
|
|
* '*drop_frags': true indicates that fragments are dropped, false indicates
|
|
|
|
|
* that fragments are treated in the same way as other IP packets (except that
|
|
|
|
|
* the L4 header cannot be read). Returns 0 if successful, otherwise a
|
|
|
|
|
* positive errno value. */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
int
|
|
|
|
|
dpif_get_drop_frags(const struct dpif *dpif, bool *drop_frags)
|
|
|
|
|
{
|
2010-01-22 15:14:01 -08:00
|
|
|
|
int error = dpif->dpif_class->get_drop_frags(dpif, drop_frags);
|
2009-06-17 14:35:35 -07:00
|
|
|
|
if (error) {
|
|
|
|
|
*drop_frags = false;
|
|
|
|
|
}
|
|
|
|
|
log_operation(dpif, "get_drop_frags", error);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
return error;
|
|
|
|
|
}
|
|
|
|
|
|
2009-06-17 14:35:35 -07:00
|
|
|
|
/* Changes 'dpif''s treatment of IP fragments to 'drop_frags', whose meaning is
|
|
|
|
|
* the same as for the get_drop_frags member function. Returns 0 if
|
|
|
|
|
* successful, otherwise a positive errno value. */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
int
|
|
|
|
|
dpif_set_drop_frags(struct dpif *dpif, bool drop_frags)
|
|
|
|
|
{
|
2010-01-22 15:14:01 -08:00
|
|
|
|
int error = dpif->dpif_class->set_drop_frags(dpif, drop_frags);
|
2009-06-17 14:35:35 -07:00
|
|
|
|
log_operation(dpif, "set_drop_frags", error);
|
|
|
|
|
return error;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2010-12-03 14:41:38 -08:00
|
|
|
|
/* Attempts to add 'netdev' as a port on 'dpif'. If successful, returns 0 and
|
|
|
|
|
* sets '*port_nop' to the new port's port number (if 'port_nop' is non-null).
|
|
|
|
|
* On failure, returns a positive errno value and sets '*port_nop' to
|
|
|
|
|
* UINT16_MAX (if 'port_nop' is non-null). */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
int
|
2010-12-03 14:41:38 -08:00
|
|
|
|
dpif_port_add(struct dpif *dpif, struct netdev *netdev, uint16_t *port_nop)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2010-12-03 14:41:38 -08:00
|
|
|
|
const char *netdev_name = netdev_get_name(netdev);
|
2009-06-17 14:26:19 -07:00
|
|
|
|
uint16_t port_no;
|
|
|
|
|
int error;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
|
|
|
|
COVERAGE_INC(dpif_port_add);
|
2009-06-17 14:26:19 -07:00
|
|
|
|
|
2010-12-03 14:41:38 -08:00
|
|
|
|
error = dpif->dpif_class->port_add(dpif, netdev, &port_no);
|
2009-06-17 14:26:19 -07:00
|
|
|
|
if (!error) {
|
2009-06-16 11:00:22 -07:00
|
|
|
|
VLOG_DBG_RL(&dpmsg_rl, "%s: added %s as port %"PRIu16,
|
2010-12-03 14:41:38 -08:00
|
|
|
|
dpif_name(dpif), netdev_name, port_no);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
} else {
|
2009-06-17 14:26:19 -07:00
|
|
|
|
VLOG_WARN_RL(&error_rl, "%s: failed to add %s as port: %s",
|
2010-12-03 14:41:38 -08:00
|
|
|
|
dpif_name(dpif), netdev_name, strerror(error));
|
2009-06-17 14:35:35 -07:00
|
|
|
|
port_no = UINT16_MAX;
|
2009-06-17 14:26:19 -07:00
|
|
|
|
}
|
|
|
|
|
if (port_nop) {
|
|
|
|
|
*port_nop = port_no;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2009-06-17 14:26:19 -07:00
|
|
|
|
return error;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2009-06-17 14:35:35 -07:00
|
|
|
|
/* Attempts to remove 'dpif''s port number 'port_no'. Returns 0 if successful,
|
|
|
|
|
* otherwise a positive errno value. */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
int
|
|
|
|
|
dpif_port_del(struct dpif *dpif, uint16_t port_no)
|
|
|
|
|
{
|
2009-06-17 14:35:35 -07:00
|
|
|
|
int error;
|
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
COVERAGE_INC(dpif_port_del);
|
2009-06-17 14:35:35 -07:00
|
|
|
|
|
2010-01-22 15:14:01 -08:00
|
|
|
|
error = dpif->dpif_class->port_del(dpif, port_no);
|
2010-12-03 14:42:28 -08:00
|
|
|
|
if (!error) {
|
|
|
|
|
VLOG_DBG_RL(&dpmsg_rl, "%s: port_del(%"PRIu16")",
|
|
|
|
|
dpif_name(dpif), port_no);
|
|
|
|
|
} else {
|
|
|
|
|
log_operation(dpif, "port_del", error);
|
|
|
|
|
}
|
2009-06-17 14:35:35 -07:00
|
|
|
|
return error;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-01-23 18:48:02 -08:00
|
|
|
|
/* Makes a deep copy of 'src' into 'dst'. */
|
|
|
|
|
void
|
|
|
|
|
dpif_port_clone(struct dpif_port *dst, const struct dpif_port *src)
|
|
|
|
|
{
|
|
|
|
|
dst->name = xstrdup(src->name);
|
|
|
|
|
dst->type = xstrdup(src->type);
|
|
|
|
|
dst->port_no = src->port_no;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Frees memory allocated to members of 'dpif_port'.
|
|
|
|
|
*
|
|
|
|
|
* Do not call this function on a dpif_port obtained from
|
|
|
|
|
* dpif_port_dump_next(): that function retains ownership of the data in the
|
|
|
|
|
* dpif_port. */
|
|
|
|
|
void
|
|
|
|
|
dpif_port_destroy(struct dpif_port *dpif_port)
|
|
|
|
|
{
|
|
|
|
|
free(dpif_port->name);
|
|
|
|
|
free(dpif_port->type);
|
|
|
|
|
}
|
|
|
|
|
|
2009-06-17 14:35:35 -07:00
|
|
|
|
/* Looks up port number 'port_no' in 'dpif'. On success, returns 0 and
|
|
|
|
|
* initializes '*port' appropriately; on failure, returns a positive errno
|
2011-01-23 18:48:02 -08:00
|
|
|
|
* value.
|
|
|
|
|
*
|
|
|
|
|
* The caller owns the data in 'port' and must free it with
|
|
|
|
|
* dpif_port_destroy() when it is no longer needed. */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
int
|
|
|
|
|
dpif_port_query_by_number(const struct dpif *dpif, uint16_t port_no,
|
2011-01-23 18:48:02 -08:00
|
|
|
|
struct dpif_port *port)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2010-01-22 15:14:01 -08:00
|
|
|
|
int error = dpif->dpif_class->port_query_by_number(dpif, port_no, port);
|
2009-06-17 14:35:35 -07:00
|
|
|
|
if (!error) {
|
2009-06-16 11:00:22 -07:00
|
|
|
|
VLOG_DBG_RL(&dpmsg_rl, "%s: port %"PRIu16" is device %s",
|
2011-01-23 18:48:02 -08:00
|
|
|
|
dpif_name(dpif), port_no, port->name);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
} else {
|
2009-06-17 14:35:35 -07:00
|
|
|
|
memset(port, 0, sizeof *port);
|
2009-06-16 11:00:22 -07:00
|
|
|
|
VLOG_WARN_RL(&error_rl, "%s: failed to query port %"PRIu16": %s",
|
2009-06-17 14:35:35 -07:00
|
|
|
|
dpif_name(dpif), port_no, strerror(error));
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2009-06-17 14:35:35 -07:00
|
|
|
|
return error;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2009-06-17 14:35:35 -07:00
|
|
|
|
/* Looks up port named 'devname' in 'dpif'. On success, returns 0 and
|
|
|
|
|
* initializes '*port' appropriately; on failure, returns a positive errno
|
2011-01-23 18:48:02 -08:00
|
|
|
|
* value.
|
|
|
|
|
*
|
|
|
|
|
* The caller owns the data in 'port' and must free it with
|
|
|
|
|
* dpif_port_destroy() when it is no longer needed. */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
int
|
|
|
|
|
dpif_port_query_by_name(const struct dpif *dpif, const char *devname,
|
2011-01-23 18:48:02 -08:00
|
|
|
|
struct dpif_port *port)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2010-01-22 15:14:01 -08:00
|
|
|
|
int error = dpif->dpif_class->port_query_by_name(dpif, devname, port);
|
2009-06-17 14:35:35 -07:00
|
|
|
|
if (!error) {
|
2009-06-16 11:00:22 -07:00
|
|
|
|
VLOG_DBG_RL(&dpmsg_rl, "%s: device %s is on port %"PRIu16,
|
2011-01-23 18:48:02 -08:00
|
|
|
|
dpif_name(dpif), devname, port->port_no);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
} else {
|
2009-06-17 14:35:35 -07:00
|
|
|
|
memset(port, 0, sizeof *port);
|
|
|
|
|
|
2009-06-16 10:01:04 -07:00
|
|
|
|
/* Log level is DBG here because all the current callers are interested
|
|
|
|
|
* in whether 'dpif' actually has a port 'devname', so that it's not an
|
|
|
|
|
* issue worth logging if it doesn't. */
|
|
|
|
|
VLOG_DBG_RL(&error_rl, "%s: failed to query port %s: %s",
|
2009-06-17 14:35:35 -07:00
|
|
|
|
dpif_name(dpif), devname, strerror(error));
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2009-06-17 14:35:35 -07:00
|
|
|
|
return error;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-01-26 09:24:59 -08:00
|
|
|
|
/* Returns one greater than the maximum port number accepted in flow
|
|
|
|
|
* actions. */
|
|
|
|
|
int
|
|
|
|
|
dpif_get_max_ports(const struct dpif *dpif)
|
|
|
|
|
{
|
|
|
|
|
return dpif->dpif_class->get_max_ports(dpif);
|
|
|
|
|
}
|
|
|
|
|
|
2009-06-17 14:35:35 -07:00
|
|
|
|
/* Looks up port number 'port_no' in 'dpif'. On success, returns 0 and copies
|
|
|
|
|
* the port's name into the 'name_size' bytes in 'name', ensuring that the
|
|
|
|
|
* result is null-terminated. On failure, returns a positive errno value and
|
|
|
|
|
* makes 'name' the empty string. */
|
2009-06-15 16:51:46 -07:00
|
|
|
|
int
|
|
|
|
|
dpif_port_get_name(struct dpif *dpif, uint16_t port_no,
|
|
|
|
|
char *name, size_t name_size)
|
|
|
|
|
{
|
2011-01-23 18:48:02 -08:00
|
|
|
|
struct dpif_port port;
|
2009-06-15 16:51:46 -07:00
|
|
|
|
int error;
|
|
|
|
|
|
|
|
|
|
assert(name_size > 0);
|
|
|
|
|
|
|
|
|
|
error = dpif_port_query_by_number(dpif, port_no, &port);
|
|
|
|
|
if (!error) {
|
2011-01-23 18:48:02 -08:00
|
|
|
|
ovs_strlcpy(name, port.name, name_size);
|
|
|
|
|
dpif_port_destroy(&port);
|
2009-06-15 16:51:46 -07:00
|
|
|
|
} else {
|
|
|
|
|
*name = '\0';
|
|
|
|
|
}
|
|
|
|
|
return error;
|
|
|
|
|
}
|
|
|
|
|
|
datapath: Change listing ports to use an iterator concept.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to add new
features to the kernel vport layer without changing userspace software. In
turn, that means that the odp_port structure must become variable-length.
This does not, however, fit in well with the ODP_PORT_LIST ioctl in its
current form, because that would require userspace to know how much space
to allocate for each port in advance, or to allocate as much space as
could possibly be needed. Neither choice is very attractive.
This commit prepares for a different solution, by replacing ODP_PORT_LIST
by a new ioctl ODP_VPORT_DUMP that retrieves information about a single
vport from the datapath on each call. It is much cleaner to allocate the
maximum amount of space for a single vport than to do so for possibly a
large number of vports.
It would be faster to retrieve a number of vports in batch instead of just
one at a time, but that will naturally happen later when the kernel
datapath interface is changed to use Netlink, so this patch does not bother
with it.
The Netlink version won't need to take the starting port number from
userspace, since Netlink sockets can keep track of that state as part
of their "dump" feature.
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2011-01-10 13:12:12 -08:00
|
|
|
|
/* Initializes 'dump' to begin dumping the ports in a dpif.
|
2009-06-17 14:35:35 -07:00
|
|
|
|
*
|
datapath: Change listing ports to use an iterator concept.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to add new
features to the kernel vport layer without changing userspace software. In
turn, that means that the odp_port structure must become variable-length.
This does not, however, fit in well with the ODP_PORT_LIST ioctl in its
current form, because that would require userspace to know how much space
to allocate for each port in advance, or to allocate as much space as
could possibly be needed. Neither choice is very attractive.
This commit prepares for a different solution, by replacing ODP_PORT_LIST
by a new ioctl ODP_VPORT_DUMP that retrieves information about a single
vport from the datapath on each call. It is much cleaner to allocate the
maximum amount of space for a single vport than to do so for possibly a
large number of vports.
It would be faster to retrieve a number of vports in batch instead of just
one at a time, but that will naturally happen later when the kernel
datapath interface is changed to use Netlink, so this patch does not bother
with it.
The Netlink version won't need to take the starting port number from
userspace, since Netlink sockets can keep track of that state as part
of their "dump" feature.
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2011-01-10 13:12:12 -08:00
|
|
|
|
* This function provides no status indication. An error status for the entire
|
|
|
|
|
* dump operation is provided when it is completed by calling
|
|
|
|
|
* dpif_port_dump_done().
|
|
|
|
|
*/
|
|
|
|
|
void
|
|
|
|
|
dpif_port_dump_start(struct dpif_port_dump *dump, const struct dpif *dpif)
|
|
|
|
|
{
|
|
|
|
|
dump->dpif = dpif;
|
|
|
|
|
dump->error = dpif->dpif_class->port_dump_start(dpif, &dump->state);
|
|
|
|
|
log_operation(dpif, "port_dump_start", dump->error);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Attempts to retrieve another port from 'dump', which must have been
|
2011-01-23 18:48:02 -08:00
|
|
|
|
* initialized with dpif_port_dump_start(). On success, stores a new dpif_port
|
datapath: Change listing ports to use an iterator concept.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to add new
features to the kernel vport layer without changing userspace software. In
turn, that means that the odp_port structure must become variable-length.
This does not, however, fit in well with the ODP_PORT_LIST ioctl in its
current form, because that would require userspace to know how much space
to allocate for each port in advance, or to allocate as much space as
could possibly be needed. Neither choice is very attractive.
This commit prepares for a different solution, by replacing ODP_PORT_LIST
by a new ioctl ODP_VPORT_DUMP that retrieves information about a single
vport from the datapath on each call. It is much cleaner to allocate the
maximum amount of space for a single vport than to do so for possibly a
large number of vports.
It would be faster to retrieve a number of vports in batch instead of just
one at a time, but that will naturally happen later when the kernel
datapath interface is changed to use Netlink, so this patch does not bother
with it.
The Netlink version won't need to take the starting port number from
userspace, since Netlink sockets can keep track of that state as part
of their "dump" feature.
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2011-01-10 13:12:12 -08:00
|
|
|
|
* into 'port' and returns true. On failure, returns false.
|
2009-06-17 14:35:35 -07:00
|
|
|
|
*
|
datapath: Change listing ports to use an iterator concept.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to add new
features to the kernel vport layer without changing userspace software. In
turn, that means that the odp_port structure must become variable-length.
This does not, however, fit in well with the ODP_PORT_LIST ioctl in its
current form, because that would require userspace to know how much space
to allocate for each port in advance, or to allocate as much space as
could possibly be needed. Neither choice is very attractive.
This commit prepares for a different solution, by replacing ODP_PORT_LIST
by a new ioctl ODP_VPORT_DUMP that retrieves information about a single
vport from the datapath on each call. It is much cleaner to allocate the
maximum amount of space for a single vport than to do so for possibly a
large number of vports.
It would be faster to retrieve a number of vports in batch instead of just
one at a time, but that will naturally happen later when the kernel
datapath interface is changed to use Netlink, so this patch does not bother
with it.
The Netlink version won't need to take the starting port number from
userspace, since Netlink sockets can keep track of that state as part
of their "dump" feature.
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2011-01-10 13:12:12 -08:00
|
|
|
|
* Failure might indicate an actual error or merely that the last port has been
|
|
|
|
|
* dumped. An error status for the entire dump operation is provided when it
|
2011-01-23 18:48:02 -08:00
|
|
|
|
* is completed by calling dpif_port_dump_done().
|
|
|
|
|
*
|
|
|
|
|
* The dpif owns the data stored in 'port'. It will remain valid until at
|
|
|
|
|
* least the next time 'dump' is passed to dpif_port_dump_next() or
|
|
|
|
|
* dpif_port_dump_done(). */
|
datapath: Change listing ports to use an iterator concept.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to add new
features to the kernel vport layer without changing userspace software. In
turn, that means that the odp_port structure must become variable-length.
This does not, however, fit in well with the ODP_PORT_LIST ioctl in its
current form, because that would require userspace to know how much space
to allocate for each port in advance, or to allocate as much space as
could possibly be needed. Neither choice is very attractive.
This commit prepares for a different solution, by replacing ODP_PORT_LIST
by a new ioctl ODP_VPORT_DUMP that retrieves information about a single
vport from the datapath on each call. It is much cleaner to allocate the
maximum amount of space for a single vport than to do so for possibly a
large number of vports.
It would be faster to retrieve a number of vports in batch instead of just
one at a time, but that will naturally happen later when the kernel
datapath interface is changed to use Netlink, so this patch does not bother
with it.
The Netlink version won't need to take the starting port number from
userspace, since Netlink sockets can keep track of that state as part
of their "dump" feature.
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2011-01-10 13:12:12 -08:00
|
|
|
|
bool
|
2011-01-23 18:48:02 -08:00
|
|
|
|
dpif_port_dump_next(struct dpif_port_dump *dump, struct dpif_port *port)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
datapath: Change listing ports to use an iterator concept.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to add new
features to the kernel vport layer without changing userspace software. In
turn, that means that the odp_port structure must become variable-length.
This does not, however, fit in well with the ODP_PORT_LIST ioctl in its
current form, because that would require userspace to know how much space
to allocate for each port in advance, or to allocate as much space as
could possibly be needed. Neither choice is very attractive.
This commit prepares for a different solution, by replacing ODP_PORT_LIST
by a new ioctl ODP_VPORT_DUMP that retrieves information about a single
vport from the datapath on each call. It is much cleaner to allocate the
maximum amount of space for a single vport than to do so for possibly a
large number of vports.
It would be faster to retrieve a number of vports in batch instead of just
one at a time, but that will naturally happen later when the kernel
datapath interface is changed to use Netlink, so this patch does not bother
with it.
The Netlink version won't need to take the starting port number from
userspace, since Netlink sockets can keep track of that state as part
of their "dump" feature.
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2011-01-10 13:12:12 -08:00
|
|
|
|
const struct dpif *dpif = dump->dpif;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
datapath: Change listing ports to use an iterator concept.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to add new
features to the kernel vport layer without changing userspace software. In
turn, that means that the odp_port structure must become variable-length.
This does not, however, fit in well with the ODP_PORT_LIST ioctl in its
current form, because that would require userspace to know how much space
to allocate for each port in advance, or to allocate as much space as
could possibly be needed. Neither choice is very attractive.
This commit prepares for a different solution, by replacing ODP_PORT_LIST
by a new ioctl ODP_VPORT_DUMP that retrieves information about a single
vport from the datapath on each call. It is much cleaner to allocate the
maximum amount of space for a single vport than to do so for possibly a
large number of vports.
It would be faster to retrieve a number of vports in batch instead of just
one at a time, but that will naturally happen later when the kernel
datapath interface is changed to use Netlink, so this patch does not bother
with it.
The Netlink version won't need to take the starting port number from
userspace, since Netlink sockets can keep track of that state as part
of their "dump" feature.
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2011-01-10 13:12:12 -08:00
|
|
|
|
if (dump->error) {
|
|
|
|
|
return false;
|
|
|
|
|
}
|
2009-06-17 14:28:07 -07:00
|
|
|
|
|
datapath: Change listing ports to use an iterator concept.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to add new
features to the kernel vport layer without changing userspace software. In
turn, that means that the odp_port structure must become variable-length.
This does not, however, fit in well with the ODP_PORT_LIST ioctl in its
current form, because that would require userspace to know how much space
to allocate for each port in advance, or to allocate as much space as
could possibly be needed. Neither choice is very attractive.
This commit prepares for a different solution, by replacing ODP_PORT_LIST
by a new ioctl ODP_VPORT_DUMP that retrieves information about a single
vport from the datapath on each call. It is much cleaner to allocate the
maximum amount of space for a single vport than to do so for possibly a
large number of vports.
It would be faster to retrieve a number of vports in batch instead of just
one at a time, but that will naturally happen later when the kernel
datapath interface is changed to use Netlink, so this patch does not bother
with it.
The Netlink version won't need to take the starting port number from
userspace, since Netlink sockets can keep track of that state as part
of their "dump" feature.
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2011-01-10 13:12:12 -08:00
|
|
|
|
dump->error = dpif->dpif_class->port_dump_next(dpif, dump->state, port);
|
|
|
|
|
if (dump->error == EOF) {
|
|
|
|
|
VLOG_DBG_RL(&dpmsg_rl, "%s: dumped all ports", dpif_name(dpif));
|
|
|
|
|
} else {
|
|
|
|
|
log_operation(dpif, "port_dump_next", dump->error);
|
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
datapath: Change listing ports to use an iterator concept.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to add new
features to the kernel vport layer without changing userspace software. In
turn, that means that the odp_port structure must become variable-length.
This does not, however, fit in well with the ODP_PORT_LIST ioctl in its
current form, because that would require userspace to know how much space
to allocate for each port in advance, or to allocate as much space as
could possibly be needed. Neither choice is very attractive.
This commit prepares for a different solution, by replacing ODP_PORT_LIST
by a new ioctl ODP_VPORT_DUMP that retrieves information about a single
vport from the datapath on each call. It is much cleaner to allocate the
maximum amount of space for a single vport than to do so for possibly a
large number of vports.
It would be faster to retrieve a number of vports in batch instead of just
one at a time, but that will naturally happen later when the kernel
datapath interface is changed to use Netlink, so this patch does not bother
with it.
The Netlink version won't need to take the starting port number from
userspace, since Netlink sockets can keep track of that state as part
of their "dump" feature.
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2011-01-10 13:12:12 -08:00
|
|
|
|
if (dump->error) {
|
|
|
|
|
dpif->dpif_class->port_dump_done(dpif, dump->state);
|
|
|
|
|
return false;
|
2009-06-17 14:28:07 -07:00
|
|
|
|
}
|
datapath: Change listing ports to use an iterator concept.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to add new
features to the kernel vport layer without changing userspace software. In
turn, that means that the odp_port structure must become variable-length.
This does not, however, fit in well with the ODP_PORT_LIST ioctl in its
current form, because that would require userspace to know how much space
to allocate for each port in advance, or to allocate as much space as
could possibly be needed. Neither choice is very attractive.
This commit prepares for a different solution, by replacing ODP_PORT_LIST
by a new ioctl ODP_VPORT_DUMP that retrieves information about a single
vport from the datapath on each call. It is much cleaner to allocate the
maximum amount of space for a single vport than to do so for possibly a
large number of vports.
It would be faster to retrieve a number of vports in batch instead of just
one at a time, but that will naturally happen later when the kernel
datapath interface is changed to use Netlink, so this patch does not bother
with it.
The Netlink version won't need to take the starting port number from
userspace, since Netlink sockets can keep track of that state as part
of their "dump" feature.
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2011-01-10 13:12:12 -08:00
|
|
|
|
return true;
|
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
datapath: Change listing ports to use an iterator concept.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to add new
features to the kernel vport layer without changing userspace software. In
turn, that means that the odp_port structure must become variable-length.
This does not, however, fit in well with the ODP_PORT_LIST ioctl in its
current form, because that would require userspace to know how much space
to allocate for each port in advance, or to allocate as much space as
could possibly be needed. Neither choice is very attractive.
This commit prepares for a different solution, by replacing ODP_PORT_LIST
by a new ioctl ODP_VPORT_DUMP that retrieves information about a single
vport from the datapath on each call. It is much cleaner to allocate the
maximum amount of space for a single vport than to do so for possibly a
large number of vports.
It would be faster to retrieve a number of vports in batch instead of just
one at a time, but that will naturally happen later when the kernel
datapath interface is changed to use Netlink, so this patch does not bother
with it.
The Netlink version won't need to take the starting port number from
userspace, since Netlink sockets can keep track of that state as part
of their "dump" feature.
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2011-01-10 13:12:12 -08:00
|
|
|
|
/* Completes port table dump operation 'dump', which must have been initialized
|
|
|
|
|
* with dpif_port_dump_start(). Returns 0 if the dump operation was
|
|
|
|
|
* error-free, otherwise a positive errno value describing the problem. */
|
|
|
|
|
int
|
|
|
|
|
dpif_port_dump_done(struct dpif_port_dump *dump)
|
|
|
|
|
{
|
|
|
|
|
const struct dpif *dpif = dump->dpif;
|
|
|
|
|
if (!dump->error) {
|
|
|
|
|
dump->error = dpif->dpif_class->port_dump_done(dpif, dump->state);
|
|
|
|
|
log_operation(dpif, "port_dump_done", dump->error);
|
2009-06-17 14:28:07 -07:00
|
|
|
|
}
|
datapath: Change listing ports to use an iterator concept.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to add new
features to the kernel vport layer without changing userspace software. In
turn, that means that the odp_port structure must become variable-length.
This does not, however, fit in well with the ODP_PORT_LIST ioctl in its
current form, because that would require userspace to know how much space
to allocate for each port in advance, or to allocate as much space as
could possibly be needed. Neither choice is very attractive.
This commit prepares for a different solution, by replacing ODP_PORT_LIST
by a new ioctl ODP_VPORT_DUMP that retrieves information about a single
vport from the datapath on each call. It is much cleaner to allocate the
maximum amount of space for a single vport than to do so for possibly a
large number of vports.
It would be faster to retrieve a number of vports in batch instead of just
one at a time, but that will naturally happen later when the kernel
datapath interface is changed to use Netlink, so this patch does not bother
with it.
The Netlink version won't need to take the starting port number from
userspace, since Netlink sockets can keep track of that state as part
of their "dump" feature.
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2011-01-10 13:12:12 -08:00
|
|
|
|
return dump->error == EOF ? 0 : dump->error;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2009-06-24 10:24:09 -07:00
|
|
|
|
/* Polls for changes in the set of ports in 'dpif'. If the set of ports in
|
|
|
|
|
* 'dpif' has changed, this function does one of the following:
|
|
|
|
|
*
|
|
|
|
|
* - Stores the name of the device that was added to or deleted from 'dpif' in
|
|
|
|
|
* '*devnamep' and returns 0. The caller is responsible for freeing
|
|
|
|
|
* '*devnamep' (with free()) when it no longer needs it.
|
|
|
|
|
*
|
|
|
|
|
* - Returns ENOBUFS and sets '*devnamep' to NULL.
|
|
|
|
|
*
|
|
|
|
|
* This function may also return 'false positives', where it returns 0 and
|
|
|
|
|
* '*devnamep' names a device that was not actually added or deleted or it
|
|
|
|
|
* returns ENOBUFS without any change.
|
|
|
|
|
*
|
|
|
|
|
* Returns EAGAIN if the set of ports in 'dpif' has not changed. May also
|
|
|
|
|
* return other positive errno values to indicate that something has gone
|
|
|
|
|
* wrong. */
|
|
|
|
|
int
|
|
|
|
|
dpif_port_poll(const struct dpif *dpif, char **devnamep)
|
|
|
|
|
{
|
2010-01-22 15:14:01 -08:00
|
|
|
|
int error = dpif->dpif_class->port_poll(dpif, devnamep);
|
2009-06-24 10:24:09 -07:00
|
|
|
|
if (error) {
|
|
|
|
|
*devnamep = NULL;
|
|
|
|
|
}
|
|
|
|
|
return error;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Arranges for the poll loop to wake up when port_poll(dpif) will return a
|
|
|
|
|
* value other than EAGAIN. */
|
|
|
|
|
void
|
|
|
|
|
dpif_port_poll_wait(const struct dpif *dpif)
|
|
|
|
|
{
|
2010-01-22 15:14:01 -08:00
|
|
|
|
dpif->dpif_class->port_poll_wait(dpif);
|
2009-06-24 10:24:09 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-01-26 07:11:50 -08:00
|
|
|
|
/* Appends a human-readable representation of 'stats' to 's'. */
|
|
|
|
|
void
|
|
|
|
|
dpif_flow_stats_format(const struct dpif_flow_stats *stats, struct ds *s)
|
|
|
|
|
{
|
|
|
|
|
ds_put_format(s, "packets:%"PRIu64", bytes:%"PRIu64", used:",
|
|
|
|
|
stats->n_packets, stats->n_bytes);
|
|
|
|
|
if (stats->used) {
|
|
|
|
|
ds_put_format(s, "%.3fs", (time_msec() - stats->used) / 1000.0);
|
|
|
|
|
} else {
|
|
|
|
|
ds_put_format(s, "never");
|
|
|
|
|
}
|
|
|
|
|
/* XXX tcp_flags? */
|
|
|
|
|
}
|
|
|
|
|
|
2009-06-17 14:35:35 -07:00
|
|
|
|
/* Deletes all flows from 'dpif'. Returns 0 if successful, otherwise a
|
|
|
|
|
* positive errno value. */
|
|
|
|
|
int
|
|
|
|
|
dpif_flow_flush(struct dpif *dpif)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2009-06-17 14:35:35 -07:00
|
|
|
|
int error;
|
|
|
|
|
|
|
|
|
|
COVERAGE_INC(dpif_flow_flush);
|
|
|
|
|
|
2010-01-22 15:14:01 -08:00
|
|
|
|
error = dpif->dpif_class->flow_flush(dpif);
|
2009-06-17 14:35:35 -07:00
|
|
|
|
log_operation(dpif, "flow_flush", error);
|
|
|
|
|
return error;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-01-26 07:03:39 -08:00
|
|
|
|
/* Queries 'dpif' for a flow entry. The flow is specified by the Netlink
|
|
|
|
|
* attributes with types ODP_KEY_ATTR_* in the 'key_len' bytes starting at
|
|
|
|
|
* 'key'.
|
2009-06-17 14:35:35 -07:00
|
|
|
|
*
|
2011-01-26 07:03:39 -08:00
|
|
|
|
* Returns 0 if successful. If no flow matches, returns ENOENT. On other
|
|
|
|
|
* failure, returns a positive errno value.
|
2009-06-17 14:35:35 -07:00
|
|
|
|
*
|
2011-01-26 07:03:39 -08:00
|
|
|
|
* If 'actionsp' is nonnull, then on success '*actionsp' will be set to an
|
|
|
|
|
* ofpbuf owned by the caller that contains the Netlink attributes for the
|
|
|
|
|
* flow's actions. The caller must free the ofpbuf (with ofpbuf_delete()) when
|
|
|
|
|
* it is no longer needed.
|
|
|
|
|
*
|
|
|
|
|
* If 'stats' is nonnull, then on success it will be updated with the flow's
|
|
|
|
|
* statistics. */
|
2009-06-17 14:35:35 -07:00
|
|
|
|
int
|
2011-01-17 14:43:30 -08:00
|
|
|
|
dpif_flow_get(const struct dpif *dpif,
|
2011-01-26 07:03:39 -08:00
|
|
|
|
const struct nlattr *key, size_t key_len,
|
2011-01-26 07:11:50 -08:00
|
|
|
|
struct ofpbuf **actionsp, struct dpif_flow_stats *stats)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2009-06-17 14:35:35 -07:00
|
|
|
|
int error;
|
|
|
|
|
|
|
|
|
|
COVERAGE_INC(dpif_flow_get);
|
|
|
|
|
|
2011-01-17 14:43:30 -08:00
|
|
|
|
error = dpif->dpif_class->flow_get(dpif, key, key_len, actionsp, stats);
|
2010-04-13 16:49:22 -07:00
|
|
|
|
if (error) {
|
2011-01-26 07:03:39 -08:00
|
|
|
|
if (actionsp) {
|
|
|
|
|
*actionsp = NULL;
|
|
|
|
|
}
|
|
|
|
|
if (stats) {
|
|
|
|
|
memset(stats, 0, sizeof *stats);
|
|
|
|
|
}
|
2010-04-13 16:49:22 -07:00
|
|
|
|
}
|
2009-06-17 14:35:35 -07:00
|
|
|
|
if (should_log_flow_message(error)) {
|
2011-01-26 07:03:39 -08:00
|
|
|
|
const struct nlattr *actions;
|
|
|
|
|
size_t actions_len;
|
|
|
|
|
|
|
|
|
|
if (!error && actionsp) {
|
|
|
|
|
actions = (*actionsp)->data;
|
|
|
|
|
actions_len = (*actionsp)->size;
|
|
|
|
|
} else {
|
|
|
|
|
actions = NULL;
|
|
|
|
|
actions_len = 0;
|
|
|
|
|
}
|
|
|
|
|
log_flow_message(dpif, error, "flow_get", key, key_len, stats,
|
|
|
|
|
actions, actions_len);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2009-06-17 14:35:35 -07:00
|
|
|
|
return error;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2011-01-26 07:03:39 -08:00
|
|
|
|
/* Adds or modifies a flow in 'dpif'. The flow is specified by the Netlink
|
|
|
|
|
* attributes with types ODP_KEY_ATTR_* in the 'key_len' bytes starting at
|
|
|
|
|
* 'key'. The associated actions are specified by the Netlink attributes with
|
|
|
|
|
* types ODPAT_* in the 'actions_len' bytes starting at 'actions'.
|
2009-06-17 14:35:35 -07:00
|
|
|
|
*
|
2011-01-26 07:03:39 -08:00
|
|
|
|
* - If the flow's key does not exist in 'dpif', then the flow will be added if
|
2011-01-26 07:12:24 -08:00
|
|
|
|
* 'flags' includes DPIF_FP_CREATE. Otherwise the operation will fail with
|
2009-06-17 14:35:35 -07:00
|
|
|
|
* ENOENT.
|
|
|
|
|
*
|
2011-01-26 07:03:39 -08:00
|
|
|
|
* If the operation succeeds, then 'stats', if nonnull, will be zeroed.
|
2009-06-17 14:35:35 -07:00
|
|
|
|
*
|
2011-01-26 07:03:39 -08:00
|
|
|
|
* - If the flow's key does exist in 'dpif', then the flow's actions will be
|
2011-01-26 07:12:24 -08:00
|
|
|
|
* updated if 'flags' includes DPIF_FP_MODIFY. Otherwise the operation will
|
2011-01-26 07:03:39 -08:00
|
|
|
|
* fail with EEXIST. If the flow's actions are updated, then its statistics
|
2011-01-26 07:12:24 -08:00
|
|
|
|
* will be zeroed if 'flags' includes DPIF_FP_ZERO_STATS, and left as-is
|
2011-01-26 07:03:39 -08:00
|
|
|
|
* otherwise.
|
|
|
|
|
*
|
|
|
|
|
* If the operation succeeds, then 'stats', if nonnull, will be set to the
|
|
|
|
|
* flow's statistics before the update.
|
2009-06-17 14:35:35 -07:00
|
|
|
|
*/
|
2009-07-08 13:19:16 -07:00
|
|
|
|
int
|
2011-01-26 07:12:24 -08:00
|
|
|
|
dpif_flow_put(struct dpif *dpif, enum dpif_flow_put_flags flags,
|
2011-01-26 07:03:39 -08:00
|
|
|
|
const struct nlattr *key, size_t key_len,
|
|
|
|
|
const struct nlattr *actions, size_t actions_len,
|
2011-01-26 07:11:50 -08:00
|
|
|
|
struct dpif_flow_stats *stats)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2009-06-17 14:35:35 -07:00
|
|
|
|
int error;
|
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
COVERAGE_INC(dpif_flow_put);
|
2011-01-26 07:12:24 -08:00
|
|
|
|
assert(!(flags & ~(DPIF_FP_CREATE | DPIF_FP_MODIFY | DPIF_FP_ZERO_STATS)));
|
2009-06-17 14:35:35 -07:00
|
|
|
|
|
2011-01-26 07:03:39 -08:00
|
|
|
|
error = dpif->dpif_class->flow_put(dpif, flags, key, key_len,
|
|
|
|
|
actions, actions_len, stats);
|
|
|
|
|
if (error && stats) {
|
|
|
|
|
memset(stats, 0, sizeof *stats);
|
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
if (should_log_flow_message(error)) {
|
2011-01-26 07:03:39 -08:00
|
|
|
|
struct ds s;
|
|
|
|
|
|
|
|
|
|
ds_init(&s);
|
|
|
|
|
ds_put_cstr(&s, "put");
|
2011-01-26 07:12:24 -08:00
|
|
|
|
if (flags & DPIF_FP_CREATE) {
|
2011-01-26 07:03:39 -08:00
|
|
|
|
ds_put_cstr(&s, "[create]");
|
|
|
|
|
}
|
2011-01-26 07:12:24 -08:00
|
|
|
|
if (flags & DPIF_FP_MODIFY) {
|
2011-01-26 07:03:39 -08:00
|
|
|
|
ds_put_cstr(&s, "[modify]");
|
|
|
|
|
}
|
2011-01-26 07:12:24 -08:00
|
|
|
|
if (flags & DPIF_FP_ZERO_STATS) {
|
2011-01-26 07:03:39 -08:00
|
|
|
|
ds_put_cstr(&s, "[zero]");
|
|
|
|
|
}
|
|
|
|
|
log_flow_message(dpif, error, ds_cstr(&s), key, key_len, stats,
|
|
|
|
|
actions, actions_len);
|
|
|
|
|
ds_destroy(&s);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
return error;
|
|
|
|
|
}
|
|
|
|
|
|
2011-01-26 07:03:39 -08:00
|
|
|
|
/* Deletes a flow from 'dpif' and returns 0, or returns ENOENT if 'dpif' does
|
|
|
|
|
* not contain such a flow. The flow is specified by the Netlink attributes
|
|
|
|
|
* with types ODP_KEY_ATTR_* in the 'key_len' bytes starting at 'key'.
|
2009-06-17 14:35:35 -07:00
|
|
|
|
*
|
2011-01-26 07:03:39 -08:00
|
|
|
|
* If the operation succeeds, then 'stats', if nonnull, will be set to the
|
|
|
|
|
* flow's statistics before its deletion. */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
int
|
2011-01-26 07:03:39 -08:00
|
|
|
|
dpif_flow_del(struct dpif *dpif,
|
|
|
|
|
const struct nlattr *key, size_t key_len,
|
2011-01-26 07:11:50 -08:00
|
|
|
|
struct dpif_flow_stats *stats)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
2009-06-17 12:41:30 -07:00
|
|
|
|
int error;
|
|
|
|
|
|
2009-06-17 14:35:35 -07:00
|
|
|
|
COVERAGE_INC(dpif_flow_del);
|
2009-06-17 12:41:30 -07:00
|
|
|
|
|
2011-01-26 07:03:39 -08:00
|
|
|
|
error = dpif->dpif_class->flow_del(dpif, key, key_len, stats);
|
|
|
|
|
if (error && stats) {
|
|
|
|
|
memset(stats, 0, sizeof *stats);
|
|
|
|
|
}
|
2009-06-17 14:35:35 -07:00
|
|
|
|
if (should_log_flow_message(error)) {
|
2011-01-26 07:03:39 -08:00
|
|
|
|
log_flow_message(dpif, error, "flow_del", key, key_len,
|
|
|
|
|
!error ? stats : NULL, NULL, 0);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2009-06-17 14:35:35 -07:00
|
|
|
|
return error;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
datapath: Change listing flows to use an iterator concept.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to change
the kernel's idea of the flow key separately from the userspace version.
In turn, that means that flow keys must become variable-length. This does
not, however, fit in well with the ODP_FLOW_LIST ioctl in its current form,
because that would require userspace to know how much space to allocate
for each flow's key in advance, or to allocate as much space as could
possibly be needed. Neither choice is very attractive.
This commit prepares for a different solution, by replacing ODP_FLOW_LIST
by a new ioctl ODP_FLOW_DUMP that retrieves a single flow from the datapath
on each call. It is much cleaner to allocate the maximum amount of space
for a single flow key than to do so for possibly a very large number of
flow keys.
As a side effect, this patch also fixes a race condition that sometimes
made "ovs-dpctl dump-flows" print an error: previously, flows were listed
and then their actions were retrieved, which left a window in which
ovs-vswitchd could delete the flow. Now dumping a flow and its actions is
a single step, closing that window.
Dumping all of the flows in a datapath is no longer an atomic step, so now
it is possible to miss some flows or see a single flow twice during
iteration, if the flow table is modified by another process. It doesn't
look like this should be a problem for ovs-vswitchd.
It would be faster to retrieve a number of flows in batch instead of just
one at a time, but that will naturally happen later when the kernel
datapath interface is changed to use Netlink, so this patch does not bother
with it.
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2010-12-28 10:39:52 -08:00
|
|
|
|
/* Initializes 'dump' to begin dumping the flows in a dpif.
|
|
|
|
|
*
|
|
|
|
|
* This function provides no status indication. An error status for the entire
|
|
|
|
|
* dump operation is provided when it is completed by calling
|
|
|
|
|
* dpif_flow_dump_done().
|
|
|
|
|
*/
|
|
|
|
|
void
|
|
|
|
|
dpif_flow_dump_start(struct dpif_flow_dump *dump, const struct dpif *dpif)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
datapath: Change listing flows to use an iterator concept.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to change
the kernel's idea of the flow key separately from the userspace version.
In turn, that means that flow keys must become variable-length. This does
not, however, fit in well with the ODP_FLOW_LIST ioctl in its current form,
because that would require userspace to know how much space to allocate
for each flow's key in advance, or to allocate as much space as could
possibly be needed. Neither choice is very attractive.
This commit prepares for a different solution, by replacing ODP_FLOW_LIST
by a new ioctl ODP_FLOW_DUMP that retrieves a single flow from the datapath
on each call. It is much cleaner to allocate the maximum amount of space
for a single flow key than to do so for possibly a very large number of
flow keys.
As a side effect, this patch also fixes a race condition that sometimes
made "ovs-dpctl dump-flows" print an error: previously, flows were listed
and then their actions were retrieved, which left a window in which
ovs-vswitchd could delete the flow. Now dumping a flow and its actions is
a single step, closing that window.
Dumping all of the flows in a datapath is no longer an atomic step, so now
it is possible to miss some flows or see a single flow twice during
iteration, if the flow table is modified by another process. It doesn't
look like this should be a problem for ovs-vswitchd.
It would be faster to retrieve a number of flows in batch instead of just
one at a time, but that will naturally happen later when the kernel
datapath interface is changed to use Netlink, so this patch does not bother
with it.
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2010-12-28 10:39:52 -08:00
|
|
|
|
dump->dpif = dpif;
|
|
|
|
|
dump->error = dpif->dpif_class->flow_dump_start(dpif, &dump->state);
|
|
|
|
|
log_operation(dpif, "flow_dump_start", dump->error);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
datapath: Change listing flows to use an iterator concept.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to change
the kernel's idea of the flow key separately from the userspace version.
In turn, that means that flow keys must become variable-length. This does
not, however, fit in well with the ODP_FLOW_LIST ioctl in its current form,
because that would require userspace to know how much space to allocate
for each flow's key in advance, or to allocate as much space as could
possibly be needed. Neither choice is very attractive.
This commit prepares for a different solution, by replacing ODP_FLOW_LIST
by a new ioctl ODP_FLOW_DUMP that retrieves a single flow from the datapath
on each call. It is much cleaner to allocate the maximum amount of space
for a single flow key than to do so for possibly a very large number of
flow keys.
As a side effect, this patch also fixes a race condition that sometimes
made "ovs-dpctl dump-flows" print an error: previously, flows were listed
and then their actions were retrieved, which left a window in which
ovs-vswitchd could delete the flow. Now dumping a flow and its actions is
a single step, closing that window.
Dumping all of the flows in a datapath is no longer an atomic step, so now
it is possible to miss some flows or see a single flow twice during
iteration, if the flow table is modified by another process. It doesn't
look like this should be a problem for ovs-vswitchd.
It would be faster to retrieve a number of flows in batch instead of just
one at a time, but that will naturally happen later when the kernel
datapath interface is changed to use Netlink, so this patch does not bother
with it.
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2010-12-28 10:39:52 -08:00
|
|
|
|
/* Attempts to retrieve another flow from 'dump', which must have been
|
2011-01-26 07:03:39 -08:00
|
|
|
|
* initialized with dpif_flow_dump_start(). On success, updates the output
|
|
|
|
|
* parameters as described below and returns true. Otherwise, returns false.
|
|
|
|
|
* Failure might indicate an actual error or merely the end of the flow table.
|
|
|
|
|
* An error status for the entire dump operation is provided when it is
|
|
|
|
|
* completed by calling dpif_flow_dump_done().
|
|
|
|
|
*
|
|
|
|
|
* On success, if 'key' and 'key_len' are nonnull then '*key' and '*key_len'
|
|
|
|
|
* will be set to Netlink attributes with types ODP_KEY_ATTR_* representing the
|
|
|
|
|
* dumped flow's key. If 'actions' and 'actions_len' are nonnull then they are
|
|
|
|
|
* set to Netlink attributes with types ODPAT_* representing the dumped flow's
|
|
|
|
|
* actions. If 'stats' is nonnull then it will be set to the dumped flow's
|
|
|
|
|
* statistics.
|
2009-06-17 14:35:35 -07:00
|
|
|
|
*
|
2011-01-26 07:03:39 -08:00
|
|
|
|
* All of the returned data is owned by 'dpif', not by the caller, and the
|
|
|
|
|
* caller must not modify or free it. 'dpif' guarantees that it remains
|
|
|
|
|
* accessible and unchanging until at least the next call to 'flow_dump_next'
|
|
|
|
|
* or 'flow_dump_done' for 'dump'. */
|
datapath: Change listing flows to use an iterator concept.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to change
the kernel's idea of the flow key separately from the userspace version.
In turn, that means that flow keys must become variable-length. This does
not, however, fit in well with the ODP_FLOW_LIST ioctl in its current form,
because that would require userspace to know how much space to allocate
for each flow's key in advance, or to allocate as much space as could
possibly be needed. Neither choice is very attractive.
This commit prepares for a different solution, by replacing ODP_FLOW_LIST
by a new ioctl ODP_FLOW_DUMP that retrieves a single flow from the datapath
on each call. It is much cleaner to allocate the maximum amount of space
for a single flow key than to do so for possibly a very large number of
flow keys.
As a side effect, this patch also fixes a race condition that sometimes
made "ovs-dpctl dump-flows" print an error: previously, flows were listed
and then their actions were retrieved, which left a window in which
ovs-vswitchd could delete the flow. Now dumping a flow and its actions is
a single step, closing that window.
Dumping all of the flows in a datapath is no longer an atomic step, so now
it is possible to miss some flows or see a single flow twice during
iteration, if the flow table is modified by another process. It doesn't
look like this should be a problem for ovs-vswitchd.
It would be faster to retrieve a number of flows in batch instead of just
one at a time, but that will naturally happen later when the kernel
datapath interface is changed to use Netlink, so this patch does not bother
with it.
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2010-12-28 10:39:52 -08:00
|
|
|
|
bool
|
2011-01-26 07:03:39 -08:00
|
|
|
|
dpif_flow_dump_next(struct dpif_flow_dump *dump,
|
|
|
|
|
const struct nlattr **key, size_t *key_len,
|
|
|
|
|
const struct nlattr **actions, size_t *actions_len,
|
2011-01-26 07:11:50 -08:00
|
|
|
|
const struct dpif_flow_stats **stats)
|
datapath: Change listing flows to use an iterator concept.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to change
the kernel's idea of the flow key separately from the userspace version.
In turn, that means that flow keys must become variable-length. This does
not, however, fit in well with the ODP_FLOW_LIST ioctl in its current form,
because that would require userspace to know how much space to allocate
for each flow's key in advance, or to allocate as much space as could
possibly be needed. Neither choice is very attractive.
This commit prepares for a different solution, by replacing ODP_FLOW_LIST
by a new ioctl ODP_FLOW_DUMP that retrieves a single flow from the datapath
on each call. It is much cleaner to allocate the maximum amount of space
for a single flow key than to do so for possibly a very large number of
flow keys.
As a side effect, this patch also fixes a race condition that sometimes
made "ovs-dpctl dump-flows" print an error: previously, flows were listed
and then their actions were retrieved, which left a window in which
ovs-vswitchd could delete the flow. Now dumping a flow and its actions is
a single step, closing that window.
Dumping all of the flows in a datapath is no longer an atomic step, so now
it is possible to miss some flows or see a single flow twice during
iteration, if the flow table is modified by another process. It doesn't
look like this should be a problem for ovs-vswitchd.
It would be faster to retrieve a number of flows in batch instead of just
one at a time, but that will naturally happen later when the kernel
datapath interface is changed to use Netlink, so this patch does not bother
with it.
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2010-12-28 10:39:52 -08:00
|
|
|
|
{
|
|
|
|
|
const struct dpif *dpif = dump->dpif;
|
2011-01-26 07:03:39 -08:00
|
|
|
|
int error = dump->error;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2011-01-26 07:03:39 -08:00
|
|
|
|
if (!error) {
|
|
|
|
|
error = dpif->dpif_class->flow_dump_next(dpif, dump->state,
|
|
|
|
|
key, key_len,
|
|
|
|
|
actions, actions_len,
|
|
|
|
|
stats);
|
|
|
|
|
if (error) {
|
|
|
|
|
dpif->dpif_class->flow_dump_done(dpif, dump->state);
|
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2011-01-26 07:03:39 -08:00
|
|
|
|
if (error) {
|
|
|
|
|
if (key) {
|
|
|
|
|
*key = NULL;
|
|
|
|
|
*key_len = 0;
|
2011-01-23 18:44:44 -08:00
|
|
|
|
}
|
2011-01-26 07:03:39 -08:00
|
|
|
|
if (actions) {
|
|
|
|
|
*actions = NULL;
|
|
|
|
|
*actions_len = 0;
|
|
|
|
|
}
|
|
|
|
|
if (stats) {
|
|
|
|
|
*stats = NULL;
|
datapath: Change listing flows to use an iterator concept.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to change
the kernel's idea of the flow key separately from the userspace version.
In turn, that means that flow keys must become variable-length. This does
not, however, fit in well with the ODP_FLOW_LIST ioctl in its current form,
because that would require userspace to know how much space to allocate
for each flow's key in advance, or to allocate as much space as could
possibly be needed. Neither choice is very attractive.
This commit prepares for a different solution, by replacing ODP_FLOW_LIST
by a new ioctl ODP_FLOW_DUMP that retrieves a single flow from the datapath
on each call. It is much cleaner to allocate the maximum amount of space
for a single flow key than to do so for possibly a very large number of
flow keys.
As a side effect, this patch also fixes a race condition that sometimes
made "ovs-dpctl dump-flows" print an error: previously, flows were listed
and then their actions were retrieved, which left a window in which
ovs-vswitchd could delete the flow. Now dumping a flow and its actions is
a single step, closing that window.
Dumping all of the flows in a datapath is no longer an atomic step, so now
it is possible to miss some flows or see a single flow twice during
iteration, if the flow table is modified by another process. It doesn't
look like this should be a problem for ovs-vswitchd.
It would be faster to retrieve a number of flows in batch instead of just
one at a time, but that will naturally happen later when the kernel
datapath interface is changed to use Netlink, so this patch does not bother
with it.
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2010-12-28 10:39:52 -08:00
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2011-01-26 07:03:39 -08:00
|
|
|
|
if (!dump->error) {
|
|
|
|
|
if (error == EOF) {
|
|
|
|
|
VLOG_DBG_RL(&dpmsg_rl, "%s: dumped all flows", dpif_name(dpif));
|
|
|
|
|
} else if (should_log_flow_message(error)) {
|
|
|
|
|
log_flow_message(dpif, error, "flow_dump",
|
|
|
|
|
key ? *key : NULL, key ? *key_len : 0,
|
|
|
|
|
stats ? *stats : NULL, actions ? *actions : NULL,
|
|
|
|
|
actions ? *actions_len : 0);
|
|
|
|
|
}
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2011-01-26 07:03:39 -08:00
|
|
|
|
dump->error = error;
|
|
|
|
|
return !error;
|
datapath: Change listing flows to use an iterator concept.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to change
the kernel's idea of the flow key separately from the userspace version.
In turn, that means that flow keys must become variable-length. This does
not, however, fit in well with the ODP_FLOW_LIST ioctl in its current form,
because that would require userspace to know how much space to allocate
for each flow's key in advance, or to allocate as much space as could
possibly be needed. Neither choice is very attractive.
This commit prepares for a different solution, by replacing ODP_FLOW_LIST
by a new ioctl ODP_FLOW_DUMP that retrieves a single flow from the datapath
on each call. It is much cleaner to allocate the maximum amount of space
for a single flow key than to do so for possibly a very large number of
flow keys.
As a side effect, this patch also fixes a race condition that sometimes
made "ovs-dpctl dump-flows" print an error: previously, flows were listed
and then their actions were retrieved, which left a window in which
ovs-vswitchd could delete the flow. Now dumping a flow and its actions is
a single step, closing that window.
Dumping all of the flows in a datapath is no longer an atomic step, so now
it is possible to miss some flows or see a single flow twice during
iteration, if the flow table is modified by another process. It doesn't
look like this should be a problem for ovs-vswitchd.
It would be faster to retrieve a number of flows in batch instead of just
one at a time, but that will naturally happen later when the kernel
datapath interface is changed to use Netlink, so this patch does not bother
with it.
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2010-12-28 10:39:52 -08:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Completes flow table dump operation 'dump', which must have been initialized
|
|
|
|
|
* with dpif_flow_dump_start(). Returns 0 if the dump operation was
|
|
|
|
|
* error-free, otherwise a positive errno value describing the problem. */
|
|
|
|
|
int
|
|
|
|
|
dpif_flow_dump_done(struct dpif_flow_dump *dump)
|
|
|
|
|
{
|
|
|
|
|
const struct dpif *dpif = dump->dpif;
|
|
|
|
|
if (!dump->error) {
|
|
|
|
|
dump->error = dpif->dpif_class->flow_dump_done(dpif, dump->state);
|
|
|
|
|
log_operation(dpif, "flow_dump_done", dump->error);
|
|
|
|
|
}
|
|
|
|
|
return dump->error == EOF ? 0 : dump->error;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
|
2010-12-10 10:40:58 -08:00
|
|
|
|
/* Causes 'dpif' to perform the 'actions_len' bytes of actions in 'actions' on
|
|
|
|
|
* the Ethernet frame specified in 'packet'.
|
2009-06-17 14:35:35 -07:00
|
|
|
|
*
|
|
|
|
|
* Returns 0 if successful, otherwise a positive errno value. */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
int
|
2010-10-08 16:36:13 -07:00
|
|
|
|
dpif_execute(struct dpif *dpif,
|
2010-12-10 10:40:58 -08:00
|
|
|
|
const struct nlattr *actions, size_t actions_len,
|
2009-07-08 13:19:16 -07:00
|
|
|
|
const struct ofpbuf *buf)
|
|
|
|
|
{
|
|
|
|
|
int error;
|
|
|
|
|
|
|
|
|
|
COVERAGE_INC(dpif_execute);
|
2010-12-10 10:40:58 -08:00
|
|
|
|
if (actions_len > 0) {
|
|
|
|
|
error = dpif->dpif_class->execute(dpif, actions, actions_len, buf);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
} else {
|
|
|
|
|
error = 0;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (!(error ? VLOG_DROP_WARN(&error_rl) : VLOG_DROP_DBG(&dpmsg_rl))) {
|
|
|
|
|
struct ds ds = DS_EMPTY_INITIALIZER;
|
|
|
|
|
char *packet = ofp_packet_to_string(buf->data, buf->size, buf->size);
|
2009-06-16 11:00:22 -07:00
|
|
|
|
ds_put_format(&ds, "%s: execute ", dpif_name(dpif));
|
2010-12-10 10:40:58 -08:00
|
|
|
|
format_odp_actions(&ds, actions, actions_len);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
if (error) {
|
|
|
|
|
ds_put_format(&ds, " failed (%s)", strerror(error));
|
|
|
|
|
}
|
|
|
|
|
ds_put_format(&ds, " on packet %s", packet);
|
|
|
|
|
vlog(THIS_MODULE, error ? VLL_WARN : VLL_DBG, "%s", ds_cstr(&ds));
|
|
|
|
|
ds_destroy(&ds);
|
|
|
|
|
free(packet);
|
|
|
|
|
}
|
|
|
|
|
return error;
|
|
|
|
|
}
|
|
|
|
|
|
2009-06-17 14:35:35 -07:00
|
|
|
|
/* Retrieves 'dpif''s "listen mask" into '*listen_mask'. Each ODPL_* bit set
|
|
|
|
|
* in '*listen_mask' indicates that dpif_recv() will receive messages of that
|
|
|
|
|
* type. Returns 0 if successful, otherwise a positive errno value. */
|
2009-06-17 14:18:10 -07:00
|
|
|
|
int
|
|
|
|
|
dpif_recv_get_mask(const struct dpif *dpif, int *listen_mask)
|
|
|
|
|
{
|
2010-01-22 15:14:01 -08:00
|
|
|
|
int error = dpif->dpif_class->recv_get_mask(dpif, listen_mask);
|
2009-06-17 14:18:10 -07:00
|
|
|
|
if (error) {
|
|
|
|
|
*listen_mask = 0;
|
|
|
|
|
}
|
2009-06-17 14:35:35 -07:00
|
|
|
|
log_operation(dpif, "recv_get_mask", error);
|
2009-06-17 14:18:10 -07:00
|
|
|
|
return error;
|
|
|
|
|
}
|
|
|
|
|
|
2009-06-17 14:35:35 -07:00
|
|
|
|
/* Sets 'dpif''s "listen mask" to 'listen_mask'. Each ODPL_* bit set in
|
|
|
|
|
* '*listen_mask' requests that dpif_recv() receive messages of that type.
|
|
|
|
|
* Returns 0 if successful, otherwise a positive errno value. */
|
2009-06-17 14:18:10 -07:00
|
|
|
|
int
|
|
|
|
|
dpif_recv_set_mask(struct dpif *dpif, int listen_mask)
|
|
|
|
|
{
|
2010-01-22 15:14:01 -08:00
|
|
|
|
int error = dpif->dpif_class->recv_set_mask(dpif, listen_mask);
|
2009-06-17 14:35:35 -07:00
|
|
|
|
log_operation(dpif, "recv_set_mask", error);
|
|
|
|
|
return error;
|
2009-06-17 14:18:10 -07:00
|
|
|
|
}
|
|
|
|
|
|
2010-01-08 16:44:43 -08:00
|
|
|
|
/* Retrieve the sFlow sampling probability. '*probability' is expressed as the
|
|
|
|
|
* number of packets out of UINT_MAX to sample, e.g. probability/UINT_MAX is
|
|
|
|
|
* the probability of sampling a given packet.
|
2010-01-04 13:08:37 -08:00
|
|
|
|
*
|
|
|
|
|
* Returns 0 if successful, otherwise a positive errno value. EOPNOTSUPP
|
|
|
|
|
* indicates that 'dpif' does not support sFlow sampling. */
|
|
|
|
|
int
|
|
|
|
|
dpif_get_sflow_probability(const struct dpif *dpif, uint32_t *probability)
|
|
|
|
|
{
|
2010-01-25 10:52:28 -08:00
|
|
|
|
int error = (dpif->dpif_class->get_sflow_probability
|
|
|
|
|
? dpif->dpif_class->get_sflow_probability(dpif, probability)
|
2010-01-04 13:08:37 -08:00
|
|
|
|
: EOPNOTSUPP);
|
|
|
|
|
if (error) {
|
|
|
|
|
*probability = 0;
|
|
|
|
|
}
|
|
|
|
|
log_operation(dpif, "get_sflow_probability", error);
|
|
|
|
|
return error;
|
|
|
|
|
}
|
|
|
|
|
|
2010-01-08 16:44:43 -08:00
|
|
|
|
/* Set the sFlow sampling probability. 'probability' is expressed as the
|
|
|
|
|
* number of packets out of UINT_MAX to sample, e.g. probability/UINT_MAX is
|
|
|
|
|
* the probability of sampling a given packet.
|
2010-01-04 13:08:37 -08:00
|
|
|
|
*
|
|
|
|
|
* Returns 0 if successful, otherwise a positive errno value. EOPNOTSUPP
|
|
|
|
|
* indicates that 'dpif' does not support sFlow sampling. */
|
|
|
|
|
int
|
|
|
|
|
dpif_set_sflow_probability(struct dpif *dpif, uint32_t probability)
|
|
|
|
|
{
|
2010-01-25 10:52:28 -08:00
|
|
|
|
int error = (dpif->dpif_class->set_sflow_probability
|
|
|
|
|
? dpif->dpif_class->set_sflow_probability(dpif, probability)
|
2010-01-04 13:08:37 -08:00
|
|
|
|
: EOPNOTSUPP);
|
|
|
|
|
log_operation(dpif, "set_sflow_probability", error);
|
|
|
|
|
return error;
|
|
|
|
|
}
|
|
|
|
|
|
datapath: Report kernel's flow key when passing packets up to userspace.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to change
the kernel's idea of the flow key separately from the userspace version.
This commit takes one step in that direction by making the kernel report
its idea of the flow that a packet belongs to whenever it passes a packet
up to userspace. This means that userspace can intelligently figure out
what to do:
- If userspace's notion of the flow for the packet matches the kernel's,
then nothing special is necessary.
- If the kernel has a more specific notion for the flow than userspace,
for example if the kernel decoded IPv6 headers but userspace stopped
at the Ethernet type (because it does not understand IPv6), then again
nothing special is necessary: userspace can still set up the flow in
the usual way.
- If userspace has a more specific notion for the flow than the kernel,
for example if userspace decoded an IPv6 header but the kernel
stopped at the Ethernet type, then userspace can forward the packet
manually, without setting up a flow in the kernel. (This case is
bad from a performance point of view, but at least it is correct.)
This commit does not actually make userspace flexible enough to handle
changes in the kernel flow key structure, although userspace does now
have enough information to do that intelligently. This will have to wait
for later commits.
This commit is bigger than it would otherwise be because it is rolled
together with changing "struct odp_msg" to a sequence of Netlink
attributes. The alternative, to do each of those changes in a separate
patch, seemed like overkill because it meant that either we would have to
introduce and then kill off Netlink attributes for in_port and tun_id, if
Netlink conversion went first, or shove yet another variable-length header
into the stuff already after odp_msg, if adding the flow key to odp_msg
went first.
This commit will slow down performance of checksumming packets sent up to
userspace. I'm not entirely pleased with how I did it. I considered a
couple of alternatives, but none of them seemed that much better.
Suggestions welcome. Not changing anything wasn't an option,
unfortunately. At any rate some slowdown will become unavoidable when OVS
actually starts using Netlink instead of just Netlink framing.
(Actually, I thought of one option where we could avoid that: make
userspace do the checksum instead, by passing csum_start and csum_offset as
part of what goes to userspace. But that's not perfect either.)
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2011-01-24 14:59:57 -08:00
|
|
|
|
/* Polls for an upcall from 'dpif'. If successful, stores the upcall into
|
|
|
|
|
* '*upcall'. Only upcalls of the types selected with the set_listen_mask
|
|
|
|
|
* member function will ordinarily be received (but if a message type is
|
2009-06-17 14:35:35 -07:00
|
|
|
|
* enabled and then later disabled, some stragglers might pop up).
|
|
|
|
|
*
|
datapath: Report kernel's flow key when passing packets up to userspace.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to change
the kernel's idea of the flow key separately from the userspace version.
This commit takes one step in that direction by making the kernel report
its idea of the flow that a packet belongs to whenever it passes a packet
up to userspace. This means that userspace can intelligently figure out
what to do:
- If userspace's notion of the flow for the packet matches the kernel's,
then nothing special is necessary.
- If the kernel has a more specific notion for the flow than userspace,
for example if the kernel decoded IPv6 headers but userspace stopped
at the Ethernet type (because it does not understand IPv6), then again
nothing special is necessary: userspace can still set up the flow in
the usual way.
- If userspace has a more specific notion for the flow than the kernel,
for example if userspace decoded an IPv6 header but the kernel
stopped at the Ethernet type, then userspace can forward the packet
manually, without setting up a flow in the kernel. (This case is
bad from a performance point of view, but at least it is correct.)
This commit does not actually make userspace flexible enough to handle
changes in the kernel flow key structure, although userspace does now
have enough information to do that intelligently. This will have to wait
for later commits.
This commit is bigger than it would otherwise be because it is rolled
together with changing "struct odp_msg" to a sequence of Netlink
attributes. The alternative, to do each of those changes in a separate
patch, seemed like overkill because it meant that either we would have to
introduce and then kill off Netlink attributes for in_port and tun_id, if
Netlink conversion went first, or shove yet another variable-length header
into the stuff already after odp_msg, if adding the flow key to odp_msg
went first.
This commit will slow down performance of checksumming packets sent up to
userspace. I'm not entirely pleased with how I did it. I considered a
couple of alternatives, but none of them seemed that much better.
Suggestions welcome. Not changing anything wasn't an option,
unfortunately. At any rate some slowdown will become unavoidable when OVS
actually starts using Netlink instead of just Netlink framing.
(Actually, I thought of one option where we could avoid that: make
userspace do the checksum instead, by passing csum_start and csum_offset as
part of what goes to userspace. But that's not perfect either.)
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2011-01-24 14:59:57 -08:00
|
|
|
|
* The caller takes ownership of the data that 'upcall' points to.
|
|
|
|
|
* 'upcall->key' and 'upcall->actions' (if nonnull) point into data owned by
|
|
|
|
|
* 'upcall->packet', so their memory cannot be freed separately. (This is
|
|
|
|
|
* hardly a great way to do things but it works out OK for the dpif providers
|
|
|
|
|
* and clients that exist so far.)
|
|
|
|
|
*
|
2009-06-17 14:35:35 -07:00
|
|
|
|
* Returns 0 if successful, otherwise a positive errno value. Returns EAGAIN
|
datapath: Report kernel's flow key when passing packets up to userspace.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to change
the kernel's idea of the flow key separately from the userspace version.
This commit takes one step in that direction by making the kernel report
its idea of the flow that a packet belongs to whenever it passes a packet
up to userspace. This means that userspace can intelligently figure out
what to do:
- If userspace's notion of the flow for the packet matches the kernel's,
then nothing special is necessary.
- If the kernel has a more specific notion for the flow than userspace,
for example if the kernel decoded IPv6 headers but userspace stopped
at the Ethernet type (because it does not understand IPv6), then again
nothing special is necessary: userspace can still set up the flow in
the usual way.
- If userspace has a more specific notion for the flow than the kernel,
for example if userspace decoded an IPv6 header but the kernel
stopped at the Ethernet type, then userspace can forward the packet
manually, without setting up a flow in the kernel. (This case is
bad from a performance point of view, but at least it is correct.)
This commit does not actually make userspace flexible enough to handle
changes in the kernel flow key structure, although userspace does now
have enough information to do that intelligently. This will have to wait
for later commits.
This commit is bigger than it would otherwise be because it is rolled
together with changing "struct odp_msg" to a sequence of Netlink
attributes. The alternative, to do each of those changes in a separate
patch, seemed like overkill because it meant that either we would have to
introduce and then kill off Netlink attributes for in_port and tun_id, if
Netlink conversion went first, or shove yet another variable-length header
into the stuff already after odp_msg, if adding the flow key to odp_msg
went first.
This commit will slow down performance of checksumming packets sent up to
userspace. I'm not entirely pleased with how I did it. I considered a
couple of alternatives, but none of them seemed that much better.
Suggestions welcome. Not changing anything wasn't an option,
unfortunately. At any rate some slowdown will become unavoidable when OVS
actually starts using Netlink instead of just Netlink framing.
(Actually, I thought of one option where we could avoid that: make
userspace do the checksum instead, by passing csum_start and csum_offset as
part of what goes to userspace. But that's not perfect either.)
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2011-01-24 14:59:57 -08:00
|
|
|
|
* if no upcall is immediately available. */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
int
|
datapath: Report kernel's flow key when passing packets up to userspace.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to change
the kernel's idea of the flow key separately from the userspace version.
This commit takes one step in that direction by making the kernel report
its idea of the flow that a packet belongs to whenever it passes a packet
up to userspace. This means that userspace can intelligently figure out
what to do:
- If userspace's notion of the flow for the packet matches the kernel's,
then nothing special is necessary.
- If the kernel has a more specific notion for the flow than userspace,
for example if the kernel decoded IPv6 headers but userspace stopped
at the Ethernet type (because it does not understand IPv6), then again
nothing special is necessary: userspace can still set up the flow in
the usual way.
- If userspace has a more specific notion for the flow than the kernel,
for example if userspace decoded an IPv6 header but the kernel
stopped at the Ethernet type, then userspace can forward the packet
manually, without setting up a flow in the kernel. (This case is
bad from a performance point of view, but at least it is correct.)
This commit does not actually make userspace flexible enough to handle
changes in the kernel flow key structure, although userspace does now
have enough information to do that intelligently. This will have to wait
for later commits.
This commit is bigger than it would otherwise be because it is rolled
together with changing "struct odp_msg" to a sequence of Netlink
attributes. The alternative, to do each of those changes in a separate
patch, seemed like overkill because it meant that either we would have to
introduce and then kill off Netlink attributes for in_port and tun_id, if
Netlink conversion went first, or shove yet another variable-length header
into the stuff already after odp_msg, if adding the flow key to odp_msg
went first.
This commit will slow down performance of checksumming packets sent up to
userspace. I'm not entirely pleased with how I did it. I considered a
couple of alternatives, but none of them seemed that much better.
Suggestions welcome. Not changing anything wasn't an option,
unfortunately. At any rate some slowdown will become unavoidable when OVS
actually starts using Netlink instead of just Netlink framing.
(Actually, I thought of one option where we could avoid that: make
userspace do the checksum instead, by passing csum_start and csum_offset as
part of what goes to userspace. But that's not perfect either.)
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2011-01-24 14:59:57 -08:00
|
|
|
|
dpif_recv(struct dpif *dpif, struct dpif_upcall *upcall)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
{
|
datapath: Report kernel's flow key when passing packets up to userspace.
One of the goals for Open vSwitch is to decouple kernel and userspace
software, so that either one can be upgraded or rolled back independent of
the other. To do this in full generality, it must be possible to change
the kernel's idea of the flow key separately from the userspace version.
This commit takes one step in that direction by making the kernel report
its idea of the flow that a packet belongs to whenever it passes a packet
up to userspace. This means that userspace can intelligently figure out
what to do:
- If userspace's notion of the flow for the packet matches the kernel's,
then nothing special is necessary.
- If the kernel has a more specific notion for the flow than userspace,
for example if the kernel decoded IPv6 headers but userspace stopped
at the Ethernet type (because it does not understand IPv6), then again
nothing special is necessary: userspace can still set up the flow in
the usual way.
- If userspace has a more specific notion for the flow than the kernel,
for example if userspace decoded an IPv6 header but the kernel
stopped at the Ethernet type, then userspace can forward the packet
manually, without setting up a flow in the kernel. (This case is
bad from a performance point of view, but at least it is correct.)
This commit does not actually make userspace flexible enough to handle
changes in the kernel flow key structure, although userspace does now
have enough information to do that intelligently. This will have to wait
for later commits.
This commit is bigger than it would otherwise be because it is rolled
together with changing "struct odp_msg" to a sequence of Netlink
attributes. The alternative, to do each of those changes in a separate
patch, seemed like overkill because it meant that either we would have to
introduce and then kill off Netlink attributes for in_port and tun_id, if
Netlink conversion went first, or shove yet another variable-length header
into the stuff already after odp_msg, if adding the flow key to odp_msg
went first.
This commit will slow down performance of checksumming packets sent up to
userspace. I'm not entirely pleased with how I did it. I considered a
couple of alternatives, but none of them seemed that much better.
Suggestions welcome. Not changing anything wasn't an option,
unfortunately. At any rate some slowdown will become unavoidable when OVS
actually starts using Netlink instead of just Netlink framing.
(Actually, I thought of one option where we could avoid that: make
userspace do the checksum instead, by passing csum_start and csum_offset as
part of what goes to userspace. But that's not perfect either.)
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
2011-01-24 14:59:57 -08:00
|
|
|
|
int error = dpif->dpif_class->recv(dpif, upcall);
|
|
|
|
|
if (!error && !VLOG_DROP_DBG(&dpmsg_rl)) {
|
|
|
|
|
struct flow flow;
|
|
|
|
|
char *s;
|
|
|
|
|
|
|
|
|
|
s = ofp_packet_to_string(upcall->packet->data,
|
|
|
|
|
upcall->packet->size, upcall->packet->size);
|
|
|
|
|
odp_flow_key_to_flow(upcall->key, upcall->key_len, &flow);
|
|
|
|
|
|
|
|
|
|
VLOG_DBG("%s: %s upcall on port %"PRIu16": %s", dpif_name(dpif),
|
|
|
|
|
(upcall->type == _ODPL_MISS_NR ? "miss"
|
|
|
|
|
: upcall->type == _ODPL_ACTION_NR ? "action"
|
|
|
|
|
: upcall->type == _ODPL_SFLOW_NR ? "sFlow"
|
|
|
|
|
: "<unknown>"),
|
|
|
|
|
flow.in_port, s);
|
|
|
|
|
free(s);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
|
|
|
|
return error;
|
|
|
|
|
}
|
|
|
|
|
|
2009-06-17 14:35:35 -07:00
|
|
|
|
/* Discards all messages that would otherwise be received by dpif_recv() on
|
2011-01-04 17:00:36 -08:00
|
|
|
|
* 'dpif'. */
|
|
|
|
|
void
|
2009-06-17 14:35:35 -07:00
|
|
|
|
dpif_recv_purge(struct dpif *dpif)
|
|
|
|
|
{
|
|
|
|
|
COVERAGE_INC(dpif_purge);
|
2011-01-04 17:00:36 -08:00
|
|
|
|
if (dpif->dpif_class->recv_purge) {
|
|
|
|
|
dpif->dpif_class->recv_purge(dpif);
|
2009-06-17 14:35:35 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Arranges for the poll loop to wake up when 'dpif' has a message queued to be
|
|
|
|
|
* received with dpif_recv(). */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
void
|
|
|
|
|
dpif_recv_wait(struct dpif *dpif)
|
|
|
|
|
{
|
2010-01-22 15:14:01 -08:00
|
|
|
|
dpif->dpif_class->recv_wait(dpif);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
}
|
2009-06-16 10:59:43 -07:00
|
|
|
|
|
2009-06-17 14:35:35 -07:00
|
|
|
|
/* Obtains the NetFlow engine type and engine ID for 'dpif' into '*engine_type'
|
|
|
|
|
* and '*engine_id', respectively. */
|
2009-06-16 10:59:43 -07:00
|
|
|
|
void
|
|
|
|
|
dpif_get_netflow_ids(const struct dpif *dpif,
|
|
|
|
|
uint8_t *engine_type, uint8_t *engine_id)
|
|
|
|
|
{
|
2009-06-17 14:35:35 -07:00
|
|
|
|
*engine_type = dpif->netflow_engine_type;
|
|
|
|
|
*engine_id = dpif->netflow_engine_id;
|
|
|
|
|
}
|
2010-07-20 11:23:21 -07:00
|
|
|
|
|
|
|
|
|
/* Translates OpenFlow queue ID 'queue_id' (in host byte order) into a priority
|
|
|
|
|
* value for use in the ODPAT_SET_PRIORITY action. On success, returns 0 and
|
|
|
|
|
* stores the priority into '*priority'. On failure, returns a positive errno
|
|
|
|
|
* value and stores 0 into '*priority'. */
|
|
|
|
|
int
|
|
|
|
|
dpif_queue_to_priority(const struct dpif *dpif, uint32_t queue_id,
|
|
|
|
|
uint32_t *priority)
|
|
|
|
|
{
|
|
|
|
|
int error = (dpif->dpif_class->queue_to_priority
|
|
|
|
|
? dpif->dpif_class->queue_to_priority(dpif, queue_id,
|
|
|
|
|
priority)
|
|
|
|
|
: EOPNOTSUPP);
|
|
|
|
|
if (error) {
|
|
|
|
|
*priority = 0;
|
|
|
|
|
}
|
|
|
|
|
log_operation(dpif, "queue_to_priority", error);
|
|
|
|
|
return error;
|
|
|
|
|
}
|
2009-06-17 14:35:35 -07:00
|
|
|
|
|
|
|
|
|
void
|
2010-01-22 15:14:01 -08:00
|
|
|
|
dpif_init(struct dpif *dpif, const struct dpif_class *dpif_class,
|
|
|
|
|
const char *name,
|
2009-06-17 14:35:35 -07:00
|
|
|
|
uint8_t netflow_engine_type, uint8_t netflow_engine_id)
|
|
|
|
|
{
|
2010-01-22 15:14:01 -08:00
|
|
|
|
dpif->dpif_class = dpif_class;
|
2010-01-22 14:37:10 -05:00
|
|
|
|
dpif->base_name = xstrdup(name);
|
2010-02-05 15:58:27 -08:00
|
|
|
|
dpif->full_name = xasprintf("%s@%s", dpif_class->type, name);
|
2009-06-17 14:35:35 -07:00
|
|
|
|
dpif->netflow_engine_type = netflow_engine_type;
|
|
|
|
|
dpif->netflow_engine_id = netflow_engine_id;
|
|
|
|
|
}
|
2010-02-01 11:36:01 -05:00
|
|
|
|
|
|
|
|
|
/* Undoes the results of initialization.
|
|
|
|
|
*
|
|
|
|
|
* Normally this function only needs to be called from dpif_close().
|
|
|
|
|
* However, it may be called by providers due to an error on opening
|
|
|
|
|
* that occurs after initialization. It this case dpif_close() would
|
|
|
|
|
* never be called. */
|
|
|
|
|
void
|
|
|
|
|
dpif_uninit(struct dpif *dpif, bool close)
|
|
|
|
|
{
|
|
|
|
|
char *base_name = dpif->base_name;
|
|
|
|
|
char *full_name = dpif->full_name;
|
|
|
|
|
|
|
|
|
|
if (close) {
|
2010-02-05 15:58:27 -08:00
|
|
|
|
dpif->dpif_class->close(dpif);
|
2010-02-01 11:36:01 -05:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
free(base_name);
|
|
|
|
|
free(full_name);
|
|
|
|
|
}
|
2009-06-17 14:35:35 -07:00
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
log_operation(const struct dpif *dpif, const char *operation, int error)
|
|
|
|
|
{
|
|
|
|
|
if (!error) {
|
|
|
|
|
VLOG_DBG_RL(&dpmsg_rl, "%s: %s success", dpif_name(dpif), operation);
|
2010-10-19 09:55:40 -07:00
|
|
|
|
} else if (is_errno(error)) {
|
2009-06-17 14:35:35 -07:00
|
|
|
|
VLOG_WARN_RL(&error_rl, "%s: %s failed (%s)",
|
|
|
|
|
dpif_name(dpif), operation, strerror(error));
|
2010-10-19 09:55:40 -07:00
|
|
|
|
} else {
|
|
|
|
|
VLOG_WARN_RL(&error_rl, "%s: %s failed (%d/%d)",
|
|
|
|
|
dpif_name(dpif), operation,
|
|
|
|
|
get_ofp_err_type(error), get_ofp_err_code(error));
|
2009-06-17 14:35:35 -07:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static enum vlog_level
|
|
|
|
|
flow_message_log_level(int error)
|
|
|
|
|
{
|
|
|
|
|
return error ? VLL_WARN : VLL_DBG;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static bool
|
|
|
|
|
should_log_flow_message(int error)
|
|
|
|
|
{
|
|
|
|
|
return !vlog_should_drop(THIS_MODULE, flow_message_log_level(error),
|
|
|
|
|
error ? &error_rl : &dpmsg_rl);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void
|
|
|
|
|
log_flow_message(const struct dpif *dpif, int error, const char *operation,
|
2011-01-23 18:44:44 -08:00
|
|
|
|
const struct nlattr *key, size_t key_len,
|
2011-01-26 07:11:50 -08:00
|
|
|
|
const struct dpif_flow_stats *stats,
|
2010-12-11 22:51:31 -08:00
|
|
|
|
const struct nlattr *actions, size_t actions_len)
|
2009-06-17 14:35:35 -07:00
|
|
|
|
{
|
|
|
|
|
struct ds ds = DS_EMPTY_INITIALIZER;
|
|
|
|
|
ds_put_format(&ds, "%s: ", dpif_name(dpif));
|
|
|
|
|
if (error) {
|
|
|
|
|
ds_put_cstr(&ds, "failed to ");
|
|
|
|
|
}
|
|
|
|
|
ds_put_format(&ds, "%s ", operation);
|
|
|
|
|
if (error) {
|
|
|
|
|
ds_put_format(&ds, "(%s) ", strerror(error));
|
|
|
|
|
}
|
2011-01-23 18:44:44 -08:00
|
|
|
|
odp_flow_key_format(key, key_len, &ds);
|
2009-06-17 14:35:35 -07:00
|
|
|
|
if (stats) {
|
|
|
|
|
ds_put_cstr(&ds, ", ");
|
2011-01-26 07:11:50 -08:00
|
|
|
|
dpif_flow_stats_format(stats, &ds);
|
2009-06-17 14:35:35 -07:00
|
|
|
|
}
|
2010-12-10 10:40:58 -08:00
|
|
|
|
if (actions || actions_len) {
|
2009-06-17 14:35:35 -07:00
|
|
|
|
ds_put_cstr(&ds, ", actions:");
|
2010-12-10 10:40:58 -08:00
|
|
|
|
format_odp_actions(&ds, actions, actions_len);
|
2009-06-17 14:35:35 -07:00
|
|
|
|
}
|
|
|
|
|
vlog(THIS_MODULE, flow_message_log_level(error), "%s", ds_cstr(&ds));
|
|
|
|
|
ds_destroy(&ds);
|
|
|
|
|
}
|