2
0
mirror of https://github.com/openvswitch/ovs synced 2025-08-22 01:51:26 +00:00
ovs/lib/ovsdb-data.h

343 lines
14 KiB
C
Raw Normal View History

/* Copyright (c) 2009, 2010, 2011, 2012, 2015, 2016, 2017 Nicira, Inc.
2009-11-04 15:11:44 -08:00
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at:
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#ifndef OVSDB_DATA_H
#define OVSDB_DATA_H 1
#include <stdlib.h>
#include "compiler.h"
#include "ovsdb-types.h"
#include "openvswitch/json.h"
#include "openvswitch/shash.h"
#include "util.h"
2009-11-04 15:11:44 -08:00
#ifdef __cplusplus
extern "C" {
#endif
#define MAX_OVSDB_ATOM_RANGE_SIZE 4096
struct ds;
2009-11-04 15:11:44 -08:00
struct ovsdb_symbol_table;
struct smap;
2009-11-04 15:11:44 -08:00
static inline struct json *
ovsdb_atom_string_create_nocopy(char *str)
{
return json_string_create_nocopy(str);
}
static inline struct json *
ovsdb_atom_string_create(const char *str)
{
return json_string_create(str);
}
2009-11-04 15:11:44 -08:00
/* One value of an atomic type (given by enum ovs_atomic_type). */
union ovsdb_atom {
int64_t integer;
double real;
bool boolean;
struct json *s;
2009-11-04 15:11:44 -08:00
struct uuid uuid;
};
void ovsdb_atom_init_default(union ovsdb_atom *, enum ovsdb_atomic_type);
const union ovsdb_atom *ovsdb_atom_default(enum ovsdb_atomic_type);
bool ovsdb_atom_is_default(const union ovsdb_atom *, enum ovsdb_atomic_type);
2009-11-04 15:11:44 -08:00
void ovsdb_atom_clone(union ovsdb_atom *, const union ovsdb_atom *,
enum ovsdb_atomic_type);
void ovsdb_atom_swap(union ovsdb_atom *, union ovsdb_atom *);
/* Returns false if ovsdb_atom_destroy() is a no-op when it is applied to an
* initialized atom of the given 'type', true if ovsdb_atom_destroy() actually
* does something.
*
* This can be used to avoid calling ovsdb_atom_destroy() for each element in
* an array of homogeneous atoms. (It's not worthwhile for a single atom.) */
2009-11-04 15:11:44 -08:00
static inline bool
ovsdb_atom_needs_destruction(enum ovsdb_atomic_type type)
{
return type == OVSDB_TYPE_STRING;
}
/* Frees the contents of 'atom', which must have the specified 'type'.
*
* This does not actually call free(atom). If necessary, the caller must be
* responsible for that. */
2009-11-04 15:11:44 -08:00
static inline void
ovsdb_atom_destroy(union ovsdb_atom *atom, enum ovsdb_atomic_type type)
{
if (type == OVSDB_TYPE_STRING) {
json_destroy(atom->s);
2009-11-04 15:11:44 -08:00
}
}
uint32_t ovsdb_atom_hash(const union ovsdb_atom *, enum ovsdb_atomic_type,
uint32_t basis);
int ovsdb_atom_compare_3way(const union ovsdb_atom *,
const union ovsdb_atom *,
enum ovsdb_atomic_type);
/* Returns true if 'a' and 'b', which are both of type 'type', has the same
* contents, false if their contents differ. */
2009-11-04 15:11:44 -08:00
static inline bool ovsdb_atom_equals(const union ovsdb_atom *a,
const union ovsdb_atom *b,
enum ovsdb_atomic_type type)
{
return !ovsdb_atom_compare_3way(a, b, type);
}
struct ovsdb_error *ovsdb_atom_from_json(union ovsdb_atom *,
2010-02-08 14:09:36 -08:00
const struct ovsdb_base_type *,
2009-11-04 15:11:44 -08:00
const struct json *,
struct ovsdb_symbol_table *)
OVS_WARN_UNUSED_RESULT;
2009-11-04 15:11:44 -08:00
struct json *ovsdb_atom_to_json(const union ovsdb_atom *,
enum ovsdb_atomic_type);
char *ovsdb_atom_from_string(union ovsdb_atom *, union ovsdb_atom **,
const struct ovsdb_base_type *, const char *,
struct ovsdb_symbol_table *)
OVS_WARN_UNUSED_RESULT;
void ovsdb_atom_to_string(const union ovsdb_atom *, enum ovsdb_atomic_type,
struct ds *);
void ovsdb_atom_to_bare(const union ovsdb_atom *, enum ovsdb_atomic_type,
struct ds *);
2010-02-08 14:09:36 -08:00
struct ovsdb_error *ovsdb_atom_check_constraints(
const union ovsdb_atom *, const struct ovsdb_base_type *)
OVS_WARN_UNUSED_RESULT;
2009-11-04 15:11:44 -08:00
/* An instance of an OVSDB type (given by struct ovsdb_type).
*
* - The 'keys' must be unique and in sorted order. Most functions that modify
* an ovsdb_datum maintain these invariants. Functions that don't maintain
* the invariants have names that end in "_unsafe". Use ovsdb_datum_sort()
* to check and restore these invariants.
*
* - 'n' is constrained by the ovsdb_type's 'n_min' and 'n_max'.
*
* If 'n' is nonzero, then 'keys' points to an array of 'n' atoms of the type
* specified by the ovsdb_type's 'key_type'. (Otherwise, 'keys' should be
* null.)
*
* If 'n' is nonzero and the ovsdb_type's 'value_type' is not
* OVSDB_TYPE_VOID, then 'values' points to an array of 'n' atoms of the type
* specified by the 'value_type'. (Otherwise, 'values' should be null.)
*
* Thus, for 'n' > 0, 'keys' will always be nonnull and 'values' will be
* nonnull only for "map" types.
*/
2009-11-04 15:11:44 -08:00
struct ovsdb_datum {
unsigned int n; /* Number of 'keys' and 'values'. */
union ovsdb_atom *keys; /* Each of the ovsdb_type's 'key_type'. */
union ovsdb_atom *values; /* Each of the ovsdb_type's 'value_type'. */
unsigned int *refcnt; /* Number of copies with the same
* 'keys' and 'values'. */
2009-11-04 15:11:44 -08:00
};
#define OVSDB_DATUM_INITIALIZER { 0, NULL, NULL }
2009-11-04 15:11:44 -08:00
/* Basics. */
void ovsdb_datum_init_empty(struct ovsdb_datum *);
2009-11-04 15:11:44 -08:00
void ovsdb_datum_init_default(struct ovsdb_datum *, const struct ovsdb_type *);
bool ovsdb_datum_is_default(const struct ovsdb_datum *,
const struct ovsdb_type *);
const struct ovsdb_datum *ovsdb_datum_default(const struct ovsdb_type *);
void ovsdb_datum_clone(struct ovsdb_datum *, const struct ovsdb_datum *);
2009-11-04 15:11:44 -08:00
void ovsdb_datum_destroy(struct ovsdb_datum *, const struct ovsdb_type *);
void ovsdb_datum_unshare(struct ovsdb_datum *, const struct ovsdb_type *);
2009-11-04 15:11:44 -08:00
void ovsdb_datum_swap(struct ovsdb_datum *, struct ovsdb_datum *);
/* Checking and maintaining invariants. */
struct ovsdb_error *ovsdb_datum_sort(struct ovsdb_datum *,
const struct ovsdb_type *type)
OVS_WARN_UNUSED_RESULT;
void ovsdb_datum_sort_assert(struct ovsdb_datum *,
const struct ovsdb_type *type);
size_t ovsdb_datum_sort_unique(struct ovsdb_datum *,
const struct ovsdb_type *type);
2010-02-08 14:09:36 -08:00
struct ovsdb_error *ovsdb_datum_check_constraints(
const struct ovsdb_datum *, const struct ovsdb_type *)
OVS_WARN_UNUSED_RESULT;
2009-11-04 15:11:44 -08:00
/* Type conversion. */
2009-11-04 15:11:44 -08:00
struct ovsdb_error *ovsdb_datum_from_json(struct ovsdb_datum *,
const struct ovsdb_type *,
const struct json *,
struct ovsdb_symbol_table *)
OVS_WARN_UNUSED_RESULT;
struct ovsdb_error *ovsdb_transient_datum_from_json(
struct ovsdb_datum *,
const struct ovsdb_type *,
const struct json *)
OVS_WARN_UNUSED_RESULT;
struct ovsdb_error *
ovsdb_unconstrained_datum_from_json(struct ovsdb_datum *,
const struct ovsdb_type *,
const struct json *)
OVS_WARN_UNUSED_RESULT;
2009-11-04 15:11:44 -08:00
struct json *ovsdb_datum_to_json(const struct ovsdb_datum *,
const struct ovsdb_type *);
2022-10-10 15:11:57 +02:00
struct json *ovsdb_datum_to_json_deep(const struct ovsdb_datum *,
const struct ovsdb_type *);
2009-11-04 15:11:44 -08:00
char *ovsdb_datum_from_string(struct ovsdb_datum *,
const struct ovsdb_type *, const char *,
struct ovsdb_symbol_table *)
OVS_WARN_UNUSED_RESULT;
void ovsdb_datum_to_string(const struct ovsdb_datum *,
const struct ovsdb_type *, struct ds *);
void ovsdb_datum_to_bare(const struct ovsdb_datum *,
const struct ovsdb_type *, struct ds *);
void ovsdb_datum_from_smap(struct ovsdb_datum *, const struct smap *);
struct ovsdb_error *ovsdb_datum_convert(struct ovsdb_datum *dst,
const struct ovsdb_type *dst_type,
const struct ovsdb_datum *src,
const struct ovsdb_type *src_type)
OVS_WARN_UNUSED_RESULT;
/* Comparison. */
2009-11-04 15:11:44 -08:00
uint32_t ovsdb_datum_hash(const struct ovsdb_datum *,
const struct ovsdb_type *, uint32_t basis);
int ovsdb_datum_compare_3way(const struct ovsdb_datum *,
const struct ovsdb_datum *,
const struct ovsdb_type *);
bool ovsdb_datum_equals(const struct ovsdb_datum *,
const struct ovsdb_datum *,
const struct ovsdb_type *);
/* Search. */
ovsdb-data: Optimize union of sets. Current algorithm of ovsdb_datum_union looks like this: for-each atom in b: if not bin_search(a, atom): push(a, clone(atom)) quicksort(a) So, the complexity looks like this: Nb * log2(Na) + Nb + (Na + Nb) * log2(Na + Nb) Comparisons clones Comparisons for quicksort for search ovsdb_datum_union() is heavily used in database transactions while new element is added to a set. For example, if new logical switch port is added to a logical switch in OVN. This is a very common use case where CMS adds one new port to an existing switch that already has, let's say, 100 ports. For this case ovsdb-server will have to perform: 1 * log2(100) + 1 clone + 101 * log2(101) Comparisons Comparisons for for search quicksort. ~7 1 ~707 Roughly 714 comparisons of atoms and 1 clone. Since binary search can give us position, where new atom should go (it's the 'low' index after the search completion) for free, the logic can be re-worked like this: copied = 0 for-each atom in b: desired_position = bin_search(a, atom) push(result, a[ copied : desired_position - 1 ]) copied = desired_position push(result, clone(atom)) push(result, a[ copied : Na ]) swap(a, result) Complexity of this schema: Nb * log2(Na) + Nb + Na Comparisons clones memory copy on push for search 'swap' is just a swap of a few pointers. 'push' is not a 'clone', but a simple memory copy of 'union ovsdb_atom'. In general, this schema substitutes complexity of a quicksort with complexity of a memory copy of Na atom structures, where we're not even copying strings that these atoms are pointing to. Complexity in the example above goes down from 714 comparisons to 7 comparisons and memcpy of 100 * sizeof (union ovsdb_atom) bytes. General complexity of a memory copy should always be lower than complexity of a quicksort, especially because these copies usually performed in bulk, so this new schema should work faster for any input. All in all, this change allows to execute several times more transactions per second for transactions that adds new entries to sets. Alternatively, union can be implemented as a linear merge of two sorted arrays, but this will result in O(Na) comparisons, which is more than Nb * log2(Na) in common case, since Na is usually far bigger than Nb. Linear merge will also mean per-atom memory copies instead of copying in bulk. 'replace' functionality of ovsdb_datum_union() had no users, so it just removed. But it can easily be added back if needed in the future. Signed-off-by: Ilya Maximets <i.maximets@ovn.org> Acked-by: Han Zhou <hzhou@ovn.org> Acked-by: Mark D. Gray <mark.d.gray@redhat.com>
2021-09-23 01:47:22 +02:00
bool ovsdb_datum_find_key(const struct ovsdb_datum *,
const union ovsdb_atom *key,
enum ovsdb_atomic_type key_type,
unsigned int *pos);
unsigned int ovsdb_datum_find_key_value(const struct ovsdb_datum *,
const union ovsdb_atom *key,
enum ovsdb_atomic_type key_type,
const union ovsdb_atom *value,
enum ovsdb_atomic_type value_type);
/* Set operations. */
2009-11-04 15:11:44 -08:00
bool ovsdb_datum_includes_all(const struct ovsdb_datum *,
const struct ovsdb_datum *,
const struct ovsdb_type *);
bool ovsdb_datum_excludes_all(const struct ovsdb_datum *,
const struct ovsdb_datum *,
const struct ovsdb_type *);
void ovsdb_datum_union(struct ovsdb_datum *,
const struct ovsdb_datum *,
ovsdb-data: Optimize union of sets. Current algorithm of ovsdb_datum_union looks like this: for-each atom in b: if not bin_search(a, atom): push(a, clone(atom)) quicksort(a) So, the complexity looks like this: Nb * log2(Na) + Nb + (Na + Nb) * log2(Na + Nb) Comparisons clones Comparisons for quicksort for search ovsdb_datum_union() is heavily used in database transactions while new element is added to a set. For example, if new logical switch port is added to a logical switch in OVN. This is a very common use case where CMS adds one new port to an existing switch that already has, let's say, 100 ports. For this case ovsdb-server will have to perform: 1 * log2(100) + 1 clone + 101 * log2(101) Comparisons Comparisons for for search quicksort. ~7 1 ~707 Roughly 714 comparisons of atoms and 1 clone. Since binary search can give us position, where new atom should go (it's the 'low' index after the search completion) for free, the logic can be re-worked like this: copied = 0 for-each atom in b: desired_position = bin_search(a, atom) push(result, a[ copied : desired_position - 1 ]) copied = desired_position push(result, clone(atom)) push(result, a[ copied : Na ]) swap(a, result) Complexity of this schema: Nb * log2(Na) + Nb + Na Comparisons clones memory copy on push for search 'swap' is just a swap of a few pointers. 'push' is not a 'clone', but a simple memory copy of 'union ovsdb_atom'. In general, this schema substitutes complexity of a quicksort with complexity of a memory copy of Na atom structures, where we're not even copying strings that these atoms are pointing to. Complexity in the example above goes down from 714 comparisons to 7 comparisons and memcpy of 100 * sizeof (union ovsdb_atom) bytes. General complexity of a memory copy should always be lower than complexity of a quicksort, especially because these copies usually performed in bulk, so this new schema should work faster for any input. All in all, this change allows to execute several times more transactions per second for transactions that adds new entries to sets. Alternatively, union can be implemented as a linear merge of two sorted arrays, but this will result in O(Na) comparisons, which is more than Nb * log2(Na) in common case, since Na is usually far bigger than Nb. Linear merge will also mean per-atom memory copies instead of copying in bulk. 'replace' functionality of ovsdb_datum_union() had no users, so it just removed. But it can easily be added back if needed in the future. Signed-off-by: Ilya Maximets <i.maximets@ovn.org> Acked-by: Han Zhou <hzhou@ovn.org> Acked-by: Mark D. Gray <mark.d.gray@redhat.com>
2021-09-23 01:47:22 +02:00
const struct ovsdb_type *);
void ovsdb_datum_subtract(struct ovsdb_datum *a,
const struct ovsdb_type *a_type,
const struct ovsdb_datum *b,
const struct ovsdb_type *b_type);
/* Generate and apply diffs */
void ovsdb_datum_added_removed(struct ovsdb_datum *added,
struct ovsdb_datum *removed,
const struct ovsdb_datum *old,
const struct ovsdb_datum *new,
const struct ovsdb_type *type);
void ovsdb_datum_diff(struct ovsdb_datum *diff,
const struct ovsdb_datum *old_datum,
const struct ovsdb_datum *new_datum,
const struct ovsdb_type *type);
struct ovsdb_error *ovsdb_datum_apply_diff(struct ovsdb_datum *new_datum,
const struct ovsdb_datum *old_datum,
const struct ovsdb_datum *diff,
const struct ovsdb_type *type)
OVS_WARN_UNUSED_RESULT;
struct ovsdb_error * ovsdb_datum_apply_diff_in_place(
struct ovsdb_datum *a,
const struct ovsdb_datum *diff,
const struct ovsdb_type *type)
OVS_WARN_UNUSED_RESULT;
/* Raw operations that may not maintain the invariants. */
void ovsdb_datum_remove_unsafe(struct ovsdb_datum *, size_t idx,
const struct ovsdb_type *);
void ovsdb_datum_add_unsafe(struct ovsdb_datum *,
const union ovsdb_atom *key,
const union ovsdb_atom *value,
const struct ovsdb_type *,
const union ovsdb_atom *range_end_atom);
treewide: Avoid offsetting NULL pointers. This is undefined behavior and was reported by UB Sanitizer: lib/meta-flow.c:3445:16: runtime error: member access within null pointer of type 'struct vl_mf_field' 0 0x6aad0f in mf_get_vl_mff lib/meta-flow.c:3445 1 0x6d96d7 in mf_from_oxm_header lib/nx-match.c:260 2 0x6d9e2e in nx_pull_header__ lib/nx-match.c:341 3 0x6daafa in nx_pull_header lib/nx-match.c:488 4 0x6abcb6 in mf_vl_mff_nx_pull_header lib/meta-flow.c:3605 5 0x73b9be in decode_NXAST_RAW_REG_MOVE lib/ofp-actions.c:2652 6 0x764ccd in ofpact_decode lib/ofp-actions.inc2:4681 [...] lib/sset.c:315:12: runtime error: applying zero offset to null pointer 0 0xcc2e6a in sset_at_position lib/sset.c:315:12 1 0x5734b3 in port_dump_next ofproto/ofproto-dpif.c:4083:20 [...] lib/ovsdb-data.c:2194:56: runtime error: applying zero offset to null pointer 0 0x5e9530 in ovsdb_datum_added_removed lib/ovsdb-data.c:2194:56 1 0x4d6258 in update_row_ref_count ovsdb/transaction.c:335:17 2 0x4c360b in for_each_txn_row ovsdb/transaction.c:1572:33 [...] lib/ofpbuf.c:440:30: runtime error: applying zero offset to null pointer 0 0x75066d in ofpbuf_push_uninit lib/ofpbuf.c:440 1 0x46ac8a in ovnacts_parse lib/actions.c:4190 2 0x46ad91 in ovnacts_parse_string lib/actions.c:4208 3 0x4106d1 in test_parse_actions tests/test-ovn.c:1324 [...] lib/ofp-actions.c:3205:22: runtime error: applying non-zero offset 2 to null pointer 0 0x6e1641 in set_field_split_str lib/ofp-actions.c:3205:22 [...] lib/tnl-ports.c:74:12: runtime error: applying zero offset to null pointer 0 0xceffe7 in tnl_port_cast lib/tnl-ports.c:74:12 1 0xcf14c3 in map_insert lib/tnl-ports.c:116:13 [...] ofproto/ofproto.c:8905:16: runtime error: applying zero offset to null pointer 0 0x556795 in eviction_group_hash_rule ofproto/ofproto.c:8905:16 1 0x503f8d in eviction_group_add_rule ofproto/ofproto.c:9022:42 [...] Also, it's valid to have an empty ofpact list and we should be able to try to iterate through it. UB Sanitizer report: include/openvswitch/ofp-actions.h:222:12: runtime error: applying zero offset to null pointer 0 0x665d69 in ofpact_end ./include/openvswitch/ofp-actions.h:222:12 1 0x66b2cf in ofpacts_put_openflow_actions lib/ofp-actions.c:8861:5 2 0x6ffdd1 in ofputil_encode_flow_mod lib/ofp-flow.c:447:9 [...] Signed-off-by: Dumitru Ceara <dceara@redhat.com> Acked-by: Aaron Conole <aconole@redhat.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
2022-04-11 13:37:50 +02:00
void ovsdb_datum_add_from_index_unsafe(struct ovsdb_datum *dst,
const struct ovsdb_datum *src,
size_t idx,
const struct ovsdb_type *type);
/* Transactions with named-uuid row names. */
struct json *ovsdb_datum_to_json_with_row_names(const struct ovsdb_datum *,
const struct ovsdb_type *);
char *ovsdb_data_row_name(const struct uuid *);
/* Type checking. */
2009-11-04 15:11:44 -08:00
static inline bool
ovsdb_datum_conforms_to_type(const struct ovsdb_datum *datum,
const struct ovsdb_type *type)
{
return datum->n >= type->n_min && datum->n <= type->n_max;
}
/* A table mapping from names to data items. Currently the data items are
* always UUIDs; perhaps this will be expanded in the future. */
struct ovsdb_symbol_table {
struct shash sh; /* Maps from name to struct ovsdb_symbol *. */
};
struct ovsdb_symbol {
struct uuid uuid; /* The UUID that the symbol represents. */
bool created; /* Already used to create row? */
2011-03-10 11:15:01 -08:00
bool strong_ref; /* Parsed a strong reference to this row? */
bool weak_ref; /* Parsed a weak reference to this row? */
};
2009-11-04 15:11:44 -08:00
struct ovsdb_symbol_table *ovsdb_symbol_table_create(void);
void ovsdb_symbol_table_destroy(struct ovsdb_symbol_table *);
struct ovsdb_symbol *ovsdb_symbol_table_get(const struct ovsdb_symbol_table *,
const char *name);
struct ovsdb_symbol *ovsdb_symbol_table_put(struct ovsdb_symbol_table *,
const char *name,
const struct uuid *, bool used);
struct ovsdb_symbol *ovsdb_symbol_table_insert(struct ovsdb_symbol_table *,
const char *name);
/* Tokenization
*
* Used by ovsdb_atom_from_string() and ovsdb_datum_from_string(). */
char *ovsdb_token_parse(const char **, char **outp) OVS_WARN_UNUSED_RESULT;
bool ovsdb_token_is_delim(unsigned char);
2009-11-04 15:11:44 -08:00
struct ovsdb_error *ovsdb_atom_range_check_size(int64_t range_start,
int64_t range_end);
#ifdef __cplusplus
}
#endif
2009-11-04 15:11:44 -08:00
#endif /* ovsdb-data.h */