2009-07-08 13:19:16 -07:00
|
|
|
/*
|
2012-05-02 15:21:36 -07:00
|
|
|
* Copyright (c) 2009, 2010, 2011, 2012 Nicira, Inc.
|
2009-07-08 13:19:16 -07:00
|
|
|
*
|
2009-06-15 15:11:30 -07:00
|
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
* you may not use this file except in compliance with the License.
|
|
|
|
* You may obtain a copy of the License at:
|
2009-07-08 13:19:16 -07:00
|
|
|
*
|
2009-06-15 15:11:30 -07:00
|
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
*
|
|
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
* See the License for the specific language governing permissions and
|
|
|
|
* limitations under the License.
|
2009-07-08 13:19:16 -07:00
|
|
|
*/
|
|
|
|
|
|
|
|
#include <config.h>
|
|
|
|
#include "coverage.h"
|
|
|
|
#include <inttypes.h>
|
|
|
|
#include <stdlib.h>
|
|
|
|
#include "dynamic-string.h"
|
|
|
|
#include "hash.h"
|
2012-04-20 14:09:30 -07:00
|
|
|
#include "svec.h"
|
2012-02-06 10:21:59 -08:00
|
|
|
#include "timeval.h"
|
2009-07-10 15:09:41 -07:00
|
|
|
#include "unixctl.h"
|
2009-07-08 13:19:16 -07:00
|
|
|
#include "util.h"
|
|
|
|
#include "vlog.h"
|
|
|
|
|
2010-10-19 14:47:01 -07:00
|
|
|
VLOG_DEFINE_THIS_MODULE(coverage);
|
2010-07-16 11:02:49 -07:00
|
|
|
|
coverage: Make the coverage counters catalog program-specific.
Until now, the collection of coverage counters supported by a given OVS
program was not specific to that program. That means that, for example,
even though ovs-dpctl does not have anything to do with mac_learning, it
still has a coverage counter for it. This is confusing, at best.
This commit fixes the problem on some systems, in particular on ones that
use GCC and the GNU linker. It uses the feature of the GNU linker
described in its manual as:
If an orphaned section's name is representable as a C identifier then
the linker will automatically see PROVIDE two symbols: __start_SECNAME
and __end_SECNAME, where SECNAME is the name of the section. These
indicate the start address and end address of the orphaned section
respectively.
Systems that don't support these features retain the earlier behavior.
This commit also fixes the annoyance that files that include coverage
counters must be listed on COVERAGE_FILES in lib/automake.mk.
This commit also fixes the annoyance that modifying any source file that
includes a coverage counter caused all programs that link against
libopenvswitch.a to relink, even programs that the source file was not
linked into. For example, modifying ofproto/ofproto.c (which includes
coverage counters) caused tests/test-aes128 to relink, even though
test-aes128 does not link again ofproto.o.
2010-11-01 14:14:27 -07:00
|
|
|
/* The coverage counters. */
|
|
|
|
#if USE_LINKER_SECTIONS
|
|
|
|
extern struct coverage_counter *__start_coverage[];
|
|
|
|
extern struct coverage_counter *__stop_coverage[];
|
|
|
|
#define coverage_counters __start_coverage
|
|
|
|
#define n_coverage_counters (__stop_coverage - __start_coverage)
|
|
|
|
#else /* !USE_LINKER_SECTIONS */
|
|
|
|
#define COVERAGE_COUNTER(NAME) COVERAGE_DEFINE__(NAME);
|
|
|
|
#include "coverage.def"
|
|
|
|
#undef COVERAGE_COUNTER
|
|
|
|
|
|
|
|
struct coverage_counter *coverage_counters[] = {
|
|
|
|
#define COVERAGE_COUNTER(NAME) &counter_##NAME,
|
|
|
|
#include "coverage.def"
|
|
|
|
#undef COVERAGE_COUNTER
|
|
|
|
};
|
|
|
|
#define n_coverage_counters ARRAY_SIZE(coverage_counters)
|
|
|
|
#endif /* !USE_LINKER_SECTIONS */
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
static unsigned int epoch;
|
|
|
|
|
2012-04-20 14:09:30 -07:00
|
|
|
static void coverage_read(struct svec *);
|
|
|
|
|
2009-07-10 15:09:41 -07:00
|
|
|
static void
|
2012-04-20 14:09:30 -07:00
|
|
|
coverage_unixctl_show(struct unixctl_conn *conn, int argc OVS_UNUSED,
|
2011-12-02 15:29:19 -08:00
|
|
|
const char *argv[] OVS_UNUSED, void *aux OVS_UNUSED)
|
2009-07-10 15:09:41 -07:00
|
|
|
{
|
2012-04-20 14:09:30 -07:00
|
|
|
struct svec lines;
|
|
|
|
char *reply;
|
|
|
|
|
|
|
|
svec_init(&lines);
|
|
|
|
coverage_read(&lines);
|
|
|
|
reply = svec_join(&lines, "\n", "\n");
|
|
|
|
unixctl_command_reply(conn, reply);
|
|
|
|
free(reply);
|
|
|
|
svec_destroy(&lines);
|
2009-07-10 15:09:41 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
void
|
|
|
|
coverage_init(void)
|
|
|
|
{
|
2012-04-20 14:09:30 -07:00
|
|
|
unixctl_command_register("coverage/show", "", 0, 0,
|
|
|
|
coverage_unixctl_show, NULL);
|
2009-07-10 15:09:41 -07:00
|
|
|
}
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
/* Sorts coverage counters in descending order by count, within equal counts
|
|
|
|
* alphabetically by name. */
|
|
|
|
static int
|
|
|
|
compare_coverage_counters(const void *a_, const void *b_)
|
|
|
|
{
|
|
|
|
const struct coverage_counter *const *ap = a_;
|
|
|
|
const struct coverage_counter *const *bp = b_;
|
|
|
|
const struct coverage_counter *a = *ap;
|
|
|
|
const struct coverage_counter *b = *bp;
|
|
|
|
if (a->count != b->count) {
|
|
|
|
return a->count < b->count ? 1 : -1;
|
|
|
|
} else {
|
|
|
|
return strcmp(a->name, b->name);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static uint32_t
|
|
|
|
coverage_hash(void)
|
|
|
|
{
|
|
|
|
struct coverage_counter **c;
|
|
|
|
uint32_t hash = 0;
|
|
|
|
int n_groups, i;
|
|
|
|
|
|
|
|
/* Sort coverage counters into groups with equal counts. */
|
coverage: Make the coverage counters catalog program-specific.
Until now, the collection of coverage counters supported by a given OVS
program was not specific to that program. That means that, for example,
even though ovs-dpctl does not have anything to do with mac_learning, it
still has a coverage counter for it. This is confusing, at best.
This commit fixes the problem on some systems, in particular on ones that
use GCC and the GNU linker. It uses the feature of the GNU linker
described in its manual as:
If an orphaned section's name is representable as a C identifier then
the linker will automatically see PROVIDE two symbols: __start_SECNAME
and __end_SECNAME, where SECNAME is the name of the section. These
indicate the start address and end address of the orphaned section
respectively.
Systems that don't support these features retain the earlier behavior.
This commit also fixes the annoyance that files that include coverage
counters must be listed on COVERAGE_FILES in lib/automake.mk.
This commit also fixes the annoyance that modifying any source file that
includes a coverage counter caused all programs that link against
libopenvswitch.a to relink, even programs that the source file was not
linked into. For example, modifying ofproto/ofproto.c (which includes
coverage counters) caused tests/test-aes128 to relink, even though
test-aes128 does not link again ofproto.o.
2010-11-01 14:14:27 -07:00
|
|
|
c = xmalloc(n_coverage_counters * sizeof *c);
|
|
|
|
for (i = 0; i < n_coverage_counters; i++) {
|
2009-07-08 13:19:16 -07:00
|
|
|
c[i] = coverage_counters[i];
|
|
|
|
}
|
coverage: Make the coverage counters catalog program-specific.
Until now, the collection of coverage counters supported by a given OVS
program was not specific to that program. That means that, for example,
even though ovs-dpctl does not have anything to do with mac_learning, it
still has a coverage counter for it. This is confusing, at best.
This commit fixes the problem on some systems, in particular on ones that
use GCC and the GNU linker. It uses the feature of the GNU linker
described in its manual as:
If an orphaned section's name is representable as a C identifier then
the linker will automatically see PROVIDE two symbols: __start_SECNAME
and __end_SECNAME, where SECNAME is the name of the section. These
indicate the start address and end address of the orphaned section
respectively.
Systems that don't support these features retain the earlier behavior.
This commit also fixes the annoyance that files that include coverage
counters must be listed on COVERAGE_FILES in lib/automake.mk.
This commit also fixes the annoyance that modifying any source file that
includes a coverage counter caused all programs that link against
libopenvswitch.a to relink, even programs that the source file was not
linked into. For example, modifying ofproto/ofproto.c (which includes
coverage counters) caused tests/test-aes128 to relink, even though
test-aes128 does not link again ofproto.o.
2010-11-01 14:14:27 -07:00
|
|
|
qsort(c, n_coverage_counters, sizeof *c, compare_coverage_counters);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
|
|
/* Hash the names in each group along with the rank. */
|
|
|
|
n_groups = 0;
|
coverage: Make the coverage counters catalog program-specific.
Until now, the collection of coverage counters supported by a given OVS
program was not specific to that program. That means that, for example,
even though ovs-dpctl does not have anything to do with mac_learning, it
still has a coverage counter for it. This is confusing, at best.
This commit fixes the problem on some systems, in particular on ones that
use GCC and the GNU linker. It uses the feature of the GNU linker
described in its manual as:
If an orphaned section's name is representable as a C identifier then
the linker will automatically see PROVIDE two symbols: __start_SECNAME
and __end_SECNAME, where SECNAME is the name of the section. These
indicate the start address and end address of the orphaned section
respectively.
Systems that don't support these features retain the earlier behavior.
This commit also fixes the annoyance that files that include coverage
counters must be listed on COVERAGE_FILES in lib/automake.mk.
This commit also fixes the annoyance that modifying any source file that
includes a coverage counter caused all programs that link against
libopenvswitch.a to relink, even programs that the source file was not
linked into. For example, modifying ofproto/ofproto.c (which includes
coverage counters) caused tests/test-aes128 to relink, even though
test-aes128 does not link again ofproto.o.
2010-11-01 14:14:27 -07:00
|
|
|
for (i = 0; i < n_coverage_counters; ) {
|
2009-07-08 13:19:16 -07:00
|
|
|
int j;
|
|
|
|
|
|
|
|
if (!c[i]->count) {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
n_groups++;
|
|
|
|
hash = hash_int(i, hash);
|
coverage: Make the coverage counters catalog program-specific.
Until now, the collection of coverage counters supported by a given OVS
program was not specific to that program. That means that, for example,
even though ovs-dpctl does not have anything to do with mac_learning, it
still has a coverage counter for it. This is confusing, at best.
This commit fixes the problem on some systems, in particular on ones that
use GCC and the GNU linker. It uses the feature of the GNU linker
described in its manual as:
If an orphaned section's name is representable as a C identifier then
the linker will automatically see PROVIDE two symbols: __start_SECNAME
and __end_SECNAME, where SECNAME is the name of the section. These
indicate the start address and end address of the orphaned section
respectively.
Systems that don't support these features retain the earlier behavior.
This commit also fixes the annoyance that files that include coverage
counters must be listed on COVERAGE_FILES in lib/automake.mk.
This commit also fixes the annoyance that modifying any source file that
includes a coverage counter caused all programs that link against
libopenvswitch.a to relink, even programs that the source file was not
linked into. For example, modifying ofproto/ofproto.c (which includes
coverage counters) caused tests/test-aes128 to relink, even though
test-aes128 does not link again ofproto.o.
2010-11-01 14:14:27 -07:00
|
|
|
for (j = i; j < n_coverage_counters; j++) {
|
2009-07-08 13:19:16 -07:00
|
|
|
if (c[j]->count != c[i]->count) {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
hash = hash_string(c[j]->name, hash);
|
|
|
|
}
|
|
|
|
i = j;
|
|
|
|
}
|
|
|
|
|
|
|
|
free(c);
|
|
|
|
|
|
|
|
return hash_int(n_groups, hash);
|
|
|
|
}
|
|
|
|
|
|
|
|
static bool
|
|
|
|
coverage_hit(uint32_t hash)
|
|
|
|
{
|
|
|
|
enum { HIT_BITS = 1024, BITS_PER_WORD = 32 };
|
|
|
|
static uint32_t hit[HIT_BITS / BITS_PER_WORD];
|
|
|
|
BUILD_ASSERT_DECL(IS_POW2(HIT_BITS));
|
|
|
|
|
2012-02-06 10:21:59 -08:00
|
|
|
static long long int next_clear = LLONG_MIN;
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
unsigned int bit_index = hash & (HIT_BITS - 1);
|
|
|
|
unsigned int word_index = bit_index / BITS_PER_WORD;
|
|
|
|
unsigned int word_mask = 1u << (bit_index % BITS_PER_WORD);
|
|
|
|
|
2012-02-06 10:21:59 -08:00
|
|
|
/* Expire coverage hash suppression once a day. */
|
|
|
|
if (time_msec() >= next_clear) {
|
|
|
|
memset(hit, 0, sizeof hit);
|
|
|
|
next_clear = time_msec() + 60 * 60 * 24 * 1000LL;
|
|
|
|
}
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
if (hit[word_index] & word_mask) {
|
2012-02-06 10:21:59 -08:00
|
|
|
return true;
|
2009-07-08 13:19:16 -07:00
|
|
|
} else {
|
|
|
|
hit[word_index] |= word_mask;
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-04-20 14:09:30 -07:00
|
|
|
/* Logs the coverage counters, unless a similar set of events has already been
|
|
|
|
* logged.
|
|
|
|
*
|
|
|
|
* This function logs at log level VLL_INFO. Use care before adjusting this
|
|
|
|
* level, because depending on its configuration, syslogd can write changes
|
|
|
|
* synchronously, which can cause the coverage messages to take several seconds
|
|
|
|
* to write. */
|
|
|
|
void
|
|
|
|
coverage_log(void)
|
|
|
|
{
|
|
|
|
static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 3);
|
|
|
|
|
|
|
|
if (!VLOG_DROP_INFO(&rl)) {
|
|
|
|
uint32_t hash = coverage_hash();
|
|
|
|
if (coverage_hit(hash)) {
|
|
|
|
VLOG_INFO("Skipping details of duplicate event coverage for "
|
|
|
|
"hash=%08"PRIx32" in epoch %u", hash, epoch);
|
|
|
|
} else {
|
|
|
|
struct svec lines;
|
|
|
|
const char *line;
|
|
|
|
size_t i;
|
|
|
|
|
|
|
|
svec_init(&lines);
|
|
|
|
coverage_read(&lines);
|
|
|
|
SVEC_FOR_EACH (i, line, &lines) {
|
|
|
|
VLOG_INFO("%s", line);
|
|
|
|
}
|
|
|
|
svec_destroy(&lines);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
static void
|
2012-04-20 14:09:30 -07:00
|
|
|
coverage_read_counter(struct svec *lines, const struct coverage_counter *c)
|
2009-07-08 13:19:16 -07:00
|
|
|
{
|
2012-04-20 14:09:30 -07:00
|
|
|
svec_add_nocopy(lines, xasprintf("%-24s %5u / %9llu",
|
|
|
|
c->name, c->count, c->count + c->total));
|
2009-07-08 13:19:16 -07:00
|
|
|
}
|
|
|
|
|
2012-04-20 14:09:30 -07:00
|
|
|
/* Adds coverage counter information to 'lines'. */
|
|
|
|
static void
|
|
|
|
coverage_read(struct svec *lines)
|
2009-07-08 13:19:16 -07:00
|
|
|
{
|
|
|
|
size_t n_never_hit;
|
|
|
|
uint32_t hash;
|
|
|
|
size_t i;
|
|
|
|
|
2009-07-14 00:25:44 -07:00
|
|
|
hash = coverage_hash();
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
|
|
n_never_hit = 0;
|
2012-04-20 14:09:30 -07:00
|
|
|
svec_add_nocopy(lines, xasprintf("Event coverage (epoch %u/entire run), "
|
|
|
|
"hash=%08"PRIx32":", epoch, hash));
|
coverage: Make the coverage counters catalog program-specific.
Until now, the collection of coverage counters supported by a given OVS
program was not specific to that program. That means that, for example,
even though ovs-dpctl does not have anything to do with mac_learning, it
still has a coverage counter for it. This is confusing, at best.
This commit fixes the problem on some systems, in particular on ones that
use GCC and the GNU linker. It uses the feature of the GNU linker
described in its manual as:
If an orphaned section's name is representable as a C identifier then
the linker will automatically see PROVIDE two symbols: __start_SECNAME
and __end_SECNAME, where SECNAME is the name of the section. These
indicate the start address and end address of the orphaned section
respectively.
Systems that don't support these features retain the earlier behavior.
This commit also fixes the annoyance that files that include coverage
counters must be listed on COVERAGE_FILES in lib/automake.mk.
This commit also fixes the annoyance that modifying any source file that
includes a coverage counter caused all programs that link against
libopenvswitch.a to relink, even programs that the source file was not
linked into. For example, modifying ofproto/ofproto.c (which includes
coverage counters) caused tests/test-aes128 to relink, even though
test-aes128 does not link again ofproto.o.
2010-11-01 14:14:27 -07:00
|
|
|
for (i = 0; i < n_coverage_counters; i++) {
|
2009-07-08 13:19:16 -07:00
|
|
|
struct coverage_counter *c = coverage_counters[i];
|
|
|
|
if (c->count) {
|
2012-04-20 14:09:30 -07:00
|
|
|
coverage_read_counter(lines, c);
|
2009-07-08 13:19:16 -07:00
|
|
|
}
|
|
|
|
}
|
coverage: Make the coverage counters catalog program-specific.
Until now, the collection of coverage counters supported by a given OVS
program was not specific to that program. That means that, for example,
even though ovs-dpctl does not have anything to do with mac_learning, it
still has a coverage counter for it. This is confusing, at best.
This commit fixes the problem on some systems, in particular on ones that
use GCC and the GNU linker. It uses the feature of the GNU linker
described in its manual as:
If an orphaned section's name is representable as a C identifier then
the linker will automatically see PROVIDE two symbols: __start_SECNAME
and __end_SECNAME, where SECNAME is the name of the section. These
indicate the start address and end address of the orphaned section
respectively.
Systems that don't support these features retain the earlier behavior.
This commit also fixes the annoyance that files that include coverage
counters must be listed on COVERAGE_FILES in lib/automake.mk.
This commit also fixes the annoyance that modifying any source file that
includes a coverage counter caused all programs that link against
libopenvswitch.a to relink, even programs that the source file was not
linked into. For example, modifying ofproto/ofproto.c (which includes
coverage counters) caused tests/test-aes128 to relink, even though
test-aes128 does not link again ofproto.o.
2010-11-01 14:14:27 -07:00
|
|
|
for (i = 0; i < n_coverage_counters; i++) {
|
2009-07-08 13:19:16 -07:00
|
|
|
struct coverage_counter *c = coverage_counters[i];
|
|
|
|
if (!c->count) {
|
|
|
|
if (c->total) {
|
2012-04-20 14:09:30 -07:00
|
|
|
coverage_read_counter(lines, c);
|
2009-07-08 13:19:16 -07:00
|
|
|
} else {
|
|
|
|
n_never_hit++;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2012-04-20 14:09:30 -07:00
|
|
|
svec_add_nocopy(lines, xasprintf("%zu events never hit", n_never_hit));
|
2009-07-08 13:19:16 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Advances to the next epoch of coverage, resetting all the counters to 0. */
|
|
|
|
void
|
|
|
|
coverage_clear(void)
|
|
|
|
{
|
|
|
|
size_t i;
|
|
|
|
|
|
|
|
epoch++;
|
coverage: Make the coverage counters catalog program-specific.
Until now, the collection of coverage counters supported by a given OVS
program was not specific to that program. That means that, for example,
even though ovs-dpctl does not have anything to do with mac_learning, it
still has a coverage counter for it. This is confusing, at best.
This commit fixes the problem on some systems, in particular on ones that
use GCC and the GNU linker. It uses the feature of the GNU linker
described in its manual as:
If an orphaned section's name is representable as a C identifier then
the linker will automatically see PROVIDE two symbols: __start_SECNAME
and __end_SECNAME, where SECNAME is the name of the section. These
indicate the start address and end address of the orphaned section
respectively.
Systems that don't support these features retain the earlier behavior.
This commit also fixes the annoyance that files that include coverage
counters must be listed on COVERAGE_FILES in lib/automake.mk.
This commit also fixes the annoyance that modifying any source file that
includes a coverage counter caused all programs that link against
libopenvswitch.a to relink, even programs that the source file was not
linked into. For example, modifying ofproto/ofproto.c (which includes
coverage counters) caused tests/test-aes128 to relink, even though
test-aes128 does not link again ofproto.o.
2010-11-01 14:14:27 -07:00
|
|
|
for (i = 0; i < n_coverage_counters; i++) {
|
2009-07-08 13:19:16 -07:00
|
|
|
struct coverage_counter *c = coverage_counters[i];
|
|
|
|
c->total += c->count;
|
|
|
|
c->count = 0;
|
|
|
|
}
|
|
|
|
}
|