2009-07-08 13:19:16 -07:00
|
|
|
|
/*
|
2017-04-05 22:49:27 -07:00
|
|
|
|
* Copyright (c) 2008, 2009, 2010, 2011, 2012, 2013, 2014, 2015, 2016, 2017 Nicira, Inc.
|
2009-07-08 13:19:16 -07:00
|
|
|
|
*
|
2009-06-15 15:11:30 -07:00
|
|
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
|
* you may not use this file except in compliance with the License.
|
|
|
|
|
* You may obtain a copy of the License at:
|
2009-07-08 13:19:16 -07:00
|
|
|
|
*
|
2009-06-15 15:11:30 -07:00
|
|
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
|
*
|
|
|
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
|
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
|
* See the License for the specific language governing permissions and
|
|
|
|
|
* limitations under the License.
|
2009-07-08 13:19:16 -07:00
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#ifndef UTIL_H
|
|
|
|
|
#define UTIL_H 1
|
|
|
|
|
|
2017-11-06 14:42:32 -08:00
|
|
|
|
#include <sys/types.h>
|
|
|
|
|
#include <netinet/in.h>
|
2014-12-04 16:05:33 -08:00
|
|
|
|
#include <arpa/inet.h>
|
lib/ofpbuf: Compact
This patch shrinks the struct ofpbuf from 104 to 48 bytes on 64-bit
systems, or from 52 to 36 bytes on 32-bit systems (counting in the
'l7' removal from an earlier patch). This may help contribute to
cache efficiency, and will speed up initializing, copying and
manipulating ofpbufs. This is potentially important for the DPDK
datapath, but the rest of the code base may also see a little benefit.
Changes are:
- Remove 'l7' pointer (previous patch).
- Use offsets instead of layer pointers for l2_5, l3, and l4 using
'l2' as basis. Usually 'data' is the same as 'l2', but this is not
always the case (e.g., when parsing or constructing a packet), so it
can not be easily used as the offset basis. Also, packet parsing is
faster if we do not need to maintain the offsets each time we pull
data from the ofpbuf.
- Use uint32_t for 'allocated' and 'size', as 2^32 is enough even for
largest possible messages/packets.
- Use packed enum for 'source'.
- Rearrange to avoid unnecessary padding.
- Remove 'private_p', which was used only in two cases, both of which
had the invariant ('l2' == 'data'), so we can temporarily use 'l2'
as a private pointer.
Signed-off-by: Jarno Rajahalme <jrajahalme@nicira.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
2014-03-24 09:17:01 -07:00
|
|
|
|
#include <inttypes.h>
|
util: New function popcount().
This is the fastest portable implementation among the ones below, as
measured with GCC 4.4 on a Xeon X3430. The measeured times were, in
seconds:
popcount1 25.6
popcount2 6.9 (but is not portable)
popcount3 31.4
popcount4 25.6
popcount5 61.6 (and is buggy)
popcount6 64.6
popcount7 32.3
popcount8 11.2
int
popcount1(unsigned int x)
{
return __builtin_popcount(x);
}
int
popcount2(unsigned int x)
{
unsigned int y;
asm("popcnt %1, %0" : "=r" (y) : "g" (x));
return y;
}
int
popcount3(unsigned int x)
{
unsigned int n;
n = (x >> 1) & 033333333333;
x -= n;
n = (n >> 1) & 033333333333;
x -= n;
x = (x + (x >> 3)) & 030707070707;
return x % 63;
}
int
popcount4(unsigned int x)
{
x -= (x >> 1) & 0x55555555;
x = (x & 0x33333333) + ((x >> 2) & 0x33333333);
x = (x + (x >> 4)) & 0x0f0f0f0f;
x += x >> 8;
x += x >> 16;
return x & 0x3f;
}
int
popcount5(unsigned int x)
{
int n;
n = 0;
while (x) {
if (x & 0xf) {
n += ((0xe9949440 >> (x & 0xf)) & 3) + 1;
}
x >>= 4;
}
return n;
}
int
popcount6(unsigned int x)
{
int n;
n = 0;
while (x) {
n += (0xe994 >> (x & 7)) & 3;
x >>= 3;
}
return n;
}
int
popcount7(unsigned int x)
{
static const int table[16] = {
0, 1, 1, 2, 1, 2, 2, 3, 1, 2, 2, 3, 2, 3, 3, 4
};
return (table[x & 0xf]
+ table[(x >> 4) & 0xf]
+ table[(x >> 8) & 0xf]
+ table[(x >> 12) & 0xf]
+ table[(x >> 16) & 0xf]
+ table[(x >> 20) & 0xf]
+ table[(x >> 24) & 0xf]
+ table[x >> 28]);
}
static int
popcount8(unsigned int x)
{
((((X) & (1 << 0)) != 0) + \
(((X) & (1 << 1)) != 0) + \
(((X) & (1 << 2)) != 0) + \
(((X) & (1 << 3)) != 0) + \
(((X) & (1 << 4)) != 0) + \
(((X) & (1 << 5)) != 0) + \
(((X) & (1 << 6)) != 0) + \
(((X) & (1 << 7)) != 0))
static const uint8_t popcount8[256] = {
INIT64(0), INIT64(64), INIT64(128), INIT64(192)
};
return (popcount8[x & 0xff] +
popcount8[(x >> 8) & 0xff] +
popcount8[(x >> 16) & 0xff] +
popcount8[x >> 24]);
}
int
main(void)
{
unsigned long long int x;
int n;
n = 0;
for (x = 0; x <= UINT32_MAX; x++) {
n += popcount8(x);
}
printf("%d\n", n);
return 0;
}
Signed-off-by: Ben Pfaff <blp@nicira.com>
2012-07-20 12:38:59 -07:00
|
|
|
|
#include <limits.h>
|
2016-04-22 05:19:23 +00:00
|
|
|
|
#include <stdarg.h>
|
2009-07-08 13:19:16 -07:00
|
|
|
|
#include <stdio.h>
|
bfd: Implement Bidirectional Forwarding Detection.
Traditionally, Open vSwitch has used a variant of 802.1ag "CFM" for
interface liveness detection. This has served us well until now,
but has several serious drawbacks which have steadily become more
inconvenient. First, the 802.1ag standard does not implement
several useful features forcing us to (optionally) break
compatibility. Second, 802.1.ag is not particularly popular
outside of carrier grade networking equipment. Third, 802.1ag is
simply quite awkward.
In an effort to solve the aforementioned problems, this patch
implements BFD which is ubiquitous, well designed, straight
forward, and implements required features in a standard way. The
initial cut of the protocol focuses on getting the basics of the
specification correct, leaving performance optimizations, and
advanced features as future work. The protocol should be
considered experimental pending future testing.
Signed-off-by: Ethan Jackson <ethan@nicira.com>
2012-06-08 12:42:42 -07:00
|
|
|
|
#include <stdlib.h>
|
2009-07-08 13:19:16 -07:00
|
|
|
|
#include <string.h>
|
|
|
|
|
#include "compiler.h"
|
2016-07-12 16:37:34 -05:00
|
|
|
|
#include "util.h"
|
2014-11-24 12:49:01 +01:00
|
|
|
|
#include "openvswitch/util.h"
|
2019-06-13 18:38:07 +08:00
|
|
|
|
#if defined(__aarch64__) && __GNUC__ >= 6
|
|
|
|
|
#include <arm_neon.h>
|
|
|
|
|
#endif
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2014-07-08 04:11:53 +00:00
|
|
|
|
extern char *program_name;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2013-10-02 02:40:09 -03:00
|
|
|
|
#define __ARRAY_SIZE_NOCHECK(ARRAY) (sizeof(ARRAY) / sizeof((ARRAY)[0]))
|
2017-11-01 14:40:27 -07:00
|
|
|
|
#if __GNUC__ && !defined(__cplusplus)
|
2013-10-02 02:40:09 -03:00
|
|
|
|
/* return 0 for array types, 1 otherwise */
|
|
|
|
|
#define __ARRAY_CHECK(ARRAY) \
|
|
|
|
|
!__builtin_types_compatible_p(typeof(ARRAY), typeof(&ARRAY[0]))
|
|
|
|
|
|
|
|
|
|
/* compile-time fail if not array */
|
|
|
|
|
#define __ARRAY_FAIL(ARRAY) (sizeof(char[-2*!__ARRAY_CHECK(ARRAY)]))
|
|
|
|
|
#define __ARRAY_SIZE(ARRAY) \
|
|
|
|
|
__builtin_choose_expr(__ARRAY_CHECK(ARRAY), \
|
|
|
|
|
__ARRAY_SIZE_NOCHECK(ARRAY), __ARRAY_FAIL(ARRAY))
|
2017-11-01 14:40:27 -07:00
|
|
|
|
#elif defined(__cplusplus)
|
|
|
|
|
#define __ARRAY_SIZE(ARRAY) ( \
|
|
|
|
|
0 * sizeof(reinterpret_cast<const ::Bad_arg_to_ARRAY_SIZE *>(ARRAY)) + \
|
|
|
|
|
0 * sizeof(::Bad_arg_to_ARRAY_SIZE::check_type((ARRAY), &(ARRAY))) + \
|
|
|
|
|
sizeof(ARRAY) / sizeof((ARRAY)[0]) )
|
|
|
|
|
|
|
|
|
|
struct Bad_arg_to_ARRAY_SIZE {
|
|
|
|
|
class Is_pointer;
|
|
|
|
|
class Is_array {};
|
|
|
|
|
template <typename T>
|
|
|
|
|
static Is_pointer check_type(const T *, const T * const *);
|
|
|
|
|
static Is_array check_type(const void *, const void *);
|
|
|
|
|
};
|
2013-10-02 02:40:09 -03:00
|
|
|
|
#else
|
|
|
|
|
#define __ARRAY_SIZE(ARRAY) __ARRAY_SIZE_NOCHECK(ARRAY)
|
|
|
|
|
#endif
|
|
|
|
|
|
2013-04-25 11:18:10 -07:00
|
|
|
|
|
2014-03-11 00:10:20 -07:00
|
|
|
|
/* This system's cache line size, in bytes.
|
|
|
|
|
* Being wrong hurts performance but not correctness. */
|
2022-01-20 21:50:44 -05:00
|
|
|
|
#if defined(__ppc64__) || defined(__powerpc64__) || \
|
|
|
|
|
defined(__PPC64__) || defined(_ARCH_PPC64)
|
|
|
|
|
/* http://lists.llvm.org/pipermail/llvm-dev/2017-March/110982.html */
|
|
|
|
|
#define CACHE_LINE_SIZE 128
|
|
|
|
|
#else
|
2014-03-11 00:10:20 -07:00
|
|
|
|
#define CACHE_LINE_SIZE 64
|
2022-01-20 21:50:44 -05:00
|
|
|
|
#endif
|
2014-03-11 00:10:20 -07:00
|
|
|
|
BUILD_ASSERT_DECL(IS_POW2(CACHE_LINE_SIZE));
|
|
|
|
|
|
2017-07-25 05:14:43 +01:00
|
|
|
|
/* Cacheline marking is typically done using zero-sized array.
|
|
|
|
|
* However MSVC doesn't like zero-sized array in struct/union.
|
|
|
|
|
* C4200: https://msdn.microsoft.com/en-us/library/79wf64bc.aspx
|
|
|
|
|
*/
|
|
|
|
|
typedef uint8_t OVS_CACHE_LINE_MARKER[1];
|
|
|
|
|
|
2014-04-29 15:50:38 -07:00
|
|
|
|
static inline void
|
|
|
|
|
ovs_prefetch_range(const void *start, size_t size)
|
|
|
|
|
{
|
|
|
|
|
const char *addr = (const char *)start;
|
|
|
|
|
size_t ofs;
|
|
|
|
|
|
|
|
|
|
for (ofs = 0; ofs < size; ofs += CACHE_LINE_SIZE) {
|
|
|
|
|
OVS_PREFETCH(addr + ofs);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
#ifndef MIN
|
|
|
|
|
#define MIN(X, Y) ((X) < (Y) ? (X) : (Y))
|
|
|
|
|
#endif
|
|
|
|
|
|
|
|
|
|
#ifndef MAX
|
|
|
|
|
#define MAX(X, Y) ((X) > (Y) ? (X) : (Y))
|
|
|
|
|
#endif
|
|
|
|
|
|
2015-11-15 22:07:25 -08:00
|
|
|
|
/* Comparisons for ints with modular arithmetic */
|
|
|
|
|
#define INT_MOD_LT(a,b) ((int) ((a)-(b)) < 0)
|
|
|
|
|
#define INT_MOD_LEQ(a,b) ((int) ((a)-(b)) <= 0)
|
|
|
|
|
#define INT_MOD_GT(a,b) ((int) ((a)-(b)) > 0)
|
|
|
|
|
#define INT_MOD_GEQ(a,b) ((int) ((a)-(b)) >= 0)
|
|
|
|
|
|
|
|
|
|
#define INT_MOD_MIN(a, b) ((INT_MOD_LT(a, b)) ? (a) : (b))
|
|
|
|
|
#define INT_MOD_MAX(a, b) ((INT_MOD_GT(a, b)) ? (a) : (b))
|
|
|
|
|
|
2013-12-17 10:32:12 -08:00
|
|
|
|
#define OVS_NOT_REACHED() abort()
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2021-07-06 15:03:12 +02:00
|
|
|
|
/* Joins two token expanding the arguments if they are macros.
|
|
|
|
|
*
|
|
|
|
|
* For token concatenation the circumlocution is needed for the
|
|
|
|
|
* expansion. */
|
|
|
|
|
#define OVS_JOIN2(X, Y) X##Y
|
|
|
|
|
#define OVS_JOIN(X, Y) OVS_JOIN2(X, Y)
|
|
|
|
|
|
2013-11-25 23:38:48 -08:00
|
|
|
|
/* Use "%"PRIuSIZE to format size_t with printf(). */
|
|
|
|
|
#ifdef _WIN32
|
|
|
|
|
#define PRIdSIZE "Id"
|
|
|
|
|
#define PRIiSIZE "Ii"
|
|
|
|
|
#define PRIoSIZE "Io"
|
|
|
|
|
#define PRIuSIZE "Iu"
|
|
|
|
|
#define PRIxSIZE "Ix"
|
|
|
|
|
#define PRIXSIZE "IX"
|
|
|
|
|
#else
|
|
|
|
|
#define PRIdSIZE "zd"
|
|
|
|
|
#define PRIiSIZE "zi"
|
|
|
|
|
#define PRIoSIZE "zo"
|
|
|
|
|
#define PRIuSIZE "zu"
|
|
|
|
|
#define PRIxSIZE "zx"
|
|
|
|
|
#define PRIXSIZE "zX"
|
|
|
|
|
#endif
|
|
|
|
|
|
2014-06-13 16:03:33 -07:00
|
|
|
|
#ifndef _WIN32
|
|
|
|
|
typedef uint32_t HANDLE;
|
|
|
|
|
#endif
|
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
#ifdef __cplusplus
|
|
|
|
|
extern "C" {
|
|
|
|
|
#endif
|
|
|
|
|
|
2011-08-02 12:16:44 -07:00
|
|
|
|
#define set_program_name(name) \
|
2014-11-24 12:49:01 +01:00
|
|
|
|
ovs_set_program_name(name, OVS_PACKAGE_VERSION)
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2013-07-12 14:18:01 -07:00
|
|
|
|
const char *get_subprogram_name(void);
|
2015-06-07 09:48:14 -07:00
|
|
|
|
void set_subprogram_name(const char *);
|
2013-07-12 14:18:01 -07:00
|
|
|
|
|
2017-06-20 10:29:47 +01:00
|
|
|
|
unsigned int get_page_size(void);
|
|
|
|
|
long long int get_boot_time(void);
|
|
|
|
|
|
2018-08-14 10:53:16 +03:00
|
|
|
|
void ctl_timeout_setup(unsigned int secs);
|
|
|
|
|
|
2011-08-02 12:16:44 -07:00
|
|
|
|
void ovs_print_version(uint8_t min_ofp, uint8_t max_ofp);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2019-05-14 16:08:42 +03:00
|
|
|
|
void set_memory_locked(void);
|
|
|
|
|
bool memory_locked(void);
|
|
|
|
|
|
2014-12-15 14:10:38 +01:00
|
|
|
|
OVS_NO_RETURN void out_of_memory(void);
|
2021-03-26 11:30:23 -07:00
|
|
|
|
|
|
|
|
|
/* Allocation wrappers that abort if memory is exhausted. */
|
2009-07-08 13:19:16 -07:00
|
|
|
|
void *xmalloc(size_t) MALLOC_LIKE;
|
|
|
|
|
void *xcalloc(size_t, size_t) MALLOC_LIKE;
|
2009-09-28 13:56:42 -07:00
|
|
|
|
void *xzalloc(size_t) MALLOC_LIKE;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
void *xrealloc(void *, size_t);
|
|
|
|
|
void *xmemdup(const void *, size_t) MALLOC_LIKE;
|
|
|
|
|
char *xmemdup0(const char *, size_t) MALLOC_LIKE;
|
|
|
|
|
char *xstrdup(const char *) MALLOC_LIKE;
|
2016-06-24 21:23:16 -07:00
|
|
|
|
char *nullable_xstrdup(const char *) MALLOC_LIKE;
|
2016-07-15 14:54:53 +03:00
|
|
|
|
bool nullable_string_is_equal(const char *a, const char *b);
|
2014-12-15 14:10:38 +01:00
|
|
|
|
char *xasprintf(const char *format, ...) OVS_PRINTF_FORMAT(1, 2) MALLOC_LIKE;
|
|
|
|
|
char *xvasprintf(const char *format, va_list) OVS_PRINTF_FORMAT(1, 0) MALLOC_LIKE;
|
2009-07-08 13:19:16 -07:00
|
|
|
|
void *x2nrealloc(void *p, size_t *n, size_t s);
|
|
|
|
|
|
2021-03-26 11:30:23 -07:00
|
|
|
|
/* Allocation wrappers for specialized situations where coverage counters
|
|
|
|
|
* cannot be used. */
|
|
|
|
|
void *xmalloc__(size_t) MALLOC_LIKE;
|
|
|
|
|
void *xcalloc__(size_t, size_t) MALLOC_LIKE;
|
|
|
|
|
void *xzalloc__(size_t) MALLOC_LIKE;
|
|
|
|
|
void *xrealloc__(void *, size_t);
|
|
|
|
|
|
2014-03-11 00:11:30 -07:00
|
|
|
|
void *xmalloc_cacheline(size_t) MALLOC_LIKE;
|
|
|
|
|
void *xzalloc_cacheline(size_t) MALLOC_LIKE;
|
|
|
|
|
void free_cacheline(void *);
|
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
void ovs_strlcpy(char *dst, const char *src, size_t size);
|
2011-02-22 10:58:36 -08:00
|
|
|
|
void ovs_strzcpy(char *dst, const char *src, size_t size);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2018-01-09 07:55:37 +00:00
|
|
|
|
int string_ends_with(const char *str, const char *suffix);
|
|
|
|
|
|
2019-07-18 13:11:14 -07:00
|
|
|
|
void *xmalloc_pagealign(size_t) MALLOC_LIKE;
|
|
|
|
|
void free_pagealign(void *);
|
|
|
|
|
void *xmalloc_size_align(size_t, size_t) MALLOC_LIKE;
|
|
|
|
|
void free_size_align(void *);
|
|
|
|
|
|
2017-06-13 12:57:38 -04:00
|
|
|
|
/* The C standards say that neither the 'dst' nor 'src' argument to
|
|
|
|
|
* memcpy() may be null, even if 'n' is zero. This wrapper tolerates
|
|
|
|
|
* the null case. */
|
|
|
|
|
static inline void
|
|
|
|
|
nullable_memcpy(void *dst, const void *src, size_t n)
|
|
|
|
|
{
|
|
|
|
|
if (n) {
|
|
|
|
|
memcpy(dst, src, n);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* The C standards say that the 'dst' argument to memset may not be
|
|
|
|
|
* null, even if 'n' is zero. This wrapper tolerates the null case. */
|
|
|
|
|
static inline void
|
|
|
|
|
nullable_memset(void *dst, int c, size_t n)
|
|
|
|
|
{
|
|
|
|
|
if (n) {
|
|
|
|
|
memset(dst, c, n);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2017-04-05 22:49:27 -07:00
|
|
|
|
/* Copy string SRC to DST, but no more bytes than the shorter of DST or SRC.
|
|
|
|
|
* DST and SRC must both be char arrays, not pointers, and with GNU C, this
|
|
|
|
|
* raises a compiler error if either DST or SRC is a pointer instead of an
|
|
|
|
|
* array. */
|
|
|
|
|
#define ovs_strlcpy_arrays(DST, SRC) \
|
|
|
|
|
ovs_strlcpy(DST, SRC, MIN(ARRAY_SIZE(DST), ARRAY_SIZE(SRC)))
|
|
|
|
|
|
2014-12-15 14:10:38 +01:00
|
|
|
|
OVS_NO_RETURN void ovs_abort(int err_no, const char *format, ...)
|
|
|
|
|
OVS_PRINTF_FORMAT(2, 3);
|
|
|
|
|
OVS_NO_RETURN void ovs_abort_valist(int err_no, const char *format, va_list)
|
|
|
|
|
OVS_PRINTF_FORMAT(2, 0);
|
|
|
|
|
OVS_NO_RETURN void ovs_fatal(int err_no, const char *format, ...)
|
|
|
|
|
OVS_PRINTF_FORMAT(2, 3);
|
|
|
|
|
OVS_NO_RETURN void ovs_fatal_valist(int err_no, const char *format, va_list)
|
|
|
|
|
OVS_PRINTF_FORMAT(2, 0);
|
|
|
|
|
void ovs_error(int err_no, const char *format, ...) OVS_PRINTF_FORMAT(2, 3);
|
2011-02-23 15:43:34 -08:00
|
|
|
|
void ovs_error_valist(int err_no, const char *format, va_list)
|
2014-12-15 14:10:38 +01:00
|
|
|
|
OVS_PRINTF_FORMAT(2, 0);
|
2011-01-30 11:29:14 -08:00
|
|
|
|
const char *ovs_retval_to_string(int);
|
2013-06-19 15:44:54 -07:00
|
|
|
|
const char *ovs_strerror(int);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
void ovs_hex_dump(FILE *, const void *, size_t, uintptr_t offset, bool ascii);
|
|
|
|
|
|
|
|
|
|
bool str_to_int(const char *, int base, int *);
|
|
|
|
|
bool str_to_long(const char *, int base, long *);
|
|
|
|
|
bool str_to_llong(const char *, int base, long long *);
|
2016-12-29 15:55:46 -07:00
|
|
|
|
bool str_to_llong_with_tail(const char *, char **, int base, long long *);
|
2014-04-23 14:45:21 +01:00
|
|
|
|
bool str_to_uint(const char *, int base, unsigned int *);
|
2017-11-29 13:50:44 +03:00
|
|
|
|
bool str_to_ullong(const char *, int base, unsigned long long *);
|
2016-12-29 15:55:46 -07:00
|
|
|
|
bool str_to_llong_range(const char *, int base, long long *, long long *);
|
2009-07-08 13:19:16 -07:00
|
|
|
|
|
2014-12-15 14:10:38 +01:00
|
|
|
|
bool ovs_scan(const char *s, const char *format, ...) OVS_SCANF_FORMAT(2, 3);
|
2014-11-10 12:46:11 -08:00
|
|
|
|
bool ovs_scan_len(const char *s, int *n, const char *format, ...);
|
2013-11-15 08:54:56 -08:00
|
|
|
|
|
2009-11-04 14:55:53 -08:00
|
|
|
|
bool str_to_double(const char *, double *);
|
|
|
|
|
|
2018-02-02 15:16:22 -08:00
|
|
|
|
int hexit_value(unsigned char c);
|
2014-09-30 12:45:50 -07:00
|
|
|
|
uintmax_t hexits_value(const char *s, size_t n, bool *ok);
|
2009-11-04 14:55:53 -08:00
|
|
|
|
|
2015-05-20 18:47:21 -07:00
|
|
|
|
int parse_int_string(const char *s, uint8_t *valuep, int field_width,
|
|
|
|
|
char **tail);
|
|
|
|
|
|
2011-06-02 10:47:18 -07:00
|
|
|
|
const char *english_list_delimiter(size_t index, size_t total);
|
|
|
|
|
|
2010-03-16 15:06:11 -07:00
|
|
|
|
char *get_cwd(void);
|
2014-05-29 10:19:19 -07:00
|
|
|
|
#ifndef _WIN32
|
2009-10-19 14:04:14 -07:00
|
|
|
|
char *dir_name(const char *file_name);
|
2010-11-09 14:38:28 -08:00
|
|
|
|
char *base_name(const char *file_name);
|
2014-05-29 10:19:19 -07:00
|
|
|
|
#endif
|
2010-03-16 15:06:11 -07:00
|
|
|
|
char *abs_file_name(const char *dir, const char *file_name);
|
2018-07-24 09:48:45 -07:00
|
|
|
|
bool is_file_name_absolute(const char *);
|
2009-10-19 14:04:14 -07:00
|
|
|
|
|
2012-07-30 11:36:06 -07:00
|
|
|
|
char *follow_symlinks(const char *filename);
|
|
|
|
|
|
2010-02-11 11:11:23 -08:00
|
|
|
|
void ignore(bool x OVS_UNUSED);
|
2012-10-31 17:12:38 -07:00
|
|
|
|
|
|
|
|
|
/* Bitwise tests. */
|
2012-08-21 10:47:22 -07:00
|
|
|
|
|
2013-11-18 11:30:38 -08:00
|
|
|
|
/* Returns the number of trailing 0-bits in 'n'. Undefined if 'n' == 0. */
|
|
|
|
|
#if __GNUC__ >= 4
|
2012-08-21 10:47:22 -07:00
|
|
|
|
static inline int
|
2013-11-18 11:30:38 -08:00
|
|
|
|
raw_ctz(uint64_t n)
|
2012-08-21 10:47:22 -07:00
|
|
|
|
{
|
2013-11-18 11:30:38 -08:00
|
|
|
|
/* With GCC 4.7 on 32-bit x86, if a 32-bit integer is passed as 'n', using
|
|
|
|
|
* a plain __builtin_ctzll() here always generates an out-of-line function
|
|
|
|
|
* call. The test below helps it to emit a single 'bsf' instruction. */
|
|
|
|
|
return (__builtin_constant_p(n <= UINT32_MAX) && n <= UINT32_MAX
|
|
|
|
|
? __builtin_ctz(n)
|
|
|
|
|
: __builtin_ctzll(n));
|
2012-08-21 10:47:22 -07:00
|
|
|
|
}
|
2013-12-03 13:41:41 -08:00
|
|
|
|
|
|
|
|
|
static inline int
|
|
|
|
|
raw_clz64(uint64_t n)
|
|
|
|
|
{
|
|
|
|
|
return __builtin_clzll(n);
|
|
|
|
|
}
|
2014-10-03 12:00:11 -07:00
|
|
|
|
#elif _MSC_VER
|
|
|
|
|
static inline int
|
|
|
|
|
raw_ctz(uint64_t n)
|
|
|
|
|
{
|
|
|
|
|
#ifdef _WIN64
|
2015-02-12 10:53:10 -08:00
|
|
|
|
unsigned long r = 0;
|
2014-10-03 12:00:11 -07:00
|
|
|
|
_BitScanForward64(&r, n);
|
|
|
|
|
return r;
|
|
|
|
|
#else
|
2015-02-12 10:53:10 -08:00
|
|
|
|
unsigned long low = n, high, r = 0;
|
2014-10-03 12:00:11 -07:00
|
|
|
|
if (_BitScanForward(&r, low)) {
|
|
|
|
|
return r;
|
|
|
|
|
}
|
|
|
|
|
high = n >> 32;
|
|
|
|
|
_BitScanForward(&r, high);
|
|
|
|
|
return r + 32;
|
|
|
|
|
#endif
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static inline int
|
|
|
|
|
raw_clz64(uint64_t n)
|
|
|
|
|
{
|
|
|
|
|
#ifdef _WIN64
|
2015-02-12 10:53:10 -08:00
|
|
|
|
unsigned long r = 0;
|
2014-10-03 12:00:11 -07:00
|
|
|
|
_BitScanReverse64(&r, n);
|
|
|
|
|
return 63 - r;
|
|
|
|
|
#else
|
2015-02-12 10:53:10 -08:00
|
|
|
|
unsigned long low, high = n >> 32, r = 0;
|
2014-10-03 12:00:11 -07:00
|
|
|
|
if (_BitScanReverse(&r, high)) {
|
|
|
|
|
return 31 - r;
|
|
|
|
|
}
|
|
|
|
|
low = n;
|
|
|
|
|
_BitScanReverse(&r, low);
|
|
|
|
|
return 63 - r;
|
|
|
|
|
#endif
|
|
|
|
|
}
|
2012-08-21 10:47:22 -07:00
|
|
|
|
#else
|
|
|
|
|
/* Defined in util.c. */
|
2013-11-18 11:30:38 -08:00
|
|
|
|
int raw_ctz(uint64_t n);
|
2013-12-03 13:41:41 -08:00
|
|
|
|
int raw_clz64(uint64_t n);
|
2012-08-21 10:47:22 -07:00
|
|
|
|
#endif
|
|
|
|
|
|
|
|
|
|
/* Returns the number of trailing 0-bits in 'n', or 32 if 'n' is 0. */
|
|
|
|
|
static inline int
|
2013-12-03 13:41:41 -08:00
|
|
|
|
ctz32(uint32_t n)
|
2012-08-21 10:47:22 -07:00
|
|
|
|
{
|
|
|
|
|
return n ? raw_ctz(n) : 32;
|
|
|
|
|
}
|
|
|
|
|
|
2013-11-18 09:28:44 -08:00
|
|
|
|
/* Returns the number of trailing 0-bits in 'n', or 64 if 'n' is 0. */
|
|
|
|
|
static inline int
|
|
|
|
|
ctz64(uint64_t n)
|
|
|
|
|
{
|
2013-11-18 11:30:38 -08:00
|
|
|
|
return n ? raw_ctz(n) : 64;
|
2013-11-18 09:28:44 -08:00
|
|
|
|
}
|
2009-12-14 23:08:10 -08:00
|
|
|
|
|
2013-12-03 13:41:41 -08:00
|
|
|
|
/* Returns the number of leading 0-bits in 'n', or 32 if 'n' is 0. */
|
|
|
|
|
static inline int
|
|
|
|
|
clz32(uint32_t n)
|
|
|
|
|
{
|
|
|
|
|
return n ? raw_clz64(n) - 32 : 32;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Returns the number of leading 0-bits in 'n', or 64 if 'n' is 0. */
|
|
|
|
|
static inline int
|
|
|
|
|
clz64(uint64_t n)
|
|
|
|
|
{
|
|
|
|
|
return n ? raw_clz64(n) : 64;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Given a word 'n', calculates floor(log_2('n')). This is equivalent
|
|
|
|
|
* to finding the bit position of the most significant one bit in 'n'. It is
|
|
|
|
|
* an error to call this function with 'n' == 0. */
|
|
|
|
|
static inline int
|
|
|
|
|
log_2_floor(uint64_t n)
|
|
|
|
|
{
|
|
|
|
|
return 63 - raw_clz64(n);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Given a word 'n', calculates ceil(log_2('n')). It is an error to
|
|
|
|
|
* call this function with 'n' == 0. */
|
|
|
|
|
static inline int
|
|
|
|
|
log_2_ceil(uint64_t n)
|
|
|
|
|
{
|
|
|
|
|
return log_2_floor(n) + !is_pow2(n);
|
|
|
|
|
}
|
|
|
|
|
|
2013-12-12 08:27:41 -08:00
|
|
|
|
/* unsigned int count_1bits(uint64_t x):
|
|
|
|
|
*
|
|
|
|
|
* Returns the number of 1-bits in 'x', between 0 and 64 inclusive. */
|
|
|
|
|
#if UINTPTR_MAX == UINT64_MAX
|
|
|
|
|
static inline unsigned int
|
|
|
|
|
count_1bits(uint64_t x)
|
|
|
|
|
{
|
2019-06-13 18:38:07 +08:00
|
|
|
|
#if (__GNUC__ >= 4 && __POPCNT__) || (defined(__aarch64__) && __GNUC__ >= 7)
|
2013-12-12 08:27:41 -08:00
|
|
|
|
return __builtin_popcountll(x);
|
2019-06-13 18:38:07 +08:00
|
|
|
|
#elif defined(__aarch64__) && __GNUC__ >= 6
|
|
|
|
|
return vaddv_u8(vcnt_u8(vcreate_u8(x)));
|
2013-12-12 08:27:41 -08:00
|
|
|
|
#else
|
|
|
|
|
/* This portable implementation is the fastest one we know of for 64
|
|
|
|
|
* bits, and about 3x faster than GCC 4.7 __builtin_popcountll(). */
|
|
|
|
|
const uint64_t h55 = UINT64_C(0x5555555555555555);
|
|
|
|
|
const uint64_t h33 = UINT64_C(0x3333333333333333);
|
|
|
|
|
const uint64_t h0F = UINT64_C(0x0F0F0F0F0F0F0F0F);
|
|
|
|
|
const uint64_t h01 = UINT64_C(0x0101010101010101);
|
|
|
|
|
x -= (x >> 1) & h55; /* Count of each 2 bits in-place. */
|
|
|
|
|
x = (x & h33) + ((x >> 2) & h33); /* Count of each 4 bits in-place. */
|
|
|
|
|
x = (x + (x >> 4)) & h0F; /* Count of each 8 bits in-place. */
|
|
|
|
|
return (x * h01) >> 56; /* Sum of all bytes. */
|
|
|
|
|
#endif
|
|
|
|
|
}
|
|
|
|
|
#else /* Not 64-bit. */
|
|
|
|
|
#if __GNUC__ >= 4 && __POPCNT__
|
2013-11-27 12:58:46 -08:00
|
|
|
|
static inline unsigned int
|
2013-12-12 08:27:41 -08:00
|
|
|
|
count_1bits_32__(uint32_t x)
|
2013-11-27 12:58:46 -08:00
|
|
|
|
{
|
|
|
|
|
return __builtin_popcount(x);
|
2013-12-12 08:27:41 -08:00
|
|
|
|
}
|
2013-11-27 12:58:46 -08:00
|
|
|
|
#else
|
2013-12-12 08:27:41 -08:00
|
|
|
|
#define NEED_COUNT_1BITS_8 1
|
|
|
|
|
extern const uint8_t count_1bits_8[256];
|
|
|
|
|
static inline unsigned int
|
|
|
|
|
count_1bits_32__(uint32_t x)
|
|
|
|
|
{
|
2013-11-27 12:58:46 -08:00
|
|
|
|
/* This portable implementation is the fastest one we know of for 32 bits,
|
|
|
|
|
* and faster than GCC __builtin_popcount(). */
|
|
|
|
|
return (count_1bits_8[x & 0xff] +
|
|
|
|
|
count_1bits_8[(x >> 8) & 0xff] +
|
|
|
|
|
count_1bits_8[(x >> 16) & 0xff] +
|
|
|
|
|
count_1bits_8[x >> 24]);
|
|
|
|
|
}
|
2013-12-12 08:27:41 -08:00
|
|
|
|
#endif
|
2013-11-27 12:58:46 -08:00
|
|
|
|
static inline unsigned int
|
|
|
|
|
count_1bits(uint64_t x)
|
|
|
|
|
{
|
2013-12-12 08:27:41 -08:00
|
|
|
|
return count_1bits_32__(x) + count_1bits_32__(x >> 32);
|
2013-11-27 12:58:46 -08:00
|
|
|
|
}
|
2013-12-12 08:27:41 -08:00
|
|
|
|
#endif
|
2013-12-03 13:41:41 -08:00
|
|
|
|
|
2012-10-31 17:12:38 -07:00
|
|
|
|
/* Returns the rightmost 1-bit in 'x' (e.g. 01011000 => 00001000), or 0 if 'x'
|
|
|
|
|
* is 0. */
|
|
|
|
|
static inline uintmax_t
|
|
|
|
|
rightmost_1bit(uintmax_t x)
|
|
|
|
|
{
|
|
|
|
|
return x & -x;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Returns 'x' with its rightmost 1-bit changed to a zero (e.g. 01011000 =>
|
|
|
|
|
* 01010000), or 0 if 'x' is 0. */
|
|
|
|
|
static inline uintmax_t
|
|
|
|
|
zero_rightmost_1bit(uintmax_t x)
|
|
|
|
|
{
|
|
|
|
|
return x & (x - 1);
|
|
|
|
|
}
|
2012-10-31 17:13:27 -07:00
|
|
|
|
|
2015-09-18 15:26:28 -07:00
|
|
|
|
/* Returns the index of the rightmost 1-bit in 'x' (e.g. 01011000 => 3), or an
|
|
|
|
|
* undefined value if 'x' is 0. */
|
2014-10-07 14:35:04 -07:00
|
|
|
|
static inline int
|
2015-09-18 15:26:28 -07:00
|
|
|
|
rightmost_1bit_idx(uint64_t x)
|
2012-10-31 17:13:27 -07:00
|
|
|
|
{
|
2015-09-18 15:26:28 -07:00
|
|
|
|
return ctz64(x);
|
2012-10-31 17:13:27 -07:00
|
|
|
|
}
|
|
|
|
|
|
2015-09-18 15:26:28 -07:00
|
|
|
|
/* Returns the index of the leftmost 1-bit in 'x' (e.g. 01011000 => 6), or an
|
|
|
|
|
* undefined value if 'x' is 0. */
|
2012-10-31 17:13:27 -07:00
|
|
|
|
static inline uint32_t
|
2015-09-18 15:26:28 -07:00
|
|
|
|
leftmost_1bit_idx(uint64_t x)
|
2012-10-31 17:13:27 -07:00
|
|
|
|
{
|
2015-09-18 15:26:28 -07:00
|
|
|
|
return log_2_floor(x);
|
2012-10-31 17:13:27 -07:00
|
|
|
|
}
|
2014-11-11 15:50:51 -08:00
|
|
|
|
|
|
|
|
|
/* Return a ovs_be32 prefix in network byte order with 'plen' highest bits set.
|
|
|
|
|
* Shift with 32 is undefined behavior, but we rather use 64-bit shift than
|
|
|
|
|
* compare. */
|
|
|
|
|
static inline ovs_be32 be32_prefix_mask(int plen)
|
|
|
|
|
{
|
|
|
|
|
return htonl((uint64_t)UINT32_MAX << (32 - plen));
|
|
|
|
|
}
|
2012-10-31 17:12:38 -07:00
|
|
|
|
|
2018-08-29 11:30:13 -07:00
|
|
|
|
/* Returns true if the 1-bits in 'super' are a superset of the 1-bits in 'sub',
|
|
|
|
|
* false otherwise. */
|
|
|
|
|
static inline bool
|
|
|
|
|
uint_is_superset(uintmax_t super, uintmax_t sub)
|
|
|
|
|
{
|
|
|
|
|
return (super & sub) == sub;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Returns true if the 1-bits in 'super' are a superset of the 1-bits in 'sub',
|
|
|
|
|
* false otherwise. */
|
|
|
|
|
static inline bool
|
|
|
|
|
be16_is_superset(ovs_be16 super, ovs_be16 sub)
|
|
|
|
|
{
|
|
|
|
|
return (super & sub) == sub;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Returns true if the 1-bits in 'super' are a superset of the 1-bits in 'sub',
|
|
|
|
|
* false otherwise. */
|
|
|
|
|
static inline bool
|
|
|
|
|
be32_is_superset(ovs_be32 super, ovs_be32 sub)
|
|
|
|
|
{
|
|
|
|
|
return (super & sub) == sub;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Returns true if the 1-bits in 'super' are a superset of the 1-bits in 'sub',
|
|
|
|
|
* false otherwise. */
|
|
|
|
|
static inline bool
|
|
|
|
|
be64_is_superset(ovs_be64 super, ovs_be64 sub)
|
|
|
|
|
{
|
|
|
|
|
return (super & sub) == sub;
|
|
|
|
|
}
|
|
|
|
|
|
2014-09-05 15:44:19 -07:00
|
|
|
|
bool is_all_zeros(const void *, size_t);
|
|
|
|
|
bool is_all_ones(const void *, size_t);
|
2017-07-31 10:07:50 -07:00
|
|
|
|
bool is_all_byte(const void *, size_t, uint8_t byte);
|
odp-util: Fix clearing match mask if set action is partially unnecessary.
While committing set() actions, commit() could wildcard all the fields
that are same in match key and in the set action. This leads to
situation where mask after commit could actually contain less bits
than it was before. And if set action was partially committed, all
the fields that were the same will be cleared out from the matching key
resulting in the incorrect (too wide) flow.
For example, for the flow that matches on both src and dst mac
addresses, if the dst mac is the same and only src should be changed
by the set() action, destination address will be wildcarded in the
match key and will never be matched, i.e. flows with any destination
mac will match, which is not correct.
Setting OF rule:
in_port=1,dl_src=50:54:00:00:00:09 actions=mod_dl_dst(50:54:00:00:00:0a),output(2)
Sending following packets on port 1:
1. eth(src=50:54:00:00:00:09,dst=50:54:00:00:00:0a),eth_type(0x0800)
2. eth(src=50:54:00:00:00:09,dst=50:54:00:00:00:0c),eth_type(0x0800)
3. eth(src=50:54:00:00:00:0b,dst=50:54:00:00:00:0c),eth_type(0x0800)
Resulted datapath flows:
eth(dst=50:54:00:00:00:0c),<...>, actions:set(eth(dst=50:54:00:00:00:0a)),2
eth(src=50:54:00:00:00:09,dst=50:54:00:00:00:0a),<...>, actions:2
The first flow doesn't have any match on source MAC address and the
third packet successfully matched on it while it must be dropped.
Fix that by updating the match mask with only the new bits set by
commit(), but keeping those that were cleared (OR operation).
With fix applied, resulted correct flows are:
eth(src=50:54:00:00:00:09,dst=50:54:00:00:00:0a),<...>, actions:2
eth(src=50:54:00:00:00:09,dst=50:54:00:00:00:0c),<...>,
actions:set(eth(dst=50:54:00:00:00:0a)),2
eth(src=50:54:00:00:00:0b),<...>, actions:drop
The code before commit dbf4a92800d0 was not able to reduce the mask,
it was only possible to expand it to exact match, so it was OK to
update original matching mask with the new value in all cases.
Fixes: dbf4a92800d0 ("odp-util: Do not rewrite fields with the same values as matched")
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1854376
Acked-by: Eli Britstein <elibr@mellanox.com>
Tested-by: Adrián Moreno <amorenoz@redhat.com>
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
2020-07-27 17:41:35 +02:00
|
|
|
|
void or_bytes(void *dst, const void *src, size_t n);
|
2012-01-17 16:38:23 -08:00
|
|
|
|
void bitwise_copy(const void *src, unsigned int src_len, unsigned int src_ofs,
|
|
|
|
|
void *dst, unsigned int dst_len, unsigned int dst_ofs,
|
|
|
|
|
unsigned int n_bits);
|
2012-01-17 16:53:29 -08:00
|
|
|
|
void bitwise_zero(void *dst_, unsigned int dst_len, unsigned dst_ofs,
|
|
|
|
|
unsigned int n_bits);
|
2012-04-11 12:07:51 -07:00
|
|
|
|
void bitwise_one(void *dst_, unsigned int dst_len, unsigned dst_ofs,
|
|
|
|
|
unsigned int n_bits);
|
2012-04-13 21:12:37 -07:00
|
|
|
|
bool bitwise_is_all_zeros(const void *, unsigned int len, unsigned int ofs,
|
|
|
|
|
unsigned int n_bits);
|
2014-09-02 17:16:51 -07:00
|
|
|
|
unsigned int bitwise_scan(const void *, unsigned int len,
|
|
|
|
|
bool target, unsigned int start, unsigned int end);
|
2015-04-15 15:21:00 -07:00
|
|
|
|
int bitwise_rscan(const void *, unsigned int len, bool target,
|
|
|
|
|
int start, int end);
|
2012-01-17 16:38:23 -08:00
|
|
|
|
void bitwise_put(uint64_t value,
|
|
|
|
|
void *dst, unsigned int dst_len, unsigned int dst_ofs,
|
|
|
|
|
unsigned int n_bits);
|
|
|
|
|
uint64_t bitwise_get(const void *src, unsigned int src_len,
|
|
|
|
|
unsigned int src_ofs, unsigned int n_bits);
|
2015-04-15 15:21:00 -07:00
|
|
|
|
bool bitwise_get_bit(const void *src, unsigned int len, unsigned int ofs);
|
|
|
|
|
void bitwise_put0(void *dst, unsigned int len, unsigned int ofs);
|
|
|
|
|
void bitwise_put1(void *dst, unsigned int len, unsigned int ofs);
|
|
|
|
|
void bitwise_put_bit(void *dst, unsigned int len, unsigned int ofs, bool);
|
|
|
|
|
void bitwise_toggle_bit(void *dst, unsigned int len, unsigned int ofs);
|
2011-09-12 16:19:57 -07:00
|
|
|
|
|
2015-05-29 16:17:01 -07:00
|
|
|
|
/* Returns non-zero if the parameters have equal value. */
|
|
|
|
|
static inline int
|
2016-05-03 18:20:51 -07:00
|
|
|
|
ovs_u128_equals(const ovs_u128 a, const ovs_u128 b)
|
2015-05-29 16:17:01 -07:00
|
|
|
|
{
|
2016-05-03 18:20:51 -07:00
|
|
|
|
return (a.u64.hi == b.u64.hi) && (a.u64.lo == b.u64.lo);
|
2015-05-29 16:17:01 -07:00
|
|
|
|
}
|
|
|
|
|
|
2015-09-22 23:24:11 -07:00
|
|
|
|
/* Returns true if 'val' is 0. */
|
|
|
|
|
static inline bool
|
2016-05-03 18:20:51 -07:00
|
|
|
|
ovs_u128_is_zero(const ovs_u128 val)
|
2015-09-22 23:24:11 -07:00
|
|
|
|
{
|
2016-05-03 18:20:51 -07:00
|
|
|
|
return !(val.u64.hi || val.u64.lo);
|
2015-09-22 23:24:11 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Returns true if 'val' is all ones. */
|
|
|
|
|
static inline bool
|
2016-05-03 18:20:51 -07:00
|
|
|
|
ovs_u128_is_ones(const ovs_u128 val)
|
2015-09-22 23:24:11 -07:00
|
|
|
|
{
|
2016-05-03 18:20:51 -07:00
|
|
|
|
return ovs_u128_equals(val, OVS_U128_MAX);
|
2015-09-22 23:24:11 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Returns non-zero if the parameters have equal value. */
|
|
|
|
|
static inline int
|
2016-05-03 18:20:51 -07:00
|
|
|
|
ovs_be128_equals(const ovs_be128 a, const ovs_be128 b)
|
2015-09-22 23:24:11 -07:00
|
|
|
|
{
|
2016-05-03 18:20:51 -07:00
|
|
|
|
return (a.be64.hi == b.be64.hi) && (a.be64.lo == b.be64.lo);
|
2015-09-22 23:24:11 -07:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/* Returns true if 'val' is 0. */
|
|
|
|
|
static inline bool
|
2016-05-03 18:20:51 -07:00
|
|
|
|
ovs_be128_is_zero(const ovs_be128 val)
|
2015-09-22 23:24:11 -07:00
|
|
|
|
{
|
2016-05-03 18:20:51 -07:00
|
|
|
|
return !(val.be64.hi || val.be64.lo);
|
2015-09-22 23:24:11 -07:00
|
|
|
|
}
|
|
|
|
|
|
ofproto-dpif-xlate: xlate ct_{mark, label} correctly.
When translating multiple ct actions in a row which include modification
of ct_mark or ct_labels, these fields could be incorrectly translated
into datapath actions, resulting in modification of these fields for
entries when the OpenFlow rules didn't actually specify the change.
For instance, the following OpenFlow actions:
ct(zone=1,commit,exec(set_field(1->ct_mark))),ct(zone=2,table=1),...
Would translate into the datapath actions:
ct(zone=1,commit,mark=1),ct(zone=2,mark=1),recirc(...),...
This commit fixes the issue by zeroing the wildcards for these fields
prior to performing nested actions translation (and restoring
afterwards). As such, these fields do not hold both the match and the
field modification values at the same time. As a result, the ct_mark and
ct_labels don't leak from one ct action to the next.
Fixes: 8e53fe8cf7a1 ("Add connection tracking mark support.")
Fixes: 9daf23484fb1 ("Add connection tracking label support.")
Signed-off-by: Joe Stringer <joe@ovn.org>
Acked-by: Ben Pfaff <blp@ovn.org>
2016-04-15 11:36:04 -07:00
|
|
|
|
static inline ovs_u128
|
|
|
|
|
ovs_u128_and(const ovs_u128 a, const ovs_u128 b)
|
|
|
|
|
{
|
|
|
|
|
ovs_u128 dst;
|
|
|
|
|
|
|
|
|
|
dst.u64.hi = a.u64.hi & b.u64.hi;
|
|
|
|
|
dst.u64.lo = a.u64.lo & b.u64.lo;
|
|
|
|
|
|
|
|
|
|
return dst;
|
|
|
|
|
}
|
|
|
|
|
|
2018-08-29 11:30:13 -07:00
|
|
|
|
static inline bool
|
|
|
|
|
ovs_be128_is_superset(ovs_be128 super, ovs_be128 sub)
|
|
|
|
|
{
|
|
|
|
|
return (be64_is_superset(super.be64.hi, sub.be64.hi) &&
|
|
|
|
|
be64_is_superset(super.be64.lo, sub.be64.lo));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static inline bool
|
|
|
|
|
ovs_u128_is_superset(ovs_u128 super, ovs_u128 sub)
|
|
|
|
|
{
|
|
|
|
|
return (uint_is_superset(super.u64.hi, sub.u64.hi) &&
|
|
|
|
|
uint_is_superset(super.u64.lo, sub.u64.lo));
|
|
|
|
|
}
|
|
|
|
|
|
2014-03-28 15:15:02 -07:00
|
|
|
|
void xsleep(unsigned int seconds);
|
2017-11-28 22:02:06 +00:00
|
|
|
|
void xnanosleep(uint64_t nanoseconds);
|
2023-01-11 09:35:00 +00:00
|
|
|
|
void xnanosleep_no_quiesce(uint64_t nanoseconds);
|
2014-04-29 15:50:38 -07:00
|
|
|
|
|
2016-03-02 15:56:16 +01:00
|
|
|
|
bool is_stdout_a_tty(void);
|
|
|
|
|
|
2014-01-16 13:49:38 -08:00
|
|
|
|
#ifdef _WIN32
|
|
|
|
|
|
2014-02-14 08:12:32 -08:00
|
|
|
|
char *ovs_format_message(int error);
|
2014-01-16 13:49:38 -08:00
|
|
|
|
char *ovs_lasterror_to_string(void);
|
2014-03-10 08:37:21 -07:00
|
|
|
|
int ftruncate(int fd, off_t length);
|
2014-01-16 13:49:38 -08:00
|
|
|
|
#endif
|
|
|
|
|
|
2009-07-08 13:19:16 -07:00
|
|
|
|
#ifdef __cplusplus
|
|
|
|
|
}
|
|
|
|
|
#endif
|
|
|
|
|
|
|
|
|
|
#endif /* util.h */
|