mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-08-30 22:05:19 +00:00
Code Issues Releases Wiki Activity

netdev-linux: favor netlink stats for physical ports

Browse Source 
Currently physical ports stats are collected from kernel datapath.
However, those counter do not reflect actual wire packet counters
when GSO, TSO or GRO are enabled by the NIC. In the meantime, the
stats collected form routing stack does. While both stats are valid,
Reporting kernel netdev stats for packet counts and byte counts make
it easier to correlate those numbers with external measurements.

Signed-off-by: Andy Zhou <azhou@nicira.com>
Acked-by: Ben Pfaff <blp@nicira.com>
This commit is contained in:
Andy Zhou
2014-04-28 15:46:30 -07:00
parent 41ca1e0afb
commit 04c881eb64
1 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
lib/netdev-linux.c
View File

@@ -1563,9 +1563,17 @@ netdev_linux_get_stats(const struct netdev *netdev_,
error = 0;
}
} else if (netdev->vport_stats_error) {
/* stats not available from OVS then use ioctl stats. */
/* stats not available from OVS then use netdev stats. */
*stats = dev_stats;
} else {
/* Use kernel netdev's packet and byte counts since vport's counters
* do not reflect packet counts on the wire when GSO, TSO or GRO are
* enabled. */
stats->rx_packets = dev_stats.rx_packets;
stats->rx_bytes = dev_stats.rx_bytes;
stats->tx_packets = dev_stats.tx_packets;
stats->tx_bytes = dev_stats.tx_bytes;
stats->rx_errors += dev_stats.rx_errors;
stats->tx_errors += dev_stats.tx_errors;
stats->rx_dropped += dev_stats.rx_dropped;
@@ -1629,6 +1637,14 @@ netdev_tap_get_stats(const struct netdev *netdev_, struct netdev_stats *stats)
stats->tx_heartbeat_errors = 0;
stats->tx_window_errors = 0;
} else {
/* Use kernel netdev's packet and byte counts since vport counters
* do not reflect packet counts on the wire when GSO, TSO or GRO
* are enabled. */
stats->rx_packets = dev_stats.tx_packets;
stats->rx_bytes = dev_stats.tx_bytes;
stats->tx_packets = dev_stats.rx_packets;
stats->tx_bytes = dev_stats.rx_bytes;
stats->rx_dropped += dev_stats.tx_dropped;
stats->tx_dropped += dev_stats.rx_dropped;