mir/ovs
2
0
Fork 0
mirror of https://github.com/openvswitch/ovs synced 2025-09-02 15:25:22 +00:00
Code Issues Releases Wiki Activity

python: Remove unnecessary semicolons and slashes.

Browse Source 
Resolve the following flake8 errors:

  E703 statement ends with a semicolon
  E502 the backslash is redundant between brackets

Also document the reamining flake8 errors that are still ignored.

Signed-off-by: Russell Bryant <russell@ovn.org>
Acked-by: Ben Pfaff <blp@ovn.org>
This commit is contained in:
Russell Bryant
2015-12-22 11:41:21 -05:00
parent 603e325fa5
commit 080793b752
3 changed files with 16 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
Makefile.am
View File

@@ -342,8 +342,18 @@ endif
if HAVE_FLAKE8 if HAVE_FLAKE8
ALL_LOCAL += flake8-check ALL_LOCAL += flake8-check
# E111 indentation is not a multiple of four
# E112 expected an indented block
# E113 unexpected indentation
# E123 closing bracket does not match indentation of opening bracket's line
# E126 continuation line over-indented for hanging indent
# E127 continuation line over-indented for visual indent
# E128 continuation line under-indented for visual indent
# E129 visually indented line with same indent as next logical line
# E131 continuation line unaligned for hanging indent
# E501 line too long (80 > 79 characters)
flake8-check: $(FLAKE8_PYFILES) flake8-check: $(FLAKE8_PYFILES)
$(AM_V_GEN) if flake8 $^ --ignore=E111,E112,E113,E123,E126,E127,E128,E129,E131,E501,E502,E703 ${FLAKE8_FLAGS}; then touch $@; else exit 1; fi $(AM_V_GEN) if flake8 $^ --ignore=E111,E112,E113,E123,E126,E127,E128,E129,E131,E501 ${FLAKE8_FLAGS}; then touch $@; else exit 1; fi
endif endif
include $(srcdir)/manpages.mk include $(srcdir)/manpages.mk

6
vtep/ovs-vtep
View File

@@ -165,7 +165,7 @@ class Logical_Switch(object):
def del_lbinding(self, lbinding): def del_lbinding(self, lbinding):
vlog.info("removing %s binding from %s" % (lbinding, self.name)) vlog.info("removing %s binding from %s" % (lbinding, self.name))
port_no = self.ports[lbinding] port_no = self.ports[lbinding]
ovs_ofctl("del-flows %s in_port=%s" % (self.short_name, port_no)); ovs_ofctl("del-flows %s in_port=%s" % (self.short_name, port_no))
del self.ports[lbinding] del self.ports[lbinding]
self.update_flood() self.update_flood()
@@ -520,8 +520,8 @@ def add_binding(binding, ls):
# Create a logical_bindings_stats record. # Create a logical_bindings_stats record.
if not vlan_: if not vlan_:
vlan_ = "0" vlan_ = "0"
vtep_ctl("set physical_port %s vlan_stats:%s=@stats --\ vtep_ctl("set physical_port %s vlan_stats:%s=@stats -- "
--id=@stats create logical_binding_stats packets_from_local=0"\ "--id=@stats create logical_binding_stats packets_from_local=0"
% (pp_name, vlan_)) % (pp_name, vlan_))
ls.add_lbinding(lbinding) ls.add_lbinding(lbinding)

2
xenserver/usr_share_openvswitch_scripts_ovs-xapi-sync
View File

@@ -267,7 +267,7 @@ def main():
while True: while True:
unixctl_server.run() unixctl_server.run()
if exiting: if exiting:
break; break
idl.run() idl.run()
if not xapi_down and not flush_cache and seqno == idl.change_seqno: if not xapi_down and not flush_cache and seqno == idl.change_seqno: